Re: dcache shrink list corruption?

2014-05-02 Thread Szeredi Miklos
On Fri, May 2, 2014 at 7:51 AM, Al Viro wrote: > On Wed, Apr 30, 2014 at 11:15:15AM +0200, Miklos Szeredi wrote: >> IBM is triggering this with the host01 test from the LTP suite. I haven't >> yet >> tried to reproduce it. > > Could you repost their report? So far I hadn't managed to get

Re: dcache shrink list corruption?

2014-05-02 Thread Szeredi Miklos
On Thu, May 1, 2014 at 4:34 PM, Al Viro wrote: > On Thu, May 01, 2014 at 11:42:52AM +0200, Miklos Szeredi wrote: >> - "bool foo = flag & FLAG" looks suspicious. Is this guaranteed not to >> overflow? > > What do you mean, overflow? It's not a 1-bit unsigned int; conversion to > _Bool is

Re: dcache shrink list corruption?

2014-05-02 Thread Szeredi Miklos
On Thu, May 1, 2014 at 4:34 PM, Al Viro v...@zeniv.linux.org.uk wrote: On Thu, May 01, 2014 at 11:42:52AM +0200, Miklos Szeredi wrote: - bool foo = flag FLAG looks suspicious. Is this guaranteed not to overflow? What do you mean, overflow? It's not a 1-bit unsigned int; conversion to

Re: dcache shrink list corruption?

2014-05-02 Thread Szeredi Miklos
On Fri, May 2, 2014 at 7:51 AM, Al Viro v...@zeniv.linux.org.uk wrote: On Wed, Apr 30, 2014 at 11:15:15AM +0200, Miklos Szeredi wrote: IBM is triggering this with the host01 test from the LTP suite. I haven't yet tried to reproduce it. Could you repost their report? So far I hadn't

Re: [RFC 3/3] asm-generic: Drop renameat syscall from default list

2014-04-29 Thread Szeredi Miklos
On Wed, Apr 23, 2014 at 2:41 PM, James Hogan wrote: > It appears Miklos Szeredi beat me to it with patch 1 (adding renameat2 > syscall to asm-generic unistd.h), and will be submitting it to Linus > at some point as part of his renameat2 series. > Miklos: Do you think it makes sense for you to

Re: [RFC 3/3] asm-generic: Drop renameat syscall from default list

2014-04-29 Thread Szeredi Miklos
On Wed, Apr 23, 2014 at 2:41 PM, James Hogan james.ho...@imgtec.com wrote: It appears Miklos Szeredi beat me to it with patch 1 (adding renameat2 syscall to asm-generic unistd.h), and will be submitting it to Linus at some point as part of his renameat2 series. Miklos: Do you think it makes

Re: [RFC] extending splice for copy offloading

2013-09-20 Thread Szeredi Miklos
On Wed, Sep 11, 2013 at 7:06 PM, Zach Brown wrote: > > When I first started on this stuff I followed the lead of previous > work and added a new syscall for the copy operation: > > https://lkml.org/lkml/2013/5/14/618 > > Towards the end of that thread Eric Wong asked why we didn't just > extend

Re: [RFC] extending splice for copy offloading

2013-09-20 Thread Szeredi Miklos
On Wed, Sep 11, 2013 at 7:06 PM, Zach Brown z...@redhat.com wrote: When I first started on this stuff I followed the lead of previous work and added a new syscall for the copy operation: https://lkml.org/lkml/2013/5/14/618 Towards the end of that thread Eric Wong asked why we didn't just