Re: pahole + BTF was: Re: [Question] bpf: about a new 'tools/bpf/bpf_dwarf2btf'

On 07/26/2018 03:27 AM, Taeung Song wrote: Hi Arnaldo, On 07/26/2018 02:52 AM, Arnaldo Carvalho de Melo wrote: Em Thu, Jul 26, 2018 at 02:23:32AM +0900, Taeung Song escreveu: Hi, Building bpf programs with .BTF section, I thought it'd be better to convert dwarf info to .BTF by a new tool

Re: pahole + BTF was: Re: [Question] bpf: about a new 'tools/bpf/bpf_dwarf2btf'

On 07/26/2018 03:27 AM, Taeung Song wrote: Hi Arnaldo, On 07/26/2018 02:52 AM, Arnaldo Carvalho de Melo wrote: Em Thu, Jul 26, 2018 at 02:23:32AM +0900, Taeung Song escreveu: Hi, Building bpf programs with .BTF section, I thought it'd be better to convert dwarf info to .BTF by a new tool

Re: pahole + BTF was: Re: [Question] bpf: about a new 'tools/bpf/bpf_dwarf2btf'

Hi Arnaldo, On 07/26/2018 02:52 AM, Arnaldo Carvalho de Melo wrote: Em Thu, Jul 26, 2018 at 02:23:32AM +0900, Taeung Song escreveu: Hi, Building bpf programs with .BTF section, I thought it'd be better to convert dwarf info to .BTF by a new tool such as 'tools/bpf/bpf_dwarf2btf' instead

Re: pahole + BTF was: Re: [Question] bpf: about a new 'tools/bpf/bpf_dwarf2btf'

Hi Arnaldo, On 07/26/2018 02:52 AM, Arnaldo Carvalho de Melo wrote: Em Thu, Jul 26, 2018 at 02:23:32AM +0900, Taeung Song escreveu: Hi, Building bpf programs with .BTF section, I thought it'd be better to convert dwarf info to .BTF by a new tool such as 'tools/bpf/bpf_dwarf2btf' instead

[Question] bpf: about a new 'tools/bpf/bpf_dwarf2btf'

Hi, Building bpf programs with .BTF section, I thought it'd be better to convert dwarf info to .BTF by a new tool such as 'tools/bpf/bpf_dwarf2btf' instead of pahole in the future. Currently for bpf binary that have .BTF section, we need to use pahole from

[Question] bpf: about a new 'tools/bpf/bpf_dwarf2btf'

Hi, Building bpf programs with .BTF section, I thought it'd be better to convert dwarf info to .BTF by a new tool such as 'tools/bpf/bpf_dwarf2btf' instead of pahole in the future. Currently for bpf binary that have .BTF section, we need to use pahole from

[PATCH] samples/bpf: Add BTF build flags to Makefile

To smoothly test BTF supported binary on samples/bpf, let samples/bpf/Makefile probe llc, pahole and llvm-objcopy for BPF support and use them like tools/testing/selftests/bpf/Makefile changed from the commit c0fa1b6c3efc ("bpf: btf: Add BTF tests") Cc: Martin KaFai Lau Signed-off-

[PATCH] samples/bpf: Add BTF build flags to Makefile

To smoothly test BTF supported binary on samples/bpf, let samples/bpf/Makefile probe llc, pahole and llvm-objcopy for BPF support and use them like tools/testing/selftests/bpf/Makefile changed from the commit c0fa1b6c3efc ("bpf: btf: Add BTF tests") Cc: Martin KaFai Lau Signed-off-

[PATCH v2 bpf-next] tools/bpftool: ignore build products

For untracked things of tools/bpf, add this. Reviewed-by: Jakub Kicinski Signed-off-by: Taeung Song --- tools/bpf/.gitignore | 5 + tools/bpf/bpftool/.gitignore | 2 ++ 2 files changed, 7 insertions(+) create mode 100644 tools/bpf/.gitignore diff --git a/tools/bpf/.gitignore b

[PATCH v2 bpf-next] tools/bpftool: ignore build products

For untracked things of tools/bpf, add this. Reviewed-by: Jakub Kicinski Signed-off-by: Taeung Song --- tools/bpf/.gitignore | 5 + tools/bpf/bpftool/.gitignore | 2 ++ 2 files changed, 7 insertions(+) create mode 100644 tools/bpf/.gitignore diff --git a/tools/bpf/.gitignore b

[PATCH bpf-next] tools/bpftool: ignore build products

For untracked things of tools/bpf, add this. Reviewed-by: Quentin Monnet Signed-off-by: Taeung Song --- tools/bpf/.gitignore | 5 + tools/bpf/bpftool/.gitignore | 2 ++ 2 files changed, 7 insertions(+) create mode 100644 tools/bpf/.gitignore diff --git a/tools/bpf/.gitignore b

[PATCH bpf-next] tools/bpftool: ignore build products

For untracked things of tools/bpf, add this. Reviewed-by: Quentin Monnet Signed-off-by: Taeung Song --- tools/bpf/.gitignore | 5 + tools/bpf/bpftool/.gitignore | 2 ++ 2 files changed, 7 insertions(+) create mode 100644 tools/bpf/.gitignore diff --git a/tools/bpf/.gitignore b

[PATCH v2 2/2] tools/bpftool: Fix segfault case regarding 'pin' arguments

-by: Jakub Kicinski Reported-by: Taehee Yoo Signed-off-by: Taeung Song --- tools/bpf/bpftool/common.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/tools/bpf/bpftool/common.c b/tools/bpf/bpftool/common.c index 32f9e397a6c0..3f140eff039f 100644 --- a/tools/bpf/bpftoo

[PATCH v2 2/2] tools/bpftool: Fix segfault case regarding 'pin' arguments

-by: Jakub Kicinski Reported-by: Taehee Yoo Signed-off-by: Taeung Song --- tools/bpf/bpftool/common.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/tools/bpf/bpftool/common.c b/tools/bpf/bpftool/common.c index 32f9e397a6c0..3f140eff039f 100644 --- a/tools/bpf/bpftoo

[PATCH v2 2/4] samples/bpf: Check the result of system()

-off-by: Taeung Song --- samples/bpf/trace_event_user.c | 27 --- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/samples/bpf/trace_event_user.c b/samples/bpf/trace_event_user.c index 1fa1becfa641..d08046ab81f0 100644 --- a/samples/bpf/trace_event_user.c

[PATCH v2 0/4] samples/bpf: simple fixes

v2: - in error cases, do return; instead of break; in loop Hello, This patchset fixes trivial things that I found when testing 'samples/bpf/' sample code. I'd appreciate it, if you review this. Thanks, Taeung Taeung Song (4): samples/bpf: add missing samples/bpf: Check the result of system

[PATCH v2 1/4] samples/bpf: add missing

' in sample code and include if_vlan.h Signed-off-by: Taeung Song --- samples/bpf/parse_varlen.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/samples/bpf/parse_varlen.c b/samples/bpf/parse_varlen.c index 95c16324760c..0b6f22feb2c9 100644 --- a/samples/bpf/parse_varlen.c

[PATCH v2 4/4] samples/bpf: add .gitignore file

For untracked executables of samples/bpf, add this. Untracked files: (use "git add ..." to include in what will be committed) samples/bpf/cpustat samples/bpf/fds_example samples/bpf/lathist samples/bpf/load_sock_ops ... Signed-off-by: T

[PATCH v2 2/4] samples/bpf: Check the result of system()

-off-by: Taeung Song --- samples/bpf/trace_event_user.c | 27 --- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/samples/bpf/trace_event_user.c b/samples/bpf/trace_event_user.c index 1fa1becfa641..d08046ab81f0 100644 --- a/samples/bpf/trace_event_user.c

[PATCH v2 0/4] samples/bpf: simple fixes

v2: - in error cases, do return; instead of break; in loop Hello, This patchset fixes trivial things that I found when testing 'samples/bpf/' sample code. I'd appreciate it, if you review this. Thanks, Taeung Taeung Song (4): samples/bpf: add missing samples/bpf: Check the result of system

[PATCH v2 1/4] samples/bpf: add missing

' in sample code and include if_vlan.h Signed-off-by: Taeung Song --- samples/bpf/parse_varlen.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/samples/bpf/parse_varlen.c b/samples/bpf/parse_varlen.c index 95c16324760c..0b6f22feb2c9 100644 --- a/samples/bpf/parse_varlen.c

[PATCH v2 4/4] samples/bpf: add .gitignore file

For untracked executables of samples/bpf, add this. Untracked files: (use "git add ..." to include in what will be committed) samples/bpf/cpustat samples/bpf/fds_example samples/bpf/lathist samples/bpf/load_sock_ops ... Signed-off-by: T

[tip:perf/core] tools lib traceevent: Fix missing break in FALSE case of pevent_filter_clear_trivial()

Commit-ID: 806efaed3cacab1521895d20bb3b5ed610909299 Gitweb: https://git.kernel.org/tip/806efaed3cacab1521895d20bb3b5ed610909299 Author: Taeung Song <treeze.tae...@gmail.com> AuthorDate: Thu, 11 Jan 2018 19:47:50 -0500 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> Com

[tip:perf/core] tools lib traceevent: Fix missing break in FALSE case of pevent_filter_clear_trivial()

Commit-ID: 806efaed3cacab1521895d20bb3b5ed610909299 Gitweb: https://git.kernel.org/tip/806efaed3cacab1521895d20bb3b5ed610909299 Author: Taeung Song AuthorDate: Thu, 11 Jan 2018 19:47:50 -0500 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 17 Jan 2018 10:22:57 -0300 tools lib

Re: [PATCH 09/10] lib traceeevent: Fix missing break in FALSE case of pevent_filter_clear_trivial()

Hi Steven, I found a trivial typo "eee" on the commit log title It seems better to change "lib traceeevent" to " lib traceevent", if you want to do it.. Thanks, Taeung On 01/12/2018 09:47 AM, Steven Rostedt wrote:

Re: [PATCH 09/10] lib traceeevent: Fix missing break in FALSE case of pevent_filter_clear_trivial()

Hi Steven, I found a trivial typo "eee" on the commit log title It seems better to change "lib traceeevent" to " lib traceevent", if you want to do it.. Thanks, Taeung On 01/12/2018 09:47 AM, Steven Rostedt wrote:

Re: [PATCH 1/3] perf help: Document missing options

nsupported man viewer sub key. ... Fixes: 8e99b6d4533c ("tools include: Adopt strstarts() from the kernel") Cc: Taeung Song <treeze.tae...@gmail.com> Signed-off-by: Namhyung Kim <namhy...@kernel.org> --- tools/perf/builtin-help.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH 1/3] perf help: Document missing options

3c changed prefixcmp() to strstart() but missed to change the return value in some place. It makes perf help print annoying output even for sane config items like below: $ perf help '.root': unsupported man viewer sub key. ... Fixes: 8e99b6d4533c ("tools include: Adopt strstarts() from the

[tip:perf/urgent] perf record: Fix documentation for a inexistent option '-l'

Commit-ID: 3f50f614d61f91ad30b1947c429d1f235493a7f9 Gitweb: https://git.kernel.org/tip/3f50f614d61f91ad30b1947c429d1f235493a7f9 Author: Taeung Song <treeze.tae...@gmail.com> AuthorDate: Sat, 14 Oct 2017 00:10:12 +0900 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> Com

[tip:perf/urgent] perf record: Fix documentation for a inexistent option '-l'

Commit-ID: 3f50f614d61f91ad30b1947c429d1f235493a7f9 Gitweb: https://git.kernel.org/tip/3f50f614d61f91ad30b1947c429d1f235493a7f9 Author: Taeung Song AuthorDate: Sat, 14 Oct 2017 00:10:12 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 17 Oct 2017 09:05:36 -0300 perf record

[PATCH RESEND] perf record: Fix documentation for a disused option '-l'

ernel.org> Cc: Namhyung Kim <namhy...@kernel.org> Signed-off-by: Taeung Song <treeze.tae...@gmail.com> --- tools/perf/Documentation/perf-record.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/Documentation/perf-record.txt b/tools/perf/Documentation/p

[PATCH RESEND] perf record: Fix documentation for a disused option '-l'

Signed-off-by: Taeung Song --- tools/perf/Documentation/perf-record.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/Documentation/perf-record.txt b/tools/perf/Documentation/perf-record.txt index 68a1ffb..5a626ef 100644 --- a/tools/perf/Documentation/perf-

[PATCH] perf record: Remove a disused option '-l'

ernel.org> Cc: Namhyung Kim <namhy...@kernel.org> Signed-off-by: Taeung Song <treeze.tae...@gmail.com> --- tools/perf/Documentation/perf-record.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/Documentation/perf-record.txt b/tools/perf/Documentation/p

[PATCH] perf record: Remove a disused option '-l'

Signed-off-by: Taeung Song --- tools/perf/Documentation/perf-record.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/Documentation/perf-record.txt b/tools/perf/Documentation/perf-record.txt index 68a1ffb..5a626ef 100644 --- a/tools/perf/Documentation/perf-

[tip:perf/core] perf config: Allow creating empty config set for config file autogeneration

Commit-ID: 55421b4fb7054f85274b1b6a321e204dac696133 Gitweb: http://git.kernel.org/tip/55421b4fb7054f85274b1b6a321e204dac696133 Author: Taeung Song <treeze.tae...@gmail.com> AuthorDate: Thu, 7 Sep 2017 12:18:56 +0900 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> Com

[tip:perf/core] perf config: Allow creating empty config set for config file autogeneration

Commit-ID: 55421b4fb7054f85274b1b6a321e204dac696133 Gitweb: http://git.kernel.org/tip/55421b4fb7054f85274b1b6a321e204dac696133 Author: Taeung Song AuthorDate: Thu, 7 Sep 2017 12:18:56 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 13 Sep 2017 09:49:16 -0300 perf config

[tip:perf/core] perf config: Write a config file just once

Commit-ID: 5c2615556d4410baebc9b336f14befe0bb32cde4 Gitweb: http://git.kernel.org/tip/5c2615556d4410baebc9b336f14befe0bb32cde4 Author: Taeung Song <treeze.tae...@gmail.com> AuthorDate: Thu, 7 Sep 2017 12:18:51 +0900 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> Com

[tip:perf/core] perf config: Write a config file just once

Commit-ID: 5c2615556d4410baebc9b336f14befe0bb32cde4 Gitweb: http://git.kernel.org/tip/5c2615556d4410baebc9b336f14befe0bb32cde4 Author: Taeung Song AuthorDate: Thu, 7 Sep 2017 12:18:51 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 13 Sep 2017 09:49:15 -0300 perf config

[tip:perf/urgent] perf config: Check not only section->from_system_config but also item's

Commit-ID: cba225d6eeaf00bd8181a851fbaa7b8716337e0b Gitweb: http://git.kernel.org/tip/cba225d6eeaf00bd8181a851fbaa7b8716337e0b Author: Taeung Song <treeze.tae...@gmail.com> AuthorDate: Thu, 7 Sep 2017 12:18:45 +0900 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> Com

[tip:perf/urgent] perf config: Check not only section->from_system_config but also item's

Commit-ID: cba225d6eeaf00bd8181a851fbaa7b8716337e0b Gitweb: http://git.kernel.org/tip/cba225d6eeaf00bd8181a851fbaa7b8716337e0b Author: Taeung Song AuthorDate: Thu, 7 Sep 2017 12:18:45 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 12 Sep 2017 12:35:11 -0300 perf config

Re: [PATCH v5 3/3] perf config: Allow creating empty config set for config file autogeneration

Thank you !! :) - Taeung On 09/08/2017 11:36 PM, Arnaldo Carvalho de Melo wrote: Em Thu, Sep 07, 2017 at 12:18:56PM +0900, Taeung Song escreveu: When there isn't a config file (e.g. ~/.perfconfig) or it has nothing, the config set wasn't created. If the config set not exists, a config file

Re: [PATCH v5 3/3] perf config: Allow creating empty config set for config file autogeneration

Thank you !! :) - Taeung On 09/08/2017 11:36 PM, Arnaldo Carvalho de Melo wrote: Em Thu, Sep 07, 2017 at 12:18:56PM +0900, Taeung Song escreveu: When there isn't a config file (e.g. ~/.perfconfig) or it has nothing, the config set wasn't created. If the config set not exists, a config file

[PATCH v5 3/3] perf config: Allow creating empty config set for config file autogeneration

<jo...@kernel.org> Cc: Namhyung Kim <namhy...@kernel.org> Signed-off-by: Taeung Song <treeze.tae...@gmail.com> --- tools/perf/util/config.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c index bc755

[PATCH v5 1/3] perf config: Check not only section->from_system_config but also item's

Currently only section->from_system_config is being checked multiple times. items->from_system_config should be also checked, so fix it. Cc: Jiri Olsa <jo...@kernel.org> Cc: Namhyung Kim <namhy...@kernel.org> Signed-off-by: Taeung Song <treeze.tae...@gmail.com> --- too

[PATCH v5 3/3] perf config: Allow creating empty config set for config file autogeneration

Cc: Namhyung Kim Signed-off-by: Taeung Song --- tools/perf/util/config.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c index bc75596..d2b6983 100644 --- a/tools/perf/util/config.c +++ b/tools/perf/util/config.c

[PATCH v5 1/3] perf config: Check not only section->from_system_config but also item's

Currently only section->from_system_config is being checked multiple times. items->from_system_config should be also checked, so fix it. Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v5 0/3] perf config: Simple bugfixes & refactoring

if show_spec_config() cannot show the config - initialize 'ret' with -1 instead of 0 for more compact code in cmd_config() - Add a error message when perf_config_set__new() failed in cmd_config() v2: - there is no need to consider empty config file (Arnaldo) Taeung Song (3): perf config: Check not only

[PATCH v5 2/3] perf config: Once write a config file in the end, not a repeat

ng Kim <namhy...@kernel.org> Signed-off-by: Taeung Song <treeze.tae...@gmail.com> --- tools/perf/builtin-config.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/tools/perf/builtin-config.c b/tools/perf/builtin-config.c index a1d82e3..b89417d

[PATCH v5 2/3] perf config: Once write a config file in the end, not a repeat

-by: Taeung Song --- tools/perf/builtin-config.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/tools/perf/builtin-config.c b/tools/perf/builtin-config.c index a1d82e3..b89417d 100644 --- a/tools/perf/builtin-config.c +++ b/tools/perf/builtin-config.c @@ -34,8

[PATCH v5 0/3] perf config: Simple bugfixes & refactoring

if show_spec_config() cannot show the config - initialize 'ret' with -1 instead of 0 for more compact code in cmd_config() - Add a error message when perf_config_set__new() failed in cmd_config() v2: - there is no need to consider empty config file (Arnaldo) Taeung Song (3): perf config: Check not only

[tip:perf/core] perf annotate browser: Circulate percent, total-period and nr-samples view

Commit-ID: 3a555c7799de69d73826eccc9a21948a5775d4d3 Gitweb: http://git.kernel.org/tip/3a555c7799de69d73826eccc9a21948a5775d4d3 Author: Taeung Song <treeze.tae...@gmail.com> AuthorDate: Fri, 18 Aug 2017 17:47:08 +0900 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> Com

[tip:perf/core] perf annotate browser: Circulate percent, total-period and nr-samples view

Commit-ID: 3a555c7799de69d73826eccc9a21948a5775d4d3 Gitweb: http://git.kernel.org/tip/3a555c7799de69d73826eccc9a21948a5775d4d3 Author: Taeung Song AuthorDate: Fri, 18 Aug 2017 17:47:08 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 18 Aug 2017 11:23:20 -0300 perf annotate

[tip:perf/core] perf annotate stdio: Support --show-nr-samples option

Commit-ID: 1ac39372e06f5009982aaaf890fc5bbd044bb047 Gitweb: http://git.kernel.org/tip/1ac39372e06f5009982aaaf890fc5bbd044bb047 Author: Taeung Song <treeze.tae...@gmail.com> AuthorDate: Fri, 18 Aug 2017 17:46:48 +0900 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> Com

[tip:perf/core] perf annotate: Document --show-total-period option

Commit-ID: 01c85629f5e99958606da816f1df058c0722a570 Gitweb: http://git.kernel.org/tip/01c85629f5e99958606da816f1df058c0722a570 Author: Taeung Song <treeze.tae...@gmail.com> AuthorDate: Fri, 18 Aug 2017 17:46:53 +0900 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> Com

[tip:perf/core] perf annotate stdio: Support --show-nr-samples option

Commit-ID: 1ac39372e06f5009982aaaf890fc5bbd044bb047 Gitweb: http://git.kernel.org/tip/1ac39372e06f5009982aaaf890fc5bbd044bb047 Author: Taeung Song AuthorDate: Fri, 18 Aug 2017 17:46:48 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 18 Aug 2017 10:31:53 -0300 perf annotate

[tip:perf/core] perf annotate: Document --show-total-period option

Commit-ID: 01c85629f5e99958606da816f1df058c0722a570 Gitweb: http://git.kernel.org/tip/01c85629f5e99958606da816f1df058c0722a570 Author: Taeung Song AuthorDate: Fri, 18 Aug 2017 17:46:53 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 18 Aug 2017 10:34:08 -0300 perf annotate

[tip:perf/core] perf annotate browser: Support --show-nr-samples option

Commit-ID: 9cef4b0b5b7f64016f043609313aaa821d682d2e Gitweb: http://git.kernel.org/tip/9cef4b0b5b7f64016f043609313aaa821d682d2e Author: Taeung Song <treeze.tae...@gmail.com> AuthorDate: Fri, 18 Aug 2017 17:47:03 +0900 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> Com

[tip:perf/core] perf annotate browser: Support --show-nr-samples option

Commit-ID: 9cef4b0b5b7f64016f043609313aaa821d682d2e Gitweb: http://git.kernel.org/tip/9cef4b0b5b7f64016f043609313aaa821d682d2e Author: Taeung Song AuthorDate: Fri, 18 Aug 2017 17:47:03 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 18 Aug 2017 11:15:09 -0300 perf annotate

Re: [PATCH v3 5/5] perf annotate browser: Circulate percent, total period and samples view

On 08/18/2017 11:23 PM, Arnaldo Carvalho de Melo wrote: Em Fri, Aug 18, 2017 at 05:47:08PM +0900, Taeung Song escreveu: With a existing 't' hotkey, support the three view based on percent, total period and number of samples on the annotate TUI browser, circulating them like below: Percent

Re: [PATCH v3 5/5] perf annotate browser: Circulate percent, total period and samples view

On 08/18/2017 11:23 PM, Arnaldo Carvalho de Melo wrote: Em Fri, Aug 18, 2017 at 05:47:08PM +0900, Taeung Song escreveu: With a existing 't' hotkey, support the three view based on percent, total period and number of samples on the annotate TUI browser, circulating them like below: Percent

Re: [PATCH v3 4/5] perf annotate browser: Support --show-nr-samples option

On 08/18/2017 11:17 PM, Arnaldo Carvalho de Melo wrote: Em Fri, Aug 18, 2017 at 05:47:03PM +0900, Taeung Song escreveu: Cc: Namhyung Kim <namhy...@kernel.org> Cc: Jiri Olsa <jo...@redhat.com> Signed-off-by: Taeung Song <treeze.tae...@gmail.com> Ok, now that check for

Re: [PATCH v3 4/5] perf annotate browser: Support --show-nr-samples option

On 08/18/2017 11:17 PM, Arnaldo Carvalho de Melo wrote: Em Fri, Aug 18, 2017 at 05:47:03PM +0900, Taeung Song escreveu: Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song Ok, now that check for !--stdio is lifted and replaced with: - if (symbol_conf.show_nr_samples

Re: [PATCH v3 1/5] perf annotate stdio: Support --show-nr-samples option

On 08/18/2017 10:33 PM, Arnaldo Carvalho de Melo wrote: Em Fri, Aug 18, 2017 at 05:46:48PM +0900, Taeung Song escreveu: Add --show-nr-samples option to perf-annotate so that it corresponds with perf-report. So, at this point I tried to test it and forgot this was just about --stdio, which

Re: [PATCH v3 1/5] perf annotate stdio: Support --show-nr-samples option

On 08/18/2017 10:33 PM, Arnaldo Carvalho de Melo wrote: Em Fri, Aug 18, 2017 at 05:46:48PM +0900, Taeung Song escreveu: Add --show-nr-samples option to perf-annotate so that it corresponds with perf-report. So, at this point I tried to test it and forgot this was just about --stdio, which

[PATCH v3 2/5] perf annotate: Add a missing period option in documentation

Cc: Namhyung Kim <namhy...@kernel.org> Cc: Jiri Olsa <jo...@redhat.com> Signed-off-by: Taeung Song <treeze.tae...@gmail.com> --- tools/perf/Documentation/perf-annotate.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/perf/Documentation/perf-annotate.txt b/tools/

[PATCH v3 2/5] perf annotate: Add a missing period option in documentation

Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/Documentation/perf-annotate.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/perf/Documentation/perf-annotate.txt b/tools/perf/Documentation/perf-annotate.txt index 2a5975c..c635eab 100644 --- a/tools/perf

[PATCH v3 4/5] perf annotate browser: Support --show-nr-samples option

Cc: Namhyung Kim <namhy...@kernel.org> Cc: Jiri Olsa <jo...@redhat.com> Signed-off-by: Taeung Song <treeze.tae...@gmail.com> --- tools/perf/ui/browsers/annotate.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/tools/perf/ui/browsers/annotate.

[PATCH v3 4/5] perf annotate browser: Support --show-nr-samples option

Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/ui/browsers/annotate.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c index 80f38da..faca1b9 100644 --- a/tools

[PATCH v3 1/5] perf annotate stdio: Support --show-nr-samples option

Add --show-nr-samples option to perf-annotate so that it corresponds with perf-report. Cc: Namhyung Kim <namhy...@kernel.org> Cc: Milian Wolff <milian.wo...@kdab.com> Cc: Jiri Olsa <jo...@redhat.com> Signed-off-by: Taeung Song <treeze.tae...@gmail.com> --- tools

[PATCH v3 3/5] perf annotate: Period and samples view can't be used at the same time

If users give two options --show-total-period and --show-nr-samples, show their proper usage because the two options can not be used at the same time. Cc: Namhyung Kim <namhy...@kernel.org> Cc: Jiri Olsa <jo...@redhat.com> Signed-off-by: Taeung Song <treeze.tae...@gmail.com&g

[PATCH v3 5/5] perf annotate browser: Circulate percent, total period and samples view

ian.wo...@kdab.com> Cc: Jiri Olsa <jo...@redhat.com> Signed-off-by: Taeung Song <treeze.tae...@gmail.com> --- tools/perf/ui/browsers/annotate.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/

[PATCH v3 1/5] perf annotate stdio: Support --show-nr-samples option

Add --show-nr-samples option to perf-annotate so that it corresponds with perf-report. Cc: Namhyung Kim Cc: Milian Wolff Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/Documentation/perf-annotate.txt | 4 tools/perf/builtin-annotate.c | 2 ++ tools/perf/util

[PATCH v3 3/5] perf annotate: Period and samples view can't be used at the same time

If users give two options --show-total-period and --show-nr-samples, show their proper usage because the two options can not be used at the same time. Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/builtin-annotate.c | 8 ++-- 1 file changed, 6 insertions(+), 2

[PATCH v3 5/5] perf annotate browser: Circulate percent, total period and samples view

With a existing 't' hotkey, support the three view based on percent, total period and number of samples on the annotate TUI browser, circulating them like below: Percent -> Period -> Samples -> Percent ... Suggested-by: Namhyung Kim Cc: Milian Wolff Cc: Jiri Olsa Signed-off-by: Ta

[PATCH v3 0/5] perf annotate: Support --show-nr-samples and circulating view

ples view can't be used at the same time (Arnaldo) Taeung Song (5): perf annotate stdio: Support --show-nr-samples option perf annotate: Add a missing period option in documentation perf annotate: Period and samples view can't be used at the same time perf annotate browser: Support --show-n

[PATCH v3 0/5] perf annotate: Support --show-nr-samples and circulating view

ples view can't be used at the same time (Arnaldo) Taeung Song (5): perf annotate stdio: Support --show-nr-samples option perf annotate: Add a missing period option in documentation perf annotate: Period and samples view can't be used at the same time perf annotate browser: Support --show-n

Re: [PATCH v2 1/4] perf annotate stdio: Support --show-nr-samples option

Hi Arnaldo, On 08/18/2017 12:16 AM, Arnaldo Carvalho de Melo wrote: Em Tue, Aug 15, 2017 at 05:06:31PM -0300, Arnaldo Carvalho de Melo escreveu: Em Wed, Aug 16, 2017 at 12:13:09AM +0900, Taeung Song escreveu: Add --show-nr-samples option to perf-annotate so that it corresponds with perf

Re: [PATCH v2 1/4] perf annotate stdio: Support --show-nr-samples option

Hi Arnaldo, On 08/18/2017 12:16 AM, Arnaldo Carvalho de Melo wrote: Em Tue, Aug 15, 2017 at 05:06:31PM -0300, Arnaldo Carvalho de Melo escreveu: Em Wed, Aug 16, 2017 at 12:13:09AM +0900, Taeung Song escreveu: Add --show-nr-samples option to perf-annotate so that it corresponds with perf

[PATCH v2 4/4] perf annotate browser: Circulate percent, total period and samples view

ian.wo...@kdab.com> Cc: Jiri Olsa <jo...@redhat.com> Signed-off-by: Taeung Song <treeze.tae...@gmail.com> --- tools/perf/ui/browsers/annotate.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/

[PATCH v2 4/4] perf annotate browser: Circulate percent, total period and samples view

With a existing 't' hotkey, support the three view based on percent, total period and number of samples on the annotate TUI browser, circulating them like below: Percent -> Period -> Samples -> Percent ... Suggested-by: Namhyung Kim Cc: Milian Wolff Cc: Jiri Olsa Signed-off-by: Ta

[PATCH v2 2/4] perf annotate: Period and samples view can't be used at the same time

If users give two options --show-total-period and --show-nr-samples, show their proper usage because the two options can not be used at the same time. Cc: Namhyung Kim <namhy...@kernel.org> Cc: Jiri Olsa <jo...@redhat.com> Signed-off-by: Taeung Song <treeze.tae...@gmail.com&g

[PATCH v2 3/4] perf annotate browser: Support --show-nr-samples option

Cc: Namhyung Kim <namhy...@kernel.org> Cc: Jiri Olsa <jo...@redhat.com> Signed-off-by: Taeung Song <treeze.tae...@gmail.com> --- tools/perf/ui/browsers/annotate.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/tools/perf/ui/browsers/annotate.

[PATCH v2 0/4] perf annotate: Support --show-nr-samples and circulating view

ppreciate some feedback on my patchkit. :) The code is available on 'perf/ann-nr-samples' branch at git://github.com/taeung/linux-perf.git Thanks, Taeung v2: - period and nr-samples view can't be used at the same time (Arnaldo) Taeung Song (4): perf annotate stdio: Support --show-nr-sampl

[PATCH v2 1/4] perf annotate stdio: Support --show-nr-samples option

Add --show-nr-samples option to perf-annotate so that it corresponds with perf-report. Cc: Namhyung Kim <namhy...@kernel.org> Cc: Milian Wolff <milian.wo...@kdab.com> Cc: Jiri Olsa <jo...@redhat.com> Signed-off-by: Taeung Song <treeze.tae...@gmail.com> --- tools/per

[PATCH v2 2/4] perf annotate: Period and samples view can't be used at the same time

If users give two options --show-total-period and --show-nr-samples, show their proper usage because the two options can not be used at the same time. Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/builtin-annotate.c | 8 ++-- 1 file changed, 6 insertions(+), 2

[PATCH v2 3/4] perf annotate browser: Support --show-nr-samples option

Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/ui/browsers/annotate.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c index 80f38da..faca1b9 100644 --- a/tools

[PATCH v2 0/4] perf annotate: Support --show-nr-samples and circulating view

ppreciate some feedback on my patchkit. :) The code is available on 'perf/ann-nr-samples' branch at git://github.com/taeung/linux-perf.git Thanks, Taeung v2: - period and nr-samples view can't be used at the same time (Arnaldo) Taeung Song (4): perf annotate stdio: Support --show-nr-sampl

[PATCH v2 1/4] perf annotate stdio: Support --show-nr-samples option

Add --show-nr-samples option to perf-annotate so that it corresponds with perf-report. Cc: Namhyung Kim Cc: Milian Wolff Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/builtin-annotate.c | 2 ++ tools/perf/util/annotate.c| 6 +- 2 files changed, 7 insertions(+), 1 deletion

Re: [PATCH v4 5/9] perf annotate stdio: Support --show-nr-samples option

On 08/15/2017 01:31 AM, Arnaldo Carvalho de Melo wrote: Em Mon, Aug 14, 2017 at 07:42:07PM +0900, Taeung Song escreveu: On 08/01/2017 03:24 PM, Taeung Song wrote: On 07/29/2017 01:26 AM, Arnaldo Carvalho de Melo wrote: Em Fri, Jul 28, 2017 at 01:16:16AM +0900, Taeung Song escreveu: Add

Re: [PATCH v4 5/9] perf annotate stdio: Support --show-nr-samples option

On 08/15/2017 01:31 AM, Arnaldo Carvalho de Melo wrote: Em Mon, Aug 14, 2017 at 07:42:07PM +0900, Taeung Song escreveu: On 08/01/2017 03:24 PM, Taeung Song wrote: On 07/29/2017 01:26 AM, Arnaldo Carvalho de Melo wrote: Em Fri, Jul 28, 2017 at 01:16:16AM +0900, Taeung Song escreveu: Add

Re: [PATCH v4 5/9] perf annotate stdio: Support --show-nr-samples option

Hi Arnaldo, On 08/01/2017 03:24 PM, Taeung Song wrote: On 07/29/2017 01:26 AM, Arnaldo Carvalho de Melo wrote: Em Fri, Jul 28, 2017 at 01:16:16AM +0900, Taeung Song escreveu: Add --show-nr-samples option to perf-annotate so that it corresponds with perf-report. So

Re: [PATCH v4 5/9] perf annotate stdio: Support --show-nr-samples option

Hi Arnaldo, On 08/01/2017 03:24 PM, Taeung Song wrote: On 07/29/2017 01:26 AM, Arnaldo Carvalho de Melo wrote: Em Fri, Jul 28, 2017 at 01:16:16AM +0900, Taeung Song escreveu: Add --show-nr-samples option to perf-annotate so that it corresponds with perf-report. So

[PATCH 0/3] perf annotate: Support --show-nr-samples and circulating view

ppreciate some feedback on my patchkit. :) The code is available on 'perf/ann-nr-samples' branch at git://github.com/taeung/linux-perf.git Thanks, Taeung Taeung Song (3): perf annotate stdio: Support --show-nr-samples option perf annotate browser: Support --show-nr-samples option perf

[PATCH 0/3] perf annotate: Support --show-nr-samples and circulating view

ppreciate some feedback on my patchkit. :) The code is available on 'perf/ann-nr-samples' branch at git://github.com/taeung/linux-perf.git Thanks, Taeung Taeung Song (3): perf annotate stdio: Support --show-nr-samples option perf annotate browser: Support --show-nr-samples option perf

[PATCH 1/3] perf annotate stdio: Support --show-nr-samples option

Add --show-nr-samples option to perf-annotate so that it corresponds with perf-report. Cc: Namhyung Kim <namhy...@kernel.org> Cc: Milian Wolff <milian.wo...@kdab.com> Cc: Jiri Olsa <jo...@redhat.com> Signed-off-by: Taeung Song <treeze.tae...@gmail.com> --- tools/per

[PATCH 1/3] perf annotate stdio: Support --show-nr-samples option

Add --show-nr-samples option to perf-annotate so that it corresponds with perf-report. Cc: Namhyung Kim Cc: Milian Wolff Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/builtin-annotate.c | 2 ++ tools/perf/util/annotate.c| 6 +- 2 files changed, 7 insertions(+), 1 deletion

[PATCH 3/3] perf annotate browser: Circulate percent, total period and samples view

ian.wo...@kdab.com> Cc: Jiri Olsa <jo...@redhat.com> Signed-off-by: Taeung Song <treeze.tae...@gmail.com> --- tools/perf/ui/browsers/annotate.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/

[PATCH 3/3] perf annotate browser: Circulate percent, total period and samples view

With a existing 't' hotkey, support the three view based on percent, total period and number of samples on the annotate TUI browser, circulating them like below: Percent -> Period -> Samples -> Percent ... Suggested-by: Namhyung Kim Cc: Milian Wolff Cc: Jiri Olsa Signed-off-by: Ta

[PATCH 2/3] perf annotate browser: Support --show-nr-samples option

Cc: Namhyung Kim <namhy...@kernel.org> Cc: Jiri Olsa <jo...@redhat.com> Signed-off-by: Taeung Song <treeze.tae...@gmail.com> --- tools/perf/ui/browsers/annotate.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/tools/perf/ui/browsers/annotate.

[PATCH 2/3] perf annotate browser: Support --show-nr-samples option

Cc: Namhyung Kim Cc: Jiri Olsa Signed-off-by: Taeung Song --- tools/perf/ui/browsers/annotate.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c index 80f38da..faca1b9 100644 --- a/tools

  1   2   3   4   5   6   7   8   9   10   >