On 03/28/2017 10:48 PM, Arnaldo Carvalho de Melo wrote:
Em Tue, Mar 28, 2017 at 09:12:05PM +0900, Taeung Song escreveu:
The option 'show-total-period' works fine without a option '-l'.
But if running 'perf annotate --stdio -l --show-total-period',
you can see a problem showing only zero '0
On 03/28/2017 10:48 PM, Arnaldo Carvalho de Melo wrote:
Em Tue, Mar 28, 2017 at 09:12:05PM +0900, Taeung Song escreveu:
The option 'show-total-period' works fine without a option '-l'.
But if running 'perf annotate --stdio -l --show-total-period',
you can see a problem showing only zero '0
(%rdx),%esi
1 :40082a: mov$0x0,%edx
...
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Jiri Olsa <jo...@redhat.com>
Cc: Martin Liska <mli...@suse.cz>
Fixes: 0c4a5bcea460 ("perf annotate: Display total number of samples with
--show-total-period"
(%rdx),%esi
1 :40082a: mov$0x0,%edx
...
Cc: Namhyung Kim
Cc: Jiri Olsa
Cc: Martin Liska
Fixes: 0c4a5bcea460 ("perf annotate: Display total number of samples with
--show-total-period")
Signed-off-by: Taeung Song
---
tools/perf/util/annotate.c | 6 --
Good morning, Arnaldo :)
On 03/28/2017 03:26 AM, Arnaldo Carvalho de Melo wrote:
Em Mon, Mar 27, 2017 at 04:10:38PM +0900, Taeung Song escreveu:
If running 'perf annotate --stdio -l --show-total-period',
you can see a problem showing only zero '0' for number of samples.
Before:
$ perf
Good morning, Arnaldo :)
On 03/28/2017 03:26 AM, Arnaldo Carvalho de Melo wrote:
Em Mon, Mar 27, 2017 at 04:10:38PM +0900, Taeung Song escreveu:
If running 'perf annotate --stdio -l --show-total-period',
you can see a problem showing only zero '0' for number of samples.
Before:
$ perf
On 03/28/2017 03:01 AM, Arnaldo Carvalho de Melo wrote:
Em Mon, Mar 27, 2017 at 04:10:36PM +0900, Taeung Song escreveu:
It is wrong way to read link name from a build-id file.
Because a build-id file is not symbolic link
but build-id directory of it is symbolic link, so fix it.
Ok, applied
On 03/28/2017 03:01 AM, Arnaldo Carvalho de Melo wrote:
Em Mon, Mar 27, 2017 at 04:10:36PM +0900, Taeung Song escreveu:
It is wrong way to read link name from a build-id file.
Because a build-id file is not symbolic link
but build-id directory of it is symbolic link, so fix it.
Ok, applied
Commit-ID: 2e933b1274dc89cd1629f6c7fd9bf952248d84c2
Gitweb: http://git.kernel.org/tip/2e933b1274dc89cd1629f6c7fd9bf952248d84c2
Author: Taeung Song <treeze.tae...@gmail.com>
AuthorDate: Mon, 27 Mar 2017 16:10:37 +0900
Committer: Arnaldo Carvalho de Melo <a...@redhat.com>
Com
Commit-ID: 2e933b1274dc89cd1629f6c7fd9bf952248d84c2
Gitweb: http://git.kernel.org/tip/2e933b1274dc89cd1629f6c7fd9bf952248d84c2
Author: Taeung Song
AuthorDate: Mon, 27 Mar 2017 16:10:37 +0900
Committer: Arnaldo Carvalho de Melo
CommitDate: Mon, 27 Mar 2017 15:04:56 -0300
perf annotate
Commit-ID: 6ebd2547dd24daf95a21b2bc59931de8502afcc3
Gitweb: http://git.kernel.org/tip/6ebd2547dd24daf95a21b2bc59931de8502afcc3
Author: Taeung Song <treeze.tae...@gmail.com>
AuthorDate: Mon, 27 Mar 2017 16:10:36 +0900
Committer: Arnaldo Carvalho de Melo <a...@redhat.com>
Com
Commit-ID: 6ebd2547dd24daf95a21b2bc59931de8502afcc3
Gitweb: http://git.kernel.org/tip/6ebd2547dd24daf95a21b2bc59931de8502afcc3
Author: Taeung Song
AuthorDate: Mon, 27 Mar 2017 16:10:36 +0900
Committer: Arnaldo Carvalho de Melo
CommitDate: Mon, 27 Mar 2017 14:58:20 -0300
perf annotate
Hi,
perf-annotate has little bugs so I fix them.
I'd appreciate some feedback on this patchset. :)
Thanks,
Taeung
v3:
- rebased on current acme/perf/core
v2:
- more clearly commit log messages (Arnaldo)
- rebased on current acme/perf/core
Taeung Song (3):
perf annotate: Fix a bug reading
Hi,
perf-annotate has little bugs so I fix them.
I'd appreciate some feedback on this patchset. :)
Thanks,
Taeung
v3:
- rebased on current acme/perf/core
v2:
- more clearly commit log messages (Arnaldo)
- rebased on current acme/perf/core
Taeung Song (3):
perf annotate: Fix a bug reading
cles
(529 samples)
-
:
...
a.c:260.570.004.23 : 40081a: mov%edi,-0x24(%rbp)
a.c:260.000.009.86 : 40081d: mov%rsi,-0x30(%rbp)
...
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Jiri Olsa <jo...@redhat.com&
cles
(529 samples)
-
:
...
a.c:260.570.004.23 : 40081a: mov%edi,-0x24(%rbp)
a.c:260.000.009.86 : 40081d: mov%rsi,-0x30(%rbp)
...
Cc: Namhyung Kim
Cc: Jiri Olsa
Signed-off-by: Taeung Song
---
tools/perf/ut
sa <jo...@redhat.com>
Signed-off-by: Taeung Song <treeze.tae...@gmail.com>
---
tools/perf/util/annotate.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index 3d0263e..6dc9148 100644
--- a/tools/perf/util/anno
/75c7d197c951659d1c1b8b5fd49bcdf8f3f8b1/elf
To correctly read link name of build-id,
use the build-id dir path that is a symbolic link,
instead of the above build-id file name like below.
/root/.debug/.build-id/4f/75c7d197c951659d1c1b8b5fd49bcdf8f3f8b1
Cc: Namhyung Kim
Cc: Jiri Olsa
Signed-off-by: Taeung Song
: Namhyung Kim <namhy...@kernel.org>
Cc: Jiri Olsa <jo...@redhat.com>
Signed-off-by: Taeung Song <treeze.tae...@gmail.com>
---
tools/perf/util/annotate.c | 6 --
tools/perf/util/annotate.h | 2 +-
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/tools/perf/util/annot
: Namhyung Kim
Cc: Jiri Olsa
Signed-off-by: Taeung Song
---
tools/perf/util/annotate.c | 6 --
tools/perf/util/annotate.h | 2 +-
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index 11af5f0..a37032b 100644
--- a/tools/perf
Commit-ID: e7cb9de211ebb2924d87fdeb77e50d74c2e673d1
Gitweb: http://git.kernel.org/tip/e7cb9de211ebb2924d87fdeb77e50d74c2e673d1
Author: Taeung Song <treeze.tae...@gmail.com>
AuthorDate: Mon, 20 Mar 2017 11:56:57 +0900
Committer: Arnaldo Carvalho de Melo <a...@redhat.com>
Com
Commit-ID: e7cb9de211ebb2924d87fdeb77e50d74c2e673d1
Gitweb: http://git.kernel.org/tip/e7cb9de211ebb2924d87fdeb77e50d74c2e673d1
Author: Taeung Song
AuthorDate: Mon, 20 Mar 2017 11:56:57 +0900
Committer: Arnaldo Carvalho de Melo
CommitDate: Tue, 21 Mar 2017 15:42:25 -0300
perf annotate
cles
(529 samples)
-
:
...
a.c:260.570.004.23 : 40081a: mov%edi,-0x24(%rbp)
a.c:260.000.009.86 : 40081d: mov%rsi,-0x30(%rbp)
...
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Jiri Olsa <jo...@redhat.com&
cles
(529 samples)
-
:
...
a.c:260.570.004.23 : 40081a: mov%edi,-0x24(%rbp)
a.c:260.000.009.86 : 40081d: mov%rsi,-0x30(%rbp)
...
Cc: Namhyung Kim
Cc: Jiri Olsa
Signed-off-by: Taeung Song
---
tools/perf/ut
sa <jo...@redhat.com>
Signed-off-by: Taeung Song <treeze.tae...@gmail.com>
---
tools/perf/util/annotate.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index 22cd1db..20de715 100644
--- a/tools/perf/util/anno
/75c7d197c951659d1c1b8b5fd49bcdf8f3f8b1/elf
To correctly read link name of build-id,
use the build-id dir path that is a symbolic link,
instead of the above build-id file name like below.
/root/.debug/.build-id/4f/75c7d197c951659d1c1b8b5fd49bcdf8f3f8b1
Cc: Namhyung Kim
Cc: Jiri Olsa
Signed-off-by: Taeung Song
: Namhyung Kim <namhy...@kernel.org>
Cc: Jiri Olsa <jo...@redhat.com>
Signed-off-by: Taeung Song <treeze.tae...@gmail.com>
---
tools/perf/util/annotate.c | 6 --
tools/perf/util/annotate.h | 2 +-
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/tools/perf/util/annot
: Namhyung Kim
Cc: Jiri Olsa
Signed-off-by: Taeung Song
---
tools/perf/util/annotate.c | 6 --
tools/perf/util/annotate.h | 2 +-
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index db3ebf1..23f36cb 100644
--- a/tools/perf
Hi,
perf-annotate has little bugs so I fix them.
I'd appreciate some feedback on this patchset. :)
Thanks,
Taeung
v2:
- more clearly commit log messages (Arnaldo)
- rebased on current acme/perf/core
Taeung Song (3):
perf annotate: Fix a bug reading link name from a build-id file
perf
Hi,
perf-annotate has little bugs so I fix them.
I'd appreciate some feedback on this patchset. :)
Thanks,
Taeung
v2:
- more clearly commit log messages (Arnaldo)
- rebased on current acme/perf/core
Taeung Song (3):
perf annotate: Fix a bug reading link name from a build-id file
perf
On 03/21/2017 11:21 PM, Arnaldo Carvalho de Melo wrote:
Em Tue, Mar 21, 2017 at 11:14:07AM -0300, Arnaldo Carvalho de Melo escreveu:
Em Tue, Mar 21, 2017 at 07:20:20AM +0900, Taeung Song escreveu:
And,
I tested by perf-stat on the same situation as below.
$ perf stat -e "{cycles
On 03/21/2017 11:21 PM, Arnaldo Carvalho de Melo wrote:
Em Tue, Mar 21, 2017 at 11:14:07AM -0300, Arnaldo Carvalho de Melo escreveu:
Em Tue, Mar 21, 2017 at 07:20:20AM +0900, Taeung Song escreveu:
And,
I tested by perf-stat on the same situation as below.
$ perf stat -e "{cycles
On 03/22/2017 03:32 AM, Arnaldo Carvalho de Melo wrote:
Em Tue, Mar 21, 2017 at 03:29:50PM -0300, Arnaldo Carvalho de Melo escreveu:
Em Wed, Mar 22, 2017 at 01:19:49AM +0900, Taeung Song escreveu:
On 03/21/2017 11:37 PM, Arnaldo Carvalho de Melo wrote:
+++ b/tools/perf/util/annotate.c
On 03/22/2017 03:32 AM, Arnaldo Carvalho de Melo wrote:
Em Tue, Mar 21, 2017 at 03:29:50PM -0300, Arnaldo Carvalho de Melo escreveu:
Em Wed, Mar 22, 2017 at 01:19:49AM +0900, Taeung Song escreveu:
On 03/21/2017 11:37 PM, Arnaldo Carvalho de Melo wrote:
+++ b/tools/perf/util/annotate.c
Thank you for your review :)
On 03/21/2017 11:37 PM, Arnaldo Carvalho de Melo wrote:
Em Mon, Mar 20, 2017 at 11:56:57AM +0900, Taeung Song escreveu:
grep -v "file name" in the objdump command
cause a side effect eliminating filename:linenr of
output of 'objdump -l' if the object
Thank you for your review :)
On 03/21/2017 11:37 PM, Arnaldo Carvalho de Melo wrote:
Em Mon, Mar 20, 2017 at 11:56:57AM +0900, Taeung Song escreveu:
grep -v "file name" in the objdump command
cause a side effect eliminating filename:linenr of
output of 'objdump -l' if the object
Thank you for your review :)
On 03/21/2017 11:37 PM, Arnaldo Carvalho de Melo wrote:
Em Mon, Mar 20, 2017 at 11:56:57AM +0900, Taeung Song escreveu:
grep -v "file name" in the objdump command
cause a side effect eliminating filename:linenr of
output of 'objdump -l' if the object
Thank you for your review :)
On 03/21/2017 11:37 PM, Arnaldo Carvalho de Melo wrote:
Em Mon, Mar 20, 2017 at 11:56:57AM +0900, Taeung Song escreveu:
grep -v "file name" in the objdump command
cause a side effect eliminating filename:linenr of
output of 'objdump -l' if the object
Hi,
On 03/21/2017 11:21 PM, Arnaldo Carvalho de Melo wrote:
Em Tue, Mar 21, 2017 at 11:14:07AM -0300, Arnaldo Carvalho de Melo escreveu:
Em Tue, Mar 21, 2017 at 07:20:20AM +0900, Taeung Song escreveu:
And,
I tested by perf-stat on the same situation as below.
$ perf stat -e "{cycles
Hi,
On 03/21/2017 11:21 PM, Arnaldo Carvalho de Melo wrote:
Em Tue, Mar 21, 2017 at 11:14:07AM -0300, Arnaldo Carvalho de Melo escreveu:
Em Tue, Mar 21, 2017 at 07:20:20AM +0900, Taeung Song escreveu:
And,
I tested by perf-stat on the same situation as below.
$ perf stat -e "{cycles
addr[i] / h->sum;
This patch just add if statement 'if (h->sum)' to handle the case
that h->sum is zero. But now I wonder how h->sum could be zero..
I'll dig the problem to find the root cause of it, too !
Thanks,
Taeung
On 03/21/2017 07:11 AM, Taeung Song wrote:
Hi Arnaldo :)
addr[i] / h->sum;
This patch just add if statement 'if (h->sum)' to handle the case
that h->sum is zero. But now I wonder how h->sum could be zero..
I'll dig the problem to find the root cause of it, too !
Thanks,
Taeung
On 03/21/2017 07:11 AM, Taeung Song wrote:
Hi Arnaldo :)
an0.00 old_pack_knapsack.c:38
16.37-nan0.00 old_pack_knapsack.c:37
Thanks,
Taeung
On 03/21/2017 03:15 AM, Arnaldo Carvalho de Melo wrote:
Em Mon, Mar 20, 2017 at 11:56:55AM +0900, Taeung Song escreveu:
Currently perf-annotate with --print-line can print
-nan(0x8) because o
an0.00 old_pack_knapsack.c:38
16.37-nan0.00 old_pack_knapsack.c:37
Thanks,
Taeung
On 03/21/2017 03:15 AM, Arnaldo Carvalho de Melo wrote:
Em Mon, Mar 20, 2017 at 11:56:55AM +0900, Taeung Song escreveu:
Currently perf-annotate with --print-line can print
-nan(0x8) because o
Jiri Olsa <jo...@redhat.com>
Signed-off-by: Taeung Song <treeze.tae...@gmail.com>
---
tools/perf/util/annotate.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index fc91c6b..9bb43cd 100644
--- a/
samples)
-
:
...
a.c:260.570.004.23 : 40081a: mov%edi,-0x24(%rbp)
a.c:260.000.009.86 : 40081d: mov%rsi,-0x30(%rbp)
...
Cc: Namhyung Kim
Cc: Jiri Olsa
Signed-off-by
2 :400824: mov-0x30(%rbp),%rdx
0 :400828: mov(%rdx),%esi
1 :40082a: mov$0x0,%edx
...
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Jiri Olsa <jo...@redhat.com>
Signed-off-by: Taeung Song <treeze.tae...@gmail.com&g
<namhy...@kernel.org>
Cc: Jiri Olsa <jo...@redhat.com>
Signed-off-by: Taeung Song <treeze.tae...@gmail.com>
---
tools/perf/util/annotate.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index 273f2
2 :400824: mov-0x30(%rbp),%rdx
0 :400828: mov(%rdx),%esi
1 :40082a: mov$0x0,%edx
...
Cc: Namhyung Kim
Cc: Jiri Olsa
Signed-off-by: Taeung Song
---
tools/perf/util/annotate.c | 6 --
tools/perf/util/annotate.h | 2 +-
2
: Jiri Olsa
Signed-off-by: Taeung Song
---
tools/perf/util/annotate.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index 273f21f..fc91c6b 100644
--- a/tools/perf/util/annotate.c
+++ b/tools/perf/util/annotate.c
Hi,
perf-annotate has little bugs so I fix them.
I'd appreciate some feedback on this patchset. :)
Thanks,
Taeung
Taeung Song (4):
perf annotate: Use build-id dir when reading link name
perf annotate: Avoid division by zero when calculating percent
perf annotate: Fix missing setting nr
Hi,
perf-annotate has little bugs so I fix them.
I'd appreciate some feedback on this patchset. :)
Thanks,
Taeung
Taeung Song (4):
perf annotate: Use build-id dir when reading link name
perf annotate: Avoid division by zero when calculating percent
perf annotate: Fix missing setting nr
format elf64-x86-64"
After:
$ objdump -l -d -S -C /home/taeung/hello | grep /home/taeung/hello:
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Jiri Olsa <jo...@redhat.com>
Signed-off-by: Taeung Song <treeze.tae...@gmail.com>
---
tools/perf/util/annotate.c | 2 +-
1 file cha
format elf64-x86-64"
After:
$ objdump -l -d -S -C /home/taeung/hello | grep /home/taeung/hello:
Cc: Namhyung Kim
Cc: Jiri Olsa
Signed-off-by: Taeung Song
---
tools/perf/util/annotate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/annotate.
73 }
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Jiri Olsa <jo...@redhat.com>
Signed-off-by: Taeung Song <treeze.tae...@gmail.com>
---
tools/perf/builtin-annotate.c | 2 +
tools/perf/ui/browsers/annotate.c | 5 -
tools/perf/util/annotate.c| 299 ++
a
Signed-off-by: Taeung Song
---
tools/perf/builtin-annotate.c | 2 +
tools/perf/ui/browsers/annotate.c | 5 -
tools/perf/util/annotate.c| 299 +-
tools/perf/util/annotate.h| 22 +++
tools/perf/util/symbol.c | 1 +
tools/perf/
< 0)
|break;
|
23.21 |*long_val = (*long_val << 4) | hex_val;
|p++;
|}
|
1.79 |return p - ptr;
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Jiri Olsa <jo...@redhat.com>
Signed-off-by
< 0)
|break;
|
23.21 |*long_val = (*long_val << 4) | hex_val;
|p++;
|}
|
1.79 |return p - ptr;
Cc: Namhyung Kim
Cc: Jiri Olsa
Signed-off-by: Taeung Song
---
tools/perf/Documentation/perfconfig.
liminating filename:linenr of
output of 'objdump -l' so fix it.
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Jiri Olsa <jo...@redhat.com>
Signed-off-by: Taeung Song <treeze.tae...@gmail.com>
---
tools/perf/util/annotate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/
Jiri Olsa <jo...@redhat.com>
Signed-off-by: Taeung Song <treeze.tae...@gmail.com>
---
tools/perf/util/annotate.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index fc91c6b..9bb43cd 100644
--- a/
liminating filename:linenr of
output of 'objdump -l' so fix it.
Cc: Namhyung Kim
Cc: Jiri Olsa
Signed-off-by: Taeung Song
---
tools/perf/util/annotate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index 63130ec..e49eb7e 100644
-
samples)
-
:
...
a.c:260.570.004.23 : 40081a: mov%edi,-0x24(%rbp)
a.c:260.000.009.86 : 40081d: mov%rsi,-0x30(%rbp)
...
Cc: Namhyung Kim
Cc: Jiri Olsa
Signed-off-by
: Jiri Olsa <jo...@redhat.com>
Signed-off-by: Taeung Song <treeze.tae...@gmail.com>
---
tools/perf/util/annotate.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index e49eb7e..a50d949 100644
--- a/tools/perf/uti
-by: Taeung Song
---
tools/perf/util/annotate.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index e49eb7e..a50d949 100644
--- a/tools/perf/util/annotate.c
+++ b/tools/perf/util/annotate.c
@@ -823,11 +823,11 @@ static struct
2 :400824: mov-0x30(%rbp),%rdx
0 :400828: mov(%rdx),%esi
1 :40082a: mov$0x0,%edx
...
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Jiri Olsa <jo...@redhat.com>
Signed-off-by: Taeung Song <treeze.tae...@gmail.com&g
2 :400824: mov-0x30(%rbp),%rdx
0 :400828: mov(%rdx),%esi
1 :40082a: mov$0x0,%edx
...
Cc: Namhyung Kim
Cc: Jiri Olsa
Signed-off-by: Taeung Song
---
tools/perf/util/annotate.c | 6 --
tools/perf/util/annotate.h | 2 +-
2
<namhy...@kernel.org>
Cc: Jiri Olsa <jo...@redhat.com>
Signed-off-by: Taeung Song <treeze.tae...@gmail.com>
---
tools/perf/util/annotate.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index 273f2
: Jiri Olsa
Signed-off-by: Taeung Song
---
tools/perf/util/annotate.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index 273f21f..fc91c6b 100644
--- a/tools/perf/util/annotate.c
+++ b/tools/perf/util/annotate.c
of asm per a line' on the new source
code view.
If you agree the new source code view, I keep going to do!
Taeung Song (7):
perf annotate: Use build-id dir when reading link name
perf annotate: Avoid division by zero when calculating percent
perf annotate: Fix missing setting nr samples on s
of asm per a line' on the new source
code view.
If you agree the new source code view, I keep going to do!
Taeung Song (7):
perf annotate: Use build-id dir when reading link name
perf annotate: Avoid division by zero when calculating percent
perf annotate: Fix missing setting nr samples on s
On 03/03/2017 11:40 AM, Namhyung Kim wrote:
+ Andi Kleen who wrote the code.
On Thu, Mar 02, 2017 at 03:05:14PM +0900, Taeung Song wrote:
On 03/01/2017 10:17 PM, Namhyung Kim wrote:
Hi Taeung,
On Wed, Mar 01, 2017 at 04:59:51AM +0900, Taeung Song wrote:
Currently perf-annotate show
On 03/03/2017 11:40 AM, Namhyung Kim wrote:
+ Andi Kleen who wrote the code.
On Thu, Mar 02, 2017 at 03:05:14PM +0900, Taeung Song wrote:
On 03/01/2017 10:17 PM, Namhyung Kim wrote:
Hi Taeung,
On Wed, Mar 01, 2017 at 04:59:51AM +0900, Taeung Song wrote:
Currently perf-annotate show
On 03/01/2017 10:17 PM, Namhyung Kim wrote:
Hi Taeung,
On Wed, Mar 01, 2017 at 04:59:51AM +0900, Taeung Song wrote:
Currently perf-annotate show wrong line numbers.
For example,
Actual source code is as below
...
21 };
22
23 unsigned int limited_wgt;
24
25 unsigned int
On 03/01/2017 10:17 PM, Namhyung Kim wrote:
Hi Taeung,
On Wed, Mar 01, 2017 at 04:59:51AM +0900, Taeung Song wrote:
Currently perf-annotate show wrong line numbers.
For example,
Actual source code is as below
...
21 };
22
23 unsigned int limited_wgt;
24
25 unsigned int
Hi, Peter
On 03/02/2017 12:07 AM, Peter Zijlstra wrote:
On Wed, Mar 01, 2017 at 11:56:39PM +0900, Namhyung Kim wrote:
It's a kind of user experience issue. We provide the asm-only and
asm+source annotation, and I think it'd be nice to add source-only
option. And I remember that it was
Hi, Peter
On 03/02/2017 12:07 AM, Peter Zijlstra wrote:
On Wed, Mar 01, 2017 at 11:56:39PM +0900, Namhyung Kim wrote:
It's a kind of user experience issue. We provide the asm-only and
asm+source annotation, and I think it'd be nice to add source-only
option. And I remember that it was
c: Jiri Olsa <jo...@redhat.com>
Signed-off-by: Taeung Song <treeze.tae...@gmail.com>
---
tools/perf/builtin-annotate.c | 2 +-
tools/perf/ui/browsers/annotate.c | 5 -
tools/perf/util/annotate.c| 235 +-
tools/perf/util/annotate.h
;
0.00 : 60
12.20 : 61 if (knapsack_list[wgt].maxprice <
maxprice)
0.00 : 62 knapsack_list[wgt].maxprice =
maxprice;
0.00 : 63 }
0.00 : 64 }
0.00 : 65 }
Cc: Namhyung Kim
Cc: Jiri Olsa
Signed-off-
│59 maxprice = get_cond_maxprice(wgt, jewelry);
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Jiri Olsa <jo...@redhat.com>
Signed-off-by: Taeung Song <treeze.tae...@gmail.com>
---
tools/perf/ui/browsers/annotate.c | 170 --
tools/
│59 maxprice = get_cond_maxprice(wgt, jewelry);
Cc: Namhyung Kim
Cc: Jiri Olsa
Signed-off-by: Taeung Song
---
tools/perf/ui/browsers/annotate.c | 170 --
tools/perf/util/annotate.h| 1 +
2 files changed, 128 insertions(+), 43 deleti
-S')
So fix them regarding wrong line numbers
and Introduce new source_code collecting actual code,
not depending on 'objdump -S'.
I'd appreciate some feedback.
Thanks,
Taeung
v2:
- contains the new source code view (Namhyung)
Taeung Song (3):
perf annotate: Get correct line numbers matched
source code view.
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Jiri Olsa <jo...@redhat.com>
Signed-off-by: Taeung Song <treeze.tae...@gmail.com>
---
tools/perf/util/annotate.c | 59 +++---
1 file changed, 35 insertions(+), 24 deletions(-)
diff
-S')
So fix them regarding wrong line numbers
and Introduce new source_code collecting actual code,
not depending on 'objdump -S'.
I'd appreciate some feedback.
Thanks,
Taeung
v2:
- contains the new source code view (Namhyung)
Taeung Song (3):
perf annotate: Get correct line numbers matched
source code view.
Cc: Namhyung Kim
Cc: Jiri Olsa
Signed-off-by: Taeung Song
---
tools/perf/util/annotate.c | 59 +++---
1 file changed, 35 insertions(+), 24 deletions(-)
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index 273f21f
On 02/22/2017 08:27 PM, Namhyung Kim wrote:
On Wed, Feb 22, 2017 at 7:08 PM, Taeung Song <treeze.tae...@gmail.com> wrote:
The output of perf-annotate has a problem.
It is so confusing that the output is mixed with
both source code and assembly code.
IMHO, we need readable annotate view
On 02/22/2017 08:27 PM, Namhyung Kim wrote:
On Wed, Feb 22, 2017 at 7:08 PM, Taeung Song wrote:
The output of perf-annotate has a problem.
It is so confusing that the output is mixed with
both source code and assembly code.
IMHO, we need readable annotate view based on source code,
not mixed
On 02/22/2017 08:22 PM, Namhyung Kim wrote:
On Wed, Feb 22, 2017 at 7:08 PM, Taeung Song <treeze.tae...@gmail.com> wrote:
In the stdio interface, currently 'filename:linenr' infos
are confusedly printed in the intervals of assembly code.
So fix it.
The cause was a 0.5% filter of if sta
On 02/22/2017 08:22 PM, Namhyung Kim wrote:
On Wed, Feb 22, 2017 at 7:08 PM, Taeung Song wrote:
In the stdio interface, currently 'filename:linenr' infos
are confusedly printed in the intervals of assembly code.
So fix it.
The cause was a 0.5% filter of if statement. After fixed
Hi Namhyung,
On 02/22/2017 07:47 PM, Namhyung Kim wrote:
Hi Taeung,
On Wed, Feb 22, 2017 at 7:08 PM, Taeung Song <treeze.tae...@gmail.com> wrote:
The commit e592488c01d5 ("perf annotate: Support source line
numbers in annotate") support source line numbers in annotate.
Hi Namhyung,
On 02/22/2017 07:47 PM, Namhyung Kim wrote:
Hi Taeung,
On Wed, Feb 22, 2017 at 7:08 PM, Taeung Song wrote:
The commit e592488c01d5 ("perf annotate: Support source line
numbers in annotate") support source line numbers in annotate.
But we can get filename:l
(sym)
using addr2line() and we can handle 'struct source_code'
that contains each line of code.
In near future, it would be used for new annotate view based on
actual source code per function(sym).
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Jiri Olsa <jo...@redhat.com>
Signed-off-by:
sa <jo...@redhat.com>
Signed-off-by: Taeung Song <treeze.tae...@gmail.com>
---
tools/perf/util/annotate.c | 28 +++-
1 file changed, 19 insertions(+), 9 deletions(-)
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index 9d0aa50..acd500b 100644
---
(sym)
using addr2line() and we can handle 'struct source_code'
that contains each line of code.
In near future, it would be used for new annotate view based on
actual source code per function(sym).
Cc: Namhyung Kim
Cc: Jiri Olsa
Signed-off-by: Taeung Song
---
tools/perf/util/annotate.c | 117
Currently line numbers are wrong due to
just counting according to output of 'objdump -S'
So remove needless local variables (line_nr, lineno)
and get correct line numbers according to each address
in symbol__get_source_line().
Cc: Namhyung Kim
Cc: Jiri Olsa
Signed-off-by: Taeung Song
0.21 :40081d: mov%rsi,-0x30(%rbp)
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Jiri Olsa <jo...@redhat.com>
Signed-off-by: Taeung Song <treeze.tae...@gmail.com>
---
tools/perf/util/annotate.c | 17 ++---
1 file changed, 2 insertions(+), 15 deletions(-)
di
0.21 :40081d: mov%rsi,-0x30(%rbp)
Cc: Namhyung Kim
Cc: Jiri Olsa
Signed-off-by: Taeung Song
---
tools/perf/util/annotate.c | 17 ++---
1 file changed, 2 insertions(+), 15 deletions(-)
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index bc54e41.
he problem about line numbers.
Cc: Andi Kleen <a...@linux.intel.com>
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Jiri Olsa <jo...@redhat.com>
Signed-off-by: Taeung Song <treeze.tae...@gmail.com>
---
tools/perf/util/annotate.c | 16 +---
1 file changed, 1 inserti
he problem about line numbers.
Cc: Andi Kleen
Cc: Namhyung Kim
Cc: Jiri Olsa
Signed-off-by: Taeung Song
---
tools/perf/util/annotate.c | 16 +---
1 file changed, 1 insertion(+), 15 deletions(-)
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index 273f21f..bc54
.
(Current v1 don't consider improvement of performance of annotate
and don't make code of annotate more compact so I'll consider them in v2)
Thanks,
Taeung
Taeung Song (4):
perf annotate: Remove needless regular expression for filename:linenr
perf annotate: Align filename:linenr and more
.
(Current v1 don't consider improvement of performance of annotate
and don't make code of annotate more compact so I'll consider them in v2)
Thanks,
Taeung
Taeung Song (4):
perf annotate: Remove needless regular expression for filename:linenr
perf annotate: Align filename:linenr and more
401 - 500 of 1768 matches
Mail list logo
