Re: [PATCH v10 2/3] perf config: Reimplement perf_config() introducing new perf_config_init() and perf_config_finish()

2016-06-23 Thread Taeung Song
Hi, Arnaldo :) On 06/23/2016 08:56 PM, Arnaldo Carvalho de Melo wrote: Em Thu, Jun 23, 2016 at 05:55:18PM +0900, Taeung Song escreveu: Many sub-commands use perf_config() but everytime perf_config() is called, perf_config() always read config files. (i.e. user config '~/.perfconfig' and system

Re: [PATCH v10 2/3] perf config: Reimplement perf_config() introducing new perf_config_init() and perf_config_finish()

2016-06-23 Thread Taeung Song
Hi, Arnaldo :) On 06/23/2016 08:56 PM, Arnaldo Carvalho de Melo wrote: Em Thu, Jun 23, 2016 at 05:55:18PM +0900, Taeung Song escreveu: Many sub-commands use perf_config() but everytime perf_config() is called, perf_config() always read config files. (i.e. user config '~/.perfconfig' and system

[PATCH v10 1/3] perf config: Bring declarations about config from util/cache.h to util/config.h

2016-06-23 Thread Taeung Song
n...@huawei.com> Signed-off-by: Taeung Song <treeze.tae...@gmail.com> --- tools/perf/builtin-help.c | 2 +- tools/perf/builtin-kmem.c | 2 +- tools/perf/builtin-record.c| 1 + tools/perf/builtin-report.c| 2 +- tools/perf/builtin-top.c | 2 +- too

[PATCH v10 1/3] perf config: Bring declarations about config from util/cache.h to util/config.h

2016-06-23 Thread Taeung Song
that included previous cache.h need only config.h, remove including cache.h. Cc: Alexander Shishkin Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Namhyung Kim Cc: Wang Nan Signed-off-by: Taeung Song --- tools/perf/builtin-help.c | 2 +- tools/perf/builtin-kmem.c | 2 +- tools/perf

[PATCH v10 3/3] perf config: Reimplement show_config() using config_set__for_each

2016-06-23 Thread Taeung Song
n <alexander.shish...@linux.intel.com> Cc: Wang Nan <wangn...@huawei.com> Signed-off-by: Taeung Song <treeze.tae...@gmail.com> --- tools/perf/builtin-config.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/tools/perf/builtin-config.c b/tools

[PATCH v10 3/3] perf config: Reimplement show_config() using config_set__for_each

2016-06-23 Thread Taeung Song
Lately config_set__for_each is added. In order to let show_config() be short and clear, remake this function using config_set__for_each macro Cc: Namhyung Kim Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Alexander Shishkin Cc: Wang Nan Signed-off-by: Taeung Song --- tools/perf/builtin-config.c

[PATCH v10 0/3] perf config: Reimplement perf_config()

2016-06-23 Thread Taeung Song
only 'config' sub-commaned work because of options for config file location Taeung Song (3): perf config: Bring declarations about config from util/cache.h to util/config.h perf config: Reimplement perf_config() introducing new perf_config_init() and perf_config_finish() perf config

[PATCH v10 0/3] perf config: Reimplement perf_config()

2016-06-23 Thread Taeung Song
only 'config' sub-commaned work because of options for config file location Taeung Song (3): perf config: Bring declarations about config from util/cache.h to util/config.h perf config: Reimplement perf_config() introducing new perf_config_init() and perf_config_finish() perf config

[PATCH v10 2/3] perf config: Reimplement perf_config() introducing new perf_config_init() and perf_config_finish()

2016-06-23 Thread Taeung Song
> Cc: Ingo Molnar <mi...@redhat.com> Cc: Masami Hiramatsu <mhira...@kernel.org> Cc: Alexander Shishkin <alexander.shish...@linux.intel.com> Signed-off-by: Taeung Song <treeze.tae...@gmail.com> --- tools/perf/builtin-config.c | 4 ++ tools/perf/perf.c

[PATCH v10 2/3] perf config: Reimplement perf_config() introducing new perf_config_init() and perf_config_finish()

2016-06-23 Thread Taeung Song
set perf_config_finish() # destroy existing config set and initialize a new config set. perf_config_refresh() Cc: Namhyung Kim Cc: Jiri Olsa Cc: Wang Nan Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Masami Hiramatsu Cc: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf

Re: [PATCH v8 3/5] perf config: Reimplement perf_config() using perf_config_set__it to

2016-06-20 Thread Taeung Song
that is made by perf_config_set__new() would be reused when we initialize all actual config variables and then if using is is finished, we could free the config set. Thanks, Taeung On 06/10/2016 07:58 PM, Taeung Song wrote: On 06/09/2016 10:34 PM, Arnaldo Carvalho de Melo wrote: Em Wed, Jun 08, 2016

Re: [PATCH v8 3/5] perf config: Reimplement perf_config() using perf_config_set__it to

2016-06-20 Thread Taeung Song
that is made by perf_config_set__new() would be reused when we initialize all actual config variables and then if using is is finished, we could free the config set. Thanks, Taeung On 06/10/2016 07:58 PM, Taeung Song wrote: On 06/09/2016 10:34 PM, Arnaldo Carvalho de Melo wrote: Em Wed, Jun 08, 2016

[REFACTORING][PATCH v9 1/3] perf config: Bring declarations about config from util/cache.h to util/config.h

2016-06-20 Thread Taeung Song
n...@huawei.com> Signed-off-by: Taeung Song <treeze.tae...@gmail.com> --- tools/perf/builtin-help.c | 2 +- tools/perf/builtin-kmem.c | 2 +- tools/perf/builtin-record.c| 1 + tools/perf/builtin-report.c| 2 +- tools/perf/builtin-top.c | 2 +- too

[REFACTORING][PATCH v9 1/3] perf config: Bring declarations about config from util/cache.h to util/config.h

2016-06-20 Thread Taeung Song
that included previous cache.h need only config.h, remove including cache.h. Cc: Alexander Shishkin Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Namhyung Kim Cc: Wang Nan Signed-off-by: Taeung Song --- tools/perf/builtin-help.c | 2 +- tools/perf/builtin-kmem.c | 2 +- tools/perf

[RFC][PATCH v9 0/3] perf config: Reimplement perf_config() adding perf_config_init() and perf_config_finish()

2016-06-20 Thread Taeung Song
: - split a patch into several patches - reimplement show_config() using new perf_config() - modify perf_config_set__delete using global variable 'config_set' - reset config set when only 'config' sub-commaned work because of options for config file location Taeung Song (3): perf config: Bring

[PATCH v9 3/3] perf config: Reimplement show_config() using config_set__for_each

2016-06-20 Thread Taeung Song
n <alexander.shish...@linux.intel.com> Cc: Wang Nan <wangn...@huawei.com> Signed-off-by: Taeung Song <treeze.tae...@gmail.com> --- tools/perf/builtin-config.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/tools/perf/builtin-config.c b/tools

[PATCH v9 3/3] perf config: Reimplement show_config() using config_set__for_each

2016-06-20 Thread Taeung Song
Lately config_set__for_each is added. In order to let show_config() be short and clear, remake this function using config_set__for_each macro Cc: Namhyung Kim Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Alexander Shishkin Cc: Wang Nan Signed-off-by: Taeung Song --- tools/perf/builtin-config.c

[RFC][PATCH v9 0/3] perf config: Reimplement perf_config() adding perf_config_init() and perf_config_finish()

2016-06-20 Thread Taeung Song
: - split a patch into several patches - reimplement show_config() using new perf_config() - modify perf_config_set__delete using global variable 'config_set' - reset config set when only 'config' sub-commaned work because of options for config file location Taeung Song (3): perf config: Bring

[RFC][PATCH v9 2/3] perf config: Reimplement perf_config() adding perf_config_init() and perf_config_finish()

2016-06-20 Thread Taeung Song
i...@redhat.com> Cc: Masami Hiramatsu <mhira...@kernel.org> Cc: Alexander Shishkin <alexander.shish...@linux.intel.com> Signed-off-by: Taeung Song <treeze.tae...@gmail.com> --- tools/perf/builtin-config.c | 4 ++ tools/perf/perf.c | 2 + tools/perf/util/config.c| 92

[RFC][PATCH v9 2/3] perf config: Reimplement perf_config() adding perf_config_init() and perf_config_finish()

2016-06-20 Thread Taeung Song
() # destroy existing config set and initialize a new config set. perf_config_refresh() Cc: Namhyung Kim Cc: Jiri Olsa Cc: Wang Nan Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Masami Hiramatsu Cc: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 4

[tip:perf/core] perf config: Handle NULL at perf_config_set__delete()

2016-06-16 Thread tip-bot for Taeung Song
Commit-ID: 826424cc919529d6d234af12c6ba975b63528a74 Gitweb: http://git.kernel.org/tip/826424cc919529d6d234af12c6ba975b63528a74 Author: Taeung Song <treeze.tae...@gmail.com> AuthorDate: Wed, 8 Jun 2016 21:36:49 +0900 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> Com

[tip:perf/core] perf config: Handle NULL at perf_config_set__delete()

2016-06-16 Thread tip-bot for Taeung Song
Commit-ID: 826424cc919529d6d234af12c6ba975b63528a74 Gitweb: http://git.kernel.org/tip/826424cc919529d6d234af12c6ba975b63528a74 Author: Taeung Song AuthorDate: Wed, 8 Jun 2016 21:36:49 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 14 Jun 2016 09:29:53 -0300 perf config

Re: [PATCH v8 3/5] perf config: Reimplement perf_config() using perf_config_set__iter()

2016-06-12 Thread Taeung Song
by perf_config_set__new() would be reused when we initialize all actual config variables and then if using is is finished, we could free the config set. Thanks, Taeung On 06/10/2016 07:58 PM, Taeung Song wrote: On 06/09/2016 10:34 PM, Arnaldo Carvalho de Melo wrote: Em Wed, Jun 08, 2016 at 09

Re: [PATCH v8 3/5] perf config: Reimplement perf_config() using perf_config_set__iter()

2016-06-12 Thread Taeung Song
by perf_config_set__new() would be reused when we initialize all actual config variables and then if using is is finished, we could free the config set. Thanks, Taeung On 06/10/2016 07:58 PM, Taeung Song wrote: On 06/09/2016 10:34 PM, Arnaldo Carvalho de Melo wrote: Em Wed, Jun 08, 2016 at 09

Re: [PATCH v8 2/5] perf config: Bring declarations about config from util/cache.h to util/config.h

2016-06-12 Thread Taeung Song
ually send patches for this problem.) Thanks, Taeung On 06/11/2016 09:59 AM, Taeung Song wrote: Good evening :) On 06/11/2016 04:06 AM, Arnaldo Carvalho de Melo wrote: Em Fri, Jun 10, 2016 at 03:20:43PM +0900, Taeung Song escreveu: On 06/09/2016 10:29 PM, Arnaldo Carvalho de Melo wrote: +

Re: [PATCH v8 2/5] perf config: Bring declarations about config from util/cache.h to util/config.h

2016-06-12 Thread Taeung Song
ually send patches for this problem.) Thanks, Taeung On 06/11/2016 09:59 AM, Taeung Song wrote: Good evening :) On 06/11/2016 04:06 AM, Arnaldo Carvalho de Melo wrote: Em Fri, Jun 10, 2016 at 03:20:43PM +0900, Taeung Song escreveu: On 06/09/2016 10:29 PM, Arnaldo Carvalho de Melo wrote: +

Re: [PATCH v8 2/5] perf config: Bring declarations about config from util/cache.h to util/config.h

2016-06-10 Thread Taeung Song
Good evening :) On 06/11/2016 04:06 AM, Arnaldo Carvalho de Melo wrote: Em Fri, Jun 10, 2016 at 03:20:43PM +0900, Taeung Song escreveu: On 06/09/2016 10:29 PM, Arnaldo Carvalho de Melo wrote: +++ b/tools/perf/util/cache.h @@ -7,6 +7,7 @@ #include +#include "config.h" Why have

Re: [PATCH v8 2/5] perf config: Bring declarations about config from util/cache.h to util/config.h

2016-06-10 Thread Taeung Song
Good evening :) On 06/11/2016 04:06 AM, Arnaldo Carvalho de Melo wrote: Em Fri, Jun 10, 2016 at 03:20:43PM +0900, Taeung Song escreveu: On 06/09/2016 10:29 PM, Arnaldo Carvalho de Melo wrote: +++ b/tools/perf/util/cache.h @@ -7,6 +7,7 @@ #include +#include "config.h" Why have

Re: [PATCH v8 3/5] perf config: Reimplement perf_config() using perf_config_set__iter()

2016-06-10 Thread Taeung Song
On 06/09/2016 10:41 PM, Arnaldo Carvalho de Melo wrote: Em Wed, Jun 08, 2016 at 09:36:51PM +0900, Taeung Song escreveu: Many sub-commands use perf_config() so everytime perf_config() is called, perf_config() always read config files. (i.e. user config '~/.perfconfig' and system config

Re: [PATCH v8 3/5] perf config: Reimplement perf_config() using perf_config_set__iter()

2016-06-10 Thread Taeung Song
On 06/09/2016 10:41 PM, Arnaldo Carvalho de Melo wrote: Em Wed, Jun 08, 2016 at 09:36:51PM +0900, Taeung Song escreveu: Many sub-commands use perf_config() so everytime perf_config() is called, perf_config() always read config files. (i.e. user config '~/.perfconfig' and system config

Re: [PATCH v8 4/5] perf config: Use zfree() instead of free() at perf_config_set__delete()

2016-06-10 Thread Taeung Song
On 06/09/2016 10:37 PM, Arnaldo Carvalho de Melo wrote: Em Wed, Jun 08, 2016 at 09:36:52PM +0900, Taeung Song escreveu: perf_config_set__delete() delete allocated the config set but the global variable 'config_set' is used all around. So purge and zfree by an address of the global variable

Re: [PATCH v8 4/5] perf config: Use zfree() instead of free() at perf_config_set__delete()

2016-06-10 Thread Taeung Song
On 06/09/2016 10:37 PM, Arnaldo Carvalho de Melo wrote: Em Wed, Jun 08, 2016 at 09:36:52PM +0900, Taeung Song escreveu: perf_config_set__delete() delete allocated the config set but the global variable 'config_set' is used all around. So purge and zfree by an address of the global variable

Re: [PATCH v8 3/5] perf config: Reimplement perf_config() using perf_config_set__iter()

2016-06-10 Thread Taeung Song
On 06/09/2016 10:34 PM, Arnaldo Carvalho de Melo wrote: Em Wed, Jun 08, 2016 at 09:36:51PM +0900, Taeung Song escreveu: Many sub-commands use perf_config() so everytime perf_config() is called, perf_config() always read config files. (i.e. user config '~/.perfconfig' and system config

Re: [PATCH v8 3/5] perf config: Reimplement perf_config() using perf_config_set__iter()

2016-06-10 Thread Taeung Song
On 06/09/2016 10:34 PM, Arnaldo Carvalho de Melo wrote: Em Wed, Jun 08, 2016 at 09:36:51PM +0900, Taeung Song escreveu: Many sub-commands use perf_config() so everytime perf_config() is called, perf_config() always read config files. (i.e. user config '~/.perfconfig' and system config

Re: [PATCH v8 2/5] perf config: Bring declarations about config from util/cache.h to util/config.h

2016-06-10 Thread Taeung Song
Hi, Arnaldo :) Thank you for your review. On 06/09/2016 10:29 PM, Arnaldo Carvalho de Melo wrote: Em Wed, Jun 08, 2016 at 09:36:50PM +0900, Taeung Song escreveu: Lately util/config.h has been added but util/cache.h has declarations of functions and extern variable for config features

Re: [PATCH v8 2/5] perf config: Bring declarations about config from util/cache.h to util/config.h

2016-06-10 Thread Taeung Song
Hi, Arnaldo :) Thank you for your review. On 06/09/2016 10:29 PM, Arnaldo Carvalho de Melo wrote: Em Wed, Jun 08, 2016 at 09:36:50PM +0900, Taeung Song escreveu: Lately util/config.h has been added but util/cache.h has declarations of functions and extern variable for config features

Re: [PATCH v7 3/7] perf config: Add global variable 'config_set'

2016-06-08 Thread Taeung Song
, IMHO we need to use 'config_set' as a global variable. Anyway I sent v8 recasting this patchset with other way. (But 'config_set' is still a global variable.) Please, reconsider it again. Thanks, Taeung On 06/08/2016 12:14 AM, Taeung Song wrote: Good afternoon :) On 06/07/2016 11:05 PM, Arnaldo

Re: [PATCH v7 3/7] perf config: Add global variable 'config_set'

2016-06-08 Thread Taeung Song
, IMHO we need to use 'config_set' as a global variable. Anyway I sent v8 recasting this patchset with other way. (But 'config_set' is still a global variable.) Please, reconsider it again. Thanks, Taeung On 06/08/2016 12:14 AM, Taeung Song wrote: Good afternoon :) On 06/07/2016 11:05 PM, Arnaldo

[RFC][PATCH v8 0/5] perf config: Reimplement perf_config() using perf_config_set__inter()

2016-06-08 Thread Taeung Song
config set when only 'config' sub-commaned work because of options for config file location Taeung Song (5): perf config: Handle the error about NULL at perf_config_set__delete() perf config: Bring declarations about config from util/cache.h to util/config.h perf config: Reimplement

[RFC][PATCH v8 0/5] perf config: Reimplement perf_config() using perf_config_set__inter()

2016-06-08 Thread Taeung Song
config set when only 'config' sub-commaned work because of options for config file location Taeung Song (5): perf config: Handle the error about NULL at perf_config_set__delete() perf config: Bring declarations about config from util/cache.h to util/config.h perf config: Reimplement

[PATCH v8 3/5] perf config: Reimplement perf_config() using perf_config_set__iter()

2016-06-08 Thread Taeung Song
: Jiri Olsa <jo...@redhat.com> Cc: Wang Nan <wangn...@huawei.com> Cc: Peter Zijlstra <pet...@infradead.org> Cc: Ingo Molnar <mi...@redhat.com> Cc: Masami Hiramatsu <mhira...@kernel.org> Cc: Alexander Shishkin <alexander.shish...@linux.intel.com> Signed-off-by: Taeung

[PATCH v8 2/5] perf config: Bring declarations about config from util/cache.h to util/config.h

2016-06-08 Thread Taeung Song
ish...@linux.intel.com> Cc: Jiri Olsa <jo...@redhat.com> Cc: Masami Hiramatsu <mhira...@kernel.org> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Wang Nan <wangn...@huawei.com> Signed-off-by: Taeung Song <treeze.tae...@gmail.com> --- tools/perf/util/cache.h | 13 +---

[PATCH v8 5/5] perf config: Reimplement show_config() using perf_config_set__iter()

2016-06-08 Thread Taeung Song
sa <jo...@redhat.com> Cc: Masami Hiramatsu <mhira...@kernel.org> Cc: Alexander Shishkin <alexander.shish...@linux.intel.com> Cc: Wang Nan <wangn...@huawei.com> Signed-off-by: Taeung Song <treeze.tae...@gmail.com> --- tools/perf/builtin-config.c | 29 +++

[PATCH v8 4/5] perf config: Use zfree() instead of free() at perf_config_set__delete()

2016-06-08 Thread Taeung Song
: Namhyung Kim <namhy...@kernel.org> Cc: Jiri Olsa <jo...@redhat.com> Cc: Masami Hiramatsu <mhira...@kernel.org> Cc: Alexander Shishkin <alexander.shish...@linux.intel.com> Cc: Wang Nan <wangn...@huawei.com> Signed-off-by: Taeung Song <treeze.tae...@gmail.com> -

[PATCH v8 3/5] perf config: Reimplement perf_config() using perf_config_set__iter()

2016-06-08 Thread Taeung Song
: Peter Zijlstra Cc: Ingo Molnar Cc: Masami Hiramatsu Cc: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 4 +++ tools/perf/perf.c | 1 + tools/perf/util/config.c| 87 ++--- tools/perf/util/config.h| 1

[PATCH v8 2/5] perf config: Bring declarations about config from util/cache.h to util/config.h

2016-06-08 Thread Taeung Song
Hiramatsu Cc: Namhyung Kim Cc: Wang Nan Signed-off-by: Taeung Song --- tools/perf/util/cache.h | 13 + tools/perf/util/config.h | 12 2 files changed, 13 insertions(+), 12 deletions(-) diff --git a/tools/perf/util/cache.h b/tools/perf/util/cache.h index 0d814bb..cd8cd4d

[PATCH v8 5/5] perf config: Reimplement show_config() using perf_config_set__iter()

2016-06-08 Thread Taeung Song
: Alexander Shishkin Cc: Wang Nan Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 29 +++-- tools/perf/util/config.c| 2 +- tools/perf/util/config.h| 1 + 3 files changed, 9 insertions(+), 23 deletions(-) diff --git a/tools/perf/builtin-config.c b

[PATCH v8 4/5] perf config: Use zfree() instead of free() at perf_config_set__delete()

2016-06-08 Thread Taeung Song
: Namhyung Kim Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Alexander Shishkin Cc: Wang Nan Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 2 +- tools/perf/perf.c | 2 +- tools/perf/util/config.c| 10 +- tools/perf/util/config.h| 2 +- 4 files changed, 8

[BUGFIX][PATCH v8 1/5] perf config: Handle the error about NULL at perf_config_set__delete()

2016-06-08 Thread Taeung Song
t.com> Cc: Masami Hiramatsu <mhira...@kernel.org> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Wang Nan <wangn...@huawei.com> Signed-off-by: Taeung Song <treeze.tae...@gmail.com> --- tools/perf/util/config.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/perf/util

[BUGFIX][PATCH v8 1/5] perf config: Handle the error about NULL at perf_config_set__delete()

2016-06-08 Thread Taeung Song
-off-by: Taeung Song --- tools/perf/util/config.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c index 8749eca..31e09a4 100644 --- a/tools/perf/util/config.c +++ b/tools/perf/util/config.c @@ -742,6 +742,9 @@ static void

[tip:perf/core] perf config: Constructor should free its allocated memory when failing

2016-06-08 Thread tip-bot for Taeung Song
Commit-ID: 25d8f48f78f37dd6af08bd11212ab3d53a4c8cc6 Gitweb: http://git.kernel.org/tip/25d8f48f78f37dd6af08bd11212ab3d53a4c8cc6 Author: Taeung Song <treeze.tae...@gmail.com> AuthorDate: Tue, 7 Jun 2016 18:26:11 +0900 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> Commit

[tip:perf/core] perf config: Constructor should free its allocated memory when failing

2016-06-08 Thread tip-bot for Taeung Song
Commit-ID: 25d8f48f78f37dd6af08bd11212ab3d53a4c8cc6 Gitweb: http://git.kernel.org/tip/25d8f48f78f37dd6af08bd11212ab3d53a4c8cc6 Author: Taeung Song AuthorDate: Tue, 7 Jun 2016 18:26:11 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 7 Jun 2016 10:58:55 -0300 perf config

[tip:perf/core] perf config: Use new perf_config_set__init() to initialize config set

2016-06-08 Thread tip-bot for Taeung Song
Commit-ID: 8beeb00f2c8498686eee02b8edcd1488b903c90b Gitweb: http://git.kernel.org/tip/8beeb00f2c8498686eee02b8edcd1488b903c90b Author: Taeung Song <treeze.tae...@gmail.com> AuthorDate: Tue, 7 Jun 2016 18:26:12 +0900 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> Commit

[tip:perf/core] perf config: Use new perf_config_set__init() to initialize config set

2016-06-08 Thread tip-bot for Taeung Song
Commit-ID: 8beeb00f2c8498686eee02b8edcd1488b903c90b Gitweb: http://git.kernel.org/tip/8beeb00f2c8498686eee02b8edcd1488b903c90b Author: Taeung Song AuthorDate: Tue, 7 Jun 2016 18:26:12 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 7 Jun 2016 11:01:25 -0300 perf config: Use

[tip:perf/core] perf config: Handle the error when config set is NULL at collect_config()

2016-06-08 Thread tip-bot for Taeung Song
Commit-ID: 7db91f251056f90fec4121f028680ab3153a0f3c Gitweb: http://git.kernel.org/tip/7db91f251056f90fec4121f028680ab3153a0f3c Author: Taeung Song <treeze.tae...@gmail.com> AuthorDate: Mon, 6 Jun 2016 19:52:54 +0900 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> Commit

[tip:perf/core] perf config: Handle the error when config set is NULL at collect_config()

2016-06-08 Thread tip-bot for Taeung Song
Commit-ID: 7db91f251056f90fec4121f028680ab3153a0f3c Gitweb: http://git.kernel.org/tip/7db91f251056f90fec4121f028680ab3153a0f3c Author: Taeung Song AuthorDate: Mon, 6 Jun 2016 19:52:54 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 6 Jun 2016 17:43:19 -0300 perf config

[tip:perf/core] perf config: Fix abnormal termination at perf_parse_file()

2016-06-08 Thread tip-bot for Taeung Song
Commit-ID: 78f71c996fb92d129ec75d572e2f5367a4f4c757 Gitweb: http://git.kernel.org/tip/78f71c996fb92d129ec75d572e2f5367a4f4c757 Author: Taeung Song <treeze.tae...@gmail.com> AuthorDate: Mon, 6 Jun 2016 19:52:52 +0900 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> Commit

[tip:perf/core] perf config: Fix abnormal termination at perf_parse_file()

2016-06-08 Thread tip-bot for Taeung Song
Commit-ID: 78f71c996fb92d129ec75d572e2f5367a4f4c757 Gitweb: http://git.kernel.org/tip/78f71c996fb92d129ec75d572e2f5367a4f4c757 Author: Taeung Song AuthorDate: Mon, 6 Jun 2016 19:52:52 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 6 Jun 2016 17:43:17 -0300 perf config: Fix

Re: [GIT PULL 00/24] perf/core improvements and fixes

2016-06-07 Thread Taeung Song
consistently and also stop using the _get_ term for non-reference count methods (Arnaldo Carvalho de Melo) - 'perf config' refactorings (Taeung Song) Signed-off-by: Arnaldo Carvalho de Melo <a...@redhat.com> Arnaldo Carvalho

Re: [GIT PULL 00/24] perf/core improvements and fixes

2016-06-07 Thread Taeung Song
consistently and also stop using the _get_ term for non-reference count methods (Arnaldo Carvalho de Melo) - 'perf config' refactorings (Taeung Song) Signed-off-by: Arnaldo Carvalho de Melo Arnaldo Carvalho de Melo (7):

Re: [PATCH v7 3/7] perf config: Add global variable 'config_set'

2016-06-07 Thread Taeung Song
Good afternoon :) On 06/07/2016 11:05 PM, Arnaldo Carvalho de Melo wrote: Em Tue, Jun 07, 2016 at 06:26:13PM +0900, Taeung Song escreveu: The config set is prepared by collecting all configs from config files (i.e. user config ~/.perfconfig and system config $(sysconfdir)/perfconfig) so

Re: [PATCH v7 3/7] perf config: Add global variable 'config_set'

2016-06-07 Thread Taeung Song
Good afternoon :) On 06/07/2016 11:05 PM, Arnaldo Carvalho de Melo wrote: Em Tue, Jun 07, 2016 at 06:26:13PM +0900, Taeung Song escreveu: The config set is prepared by collecting all configs from config files (i.e. user config ~/.perfconfig and system config $(sysconfdir)/perfconfig) so

[PATCH v7 2/7] perf config: Use new perf_config_set__init() to initialize config set

2016-06-07 Thread Taeung Song
config. Cc: Namhyung Kim <namhy...@kernel.org> Cc: Jiri Olsa <jo...@redhat.com> Cc: Masami Hiramatsu <mhira...@kernel.org> Cc: Alexander Shishkin <alexander.shish...@linux.intel.com> Signed-off-by: Taeung Song <treeze.tae...@gmail.com> ---

[PATCH v7 2/7] perf config: Use new perf_config_set__init() to initialize config set

2016-06-07 Thread Taeung Song
config. Cc: Namhyung Kim Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/util/config.c | 47 ++- 1 file changed, 46 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/config.c b/tools/perf

[PATCH v7 4/7] perf config: Use zfree() instead of free() at perf_config_set__delete()

2016-06-07 Thread Taeung Song
: Namhyung Kim <namhy...@kernel.org> Cc: Jiri Olsa <jo...@redhat.com> Cc: Masami Hiramatsu <mhira...@kernel.org> Cc: Alexander Shishkin <alexander.shish...@linux.intel.com> Signed-off-by: Taeung Song <treeze.tae...@gmail.com> --- tools/perf/builtin-config.c | 2 +- to

[PATCH v7 4/7] perf config: Use zfree() instead of free() at perf_config_set__delete()

2016-06-07 Thread Taeung Song
: Namhyung Kim Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 2 +- tools/perf/util/config.c| 11 +++ tools/perf/util/config.h| 2 +- 3 files changed, 9 insertions(+), 6 deletions(-) diff --git a/tools

[BUGFIX][PATCH v7 1/7] perf config: If collect_config() is failed, finally free a config set after it is done

2016-06-07 Thread Taeung Song
set in collect_config(). Cc: Namhyung Kim <namhy...@kernel.org> Cc: Jiri Olsa <jo...@redhat.com> Cc: Masami Hiramatsu <mhira...@kernel.org> Cc: Alexander Shishkin <alexander.shish...@linux.intel.com> Signed-off-by: Taeung Song <treeze.tae...@gmail.com> --- tools/pe

[BUGFIX][PATCH v7 1/7] perf config: If collect_config() is failed, finally free a config set after it is done

2016-06-07 Thread Taeung Song
set in collect_config(). Cc: Namhyung Kim Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/util/config.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c index

[PATCH v7 3/7] perf config: Add global variable 'config_set'

2016-06-07 Thread Taeung Song
will be handled in perf_config() and other functions at util/config.c Cc: Namhyung Kim <namhy...@kernel.org> Cc: Jiri Olsa <jo...@redhat.com> Cc: Masami Hiramatsu <mhira...@kernel.org> Cc: Alexander Shishkin <alexander.shish...@linux.intel.com> Signed-off-by: Taeung Song <treeze.t

[PATCH v7 3/7] perf config: Add global variable 'config_set'

2016-06-07 Thread Taeung Song
will be handled in perf_config() and other functions at util/config.c Cc: Namhyung Kim Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 9 - tools/perf/util/config.c| 1 + tools/perf/util/config.h| 2 ++ 3 files changed

[PATCH v7 7/7] perf config: Reimplement show_config() using perf_config()

2016-06-07 Thread Taeung Song
sa <jo...@redhat.com> Cc: Masami Hiramatsu <mhira...@kernel.org> Cc: Alexander Shishkin <alexander.shish...@linux.intel.com> Signed-off-by: Taeung Song <treeze.tae...@gmail.com> --- tools/perf/builtin-config.c | 29 +++-- 1 file changed, 7 insertions(+

[PATCH v7 7/7] perf config: Reimplement show_config() using perf_config()

2016-06-07 Thread Taeung Song
: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 29 +++-- 1 file changed, 7 insertions(+), 22 deletions(-) diff --git a/tools/perf/builtin-config.c b/tools/perf/builtin-config.c index 4dab41e..b6ae8ea 100644 --- a/tools/perf/builtin

[PATCH v7 5/7] perf config: Reimplement perf_config() using perf_config_set__iter()

2016-06-07 Thread Taeung Song
g Nan <wangn...@huawei.com> Cc: Peter Zijlstra <pet...@infradead.org> Cc: Ingo Molnar <mi...@redhat.com> Cc: Masami Hiramatsu <mhira...@kernel.org> Cc: Alexander Shishkin <alexander.shish...@linux.intel.com> Signed-off-by: Taeung Song <treeze.tae...@gmail.com>

[PATCH v7 6/7] perf config: Reset the config set at only 'config' sub-command

2016-06-07 Thread Taeung Song
be reset at the very beginning at cmd_config() Cc: Namhyung Kim <namhy...@kernel.org> Cc: Jiri Olsa <jo...@redhat.com> Cc: Masami Hiramatsu <mhira...@kernel.org> Cc: Alexander Shishkin <alexander.shish...@linux.intel.com> Signed-off-by: Taeung Song <treeze.tae...@gmail.c

[PATCH v7 5/7] perf config: Reimplement perf_config() using perf_config_set__iter()

2016-06-07 Thread Taeung Song
: Masami Hiramatsu Cc: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/perf.c| 1 + tools/perf/util/cache.h | 1 + tools/perf/util/config.c | 86 +++- 3 files changed, 43 insertions(+), 45 deletions(-) diff --git a/tools/perf/perf.c

[PATCH v7 6/7] perf config: Reset the config set at only 'config' sub-command

2016-06-07 Thread Taeung Song
be reset at the very beginning at cmd_config() Cc: Namhyung Kim Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tools/perf/builtin-config.c b/tools/perf/builtin-config.c

[RFC][PATCH v7 0/9] perf config: Reimplement perf_config() using perf_config_set__inter()

2016-06-07 Thread Taeung Song
Taeung Song (7): perf config: If collect_config() is failed, finally free a config set after it is done perf config: Use new perf_config_set__init() to initialize config set perf config: Add global variable 'config_set' perf config: Use zfree() instead of free

[RFC][PATCH v7 0/9] perf config: Reimplement perf_config() using perf_config_set__inter()

2016-06-07 Thread Taeung Song
Taeung Song (7): perf config: If collect_config() is failed, finally free a config set after it is done perf config: Use new perf_config_set__init() to initialize config set perf config: Add global variable 'config_set' perf config: Use zfree() instead of free

Re: [BUGFIX][PATCH v6 2/9] perf config: If collect_config() is failed, finally free a config set after it is done

2016-06-07 Thread Taeung Song
On 06/07/2016 06:37 AM, Taeung Song wrote: On 06/07/2016 05:23 AM, Arnaldo Carvalho de Melo wrote: Em Mon, Jun 06, 2016 at 07:52:53PM +0900, Taeung Song escreveu: Because of die() at perf_parse_file() a config set was freed in collect_config(), if failed. But it is natural to free a config

Re: [BUGFIX][PATCH v6 2/9] perf config: If collect_config() is failed, finally free a config set after it is done

2016-06-07 Thread Taeung Song
On 06/07/2016 06:37 AM, Taeung Song wrote: On 06/07/2016 05:23 AM, Arnaldo Carvalho de Melo wrote: Em Mon, Jun 06, 2016 at 07:52:53PM +0900, Taeung Song escreveu: Because of die() at perf_parse_file() a config set was freed in collect_config(), if failed. But it is natural to free a config

[BUGFIX][RESEND PATCH v6] perf config: If collect_config() is failed, finally free a config set after it is done

2016-06-06 Thread Taeung Song
set in collect_config(). Cc: Namhyung Kim <namhy...@kernel.org> Cc: Jiri Olsa <jo...@redhat.com> Cc: Masami Hiramatsu <mhira...@kernel.org> Cc: Alexander Shishkin <alexander.shish...@linux.intel.com> Signed-off-by: Taeung Song <treeze.tae...@gmail.com> --- tools/pe

[BUGFIX][RESEND PATCH v6] perf config: If collect_config() is failed, finally free a config set after it is done

2016-06-06 Thread Taeung Song
set in collect_config(). Cc: Namhyung Kim Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/util/config.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c index

Re: [BUGFIX][PATCH v6 2/9] perf config: If collect_config() is failed, finally free a config set after it is done

2016-06-06 Thread Taeung Song
On 06/07/2016 05:23 AM, Arnaldo Carvalho de Melo wrote: Em Mon, Jun 06, 2016 at 07:52:53PM +0900, Taeung Song escreveu: Because of die() at perf_parse_file() a config set was freed in collect_config(), if failed. But it is natural to free a config set after collect_config() is done when some

Re: [BUGFIX][PATCH v6 2/9] perf config: If collect_config() is failed, finally free a config set after it is done

2016-06-06 Thread Taeung Song
On 06/07/2016 05:23 AM, Arnaldo Carvalho de Melo wrote: Em Mon, Jun 06, 2016 at 07:52:53PM +0900, Taeung Song escreveu: Because of die() at perf_parse_file() a config set was freed in collect_config(), if failed. But it is natural to free a config set after collect_config() is done when some

Re: [PATCH v4 1/6] perf config: Use new perf_config_set__init() to initialize config set

2016-06-06 Thread Taeung Song
Hi, Arnaldo :) Did you have a nice weekend? I sent this mail for nothing else but to tell the reason of v6 to you. On 06/01/2016 01:52 AM, Taeung Song wrote: On 05/31/2016 10:43 PM, Arnaldo Carvalho de Melo wrote: Em Tue, May 31, 2016 at 10:13:43AM +0900, Taeung Song escreveu: Instead

Re: [PATCH v4 1/6] perf config: Use new perf_config_set__init() to initialize config set

2016-06-06 Thread Taeung Song
Hi, Arnaldo :) Did you have a nice weekend? I sent this mail for nothing else but to tell the reason of v6 to you. On 06/01/2016 01:52 AM, Taeung Song wrote: On 05/31/2016 10:43 PM, Arnaldo Carvalho de Melo wrote: Em Tue, May 31, 2016 at 10:13:43AM +0900, Taeung Song escreveu: Instead

[BUGFIX][PATCH v6 2/9] perf config: If collect_config() is failed, finally free a config set after it is done

2016-06-06 Thread Taeung Song
set in collect_config(). Cc: Namhyung Kim <namhy...@kernel.org> Cc: Jiri Olsa <jo...@redhat.com> Cc: Masami Hiramatsu <mhira...@kernel.org> Cc: Alexander Shishkin <alexander.shish...@linux.intel.com> Signed-off-by: Taeung Song <treeze.tae...@gmail.com> --- tools/perf/

[BUGFIX][PATCH v6 2/9] perf config: If collect_config() is failed, finally free a config set after it is done

2016-06-06 Thread Taeung Song
set in collect_config(). Cc: Namhyung Kim Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/util/config.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c index b500737

[PATCH v6 5/9] perf config: Add global variable 'config_set'

2016-06-06 Thread Taeung Song
will be handled in perf_config() and other functions at util/config.c Cc: Namhyung Kim <namhy...@kernel.org> Cc: Jiri Olsa <jo...@redhat.com> Cc: Masami Hiramatsu <mhira...@kernel.org> Cc: Alexander Shishkin <alexander.shish...@linux.intel.com> Signed-off-by: Taeung Song <treeze.t

[PATCH v6 5/9] perf config: Add global variable 'config_set'

2016-06-06 Thread Taeung Song
will be handled in perf_config() and other functions at util/config.c Cc: Namhyung Kim Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 9 - tools/perf/util/config.c| 1 + tools/perf/util/config.h| 2 ++ 3 files changed

[PATCH v6 9/9] perf config: Reimplement show_config() using perf_config()

2016-06-06 Thread Taeung Song
sa <jo...@redhat.com> Cc: Masami Hiramatsu <mhira...@kernel.org> Cc: Alexander Shishkin <alexander.shish...@linux.intel.com> Signed-off-by: Taeung Song <treeze.tae...@gmail.com> --- tools/perf/builtin-config.c | 29 +++-- 1 file changed, 7 insertions(+

[BUGFIX][PATCH v6 3/9] perf config: Handle the error when config set is NULL at collect_config()

2016-06-06 Thread Taeung Song
; Cc: Masami Hiramatsu <mhira...@kernel.org> Cc: Alexander Shishkin <alexander.shish...@linux.intel.com> Signed-off-by: Taeung Song <treeze.tae...@gmail.com> --- tools/perf/util/config.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/config.c b/

[PATCH v6 7/9] perf config: Reimplement perf_config() using perf_config_set__iter()

2016-06-06 Thread Taeung Song
g Nan <wangn...@huawei.com> Cc: Peter Zijlstra <pet...@infradead.org> Cc: Ingo Molnar <mi...@redhat.com> Cc: Masami Hiramatsu <mhira...@kernel.org> Cc: Alexander Shishkin <alexander.shish...@linux.intel.com> Signed-off-by: Taeung Song <treeze.tae...@gmail.com>

[PATCH v6 8/9] perf config: Reset the config set at only 'config' sub-command

2016-06-06 Thread Taeung Song
be reset at the very beginning at cmd_config() Cc: Namhyung Kim <namhy...@kernel.org> Cc: Jiri Olsa <jo...@redhat.com> Cc: Masami Hiramatsu <mhira...@kernel.org> Cc: Alexander Shishkin <alexander.shish...@linux.intel.com> Signed-off-by: Taeung Song <treeze.tae...@gmail.c

[PATCH v6 7/9] perf config: Reimplement perf_config() using perf_config_set__iter()

2016-06-06 Thread Taeung Song
: Masami Hiramatsu Cc: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/perf.c| 1 + tools/perf/util/cache.h | 1 + tools/perf/util/config.c | 86 +++- 3 files changed, 43 insertions(+), 45 deletions(-) diff --git a/tools/perf/perf.c

[PATCH v6 8/9] perf config: Reset the config set at only 'config' sub-command

2016-06-06 Thread Taeung Song
be reset at the very beginning at cmd_config() Cc: Namhyung Kim Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tools/perf/builtin-config.c b/tools/perf/builtin-config.c

[PATCH v6 9/9] perf config: Reimplement show_config() using perf_config()

2016-06-06 Thread Taeung Song
: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 29 +++-- 1 file changed, 7 insertions(+), 22 deletions(-) diff --git a/tools/perf/builtin-config.c b/tools/perf/builtin-config.c index 4dab41e..b6ae8ea 100644 --- a/tools/perf/builtin

[BUGFIX][PATCH v6 3/9] perf config: Handle the error when config set is NULL at collect_config()

2016-06-06 Thread Taeung Song
-by: Taeung Song --- tools/perf/util/config.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c index d013f90..062eeb8 100644 --- a/tools/perf/util/config.c +++ b/tools/perf/util/config.c @@ -607,8 +607,12 @@ static int

[BUGFIX][PATCH v6 1/9] perf config: Fix the problem of abnormal termination at perf_parse_file()

2016-06-06 Thread Taeung Song
mhy...@kernel.org> Cc: Jiri Olsa <jo...@redhat.com> Cc: Masami Hiramatsu <mhira...@kernel.org> Cc: Alexander Shishkin <alexander.shish...@linux.intel.com> Signed-off-by: Taeung Song <treeze.tae...@gmail.com> --- tools/perf/util/config.c | 16 +++- 1 file changed

[BUGFIX][PATCH v6 1/9] perf config: Fix the problem of abnormal termination at perf_parse_file()

2016-06-06 Thread Taeung Song
Olsa Cc: Masami Hiramatsu Cc: Alexander Shishkin Signed-off-by: Taeung Song --- tools/perf/util/config.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c index dad7d82..b500737 100644 --- a/tools/perf/util

<    4   5   6   7   8   9   10   11   12   13   >