uals to or less than
SND_FF_MAXIMIM_MIDI_QUADS (= 9). For latter protocol, the value is
equals to or less than 3. Anyway, the value should not be larger
than 16777 and the calculation can be done without ULL suffix.
Reviewd-by: Takashi Sakamoto
> diff --git a/sound/firewire/fireface/ff-transact
rror code is checked immediately. The range of value is equal to
or less than 3 when reaching the calculation, thus it should be less than
16777.
Regardless of the type of 'int' or 'unsigned int', this patch can fix
the issued problem. Feel free to add my tag when you post second version
with comment
am.h:273:6-19: WARNING: Comparison to bool
> >
> > Reported-by: Tosk Robot
> > Signed-off-by: Kaixu Xia
The message seems not to reach my mailbox. Anyway:
Acked-by: Takashi Sakamoto
> Thanks, applied.
>
>
> Takashi
>
> > ---
> > sound/firewire/amdtp-stream.
+++---
> drivers/firewire/core-iso.c | 2 +-
> include/linux/firewire.h | 17 -
> 3 files changed, 12 insertions(+), 13 deletions(-)
Oscar Carter has posted a patch to fix it.
https://sourceforge.net/p/linux1394/mailman/message/37024966/
I don't know exactly but maintainers seems to overlook it...
Thanks
Takashi Sakamoto
efw->supported_sampling_rate,
> + runtime->hw.rates = efw->supported_sampling_rate;
> snd_pcm_limit_hw_rates(runtime);
>
> limit_channels(>hw, pcm_channels);
Oops. It seems to be my typo added at the commit aa02bb6e6078
("ALSA: fireworks: Add PCM interface")...
Acked-by: Takashi Sakamoto
Thanks
Takashi Sakamoto
nd declarative. This way avoid the call to a function with one
> purpose to achieved another one.
>
> Co-developed-by: Takashi Sakamoto
> Signed-off-by: Takashi Sakamoto
> Co-developed-by: Stefan Richter
> Signed-off-by: Stefan Richter
> Signed-off-by: Oscar Carter
> --
snd_set_vender_interface);
I think the symbol name has typo; 'vender' against 'vendor'.
Anyway, this feature is not widely used at present. I suggest to add
kernel configuration for the feature at kernel compilation time, IMO.
Regards
Takashi Sakamoto
ace, I wrote the similar patch but judged it's a bit ad-hoc
way that callback functions are assigned after the call of
fw_iso_context_create() in raw code. For explicitness in a point of things
being declarative, I put the inline function into header, and avoid
someone's misfortune for future even if IEEE 1394 is enough legacy.
Anyway, I don't mind Stefan's proposal since it works well. It depends
on developers' fashion to choose policy to write codes.
Thanks
Takashi Sakamoto
by libhinoko
Reported-by: Oscar Carter
Reference:
https://lore.kernel.org/lkml/20200519173425.4724-1-oscar.car...@gmx.com/
Signed-off-by: Takashi Sakamoto
---
drivers/firewire/core-cdev.c | 40 +++-
include/linux/firewire.h | 16 +++
2 files changed, 33
Hi Greg,
On Sat, May 23, 2020 at 08:10:33AM +0200, Greg KH wrote:
> On Fri, May 22, 2020 at 07:43:08PM +0200, Oscar Carter wrote:
> > Hi,
> >
> > On Wed, May 20, 2020 at 03:16:24PM +0900, Takashi Sakamoto wrote:
> > > Hi,
> > >
> > > I'm an author
This commit obsoletes cast of function callback to assist attempt of
Control Flow Integrity builds.
Reported-by: Oscar Carter
Reference:
https://lore.kernel.org/lkml/20200519173425.4724-1-oscar.car...@gmx.com/
Signed-off-by: Takashi Sakamoto
---
drivers/firewire/core-cdev.c | 44
. Although the
API is exported in the patchset, it's better to discuss about unexporting
the API.
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/firewire/core-cdev.c#n985
[2] https://lore.kernel.org/lkml/20200519173425.4724-1-oscar.car...@gmx.com/
Regards
Takashi
, no in-kernel driver uses the mode
and the additional kernel API is never used at present.
Reported-by: Oscar Carter
Reference:
https://lore.kernel.org/lkml/20200519173425.4724-1-oscar.car...@gmx.com/
Signed-off-by: Takashi Sakamoto
---
drivers/firewire/core-iso.c | 17 +
include/linux
_callback_t). This idea leaves
current drivers as is and the change is done inner firewire-core driver,
therefore existent kernel API is not changed.
Later I post two patches for the proposal. I'd like you to review it and
I'm glad to receive your comments.
Regards
Takashi Sakamoto
ith the help of Coccinelle.
>
> [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
> [2] https://github.com/KSPP/linux/issues/21
> [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")
>
> Signed-off-by: Gustavo A. R. Silva
> ---
> sound/firewire/firewor
header.
Signed-off-by: Takashi Sakamoto
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 4200194e69ea..6bd54ce6dc66 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6271,6 +6271,7 @@ L:alsa-de...@alsa-project.org (moderated for
non
On Sat, Aug 31, 2019 at 05:27:13PM +0200, Takashi Iwai wrote:
> On Fri, 30 Aug 2019 15:24:46 +0200,
> Takashi Sakamoto wrote:
> >
> > This commit adds myself as one of maintainers for firewire audio
> > drivers and IEC 61883-1/6 packet streaming engine. I call them
to post their issues, especially for
regression.
Signed-off-by: Takashi Sakamoto
---
MAINTAINERS | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 24e29b2e53c9..8929a2ec75f7 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6264,8 +6264,9 @@ S
rtion(+), 1 deletion(-)
Reviewed-by: Takashi Sakamoto
And this bug exists till its first commit for v2.6.39.
Fixes: 31ef9134eb52 ("ALSA: add LaCie FireWire Speakers/Griffin FireWave
Surround driver")
Cc: # v2.6.39+
Thanks
Takashi Sakamoto
ewire-lib: refactoring to obsolete IR packet handler").
https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git/commit/?id=98e3e43b599d742c104864c6772a251025ffb52b
Thanks
Takashi Sakamoto
nstead.
>
> Signed-off-by: Ross Zwisler
> ---
> MAINTAINERS | 13 ++---
> 1 file changed, 6 insertions(+), 7 deletions(-)
This is a good catch.
Reviewed-by: Takashi Sakamoto
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e17ebf70b5480..d373d976a9317 100644
Hi,
On 2018/11/01 22:04, Arnaldo Carvalho de Melo wrote:
Em Thu, Nov 01, 2018 at 08:54:45PM +0900, Takashi Sakamoto escreveu:
Hi Arnaldo,
On Nov 1 2018 4:29, Arnaldo Carvalho de Melo wrote:
Wouldn't a symlink be simpler?
That would be equivalent to using it directly, see my response
Hi,
On 2018/11/01 22:04, Arnaldo Carvalho de Melo wrote:
Em Thu, Nov 01, 2018 at 08:54:45PM +0900, Takashi Sakamoto escreveu:
Hi Arnaldo,
On Nov 1 2018 4:29, Arnaldo Carvalho de Melo wrote:
Wouldn't a symlink be simpler?
That would be equivalent to using it directly, see my response
' in a
development period for Linux kernel v4.21[1]. Would I need to add you to
C.C list of the future patch to notify the change, or things go well
without such special care for your side?
[1]
https://github.com/takaswie/presentations/blob/master/20181021/contents.md
Regards
Takashi Sakamoto
' in a
development period for Linux kernel v4.21[1]. Would I need to add you to
C.C list of the future patch to notify the change, or things go well
without such special care for your side?
[1]
https://github.com/takaswie/presentations/blob/master/20181021/contents.md
Regards
Takashi Sakamoto
On 2018年10月09日 04:39, Connor McAdams wrote:
This patch set fixes the microphone inconsistency issue, which means
the microphone now works all the time on all of the cards I've tested
(ZxR, Z, AE-5), along with the input effects.
It also includes changes suggested by Takashi Sakamoto, I believe
On 2018年10月09日 04:39, Connor McAdams wrote:
This patch set fixes the microphone inconsistency issue, which means
the microphone now works all the time on all of the cards I've tested
(ZxR, Z, AE-5), along with the input effects.
It also includes changes suggested by Takashi Sakamoto, I believe
/ca0132 - Add ZxR exit commands
sound/pci/hda/patch_ca0132.c | 369 ---
1 file changed, 345 insertions(+), 24 deletions(-)
I reviewed the above patches and they looks good to be merged to
upstream.
Reviewed-by: Takashi Sakamoto
I've already point some
/ca0132 - Add ZxR exit commands
sound/pci/hda/patch_ca0132.c | 369 ---
1 file changed, 345 insertions(+), 24 deletions(-)
I reviewed the above patches and they looks good to be merged to
upstream.
Reviewed-by: Takashi Sakamoto
I've already point some
num
- ae5_add_headphone_gain_enum
- ae5_add_sound_filter_enum
- zxr_add_headphone_gain_switch
This is not a strong request and you can work for it after merging this
patchset. We have two weeks more till next merge window.
Regards
Takashi Sakamoto
num
- ae5_add_headphone_gain_enum
- ae5_add_sound_filter_enum
- zxr_add_headphone_gain_switch
This is not a strong request and you can work for it after merging this
patchset. We have two weeks more till next merge window.
Regards
Takashi Sakamoto
)
->'spec' preparation (assignment to members in ca0132_spec, etc.)
Regards
Takashi Sakamoto
)
->'spec' preparation (assignment to members in ca0132_spec, etc.)
Regards
Takashi Sakamoto
insertions(+)
Reviewed-by: Takashi Sakamoto
Tested-by: Takashi Sakamoto
Thanks
Takashi Sakamoto
insertions(+)
Reviewed-by: Takashi Sakamoto
Tested-by: Takashi Sakamoto
Thanks
Takashi Sakamoto
/sound.git/log/?h=for-4.19
Thanks
Takashi Sakamoto
/sound.git/log/?h=for-4.19
Thanks
Takashi Sakamoto
[2] ASoC: fix 0-day warnings with snd_soc_new_compress()
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/?h=for-4.18=0b014d72ebae14c0c6ab3fb36a442fda91e1a1b3
Thanks
Takashi Sakamoto
[2] ASoC: fix 0-day warnings with snd_soc_new_compress()
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/?h=for-4.18=0b014d72ebae14c0c6ab3fb36a442fda91e1a1b3
Thanks
Takashi Sakamoto
t the same
as the third argument of xen_snd_front_stream_prepare() because it is
'u8'. This patch looks good to me.
Reviewed-by: Takashi Sakamoto <o-taka...@sakamoccchi.jp>
Regards
Takashi Sakamoto
re() because it is
'u8'. This patch looks good to me.
Reviewed-by: Takashi Sakamoto
Regards
Takashi Sakamoto
}
- if (ret < 0)
- goto fail;
front_info->num_evt_pairs = num_streams;
return 0;
Yep. All branches for error path on the nested for loop have goto
statement, thus no need to check error outer the loop.
Reviewed-by: Takashi Sakamoto <o-taka...@sakamocchi.jp>
Takashi Sakamoto
front_info->num_evt_pairs = num_streams;
return 0;
Yep. All branches for error path on the nested for loop have goto
statement, thus no need to check error outer the loop.
Reviewed-by: Takashi Sakamoto
Takashi Sakamoto
5970af9
[2]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4b671f577474
[3]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b602aa8eb1a0
[4]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=fccf53881e9b
Regards
Takashi Sakamoto
5970af9
[2]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4b671f577474
[3]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b602aa8eb1a0
[4]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=fccf53881e9b
Regards
Takashi Sakamoto
Hi,
On May 21 2018 20:58, Yisheng Xie wrote:
match_string() returns the index of an array for a matching string,
which can be used intead of open coded variant.
Cc: Clemens Ladisch <clem...@ladisch.de>
Cc: Jaroslav Kysela <pe...@perex.cz>
Cc: Takashi Iwai <ti...@suse.com>
Cc
Hi,
On May 21 2018 20:58, Yisheng Xie wrote:
match_string() returns the index of an array for a matching string,
which can be used intead of open coded variant.
Cc: Clemens Ladisch
Cc: Jaroslav Kysela
Cc: Takashi Iwai
Cc: Takashi Sakamoto
Cc: alsa-de...@alsa-project.org
Signed-off
c: alsa-de...@alsa-project.org
Signed-off-by: Yisheng Xie <xieyishe...@huawei.com>
---
sound/firewire/oxfw/oxfw.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
Reviewed-by: Takashi Sakamoto <o-taka...@sakamocchi.jp>
For my information, use_match_string() helper was fir
/firewire/oxfw/oxfw.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
Reviewed-by: Takashi Sakamoto
For my information, use_match_string() helper was firstly introduced to
v4.6 kernel by a commit 56b060814e2d ('lib/string: introduce
match_string() helper').
diff --git a/sound
patches.
Reviewed-by: Takashi Sakamoto <o-taka...@sakamocchi.jp>
There're some points to improve such like read-only memory objects, and
I'll post some patches for them after merging this patchset.
Thanks
Takashi Sakamoto
patches.
Reviewed-by: Takashi Sakamoto
There're some points to improve such like read-only memory objects, and
I'll post some patches for them after merging this patchset.
Thanks
Takashi Sakamoto
.reqs = { 0x18, 0x01, 0x1F, 0x15,
+ 0x3A, 0x1A, 0x1B, 0x1C },
+ .vals = { 0x, 0x, 0x,
+ 0x, 0x, 0x,
+ 0x, 0x }
+ }
+};
+
It's better to add 'const' qualifier.
Regards
Takashi Sakamoto
eqs = { 0x18, 0x01, 0x1F, 0x15,
+ 0x3A, 0x1A, 0x1B, 0x1C },
+ .vals = { 0x, 0x, 0x,
+ 0x, 0x, 0x,
+ 0x, 0x }
+ }
+};
+
It's better to add 'const' qualifier.
Regards
Takashi Sakamoto
_param()
* dspio_alloc_dma_chan()
* dspio_free_dma_chan()
* Changes for SBZ only
* Changes for R3Di only
Could you please prepare for these three patches from this large patch
in your next chance? Especially, you can describe enough information to
the latter two patches as patch comment.
Thanks
Takashi Sakamoto
()
* dspio_free_dma_chan()
* Changes for SBZ only
* Changes for R3Di only
Could you please prepare for these three patches from this large patch
in your next chance? Especially, you can describe enough information to
the latter two patches as patch comment.
Thanks
Takashi Sakamoto
letter.
For its content, please refer to cover letters by the other developers
in alsa-devel archive.
http://mailman.alsa-project.org/pipermail/alsa-devel/
Thanks
Takashi Sakamoto
letter.
For its content, please refer to cover letters by the other developers
in alsa-devel archive.
http://mailman.alsa-project.org/pipermail/alsa-devel/
Thanks
Takashi Sakamoto
d/core/pcm_native.c?h=for-next=5730f9f744cfe20b771adc33f3b476b95d3eebba
[2]
http://mailman.alsa-project.org/pipermail/alsa-devel/2018-March/133268.html
Thanks
Takashi Sakamoto
=5730f9f744cfe20b771adc33f3b476b95d3eebba
[2]
http://mailman.alsa-project.org/pipermail/alsa-devel/2018-March/133268.html
Thanks
Takashi Sakamoto
-by: Takashi Iwai <ti...@suse.de>
---
sound/core/pcm_native.c | 19 ---
1 file changed, 12 insertions(+), 7 deletions(-)
Yeah. I have concerned about it for a long time but kept it as is
because it had no issue. Now, let's obsolete it.
Reviewed-by: Takashi Sakamoto &
-by: Takashi Iwai
---
sound/core/pcm_native.c | 19 ---
1 file changed, 12 insertions(+), 7 deletions(-)
Yeah. I have concerned about it for a long time but kept it as is
because it had no issue. Now, let's obsolete it.
Reviewed-by: Takashi Sakamoto
diff --git a/sound/core
clock gating
parameter when parsing hw_configs
http://mailman.alsa-project.org/pipermail/alsa-devel/2018-February/132259.html
Regards
Takashi Sakamoto
permail/alsa-devel/2018-February/132259.html
Regards
Takashi Sakamoto
27 ('ASoC: intel: initialize return value properly')[2].
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/log/?h=topic/intel
[2]
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/?h=topic/intel=cc20c4df1627
Regards
Takashi Sakamoto
SoC: intel: initialize return value properly')[2].
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/log/?h=topic/intel
[2]
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/?h=topic/intel=cc20c4df1627
Regards
Takashi Sakamoto
symbol
'skl_clk_round_rate' was not declared. Should it be static?
Signed-off-by: Colin Ian King <colin.k...@canonical.com>
---
sound/soc/intel/skylake/skl-ssp-clk.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Takashi Sakamoto <o-taka...@sakamocchi.jp>
' was not declared. Should it be static?
Signed-off-by: Colin Ian King
---
sound/soc/intel/skylake/skl-ssp-clk.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Takashi Sakamoto
diff --git a/sound/soc/intel/skylake/skl-ssp-clk.c
b/sound/soc/intel/skylake/skl-ssp-clk.c
or-next
[2]
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/sound/soc/sh?h=for-next=33f801366bdf3f8b67dfe325b84f4051a090d01e
[3]
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/sound/soc/sh?h=for-next=2e2d53da81af6bc6b4e025a5d01b37b4449b
Regard
or-next
[2]
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/sound/soc/sh?h=for-next=33f801366bdf3f8b67dfe325b84f4051a090d01e
[3]
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/sound/soc/sh?h=for-next=2e2d53da81af6bc6b4e025a5d01b37b4449b
Regard
issue.
Signed-off-by: Jiada Wang <jiada_w...@mentor.com>
Reviewed-by: Takashi Sakamoto <takashi.sakam...@miraclelinux.com>
Acked-by: Kuninori Morimoto <kuninori.morimoto...@renesas.com>
Signed-off-by: Mark Brown <broo...@kernel.org>
---
sound/soc/sh/rcar/ssi.c | 16 +++
Reviewed-by: Takashi Sakamoto
Acked-by: Kuninori Morimoto
Signed-off-by: Mark Brown
---
sound/soc/sh/rcar/ssi.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/sound/soc/sh/rcar/ssi.c b/sound/soc/sh/rcar/ssi.c
index fece1e5f582f..cbf3bf312d23 100644
On Nov 28 2017 04:51, Takashi Iwai wrote:
On Mon, 27 Nov 2017 18:34:17 +0100,
Takashi Sakamoto wrote:
Hi,
On Nov 27 2017 21:58, Colin King wrote:
From: Colin Ian King <colin.k...@canonical.com>
Don't populate array 'names' on the stack but instead make them static.
Makes the objec
On Nov 28 2017 04:51, Takashi Iwai wrote:
On Mon, 27 Nov 2017 18:34:17 +0100,
Takashi Sakamoto wrote:
Hi,
On Nov 27 2017 21:58, Colin King wrote:
From: Colin Ian King
Don't populate array 'names' on the stack but instead make them static.
Makes the object code smaller by 50 bytes:
Before
ned properly yet */
[SNDRV_PCM_FORMAT_SPECIAL] = {
.le = -1, .signd = -1,
},
Looks good to me.
Reviewed-by: Takashi Sakamoto <o-taka...@sakamocchi.jp>
In next time to post any of your v2 patchset, it's better to add
commenters of v1 patchset to CC list, so that your patch reaches the
pe
.le = -1, .signd = -1,
},
Looks good to me.
Reviewed-by: Takashi Sakamoto
In next time to post any of your v2 patchset, it's better to add
commenters of v1 patchset to CC list, so that your patch reaches the
person who has practical interests in it.
I'm waiting for your ano
ot;None", "CD Player" };
return snd_ctl_enum_info(info, 1, 2, names);
}
Total size of snd-dummy.ko increases but this patch has an advantage to
have the symbol in read-only section. This looks good to me.
Reviewed-by: Takashi Sakamoto <o-taka...@sakamocchi.jp>
um_info(info, 1, 2, names);
}
Total size of snd-dummy.ko increases but this patch has an advantage to
have the symbol in read-only section. This looks good to me.
Reviewed-by: Takashi Sakamoto
Another issue is addressed by the others, but here I focus on the
original intention of this patch.
Thanks
Takashi Sakamoto
0, .phys = 32, .le = 0, .signd = 0,
188 .silence = { 0x00, 0x08, 0x00, 0x00 },
189 },
-> 190 /* FIXME: this format is not defined properly yet */
191 [SNDRV_PCM_FORMAT_SPECIAL] = {
192 .le = -1, .signd = -1,
193 },
Regards
Takashi Sakamoto
.signd = 0,
188 .silence = { 0x00, 0x08, 0x00, 0x00 },
189 },
-> 190 /* FIXME: this format is not defined properly yet */
191 [SNDRV_PCM_FORMAT_SPECIAL] = {
192 .le = -1, .signd = -1,
193 },
Regards
Takashi Sakamoto
On Nov 23 2017 08:44, Maciej S. Szmigiero wrote:
On 23.11.2017 00:27, Takashi Sakamoto wrote:
On Nov 23 2017 04:17, Maciej S. Szmigiero wrote:
(..)
--- a/include/uapi/sound/asound.h
+++ b/include/uapi/sound/asound.h
@@ -236,7 +236,11 @@ typedef int __bitwise snd_pcm_format_t;
#define
On Nov 23 2017 08:44, Maciej S. Szmigiero wrote:
On 23.11.2017 00:27, Takashi Sakamoto wrote:
On Nov 23 2017 04:17, Maciej S. Szmigiero wrote:
(..)
--- a/include/uapi/sound/asound.h
+++ b/include/uapi/sound/asound.h
@@ -236,7 +236,11 @@ typedef int __bitwise snd_pcm_format_t;
#define
lob;f=src/pcm/pcm_misc.c;h=5420b1895713a3aec3624a5218794a7b49baf167;hb=HEAD
Regards
Takashi Sakamoto
c;h=5420b1895713a3aec3624a5218794a7b49baf167;hb=HEAD
Regards
Takashi Sakamoto
patch. Of course, we should have enough investigation and
consideration about its meaning on ALSA control interface in advance of
actual removal.
[1] http://git.alsa-project.org/?p=alsa-lib.git
[2] https://android.googlesource.com/platform/external/tinyalsa/
Thanks
Takashi Sakamoto
enough investigation and
consideration about its meaning on ALSA control interface in advance of
actual removal.
[1] http://git.alsa-project.org/?p=alsa-lib.git
[2] https://android.googlesource.com/platform/external/tinyalsa/
Thanks
Takashi Sakamoto
[1] https://www.ietf.org/rfc/rfc0822.txt
Regards
Takashi Sakamoto
can point links to backend/frontend implementation as
para-virtualization drivers which use the new feature of interface, if
you did work for it. Indicating procedure to use a series of your work
is better for test, if possible.
[1] https://www.ietf.org/rfc/rfc0822.txt
Regards
Takashi Sakamoto
you have some ways to detect the
pattern on current vanilla kernel? Or we should find it by eye-grep?
Thanks
Takashi Sakamoto
8<
>From 85896b50aa22bf2f2b5e45456daa16d386602edc Mon Sep 17 00:00:00 2001
From: Takashi Sakamoto <o-taka...@sakamocchi.jp>
Date: Sat, 14 Oct
you have some ways to detect the
pattern on current vanilla kernel? Or we should find it by eye-grep?
Thanks
Takashi Sakamoto
8<
>From 85896b50aa22bf2f2b5e45456daa16d386602edc Mon Sep 17 00:00:00 2001
From: Takashi Sakamoto
Date: Sat, 14 Oct 2017 14:08:51 +0900
Subject
your questions without it.
Regards
Takashi Sakamoto
your questions without it.
Regards
Takashi Sakamoto
-by: Bhumika Goyal <bhumi...@gmail.com>
---
sound/usb/line6/capture.c | 2 +-
sound/usb/line6/capture.h | 2 +-
sound/usb/line6/playback.c | 2 +-
sound/usb/line6/playback.h | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
This looks good to me.
Reviewed-by: Takashi Sakamoto &
-by: Bhumika Goyal
---
sound/usb/line6/capture.c | 2 +-
sound/usb/line6/capture.h | 2 +-
sound/usb/line6/playback.c | 2 +-
sound/usb/line6/playback.h | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
This looks good to me.
Reviewed-by: Takashi Sakamoto
diff --git a/sound/usb/line6
d of
work.)
In this point of view, whether your patchset is worth to be applied
or not, Please keep enough time to think about.
[1] http://driverdev.linuxdriverproject.org/mailman/listinfo
Thanks
Takashi Sakamoto
d of
work.)
In this point of view, whether your patchset is worth to be applied
or not, Please keep enough time to think about.
[1] http://driverdev.linuxdriverproject.org/mailman/listinfo
Thanks
Takashi Sakamoto
or the other patches, I can find no merit to apply except for reduction
of the number of characters included in the file.
Thanks
Takashi Sakamoto
return err;
+
+stop_rx_stream:
+ amdtp_stream_stop(>rx_stream);
+break_connections:
+ break_both_connections(bebob);
+ return err;
}
void snd_bebob_stream_stop_duplex(struct snd_bebob *bebob)
For the other patches, I can find no merit to apply except for reduction
of the nu
ct.org/pipermail/alsa-devel/2017-September/125574.html
Thanks
Takashi Sakamoto
ct.org/pipermail/alsa-devel/2017-September/125574.html
Thanks
Takashi Sakamoto
enders the tasklet useless.
Signed-off-by: Thomas Gleixner <t...@linutronix.de>
Signed-off-by: Anna-Maria Gleixner <anna-ma...@linutronix.de>
Cc: Jaroslav Kysela <pe...@perex.cz>
Cc: Takashi Iwai <ti...@suse.com>
Cc: Takashi Sakamoto <o-taka...@sakamocchi.jp>
Cc: al
1 - 100 of 245 matches
Mail list logo
