RE: [PATCH v4 00/12] [dt-bindings] [media] Add document file and driver for Sony CXD2880 DVB-T2/T tuner + demodulator

Dear Mauro > > I am creating patch files for version 5 of our driver. > I need to add our driver information into > /drivers/media/dvb-frontends/Kconfig. > This Kconfig has no SPDX license Identifier now. > Is it unnecessary for us to add SPDX into > /drivers/media/dvb-frontends/Kconfig? >

RE: [PATCH v4 00/12] [dt-bindings] [media] Add document file and driver for Sony CXD2880 DVB-T2/T tuner + demodulator

Dear Mauro > > I am creating patch files for version 5 of our driver. > I need to add our driver information into > /drivers/media/dvb-frontends/Kconfig. > This Kconfig has no SPDX license Identifier now. > Is it unnecessary for us to add SPDX into > /drivers/media/dvb-frontends/Kconfig? >

RE: [PATCH v4 00/12] [dt-bindings] [media] Add document file and driver for Sony CXD2880 DVB-T2/T tuner + demodulator

Dear Mauro I am creating patch files for version 5 of our driver. I need to add our driver information into /drivers/media/dvb-frontends/Kconfig. This Kconfig has no SPDX license Identifier now. Is it unnecessary for us to add SPDX into /drivers/media/dvb-frontends/Kconfig? (Should we add our

RE: [PATCH v4 00/12] [dt-bindings] [media] Add document file and driver for Sony CXD2880 DVB-T2/T tuner + demodulator

Dear Mauro I am creating patch files for version 5 of our driver. I need to add our driver information into /drivers/media/dvb-frontends/Kconfig. This Kconfig has no SPDX license Identifier now. Is it unnecessary for us to add SPDX into /drivers/media/dvb-frontends/Kconfig? (Should we add our

RE: [PATCH v4 07/12] [media] cxd2880: Add top level of the driver

Hi, Mauro > > + > > +#define pr_fmt(fmt) KBUILD_MODNAME ": %s: " fmt, __func__ > > Same comments as on other patches: use SPDX and dev_foo() for printing > messages. About printing messages pr_fmt, I also replied a comment to [PATCH v4 02/12] [media] cxd2880-spi: Add support for CXD2880 SPI

RE: [PATCH v4 07/12] [media] cxd2880: Add top level of the driver

Hi, Mauro > > + > > +#define pr_fmt(fmt) KBUILD_MODNAME ": %s: " fmt, __func__ > > Same comments as on other patches: use SPDX and dev_foo() for printing > messages. About printing messages pr_fmt, I also replied a comment to [PATCH v4 02/12] [media] cxd2880-spi: Add support for CXD2880 SPI

RE: [PATCH v4 06/12] [media] cxd2880: Add integration layer for the driver

Hi, Mauro. > > > > These functions monitor the driver and watch for task completion. > > This is part of the Sony CXD2880 DVB-T2/T tuner + demodulator driver. > > If I understand well, the goal here is to have thread that would be waking > up from time to time, right? Just use the infrastructure

RE: [PATCH v4 06/12] [media] cxd2880: Add integration layer for the driver

Hi, Mauro. > > > > These functions monitor the driver and watch for task completion. > > This is part of the Sony CXD2880 DVB-T2/T tuner + demodulator driver. > > If I understand well, the goal here is to have thread that would be waking > up from time to time, right? Just use the infrastructure

RE: [PATCH v4 05/12] [media] cxd2880: Add tuner part of the driver

Hi, Mauro > > + ret = tnr_dmd->io->read_regs(tnr_dmd->io, > > +CXD2880_IO_TGT_SYS, > > +0x10, data, 1); > > + if (ret) > > + return ret; > > + if ((data[0] & 0x01) == 0x00) > > + return -EBUSY; > > I don't

RE: [PATCH v4 05/12] [media] cxd2880: Add tuner part of the driver

Hi, Mauro > > + ret = tnr_dmd->io->read_regs(tnr_dmd->io, > > +CXD2880_IO_TGT_SYS, > > +0x10, data, 1); > > + if (ret) > > + return ret; > > + if ((data[0] & 0x01) == 0x00) > > + return -EBUSY; > > I don't

RE: [PATCH v4 02/12] [media] cxd2880-spi: Add support for CXD2880 SPI interface

Hi, Mauro. > > + > > +#define pr_fmt(fmt) KBUILD_MODNAME ": %s: " fmt, __func__ > > It would be better to use dev_foo() debug macros instead of > pr_foo() ones. I got comment for this previous version patch as below

RE: [PATCH v4 02/12] [media] cxd2880-spi: Add support for CXD2880 SPI interface

Hi, Mauro. > > + > > +#define pr_fmt(fmt) KBUILD_MODNAME ": %s: " fmt, __func__ > > It would be better to use dev_foo() debug macros instead of > pr_foo() ones. I got comment for this previous version patch as below

RE: [PATCH v4 00/12] [dt-bindings] [media] Add document file and driver for Sony CXD2880 DVB-T2/T tuner + demodulator

Dear Mauro Thanks for your review. We will refer to your comments and consider how to respond for them. I want to confirm one thing about SPDX license text We will add SPDX license text to our files, Is it necessary to add SPDX not only .c .h Makefile but also Kconfig? When I checked current

RE: [PATCH v4 00/12] [dt-bindings] [media] Add document file and driver for Sony CXD2880 DVB-T2/T tuner + demodulator

Dear Mauro Thanks for your review. We will refer to your comments and consider how to respond for them. I want to confirm one thing about SPDX license text We will add SPDX license text to our files, Is it necessary to add SPDX not only .c .h Makefile but also Kconfig? When I checked current

RE: [PATCH v4 07/12] [media] cxd2880: Add top level of the driver

Dear Sean Hi, Thanks for your review. We will refer to your comments and consider how to respond for them. > > + u8 rdata[2]; > > + int ret; > > + > > + if ((!tnrdmd) || (!pre_bit_err) || (!pre_bit_count)) > > + return -EINVAL; > > + > > + if (tnrdmd->diver_mode ==

RE: [PATCH v4 07/12] [media] cxd2880: Add top level of the driver

Dear Sean Hi, Thanks for your review. We will refer to your comments and consider how to respond for them. > > + u8 rdata[2]; > > + int ret; > > + > > + if ((!tnrdmd) || (!pre_bit_err) || (!pre_bit_count)) > > + return -EINVAL; > > + > > + if (tnrdmd->diver_mode ==

RE: [PATCH v4 00/12] [dt-bindings] [media] Add document file and driver for Sony CXD2880 DVB-T2/T tuner + demodulator

Dear Mauro Thanks for your support and reply. I understood current status. We will wait for community's feedback. Regards and Thanks, Takiguchi

RE: [PATCH v4 00/12] [dt-bindings] [media] Add document file and driver for Sony CXD2880 DVB-T2/T tuner + demodulator

Dear Mauro Thanks for your support and reply. I understood current status. We will wait for community's feedback. Regards and Thanks, Takiguchi

Re: [PATCH v4 00/12] [dt-bindings] [media] Add document file and driver for Sony CXD2880 DVB-T2/T tuner + demodulator

Hi, all I sent the patch series of Sony CXD2880 DVB-T2/T tuner + demodulator driver version 4 on 13th/Oct. I'd like to get better understanding of current review status for our codes. Are there any comments, advices and review results for them? Regards, Takiguchi

Re: [PATCH v4 00/12] [dt-bindings] [media] Add document file and driver for Sony CXD2880 DVB-T2/T tuner + demodulator

Hi, all I sent the patch series of Sony CXD2880 DVB-T2/T tuner + demodulator driver version 4 on 13th/Oct. I'd like to get better understanding of current review status for our codes. Are there any comments, advices and review results for them? Regards, Takiguchi

Re: [PATCH v4 00/12] [dt-bindings] [media] Add document file and driver for Sony CXD2880 DVB-T2/T tuner + demodulator

Hi, all I sent the patch series of Sony CXD2880 DVB-T2/T tuner + demodulator driver version 4 on 13th/Oct. Are there any comments, advices and review results for them? I'd like to get better understanding of current review status for our codes. Regards, Takiguchi

Re: [PATCH v4 00/12] [dt-bindings] [media] Add document file and driver for Sony CXD2880 DVB-T2/T tuner + demodulator

Hi, all I sent the patch series of Sony CXD2880 DVB-T2/T tuner + demodulator driver version 4 on 13th/Oct. Are there any comments, advices and review results for them? I'd like to get better understanding of current review status for our codes. Regards, Takiguchi

Re: [PATCH v4 02/12] [media] cxd2880-spi: Add support for CXD2880 SPI interface

Hi Honza, > BTW, is there any device, preferable some devboard with this silicon > on the market? There is not devboard at this moment, but we are promoting this device. Takiguchi

Re: [PATCH v4 02/12] [media] cxd2880-spi: Add support for CXD2880 SPI interface

Hi Honza, > BTW, is there any device, preferable some devboard with this silicon > on the market? There is not devboard at this moment, but we are promoting this device. Takiguchi

Re: [PATCH v4 02/12] [media] cxd2880-spi: Add support for CXD2880 SPI interface

Hi Honza > If I understand it right, it uses SPI bus also for passing transport stream > to the host system (also having some pid piltering inside!), isn't it? > It would be interesting to know what is the max throughput of the CXD's SPI? Yes, max clock rate of spi is written in sony-cxd2880.txt

Re: [PATCH v4 02/12] [media] cxd2880-spi: Add support for CXD2880 SPI interface

Hi Honza > If I understand it right, it uses SPI bus also for passing transport stream > to the host system (also having some pid piltering inside!), isn't it? > It would be interesting to know what is the max throughput of the CXD's SPI? Yes, max clock rate of spi is written in sony-cxd2880.txt

Re: [PATCH v3 05/14] [media] cxd2880: Add tuner part of the driver

Dear Mauro Thanks for your review and reply. We are going to discuss how to change our code with your comments internally. I reply for your 2 comments, >> [Change list] >> Changes in V3 >>drivers/media/dvb-frontends/cxd2880/cxd2880_dtv.h >> -removed code relevant to ISDB-T > > Just

Re: [PATCH v3 05/14] [media] cxd2880: Add tuner part of the driver

Dear Mauro Thanks for your review and reply. We are going to discuss how to change our code with your comments internally. I reply for your 2 comments, >> [Change list] >> Changes in V3 >>drivers/media/dvb-frontends/cxd2880/cxd2880_dtv.h >> -removed code relevant to ISDB-T > > Just

Re: [PATCH v3 14/14] [media] cxd2880 : Update MAINTAINERS file for CXD2880 driver

From: Yasunari Takiguchi I add an e-mail address and re-send this mail again. This is MAINTAINERS file update about the driver for the Sony CXD2880 DVB-T2/T tuner + demodulator. [Change list] Changes in V3 MAINTAINERS -no change Signed-off-by: Yasunari

Re: [PATCH v3 14/14] [media] cxd2880 : Update MAINTAINERS file for CXD2880 driver

From: Yasunari Takiguchi I add an e-mail address and re-send this mail again. This is MAINTAINERS file update about the driver for the Sony CXD2880 DVB-T2/T tuner + demodulator. [Change list] Changes in V3 MAINTAINERS -no change Signed-off-by: Yasunari Takiguchi Signed-off-by:

Re: [PATCH v2 08/15] [media] cxd2880: Add top level of the driver

>>> Em Mon, 19 Jun 2017 16:56:13 +0900 >>> "Takiguchi, Yasunari" <yasunari.takigu...@sony.com> escreveu: >>> >>>>>> +static int cxd2880_get_frontend_t(struct dvb_frontend *fe, >>>>>> +stru

Re: [PATCH v2 08/15] [media] cxd2880: Add top level of the driver

On 2017/06/26 10:24, Mauro Carvalho Chehab wrote: > Em Sun, 25 Jun 2017 09:15:06 -0300 > Mauro Carvalho Chehab escreveu: > >> Em Fri, 23 Jun 2017 10:02:39 -0300 >> Mauro Carvalho Chehab escreveu: >> >>> Em Mon, 19 Jun 2017 16:56:13 +0900

Re: [PATCH v2 08/15] [media] cxd2880: Add top level of the driver

Thanks for your kindly reply. We are think of how to change our driver to follow the comments now. I reply one thing about reading BER measures at get_frontend() in this mail. On 2017/06/13 22:30, Mauro Carvalho Chehab wrote: > Em Fri, 14 Apr 2017 11:31:50 +0900 >

Re: [PATCH v2 08/15] [media] cxd2880: Add top level of the driver

Thanks for your kindly reply. We are think of how to change our driver to follow the comments now. I reply one thing about reading BER measures at get_frontend() in this mail. On 2017/06/13 22:30, Mauro Carvalho Chehab wrote: > Em Fri, 14 Apr 2017 11:31:50 +0900 > escreveu: > >> From: Yasunari

Re: [PATCH v2 0/15] [dt-bindings] [media] Add document file and driver for Sony CXD2880 DVB-T2/T tuner + demodulator

2017 15:15:39 +0900 > "Takiguchi, Yasunari" <yasunari.takigu...@sony.com> escreveu: > >> Hi, all >> >> I sent the patch series of Sony CXD2880 DVB-T2/T tuner + demodulator driver >> on Apr/14. >> Are there any comments, advices and review results

Re: [PATCH v2 0/15] [dt-bindings] [media] Add document file and driver for Sony CXD2880 DVB-T2/T tuner + demodulator

2017 15:15:39 +0900 > "Takiguchi, Yasunari" escreveu: > >> Hi, all >> >> I sent the patch series of Sony CXD2880 DVB-T2/T tuner + demodulator driver >> on Apr/14. >> Are there any comments, advices and review results for them? > > Usually, re

Re: [PATCH v2 0/15] [dt-bindings] [media] Add document file and driver for Sony CXD2880 DVB-T2/T tuner + demodulator

Dear Abylay Ospan Thank you for your review and proposal. Unfortunately, we supposed it's difficult to cover CXD2841 functionality by CXD2880 driver. CXD2880 is for mobile IC, tuner (RF) and demodulator convined IC. On the other hand, CXD2841 is demodulator only IC for stationary use. CXD2841

Re: [PATCH v2 0/15] [dt-bindings] [media] Add document file and driver for Sony CXD2880 DVB-T2/T tuner + demodulator

Dear Abylay Ospan Thank you for your review and proposal. Unfortunately, we supposed it's difficult to cover CXD2841 functionality by CXD2880 driver. CXD2880 is for mobile IC, tuner (RF) and demodulator convined IC. On the other hand, CXD2841 is demodulator only IC for stationary use. CXD2841

Re: [PATCH v2 0/15] [dt-bindings] [media] Add document file and driver for Sony CXD2880 DVB-T2/T tuner + demodulator

Hi, all I sent the patch series of Sony CXD2880 DVB-T2/T tuner + demodulator driver on Apr/14. Are there any comments, advices and review results for them? I'd like to get better understanding of current review status for our codes. Regards, Takiguchi

Re: [PATCH v2 0/15] [dt-bindings] [media] Add document file and driver for Sony CXD2880 DVB-T2/T tuner + demodulator

Hi, all I sent the patch series of Sony CXD2880 DVB-T2/T tuner + demodulator driver on Apr/14. Are there any comments, advices and review results for them? I'd like to get better understanding of current review status for our codes. Regards, Takiguchi

Re: [PATCH v2 0/15] [dt-bindings] [media] Add document file and driver for Sony CXD2880 DVB-T2/T tuner + demodulator

Hi, all I sent the patch series of Sony CXD2880 DVB-T2/T tuner + demodulator driver on Apr/14. Are there any comments, advices and review results for them? I'd like to get better understanding of current review status for our codes. Regards, Takiguchi

Re: [PATCH v2 0/15] [dt-bindings] [media] Add document file and driver for Sony CXD2880 DVB-T2/T tuner + demodulator

Hi, all I sent the patch series of Sony CXD2880 DVB-T2/T tuner + demodulator driver on Apr/14. Are there any comments, advices and review results for them? I'd like to get better understanding of current review status for our codes. Regards, Takiguchi

Re: [PATCH v2 0/15] [dt-bindings] [media] Add document file and driver for Sony CXD2880 DVB-T2/T tuner + demodulator

On 2017/04/14 10:50, Takiguchi, Yasunari wrote: > From: Yasunari Takiguchi <yasunari.takigu...@sony.com> > > Hi, > > This is the patch series (version 2) of Sony CXD2880 DVB-T2/T tuner + > demodulator driver. > The driver supports DVB-API and interfaces throu

Re: [PATCH v2 0/15] [dt-bindings] [media] Add document file and driver for Sony CXD2880 DVB-T2/T tuner + demodulator

On 2017/04/14 10:50, Takiguchi, Yasunari wrote: > From: Yasunari Takiguchi > > Hi, > > This is the patch series (version 2) of Sony CXD2880 DVB-T2/T tuner + > demodulator driver. > The driver supports DVB-API and interfaces through SPI. > > We have tested the drive

Re: [PATCH v2 01/15] [dt-bindings] [media] Add document file for CXD2880 SPI I/F

> From: Yasunari Takiguchi > > This is the document file for Sony CXD2880 DVB-T2/T tuner + demodulator. > It contains the description of the SPI adapter binding. > > Signed-off-by: Yasunari Takiguchi > Signed-off-by: Masayuki Yamamoto

Re: [PATCH v2 01/15] [dt-bindings] [media] Add document file for CXD2880 SPI I/F

> From: Yasunari Takiguchi > > This is the document file for Sony CXD2880 DVB-T2/T tuner + demodulator. > It contains the description of the SPI adapter binding. > > Signed-off-by: Yasunari Takiguchi > Signed-off-by: Masayuki Yamamoto > Signed-off-by: Hideki Nozawa > Signed-off-by: Kota

RE: [PATCH 2/5] media: Add support for CXD2880 SPI I/F

Dear All Our patches consists of the following items. [PATCH 1/5] dt-bindings: media: Add document file for CXD2880 SPI I/F [PATCH 2/5] media: Add support for CXD2880 SPI I/F [PATCH 3/5] media: Add suppurt for CXD2880 [PATCH 4/5] media: Add suppurt for CXD2880 DVB-T2/T functions [PATCH

RE: [PATCH 2/5] media: Add support for CXD2880 SPI I/F

Dear All Our patches consists of the following items. [PATCH 1/5] dt-bindings: media: Add document file for CXD2880 SPI I/F [PATCH 2/5] media: Add support for CXD2880 SPI I/F [PATCH 3/5] media: Add suppurt for CXD2880 [PATCH 4/5] media: Add suppurt for CXD2880 DVB-T2/T functions [PATCH