Re: [PATCH] Fix compile warning with ATA_DEBUG enabled

On Fri, Jan 26, 2018 at 11:21:49AM +0800, dongbo (E) wrote: > From: Dong Bo > > This fixs the following comile warnings with ATA_DEBUG enabled, > which detected by Linaro GCC 5.2-2015.11: > > In file included from ./include/linux/printk.h:7:0, > from

Re: [RFC PATCH 2/3] sched/deadline: add task groups bandwidth management support

Hello, On Mon, Feb 12, 2018 at 02:40:29PM +0100, Juri Lelli wrote: > - implementation _is not_ hierarchical: only single/plain DEADLINE entities >can be handled, and they get scheduled at root rq level This usually is a deal breaker and often indicates that the cgroup filesystem is not the

Re: [RFC PATCH 2/3] sched/deadline: add task groups bandwidth management support

Hello, On Mon, Feb 12, 2018 at 02:40:29PM +0100, Juri Lelli wrote: > - implementation _is not_ hierarchical: only single/plain DEADLINE entities >can be handled, and they get scheduled at root rq level This usually is a deal breaker and often indicates that the cgroup filesystem is not the

[PATCH 2/2] FUSE: fix congested state leak on aborted connections

we're always guaranteed to have access to the bdi while the superblock is alive (fc->sb). Drop fc->connected conditional to avoid leaking congestion states. Signed-off-by: Tejun Heo <t...@kernel.org> Reported-by: Joshua Miller <joshmil...@fb.com> Cc: Johannes Weiner <han...@cm

[PATCH 1/2] bdi: make sure congestion states are clear on free

destroying bdi_writebacks, bdi layer can ensure that congestion states are not leaked beyond bdi_writeback lifecycle. Signed-off-by: Tejun Heo <t...@kernel.org> Reported-by: Joshua Miller <joshmil...@fb.com> Cc: Johannes Weiner <han...@cmpxchg.org> Cc: Jan Kara <

[PATCH 2/2] FUSE: fix congested state leak on aborted connections

we're always guaranteed to have access to the bdi while the superblock is alive (fc->sb). Drop fc->connected conditional to avoid leaking congestion states. Signed-off-by: Tejun Heo Reported-by: Joshua Miller Cc: Johannes Weiner Cc: Miklos Szeredi Cc: Jan Kara Cc: sta...@vger.kernel.org

[PATCH 1/2] bdi: make sure congestion states are clear on free

destroying bdi_writebacks, bdi layer can ensure that congestion states are not leaked beyond bdi_writeback lifecycle. Signed-off-by: Tejun Heo Reported-by: Joshua Miller Cc: Johannes Weiner Cc: Jan Kara Cc: sta...@vger.kernel.org --- include/linux/backing-dev.h | 14 +- mm/backing

Re: [PATCH v4.15-rc9] sched, cgroup: Don't reject lower cpu.max on ancestors

Hello, On Thu, Feb 01, 2018 at 05:49:42PM +0100, Peter Zijlstra wrote: > > Well, they're upper limits, not strict allocations. The current > > behavior implemented by cpu isn't either a strict allocation or upper > > limits. It disallows a child from having a value higher than the > > parent

Re: [PATCH v4.15-rc9] sched, cgroup: Don't reject lower cpu.max on ancestors

Hello, On Thu, Feb 01, 2018 at 05:49:42PM +0100, Peter Zijlstra wrote: > > Well, they're upper limits, not strict allocations. The current > > behavior implemented by cpu isn't either a strict allocation or upper > > limits. It disallows a child from having a value higher than the > > parent

[GIT PULL] cgroup changes for v4.16-rc1

per (2): Documentation/cgroup-v1: fix outdated programming details cgroup: Update documentation reference Roman Gushchin (1): cgroup, docs: document cgroup v2 device controller Tejun Heo (2): Merge branch 'for-4.15-fixes' into for-4.16 string: drop __must_check from strscpy() and r

[GIT PULL] cgroup changes for v4.16-rc1

per (2): Documentation/cgroup-v1: fix outdated programming details cgroup: Update documentation reference Roman Gushchin (1): cgroup, docs: document cgroup v2 device controller Tejun Heo (2): Merge branch 'for-4.15-fixes' into for-4.16 string: drop __must_check from strscpy() and r

[GIT PULL] percpu changes for v4.16-rc1

Hello, Linus. One trivial patch to convert the return type from int to bool. Thanks. The following changes since commit 032b4cc8ff84490c4bc7c4ef8c91e6d83a637538: Merge tag 'pm-4.15-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm (2017-12-14 18:25:03 -0800) are

[GIT PULL] percpu changes for v4.16-rc1

Hello, Linus. One trivial patch to convert the return type from int to bool. Thanks. The following changes since commit 032b4cc8ff84490c4bc7c4ef8c91e6d83a637538: Merge tag 'pm-4.15-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm (2017-12-14 18:25:03 -0800) are

[GIT PULL] libata changes for v4.16-rc1

Hello, Linus. Nothing too interesting. Several patches to convert mdelay() to usleep_range(), removal of unused pata_at32, and other low level driver specific changes. Thanks. The following changes since commit 2dc0b46b5ea30f169b0b272253ea846a5a281731: libata: sata_down_spd_limit should

[GIT PULL] libata changes for v4.16-rc1

Hello, Linus. Nothing too interesting. Several patches to convert mdelay() to usleep_range(), removal of unused pata_at32, and other low level driver specific changes. Thanks. The following changes since commit 2dc0b46b5ea30f169b0b272253ea846a5a281731: libata: sata_down_spd_limit should

[GIT PULL] workqueue changes for v4.16-rc1

) Tejun Heo (2): workqueue: separate out init_rescuer() workqueue: allow WQ_MEM_RECLAIM on early init workqueues kernel/workqueue.c | 64 ++ 1 file changed, 40 insertions(+), 24 deletions(-) -- tejun

[GIT PULL] workqueue changes for v4.16-rc1

) Tejun Heo (2): workqueue: separate out init_rescuer() workqueue: allow WQ_MEM_RECLAIM on early init workqueues kernel/workqueue.c | 64 ++ 1 file changed, 40 insertions(+), 24 deletions(-) -- tejun

Re: [patch -mm v2 2/3] mm, memcg: replace cgroup aware oom killer mount option with tunable

adness > of its tasks. This might result in an over accounting because of the > oom_score_adj setting. Document this for now. > > Acked-by: Roman Gushchin <g...@fb.com> > Signed-off-by: Michal Hocko <mho...@suse.com> Acked-by: Tejun Heo <t...@kernel.org> Thanks, Michal. -- tejun

Re: [patch -mm v2 2/3] mm, memcg: replace cgroup aware oom killer mount option with tunable

. This might result in an over accounting because of the > oom_score_adj setting. Document this for now. > > Acked-by: Roman Gushchin > Signed-off-by: Michal Hocko Acked-by: Tejun Heo Thanks, Michal. -- tejun

Re: [PATCH v4.15-rc9] sched, cgroup: Don't reject lower cpu.max on ancestors

Hello, On Tue, Jan 30, 2018 at 11:21:56AM +0100, Peter Zijlstra wrote: > afaiu the existing code does exactly the opposite, it forces the > descendants to configure less than the parent allows. > > You're taking out an error condition and silently allowing descentant > misconfiguration. How does

Re: [PATCH v4.15-rc9] sched, cgroup: Don't reject lower cpu.max on ancestors

Hello, On Tue, Jan 30, 2018 at 11:21:56AM +0100, Peter Zijlstra wrote: > afaiu the existing code does exactly the opposite, it forces the > descendants to configure less than the parent allows. > > You're taking out an error condition and silently allowing descentant > misconfiguration. How does

Re: [PATCH v4.15-rc9] sched, cgroup: Don't reject lower cpu.max on ancestors

Hello, On Mon, Jan 22, 2018 at 11:26:18AM -0800, Tejun Heo wrote: > While adding cgroup2 interface for the cpu controller, 0d5936344f30 > ("sched: Implement interface for cgroup unified hierarchy") forgot to > update input validation and left it to reject cpu.max config if a

Re: [PATCH v4.15-rc9] sched, cgroup: Don't reject lower cpu.max on ancestors

Hello, On Mon, Jan 22, 2018 at 11:26:18AM -0800, Tejun Heo wrote: > While adding cgroup2 interface for the cpu controller, 0d5936344f30 > ("sched: Implement interface for cgroup unified hierarchy") forgot to > update input validation and left it to reject cpu.max config if a

Re: [PATCH] kernfs: account kernfs_node_cache as reclaimable

On Fri, Jan 26, 2018 at 02:47:20PM -0800, Cong Wang wrote: > Similar to commit df206988e03e > ("fs: fuse: account fuse_inode slab memory as reclaimable"), these > kernfs nodes are currently included in the unreclaimable slab counts - > SUnreclaim in /proc/meminfo. And they are reclaimable too and

Re: [PATCH] kernfs: account kernfs_node_cache as reclaimable

On Fri, Jan 26, 2018 at 02:47:20PM -0800, Cong Wang wrote: > Similar to commit df206988e03e > ("fs: fuse: account fuse_inode slab memory as reclaimable"), these > kernfs nodes are currently included in the unreclaimable slab counts - > SUnreclaim in /proc/meminfo. And they are reclaimable too and

Re: [patch -mm v2 2/3] mm, memcg: replace cgroup aware oom killer mount option with tunable

Hello, Michal. On Mon, Jan 29, 2018 at 11:46:57AM +0100, Michal Hocko wrote: > @@ -1292,7 +1292,11 @@ the memory controller considers only cgroups belonging > to the sub-tree > of the OOM'ing cgroup. > > The root cgroup is treated as a leaf memory cgroup, so it's compared > -with other leaf

Re: [patch -mm v2 2/3] mm, memcg: replace cgroup aware oom killer mount option with tunable

Hello, Michal. On Mon, Jan 29, 2018 at 11:46:57AM +0100, Michal Hocko wrote: > @@ -1292,7 +1292,11 @@ the memory controller considers only cgroups belonging > to the sub-tree > of the OOM'ing cgroup. > > The root cgroup is treated as a leaf memory cgroup, so it's compared > -with other leaf

Re: [RFC PATCH V4 1/5] workqueue: rename system workqueues

Hello, On Thu, Jan 25, 2018 at 07:54:41AM -0800, Tejun Heo wrote: > On Thu, Jan 25, 2018 at 03:01:40PM +0800, Wen Yang wrote: > > Rename system_wq's wq->name from "events" to "system_percpu", > > and similarly for the similarly named workqueues. >

Re: [RFC PATCH V4 1/5] workqueue: rename system workqueues

Hello, On Thu, Jan 25, 2018 at 07:54:41AM -0800, Tejun Heo wrote: > On Thu, Jan 25, 2018 at 03:01:40PM +0800, Wen Yang wrote: > > Rename system_wq's wq->name from "events" to "system_percpu", > > and similarly for the similarly named workqueues. > >

Re: [RFC PATCH V4 1/5] workqueue: rename system workqueues

Jiang Biao <jiang.bi...@zte.com.cn> > Signed-off-by: Tan Hu <tan...@zte.com.cn> > Suggested-by: Tejun Heo <t...@kernel.org> > Cc: Tejun Heo <t...@kernel.org> > Cc: Lai Jiangshan <jiangshan...@gmail.com> > Cc: linux-kernel@vger.kernel.org The patches don't

Re: [RFC PATCH V4 1/5] workqueue: rename system workqueues

Hello, On Thu, Jan 25, 2018 at 03:01:40PM +0800, Wen Yang wrote: > Rename system_wq's wq->name from "events" to "system_percpu", > and similarly for the similarly named workqueues. > > Signed-off-by: Wen Yang > Signed-off-by: Jiang Biao > Signed-off-by

Re: [PATCH bpf-next] cgroup: support attaching eBPF programs to net_prio cgroup

On Thu, Jan 25, 2018 at 11:38:48PM +0800, Yafang Shao wrote: > If net_prio is used, we could also use eBPF programs to attach it, > because the net_prio cgroup could be got with prioidx in struct > sock_cgroup_data. > Hence it should not only be limited to cgroup2. I really don't wanna do this.

Re: [PATCH bpf-next] cgroup: support attaching eBPF programs to net_prio cgroup

On Thu, Jan 25, 2018 at 11:38:48PM +0800, Yafang Shao wrote: > If net_prio is used, we could also use eBPF programs to attach it, > because the net_prio cgroup could be got with prioidx in struct > sock_cgroup_data. > Hence it should not only be limited to cgroup2. I really don't wanna do this.

Re: [PATCH] ata: pata_it821x: Replace mdelay with usleep_range in it821x_firmware_command

On Thu, Jan 25, 2018 at 06:32:59PM +0800, Jia-Ju Bai wrote: > After checking all possible call chains to it821x_firmware_command here, > my tool finds that it821x_firmware_command > is never called in atomic context, > namely never in an interrupt handler or holding a spinlock. > And

Re: [PATCH] ata: pata_it821x: Replace mdelay with usleep_range in it821x_firmware_command

On Thu, Jan 25, 2018 at 06:32:59PM +0800, Jia-Ju Bai wrote: > After checking all possible call chains to it821x_firmware_command here, > my tool finds that it821x_firmware_command > is never called in atomic context, > namely never in an interrupt handler or holding a spinlock. > And

Re: [PATCH] ata: pata_pdc2027x: Replace mdelay with msleep

On Thu, Jan 25, 2018 at 06:45:05PM +0800, Jia-Ju Bai wrote: > After checking all possible call chains to pdc_adjust_pll and > pdc_detect_pll_input_clock, > my tool finds that these functions are never called in atomic context, > namely never in an interrupt handler or holding a spinlock. > And

Re: [PATCH] ata: pata_pdc2027x: Replace mdelay with msleep

On Thu, Jan 25, 2018 at 06:45:05PM +0800, Jia-Ju Bai wrote: > After checking all possible call chains to pdc_adjust_pll and > pdc_detect_pll_input_clock, > my tool finds that these functions are never called in atomic context, > namely never in an interrupt handler or holding a spinlock. > And

Re: [PATCH] ata: sata_mv: Replace mdelay with usleep_range in mv_reset_channel

On Thu, Jan 25, 2018 at 06:26:52PM +0800, Jia-Ju Bai wrote: > After checking all possible call chains to mv_reset_channel here, > my tool finds that mv_reset_channel is never called in atomic context, > namely never in an interrupt handler or holding a spinlock. > Thus mdelay can be replaced with

Re: [PATCH] ata: sata_mv: Replace mdelay with usleep_range in mv_reset_channel

On Thu, Jan 25, 2018 at 06:26:52PM +0800, Jia-Ju Bai wrote: > After checking all possible call chains to mv_reset_channel here, > my tool finds that mv_reset_channel is never called in atomic context, > namely never in an interrupt handler or holding a spinlock. > Thus mdelay can be replaced with

Re: [patch -mm 3/4] mm, memcg: replace memory.oom_group with policy tunable

Hello, Andrew. On Wed, Jan 24, 2018 at 02:08:05PM -0800, Andrew Morton wrote: > Can we please try to narrow the scope of this issue by concentrating on > the userspace interfaces? David believes that the mount option and > memory.oom_group will disappear again in the near future, others >

Re: [patch -mm 3/4] mm, memcg: replace memory.oom_group with policy tunable

Hello, Andrew. On Wed, Jan 24, 2018 at 02:08:05PM -0800, Andrew Morton wrote: > Can we please try to narrow the scope of this issue by concentrating on > the userspace interfaces? David believes that the mount option and > memory.oom_group will disappear again in the near future, others >

Re: [PATCH] lockdep: Avoid triggering hardlockup from debug_show_all_locks()

Hello, Sergey, Steven. On Wed, Jan 24, 2018 at 02:00:35PM +0900, Sergey Senozhatsky wrote: > On (01/23/18 21:54), Steven Rostedt wrote: > > > > > Another problem, and I mentioned it somewhere in another email, is that > > > upstream printk people don't receive enough [if any at all] feedback

Re: [PATCH] lockdep: Avoid triggering hardlockup from debug_show_all_locks()

Hello, Sergey, Steven. On Wed, Jan 24, 2018 at 02:00:35PM +0900, Sergey Senozhatsky wrote: > On (01/23/18 21:54), Steven Rostedt wrote: > > > > > Another problem, and I mentioned it somewhere in another email, is that > > > upstream printk people don't receive enough [if any at all] feedback

Re: [PATCH v5 0/2] printk: Console owner and waiter logic cleanup

Hello, Peter. On Wed, Jan 24, 2018 at 10:36:07AM +0100, Peter Zijlstra wrote: > On Wed, Jan 10, 2018 at 09:02:23AM -0800, Tejun Heo wrote: > > 1. Console is IPMI emulated serial console. Super slow. Also > >netconsole is in use. > > So my IPMI SoE typically run at 1

Re: [PATCH v5 0/2] printk: Console owner and waiter logic cleanup

Hello, Peter. On Wed, Jan 24, 2018 at 10:36:07AM +0100, Peter Zijlstra wrote: > On Wed, Jan 10, 2018 at 09:02:23AM -0800, Tejun Heo wrote: > > 1. Console is IPMI emulated serial console. Super slow. Also > >netconsole is in use. > > So my IPMI SoE typically run at 1

[tip:locking/urgent] locking/lockdep: Avoid triggering hardlockup from debug_show_all_locks()

Commit-ID: 88f1c87de11a86d839f4ce5313e552d96709b990 Gitweb: https://git.kernel.org/tip/88f1c87de11a86d839f4ce5313e552d96709b990 Author: Tejun Heo <t...@kernel.org> AuthorDate: Mon, 22 Jan 2018 14:00:55 -0800 Committer: Ingo Molnar <mi...@kernel.org> CommitDate: Wed, 24 Jan 2

[tip:locking/urgent] locking/lockdep: Avoid triggering hardlockup from debug_show_all_locks()

Commit-ID: 88f1c87de11a86d839f4ce5313e552d96709b990 Gitweb: https://git.kernel.org/tip/88f1c87de11a86d839f4ce5313e552d96709b990 Author: Tejun Heo AuthorDate: Mon, 22 Jan 2018 14:00:55 -0800 Committer: Ingo Molnar CommitDate: Wed, 24 Jan 2018 10:00:09 +0100 locking/lockdep: Avoid

Re: [PATCH] lockdep: Avoid triggering hardlockup from debug_show_all_locks()

Hello, Steven. On Tue, Jan 23, 2018 at 04:00:54PM -0500, Steven Rostedt wrote: > On Tue, 23 Jan 2018 12:57:06 -0800 > Tejun Heo <t...@kernel.org> wrote: > > > Yeah, it's ridiculous how often printk ends up escalating otherwise > > recoverable situations into system

Re: [PATCH] lockdep: Avoid triggering hardlockup from debug_show_all_locks()

Hello, Steven. On Tue, Jan 23, 2018 at 04:00:54PM -0500, Steven Rostedt wrote: > On Tue, 23 Jan 2018 12:57:06 -0800 > Tejun Heo wrote: > > > Yeah, it's ridiculous how often printk ends up escalating otherwise > > recoverable situations into system crashes. I don't kn

Re: [PATCH] lockdep: Avoid triggering hardlockup from debug_show_all_locks()

Hello, (cc'ing Steven, Sergey and Petr who are working on printk) On Tue, Jan 23, 2018 at 02:03:57PM -0500, Rik van Riel wrote: > On Mon, 2018-01-22 at 14:00 -0800, Tejun Heo wrote: > > debug_show_all_locks() iterates all tasks and print held locks whole > > holding tasklist_lock.

Re: [PATCH] lockdep: Avoid triggering hardlockup from debug_show_all_locks()

Hello, (cc'ing Steven, Sergey and Petr who are working on printk) On Tue, Jan 23, 2018 at 02:03:57PM -0500, Rik van Riel wrote: > On Mon, 2018-01-22 at 14:00 -0800, Tejun Heo wrote: > > debug_show_all_locks() iterates all tasks and print held locks whole > > holding tasklist_lock.

Re: [PATCH v5 0/2] printk: Console owner and waiter logic cleanup

Hello, Sergey. On Wed, Jan 24, 2018 at 01:01:53AM +0900, Sergey Senozhatsky wrote: > On (01/23/18 10:41), Steven Rostedt wrote: > [..] > > We can have more. But if printk is causing printks, that's a major bug. > > And work queues are not going to fix it, it will just spread out the > > pain.

Re: [PATCH v5 0/2] printk: Console owner and waiter logic cleanup

Hello, Sergey. On Wed, Jan 24, 2018 at 01:01:53AM +0900, Sergey Senozhatsky wrote: > On (01/23/18 10:41), Steven Rostedt wrote: > [..] > > We can have more. But if printk is causing printks, that's a major bug. > > And work queues are not going to fix it, it will just spread out the > > pain.

Re: [PATCH v5 0/2] printk: Console owner and waiter logic cleanup

Hey, On Tue, Jan 23, 2018 at 11:13:30AM -0500, Steven Rostedt wrote: > From what I understand is that there's an issue with one of the printk > consoles, due to memory pressure or whatnot. Then a printk happens > within a printk recursively. It gets put into the safe buffer and an > irq is sent

Re: [PATCH v5 0/2] printk: Console owner and waiter logic cleanup

Hey, On Tue, Jan 23, 2018 at 11:13:30AM -0500, Steven Rostedt wrote: > From what I understand is that there's an issue with one of the printk > consoles, due to memory pressure or whatnot. Then a printk happens > within a printk recursively. It gets put into the safe buffer and an > irq is sent

Re: [PATCH v5 0/2] printk: Console owner and waiter logic cleanup

Hello, Steven. On Tue, Jan 23, 2018 at 10:41:21AM -0500, Steven Rostedt wrote: > > I don't want to have heuristics in print_safe, I don't want to have a magic > > number controlled by a user-space visible knob, I don't want to have the > > first 3 lines of a lockdep splat. > > We can have more.

Re: [PATCH v5 0/2] printk: Console owner and waiter logic cleanup

Hello, Steven. On Tue, Jan 23, 2018 at 10:41:21AM -0500, Steven Rostedt wrote: > > I don't want to have heuristics in print_safe, I don't want to have a magic > > number controlled by a user-space visible knob, I don't want to have the > > first 3 lines of a lockdep splat. > > We can have more.

Re: [RFC PATCH v3] workqueue: Introduce a way to set percpu worker_pool's scheduler

Hello, On Tue, Jan 23, 2018 at 07:00:42PM +0800, Wen Yang wrote: ... > This patch introduces a way to set the scheduler(policy and priority) > of percpu worker_pool, in that way, user could set proper scheduler > policy and priority of the worker_pool as needed, which could apply > to all the

Re: [RFC PATCH v3] workqueue: Introduce a way to set percpu worker_pool's scheduler

Hello, On Tue, Jan 23, 2018 at 07:00:42PM +0800, Wen Yang wrote: ... > This patch introduces a way to set the scheduler(policy and priority) > of percpu worker_pool, in that way, user could set proper scheduler > policy and priority of the worker_pool as needed, which could apply > to all the

Re: Spurious lockdep splat in v4.15-rc9

Hello, Peter. On Mon, Jan 22, 2018 at 10:53:29PM +0100, Peter Zijlstra wrote: > > Tejun, does the below work for you (compile tested only). Yeap, that gets rid of the lockdep warning. Thanks a lot. -- tejun

Re: Spurious lockdep splat in v4.15-rc9

Hello, Peter. On Mon, Jan 22, 2018 at 10:53:29PM +0100, Peter Zijlstra wrote: > > Tejun, does the below work for you (compile tested only). Yeap, that gets rid of the lockdep warning. Thanks a lot. -- tejun

[PATCH] lockdep: Avoid triggering hardlockup from debug_show_all_locks()

to avoid spuriously triggering the hardlockup detector. Signed-off-by: Tejun Heo <t...@kernel.org> --- kernel/locking/lockdep.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c index 5fa1324..5216590 100644 --- a/kernel/locking/loc

[PATCH] lockdep: Avoid triggering hardlockup from debug_show_all_locks()

to avoid spuriously triggering the hardlockup detector. Signed-off-by: Tejun Heo --- kernel/locking/lockdep.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c index 5fa1324..5216590 100644 --- a/kernel/locking/lockdep.c +++ b/kernel/locking

[PATCH v4.15-rc9] sched, cgroup: Don't reject lower cpu.max on ancestors

tes config validation on cgroup2 so that the cpu controller follows the same convention. Signed-off-by: Tejun Heo <t...@kernel.org> Fixes: 0d5936344f30 ("sched: Implement interface for cgroup unified hierarchy") --- kernel/sched/core.c | 15 ++- 1 file changed, 10

[PATCH v4.15-rc9] sched, cgroup: Don't reject lower cpu.max on ancestors

tes config validation on cgroup2 so that the cpu controller follows the same convention. Signed-off-by: Tejun Heo Fixes: 0d5936344f30 ("sched: Implement interface for cgroup unified hierarchy") --- kernel/sched/core.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-)

Spurious lockdep splat in v4.15-rc9

Hello, Peter, Ingo. I get the below lockdep warning if I try to write a config into cgroup cpu.max file. It's warning about A-A deadlock, but it's obviously spurious - the system doesn't lock up and the warning is about two get_online_cpus() calls nesting. Thanks. [ 79.106704] [ 79.106886]

Spurious lockdep splat in v4.15-rc9

Hello, Peter, Ingo. I get the below lockdep warning if I try to write a config into cgroup cpu.max file. It's warning about A-A deadlock, but it's obviously spurious - the system doesn't lock up and the warning is about two get_online_cpus() calls nesting. Thanks. [ 79.106704] [ 79.106886]

Re: [BUG] cgroup lockup while upgrading udev on debian

Hello, Steven. On Sun, Jan 21, 2018 at 09:31:08PM -0500, Steven Rostedt wrote: > While upgrading my system, it locked up while upgrading udev. It locked > up on vanilla v4.14.12, and it also locked up on debian's 4.14 kernel > as well. When I booted debian's 4.9 kernel, it upgraded fine. > >

Re: [BUG] cgroup lockup while upgrading udev on debian

Hello, Steven. On Sun, Jan 21, 2018 at 09:31:08PM -0500, Steven Rostedt wrote: > While upgrading my system, it locked up while upgrading udev. It locked > up on vanilla v4.14.12, and it also locked up on debian's 4.14 kernel > as well. When I booted debian's 4.9 kernel, it upgraded fine. > >

Re: [PATCH] cgroup: remove incorrect check on the return value of css_alloc

Hello, On Mon, Jan 22, 2018 at 09:38:51PM +0800, Xiongwei Song wrote: > The function css_alloc never return NULL, it may return normal pointer or It's a calling a controller implemented method. I'd much rather keep the extra protection. > error codes that made by ERR_PTR, so !css is always

Re: [PATCH] cgroup: remove incorrect check on the return value of css_alloc

Hello, On Mon, Jan 22, 2018 at 09:38:51PM +0800, Xiongwei Song wrote: > The function css_alloc never return NULL, it may return normal pointer or It's a calling a controller implemented method. I'd much rather keep the extra protection. > error codes that made by ERR_PTR, so !css is always

Re: [patch -mm 3/4] mm, memcg: replace memory.oom_group with policy tunable

Hello, David. On Fri, Jan 19, 2018 at 12:53:41PM -0800, David Rientjes wrote: > Hearing no response, I'll implement this as a separate tunable in a v2 > series assuming there are no better ideas proposed before next week. One > of the nice things about a separate tunable is that an admin can

Re: [patch -mm 3/4] mm, memcg: replace memory.oom_group with policy tunable

Hello, David. On Fri, Jan 19, 2018 at 12:53:41PM -0800, David Rientjes wrote: > Hearing no response, I'll implement this as a separate tunable in a v2 > series assuming there are no better ideas proposed before next week. One > of the nice things about a separate tunable is that an admin can

Re: [PATCH v5 0/2] printk: Console owner and waiter logic cleanup

Hello, Steven. On Fri, Jan 19, 2018 at 01:20:52PM -0500, Steven Rostedt wrote: > I was thinking about this a bit more, and instead of offloading a > recursive printk, perhaps its best to simply throttle it. Because the > problem may not go away if a printk thread takes over, because the bug > is

Re: [PATCH v5 0/2] printk: Console owner and waiter logic cleanup

Hello, Steven. On Fri, Jan 19, 2018 at 01:20:52PM -0500, Steven Rostedt wrote: > I was thinking about this a bit more, and instead of offloading a > recursive printk, perhaps its best to simply throttle it. Because the > problem may not go away if a printk thread takes over, because the bug > is

Re: [PATCH] string: drop __must_check from strscpy() and restore strscpy() usages in cgroup

Hello, On Fri, Jan 19, 2018 at 09:27:50AM -0800, Linus Torvalds wrote: > On Fri, Jan 19, 2018 at 8:50 AM, Tejun Heo <t...@kernel.org> wrote: > > > > Applied to cgroup/for-4.16. > > I did still have it queued up, but I was looking at other issues, and > hadn't gotten

Re: [PATCH] string: drop __must_check from strscpy() and restore strscpy() usages in cgroup

Hello, On Fri, Jan 19, 2018 at 09:27:50AM -0800, Linus Torvalds wrote: > On Fri, Jan 19, 2018 at 8:50 AM, Tejun Heo wrote: > > > > Applied to cgroup/for-4.16. > > I did still have it queued up, but I was looking at other issues, and > hadn't gotten around to it. But if i

Re: [PATCH driver-core] kernfs: fix regression in kernfs_fop_write caused by wrong type

ic_write_len in kernfs_open_file") > Signed-off-by: Ivan Vecera <ivec...@redhat.com> Oops. Acked-by: Tejun Heo <t...@kernel.org> Thanks. -- tejun

Re: [PATCH driver-core] kernfs: fix regression in kernfs_fop_write caused by wrong type

c_write_len in kernfs_open_file") > Signed-off-by: Ivan Vecera Oops. Acked-by: Tejun Heo Thanks. -- tejun

[GIT PULL] libata fixes for v4.15-rc8

Hello, Linus. This just adds one more entry for liteon optical drives to the device blacklist for large IOs. The change is very low risk. Thanks. The following changes since commit 2dc0b46b5ea30f169b0b272253ea846a5a281731: libata: sata_down_spd_limit should return if driver has not recorded

[GIT PULL] libata fixes for v4.15-rc8

Hello, Linus. This just adds one more entry for liteon optical drives to the device blacklist for large IOs. The change is very low risk. Thanks. The following changes since commit 2dc0b46b5ea30f169b0b272253ea846a5a281731: libata: sata_down_spd_limit should return if driver has not recorded

[GIT PULL] workqueue fixes for v4.15-rc8

Hello, Linus. One patch to add touch_nmi_watchdog() while dumping workqueue debug messages to avoid triggering the lockup detector spuriously. The change is very low risk. Thanks. The following changes since commit 01dfee9582d9b4403c4902df096ed8b43d55181c: workqueue: remove unneeded

[GIT PULL] workqueue fixes for v4.15-rc8

Hello, Linus. One patch to add touch_nmi_watchdog() while dumping workqueue debug messages to avoid triggering the lockup detector spuriously. The change is very low risk. Thanks. The following changes since commit 01dfee9582d9b4403c4902df096ed8b43d55181c: workqueue: remove unneeded

Re: [PATCH] string: drop __must_check from strscpy() and restore strscpy() usages in cgroup

On Tue, Jan 09, 2018 at 07:21:15AM -0800, Tejun Heo wrote: > From ceb2d2b2e496f180be95adb670337bb254f89323 Mon Sep 17 00:00:00 2001 > From: Tejun Heo <t...@kernel.org> > Date: Tue, 9 Jan 2018 07:00:29 -0800 > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > C

Re: [PATCH] string: drop __must_check from strscpy() and restore strscpy() usages in cgroup

On Tue, Jan 09, 2018 at 07:21:15AM -0800, Tejun Heo wrote: > From ceb2d2b2e496f180be95adb670337bb254f89323 Mon Sep 17 00:00:00 2001 > From: Tejun Heo > Date: Tue, 9 Jan 2018 07:00:29 -0800 > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encod

Re: [PATCH] ata: remove pata_at32

On Thu, Jan 18, 2018 at 09:05:34PM +0100, Corentin Labbe wrote: > Since AVR32 was removed, pata_at32 is unselectable/uncompilable. > Remove this driver. > > Signed-off-by: Corentin Labbe Applied to libata/for-4.16. Thanks. -- tejun

Re: [PATCH] ata: remove pata_at32

On Thu, Jan 18, 2018 at 09:05:34PM +0100, Corentin Labbe wrote: > Since AVR32 was removed, pata_at32 is unselectable/uncompilable. > Remove this driver. > > Signed-off-by: Corentin Labbe Applied to libata/for-4.16. Thanks. -- tejun

Re: [PATCH] phy: brcm-sata: remove unused variable

On Thu, Jan 18, 2018 at 02:19:58PM +0100, Arnd Bergmann wrote: > The newly introduced calibrate function has a variable > that has never been used and needs to be removed to avoid > this harmless warning: > > drivers/phy/broadcom/phy-brcm-sata.c: In function 'brcm_stb_sata_calibrate': >

Re: [PATCH] phy: brcm-sata: remove unused variable

On Thu, Jan 18, 2018 at 02:19:58PM +0100, Arnd Bergmann wrote: > The newly introduced calibrate function has a variable > that has never been used and needs to be removed to avoid > this harmless warning: > > drivers/phy/broadcom/phy-brcm-sata.c: In function 'brcm_stb_sata_calibrate': >

Re: [PATCH v5 0/2] printk: Console owner and waiter logic cleanup

Hello, Steven. On Wed, Jan 17, 2018 at 12:12:51PM -0500, Steven Rostedt wrote: > From what I gathered, you said an OOM would trigger, and then the > network console would not be able to allocate memory and it would > trigger a printk too, and cause an infinite amount of printks. Yeah, it falls

Re: [PATCH v5 0/2] printk: Console owner and waiter logic cleanup

Hello, Steven. On Wed, Jan 17, 2018 at 12:12:51PM -0500, Steven Rostedt wrote: > From what I gathered, you said an OOM would trigger, and then the > network console would not be able to allocate memory and it would > trigger a printk too, and cause an infinite amount of printks. Yeah, it falls

Re: [PATCH v2 0/2] ata: ahci_brcm: Recover from failures to identify devices

On Thu, Jan 11, 2018 at 05:31:06PM -0800, Florian Fainelli wrote: > Hi Tejun, Kishon, > > This patch series implement a recovery mechanism to work around a HW bug > on Broadcom AHCI SATA controller subject to noise triggering a failure to > identify hard drives. Applied 1-2 to libata/for-4.16.

Re: [PATCH v2 0/2] ata: ahci_brcm: Recover from failures to identify devices

On Thu, Jan 11, 2018 at 05:31:06PM -0800, Florian Fainelli wrote: > Hi Tejun, Kishon, > > This patch series implement a recovery mechanism to work around a HW bug > on Broadcom AHCI SATA controller subject to noise triggering a failure to > identify hard drives. Applied 1-2 to libata/for-4.16.

Re: [patch -mm 3/4] mm, memcg: replace memory.oom_group with policy tunable

Hello, David. On Tue, Jan 16, 2018 at 06:15:08PM -0800, David Rientjes wrote: > The behavior of killing an entire indivisible memory consumer, enabled > by memory.oom_group, is an oom policy itself. It specifies that all I thought we discussed this before but maybe I'm misremembering. There are

Re: [patch -mm 3/4] mm, memcg: replace memory.oom_group with policy tunable

Hello, David. On Tue, Jan 16, 2018 at 06:15:08PM -0800, David Rientjes wrote: > The behavior of killing an entire indivisible memory consumer, enabled > by memory.oom_group, is an oom policy itself. It specifies that all I thought we discussed this before but maybe I'm misremembering. There are

Re: [PATCH v5 0/2] printk: Console owner and waiter logic cleanup

Hello, On Wed, Jan 17, 2018 at 10:12:08AM +0100, Petr Mladek wrote: > IMHO, the bad scenario with OOM was that any printk() called in > the OOM report became console_lock owner and was responsible > for pushing all new messages to the console. There was a possible > livelock because OOM Killer

Re: [PATCH v5 0/2] printk: Console owner and waiter logic cleanup

Hello, On Wed, Jan 17, 2018 at 10:12:08AM +0100, Petr Mladek wrote: > IMHO, the bad scenario with OOM was that any printk() called in > the OOM report became console_lock owner and was responsible > for pushing all new messages to the console. There was a possible > livelock because OOM Killer

Re: [PATCH v5 0/2] printk: Console owner and waiter logic cleanup

Hello, Steven. On Thu, Jan 11, 2018 at 09:55:47PM -0500, Steven Rostedt wrote: > All I did was start off a work queue on each CPU, and each CPU does one > printk() followed by a millisecond sleep. No 10,000 printks, nothing > in an interrupt handler. Preemption is disabled while the printk >

Re: [PATCH v5 0/2] printk: Console owner and waiter logic cleanup

Hello, Steven. On Thu, Jan 11, 2018 at 09:55:47PM -0500, Steven Rostedt wrote: > All I did was start off a work queue on each CPU, and each CPU does one > printk() followed by a millisecond sleep. No 10,000 printks, nothing > in an interrupt handler. Preemption is disabled while the printk >

Re: [PATCH] workqueue: Handle race between wake up and rebind

Hello, Neeraj. On Mon, Jan 15, 2018 at 02:08:12PM +0530, Neeraj Upadhyay wrote: > - kworker/0:0 gets chance to run on cpu1; while processing > a work, it goes to sleep. However, it does not decrement > pool->nr_running. This is because WORKER_REBOUND (NOT_ > RUNNING) flag was cleared, when

<    7   8   9   10   11   12   13   14   15   16   >