Re: [PATCH v8 4/8] dt-bindings: pwm: Support new PWM_USAGE_POWER flag

2021-04-16 Thread Thierry Reding
On Mon, Apr 12, 2021 at 03:27:41PM +0200, Clemens Gruber wrote: > Add the flag and corresponding documentation for PWM_USAGE_POWER. > > Cc: Rob Herring > Signed-off-by: Clemens Gruber > --- > Documentation/devicetree/bindings/pwm/pwm.txt | 3 +++ > include/dt-bindings/pwm/pwm.h

Re: [PATCH v8 4/8] dt-bindings: pwm: Support new PWM_USAGE_POWER flag

2021-04-16 Thread Thierry Reding
On Fri, Apr 16, 2021 at 11:32:12AM +0200, Uwe Kleine-König wrote: > Hello Thierry, > > On Thu, Apr 15, 2021 at 06:27:02PM +0200, Thierry Reding wrote: > > On Tue, Apr 13, 2021 at 07:56:31PM +0200, Uwe Kleine-König wrote: > > > On Tue, Apr 13, 2021 at 01:51:15PM +02

Re: [PATCH v8 4/8] dt-bindings: pwm: Support new PWM_USAGE_POWER flag

2021-04-15 Thread Thierry Reding
On Tue, Apr 13, 2021 at 07:56:31PM +0200, Uwe Kleine-König wrote: > On Tue, Apr 13, 2021 at 01:51:15PM +0200, Thierry Reding wrote: > > On Mon, Apr 12, 2021 at 06:27:23PM +0200, Uwe Kleine-König wrote: > > > On Mon, Apr 12, 2021 at 03:27:41PM +0200, Clemens Gruber wrote: &g

Re: [PATCH] drm/tegra: Fix shift overflow in tegra_shared_plane_atomic_update

2021-04-15 Thread Thierry Reding
On Thu, Apr 15, 2021 at 08:29:14AM -0700, Nathan Chancellor wrote: > Clang warns: > > drivers/gpu/drm/tegra/hub.c:513:11: warning: shift count >= width of > type [-Wshift-count-overflow] > base |= BIT(39); > ^~~ > > BIT is unsigned long, which is

Re: [PATCH 03/30] drm/tegra: Don't register DP AUX channels before connectors

2021-04-14 Thread Thierry Reding
On Fri, Feb 19, 2021 at 04:52:59PM -0500, Lyude Paul wrote: > As pointed out by the documentation for drm_dp_aux_register(), > drm_dp_aux_init() should be used in situations where the AUX channel for a > display driver can potentially be registered before it's respective DRM > driver. This is the

Re: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-04-14 Thread Thierry Reding
On Wed, Apr 14, 2021 at 02:18:58AM +, Joakim Zhang wrote: > > > -Original Message- > > From: Thierry Reding > > Sent: 2021年4月14日 0:07 > > To: David S. Miller ; Jakub Kicinski > > Cc: Joakim Zhang ; Jon Hunter > > ; Giuseppe Cavallaro ; >

Re: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-04-13 Thread Thierry Reding
On Tue, Apr 13, 2021 at 12:13:01PM +, Joakim Zhang wrote: > > Hi Jon, > > > -Original Message- > > From: Jon Hunter > > Sent: 2021年4月13日 16:41 > > To: Joakim Zhang ; Giuseppe Cavallaro > > ; Alexandre Torgue ; > > Jose Abreu > > Cc: net...@vger.kernel.org; Linux Kernel Mailing List

Re: [PATCH] staging: media: tegra-vde: Align line break to match with the open parenthesis in file trace.h

2021-04-13 Thread Thierry Reding
On Mon, Apr 12, 2021 at 07:20:40PM -0300, Aline Santana Cordeiro wrote: > Align line break to match with the open parenthesis. > Issue detected by checkpatch.pl. > It consequently solved a few end lines with a '(', > issue also detected by checkpatch.pl > > Signed-off-by: Aline Santana Cordeiro

Re: [PATCH v3 1/4] dt-bindings: pwm: convert pwm-rockchip.txt to YAML

2021-04-13 Thread Thierry Reding
delete mode 100644 Documentation/devicetree/bindings/pwm/pwm-rockchip.txt > create mode 100644 Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml Heiko, do you want to pick up patches 1 & 2 into your tree along with 3 & 4? If so: Acked-by: Thierry Reding signature.asc Description: PGP signature

Re: [PATCH v3 2/4] dt-bindings: pwm: add more compatible strings to pwm-rockchip.yaml

2021-04-13 Thread Thierry Reding
it or > someone makes a solution for the whole PWM block. > > Changed V3: > fix mistake with compatibles introduced in V2 > Changed V2: > changed schema for clocks and clock-names > --- > Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml | 12 > 1 file changed, 12 insertions(+) Acked-by: Thierry Reding signature.asc Description: PGP signature

Re: [PATCH v8 1/8] pwm: pca9685: Switch to atomic API

2021-04-13 Thread Thierry Reding
On Tue, Apr 13, 2021 at 02:11:38PM +0200, Clemens Gruber wrote: > Hi Uwe, > > On Mon, Apr 12, 2021 at 10:10:19PM +0200, Uwe Kleine-König wrote: > > Hello Clemens, > > > > On Mon, Apr 12, 2021 at 06:39:28PM +0200, Clemens Gruber wrote: > > > On Mon, Apr 12, 2021 at 06:18:08PM +0200, Uwe

Re: [PATCH v8 4/8] dt-bindings: pwm: Support new PWM_USAGE_POWER flag

2021-04-13 Thread Thierry Reding
On Mon, Apr 12, 2021 at 06:27:23PM +0200, Uwe Kleine-König wrote: > On Mon, Apr 12, 2021 at 03:27:41PM +0200, Clemens Gruber wrote: > > Add the flag and corresponding documentation for PWM_USAGE_POWER. > > My concern here in the previous round was that PWM_USAGE_POWER isn't a > name that

Re: [PATCH v8 4/8] dt-bindings: pwm: Support new PWM_USAGE_POWER flag

2021-04-13 Thread Thierry Reding
On Tue, Apr 13, 2021 at 01:38:05PM +0200, Uwe Kleine-König wrote: > Hello, > > On Mon, Apr 12, 2021 at 06:46:51PM +0200, Clemens Gruber wrote: > > On Mon, Apr 12, 2021 at 06:27:23PM +0200, Uwe Kleine-König wrote: > > > On Mon, Apr 12, 2021 at 03:27:41PM +0200, Clemens Gruber wrote: > > > > Add

Re: [PATCH v3 2/2] pwm: visconti: Add Toshiba Visconti SoC PWM support

2021-04-09 Thread Thierry Reding
On Fri, Apr 09, 2021 at 06:07:09PM +0900, Nobuhiro Iwamatsu wrote: > Add driver for the PWM controller on Toshiba Visconti ARM SoC. > > Signed-off-by: Nobuhiro Iwamatsu > --- > drivers/pwm/Kconfig| 9 ++ > drivers/pwm/Makefile | 1 + > drivers/pwm/pwm-visconti.c | 193

Re: [PATCH v7 3/8] pwm: pca9685: Improve runtime PM behavior

2021-04-09 Thread Thierry Reding
On Tue, Apr 06, 2021 at 06:41:35PM +0200, Clemens Gruber wrote: > The chip does not come out of POR in active state but in sleep state. > To be sure (in case the bootloader woke it up) we force it to sleep in > probe. > > On kernels without CONFIG_PM, we wake the chip in .probe and put it to >

Re: [PATCH v7 4/8] dt-bindings: pwm: Support new PWM_STAGGERING_ALLOWED flag

2021-04-09 Thread Thierry Reding
On Wed, Apr 07, 2021 at 07:33:57AM +0200, Uwe Kleine-König wrote: > On Tue, Apr 06, 2021 at 06:41:36PM +0200, Clemens Gruber wrote: > > Add the flag and corresponding documentation for the new PWM staggering > > mode feature. > > > > Cc: Rob Herring > > Signed-off-by: Clemens Gruber > > For

Re: [v3,PATCH 3/3] pwm: mtk_disp: implement .get_state()

2021-04-09 Thread Thierry Reding
On Tue, Apr 06, 2021 at 12:27:56PM +0200, Uwe Kleine-König wrote: > On Tue, Apr 06, 2021 at 05:57:42PM +0800, Rex-BC Chen wrote: > > implement get_state function for pwm-mtk-disp > > > > Signed-off-by: Rex-BC Chen > > Signed-off-by: Jitao Shi > > Ideally you S-o-b line is the last one to show

Re: [PATCH] pwm: Rename pwm_get_state() to better reflect its semantic

2021-04-09 Thread Thierry Reding
On Tue, Apr 06, 2021 at 03:43:56PM +0200, Uwe Kleine-König wrote: > Hello Thierry, > > On Tue, Apr 06, 2021 at 01:16:31PM +0200, Thierry Reding wrote: > > On Tue, Apr 06, 2021 at 09:30:36AM +0200, Uwe Kleine-König wrote: > > > Given that lowlevel drivers usually canno

Re: [PATCH v2] drm/panel: panel-dsi-cm: convert sysfs snprintf to sysfs_emit

2021-04-09 Thread Thierry Reding
On Thu, Apr 08, 2021 at 11:08:49PM +0800, Xuezhi zhang wrote: > On Thu, 8 Apr 2021 15:14:04 +0200 > Thierry Reding wrote: > > > On Thu, Apr 08, 2021 at 08:52:57AM +, Carlis wrote: > > > From: Xuezhi Zhang > > > > > > Fix the following coccicheck w

Re: [PATCH] pwm: raspberrypi-poe: Fix mailbox message initialization

2021-04-09 Thread Thierry Reding
t; drivers/pwm/pwm-raspberrypi-poe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Thierry Reding signature.asc Description: PGP signature

Re: [PATCH] [v2] dmaengine: tegra20: Fix runtime PM imbalance on error

2021-04-09 Thread Thierry Reding
get(), which will not change the runtime > PM counter on error. > > Signed-off-by: Dinghao Liu > --- > > Changelog: > > v2: - Fix another similar case in tegra_dma_synchronize(). > --- > drivers/dma/tegra20-apb-dma.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deleti

Re: [PATCH -next] soc/tegra: fuse: add missing iounmap() on error in tegra_init_fuse()

2021-04-09 Thread Thierry Reding
On Fri, Apr 09, 2021 at 12:49:03PM +0800, Yang Yingliang wrote: > Add the missing iounmap() before return from tegra_init_fuse() > in the error handling case. > > Fixes: 9f94fadd75d3 ("soc/tegra: fuse: Register cell lookups for > compatibility") > Reported-by: Hulk Robot > Signed-off-by: Yang

Re: [PATCH v2] ata: ahci_tegra: call tegra_powergate_power_off only when PM domain is not present

2021-04-09 Thread Thierry Reding
a/ahci_tegra.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) Acked-by: Thierry Reding signature.asc Description: PGP signature

Re: [PATCH v7 5/8] pwm: core: Support new PWM_STAGGERING_ALLOWED flag

2021-04-09 Thread Thierry Reding
On Thu, Apr 08, 2021 at 07:36:37PM +0200, Uwe Kleine-König wrote: > On Thu, Apr 08, 2021 at 05:51:36PM +0200, Clemens Gruber wrote: > > On Thu, Apr 08, 2021 at 02:50:40PM +0200, Thierry Reding wrote: > > > Yes, I think that's basically what this is saying. I think we're perhaps

Re: [PATCH v7 5/8] pwm: core: Support new PWM_STAGGERING_ALLOWED flag

2021-04-09 Thread Thierry Reding
On Thu, Apr 08, 2021 at 05:51:36PM +0200, Clemens Gruber wrote: > On Thu, Apr 08, 2021 at 02:50:40PM +0200, Thierry Reding wrote: > > On Wed, Apr 07, 2021 at 11:34:03PM +0200, Uwe Kleine-König wrote: > > > On Wed, Apr 07, 2021 at 10:21:10PM +0200, Clemens Gruber wrote: > >

Re: [PATCH v1 1/2] iommu/tegra-smmu: Defer attachment of display clients

2021-04-08 Thread Thierry Reding
On Thu, Apr 08, 2021 at 02:42:42AM -0700, Nicolin Chen wrote: > On Mon, Mar 29, 2021 at 02:32:55AM +0300, Dmitry Osipenko wrote: > > All consumer-grade Android and Chromebook devices show a splash screen > > on boot and then display is left enabled when kernel is booted. This > > behaviour is

Re: [PATCH] drm/panel: tpo-td043mtea1: convert sysfs snprintf to sysfs_emit

2021-04-08 Thread Thierry Reding
6: > WARNING: use scnprintf or sprintf > > Signed-off-by: Xuezhi Zhang > --- > drivers/gpu/drm/panel/panel-tpo-td043mtea1.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Thierry Reding signature.asc Description: PGP signature

Re: [PATCH v2] drm/panel: panel-dsi-cm: convert sysfs snprintf to sysfs_emit

2021-04-08 Thread Thierry Reding
ail address, but it's kind of hard to tell because you haven't been using at least the same name in both email addresses. However, if you're forwarding this patch on behalf of somebody else you need to add your own Signed-off-by: line. Reviewed-by: Thierry Reding signature.asc Description: PGP signature

Re: [PATCH] PCI: tegra: Fix runtime PM imbalance in pex_ep_event_pex_rst_deassert

2021-04-08 Thread Thierry Reding
he second callsite has the proper cleanup code. Although it might be nice to use pm_runtime_resume_and_get() there as well, and adjust the cleanup path, to make this consistent. In any case, this looks good to me: Acked-by: Thierry Reding signature.asc Description: PGP signature

Re: [PATCH v4 3/3] ata: ahci_tegra: Add AHCI support for Tegra186

2021-04-08 Thread Thierry Reding
On Thu, Apr 08, 2021 at 02:25:19AM +0300, Dmitry Osipenko wrote: > 08.04.2021 02:00, Sowjanya Komatineni пишет: > > > > On 4/7/21 3:57 PM, Sowjanya Komatineni wrote: > >> > >> On 4/7/21 2:36 PM, Dmitry Osipenko wrote: > >>> 07.04.2021 04:25, Sowjanya Komatineni пишет: > +    if

Re: [PATCH v7 5/8] pwm: core: Support new PWM_STAGGERING_ALLOWED flag

2021-04-08 Thread Thierry Reding
On Wed, Apr 07, 2021 at 11:34:03PM +0200, Uwe Kleine-König wrote: > On Wed, Apr 07, 2021 at 10:21:10PM +0200, Clemens Gruber wrote: > > On Wed, Apr 07, 2021 at 07:46:58AM +0200, Uwe Kleine-König wrote: > > > On Tue, Apr 06, 2021 at 06:41:37PM +0200, Clemens Gruber wrote: > > > > If the flag

Re: [PATCH v1 1/2] iommu/tegra-smmu: Defer attachment of display clients

2021-04-08 Thread Thierry Reding
On Mon, Mar 29, 2021 at 02:32:55AM +0300, Dmitry Osipenko wrote: > All consumer-grade Android and Chromebook devices show a splash screen > on boot and then display is left enabled when kernel is booted. This > behaviour is unacceptable in a case of implicit IOMMU domains to which > devices are

Re: [PATCH v2 2/2] pwm: visconti: Add Toshiba Visconti SoC PWM support

2021-04-08 Thread Thierry Reding
On Thu, Apr 08, 2021 at 09:59:20AM +0200, Uwe Kleine-König wrote: > Hello Nobuhiro, > > On Thu, Apr 08, 2021 at 08:15:48AM +0900, Nobuhiro Iwamatsu wrote: > > > > + /* > > > > +* pwmc is a 2-bit divider for the input clock running at 1 MHz. > > > > +* When the settings of

Re: [PATCH v4 0/3] Add AHCI support for Tegra186

2021-04-07 Thread Thierry Reding
On Wed, Apr 07, 2021 at 09:44:58AM -0600, Jens Axboe wrote: > On 4/6/21 7:25 PM, Sowjanya Komatineni wrote: > > Re-sending dt-binding and ahci_tegra driver patches as v4 as device > > tree patches from v3 are merged but not the AHCI Tegra driver. > > > > Missed to add Jens Axboe to mailing list

Re: [PATCH v4 3/3] ata: ahci_tegra: Add AHCI support for Tegra186

2021-04-07 Thread Thierry Reding
t; --- > drivers/ata/ahci_tegra.c | 60 > +--- > 1 file changed, 47 insertions(+), 13 deletions(-) Acked-by: Thierry Reding signature.asc Description: PGP signature

Re: [PATCH v4 2/3] dt-binding: ata: tegra: Add dt-binding documentation for Tegra186

2021-04-07 Thread Thierry Reding
,tegra-ahci.yaml | 38 > ++ > 1 file changed, 38 insertions(+) Acked-by: Thierry Reding signature.asc Description: PGP signature

Re: [PATCH v4 1/3] dt-bindings: ata: tegra: Convert binding documentation to YAML

2021-04-07 Thread Thierry Reding
cumentation/devicetree/bindings/ata/nvidia,tegra124-ahci.txt Acked-by: Thierry Reding signature.asc Description: PGP signature

Re: [PATCH] media: Fix compilation error

2021-04-07 Thread Thierry Reding
On Wed, Apr 07, 2021 at 04:45:34PM +0300, Mikko Perttunen wrote: > On 7.4.2021 16.29, Hans Verkuil wrote: > > On 02/04/2021 09:40, Bixuan Cui wrote: > > > Fix the error: > > > > > > drivers/staging/media/tegra-video/vi.c:1180:4: > > > error: implicit declaration of function 'host1x_syncpt_free'

Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2021-04-06 Thread Thierry Reding
On Tue, Apr 06, 2021 at 08:33:57AM +0200, Uwe Kleine-König wrote: > Hello Thierry, > > On Wed, Mar 31, 2021 at 05:52:45PM +0200, Thierry Reding wrote: > > On Wed, Mar 31, 2021 at 12:25:43PM +0200, Uwe Kleine-König wrote: > > > On Mon, Mar 22, 2021 at 09:34:21AM +01

Re: [PATCH 5.10 079/126] drm/tegra: sor: Grab runtime PM reference across reset

2021-04-06 Thread Thierry Reding
On Mon, Apr 05, 2021 at 05:42:21PM +0200, Pavel Machek wrote: > Hi! > > > However, these functions alone don't provide any guarantees at the > > system level. Drivers need to ensure that the only a single consumer has > > access to the reset at the same time. In order for the SOR to be able to >

Re: [PATCH] pwm: Rename pwm_get_state() to better reflect its semantic

2021-04-06 Thread Thierry Reding
On Tue, Apr 06, 2021 at 09:30:36AM +0200, Uwe Kleine-König wrote: > Given that lowlevel drivers usually cannot implement exactly what a > consumer requests with pwm_apply_state() there is some rounding involved. > > pwm_get_state() traditionally returned the setting that was requested most >

Re: [PATCH v6 4/7] pwm: pca9685: Support staggered output ON times

2021-04-01 Thread Thierry Reding
On Thu, Apr 01, 2021 at 09:50:44AM +0200, Clemens Gruber wrote: > Hi Thierry, > > On Wed, Mar 31, 2021 at 06:21:32PM +0200, Thierry Reding wrote: > > On Wed, Mar 31, 2021 at 02:26:14PM +0200, Clemens Gruber wrote: > > > On Mon, Mar 29, 2021 at 08:02:06PM +0200

Re: [PATCH RFT 2/2] i2c: tegra-bpmp: make some functions void

2021-04-01 Thread Thierry Reding
On Wed, Mar 31, 2021 at 09:51:41AM +0200, Wolfram Sang wrote: > They return 0 always, so save some lines and code. > > Signed-off-by: Wolfram Sang > --- > drivers/i2c/busses/i2c-tegra-bpmp.c | 20 > 1 file changed, 4 insertions(+), 16 deletions(-) Tested-

Re: [PATCH RFT 1/2] i2c: tegra-bpmp: don't modify input variable in xlate_flags

2021-04-01 Thread Thierry Reding
ang > --- > drivers/i2c/busses/i2c-tegra-bpmp.c | 32 - > 1 file changed, 8 insertions(+), 24 deletions(-) I've applied this to my local development tree and ran this on Tegra194, didn't see any issues, so: Tested-by: Thierry Reding signature.asc Description: PGP signature

Re: [PATCH RFT 2/2] i2c: tegra-bpmp: make some functions void

2021-04-01 Thread Thierry Reding
On Wed, Mar 31, 2021 at 09:51:41AM +0200, Wolfram Sang wrote: > They return 0 always, so save some lines and code. > > Signed-off-by: Wolfram Sang > --- > drivers/i2c/busses/i2c-tegra-bpmp.c | 20 > 1 file changed, 4 insertions(+), 16 deletions(-) Acked-

Re: [PATCH RFT 1/2] i2c: tegra-bpmp: don't modify input variable in xlate_flags

2021-04-01 Thread Thierry Reding
ang > --- > drivers/i2c/busses/i2c-tegra-bpmp.c | 32 - > 1 file changed, 8 insertions(+), 24 deletions(-) Heh... good catch! Acked-by: Thierry Reding signature.asc Description: PGP signature

Re: [PATCH v6 4/7] pwm: pca9685: Support staggered output ON times

2021-03-31 Thread Thierry Reding
On Wed, Mar 31, 2021 at 02:26:14PM +0200, Clemens Gruber wrote: > On Mon, Mar 29, 2021 at 08:02:06PM +0200, Uwe Kleine-König wrote: > > On Mon, Mar 29, 2021 at 07:16:38PM +0200, Clemens Gruber wrote: > > > On Mon, Mar 29, 2021 at 07:03:57PM +0200, Uwe Kleine-König wrote: > > > > On Mon, Mar 29,

Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2021-03-31 Thread Thierry Reding
On Wed, Mar 31, 2021 at 12:25:43PM +0200, Uwe Kleine-König wrote: > Hello Thierry, > > On Mon, Mar 22, 2021 at 09:34:21AM +0100, Thierry Reding wrote: > > On Mon, Jan 11, 2021 at 09:43:50PM +0100, Uwe Kleine-König wrote: > > > On Sun, Jan 03, 2021 at 06:04:10PM +01

Re: [PATCH 13/17] ASoC: tegra: tegra20_das: align function prototypes

2021-03-29 Thread Thierry Reding
different: > declaration 'dap_sel' definition 'dap'. > int tegra20_das_connect_dac_to_dap(int dac, int dap) > ^ > > Signed-off-by: Pierre-Louis Bossart > --- > sound/soc/tegra/tegra20_das.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Acked-by: Thierry Reding signature.asc Description: PGP signature

Re: [PATCH 12/17] ASoC: tegra: tegra20_das: clarify expression

2021-03-29 Thread Thierry Reding
gt; !!sdata1rx << TEGRA20_DAS_DAP_CTRL_SEL_DAP_SDATA1_TX_RX_P | > ^ > > Signed-off-by: Pierre-Louis Bossart > --- > sound/soc/tegra/tegra20_das.c | 8 ++++ > 1 file changed, 4 insertions(+), 4 deletions(-) Acked-by: Thierry Reding signature.asc Description: PGP signature

Re: [PATCH] spi: dt-bindings: nvidia,tegra210-quad: Use documented compatible "jedec,spi-nor" in example

2021-03-29 Thread Thierry Reding
On Sat, Mar 27, 2021 at 03:33:57PM -0500, Rob Herring wrote: > The 'spi-nor' compatible used in the example is not documented. Use the > documented 'jedec,spi-nor' compatible instead. > > Cc: Mark Brown > Cc: Thierry Reding > Cc: Jonathan Hunter > Cc: linux-...@vger.kern

Re: [PATCH v2 05/20] drm/dp: Add backpointer to drm_device in drm_dp_aux

2021-03-29 Thread Thierry Reding
rely on drm_dp_aux->drm_dev to always be > non-NULL until drm_dp_aux_register() has been called. We make sure to point > this out in the documentation for struct drm_dp_aux. > > Signed-off-by: Lyude Paul > --- [...] > drivers/gpu/drm/tegra/dpaux.c

Re: [PATCH v2 02/20] drm/tegra: Don't register DP AUX channels before connectors

2021-03-29 Thread Thierry Reding
to use > the AUX channel before we've associated it with it's DRM connector. > > Signed-off-by: Lyude Paul > --- > drivers/gpu/drm/tegra/dpaux.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) Acked-by: Thierry Reding signature.asc Description: PGP signature

Re: [PATCH v2] ASoC: dt-bindings: nvidia,tegra210-ahub: Add missing child nodes

2021-03-29 Thread Thierry Reding
nd reference their schema if one exists. > > Cc: Liam Girdwood > Cc: Mark Brown > Cc: Thierry Reding > Cc: Jonathan Hunter > Cc: Sameer Pujar > Cc: alsa-de...@alsa-project.org > Cc: linux-te...@vger.kernel.org > Signed-off-by: Rob Herring > --- > v2: &g

Re: [PATCH] dt-bindings: Clean-up undocumented compatible strings

2021-03-26 Thread Thierry Reding
In a couple of cases, fixing the compatible revealed some schema errors > which are fixed. > > There's a bunch of others remaining after this which have bindings, but > those aren't converted to schema yet. > > Cc: Stephen Boyd > Cc: Maxime Ripard > Cc: Thierry Reding

Re: [RFC PATCH 1/3] dt-bindings: display: simple: Add the panel on sc7180-trogdor-pompom

2021-03-26 Thread Thierry Reding
On Wed, Mar 17, 2021 at 06:53:04PM -0700, Rob Clark wrote: > On Wed, Mar 17, 2021 at 4:27 PM Matthias Kaehlcke wrote: > > > > On Tue, Mar 16, 2021 at 02:08:19PM -0700, Douglas Anderson wrote: > > > The sc7180-trogdor-pompom board might be attached to any number of a > > > pile of eDP panels. At

Re: [PATCH v6 3/3] ARM: tegra: acer-a500: Add atmel,wakeup-method property

2021-03-26 Thread Thierry Reding
On Thu, Mar 25, 2021 at 11:15:54AM -0700, Dmitry Torokhov wrote: > On Thu, Mar 25, 2021 at 03:10:25PM +0100, Thierry Reding wrote: > > On Sun, Mar 21, 2021 at 03:40:28PM -0700, Dmitry Torokhov wrote: > > > On Tue, Mar 02, 2021 at 01:21:58PM +0300, Dmitry Osipenko wrote: >

Re: [PATCH v4 3/6] dt-bindings: power: tegra: Add binding for core power domain

2021-03-25 Thread Thierry Reding
.0-only OR BSD-2-Clause > >> +%YAML 1.2 > >> +--- > >> +$id: http://devicetree.org/schemas/power/nvidia,tegra20-core-domain.yaml# > >> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >> + > >> +title: NVIDIA Tegra Core Power Domain > >>

Re: [PATCH v4 5/5] soc/tegra: pmc: Rate-limit error message about failed to acquire of reset

2021-03-25 Thread Thierry Reding
On Tue, Mar 02, 2021 at 03:25:02PM +0300, Dmitry Osipenko wrote: > PMC domain could be easily bombarded with the enable requests if there is > a problem in regards to acquiring reset control of a domain and kernel > log will be flooded with the error message in this case. Hence rate-limit > the

Re: [PATCH v4 4/5] soc/tegra: pmc: Print out domain name when reset fails to acquire

2021-03-25 Thread Thierry Reding
On Tue, Mar 02, 2021 at 03:25:01PM +0300, Dmitry Osipenko wrote: > Print out domain name when reset fails to acquire for debugging purposes > and to make formatting of GENPD errors consistent in the driver. > > Tested-by: Peter Geis # Ouya T30 > Tested-by: Nicolas Chauvet # PAZ00 T20 and TK1

Re: [PATCH v4 3/5] soc/tegra: pmc: Ensure that clock rates aren't too high

2021-03-25 Thread Thierry Reding
On Tue, Mar 02, 2021 at 03:25:00PM +0300, Dmitry Osipenko wrote: > Switch all clocks of a power domain to a safe rate which is suitable > for all possible voltages in order to ensure that hardware constraints > aren't violated when power domain state toggles. > > Tested-by: Peter Geis # Ouya T30

Re: [PATCH v4 2/5] soc/tegra: pmc: Fix completion of power-gate toggling

2021-03-25 Thread Thierry Reding
On Tue, Mar 02, 2021 at 03:24:59PM +0300, Dmitry Osipenko wrote: > The SW-initiated power gate toggling is dropped by PMC if there is > contention with a HW-initiated toggling, i.e. when one of CPU cores is > gated by cpuidle driver. Software should retry the toggling after 10 > microseconds on

Re: [PATCH v4 1/5] soc/tegra: pmc: Fix imbalanced clock disabling in error code path

2021-03-25 Thread Thierry Reding
On Tue, Mar 02, 2021 at 03:24:58PM +0300, Dmitry Osipenko wrote: > The tegra_powergate_power_up() has a typo in the error code path where it > will try to disable clocks twice, fix it. In practice that error never > happens, so this is a minor correction. > > Tested-by: Peter Geis # Ouya T30 >

Re: [PATCH v6 3/3] ARM: tegra: acer-a500: Add atmel,wakeup-method property

2021-03-25 Thread Thierry Reding
On Sun, Mar 21, 2021 at 03:40:28PM -0700, Dmitry Torokhov wrote: > On Tue, Mar 02, 2021 at 01:21:58PM +0300, Dmitry Osipenko wrote: > > Acer A500 uses Atmel Maxtouch 1386 touchscreen controller. This controller > > has WAKE line which could be connected to I2C clock lane, dedicated GPIO > > or

Re: [PATCH v1] soc/tegra: regulators: Fix locking up when voltage-spread is out of range

2021-03-25 Thread Thierry Reding
On Tue, Mar 02, 2021 at 04:18:00PM +0300, Dmitry Osipenko wrote: > Fix voltage coupler lockup which happens when voltage-spread is out > of range due to a bug in the code. The max-spread requirement shall be > accounted when CPU regulator doesn't have consumers. This problem is > observed on

Re: [PATCH v7 00/14] Tegra XHCI controller ELPG support

2021-03-25 Thread Thierry Reding
On Thu, Mar 25, 2021 at 11:45:16AM +0530, Vinod Koul wrote: > On 24-03-21, 14:32, Thierry Reding wrote: > > On Wed, Mar 24, 2021 at 01:39:32PM +0100, Thierry Reding wrote: > > > On Fri, Feb 05, 2021 at 05:22:29PM +0100, Greg KH wrote: > > > > On Fri, Feb 05, 202

Re: [PATCH v1] drm/tegra: dc: Don't set PLL clock to 0Hz

2021-03-24 Thread Thierry Reding
On Tue, Mar 02, 2021 at 04:15:06PM +0300, Dmitry Osipenko wrote: > RGB output doesn't allow to change parent clock rate of the display and > PCLK rate is set to 0Hz in this case. The tegra_dc_commit_state() shall > not set the display clock to 0Hz since this change propagates to the > parent

Re: [PATCH v3 00/14] NVIDIA Tegra ARM32 device-tree improvements

2021-03-24 Thread Thierry Reding
On Tue, Mar 02, 2021 at 03:09:49PM +0300, Dmitry Osipenko wrote: > Hi, > > This series is partially factored out from [1] since the DT patches > could be applied separately. In addition I added couple more new > patches and implemented suggestion given by Daniel Lezcano to [1], > see "Specify all

Re: [PATCH v3 09/14] ARM: tegra: acer-a500: Rename avdd to vdda of touchscreen node

2021-03-24 Thread Thierry Reding
On Tue, Mar 02, 2021 at 03:09:58PM +0300, Dmitry Osipenko wrote: > Rename avdd supply to vdda of the touchscreen node. The old supply name > was incorrect. > > Signed-off-by: Dmitry Osipenko > --- > arch/arm/boot/dts/tegra20-acer-a500-picasso.dts | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH v7 00/14] Tegra XHCI controller ELPG support

2021-03-24 Thread Thierry Reding
On Wed, Mar 24, 2021 at 01:39:32PM +0100, Thierry Reding wrote: > On Fri, Feb 05, 2021 at 05:22:29PM +0100, Greg KH wrote: > > On Fri, Feb 05, 2021 at 05:15:21PM +0100, Thierry Reding wrote: > > > On Wed, Jan 20, 2021 at 03:34:00PM +0800, JC Kuo wrote: > > > > Tegr

Re: [PATCH v7 00/14] Tegra XHCI controller ELPG support

2021-03-24 Thread Thierry Reding
On Fri, Feb 05, 2021 at 05:22:29PM +0100, Greg KH wrote: > On Fri, Feb 05, 2021 at 05:15:21PM +0100, Thierry Reding wrote: > > On Wed, Jan 20, 2021 at 03:34:00PM +0800, JC Kuo wrote: > > > Tegra XHCI controler can be placed in ELPG (Engine Level PowerGated) > > > stat

Re: [PATCH] thermal: Fix a typo in the file soctherm.c

2021-03-23 Thread Thierry Reding
On Fri, Mar 05, 2021 at 07:23:20AM +0530, Bhaskar Chowdhury wrote: > > s/calibaration/calibration/ > > Signed-off-by: Bhaskar Chowdhury > --- > drivers/thermal/tegra/soctherm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Thierry Reding signature

Re: GTE - The hardware timestamping engine

2021-03-23 Thread Thierry Reding
On Tue, Mar 23, 2021 at 10:08:00AM +0100, Linus Walleij wrote: > On Mon, Mar 22, 2021 at 9:17 PM Dipen Patel wrote: > > > My follow-up concerns on both Linus's and Kent's feedback: > > > > 1. Please correct me if I am wrong, lineevent in the gpiolib* is only > > serves the userspace

Re: GTE - The hardware timestamping engine

2021-03-23 Thread Thierry Reding
On Mon, Mar 22, 2021 at 01:33:38PM -0700, Dipen Patel wrote: > Hi Richard, > > Thanks for your input and time. Please see below follow up. > > On 3/20/21 8:38 AM, Richard Cochran wrote: > > On Sat, Mar 20, 2021 at 01:44:20PM +0100, Arnd Bergmann wrote: > >> Adding Richard Cochran as well, for

Re: [PATCH] clk: tegra: fix old-style declaration

2021-03-23 Thread Thierry Reding
old-style-declaration] > 1380 | static void inline dfll_debug_init(struct tegra_dfll *td) { } > > Move the 'inline' keyword to the start of the line. > > Signed-off-by: Arnd Bergmann > --- > drivers/clk/tegra/clk-dfll.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(

Re: [PATCH v8 11/11] pwm: Add Raspberry Pi Firmware based PWM bus

2021-03-22 Thread Thierry Reding
ors > - Correct apply() function > - Round values > - Fix divisions in arm32 mode > - Small cleanups > > drivers/pwm/Kconfig | 9 ++ > drivers/pwm/Makefile | 1 + > drivers/pwm/pwm-raspberrypi-poe.c | 206 ++ >

Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2021-03-22 Thread Thierry Reding
On Fri, Jan 29, 2021 at 09:37:47PM +0100, Clemens Gruber wrote: > Hi Sven, > > On Fri, Jan 29, 2021 at 01:05:14PM -0500, Sven Van Asbroeck wrote: > > Hi Clemens, > > > > On Fri, Jan 29, 2021 at 11:31 AM Clemens Gruber > > wrote: > > > > > > Ok, so you suggest we extend our get_state logic to

Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2021-03-22 Thread Thierry Reding
On Fri, Jan 29, 2021 at 01:05:14PM -0500, Sven Van Asbroeck wrote: > Hi Clemens, > > On Fri, Jan 29, 2021 at 11:31 AM Clemens Gruber > wrote: > > > > Ok, so you suggest we extend our get_state logic to deal with cases > > like the following: > > Kind of. We can't control how other actors

Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2021-03-22 Thread Thierry Reding
On Thu, Jan 14, 2021 at 06:16:22PM +0100, Clemens Gruber wrote: > Hi, > > On Mon, Jan 11, 2021 at 09:35:32PM +0100, Uwe Kleine-König wrote: > > Hello, > > > > On Thu, Dec 17, 2020 at 06:43:04PM +0100, Clemens Gruber wrote: > > > On Wed, Dec 16, 2020 at 11:00:59PM -0500, Sven Van Asbroeck wrote:

Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2021-03-22 Thread Thierry Reding
On Mon, Jan 11, 2021 at 09:35:32PM +0100, Uwe Kleine-König wrote: > Hello, > > On Thu, Dec 17, 2020 at 06:43:04PM +0100, Clemens Gruber wrote: > > On Wed, Dec 16, 2020 at 11:00:59PM -0500, Sven Van Asbroeck wrote: > > > On Wed, Dec 16, 2020 at 7:53 AM Clemens Gruber > > > wrote: > > > > > > > >

Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2021-03-22 Thread Thierry Reding
On Mon, Jan 11, 2021 at 09:43:50PM +0100, Uwe Kleine-König wrote: > On Sun, Jan 03, 2021 at 06:04:10PM +0100, Clemens Gruber wrote: > > Another point is the period: Sven suggested we do not read out the > > period at all, as the PWM is disabled anyway (see above). > > Is this acceptable? > > In

Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2021-03-22 Thread Thierry Reding
On Sun, Jan 03, 2021 at 06:04:10PM +0100, Clemens Gruber wrote: > Hi everyone, > > happy new year, hope you are all well! > > On Thu, Dec 17, 2020 at 12:52:42PM -0500, Sven Van Asbroeck wrote: > > On Thu, Dec 17, 2020 at 12:43 PM Clemens Gruber > > wrote: > > > > > > > > Conclusion:

Re: [PATCH v5 1/7] pwm: pca9685: Switch to atomic API

2021-03-22 Thread Thierry Reding
On Thu, Dec 17, 2020 at 12:10:10PM -0500, Sven Van Asbroeck wrote: > On Thu, Dec 17, 2020 at 11:48 AM Clemens Gruber > wrote: > > > > I can initialize the values to 0 of course and check the file for other > > places with missing initializations. > > > > Or would it be better to check the return

Re: [PATCH v5] iommu/tegra-smmu: Add pagetable mappings to debugfs

2021-03-16 Thread Thierry Reding
On Mon, Mar 15, 2021 at 01:36:31PM -0700, Nicolin Chen wrote: > This patch dumps all active mapping entries from pagetable > to a debugfs directory named "mappings". > > Attaching an example: > > SWGROUP: hc > ASID: 0 > reg: 0x250 > PTB_ASID: 0xe0080004 > as->pd_dma: 0x80004000 > { >

Re: [PATCH] iommu/tegra-smmu: Fix mc errors on tegra124-nyan

2021-03-03 Thread Thierry Reding
mmu_probe_device()") > Reported-by: Guillaume Tucker > Signed-off-by: Nicolin Chen > --- > > Guillaume, would you please give a "Tested-by" to this change? Thanks! > > drivers/iommu/tegra-smmu.c | 72 +- > 1 file changed, 71 insertions(+), 1 deletion(-) Acked-by: Thierry Reding signature.asc Description: PGP signature

[GIT PULL] pwm: Changes for v5.12-rc1

2021-02-25 Thread Thierry Reding
Hi Linus, The following changes since commit 6eefb79d6f5bc4086bd02c76f1072dd4a8d9d9f6: pwm: sun4i: Remove erroneous else branch (2020-12-17 14:23:49 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/thierry.reding/linux-pwm.git

Re: next/master bisection: baseline.login on r8a77960-ulcb

2021-02-25 Thread Thierry Reding
On Thu, Feb 25, 2021 at 11:14:57AM +, Robin Murphy wrote: > On 2021-02-25 11:09, Thierry Reding wrote: > > On Wed, Feb 24, 2021 at 10:39:42PM +0100, Heiko Thiery wrote: > > > Hi Christoph and all, > > > > > > On 23.02.21 10:56, Guillaum

Re: next/master bisection: baseline.login on r8a77960-ulcb

2021-02-25 Thread Thierry Reding
On Wed, Feb 24, 2021 at 10:39:42PM +0100, Heiko Thiery wrote: > Hi Christoph and all, > > On 23.02.21 10:56, Guillaume Tucker wrote: > > Hi Christoph, > > > > Please see the bisection report below about a boot failure on > > r8a77960-ulcb on next-20210222. > > > > Reports aren't automatically

Re: [PATCH v2 1/3] pwm: mtk_disp: clear the clock operations

2021-02-22 Thread Thierry Reding
On Sat, Jan 30, 2021 at 10:12:24PM +0800, Jitao Shi wrote: > Remove the clk_prepare from mtk_disp_pwm_probe. > Remove the clk_unprepare from mtk_disp_pwm_remove. > > Signed-off-by: Jitao Shi > --- > drivers/pwm/pwm-mtk-disp.c | 23 ++- > 1 file changed, 2 insertions(+), 21

Re: [PATCH] tty: serial: Add earlycon driver for Tegra Combined UART

2021-02-15 Thread Thierry Reding
On Mon, Feb 15, 2021 at 12:35:31PM +0200, Mikko Perttunen wrote: > On 2/15/21 12:25 PM, Thierry Reding wrote: > > On Sat, Feb 13, 2021 at 01:58:24PM +0200, Mikko Perttunen wrote: > > > Add an earlycon driver for platforms with TCU, namely Tegra194. > > > The dri

Re: [PATCH] mailbox: tegra-hsp: Set lockdep class dynamically

2021-02-15 Thread Thierry Reding
; > Signed-off-by: Mikko Perttunen > --- > drivers/mailbox/tegra-hsp.c | 15 +++ > 1 file changed, 15 insertions(+) Acked-by: Thierry Reding signature.asc Description: PGP signature

Re: [PATCH -next] staging: nvec: minor coding style fix

2021-02-15 Thread Thierry Reding
ertion(+), 1 deletion(-) Acked-by: Thierry Reding signature.asc Description: PGP signature

Re: [PATCH] tty: serial: Add earlycon driver for Tegra Combined UART

2021-02-15 Thread Thierry Reding
On Sat, Feb 13, 2021 at 01:58:24PM +0200, Mikko Perttunen wrote: > Add an earlycon driver for platforms with TCU, namely Tegra194. > The driver is compatible with boot parameters passed by NVIDIA > boot chains. I'm not sure I understand the latter part of this description. What boot parameters is

Re: [PATCH v7 00/14] Tegra XHCI controller ELPG support

2021-02-05 Thread Thierry Reding
On Wed, Jan 20, 2021 at 03:34:00PM +0800, JC Kuo wrote: > Tegra XHCI controler can be placed in ELPG (Engine Level PowerGated) > state for power saving when all of the connected USB devices are in > suspended state. This patch series includes clk, phy and pmc changes > that are required for

Re: [PATCH v2] pwm: sunxi: Add Allwinner SoC PWM controller driver

2021-02-04 Thread Thierry Reding
On Thu, Feb 04, 2021 at 02:54:36PM +0100, Uwe Kleine-König wrote: > Hello Thierry, > > On Thu, Feb 04, 2021 at 02:38:40PM +0100, Thierry Reding wrote: > > All I'm saying is that I don't think we need to require everyone to > > adopt a prefix, especially if this hasn't been

Re: [PATCH v2] pwm: sunxi: Add Allwinner SoC PWM controller driver

2021-02-04 Thread Thierry Reding
On Wed, Feb 03, 2021 at 09:59:13PM +0100, Uwe Kleine-König wrote: > Hello Thierry, hello Ban, > > On Wed, Feb 03, 2021 at 05:33:16PM +0100, Thierry Reding wrote: > > On Wed, Feb 03, 2021 at 04:12:00PM +0100, Uwe Kleine-König wrote: > > > On Wed, Feb 03, 2021 at 08:53:1

Re: [PATCH v2] pwm: sunxi: Add Allwinner SoC PWM controller driver

2021-02-03 Thread Thierry Reding
On Wed, Feb 03, 2021 at 04:12:00PM +0100, Uwe Kleine-König wrote: > On Wed, Feb 03, 2021 at 08:53:17PM +0800, Ban Tao wrote: [...] > > +#define PWM_GET_CLK_OFFSET(chan) (0x20 + ((chan >> 1) * 0x4)) > > +#define PWM_CLK_APB_SCRBIT(7) > > +#define PWM_DIV_M 0 >

Re: [PATCH v5 1/9] dt-bindings: clock: tegra: Add clock ID TEGRA210_CLK_QSPI_PM

2021-01-26 Thread Thierry Reding
On Mon, Dec 21, 2020 at 01:17:31PM -0800, Sowjanya Komatineni wrote: > Tegra210 QSPI clock output has divider DIV2_SEL which will be enabled > when using DDR interface mode. > > This patch adds clock ID for this to dt-binding. > > Acked-by: Rob Herring > Signed-off-by: Sowjanya Komatineni >

Re: [PATCH] arm64: tegra: Enable Jetson-Xavier J512 USB host

2021-01-21 Thread Thierry Reding
On Tue, Jan 19, 2021 at 10:23:49AM +0800, JC Kuo wrote: > This commit enables USB host mode at J512 type-C port of Jetson-Xavier. > > Signed-off-by: JC Kuo > --- > .../arm64/boot/dts/nvidia/tegra194-p2888.dtsi | 8 +++ > .../boot/dts/nvidia/tegra194-p2972-.dts | 24

Re: [RESEND PATCH v6 5/6] arm64: tegra: Audio graph header for Tegra210

2021-01-21 Thread Thierry Reding
On Tue, Jan 19, 2021 at 02:58:15PM +0530, Sameer Pujar wrote: > Expose a header which describes DT bindings required to use audio-graph > based sound card. All Tegra210 based platforms can include this header > and add platform specific information. Currently, from SoC point of view, > all links

  1   2   3   4   5   6   7   8   9   10   >