Re: [PATCH 6/8] drm/sun4i: sun4i_layer: Wire in the frontend

2017-12-13 Thread Thomas van Kleef
i ? "overlay" : "primary"); return ERR_CAST(layer); }; DRM_DEBUG_DRIVER("Assigning %s plane to pipe %d\n", i ? "overlay" : "primary", plane->pipe); regmap_update_bits(engine->regs, SUN4I_BACKEND_ATTCTL_REG0(i), SUN4I_BACKEND_ATTCTL_REG0_LAY_PIPESEL_MASK, SUN4I_BACKEND_ATTCTL_REG0_LAY_PIPESEL(plane->pipe)); layer->id = i; planes[i] = >plane; }; - I have been using the 3rd layer (layer2) as the input for the frontend. This essentially overlays the other 2 layers. Is it still the case that we can only have 2 layers here? Or could be present 1 additional layer when it is attached to the frontend? Perhaps this is not relevant for this patchset. Regards, Thomas van Kleef Vitsch Electronics http://Vitsch.nl/ http://VitschVPN.nl/ tel: +31-(0)40-7113051 KvK nr: 17174380 BTW nr: NL142748201B01

Re: [PATCH 6/8] drm/sun4i: sun4i_layer: Wire in the frontend

2017-12-13 Thread Thomas van Kleef
erlay" : "primary"); return ERR_CAST(layer); }; DRM_DEBUG_DRIVER("Assigning %s plane to pipe %d\n", i ? "overlay" : "primary", plane->pipe); regmap_update_bits(engine->regs, SUN4I_BACKEND_ATTCTL_REG0(i), SUN4I_BACKEND_ATTCTL_REG0_LAY_PIPESEL_MASK, SUN4I_BACKEND_ATTCTL_REG0_LAY_PIPESEL(plane->pipe)); layer->id = i; planes[i] = >plane; }; - I have been using the 3rd layer (layer2) as the input for the frontend. This essentially overlays the other 2 layers. Is it still the case that we can only have 2 layers here? Or could be present 1 additional layer when it is attached to the frontend? Perhaps this is not relevant for this patchset. Regards, Thomas van Kleef Vitsch Electronics http://Vitsch.nl/ http://VitschVPN.nl/ tel: +31-(0)40-7113051 KvK nr: 17174380 BTW nr: NL142748201B01

Re: [PATCH 0/8] drm/sun4i: Support the Display Engine frontend

2017-12-13 Thread Thomas van Kleef
Hi, On 13-12-17 16:33, Maxime Ripard wrote: > Hi, > > This is a first serie to enable the display engine frontend. > > This hardware block is found in the first generation Display Engine from > Allwinner. Its role is to implement more advanced features that the > associated backend, even though

Re: [PATCH 0/8] drm/sun4i: Support the Display Engine frontend

2017-12-13 Thread Thomas van Kleef
Hi, On 13-12-17 16:33, Maxime Ripard wrote: > Hi, > > This is a first serie to enable the display engine frontend. > > This hardware block is found in the first generation Display Engine from > Allwinner. Its role is to implement more advanced features that the > associated backend, even though

Re: [linux-sunxi] Cedrus driver

2017-11-29 Thread Thomas van Kleef
sunxi-cedrus: add syscon support ARM: dts: sun8i: add video engine support for A33 Thomas van Kleef (4): Merged requests2 into linux 4.14 Fix merge error Remove reject file from merge Fix the sun5i and sun8i dts files .../devicetree/bindings/media/sunxi-cedrus.txt

Re: [linux-sunxi] Cedrus driver

2017-11-29 Thread Thomas van Kleef
sunxi-cedrus: add syscon support ARM: dts: sun8i: add video engine support for A33 Thomas van Kleef (4): Merged requests2 into linux 4.14 Fix merge error Remove reject file from merge Fix the sun5i and sun8i dts files .../devicetree/bindings/media/sunxi-cedrus.txt

Re: [linux-sunxi] Cedrus driver

2017-11-28 Thread Thomas van Kleef
On 28-11-17 13:26, Maxime Ripard wrote: > On Tue, Nov 28, 2017 at 12:20:59PM +0100, Thomas van Kleef wrote: >>> So, I have been rebasing to 4.14.0 and have the cedrus driver working. >> I have pulled linux-mainline 4.14.0. Then pulled the requests2 branch from >> Hans &g

Re: [linux-sunxi] Cedrus driver

2017-11-28 Thread Thomas van Kleef
On 28-11-17 13:26, Maxime Ripard wrote: > On Tue, Nov 28, 2017 at 12:20:59PM +0100, Thomas van Kleef wrote: >>> So, I have been rebasing to 4.14.0 and have the cedrus driver working. >> I have pulled linux-mainline 4.14.0. Then pulled the requests2 branch from >> Hans &g

Re: [linux-sunxi] Cedrus driver

2017-11-28 Thread Thomas van Kleef
Hi Giulio On 28-11-17 12:54, Giulio Benetti wrote: > Hi Thomas, > > Il 28/11/2017 12:29, Thomas van Kleef ha scritto: >> Hi, >> >> On 28-11-17 12:26, Giulio Benetti wrote: >>> Hi Thomas, >>> >>> Il 28/11/2017 12:20, Thomas van Kleef ha

Re: [linux-sunxi] Cedrus driver

2017-11-28 Thread Thomas van Kleef
Hi Giulio On 28-11-17 12:54, Giulio Benetti wrote: > Hi Thomas, > > Il 28/11/2017 12:29, Thomas van Kleef ha scritto: >> Hi, >> >> On 28-11-17 12:26, Giulio Benetti wrote: >>> Hi Thomas, >>> >>> Il 28/11/2017 12:20, Thomas van Kleef ha

Re: [linux-sunxi] Cedrus driver

2017-11-28 Thread Thomas van Kleef
Hi, On 28-11-17 12:26, Giulio Benetti wrote: > Hi Thomas, > > Il 28/11/2017 12:20, Thomas van Kleef ha scritto: >> On 28-11-17 10:50, Giulio Benetti wrote: >>> Hi Maxime, >>> >>> Il 28/11/2017 09:35, Maxime Ripard ha scritto: >>>> On Tue,

Re: [linux-sunxi] Cedrus driver

2017-11-28 Thread Thomas van Kleef
Hi, On 28-11-17 12:26, Giulio Benetti wrote: > Hi Thomas, > > Il 28/11/2017 12:20, Thomas van Kleef ha scritto: >> On 28-11-17 10:50, Giulio Benetti wrote: >>> Hi Maxime, >>> >>> Il 28/11/2017 09:35, Maxime Ripard ha scritto: >>>> On Tue,

Re: [linux-sunxi] Cedrus driver

2017-11-28 Thread Thomas van Kleef
On 28-11-17 10:50, Giulio Benetti wrote: > Hi Maxime, > > Il 28/11/2017 09:35, Maxime Ripard ha scritto: >> On Tue, Nov 28, 2017 at 01:03:59AM +0100, Giulio Benetti wrote: >>> Hi Maxime, >>> >>> Il 16/11/2017 14:42, Giulio Benetti ha scritto: Hi, Il 16/11/2017 14:39, Maxime Ripard

Re: [linux-sunxi] Cedrus driver

2017-11-28 Thread Thomas van Kleef
On 28-11-17 10:50, Giulio Benetti wrote: > Hi Maxime, > > Il 28/11/2017 09:35, Maxime Ripard ha scritto: >> On Tue, Nov 28, 2017 at 01:03:59AM +0100, Giulio Benetti wrote: >>> Hi Maxime, >>> >>> Il 16/11/2017 14:42, Giulio Benetti ha scritto: Hi, Il 16/11/2017 14:39, Maxime Ripard