Re: [PATCH] mmc: sdhci: Use mmc core regulator infrastucture

2014-05-06 Thread Tim Kryger
On Fri, Apr 25, 2014 at 1:15 AM, Ulf Hansson wrote: > On 25 April 2014 00:36, Tim Kryger wrote: >> Switch the common SDHCI code over to use mmc_host's regulator pointers >> and remove the ones in the sdhci_host structure. Additionally, use the >> common mmc_regulator_get_s

Re: [PATCH v2] mmc: core: Improve support for deferred regulators

2014-05-06 Thread Tim Kryger
On Tue, May 6, 2014 at 3:57 PM, Tim Kryger wrote: > Callers of mmc_regulator_get_supply could benefit from knowing if either > of the regulators are present but not yet available. Since callers do > not currently examine the return value, modify this function to return > zero or -

[PATCH v2] mmc: core: Improve support for deferred regulators

2014-05-06 Thread Tim Kryger
callers check vmmc/vqmmc using IS_ERR and can deal with absent regulators, switch to devm_regulator_get_optional. This has the added benefit of allowing this function to behave correctly even in the !CONFIG_REGULATOR case such that the stub can be removed. Signed-off-by: Tim Kryger --- drivers

[PATCH v2] mmc: core: Improve support for deferred regulators

2014-05-06 Thread Tim Kryger
callers check vmmc/vqmmc using IS_ERR and can deal with absent regulators, switch to devm_regulator_get_optional. This has the added benefit of allowing this function to behave correctly even in the !CONFIG_REGULATOR case such that the stub can be removed. Signed-off-by: Tim Kryger tim.kry

Re: [PATCH v2] mmc: core: Improve support for deferred regulators

2014-05-06 Thread Tim Kryger
On Tue, May 6, 2014 at 3:57 PM, Tim Kryger tim.kry...@linaro.org wrote: Callers of mmc_regulator_get_supply could benefit from knowing if either of the regulators are present but not yet available. Since callers do not currently examine the return value, modify this function to return zero

Re: [PATCH] mmc: sdhci: Use mmc core regulator infrastucture

2014-05-06 Thread Tim Kryger
On Fri, Apr 25, 2014 at 1:15 AM, Ulf Hansson ulf.hans...@linaro.org wrote: On 25 April 2014 00:36, Tim Kryger tim.kry...@linaro.org wrote: Switch the common SDHCI code over to use mmc_host's regulator pointers and remove the ones in the sdhci_host structure. Additionally, use the common

Re: [PATCH RESEND] mmc: core: Improve support for deferred regulators

2014-04-29 Thread Tim Kryger
On Fri, Apr 25, 2014 at 2:33 PM, Andrew Bresticker wrote: >> >> - if (IS_ERR(supply)) >> - return PTR_ERR(supply); >> + if (IS_ERR(mmc->supply.vmmc)) { >> + if (PTR_ERR(mmc->supply.vmmc) == -EPROBE_DEFER) >> + return -EPROBE_DEFER; >>

Re: [PATCH RESEND] mmc: core: Improve support for deferred regulators

2014-04-29 Thread Tim Kryger
On Fri, Apr 25, 2014 at 2:33 PM, Andrew Bresticker abres...@chromium.org wrote: - if (IS_ERR(supply)) - return PTR_ERR(supply); + if (IS_ERR(mmc-supply.vmmc)) { + if (PTR_ERR(mmc-supply.vmmc) == -EPROBE_DEFER) + return

Re: [PATCH v6 RESEND 0/5] Add Broadcom Kona PWM Support

2014-04-28 Thread Tim Kryger
On Mon, Apr 28, 2014 at 4:07 AM, Thierry Reding wrote: > On Fri, Apr 25, 2014 at 11:31:10AM -0700, Tim Kryger wrote: >> This series introduces the driver for the Kona PWM controller found in >> Broadcom mobile SoCs like bcm281xx and updates the device tree and the >> de

Re: [PATCH v6 RESEND 0/5] Add Broadcom Kona PWM Support

2014-04-28 Thread Tim Kryger
On Mon, Apr 28, 2014 at 4:07 AM, Thierry Reding thierry.red...@gmail.com wrote: On Fri, Apr 25, 2014 at 11:31:10AM -0700, Tim Kryger wrote: This series introduces the driver for the Kona PWM controller found in Broadcom mobile SoCs like bcm281xx and updates the device tree and the defconfig

[PATCH RESEND] mmc: core: Improve support for deferred regulators

2014-04-25 Thread Tim Kryger
value and may continue to use IS_ERR on the vmmc/vqmmc values to determine if those regulators are available. Furthermore, since all of these callers are capable of dealing with absent regulators, switch over to use the non-optional variety of the regulator get call. Signed-off-by: Tim Kryger

[PATCH v6 RESEND 3/5] ARM: dts: Declare the PWM for bcm11351 (bcm281xx)

2014-04-25 Thread Tim Kryger
Add the device tree node for the PWM on bcm11351 SoCs. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- arch/arm/boot/dts/bcm11351.dtsi |8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351

[PATCH v6 RESEND 4/5] ARM: dts: Enable the PWM for bcm28155 AP board

2014-04-25 Thread Tim Kryger
Mark the PWM as enabled on the bcm28155 AP board. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- arch/arm/boot/dts/bcm28155-ap.dts |4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/bcm28155-ap.dts b/arch/arm/boot/dts/bcm28155-ap.dts

[PATCH v6 RESEND 1/5] Documentation: dt: Add Kona PWM binding

2014-04-25 Thread Tim Kryger
Add the binding description for the Kona PWM controller found on Broadcom's mobile SoCs. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- .../devicetree/bindings/pwm/bcm-kona-pwm.txt | 21 1 file changed, 21 insertions(+) create

[PATCH v6 RESEND 5/5] ARM: bcm_defconfig: Enable PWM and Backlight

2014-04-25 Thread Tim Kryger
Enable PWM drivers and the PWM-based backlight driver. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- arch/arm/configs/bcm_defconfig |3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/configs/bcm_defconfig b/arch/arm/configs/bcm_defconfig index

[PATCH v6 RESEND 2/5] pwm: kona: Introduce Kona PWM controller support

2014-04-25 Thread Tim Kryger
Add support for the six-channel Kona PWM controller found on Broadcom mobile SoCs like bcm281xx. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- drivers/pwm/Kconfig|9 ++ drivers/pwm/Makefile |1 + drivers/pwm/pwm-bcm-kona.c | 319

[PATCH v6 RESEND 0/5] Add Broadcom Kona PWM Support

2014-04-25 Thread Tim Kryger
- Made prescale and duty computation clearer - Moved Makefile addition to keep alphabetical - Split complex lines into multiple steps Tim Kryger (5): Documentation: dt: Add Kona PWM binding pwm: kona: Introduce Kona PWM controller support ARM: dts: Declare the PWM for bcm11351 (bcm281xx

[PATCH v6 RESEND 2/5] pwm: kona: Introduce Kona PWM controller support

2014-04-25 Thread Tim Kryger
Add support for the six-channel Kona PWM controller found on Broadcom mobile SoCs like bcm281xx. Signed-off-by: Tim Kryger tim.kry...@linaro.org Reviewed-by: Alex Elder el...@linaro.org Reviewed-by: Markus Mayer markus.ma...@linaro.org --- drivers/pwm/Kconfig|9 ++ drivers/pwm

[PATCH v6 RESEND 0/5] Add Broadcom Kona PWM Support

2014-04-25 Thread Tim Kryger
- Made prescale and duty computation clearer - Moved Makefile addition to keep alphabetical - Split complex lines into multiple steps Tim Kryger (5): Documentation: dt: Add Kona PWM binding pwm: kona: Introduce Kona PWM controller support ARM: dts: Declare the PWM for bcm11351 (bcm281xx

[PATCH v6 RESEND 5/5] ARM: bcm_defconfig: Enable PWM and Backlight

2014-04-25 Thread Tim Kryger
Enable PWM drivers and the PWM-based backlight driver. Signed-off-by: Tim Kryger tim.kry...@linaro.org Reviewed-by: Alex Elder el...@linaro.org Reviewed-by: Markus Mayer markus.ma...@linaro.org --- arch/arm/configs/bcm_defconfig |3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm

[PATCH v6 RESEND 1/5] Documentation: dt: Add Kona PWM binding

2014-04-25 Thread Tim Kryger
Add the binding description for the Kona PWM controller found on Broadcom's mobile SoCs. Signed-off-by: Tim Kryger tim.kry...@linaro.org Reviewed-by: Alex Elder el...@linaro.org Reviewed-by: Markus Mayer markus.ma...@linaro.org --- .../devicetree/bindings/pwm/bcm-kona-pwm.txt | 21

[PATCH v6 RESEND 4/5] ARM: dts: Enable the PWM for bcm28155 AP board

2014-04-25 Thread Tim Kryger
Mark the PWM as enabled on the bcm28155 AP board. Signed-off-by: Tim Kryger tim.kry...@linaro.org Reviewed-by: Alex Elder el...@linaro.org Reviewed-by: Markus Mayer markus.ma...@linaro.org --- arch/arm/boot/dts/bcm28155-ap.dts |4 1 file changed, 4 insertions(+) diff --git a/arch/arm

[PATCH v6 RESEND 3/5] ARM: dts: Declare the PWM for bcm11351 (bcm281xx)

2014-04-25 Thread Tim Kryger
Add the device tree node for the PWM on bcm11351 SoCs. Signed-off-by: Tim Kryger tim.kry...@linaro.org Reviewed-by: Alex Elder el...@linaro.org Reviewed-by: Markus Mayer markus.ma...@linaro.org --- arch/arm/boot/dts/bcm11351.dtsi |8 1 file changed, 8 insertions(+) diff --git

[PATCH RESEND] mmc: core: Improve support for deferred regulators

2014-04-25 Thread Tim Kryger
value and may continue to use IS_ERR on the vmmc/vqmmc values to determine if those regulators are available. Furthermore, since all of these callers are capable of dealing with absent regulators, switch over to use the non-optional variety of the regulator get call. Signed-off-by: Tim Kryger

[PATCH] mmc: sdhci: Use mmc core regulator infrastucture

2014-04-24 Thread Tim Kryger
ranges supported which ensures ocr_avail is set correctly while allowing the use of regulators that can't provide exactly 1.8v, 3.0v, or 3.3v. Signed-off-by: Tim Kryger --- This patch is the same as the following series only squashed together. https://lkml.org/lkml/2014/4/17/653 drivers/mmc

Re: [PATCH 0/2] SDHCI should use more common MMC structs and functions

2014-04-24 Thread Tim Kryger
On Thu, Apr 24, 2014 at 1:34 AM, Ulf Hansson wrote: > On 18 April 2014 02:46, Tim Kryger wrote: >> This series updates SDHCI to use the common regulator infrastructure that mmc >> core provides. >> >> Tim Kryger (2): >> mmc: sdhci: Use supplies in common mmc

[PATCH v2] mmc: core: Try other signal levels during power up

2014-04-24 Thread Tim Kryger
but when that can't be set, 1.8v and 1.2v signalling also should be attempted. This is especially important when an external regulator with a limited range is used to supply VCCQ to an eMMC part. Signed-off-by: Tim Kryger --- Changes since v1: - Eliminated temporary err variable and added debug

Re: [PATCH] mmc: core: Try other signal levels during power up

2014-04-24 Thread Tim Kryger
On Thu, Apr 24, 2014 at 1:38 AM, Ulf Hansson wrote: > On 18 April 2014 20:58, Tim Kryger wrote: >> void mmc_power_up(struct mmc_host *host, u32 ocr) >> { >> + int err; >> + > > The variable err is not needed, since we don't plan on printing it

Re: [PATCH] mmc: core: Try other signal levels during power up

2014-04-24 Thread Tim Kryger
On Thu, Apr 24, 2014 at 1:38 AM, Ulf Hansson ulf.hans...@linaro.org wrote: On 18 April 2014 20:58, Tim Kryger tim.kry...@linaro.org wrote: void mmc_power_up(struct mmc_host *host, u32 ocr) { + int err; + The variable err is not needed, since we don't plan on printing it nor

[PATCH v2] mmc: core: Try other signal levels during power up

2014-04-24 Thread Tim Kryger
but when that can't be set, 1.8v and 1.2v signalling also should be attempted. This is especially important when an external regulator with a limited range is used to supply VCCQ to an eMMC part. Signed-off-by: Tim Kryger tim.kry...@linaro.org --- Changes since v1: - Eliminated temporary err

Re: [PATCH 0/2] SDHCI should use more common MMC structs and functions

2014-04-24 Thread Tim Kryger
On Thu, Apr 24, 2014 at 1:34 AM, Ulf Hansson ulf.hans...@linaro.org wrote: On 18 April 2014 02:46, Tim Kryger tim.kry...@linaro.org wrote: This series updates SDHCI to use the common regulator infrastructure that mmc core provides. Tim Kryger (2): mmc: sdhci: Use supplies in common

[PATCH] mmc: sdhci: Use mmc core regulator infrastucture

2014-04-24 Thread Tim Kryger
ranges supported which ensures ocr_avail is set correctly while allowing the use of regulators that can't provide exactly 1.8v, 3.0v, or 3.3v. Signed-off-by: Tim Kryger tim.kry...@linaro.org --- This patch is the same as the following series only squashed together. https://lkml.org/lkml/2014/4/17

Re: [PATCH] regulator: Allow set voltage on fixed regulators

2014-04-22 Thread Tim Kryger
On Fri, Apr 18, 2014 at 11:52 AM, Mark Brown wrote: > On Fri, Apr 18, 2014 at 11:30:10AM -0700, Tim Kryger wrote: >> If a regulator consumer requests a voltage range that can be satisfied, >> the return value should indicate success even if that regulator has a >>

Re: [PATCH] regulator: Allow set voltage on fixed regulators

2014-04-22 Thread Tim Kryger
On Fri, Apr 18, 2014 at 11:52 AM, Mark Brown broo...@kernel.org wrote: On Fri, Apr 18, 2014 at 11:30:10AM -0700, Tim Kryger wrote: If a regulator consumer requests a voltage range that can be satisfied, the return value should indicate success even if that regulator has a fixed voltage. Since

Re: [PATCH] mmc: sdhci: Set ocr_avail directly based on vmmc

2014-04-18 Thread Tim Kryger
On Wed, Apr 16, 2014 at 12:20 AM, Ulf Hansson wrote: > On 15 April 2014 19:09, Tim Kryger wrote: >> On Fri, Apr 11, 2014 at 1:15 AM, Ulf Hansson wrote: >>> A few times I have suggested to switch to use the >>> mmc_regulator_get_supply() API to simplify and cons

Re: [PATCH] regulator: Allow set voltage on fixed regulators

2014-04-18 Thread Tim Kryger
On Fri, Apr 18, 2014 at 11:52 AM, Mark Brown wrote: > On Fri, Apr 18, 2014 at 11:30:10AM -0700, Tim Kryger wrote: >> If a regulator consumer requests a voltage range that can be satisfied, >> the return value should indicate success even if that regulator has a >>

[PATCH] mmc: core: Try other signal levels during power up

2014-04-18 Thread Tim Kryger
but when that can't be set, 1.8v and 1.2v signalling also should be attempted. This is especially important when an external regulator with a limited range is used to supply VCCQ to an eMMC part. Signed-off-by: Tim Kryger --- drivers/mmc/core/core.c | 10 +- 1 file changed, 9 insertions

[PATCH] regulator: Allow set voltage on fixed regulators

2014-04-18 Thread Tim Kryger
with constraints that include a positive voltage. Signed-off-by: Tim Kryger --- drivers/regulator/of_regulator.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/of_regulator.c b/drivers/regulator/of_regulator.c index ea4f36f..a205d62 100644 --- a/drivers

[PATCH v6 0/5] Add Broadcom Kona PWM Support

2014-04-18 Thread Tim Kryger
- Made prescale and duty computation clearer - Moved Makefile addition to keep alphabetical - Split complex lines into multiple steps Tim Kryger (5): Documentation: dt: Add Kona PWM binding pwm: kona: Introduce Kona PWM controller support ARM: dts: Declare the PWM for bcm11351 (bcm281xx

[PATCH v6 2/5] pwm: kona: Introduce Kona PWM controller support

2014-04-18 Thread Tim Kryger
Add support for the six-channel Kona PWM controller found on Broadcom mobile SoCs like bcm281xx. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- drivers/pwm/Kconfig|9 ++ drivers/pwm/Makefile |1 + drivers/pwm/pwm-bcm-kona.c | 319

[PATCH v6 5/5] ARM: bcm_defconfig: Enable PWM and Backlight

2014-04-18 Thread Tim Kryger
Enable PWM drivers and the PWM-based backlight driver. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- arch/arm/configs/bcm_defconfig |3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/configs/bcm_defconfig b/arch/arm/configs/bcm_defconfig index

[PATCH v6 1/5] Documentation: dt: Add Kona PWM binding

2014-04-18 Thread Tim Kryger
Add the binding description for the Kona PWM controller found on Broadcom's mobile SoCs. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- .../devicetree/bindings/pwm/bcm-kona-pwm.txt | 21 1 file changed, 21 insertions(+) create

[PATCH v6 3/5] ARM: dts: Declare the PWM for bcm11351 (bcm281xx)

2014-04-18 Thread Tim Kryger
Add the device tree node for the PWM on bcm11351 SoCs. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- arch/arm/boot/dts/bcm11351.dtsi |8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351

[PATCH v6 4/5] ARM: dts: Enable the PWM for bcm28155 AP board

2014-04-18 Thread Tim Kryger
Mark the PWM as enabled on the bcm28155 AP board. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- arch/arm/boot/dts/bcm28155-ap.dts |4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/bcm28155-ap.dts b/arch/arm/boot/dts/bcm28155-ap.dts

[PATCH v6 4/5] ARM: dts: Enable the PWM for bcm28155 AP board

2014-04-18 Thread Tim Kryger
Mark the PWM as enabled on the bcm28155 AP board. Signed-off-by: Tim Kryger tim.kry...@linaro.org Reviewed-by: Alex Elder el...@linaro.org Reviewed-by: Markus Mayer markus.ma...@linaro.org --- arch/arm/boot/dts/bcm28155-ap.dts |4 1 file changed, 4 insertions(+) diff --git a/arch/arm

[PATCH v6 3/5] ARM: dts: Declare the PWM for bcm11351 (bcm281xx)

2014-04-18 Thread Tim Kryger
Add the device tree node for the PWM on bcm11351 SoCs. Signed-off-by: Tim Kryger tim.kry...@linaro.org Reviewed-by: Alex Elder el...@linaro.org Reviewed-by: Markus Mayer markus.ma...@linaro.org --- arch/arm/boot/dts/bcm11351.dtsi |8 1 file changed, 8 insertions(+) diff --git

[PATCH v6 1/5] Documentation: dt: Add Kona PWM binding

2014-04-18 Thread Tim Kryger
Add the binding description for the Kona PWM controller found on Broadcom's mobile SoCs. Signed-off-by: Tim Kryger tim.kry...@linaro.org Reviewed-by: Alex Elder el...@linaro.org Reviewed-by: Markus Mayer markus.ma...@linaro.org --- .../devicetree/bindings/pwm/bcm-kona-pwm.txt | 21

[PATCH v6 5/5] ARM: bcm_defconfig: Enable PWM and Backlight

2014-04-18 Thread Tim Kryger
Enable PWM drivers and the PWM-based backlight driver. Signed-off-by: Tim Kryger tim.kry...@linaro.org Reviewed-by: Alex Elder el...@linaro.org Reviewed-by: Markus Mayer markus.ma...@linaro.org --- arch/arm/configs/bcm_defconfig |3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm

[PATCH v6 2/5] pwm: kona: Introduce Kona PWM controller support

2014-04-18 Thread Tim Kryger
Add support for the six-channel Kona PWM controller found on Broadcom mobile SoCs like bcm281xx. Signed-off-by: Tim Kryger tim.kry...@linaro.org Reviewed-by: Alex Elder el...@linaro.org Reviewed-by: Markus Mayer markus.ma...@linaro.org --- drivers/pwm/Kconfig|9 ++ drivers/pwm

[PATCH v6 0/5] Add Broadcom Kona PWM Support

2014-04-18 Thread Tim Kryger
- Made prescale and duty computation clearer - Moved Makefile addition to keep alphabetical - Split complex lines into multiple steps Tim Kryger (5): Documentation: dt: Add Kona PWM binding pwm: kona: Introduce Kona PWM controller support ARM: dts: Declare the PWM for bcm11351 (bcm281xx

[PATCH] regulator: Allow set voltage on fixed regulators

2014-04-18 Thread Tim Kryger
with constraints that include a positive voltage. Signed-off-by: Tim Kryger tim.kry...@linaro.org --- drivers/regulator/of_regulator.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/of_regulator.c b/drivers/regulator/of_regulator.c index ea4f36f..a205d62

[PATCH] mmc: core: Try other signal levels during power up

2014-04-18 Thread Tim Kryger
but when that can't be set, 1.8v and 1.2v signalling also should be attempted. This is especially important when an external regulator with a limited range is used to supply VCCQ to an eMMC part. Signed-off-by: Tim Kryger tim.kry...@linaro.org --- drivers/mmc/core/core.c | 10 +- 1 file

Re: [PATCH] regulator: Allow set voltage on fixed regulators

2014-04-18 Thread Tim Kryger
On Fri, Apr 18, 2014 at 11:52 AM, Mark Brown broo...@kernel.org wrote: On Fri, Apr 18, 2014 at 11:30:10AM -0700, Tim Kryger wrote: If a regulator consumer requests a voltage range that can be satisfied, the return value should indicate success even if that regulator has a fixed voltage. Since

Re: [PATCH] mmc: sdhci: Set ocr_avail directly based on vmmc

2014-04-18 Thread Tim Kryger
On Wed, Apr 16, 2014 at 12:20 AM, Ulf Hansson ulf.hans...@linaro.org wrote: On 15 April 2014 19:09, Tim Kryger tim.kry...@linaro.org wrote: On Fri, Apr 11, 2014 at 1:15 AM, Ulf Hansson ulf.hans...@linaro.org wrote: A few times I have suggested to switch to use the mmc_regulator_get_supply

[PATCH 1/2] mmc: sdhci: Use supplies in common mmc_host struct

2014-04-17 Thread Tim Kryger
Switch the common SDHCI code over to use mmc_host's regulator pointers and remove the ones in the sdhci_host structure. Signed-off-by: Tim Kryger --- drivers/mmc/host/sdhci.c | 71 - include/linux/mmc/sdhci.h |3 -- 2 files changed, 38

[PATCH 0/2] SDHCI should use more common MMC structs and functions

2014-04-17 Thread Tim Kryger
This series updates SDHCI to use the common regulator infrastructure that mmc core provides. Tim Kryger (2): mmc: sdhci: Use supplies in common mmc_host struct mmc: sdhci: Use common mmc_regulator_get_supply drivers/mmc/host/sdhci.c | 96

[PATCH 2/2] mmc: sdhci: Use common mmc_regulator_get_supply

2014-04-17 Thread Tim Kryger
this by relaxing the range checks in the SDHCI driver but it set the capabilities as an intermediate step which meant ocr_avail could get bits set for unsupported voltages. Signed-off-by: Tim Kryger --- drivers/mmc/host/sdhci.c | 67 +- 1 file changed

[PATCH] mmc: core: Improve support for deferred regulators

2014-04-17 Thread Tim Kryger
value and may continue to use IS_ERR on the vmmc/vqmmc values to determine if those regulators are available. Furthermore, since all of these callers are capable of dealing with absent regulators, switch over to use the non-optional variety of the regulator get call. Signed-off-by: Tim Kryger

[PATCH] regulator: core: Return error in get optional stub

2014-04-17 Thread Tim Kryger
regulator_is_supported_voltage. This improves efficiency as well as eliminates the possibility for a very subtle bug. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder --- This change was proposed here: https://lkml.org/lkml/2014/4/16/627 include/linux/regulator/consumer.h |4 ++-- 1 file

[PATCH] regulator: core: Return error in get optional stub

2014-04-17 Thread Tim Kryger
regulator_is_supported_voltage. This improves efficiency as well as eliminates the possibility for a very subtle bug. Signed-off-by: Tim Kryger tim.kry...@linaro.org Reviewed-by: Alex Elder el...@linaro.org --- This change was proposed here: https://lkml.org/lkml/2014/4/16/627 include/linux

[PATCH] mmc: core: Improve support for deferred regulators

2014-04-17 Thread Tim Kryger
value and may continue to use IS_ERR on the vmmc/vqmmc values to determine if those regulators are available. Furthermore, since all of these callers are capable of dealing with absent regulators, switch over to use the non-optional variety of the regulator get call. Signed-off-by: Tim Kryger

[PATCH 2/2] mmc: sdhci: Use common mmc_regulator_get_supply

2014-04-17 Thread Tim Kryger
this by relaxing the range checks in the SDHCI driver but it set the capabilities as an intermediate step which meant ocr_avail could get bits set for unsupported voltages. Signed-off-by: Tim Kryger tim.kry...@linaro.org --- drivers/mmc/host/sdhci.c | 67

[PATCH 0/2] SDHCI should use more common MMC structs and functions

2014-04-17 Thread Tim Kryger
This series updates SDHCI to use the common regulator infrastructure that mmc core provides. Tim Kryger (2): mmc: sdhci: Use supplies in common mmc_host struct mmc: sdhci: Use common mmc_regulator_get_supply drivers/mmc/host/sdhci.c | 96

[PATCH 1/2] mmc: sdhci: Use supplies in common mmc_host struct

2014-04-17 Thread Tim Kryger
Switch the common SDHCI code over to use mmc_host's regulator pointers and remove the ones in the sdhci_host structure. Signed-off-by: Tim Kryger tim.kry...@linaro.org --- drivers/mmc/host/sdhci.c | 71 - include/linux/mmc/sdhci.h |3 -- 2 files

Re: [PATCH 3/4] mmc: sdhci: defer probing on regulator_get_optional() failures

2014-04-15 Thread Tim Kryger
On Mon, Apr 14, 2014 at 6:42 PM, Andrew Bresticker wrote: > If regulator_get_optional() returns EPROBE_DEFER, it indicates > that the regulator may show up later (e.g. the DT property is > present but the corresponding regulator may not have probed). > Instead of continuing without the regulator,

Re: [PATCH] mmc: sdhci: Set ocr_avail directly based on vmmc

2014-04-15 Thread Tim Kryger
On Fri, Apr 11, 2014 at 1:15 AM, Ulf Hansson wrote: > I have seen some patches around lately touching the code for handling > the regulators (vcc and vccq) in sdhci. Was it this patch you were thinking of or something else? http://www.spinics.net/lists/linux-mmc/msg25640.html > A few times I

Re: [PATCH] mmc: sdhci: Set ocr_avail directly based on vmmc

2014-04-15 Thread Tim Kryger
On Fri, Apr 11, 2014 at 1:15 AM, Ulf Hansson ulf.hans...@linaro.org wrote: I have seen some patches around lately touching the code for handling the regulators (vcc and vccq) in sdhci. Was it this patch you were thinking of or something else?

Re: [PATCH 3/4] mmc: sdhci: defer probing on regulator_get_optional() failures

2014-04-15 Thread Tim Kryger
On Mon, Apr 14, 2014 at 6:42 PM, Andrew Bresticker abres...@chromium.org wrote: If regulator_get_optional() returns EPROBE_DEFER, it indicates that the regulator may show up later (e.g. the DT property is present but the corresponding regulator may not have probed). Instead of continuing

Re: [PATCH] mmc: sdhci: Set ocr_avail directly based on vmmc

2014-04-11 Thread Tim Kryger
On Fri, Apr 11, 2014 at 1:15 AM, Ulf Hansson wrote: > On 11 April 2014 01:31, Tim Kryger wrote: >> +static unsigned int sdhci_get_ocr_avail_from_vmmc(struct sdhci_host *host) >> +{ >> + unsigned int ocr_avail = 0; >> + struct r

Re: [PATCH] mmc: sdhci: Set ocr_avail directly based on vmmc

2014-04-11 Thread Tim Kryger
On Fri, Apr 11, 2014 at 1:15 AM, Ulf Hansson ulf.hans...@linaro.org wrote: On 11 April 2014 01:31, Tim Kryger tim.kry...@linaro.org wrote: +static unsigned int sdhci_get_ocr_avail_from_vmmc(struct sdhci_host *host) +{ + unsigned int ocr_avail = 0; + struct regulator *vmmc = host

[PATCH] gpio: bcm-kona: Add irq_set_wake method

2014-04-10 Thread Tim Kryger
If a consumer of a GPIO-based IRQ identifies itself as wanting to have the capability to wake up the system through that interrupt, update the flags to keep that interrupt enabled in suspend. Signed-off-by: Tim Kryger --- drivers/gpio/gpio-bcm-kona.c | 19 +++ 1 file changed

[PATCH] mmc: sdhci: Set ocr_avail directly based on vmmc

2014-04-10 Thread Tim Kryger
to relax the range checks but because it relied on setting capabilities as an intermediate step, ocr_avail could easily get a bit set that the host couldn't support. Signed-off-by: Tim Kryger --- drivers/mmc/host/sdhci.c | 107 +- 1 file changed, 58

[PATCH] regulator: bcm590xx: Set n_voltages for linear reg

2014-04-10 Thread Tim Kryger
Fix the macro used to define linear range regulators to include the number of voltages. Signed-off-by: Tim Kryger --- drivers/regulator/bcm590xx-regulator.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/regulator/bcm590xx-regulator.c b/drivers/regulator/bcm590xx-regulator.c

[PATCH] regulator: bcm590xx: Set n_voltages for linear reg

2014-04-10 Thread Tim Kryger
Fix the macro used to define linear range regulators to include the number of voltages. Signed-off-by: Tim Kryger tim.kry...@linaro.org --- drivers/regulator/bcm590xx-regulator.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/regulator/bcm590xx-regulator.c b/drivers/regulator

[PATCH] mmc: sdhci: Set ocr_avail directly based on vmmc

2014-04-10 Thread Tim Kryger
to relax the range checks but because it relied on setting capabilities as an intermediate step, ocr_avail could easily get a bit set that the host couldn't support. Signed-off-by: Tim Kryger tim.kry...@linaro.org --- drivers/mmc/host/sdhci.c | 107 +- 1 file

[PATCH] gpio: bcm-kona: Add irq_set_wake method

2014-04-10 Thread Tim Kryger
If a consumer of a GPIO-based IRQ identifies itself as wanting to have the capability to wake up the system through that interrupt, update the flags to keep that interrupt enabled in suspend. Signed-off-by: Tim Kryger tim.kry...@linaro.org --- drivers/gpio/gpio-bcm-kona.c | 19

[RESEND PATCH v5 0/5] Add Broadcom Kona PWM Support

2014-04-09 Thread Tim Kryger
l.org/lkml/2014/2/14/451 Tim Kryger (5): Documentation: dt: Add Kona PWM binding pwm: kona: Introduce Kona PWM controller support ARM: dts: Declare the PWM for bcm11351 (bcm281xx) ARM: dts: Enable the PWM for bcm28155 AP board ARM: bcm_defconfig: Enable PWM and Backlight .../devicet

[RESEND PATCH v5 3/5] ARM: dts: Declare the PWM for bcm11351 (bcm281xx)

2014-04-09 Thread Tim Kryger
Add the device tree node for the PWM on bcm11351 SoCs. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- arch/arm/boot/dts/bcm11351.dtsi |8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351

[RESEND PATCH v5 1/5] Documentation: dt: Add Kona PWM binding

2014-04-09 Thread Tim Kryger
Add the binding description for the Kona PWM controller found on Broadcom's mobile SoCs. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- .../devicetree/bindings/pwm/bcm-kona-pwm.txt | 21 1 file changed, 21 insertions(+) create

[RESEND PATCH v5 4/5] ARM: dts: Enable the PWM for bcm28155 AP board

2014-04-09 Thread Tim Kryger
Mark the PWM as enabled on the bcm28155 AP board. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- arch/arm/boot/dts/bcm28155-ap.dts |4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/bcm28155-ap.dts b/arch/arm/boot/dts/bcm28155-ap.dts

[RESEND PATCH v5 5/5] ARM: bcm_defconfig: Enable PWM and Backlight

2014-04-09 Thread Tim Kryger
Enable PWM drivers and the PWM-based backlight driver. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- arch/arm/configs/bcm_defconfig |3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/configs/bcm_defconfig b/arch/arm/configs/bcm_defconfig index

[RESEND PATCH v5 2/5] pwm: kona: Introduce Kona PWM controller support

2014-04-09 Thread Tim Kryger
Add support for the six-channel Kona PWM controller found on Broadcom mobile SoCs like bcm281xx. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- drivers/pwm/Kconfig|9 ++ drivers/pwm/Makefile |1 + drivers/pwm/pwm-bcm-kona.c | 319

Re: [rfc]pwm: add BCM2835 PWM driver

2014-04-09 Thread Tim Kryger
On Tue, Apr 8, 2014 at 6:27 PM, Stephen Warren wrote: > On 04/08/2014 05:02 PM, Tim Kryger wrote: >> On Thu, Apr 3, 2014 at 6:44 AM, Bart Tanghe >> wrote: >>> need some recommendation >>> the memory mapped io registers of the bcm2835 pwm hardware are sprea

Re: [rfc]pwm: add BCM2835 PWM driver

2014-04-09 Thread Tim Kryger
On Tue, Apr 8, 2014 at 6:27 PM, Stephen Warren swar...@wwwdotorg.org wrote: On 04/08/2014 05:02 PM, Tim Kryger wrote: On Thu, Apr 3, 2014 at 6:44 AM, Bart Tanghe bart.tan...@thomasmore.be wrote: need some recommendation the memory mapped io registers of the bcm2835 pwm hardware are spreaded

[RESEND PATCH v5 2/5] pwm: kona: Introduce Kona PWM controller support

2014-04-09 Thread Tim Kryger
Add support for the six-channel Kona PWM controller found on Broadcom mobile SoCs like bcm281xx. Signed-off-by: Tim Kryger tim.kry...@linaro.org Reviewed-by: Alex Elder el...@linaro.org Reviewed-by: Markus Mayer markus.ma...@linaro.org --- drivers/pwm/Kconfig|9 ++ drivers/pwm

[RESEND PATCH v5 5/5] ARM: bcm_defconfig: Enable PWM and Backlight

2014-04-09 Thread Tim Kryger
Enable PWM drivers and the PWM-based backlight driver. Signed-off-by: Tim Kryger tim.kry...@linaro.org Reviewed-by: Alex Elder el...@linaro.org Reviewed-by: Markus Mayer markus.ma...@linaro.org --- arch/arm/configs/bcm_defconfig |3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm

[RESEND PATCH v5 4/5] ARM: dts: Enable the PWM for bcm28155 AP board

2014-04-09 Thread Tim Kryger
Mark the PWM as enabled on the bcm28155 AP board. Signed-off-by: Tim Kryger tim.kry...@linaro.org Reviewed-by: Alex Elder el...@linaro.org Reviewed-by: Markus Mayer markus.ma...@linaro.org --- arch/arm/boot/dts/bcm28155-ap.dts |4 1 file changed, 4 insertions(+) diff --git a/arch/arm

[RESEND PATCH v5 1/5] Documentation: dt: Add Kona PWM binding

2014-04-09 Thread Tim Kryger
Add the binding description for the Kona PWM controller found on Broadcom's mobile SoCs. Signed-off-by: Tim Kryger tim.kry...@linaro.org Reviewed-by: Alex Elder el...@linaro.org Reviewed-by: Markus Mayer markus.ma...@linaro.org --- .../devicetree/bindings/pwm/bcm-kona-pwm.txt | 21

[RESEND PATCH v5 0/5] Add Broadcom Kona PWM Support

2014-04-09 Thread Tim Kryger
Tim Kryger (5): Documentation: dt: Add Kona PWM binding pwm: kona: Introduce Kona PWM controller support ARM: dts: Declare the PWM for bcm11351 (bcm281xx) ARM: dts: Enable the PWM for bcm28155 AP board ARM: bcm_defconfig: Enable PWM and Backlight .../devicetree/bindings/pwm/bcm-kona

[RESEND PATCH v5 3/5] ARM: dts: Declare the PWM for bcm11351 (bcm281xx)

2014-04-09 Thread Tim Kryger
Add the device tree node for the PWM on bcm11351 SoCs. Signed-off-by: Tim Kryger tim.kry...@linaro.org Reviewed-by: Alex Elder el...@linaro.org Reviewed-by: Markus Mayer markus.ma...@linaro.org --- arch/arm/boot/dts/bcm11351.dtsi |8 1 file changed, 8 insertions(+) diff --git

Re: [rfc]pwm: add BCM2835 PWM driver

2014-04-08 Thread Tim Kryger
On Thu, Apr 3, 2014 at 6:44 AM, Bart Tanghe wrote: > need some recommendation > the memory mapped io registers of the bcm2835 pwm hardware are spreaded > over the memory mapped io > gpio config 0x2024 - clk config 0x201010A0 - pwm configuration 0x2020C000 > to handle this, I've used the base

Re: [PATCHv3 1/3] pwm: make the PWM_POLARITY flag in DTB optional

2014-04-08 Thread Tim Kryger
On Mon, Apr 7, 2014 at 10:02 PM, Lothar Waßmann wrote: > Thierry Reding wrote: >> No. You cannot emulate polarity inversion in software. >> > Why not? > > duty_ns = period_ns - duty_ns; Since I made the same mistake, I will pass along the pointer Thierry gave me. In include/linux/pwm.h the

Re: [PATCHv3 1/3] pwm: make the PWM_POLARITY flag in DTB optional

2014-04-08 Thread Tim Kryger
On Mon, Apr 7, 2014 at 10:02 PM, Lothar Waßmann l...@karo-electronics.de wrote: Thierry Reding wrote: No. You cannot emulate polarity inversion in software. Why not? duty_ns = period_ns - duty_ns; Since I made the same mistake, I will pass along the pointer Thierry gave me. In

Re: [rfc]pwm: add BCM2835 PWM driver

2014-04-08 Thread Tim Kryger
On Thu, Apr 3, 2014 at 6:44 AM, Bart Tanghe bart.tan...@thomasmore.be wrote: need some recommendation the memory mapped io registers of the bcm2835 pwm hardware are spreaded over the memory mapped io gpio config 0x2024 - clk config 0x201010A0 - pwm configuration 0x2020C000 to handle this,

Re: [PATCH 2/5] ARM: add SMP support for Broadcom mobile SoCs

2014-04-04 Thread Tim Kryger
On Thu, Apr 3, 2014 at 7:18 PM, Alex Elder wrote: > diff --git a/arch/arm/mach-bcm/platsmp.c b/arch/arm/mach-bcm/platsmp.c > new file mode 100644 > index 000..46a64f2 > --- /dev/null > +++ b/arch/arm/mach-bcm/platsmp.c > +/* Size of mapped Cortex A9 SCU address space */ > +#define SCU_SIZE

Re: [PATCH 2/5] ARM: add SMP support for Broadcom mobile SoCs

2014-04-04 Thread Tim Kryger
On Thu, Apr 3, 2014 at 7:18 PM, Alex Elder el...@linaro.org wrote: diff --git a/arch/arm/mach-bcm/platsmp.c b/arch/arm/mach-bcm/platsmp.c new file mode 100644 index 000..46a64f2 --- /dev/null +++ b/arch/arm/mach-bcm/platsmp.c +/* Size of mapped Cortex A9 SCU address space */ +#define

[RESEND PATCH v5 4/5] ARM: dts: Enable the PWM for bcm28155 AP board

2014-04-02 Thread Tim Kryger
Mark the PWM as enabled on the bcm28155 AP board. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- arch/arm/boot/dts/bcm28155-ap.dts |4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/bcm28155-ap.dts b/arch/arm/boot/dts/bcm28155-ap.dts

[RESEND PATCH v5 1/5] Documentation: dt: Add Kona PWM binding

2014-04-02 Thread Tim Kryger
Add the binding description for the Kona PWM controller found on Broadcom's mobile SoCs. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- .../devicetree/bindings/pwm/bcm-kona-pwm.txt | 21 1 file changed, 21 insertions(+) create

[RESEND PATCH v5 5/5] ARM: bcm_defconfig: Enable PWM and Backlight

2014-04-02 Thread Tim Kryger
Enable PWM drivers and the PWM-based backlight driver. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- arch/arm/configs/bcm_defconfig |3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/configs/bcm_defconfig b/arch/arm/configs/bcm_defconfig index

[RESEND PATCH v5 3/5] ARM: dts: Declare the PWM for bcm11351 (bcm281xx)

2014-04-02 Thread Tim Kryger
Add the device tree node for the PWM on bcm11351 SoCs. Signed-off-by: Tim Kryger Reviewed-by: Alex Elder Reviewed-by: Markus Mayer --- arch/arm/boot/dts/bcm11351.dtsi |8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351

<    1   2   3   4   5   >