Re: [PATCH] serial: altera-uart: fix NULL device in log message

2014-12-16 Thread Tobias Klauser
at MMIO 0x2020 (irq = 6, base_baud = 3125000) > is a Altera UART" > > Signed-off-by: Ley Foon Tan Acked-by: Tobias Klauser -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at ht

Re: [PATCH] serial: altera-juart: fix NULL device in log message

2014-12-16 Thread Tobias Klauser
ttyJ0 at MMIO 0x1008 (irq = 2, base_baud = 0) > is a > Altera JTAG UART" > > Signed-off-by: Ley Foon Tan Acked-by: Tobias Klauser -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH] serial: altera-juart: fix NULL device in log message

2014-12-16 Thread Tobias Klauser
) is a Altera JTAG UART Signed-off-by: Ley Foon Tan lf...@altera.com Acked-by: Tobias Klauser tklau...@distanz.ch -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH] serial: altera-uart: fix NULL device in log message

2014-12-16 Thread Tobias Klauser
) is a Altera UART Signed-off-by: Ley Foon Tan lf...@altera.com Acked-by: Tobias Klauser tklau...@distanz.ch -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH] drivers: Kconfig: Remove duplicate sourcing of soc folder

2014-12-08 Thread Tobias Klauser
On 2014-12-08 at 14:36:24 +0100, Pramod Gurav wrote: > Folder soc/ was sourced twice somehow. Remove duplicate entry. I already sent a patch for this a while ago [1], though it wasn't applied yet. [1] http://thread.gmane.org/gmane.linux.kernel/1831623 -- To unsubscribe from this list: send the

Re: [PATCH] drivers: Kconfig: Remove duplicate sourcing of soc folder

2014-12-08 Thread Tobias Klauser
On 2014-12-08 at 14:36:24 +0100, Pramod Gurav pramod.gu...@smartplayin.com wrote: Folder soc/ was sourced twice somehow. Remove duplicate entry. I already sent a patch for this a while ago [1], though it wasn't applied yet. [1] http://thread.gmane.org/gmane.linux.kernel/1831623 -- To

Re: [PATCH v3 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2014-11-26 Thread Tobias Klauser
On 2014-11-25 at 13:16:58 +0100, Chunyan Zhang wrote: > Add a full sc9836-uart driver for SC9836 SoC which is based on the > spreadtrum sharkl64 platform. > This driver also support earlycon. > > Signed-off-by: Chunyan Zhang > Signed-off-by: Orson Zhai > Originally-by: Lanqing Liu > --- >

Re: [PATCH v3 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2014-11-26 Thread Tobias Klauser
On 2014-11-25 at 13:16:58 +0100, Chunyan Zhang chunyan.zh...@spreadtrum.com wrote: Add a full sc9836-uart driver for SC9836 SoC which is based on the spreadtrum sharkl64 platform. This driver also support earlycon. Signed-off-by: Chunyan Zhang chunyan.zh...@spreadtrum.com Signed-off-by:

[PATCH] drivers: Remove duplicate include of SOC driver configuration

2014-11-18 Thread Tobias Klauser
eg Kroah-Hartman Cc: Santosh Shilimkar Cc: Sandeep Nair Signed-off-by: Tobias Klauser --- drivers/Kconfig | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/Kconfig b/drivers/Kconfig index 1a693d3..622fa26 100644 --- a/drivers/Kconfig +++ b/drivers/Kconfig @@ -148,8 +148,6 @@ source "d

[PATCH] drivers: Remove duplicate include of SOC driver configuration

2014-11-18 Thread Tobias Klauser
...@linuxfoundation.org Cc: Santosh Shilimkar santosh.shilim...@ti.com Cc: Sandeep Nair sandee...@ti.com Signed-off-by: Tobias Klauser tklau...@distanz.ch --- drivers/Kconfig | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/Kconfig b/drivers/Kconfig index 1a693d3..622fa26 100644 --- a/drivers

Re: [PATCH] nios2: fix error handling of irq_of_parse_and_map

2014-11-17 Thread Tobias Klauser
On 2014-11-14 at 23:04:19 +0100, Dmitry Torokhov wrote: > Return value of irq_of_parse_and_map() is unsigned int, with 0 > indicating failure, so testing for negative result never works. > > Signed-off-by: Dmitry Torokhov Reviewed-by: Tobias Klauser Thanks

Re: [PATCH] nios2: fix error handling of irq_of_parse_and_map

2014-11-17 Thread Tobias Klauser
On 2014-11-14 at 23:04:19 +0100, Dmitry Torokhov d...@chromium.org wrote: Return value of irq_of_parse_and_map() is unsigned int, with 0 indicating failure, so testing for negative result never works. Signed-off-by: Dmitry Torokhov d...@chromium.org Reviewed-by: Tobias Klauser tklau

Re: [PATCH 05/10] added media specific (MS) TCP drivers

2014-11-04 Thread Tobias Klauser
On 2014-11-03 at 21:42:52 +0100, Stephanie Wallick wrote: > This is where we handle media specific packets and transport. The MS driver > interfaces with a media agnostic (MA) driver via a series of transfer pairs. > Transfer pairs consist of a set of functions to pass MA USB packets back > and

Re: [PATCH 05/10] added media specific (MS) TCP drivers

2014-11-04 Thread Tobias Klauser
On 2014-11-03 at 21:42:52 +0100, Stephanie Wallick stephanie.s.wall...@intel.com wrote: This is where we handle media specific packets and transport. The MS driver interfaces with a media agnostic (MA) driver via a series of transfer pairs. Transfer pairs consist of a set of functions to pass

Re: [PATCH v4 17/29] nios2: System calls handling

2014-10-09 Thread Tobias Klauser
On 2014-10-08 at 11:29:43 +0200, Ley Foon Tan wrote: > This patch adds support for system calls from userspaces. It uses the > asm-generic/unistd.h definitions with architecture spcific syscall. The > sys_call_table > is just an array defined in a C file and it contains pointers to the syscall

Re: [PATCH v4 17/29] nios2: System calls handling

2014-10-09 Thread Tobias Klauser
On 2014-10-08 at 11:29:43 +0200, Ley Foon Tan lf...@altera.com wrote: This patch adds support for system calls from userspaces. It uses the asm-generic/unistd.h definitions with architecture spcific syscall. The sys_call_table is just an array defined in a C file and it contains pointers to

Re: [PATCH] Input: opencores-kbd: Switch to using managed resources

2014-10-08 Thread Tobias Klauser
On 2014-10-07 at 18:17:16 +0200, Dmitry Torokhov wrote: > On Tue, Oct 07, 2014 at 03:33:22PM +0200, Tobias Klauser wrote: > > On 2014-10-07 at 13:31:41 +0200, Pramod Gurav > > wrote: > > > This change switch to managed resources to simplifies error handling > > &

Re: [PATCH] Input: opencores-kbd: Switch to using managed resources

2014-10-08 Thread Tobias Klauser
On 2014-10-07 at 18:17:16 +0200, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Tue, Oct 07, 2014 at 03:33:22PM +0200, Tobias Klauser wrote: On 2014-10-07 at 13:31:41 +0200, Pramod Gurav pramod.gu...@smartplayin.com wrote: This change switch to managed resources to simplifies error

Re: [PATCH] Input: opencores-kbd: Switch to using managed resources

2014-10-07 Thread Tobias Klauser
On 2014-10-07 at 13:31:41 +0200, Pramod Gurav wrote: > This change switch to managed resources to simplifies error handling > and module unloading and does away with platform_driver remove function. > > Cc: Dmitry Torokhov > Cc: linux-in...@vger.kernel.org > Signed-off-by: Pramod Gurav > ---

Re: [PATCH] Input: opencores-kbd: Switch to using managed resources

2014-10-07 Thread Tobias Klauser
On 2014-10-07 at 13:31:41 +0200, Pramod Gurav pramod.gu...@smartplayin.com wrote: This change switch to managed resources to simplifies error handling and module unloading and does away with platform_driver remove function. Cc: Dmitry Torokhov dmitry.torok...@gmail.com Cc:

Re: [PATCH net-next] et131x: Add PCIe gigabit ethernet driver et131x to drivers/net

2014-10-01 Thread Tobias Klauser
On 2014-10-01 at 15:43:47 +0200, Joe Perches wrote: > On Wed, 2014-10-01 at 14:45 +0200, Tobias Klauser wrote: > > On 2014-09-30 at 23:29:46 +0200, Mark Einon wrote: > > > This adds the ethernet driver for Agere et131x devices to > > > drivers/net/ethernet. > []

Re: [PATCH net-next] et131x: Add PCIe gigabit ethernet driver et131x to drivers/net

2014-10-01 Thread Tobias Klauser
On 2014-09-30 at 23:29:46 +0200, Mark Einon wrote: > This adds the ethernet driver for Agere et131x devices to > drivers/net/ethernet. > > The driver being added has been in the staging tree for some time, and will be > removed from there in a seperate patch. This one merely disables the staging

Re: [PATCH net-next] et131x: Add PCIe gigabit ethernet driver et131x to drivers/net

2014-10-01 Thread Tobias Klauser
On 2014-09-30 at 23:29:46 +0200, Mark Einon mark.ei...@gmail.com wrote: This adds the ethernet driver for Agere et131x devices to drivers/net/ethernet. The driver being added has been in the staging tree for some time, and will be removed from there in a seperate patch. This one merely

Re: [PATCH net-next] et131x: Add PCIe gigabit ethernet driver et131x to drivers/net

2014-10-01 Thread Tobias Klauser
On 2014-10-01 at 15:43:47 +0200, Joe Perches j...@perches.com wrote: On Wed, 2014-10-01 at 14:45 +0200, Tobias Klauser wrote: On 2014-09-30 at 23:29:46 +0200, Mark Einon mark.ei...@gmail.com wrote: This adds the ethernet driver for Agere et131x devices to drivers/net/ethernet. [] diff

Re: [PATCH v3 01/29] asm-generic: add generic futex for !CONFIG_SMP

2014-09-26 Thread Tobias Klauser
On 2014-09-24 at 13:10:00 +0200, Arnd Bergmann wrote: > On Wednesday 24 September 2014 18:57:54 Ley Foon Tan wrote: > > On Wed, Sep 24, 2014 at 6:40 PM, Arnd Bergmann wrote: > > > On Wednesday 24 September 2014 18:18:50 Ley Foon Tan wrote: > > >> On Tue, Sep 23, 2014 at 6:40 PM, Arnd Bergmann

Re: [PATCH v3 01/29] asm-generic: add generic futex for !CONFIG_SMP

2014-09-26 Thread Tobias Klauser
On 2014-09-24 at 13:10:00 +0200, Arnd Bergmann a...@arndb.de wrote: On Wednesday 24 September 2014 18:57:54 Ley Foon Tan wrote: On Wed, Sep 24, 2014 at 6:40 PM, Arnd Bergmann a...@arndb.de wrote: On Wednesday 24 September 2014 18:18:50 Ley Foon Tan wrote: On Tue, Sep 23, 2014 at 6:40 PM,

Re: [RFC PATCH linux-next] et131x: Promote staging et131x driver to drivers/net

2014-09-23 Thread Tobias Klauser
On 2014-09-23 at 11:46:15 +0200, Mark Einon wrote: > On Tue, Sep 23, 2014 at 09:22:53AM +0200, Tobias Klauser wrote: > > Hi Tobias, > > Thanks for the details review. I've replied below - > > [...] > > > +/* et131x_rx_dma_memory_alloc > > > + * > >

Re: [RFC PATCH linux-next] et131x: Promote staging et131x driver to drivers/net

2014-09-23 Thread Tobias Klauser
On 2014-09-22 at 23:28:03 +0200, Mark Einon wrote: > This patch moves the et131x gigabit ethernet driver from drivers/staging > to drivers/net/ethernet/agere. > > There are no known issues at this time. > > Signed-off-by: Mark Einon > --- > > This patch will only apply once the last few

Re: [RFC PATCH linux-next] et131x: Promote staging et131x driver to drivers/net

2014-09-23 Thread Tobias Klauser
On 2014-09-22 at 23:28:03 +0200, Mark Einon mark.ei...@gmail.com wrote: This patch moves the et131x gigabit ethernet driver from drivers/staging to drivers/net/ethernet/agere. There are no known issues at this time. Signed-off-by: Mark Einon mark.ei...@gmail.com --- This patch will

Re: [RFC PATCH linux-next] et131x: Promote staging et131x driver to drivers/net

2014-09-23 Thread Tobias Klauser
On 2014-09-23 at 11:46:15 +0200, Mark Einon mark.ei...@gmail.com wrote: On Tue, Sep 23, 2014 at 09:22:53AM +0200, Tobias Klauser wrote: Hi Tobias, Thanks for the details review. I've replied below - [...] +/* et131x_rx_dma_memory_alloc + * + * Allocates Free buffer ring 1

Re: [PATCH] staging: rtl8192u: delete unused function CAM_read_entry

2014-09-18 Thread Tobias Klauser
On 2014-09-17 at 21:17:29 +0200, Benedict Boerger wrote: > Fix the sparse warning: symbol 'CAM_read_entry' was not declared. Should it > be static? > > The function CAM_read_entry is not used and therefore deleted. Your patch is missing a Signed-off-by line. Please check

Re: [PATCH] staging: rtl8192u: delete unused function CAM_read_entry

2014-09-18 Thread Tobias Klauser
On 2014-09-17 at 21:17:29 +0200, Benedict Boerger benedict.boer...@cs.tu-dortmund.de wrote: Fix the sparse warning: symbol 'CAM_read_entry' was not declared. Should it be static? The function CAM_read_entry is not used and therefore deleted. Your patch is missing a Signed-off-by line.

Re: [PATCH v3 26/29] nios2: ptrace support

2014-09-16 Thread Tobias Klauser
On 2014-09-08 at 11:22:37 +0200, Ley Foon Tan wrote: > Add ptrace support for nios2. > > Signed-off-by: Ley Foon Tan > --- > arch/nios2/include/asm/ptrace.h | 33 +++ > arch/nios2/include/uapi/asm/ptrace.h | 120 > arch/nios2/kernel/ptrace.c | 176

Re: [PATCH v3 26/29] nios2: ptrace support

2014-09-16 Thread Tobias Klauser
On 2014-09-08 at 11:22:37 +0200, Ley Foon Tan lf...@altera.com wrote: Add ptrace support for nios2. Signed-off-by: Ley Foon Tan lf...@altera.com --- arch/nios2/include/asm/ptrace.h | 33 +++ arch/nios2/include/uapi/asm/ptrace.h | 120

Re: [PATCH] tty: serial: serial_mctrl_gpio: Fix build error for !GPIOLIB

2014-09-10 Thread Tobias Klauser
On 2014-09-10 at 15:57:16 +0200, Greg Kroah-Hartman wrote: > On Wed, Sep 10, 2014 at 10:06:58AM +0200, Tobias Klauser wrote: > > If SERIAL_MCTRL_GPIO is selected but GPIOLIB is not, the noop functions > > from serial_mctrl_gpio.h are pulled in. However, serial_mctrl_gpio.c is >

[PATCH] tty: serial: serial_mctrl_gpio: Fix build error for !GPIOLIB

2014-09-10 Thread Tobias Klauser
it depend on GPIOLIB as well remove the noop functions alltogether. Reported-by: Jim Davis Signed-off-by: Tobias Klauser --- drivers/tty/serial/Kconfig | 1 + drivers/tty/serial/serial_mctrl_gpio.h | 35 -- 2 files changed, 1 insertion(+), 35 deletions

Re: randconfig build error with next-20140909, in drivers/tty/serial/serial_mctrl_gpio.c

2014-09-10 Thread Tobias Klauser
On 2014-09-10 at 00:32:25 +0200, Jim Davis wrote: > Building with the attached random configuration file, > > drivers/tty/serial/serial_mctrl_gpio.c:44:6: error: redefinition of > ‘mctrl_gpio_set’ > void mctrl_gpio_set(struct mctrl_gpios *gpios, unsigned int mctrl) > ^ > In file included

Re: [PATCH v3 25/29] nios2: Module support

2014-09-10 Thread Tobias Klauser
On 2014-09-10 at 09:29:25 +0200, Chung-Lin Tang wrote: > On 14/9/10 5:25 AM, valdis.kletni...@vt.edu wrote: > > On Mon, 08 Sep 2014 17:22:36 +0800, Ley Foon Tan said: > >> This patch adds support for loadable modules. > >> > >> Signed-off-by: Ley Foon Tan > > > >> +/* > >> + * Modules should

Re: [PATCH v5 1/2] tty: serial: 8250: Add Mediatek UART driver

2014-09-10 Thread Tobias Klauser
accordingly. > > Signed-off-by: Matthias Brugger All my previous review comments have been addressed. Reviewed-by: Tobias Klauser -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo inf

Re: [PATCH v5 1/2] tty: serial: 8250: Add Mediatek UART driver

2014-09-10 Thread Tobias Klauser
accordingly. Signed-off-by: Matthias Brugger matthias@gmail.com All my previous review comments have been addressed. Reviewed-by: Tobias Klauser tklau...@distanz.ch -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH v3 25/29] nios2: Module support

2014-09-10 Thread Tobias Klauser
On 2014-09-10 at 09:29:25 +0200, Chung-Lin Tang chunglin_t...@mentor.com wrote: On 14/9/10 5:25 AM, valdis.kletni...@vt.edu wrote: On Mon, 08 Sep 2014 17:22:36 +0800, Ley Foon Tan said: This patch adds support for loadable modules. Signed-off-by: Ley Foon Tan lf...@altera.com +/*

Re: randconfig build error with next-20140909, in drivers/tty/serial/serial_mctrl_gpio.c

2014-09-10 Thread Tobias Klauser
On 2014-09-10 at 00:32:25 +0200, Jim Davis jim.ep...@gmail.com wrote: Building with the attached random configuration file, drivers/tty/serial/serial_mctrl_gpio.c:44:6: error: redefinition of ‘mctrl_gpio_set’ void mctrl_gpio_set(struct mctrl_gpios *gpios, unsigned int mctrl) ^ In

[PATCH] tty: serial: serial_mctrl_gpio: Fix build error for !GPIOLIB

2014-09-10 Thread Tobias Klauser
it depend on GPIOLIB as well remove the noop functions alltogether. Reported-by: Jim Davis jim.ep...@gmail.com Signed-off-by: Tobias Klauser tklau...@distanz.ch --- drivers/tty/serial/Kconfig | 1 + drivers/tty/serial/serial_mctrl_gpio.h | 35 -- 2 files

Re: [PATCH] tty: serial: serial_mctrl_gpio: Fix build error for !GPIOLIB

2014-09-10 Thread Tobias Klauser
On 2014-09-10 at 15:57:16 +0200, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Wed, Sep 10, 2014 at 10:06:58AM +0200, Tobias Klauser wrote: If SERIAL_MCTRL_GPIO is selected but GPIOLIB is not, the noop functions from serial_mctrl_gpio.h are pulled in. However, serial_mctrl_gpio.c

Re: [PATCH v2 4/4] staging: ozwpan: use kmalloc_array over kmalloc with multiply

2014-09-09 Thread Tobias Klauser
On 2014-09-08 at 21:02:49 +0200, Adrian Nicoara wrote: > Cleanup checkpatch.pl warnings. Please state which warning this is fixing. Same goes for patches 1-3. > Signed-off-by: Adrian Nicoara > --- > > Somehow I missed the comment Tobias made on the line indentation. I fixed the > patch, and

Re: [PATCH v2 4/4] staging: ozwpan: use kmalloc_array over kmalloc with multiply

2014-09-09 Thread Tobias Klauser
On 2014-09-08 at 21:02:49 +0200, Adrian Nicoara anico...@uwaterloo.ca wrote: Cleanup checkpatch.pl warnings. Please state which warning this is fixing. Same goes for patches 1-3. Signed-off-by: Adrian Nicoara anico...@uwaterloo.ca --- Somehow I missed the comment Tobias made on the line

Re: [PATCH 1/4] staging: ozwpan: fix missing blank line after declaration

2014-09-08 Thread Tobias Klauser
Your From: line does not contain a real name and does not match your Signed-off-by line, please check your e-mail client settings. On 2014-09-07 at 20:21:41 +0200, anicoara wrote: Changelog text is missing. Please add a short notice, describing why this change is done. > Signed-off-by: Adrian

Re: [PATCH 2/4] staging: ozwpan: fix redundant else after break or return

2014-09-08 Thread Tobias Klauser
Your From: line does not contain a real name and does not match your Signed-off-by line, please check your e-mail client settings. On 2014-09-07 at 20:24:03 +0200, anicoara wrote: > Signed-off-by: Adrian Nicoara No changelog text? Please add a short notice, describing why this change is done.

Re: [PATCH 3/4] staging: ozwpan: fix redundant return in void function

2014-09-08 Thread Tobias Klauser
Your From: line does not contain a real name and does not match your Signed-off-by line, please check your e-mail client settings. On 2014-09-07 at 20:25:35 +0200, anicoara wrote: > Signed-off-by: Adrian Nicoara No changelog text? Please add a short notice, describing why this change is done.

Re: [PATCH 4/4] staging: ozwpan: use kmalloc_array over kmalloc with multiply

2014-09-08 Thread Tobias Klauser
Your From: line does not contain a real name and does not match your Signed-off-by line, please check your e-mail client settings. On 2014-09-07 at 20:28:25 +0200, anicoara wrote: No changelog text? Please add a short notice, describing why this change is done. > Signed-off-by: Adrian Nicoara

Re: [PATCH 4/4] staging: ozwpan: use kmalloc_array over kmalloc with multiply

2014-09-08 Thread Tobias Klauser
Your From: line does not contain a real name and does not match your Signed-off-by line, please check your e-mail client settings. On 2014-09-07 at 20:28:25 +0200, anicoara anico...@uwaterloo.ca wrote: No changelog text? Please add a short notice, describing why this change is done.

Re: [PATCH 3/4] staging: ozwpan: fix redundant return in void function

2014-09-08 Thread Tobias Klauser
Your From: line does not contain a real name and does not match your Signed-off-by line, please check your e-mail client settings. On 2014-09-07 at 20:25:35 +0200, anicoara anico...@uwaterloo.ca wrote: Signed-off-by: Adrian Nicoara anico...@uwaterloo.ca No changelog text? Please add a short

Re: [PATCH 2/4] staging: ozwpan: fix redundant else after break or return

2014-09-08 Thread Tobias Klauser
Your From: line does not contain a real name and does not match your Signed-off-by line, please check your e-mail client settings. On 2014-09-07 at 20:24:03 +0200, anicoara anico...@uwaterloo.ca wrote: Signed-off-by: Adrian Nicoara anico...@uwaterloo.ca No changelog text? Please add a short

Re: [PATCH 1/4] staging: ozwpan: fix missing blank line after declaration

2014-09-08 Thread Tobias Klauser
Your From: line does not contain a real name and does not match your Signed-off-by line, please check your e-mail client settings. On 2014-09-07 at 20:21:41 +0200, anicoara anico...@uwaterloo.ca wrote: Changelog text is missing. Please add a short notice, describing why this change is done.

Re: [PATCH] staging: xillybus: Move out of staging

2014-09-01 Thread Tobias Klauser
On 2014-08-31 at 09:57:01 +0200, Eli Billauer wrote: > This driver has been functional and stable throughout the year it has spent > in the staging area. It has been patched for minor bugs, coding style issues > and improvements during this period, so I suppose its time has come. > > I shall

Re: [PATCH] staging: xillybus: Move out of staging

2014-09-01 Thread Tobias Klauser
On 2014-08-31 at 09:57:01 +0200, Eli Billauer eli.billa...@gmail.com wrote: This driver has been functional and stable throughout the year it has spent in the staging area. It has been patched for minor bugs, coding style issues and improvements during this period, so I suppose its time has

Re: [PATCH v3 1/2] tty: serial: 8250: Add Mediatek UART driver

2014-08-12 Thread Tobias Klauser
On 2014-08-12 at 15:31:51 +0200, Matthias Brugger wrote: > 2014-08-08 14:28 GMT+02:00 Tobias Klauser : > > On 2014-08-08 at 13:32:03 +0200, Matthias Brugger > > wrote: > >> This patch adds support for the UART block found on Mediatek SoCs. > >> The devi

Re: [PATCH v3 1/2] tty: serial: 8250: Add Mediatek UART driver

2014-08-12 Thread Tobias Klauser
On 2014-08-12 at 15:31:51 +0200, Matthias Brugger matthias@gmail.com wrote: 2014-08-08 14:28 GMT+02:00 Tobias Klauser tklau...@distanz.ch: On 2014-08-08 at 13:32:03 +0200, Matthias Brugger matthias@gmail.com wrote: This patch adds support for the UART block found on Mediatek SoCs

Re: [PATCH v3 1/2] tty: serial: 8250: Add Mediatek UART driver

2014-08-08 Thread Tobias Klauser
On 2014-08-08 at 13:32:03 +0200, Matthias Brugger wrote: > This patch adds support for the UART block found on Mediatek SoCs. > The device has a highspeed register which influences the calcualtion of the > divisor. The chip lacks support for some baudrates. When requested, we set the > divisor

Re: [PATCH v10 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-08-08 Thread Tobias Klauser
ew comments for v9 of this series have been properly adressed. Reviewed-by: Tobias Klauser Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Adding a support for Skyworks SKY81452

2014-08-08 Thread Tobias Klauser
On 2014-08-08 at 09:09:19 +0200, Thierry Reding wrote: > On Thu, Aug 07, 2014 at 02:34:39PM +0200, Tobias Klauser wrote: > > On 2014-08-07 at 10:05:38 +0200, Gyungoh Yoo wrote: > [...] > > > +#ifdef CONFIG_OF > > > +static const struct of_device_id sky81452_of_ma

Re: [PATCH] Adding a support for Skyworks SKY81452

2014-08-08 Thread Tobias Klauser
On 2014-08-08 at 09:09:19 +0200, Thierry Reding thierry.red...@gmail.com wrote: On Thu, Aug 07, 2014 at 02:34:39PM +0200, Tobias Klauser wrote: On 2014-08-07 at 10:05:38 +0200, Gyungoh Yoo gyun...@gmail.com wrote: [...] +#ifdef CONFIG_OF +static const struct of_device_id

Re: [PATCH v10 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-08-08 Thread Tobias Klauser
Signed-off-by: Dean Nelson dnel...@redhat.com All my review comments for v9 of this series have been properly adressed. Reviewed-by: Tobias Klauser tklau...@distanz.ch Thanks -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org

Re: [PATCH v3 1/2] tty: serial: 8250: Add Mediatek UART driver

2014-08-08 Thread Tobias Klauser
On 2014-08-08 at 13:32:03 +0200, Matthias Brugger matthias@gmail.com wrote: This patch adds support for the UART block found on Mediatek SoCs. The device has a highspeed register which influences the calcualtion of the divisor. The chip lacks support for some baudrates. When requested, we

Re: [PATCH] Adding a support for Skyworks SKY81452

2014-08-07 Thread Tobias Klauser
On 2014-08-07 at 10:05:38 +0200, Gyungoh Yoo wrote: > Signed-off-by: Gyungoh Yoo > --- > Documentation/backlight/sky81452.txt | 25 ++ > Documentation/devicetree/bindings/mfd/sky81452.txt | 24 ++ > .../bindings/regulator/sky81452-regulator.txt | 16 + >

Re: [PATCH] powerpc/perf: Implement get_cpu_str()

2014-08-07 Thread Tobias Klauser
On 2014-08-06 at 02:17:55 +0200, Sukadev Bhattiprolu wrote: > powerpc/perf: Implement get_cpu_str() > > With a file like ~/.cache/pmu-events/004d0100-core.json describing > Power8 PMU events, we would need to run: > > perf stat \ > --events-file

Re: [PATCH] powerpc/perf: Implement get_cpu_str()

2014-08-07 Thread Tobias Klauser
On 2014-08-06 at 02:17:55 +0200, Sukadev Bhattiprolu suka...@linux.vnet.ibm.com wrote: powerpc/perf: Implement get_cpu_str() With a file like ~/.cache/pmu-events/004d0100-core.json describing Power8 PMU events, we would need to run: perf stat \ --events-file

Re: [PATCH] Adding a support for Skyworks SKY81452

2014-08-07 Thread Tobias Klauser
On 2014-08-07 at 10:05:38 +0200, Gyungoh Yoo gyun...@gmail.com wrote: Signed-off-by: Gyungoh Yoo jack@skyworksinc.com --- Documentation/backlight/sky81452.txt | 25 ++ Documentation/devicetree/bindings/mfd/sky81452.txt | 24 ++

Re: [PATCH] staging: vt6655: Fix device table definition.

2014-07-30 Thread Tobias Klauser
On 2014-07-29 at 19:44:24 +0200, fernando.apesteg...@gmail.com wrote: > From: Fernando Apesteguia > > Add static to the definition of the pci device table. > > Signed-off-by: Fernando Apesteguia This change is already part of Greg's tree, see commit 9e4c5c2837a4 ("staging: vt6655: statify

Re: [PATCH v2 1/1] staging: vt6655: ioctl.c - missing __user annotation

2014-07-30 Thread Tobias Klauser
On 2014-07-30 at 12:41:59 +0200, Anil Belur wrote: > From: Anil Belur This line is only necessary if you're sending the patch on behalf of someone else. Also there is no need to have the 1/1 in the Subject line as you're only sending one patch, not an entire series. > v2: > - private_ioctl()

Re: [PATCH v2 02/29] nios2: Kernel booting and initialization

2014-07-30 Thread Tobias Klauser
On 2014-07-15 at 10:45:29 +0200, Ley Foon Tan wrote: > This patch adds the kernel booting and the initial setup code. > > Signed-off-by: Ley Foon Tan > --- > arch/nios2/include/asm/entry.h | 152 > arch/nios2/include/asm/setup.h | 38 +++ >

Re: [PATCH v2 05/29] nios2: Memory management

2014-07-30 Thread Tobias Klauser
os2/include/asm/page.h b/arch/nios2/include/asm/page.h > new file mode 100644 > index 000..b89c1d6 > --- /dev/null > +++ b/arch/nios2/include/asm/page.h > @@ -0,0 +1,113 @@ > +/* > + * Copyright (C) 2011 Tobias Klauser > + * Copyright (C) 2004 Microtronix Datacom Ltd. > +

Re: [PATCH v2 05/29] nios2: Memory management

2014-07-30 Thread Tobias Klauser
/null > >>> +++ b/arch/nios2/include/asm/mmu.h > >>> @@ -0,0 +1,18 @@ > >>> +/* > >>> + * Copyright (C) 2010 Tobias Klauser > >>> + * Copyright (C) 2004 Microtronix Datacom Ltd. > >>> + * > >>> + * Tak

Re: [PATCH v2 05/29] nios2: Memory management

2014-07-30 Thread Tobias Klauser
...@altera.com wrote: --- /dev/null +++ b/arch/nios2/include/asm/mmu.h @@ -0,0 +1,18 @@ +/* + * Copyright (C) 2010 Tobias Klauser tklau...@distanz.ch + * Copyright (C) 2004 Microtronix Datacom Ltd. + * + * Taken from m68knommu. + * + * This file is subject to the terms and conditions

Re: [PATCH v2 05/29] nios2: Memory management

2014-07-30 Thread Tobias Klauser
/asm/page.h new file mode 100644 index 000..b89c1d6 --- /dev/null +++ b/arch/nios2/include/asm/page.h @@ -0,0 +1,113 @@ +/* + * Copyright (C) 2011 Tobias Klauser tklau...@distanz.ch + * Copyright (C) 2004 Microtronix Datacom Ltd. + * + * MMU support based on asm/page.h from mips which

Re: [PATCH v2 02/29] nios2: Kernel booting and initialization

2014-07-30 Thread Tobias Klauser
On 2014-07-15 at 10:45:29 +0200, Ley Foon Tan lf...@altera.com wrote: This patch adds the kernel booting and the initial setup code. Signed-off-by: Ley Foon Tan lf...@altera.com --- arch/nios2/include/asm/entry.h | 152 arch/nios2/include/asm/setup.h | 38

Re: [PATCH v2 1/1] staging: vt6655: ioctl.c - missing __user annotation

2014-07-30 Thread Tobias Klauser
On 2014-07-30 at 12:41:59 +0200, Anil Belur ask...@gmail.com wrote: From: Anil Belur ask...@gmail.com This line is only necessary if you're sending the patch on behalf of someone else. Also there is no need to have the 1/1 in the Subject line as you're only sending one patch, not an entire

Re: [PATCH] staging: vt6655: Fix device table definition.

2014-07-30 Thread Tobias Klauser
On 2014-07-29 at 19:44:24 +0200, fernando.apesteg...@gmail.com fernando.apesteg...@gmail.com wrote: From: Fernando Apesteguia fernando.apesteg...@gmail.com Add static to the definition of the pci device table. Signed-off-by: Fernando Apesteguia fernando.apesteg...@gmail.com This change is

Re: [PATCH 2/2] netlink: Convert netlink_lookup() to use RCU protected hash table

2014-07-29 Thread Tobias Klauser
On 2014-07-29 at 13:41:33 +0200, Thomas Graf wrote: > Heavy Netlink users such as Open vSwitch spend a considerable amount of > time in netlink_lookup() due to the read-lock on nl_table_lock. Use of > RCU relieves the lock contention. > > Makes use of the new resizable hash table to avoid

Re: [PATCH] staging: dgnc: remove commented code

2014-07-29 Thread Tobias Klauser
On 2014-07-25 at 18:49:01 +0200, Seunghun Lee wrote: > This patch removes commented code in dgnc driver. > > CC: Lidza Louina > CC: Mark Hounschell > Signed-off-by: Seunghun Lee > --- > drivers/staging/dgnc/dgnc_cls.c |5 +- > drivers/staging/dgnc/dgnc_trace.c | 123 >

Re: [PATCH 1/1] drivers: staging: vt6655: ioctl.c - missing __user annotation

2014-07-29 Thread Tobias Klauser
On 2014-07-28 at 09:58:12 +0200, Anil Belur wrote: > From: Anil Belur > > - private_ioctl() the internally calls copy_{to,from}_user() and does > not use '__user' while refrencing user space pointers. > - this patch passes __user annotation as a cast, when the pointer is > being refernced.

Re: [PATCH 1/1] drivers: staging: vt6655: ioctl.c - missing __user annotation

2014-07-29 Thread Tobias Klauser
On 2014-07-28 at 09:58:12 +0200, Anil Belur ask...@gmail.com wrote: From: Anil Belur ask...@gmail.com - private_ioctl() the internally calls copy_{to,from}_user() and does not use '__user' while refrencing user space pointers. - this patch passes __user annotation as a cast, when the

Re: [PATCH] staging: dgnc: remove commented code

2014-07-29 Thread Tobias Klauser
On 2014-07-25 at 18:49:01 +0200, Seunghun Lee way...@gmail.com wrote: This patch removes commented code in dgnc driver. CC: Lidza Louina lidza.lou...@gmail.com CC: Mark Hounschell ma...@compro.net Signed-off-by: Seunghun Lee way...@gmail.com --- drivers/staging/dgnc/dgnc_cls.c |5 +-

Re: [PATCH 2/2] netlink: Convert netlink_lookup() to use RCU protected hash table

2014-07-29 Thread Tobias Klauser
On 2014-07-29 at 13:41:33 +0200, Thomas Graf tg...@suug.ch wrote: Heavy Netlink users such as Open vSwitch spend a considerable amount of time in netlink_lookup() due to the read-lock on nl_table_lock. Use of RCU relieves the lock contention. Makes use of the new resizable hash table to

Re: [PATCH 1/1] Managed Devices devres_debugfs file system

2014-07-24 Thread Tobias Klauser
On 2014-07-24 at 17:18:01 +0200, Rob Jones wrote: > Reviewed-by: Ian Molton > Suggested-by: Ben Dooks > Signed-off-by: Rob Jones > --- > Documentation/driver-model/devres-debugfs.txt | 140 + > drivers/base/Kconfig | 18 ++ > drivers/base/devres.c

Re: [PATCH v2 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

2014-07-24 Thread Tobias Klauser
On 2014-07-24 at 10:35:29 +0200, Nicolin Chen wrote: > The Asynchronous Sample Rate Converter (ASRC) converts the sampling rate of a > signal associated with an input clock into a signal associated with a > different > output clock. The driver currently works as a Front End of DPCM with other >

Re: [PATCH v2 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

2014-07-24 Thread Tobias Klauser
On 2014-07-24 at 10:35:29 +0200, Nicolin Chen nicoleots...@gmail.com wrote: The Asynchronous Sample Rate Converter (ASRC) converts the sampling rate of a signal associated with an input clock into a signal associated with a different output clock. The driver currently works as a Front End of

Re: [PATCH 1/1] Managed Devices devres_debugfs file system

2014-07-24 Thread Tobias Klauser
On 2014-07-24 at 17:18:01 +0200, Rob Jones rob.jo...@codethink.co.uk wrote: Reviewed-by: Ian Molton ian.mol...@codethink.co.uk Suggested-by: Ben Dooks ben.do...@codethink.co.uk Signed-off-by: Rob Jones rob.jo...@codethink.co.uk --- Documentation/driver-model/devres-debugfs.txt | 140

Re: [PATCH] mailbox/omap: Use module_platform_driver

2014-07-23 Thread Tobias Klauser
On 2014-07-22 at 17:00:44 +0200, Suman Anna wrote: > Hi Tobias, > > On 07/22/2014 07:13 AM, Tobias Klauser wrote: > > Use the module_platform_driver to omit module init/exit boilerplate code. > > > > Signed-off-by: Tobias Klauser > > --- > >

Re: [PATCH] mailbox/omap: Use module_platform_driver

2014-07-23 Thread Tobias Klauser
On 2014-07-22 at 17:00:44 +0200, Suman Anna s-a...@ti.com wrote: Hi Tobias, On 07/22/2014 07:13 AM, Tobias Klauser wrote: Use the module_platform_driver to omit module init/exit boilerplate code. Signed-off-by: Tobias Klauser tklau...@distanz.ch --- drivers/mailbox/mailbox-omap1.c

[PATCH] mailbox/omap: Use module_platform_driver

2014-07-22 Thread Tobias Klauser
Use the module_platform_driver to omit module init/exit boilerplate code. Signed-off-by: Tobias Klauser --- drivers/mailbox/mailbox-omap1.c | 13 + drivers/mailbox/mailbox-omap2.c | 13 + 2 files changed, 2 insertions(+), 24 deletions(-) diff --git a/drivers/mailbox

[PATCH] mailbox/omap: Use module_platform_driver

2014-07-22 Thread Tobias Klauser
Use the module_platform_driver to omit module init/exit boilerplate code. Signed-off-by: Tobias Klauser tklau...@distanz.ch --- drivers/mailbox/mailbox-omap1.c | 13 + drivers/mailbox/mailbox-omap2.c | 13 + 2 files changed, 2 insertions(+), 24 deletions(-) diff --git

Re: [PATCH, RFC] random: introduce getrandom(2) system call

2014-07-17 Thread Tobias Klauser
On 2014-07-17 at 11:18:15 +0200, Theodore Ts'o wrote: [...] > +/* > + * Flags for getrandom(2) > + * > + * GAND_BLOCKAllow getrandom(2) to block > + * GAND_RANDOM Use the /dev/random pool instead of /dev/urandom > + */ Very minor nitpick: These should probably

Re: [PATCH, RFC] random: introduce getrandom(2) system call

2014-07-17 Thread Tobias Klauser
On 2014-07-17 at 11:18:15 +0200, Theodore Ts'o ty...@mit.edu wrote: [...] +/* + * Flags for getrandom(2) + * + * GAND_BLOCKAllow getrandom(2) to block + * GAND_RANDOM Use the /dev/random pool instead of /dev/urandom + */ Very minor nitpick: These should

Re: [PATCH v4] hwmon: pwm-fan: Add pwm-fan driver

2014-07-16 Thread Tobias Klauser
ki Looks good as for my comments. If you want you can add my Reviewed-by: Tobias Klauser -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info

Re: [PATCH v4] hwmon: pwm-fan: Add pwm-fan driver

2014-07-16 Thread Tobias Klauser
Debski k.deb...@samsung.com Looks good as for my comments. If you want you can add my Reviewed-by: Tobias Klauser tklau...@distanz.ch -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v2 00/29] nios2 Linux kernel port

2014-07-15 Thread Tobias Klauser
Hi Ley Foon On 2014-07-15 at 11:38:36 +0200, Ley Foon Tan wrote: > On Tue, Jul 15, 2014 at 5:08 PM, Tobias Klauser wrote: > > > > On 2014-07-15 at 10:45:27 +0200, Ley Foon Tan wrote: > > > > > Very nice work Ley Foon! It's great to see the Nios II port

Re: [PATCH v2 24/29] nios2: Module support

2014-07-15 Thread Tobias Klauser
On 2014-07-15 at 12:24:46 +0200, Arnd Bergmann wrote: > On Tuesday 15 July 2014 16:45:51 Ley Foon Tan wrote: > > +void *module_alloc(unsigned long size) > > +{ > > + if (size == 0) > > + return NULL; > > + return kmalloc(size, GFP_KERNEL); > > +} > > + > > +/* Free memory returned

Re: [PATCH v2 00/29] nios2 Linux kernel port

2014-07-15 Thread Tobias Klauser
On 2014-07-15 at 10:45:27 +0200, Ley Foon Tan wrote: > This is the 2nd version of patchset adds the Linux kernel port for Nios II > processor from > Altera. All of the feedback from v1 patchseries has been addressed. Thanks to > all who > provided feedback on the previous version. > > About

Re: [PATCH v2 26/29] Add ELF machine define for Nios2

2014-07-15 Thread Tobias Klauser
On 2014-07-15 at 10:45:53 +0200, Ley Foon Tan wrote: > Signed-off-by: Ley Foon Tan This should probably be sent/applied before "[PATCH v2 14/29] nios2: ELF definitions", since there EM_ALTERA_NIOS2 is already used. > --- > include/uapi/linux/elf-em.h | 1 + > 1 file changed, 1 insertion(+) >

<    1   2   3   4   5   >