[PATCH 19/20] staging: gasket: common ioctl dispatcher add __user annotations

From: Todd Poynor Add __user annotation to gasket core common ioctl pointer arguments for sparse checking. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_ioctl.c | 8 +--- drivers/staging/gasket/gasket_ioctl.h | 4

[PATCH 02/20] staging: gasket: gasket_enable_dev remove unnecessary variable

From: Todd Poynor Remove unnecessary variable, pass constant param instead. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging

[PATCH 18/20] staging: gasket: apex ioctl add __user annotations

From: Todd Poynor Add __user annotation to ioctl pointer argument, for sparse checking. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/apex_driver.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff

[PATCH 19/20] staging: gasket: common ioctl dispatcher add __user annotations

From: Todd Poynor Add __user annotation to gasket core common ioctl pointer arguments for sparse checking. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_ioctl.c | 8 +--- drivers/staging/gasket/gasket_ioctl.h | 4

[PATCH 02/20] staging: gasket: gasket_enable_dev remove unnecessary variable

From: Todd Poynor Remove unnecessary variable, pass constant param instead. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging

[PATCH 18/20] staging: gasket: apex ioctl add __user annotations

From: Todd Poynor Add __user annotation to ioctl pointer argument, for sparse checking. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/apex_driver.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff

[PATCH 11/20] staging: gasket: fix comment syntax in apex.h

From: Todd Poynor Use kernel-style multi-line comment syntax. Reported-by: Guenter Roeck Signed-off-by: Simon Que Signed-off-by: Todd Poynor --- drivers/staging/gasket/apex.h | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/gasket/apex.h b/drivers

[PATCH 10/20] staging: gasket: remove else clause after return in if clause

From: Todd Poynor Else after return is unnecessary and may cause static code checkers to complain. Reported-by: Guenter Roeck Signed-off-by: Simon Que Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_page_table.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff

[PATCH 04/20] staging: gasket: fix class create bug handling

From: Todd Poynor class_create() never returns NULL, and this driver should never return PTR_ERR(NULL) anyway. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor Reviewed-by: Dmitry Torokhov --- drivers/staging/gasket/gasket_core.c | 2 +- 1 file changed, 1

[PATCH 00/20 v4] staging: gasket: sundry fixes and fixups

From: Todd Poynor Various fixes mainly from the chromium review of the gasket and apex drivers. More to come. Todd Poynor (20): staging: gasket: allow compile for ARM64 in Kconfig staging: gasket: gasket_enable_dev remove unnecessary variable staging: gasket: remove code for no physical

[PATCH 11/20] staging: gasket: fix comment syntax in apex.h

From: Todd Poynor Use kernel-style multi-line comment syntax. Reported-by: Guenter Roeck Signed-off-by: Simon Que Signed-off-by: Todd Poynor --- drivers/staging/gasket/apex.h | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/gasket/apex.h b/drivers

[PATCH 10/20] staging: gasket: remove else clause after return in if clause

From: Todd Poynor Else after return is unnecessary and may cause static code checkers to complain. Reported-by: Guenter Roeck Signed-off-by: Simon Que Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_page_table.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff

[PATCH 04/20] staging: gasket: fix class create bug handling

From: Todd Poynor class_create() never returns NULL, and this driver should never return PTR_ERR(NULL) anyway. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor Reviewed-by: Dmitry Torokhov --- drivers/staging/gasket/gasket_core.c | 2 +- 1 file changed, 1

[PATCH 00/20 v4] staging: gasket: sundry fixes and fixups

From: Todd Poynor Various fixes mainly from the chromium review of the gasket and apex drivers. More to come. Todd Poynor (20): staging: gasket: allow compile for ARM64 in Kconfig staging: gasket: gasket_enable_dev remove unnecessary variable staging: gasket: remove code for no physical

Re: [PATCH 17/32] staging: gasket: annotate ioctl arg with __user

On Thu, Jul 19, 2018 at 2:37 AM, Greg Kroah-Hartman wrote: > On Tue, Jul 17, 2018 at 01:56:57PM -0700, Todd Poynor wrote: >> From: Todd Poynor >> >> For sparse checking. > > Close, but you can do better :) > >> >> Reported-by: Dmitry Torokhov >> S

Re: [PATCH 17/32] staging: gasket: annotate ioctl arg with __user

On Thu, Jul 19, 2018 at 2:37 AM, Greg Kroah-Hartman wrote: > On Tue, Jul 17, 2018 at 01:56:57PM -0700, Todd Poynor wrote: >> From: Todd Poynor >> >> For sparse checking. > > Close, but you can do better :) > >> >> Reported-by: Dmitry Torokhov >> S

Re: [PATCH 16/32] staging: gasket: always allow root open for write

On Thu, Jul 19, 2018 at 2:29 AM, Greg Kroah-Hartman wrote: > On Tue, Jul 17, 2018 at 01:56:56PM -0700, Todd Poynor wrote: >> From: Todd Poynor >> >> Always allow root to open device for writing. >> >> Drop special-casing of ioctl permissions for root vs. owner. &

Re: [PATCH 16/32] staging: gasket: always allow root open for write

On Thu, Jul 19, 2018 at 2:29 AM, Greg Kroah-Hartman wrote: > On Tue, Jul 17, 2018 at 01:56:56PM -0700, Todd Poynor wrote: >> From: Todd Poynor >> >> Always allow root to open device for writing. >> >> Drop special-casing of ioctl permissions for root vs. owner. &

Re: [PATCH resend] staging: gasket: remove X86 Kconfig restriction

applied to the wrong git tree, please drop us a note to > help improve the system] > > url: > https://github.com/0day-ci/linux/commits/Todd-Poynor/staging-gasket-remove-X86-Kconfig-restriction/20180716-031056 > config: xtensa-allmodconfig (attached as .config) > compiler

Re: [PATCH resend] staging: gasket: remove X86 Kconfig restriction

applied to the wrong git tree, please drop us a note to > help improve the system] > > url: > https://github.com/0day-ci/linux/commits/Todd-Poynor/staging-gasket-remove-X86-Kconfig-restriction/20180716-031056 > config: xtensa-allmodconfig (attached as .config) > compiler

[PATCH 02/32] staging: gasket: fix typo in apex_enter_reset

From: Todd Poynor Fix typo in log message. Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/apex_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gasket/apex_driver.c b/drivers/staging/gasket/apex_driver.c index

[PATCH 03/32] staging: gasket: fix typo in gasket_core.h comments

From: Todd Poynor Grammar fixup in gasket_core.h comments describing struct gasket_interrupt_desc. Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gasket/gasket_core.h b/drivers/staging

[PATCH 02/32] staging: gasket: fix typo in apex_enter_reset

From: Todd Poynor Fix typo in log message. Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/apex_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gasket/apex_driver.c b/drivers/staging/gasket/apex_driver.c index

[PATCH 03/32] staging: gasket: fix typo in gasket_core.h comments

From: Todd Poynor Grammar fixup in gasket_core.h comments describing struct gasket_interrupt_desc. Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gasket/gasket_core.h b/drivers/staging

[PATCH 07/32] staging: gasket: Return EBUSY on mapping create when already in use

From: Todd Poynor gasket_sysfs_create_mapping() return EBUSY if sysfs mapping already in use, as a more appropriate error code than the current return of EINVAL, which would indicate invalid parameters. Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket

[PATCH 10/32] staging: gasket: fix gasket_wait_with_reschedule timeout return code

From: Todd Poynor Return -ETIMEDOUT, not -EINVAL, on timeout, including callers. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/apex_driver.c | 8 drivers/staging/gasket/gasket_core.c | 2 +- 2 files changed, 5

[PATCH 07/32] staging: gasket: Return EBUSY on mapping create when already in use

From: Todd Poynor gasket_sysfs_create_mapping() return EBUSY if sysfs mapping already in use, as a more appropriate error code than the current return of EINVAL, which would indicate invalid parameters. Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket

[PATCH 10/32] staging: gasket: fix gasket_wait_with_reschedule timeout return code

From: Todd Poynor Return -ETIMEDOUT, not -EINVAL, on timeout, including callers. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/apex_driver.c | 8 drivers/staging/gasket/gasket_core.c | 2 +- 2 files changed, 5

[PATCH 11/32] staging: gasket: gasket_wait_with_reschedule use msleep

From: Todd Poynor Replace schedule_timeout() call with msleep() for simplicity. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH 12/32] staging: gasket: gasket_wait_with_reschedule simplify logic

From: Todd Poynor gasket_wait_with_reschedule() is a little more clear if we just return directly when the waited-for condition is hit. This also allows the following condition check to be removed and identation of the conditionally-executed code to be reduced. Reported-by: Dmitry Torokhov

[PATCH 08/32] staging: gasket: Remove stale pointers on error allocating attr array

From: Todd Poynor If gasket_sysfs_create_mapping() hits errors allocating the attribute array, remove stale pointers to device info from the mapping object. Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_sysfs.c | 2 ++ 1 file changed, 2 insertions

[PATCH 11/32] staging: gasket: gasket_wait_with_reschedule use msleep

From: Todd Poynor Replace schedule_timeout() call with msleep() for simplicity. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH 12/32] staging: gasket: gasket_wait_with_reschedule simplify logic

From: Todd Poynor gasket_wait_with_reschedule() is a little more clear if we just return directly when the waited-for condition is hit. This also allows the following condition check to be removed and identation of the conditionally-executed code to be reduced. Reported-by: Dmitry Torokhov

[PATCH 08/32] staging: gasket: Remove stale pointers on error allocating attr array

From: Todd Poynor If gasket_sysfs_create_mapping() hits errors allocating the attribute array, remove stale pointers to device info from the mapping object. Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_sysfs.c | 2 ++ 1 file changed, 2 insertions

[PATCH 16/32] staging: gasket: always allow root open for write

From: Todd Poynor Always allow root to open device for writing. Drop special-casing of ioctl permissions for root vs. owner. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/apex_driver.c | 9 + drivers/staging/gasket

[PATCH 25/32] staging: gasket: apex_ioctl_check_permissions use bool return type

From: Todd Poynor Convert from int return to bool. Reported-by: Guenter Roeck Signed-off-by: Simon Que Signed-off-by: Todd Poynor --- drivers/staging/gasket/apex_driver.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/gasket/apex_driver.c b

[PATCH 21/32] staging: gasket: remove unnecessary code in coherent allocator

From: Todd Poynor Remove extraneous statement in gasket_config_coherent_allocator() Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_ioctl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers

[PATCH 13/32] staging: gasket: gasket_wait_with_reschedule use 32 bits of retry count

From: Todd Poynor Don't need a 64-bit retry counter. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 4 ++-- drivers/staging/gasket/gasket_core.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 20/32] staging: gasket: fix class create bug handling

From: Todd Poynor class_create() never returns NULL, and this driver should never return PTR_ERR(NULL) anyway. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor Reviewed-by: Dmitry Torokhov --- drivers/staging/gasket/gasket_core.c | 2 +- 1 file changed, 1

[PATCH 16/32] staging: gasket: always allow root open for write

From: Todd Poynor Always allow root to open device for writing. Drop special-casing of ioctl permissions for root vs. owner. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/apex_driver.c | 9 + drivers/staging/gasket

[PATCH 25/32] staging: gasket: apex_ioctl_check_permissions use bool return type

From: Todd Poynor Convert from int return to bool. Reported-by: Guenter Roeck Signed-off-by: Simon Que Signed-off-by: Todd Poynor --- drivers/staging/gasket/apex_driver.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/gasket/apex_driver.c b

[PATCH 21/32] staging: gasket: remove unnecessary code in coherent allocator

From: Todd Poynor Remove extraneous statement in gasket_config_coherent_allocator() Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_ioctl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers

[PATCH 13/32] staging: gasket: gasket_wait_with_reschedule use 32 bits of retry count

From: Todd Poynor Don't need a 64-bit retry counter. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 4 ++-- drivers/staging/gasket/gasket_core.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 20/32] staging: gasket: fix class create bug handling

From: Todd Poynor class_create() never returns NULL, and this driver should never return PTR_ERR(NULL) anyway. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor Reviewed-by: Dmitry Torokhov --- drivers/staging/gasket/gasket_core.c | 2 +- 1 file changed, 1

[PATCH 26/32] staging: gasket: gasket page table functions use bool return type

From: Todd Poynor Convert from int to bool return type for gasket page table functions that return values used as booleans. Reported-by: Guenter Roeck Signed-off-by: Simon Que Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_page_table.c | 58 +++--- drivers

[PATCH 29/32] staging: gasket: remove unnecessary parens in page table code

From: Todd Poynor gasket_alloc_coherent_memory() extra parentheses in statement. Reported-by: Guenter Roeck Signed-off-by: Simon Que Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_page_table.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH 26/32] staging: gasket: gasket page table functions use bool return type

From: Todd Poynor Convert from int to bool return type for gasket page table functions that return values used as booleans. Reported-by: Guenter Roeck Signed-off-by: Simon Que Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_page_table.c | 58 +++--- drivers

[PATCH 29/32] staging: gasket: remove unnecessary parens in page table code

From: Todd Poynor gasket_alloc_coherent_memory() extra parentheses in statement. Reported-by: Guenter Roeck Signed-off-by: Simon Que Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_page_table.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH 32/32] staging: gasket: fix multi-line comment syntax in gasket_core.h

From: Todd Poynor Use consistent kernel-style multi-line comment syntax. Reported-by: Guenter Roeck Signed-off-by: Simon Que Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/gasket

[PATCH 14/32] staging: gasket: bail out of reset sequence on device callback error

From: Todd Poynor If device reset callback returns an error, error out at the gasket level. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH 09/32] staging: gasket: convert gasket_mmap_has_permissions to bool return

From: Todd Poynor gasket_mmap_has_permissions() should return a boolean value. Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/gasket/gasket_core.c

[PATCH 30/32] staging: gasket: gasket_mmap use PAGE_MASK

From: Todd Poynor gasket_mmap use PAGE_MASK, instead of performing math on PAGE_SIZE, for simplicity and clarity. Reported-by: Guenter Roeck Signed-off-by: Simon Que Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 32/32] staging: gasket: fix multi-line comment syntax in gasket_core.h

From: Todd Poynor Use consistent kernel-style multi-line comment syntax. Reported-by: Guenter Roeck Signed-off-by: Simon Que Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/gasket

[PATCH 14/32] staging: gasket: bail out of reset sequence on device callback error

From: Todd Poynor If device reset callback returns an error, error out at the gasket level. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH 09/32] staging: gasket: convert gasket_mmap_has_permissions to bool return

From: Todd Poynor gasket_mmap_has_permissions() should return a boolean value. Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/gasket/gasket_core.c

[PATCH 30/32] staging: gasket: gasket_mmap use PAGE_MASK

From: Todd Poynor gasket_mmap use PAGE_MASK, instead of performing math on PAGE_SIZE, for simplicity and clarity. Reported-by: Guenter Roeck Signed-off-by: Simon Que Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 18/32] staging: gasket: gasket_enable_dev remove unnecessary variable

From: Todd Poynor Remove unnecessary variable, pass constant param instead. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging

[PATCH 19/32] staging: gasket: remove code for no physical device

From: Todd Poynor gasket_enable_dev code for enabling a gasket device with no physical PCI device registered shouldn't be necessary. Reported-by: Greg Kroah-Hartman Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 12 +--- 1 file changed, 1 insertion(+), 11

[PATCH 31/32] staging: gasket: remove extra parens in gasket_write_mappable_regions

From: Todd Poynor Remove unneeded parentheses around subexpressions. Reported-by: Guenter Roeck Signed-off-by: Simon Que Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gasket

[PATCH 28/32] staging: gasket: fix comment syntax in apex.h

From: Todd Poynor Use kernel-style multi-line comment syntax. Reported-by: Guenter Roeck Signed-off-by: Simon Que Signed-off-by: Todd Poynor --- drivers/staging/gasket/apex.h | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/gasket/apex.h b/drivers

[PATCH 19/32] staging: gasket: remove code for no physical device

From: Todd Poynor gasket_enable_dev code for enabling a gasket device with no physical PCI device registered shouldn't be necessary. Reported-by: Greg Kroah-Hartman Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 12 +--- 1 file changed, 1 insertion(+), 11

[PATCH 31/32] staging: gasket: remove extra parens in gasket_write_mappable_regions

From: Todd Poynor Remove unneeded parentheses around subexpressions. Reported-by: Guenter Roeck Signed-off-by: Simon Que Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gasket

[PATCH 28/32] staging: gasket: fix comment syntax in apex.h

From: Todd Poynor Use kernel-style multi-line comment syntax. Reported-by: Guenter Roeck Signed-off-by: Simon Que Signed-off-by: Todd Poynor --- drivers/staging/gasket/apex.h | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/gasket/apex.h b/drivers

[PATCH 18/32] staging: gasket: gasket_enable_dev remove unnecessary variable

From: Todd Poynor Remove unnecessary variable, pass constant param instead. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging

[PATCH 23/32] staging: gasket: gasket_mmap return error instead of valid BAR index

From: Todd Poynor When offset to be mapped matches both a BAR region and a coherent mapped region return an error as intended, not the BAR index. Signed-off-by: Simon Que Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 27/32] staging: gasket: remove else clause after return in if clause

From: Todd Poynor Else after return is unnecessary and may cause static code checkers to complain. Reported-by: Guenter Roeck Signed-off-by: Simon Que Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_page_table.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff

[PATCH 24/32] staging: gasket: apex_clock_gating simplify logic, reduce indentation

From: Todd Poynor Collapse together two checks and return immediately, avoid conditional indentation for most of function code. Reported-by: Guenter Roeck Signed-off-by: Simon Que Signed-off-by: Todd Poynor --- drivers/staging/gasket/apex_driver.c | 43 +--- 1 file

[PATCH 22/32] staging: gasket: don't treat no device reset callback as an error

From: Todd Poynor It is not an error for a device to not have a reset callback registered. Signed-off-by: Simon Que Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/gasket

[PATCH 27/32] staging: gasket: remove else clause after return in if clause

From: Todd Poynor Else after return is unnecessary and may cause static code checkers to complain. Reported-by: Guenter Roeck Signed-off-by: Simon Que Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_page_table.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff

[PATCH 24/32] staging: gasket: apex_clock_gating simplify logic, reduce indentation

From: Todd Poynor Collapse together two checks and return immediately, avoid conditional indentation for most of function code. Reported-by: Guenter Roeck Signed-off-by: Simon Que Signed-off-by: Todd Poynor --- drivers/staging/gasket/apex_driver.c | 43 +--- 1 file

[PATCH 22/32] staging: gasket: don't treat no device reset callback as an error

From: Todd Poynor It is not an error for a device to not have a reset callback registered. Signed-off-by: Simon Que Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/gasket

[PATCH 23/32] staging: gasket: gasket_mmap return error instead of valid BAR index

From: Todd Poynor When offset to be mapped matches both a BAR region and a coherent mapped region return an error as intended, not the BAR index. Signed-off-by: Simon Que Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 01/32] staging: gasket: remove X86 Kconfig restriction

From: Todd Poynor The gasket and apex drivers are to be used on other architectures besides X86. Signed-off-by: Todd Poynor --- drivers/staging/gasket/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gasket/Kconfig b/drivers/staging/gasket/Kconfig

[PATCH 17/32] staging: gasket: annotate ioctl arg with __user

From: Todd Poynor For sparse checking. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor Reviewed-by: Dmitry Torokhov --- drivers/staging/gasket/apex_driver.c | 11 ++-- drivers/staging/gasket/gasket_core.c | 6 ++- drivers/staging/gasket/gasket_core.h

[PATCH 15/32] staging: gasket: drop gasket_cdev_get_info, use container_of

From: Todd Poynor Remove gasket_cdev_get_info(), use container_of() directly instead, drop unnecessary NULL checks. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 26 -- 1 file changed, 4

[PATCH 00/32 v3] staging: gasket: sundry fixes and fixups

From: Todd Poynor Various fixes mainly from the chromium review of the gasket and apex drivers. More to come. Todd Poynor (32): staging: gasket: remove X86 Kconfig restriction staging: gasket: fix typo in apex_enter_reset staging: gasket: fix typo in gasket_core.h comments staging

[PATCH 01/32] staging: gasket: remove X86 Kconfig restriction

From: Todd Poynor The gasket and apex drivers are to be used on other architectures besides X86. Signed-off-by: Todd Poynor --- drivers/staging/gasket/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gasket/Kconfig b/drivers/staging/gasket/Kconfig

[PATCH 17/32] staging: gasket: annotate ioctl arg with __user

From: Todd Poynor For sparse checking. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor Reviewed-by: Dmitry Torokhov --- drivers/staging/gasket/apex_driver.c | 11 ++-- drivers/staging/gasket/gasket_core.c | 6 ++- drivers/staging/gasket/gasket_core.h

[PATCH 15/32] staging: gasket: drop gasket_cdev_get_info, use container_of

From: Todd Poynor Remove gasket_cdev_get_info(), use container_of() directly instead, drop unnecessary NULL checks. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 26 -- 1 file changed, 4

[PATCH 00/32 v3] staging: gasket: sundry fixes and fixups

From: Todd Poynor Various fixes mainly from the chromium review of the gasket and apex drivers. More to come. Todd Poynor (32): staging: gasket: remove X86 Kconfig restriction staging: gasket: fix typo in apex_enter_reset staging: gasket: fix typo in gasket_core.h comments staging

[PATCH 05/32] staging: gasket: remove driver registration on class creation failure

From: Todd Poynor If class_create() fails, remove the gasket driver from the global registration table. Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/gasket

[PATCH 05/32] staging: gasket: remove driver registration on class creation failure

From: Todd Poynor If class_create() fails, remove the gasket driver from the global registration table. Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/gasket

[PATCH 04/32] staging: gasket: whitespace fix in gasket_page_table_init

From: Todd Poynor Tab replaced with space. Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_page_table.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gasket/gasket_page_table.c b/drivers/staging/gasket

[PATCH 04/32] staging: gasket: whitespace fix in gasket_page_table_init

From: Todd Poynor Tab replaced with space. Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_page_table.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gasket/gasket_page_table.c b/drivers/staging/gasket

[PATCH 06/32] staging: gasket: hold mutex on gasket driver unregistration

From: Todd Poynor Take the global mutex on driver unregistration updates for proper ordering of updates and consistent access procedures. Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 4 1 file changed, 4 insertions(+) diff --git

[PATCH 06/32] staging: gasket: hold mutex on gasket driver unregistration

From: Todd Poynor Take the global mutex on driver unregistration updates for proper ordering of updates and consistent access procedures. Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 4 1 file changed, 4 insertions(+) diff --git

Re: [PATCH 12/32] staging: gasket: gasket_wait_with_reschedule return when condition hit

On Tue, Jul 17, 2018 at 4:12 AM, Dan Carpenter wrote: > On Tue, Jul 17, 2018 at 01:13:29PM +0300, Dan Carpenter wrote: >> On Mon, Jul 16, 2018 at 07:09:06PM -0700, Todd Poynor wrote: >> > From: Todd Poynor >> > >> > Return right away instead of break out of wh

Re: [PATCH 12/32] staging: gasket: gasket_wait_with_reschedule return when condition hit

On Tue, Jul 17, 2018 at 4:12 AM, Dan Carpenter wrote: > On Tue, Jul 17, 2018 at 01:13:29PM +0300, Dan Carpenter wrote: >> On Mon, Jul 16, 2018 at 07:09:06PM -0700, Todd Poynor wrote: >> > From: Todd Poynor >> > >> > Return right away instead of break out of wh

Re: [PATCH 12/32] staging: gasket: gasket_wait_with_reschedule return when condition hit

On Tue, Jul 17, 2018 at 3:13 AM, Dan Carpenter wrote: > On Mon, Jul 16, 2018 at 07:09:06PM -0700, Todd Poynor wrote: >> From: Todd Poynor >> >> Return right away instead of break out of while and then return. >> > > You could remove the (retries == max_retries

Re: [PATCH 12/32] staging: gasket: gasket_wait_with_reschedule return when condition hit

On Tue, Jul 17, 2018 at 3:13 AM, Dan Carpenter wrote: > On Mon, Jul 16, 2018 at 07:09:06PM -0700, Todd Poynor wrote: >> From: Todd Poynor >> >> Return right away instead of break out of while and then return. >> > > You could remove the (retries == max_retries

Re: [PATCH 27/32] staging: gasket: remove else clause after return in if clause

On Tue, Jul 17, 2018 at 3:37 AM, Dan Carpenter wrote: > On Mon, Jul 16, 2018 at 07:09:21PM -0700, Todd Poynor wrote: >> From: Todd Poynor >> >> Else after return is unnecessary and may cause static code checkers to >> complain. >> >> Reported-by: Gue

Re: [PATCH 27/32] staging: gasket: remove else clause after return in if clause

On Tue, Jul 17, 2018 at 3:37 AM, Dan Carpenter wrote: > On Mon, Jul 16, 2018 at 07:09:21PM -0700, Todd Poynor wrote: >> From: Todd Poynor >> >> Else after return is unnecessary and may cause static code checkers to >> complain. >> >> Reported-by: Gue

Re: [PATCH 16/32] staging: gasket: always allow root open for write

On Tue, Jul 17, 2018 at 11:50 AM, Joe Perches wrote: > On Tue, 2018-07-17 at 13:22 +0300, Dan Carpenter wrote: >> On Mon, Jul 16, 2018 at 07:09:10PM -0700, Todd Poynor wrote: >> > --- a/drivers/staging/gasket/apex_driver.c >> > +++ b/drivers/staging/gasket/apex_drive

Re: [PATCH 16/32] staging: gasket: always allow root open for write

On Tue, Jul 17, 2018 at 11:50 AM, Joe Perches wrote: > On Tue, 2018-07-17 at 13:22 +0300, Dan Carpenter wrote: >> On Mon, Jul 16, 2018 at 07:09:10PM -0700, Todd Poynor wrote: >> > --- a/drivers/staging/gasket/apex_driver.c >> > +++ b/drivers/staging/gasket/apex_drive

Re: [PATCH 17/32] staging: gasket: annotate ioctl arg with __user

On Tue, Jul 17, 2018 at 3:26 AM, Dan Carpenter wrote: > On Mon, Jul 16, 2018 at 07:09:11PM -0700, Todd Poynor wrote: >> @@ -629,7 +630,6 @@ static bool is_gcb_in_reset(struct gasket_dev >> *gasket_dev) >> */ >> static uint apex_ioctl_check_permissions(

Re: [PATCH 17/32] staging: gasket: annotate ioctl arg with __user

On Tue, Jul 17, 2018 at 3:26 AM, Dan Carpenter wrote: > On Mon, Jul 16, 2018 at 07:09:11PM -0700, Todd Poynor wrote: >> @@ -629,7 +630,6 @@ static bool is_gcb_in_reset(struct gasket_dev >> *gasket_dev) >> */ >> static uint apex_ioctl_check_permissions(

Re: [PATCH 00/32 v2] staging: gasket: sundry fixes and fixups

On Tue, Jul 17, 2018 at 4:25 AM Todd Poynor wrote: > > On Tue, Jul 17, 2018 at 4:16 AM Greg Kroah-Hartman > wrote: > > > > On Mon, Jul 16, 2018 at 07:08:54PM -0700, Todd Poynor wrote: > > > From: Todd Poynor > > > > > > Various fixes mainly

Re: [PATCH 00/32 v2] staging: gasket: sundry fixes and fixups

On Tue, Jul 17, 2018 at 4:25 AM Todd Poynor wrote: > > On Tue, Jul 17, 2018 at 4:16 AM Greg Kroah-Hartman > wrote: > > > > On Mon, Jul 16, 2018 at 07:08:54PM -0700, Todd Poynor wrote: > > > From: Todd Poynor > > > > > > Various fixes mainly

Re: [PATCH 00/32 v2] staging: gasket: sundry fixes and fixups

On Tue, Jul 17, 2018 at 4:16 AM Greg Kroah-Hartman wrote: > > On Mon, Jul 16, 2018 at 07:08:54PM -0700, Todd Poynor wrote: > > From: Todd Poynor > > > > Various fixes mainly from the chromium review of the gasket and apex > > drivers. More to come. > > I

Re: [PATCH 00/32 v2] staging: gasket: sundry fixes and fixups

On Tue, Jul 17, 2018 at 4:16 AM Greg Kroah-Hartman wrote: > > On Mon, Jul 16, 2018 at 07:08:54PM -0700, Todd Poynor wrote: > > From: Todd Poynor > > > > Various fixes mainly from the chromium review of the gasket and apex > > drivers. More to come. > > What c

<    1   2   3   4   5   6   7   8   >