Re: [bisected] 5.12-rc1 hpsa regression: "scsi: hpsa: Correct dev cmds outstanding for retried cmds" breaks hpsa P600

2021-03-05 Thread Tomas Henzl
On 3/4/21 6:00 PM, don.br...@microchip.com wrote: > -Original Message- > From: Sergei Trofimovich [mailto:sly...@gmail.com] > Sent: Wednesday, March 3, 2021 4:04 PM > To: Don Brace - C33706 > Cc: glaub...@physik.fu-berlin.de; storagedev ; > linux-s...@vger.kernel.org;

Re: [PATCH 10/10] mpt3sas: Bump mpt3sas driver version to v16.100.00.00

2017-10-11 Thread Tomas Henzl
On 10/10/2017 03:11 PM, Sreekanth Reddy wrote: > Bump mpt3sas driver version to v16.100.00.00 > > Signed-off-by: Sreekanth Reddy <sreekanth.re...@broadcom.com> Reviewed-by: Tomas Henzl <the...@redhat.com> Tomas

Re: [PATCH 10/10] mpt3sas: Bump mpt3sas driver version to v16.100.00.00

2017-10-11 Thread Tomas Henzl
On 10/10/2017 03:11 PM, Sreekanth Reddy wrote: > Bump mpt3sas driver version to v16.100.00.00 > > Signed-off-by: Sreekanth Reddy Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 09/10] mpt3sas: Adding support for SAS3616 HBA device

2017-10-11 Thread Tomas Henzl
On 10/10/2017 03:11 PM, Sreekanth Reddy wrote: > Adding PNP ID of Mercator i.e. SAS3616 HBA device. > Its device ID is 0xD1 and vendor ID is 0x1000. > > Signed-off-by: Sreekanth Reddy <sreekanth.re...@broadcom.com> Reviewed-by: Tomas Henzl <the...@redhat.com> Tomas

Re: [PATCH 09/10] mpt3sas: Adding support for SAS3616 HBA device

2017-10-11 Thread Tomas Henzl
On 10/10/2017 03:11 PM, Sreekanth Reddy wrote: > Adding PNP ID of Mercator i.e. SAS3616 HBA device. > Its device ID is 0xD1 and vendor ID is 0x1000. > > Signed-off-by: Sreekanth Reddy Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 04/10] mpt3sas: Fix removal and addition of vSES device during host reset

2017-10-11 Thread Tomas Henzl
On 10/11/2017 05:56 PM, James Bottomley wrote: > On Wed, 2017-10-11 at 17:35 +0200, Tomas Henzl wrote: >> On 10/10/2017 03:11 PM, Sreekanth Reddy wrote: >>> For Dev Handles who value is less than hba's phys count number >>>  driver will return HBA sas address val

Re: [PATCH 04/10] mpt3sas: Fix removal and addition of vSES device during host reset

2017-10-11 Thread Tomas Henzl
On 10/11/2017 05:56 PM, James Bottomley wrote: > On Wed, 2017-10-11 at 17:35 +0200, Tomas Henzl wrote: >> On 10/10/2017 03:11 PM, Sreekanth Reddy wrote: >>> For Dev Handles who value is less than hba's phys count number >>>  driver will return HBA sas address val

Re: [PATCH 08/10] mpt3sas: Fix possibility of using invalid Enclosure Handles for SAS device after host reset

2017-10-11 Thread Tomas Henzl
> > Modified the driver to update devices enclosure handles after > host reset to current value, by referring the enclosure handles > from corresponding device pages > > Signed-off-by: Sreekanth Reddy <sreekanth.re...@broadcom.com> Reviewed-by: Tomas Henzl <the...@redhat.com>

Re: [PATCH 08/10] mpt3sas: Fix possibility of using invalid Enclosure Handles for SAS device after host reset

2017-10-11 Thread Tomas Henzl
> > Modified the driver to update devices enclosure handles after > host reset to current value, by referring the enclosure handles > from corresponding device pages > > Signed-off-by: Sreekanth Reddy Reviewed-by: Tomas Henzl

Re: [PATCH 08/10] mpt3sas: Fix possibility of using invalid Enclosure Handles for SAS device after host reset

2017-10-11 Thread Tomas Henzl
Mpi2SasDevicePage0_t *sas_device_pg0, struct _sas_device *sas_device) > +{ > + Mpi2ConfigReply_t mpi_reply; > + Mpi2SasEnclosurePage0_t enclosure_pg0; > + > + if (!sas_device_pg0 || !sas_device) > + return; This test^ implies that sas_device_pg0 or sas_device can be null, is that true? Signed-off-by: Tomas Henzl <the...@redhat.com>

Re: [PATCH 08/10] mpt3sas: Fix possibility of using invalid Enclosure Handles for SAS device after host reset

2017-10-11 Thread Tomas Henzl
0, struct _sas_device *sas_device) > +{ > + Mpi2ConfigReply_t mpi_reply; > + Mpi2SasEnclosurePage0_t enclosure_pg0; > + > + if (!sas_device_pg0 || !sas_device) > + return; This test^ implies that sas_device_pg0 or sas_device can be null, is that true? Signed-off-by: Tomas Henzl

Re: [PATCH 07/10] mpt3sas: Display chassis slot information of the drive

2017-10-11 Thread Tomas Henzl
f-by: Sreekanth Reddy <sreekanth.re...@broadcom.com> Signed-off-by: Tomas Henzl <the...@redhat.com> Tomas

Re: [PATCH 07/10] mpt3sas: Display chassis slot information of the drive

2017-10-11 Thread Tomas Henzl
f-by: Sreekanth Reddy Signed-off-by: Tomas Henzl Tomas

Re: [PATCH 06/10] mpt3sas: Updated MPI headers to v2.00.48

2017-10-11 Thread Tomas Henzl
On 10/10/2017 03:11 PM, Sreekanth Reddy wrote: > Updated MPI headers to v2.00.48 > > Signed-off-by: Sreekanth Reddy <sreekanth.re...@broadcom.com> Signed-off-by: Tomas Henzl <the...@redhat.com> Tomas

Re: [PATCH 06/10] mpt3sas: Updated MPI headers to v2.00.48

2017-10-11 Thread Tomas Henzl
On 10/10/2017 03:11 PM, Sreekanth Reddy wrote: > Updated MPI headers to v2.00.48 > > Signed-off-by: Sreekanth Reddy Signed-off-by: Tomas Henzl Tomas

Re: [PATCH 05/10] mpt3sas: Fix IO error occurs on pulling out a drive from RAID1 volume created on two SATA drive

2017-10-11 Thread Tomas Henzl
quot;DID_RESET" > (i.e. retry the IO infinite times) host bytes. > > Earlier driver is returning the IO with "DID_SOFT_ERROR" > that reties the IO quickly for five times but still > firmware needed some more time and hence IOs were failing. > > Signed-off-by: S

Re: [PATCH 05/10] mpt3sas: Fix IO error occurs on pulling out a drive from RAID1 volume created on two SATA drive

2017-10-11 Thread Tomas Henzl
quot;DID_RESET" > (i.e. retry the IO infinite times) host bytes. > > Earlier driver is returning the IO with "DID_SOFT_ERROR" > that reties the IO quickly for five times but still > firmware needed some more time and hence IOs were failing. > > Signed-off-by: Sreekanth Reddy Signed-off-by: Tomas Henzl Tomas

Re: [PATCH 04/10] mpt3sas: Fix removal and addition of vSES device during host reset

2017-10-11 Thread Tomas Henzl
now updated the driver to return > Virtual SES's sas address for Virtual SES device instead of > HBA's sas address. > > Signed-off-by: Sreekanth Reddy <sreekanth.re...@broadcom.com> Signed-off-by: Tomas Henzl <the...@redhat.com>

Re: [PATCH 04/10] mpt3sas: Fix removal and addition of vSES device during host reset

2017-10-11 Thread Tomas Henzl
now updated the driver to return > Virtual SES's sas address for Virtual SES device instead of > HBA's sas address. > > Signed-off-by: Sreekanth Reddy Signed-off-by: Tomas Henzl

Re: [PATCH 03/10] mpt3sas: Reduce memory footprints in kdump kernel

2017-10-11 Thread Tomas Henzl
ult. > 4) Set SCSI IO Queue depth to 200. > > Signed-off-by: Sreekanth Reddy <sreekanth.re...@broadcom.com> I think that preferred is (though not much used yet) instead of 'reset_devices' to use a 'is_kdump_kernel()' function. Signed-off-by: Tomas Henzl <the...@redhat.com>

Re: [PATCH 03/10] mpt3sas: Reduce memory footprints in kdump kernel

2017-10-11 Thread Tomas Henzl
ult. > 4) Set SCSI IO Queue depth to 200. > > Signed-off-by: Sreekanth Reddy I think that preferred is (though not much used yet) instead of 'reset_devices' to use a 'is_kdump_kernel()' function. Signed-off-by: Tomas Henzl

Re: [PATCH 02/10] mpt3sas: Fixed memory leaks in driver

2017-10-11 Thread Tomas Henzl
> node as NULL and so we are not freeing the child device's > allocated data structures. > Updated the driver to remove the expander device from the list > only after freeing all its child devices. > > Signed-off-by: Sreekanth Reddy <sreekanth.re...@broadcom.com> Signed

Re: [PATCH 02/10] mpt3sas: Fixed memory leaks in driver

2017-10-11 Thread Tomas Henzl
> node as NULL and so we are not freeing the child device's > allocated data structures. > Updated the driver to remove the expander device from the list > only after freeing all its child devices. > > Signed-off-by: Sreekanth Reddy Signed-off-by: Tomas Henzl Tomas

Re: [PATCH 01/10] mpt3sas: Processing of Cable Exception events

2017-10-11 Thread Tomas Henzl
added Cable Exception Event even for SAS3008 & SAS3108 HBAs > (i.e. MPI 2.5 spec supporting HBAs) earlier this event was > enabled only for MPI 2.6 spec supporting HBA devices. > > Signed-off-by: Sreekanth Reddy <sreekanth.re...@broadcom.com> Signed-off-by: Tomas Henzl <the...@redhat.com> Tomas

Re: [PATCH 01/10] mpt3sas: Processing of Cable Exception events

2017-10-11 Thread Tomas Henzl
added Cable Exception Event even for SAS3008 & SAS3108 HBAs > (i.e. MPI 2.5 spec supporting HBAs) earlier this event was > enabled only for MPI 2.6 spec supporting HBA devices. > > Signed-off-by: Sreekanth Reddy Signed-off-by: Tomas Henzl Tomas

Re: [PATCH V6 00/11] megaraid_sas: Updates for scsi-next

2016-12-23 Thread Tomas Henzl
On 23.12.2016 16:24, Tomas Henzl wrote: > On 23.12.2016 02:19, Sasikumar Chandrasekaran wrote: >> Sasikumar Chandrasekaran (11): >> megaraid_sas: Add new pci device Ids for SAS3.5 Generic Megaraid >> Controllers >> megaraid_sas: 128 MSIX Support >> megar

Re: [PATCH V6 00/11] megaraid_sas: Updates for scsi-next

2016-12-23 Thread Tomas Henzl
On 23.12.2016 16:24, Tomas Henzl wrote: > On 23.12.2016 02:19, Sasikumar Chandrasekaran wrote: >> Sasikumar Chandrasekaran (11): >> megaraid_sas: Add new pci device Ids for SAS3.5 Generic Megaraid >> Controllers >> megaraid_sas: 128 MSIX Support >> megar

Re: [PATCH V6 00/11] megaraid_sas: Updates for scsi-next

2016-12-23 Thread Tomas Henzl
On 23.12.2016 02:19, Sasikumar Chandrasekaran wrote: > Sasikumar Chandrasekaran (11): > megaraid_sas: Add new pci device Ids for SAS3.5 Generic Megaraid > Controllers > megaraid_sas: 128 MSIX Support > megaraid_sas: EEDP Escape Mode Support for SAS3.5 Generic Megaraid > Controllers >

Re: [PATCH V6 00/11] megaraid_sas: Updates for scsi-next

2016-12-23 Thread Tomas Henzl
On 23.12.2016 02:19, Sasikumar Chandrasekaran wrote: > Sasikumar Chandrasekaran (11): > megaraid_sas: Add new pci device Ids for SAS3.5 Generic Megaraid > Controllers > megaraid_sas: 128 MSIX Support > megaraid_sas: EEDP Escape Mode Support for SAS3.5 Generic Megaraid > Controllers >

Re: [PATCH V6 10/11] megaraid_sas: Implement the PD Map support for SAS3.5 Generic Megaraid Controllers

2016-12-23 Thread Tomas Henzl
On 23.12.2016 02:19, Sasikumar Chandrasekaran wrote: > Update Linux driver to use new pdTargetId field for JBOD target ID > > This patch is depending on patch 9 and same as V5 > > Signed-off-by: Sasikumar Chandrasekaran <sasikumar...@broadcom.com> Reviewed-by: Tomas Henzl <the...@redhat.com>

Re: [PATCH V6 10/11] megaraid_sas: Implement the PD Map support for SAS3.5 Generic Megaraid Controllers

2016-12-23 Thread Tomas Henzl
On 23.12.2016 02:19, Sasikumar Chandrasekaran wrote: > Update Linux driver to use new pdTargetId field for JBOD target ID > > This patch is depending on patch 9 and same as V5 > > Signed-off-by: Sasikumar Chandrasekaran Reviewed-by: Tomas Henzl

Re: [PATCH V6 08/11] megaraid_sas: Enable or Disable Fast path based on the PCI Threshold Bandwidth

2016-12-23 Thread Tomas Henzl
asikumar...@broadcom.com> Reviewed-by: Tomas Henzl <the...@redhat.com>

Re: [PATCH V6 08/11] megaraid_sas: Enable or Disable Fast path based on the PCI Threshold Bandwidth

2016-12-23 Thread Tomas Henzl
On 23.12.2016 02:19, Sasikumar Chandrasekaran wrote: > Large SEQ IO workload should sent as non fast path commands > > This patch is depending on patch 7 > > 80 chars per line limit is taken care around VD_EXT_DEBUG macro. > > Signed-off-by: Sasikumar Chandrasekaran Reviewed-by: Tomas Henzl

Re: [PATCH V6 06/11] megaraid_sas: Dynamic Raid Map Changes for SAS3.5 Generic Megaraid Controllers

2016-12-23 Thread Tomas Henzl
e around VD_EXT_DEBUG macro. > NULL pointer check for desc_table has been removed. > Few code indentation issues fixed. > > Signed-off-by: Sasikumar Chandrasekaran <sasikumar...@broadcom.com> Reviewed-by: Tomas Henzl <the...@redhat.com>

Re: [PATCH V6 06/11] megaraid_sas: Dynamic Raid Map Changes for SAS3.5 Generic Megaraid Controllers

2016-12-23 Thread Tomas Henzl
e around VD_EXT_DEBUG macro. > NULL pointer check for desc_table has been removed. > Few code indentation issues fixed. > > Signed-off-by: Sasikumar Chandrasekaran Reviewed-by: Tomas Henzl

Re: [PATCH V6 02/11] megaraid_sas: 128 MSIX Support

2016-12-23 Thread Tomas Henzl
ikumar Chandrasekaran <sasikumar...@broadcom.com> Reviewed-by: Tomas Henzl <the...@redhat.com>

Re: [PATCH V6 02/11] megaraid_sas: 128 MSIX Support

2016-12-23 Thread Tomas Henzl
ikumar Chandrasekaran Reviewed-by: Tomas Henzl

Re: [PATCH V4 08/11] megaraid_sas: Enable or Disable Fast path based on the PCI Threshold Bandwidth

2016-12-20 Thread Tomas Henzl
On 20.12.2016 02:51, Sasikumar PC wrote: > Hi Tomas, > > Please see my response inline > > Thanks > sasi > > -Original Message- > From: Tomas Henzl [mailto:the...@redhat.com] > Sent: Thursday, December 15, 2016 10:10 AM > To: Sasikumar PC; j...@kernel.org;

Re: [PATCH V4 08/11] megaraid_sas: Enable or Disable Fast path based on the PCI Threshold Bandwidth

2016-12-20 Thread Tomas Henzl
On 20.12.2016 02:51, Sasikumar PC wrote: > Hi Tomas, > > Please see my response inline > > Thanks > sasi > > -Original Message- > From: Tomas Henzl [mailto:the...@redhat.com] > Sent: Thursday, December 15, 2016 10:10 AM > To: Sasikumar PC; j...@kernel.org;

Re: [PATCH V4 06/11] megaraid_sas: Dynamic Raid Map Changes for SAS3.5 Generic Megaraid Controllers

2016-12-20 Thread Tomas Henzl
On 20.12.2016 02:51, Sasikumar PC wrote: > Hi Tomas, > > Please see my response inline > > Thanks > sasi > > -Original Message- > From: Sasikumar PC [mailto:sasikumar...@broadcom.com] > Sent: Wednesday, December 14, 2016 4:49 PM > To: 'Tomas Henzl'; 'j...

Re: [PATCH V4 06/11] megaraid_sas: Dynamic Raid Map Changes for SAS3.5 Generic Megaraid Controllers

2016-12-20 Thread Tomas Henzl
On 20.12.2016 02:51, Sasikumar PC wrote: > Hi Tomas, > > Please see my response inline > > Thanks > sasi > > -Original Message- > From: Sasikumar PC [mailto:sasikumar...@broadcom.com] > Sent: Wednesday, December 14, 2016 4:49 PM > To: 'Tomas Henzl'; 'j...

Re: [PATCH V4 02/11] megaraid_sas: 128 MSIX Support

2016-12-20 Thread Tomas Henzl
On 20.12.2016 02:50, Sasikumar PC wrote: > Hi Tomas, > > Please see my response inline > > Thanks > sasi > > -Original Message- > From: Sasikumar PC [mailto:sasikumar...@broadcom.com] > Sent: Wednesday, December 14, 2016 4:43 PM > To: 'Tomas Henzl'; 'j...

Re: [PATCH V4 02/11] megaraid_sas: 128 MSIX Support

2016-12-20 Thread Tomas Henzl
On 20.12.2016 02:50, Sasikumar PC wrote: > Hi Tomas, > > Please see my response inline > > Thanks > sasi > > -Original Message- > From: Sasikumar PC [mailto:sasikumar...@broadcom.com] > Sent: Wednesday, December 14, 2016 4:43 PM > To: 'Tomas Henzl'; 'j...

Re: [PATCH V5 00/11] megaraid_sas: Updates for scsi-next

2016-12-15 Thread Tomas Henzl
On 14.12.2016 23:12, Sasikumar Chandrasekaran wrote: > Sasikumar Chandrasekaran (11): > megaraid_sas: Add new pci device Ids for SAS3.5 Generic Megaraid > Controllers > megaraid_sas: 128 MSIX Support > megaraid_sas: EEDP Escape Mode Support for SAS3.5 Generic Megaraid > Controllers >

Re: [PATCH V5 00/11] megaraid_sas: Updates for scsi-next

2016-12-15 Thread Tomas Henzl
On 14.12.2016 23:12, Sasikumar Chandrasekaran wrote: > Sasikumar Chandrasekaran (11): > megaraid_sas: Add new pci device Ids for SAS3.5 Generic Megaraid > Controllers > megaraid_sas: 128 MSIX Support > megaraid_sas: EEDP Escape Mode Support for SAS3.5 Generic Megaraid > Controllers >

Re: [PATCH V5 08/11] megaraid_sas: Enable or Disable Fast path based on the PCI Threshold Bandwidth

2016-12-15 Thread Tomas Henzl
On 14.12.2016 23:13, Sasikumar Chandrasekaran wrote: > Large SEQ IO workload should sent as non fast path commands > > This patch is depending on patch 7 > This patch is same as V4 and there is no specific update for V5 That means, that you have ignored my question regarding 'bytes_wrote' I asked

Re: [PATCH V5 08/11] megaraid_sas: Enable or Disable Fast path based on the PCI Threshold Bandwidth

2016-12-15 Thread Tomas Henzl
On 14.12.2016 23:13, Sasikumar Chandrasekaran wrote: > Large SEQ IO workload should sent as non fast path commands > > This patch is depending on patch 7 > This patch is same as V4 and there is no specific update for V5 That means, that you have ignored my question regarding 'bytes_wrote' I asked

Re: [PATCH V4 08/11] megaraid_sas: Enable or Disable Fast path based on the PCI Threshold Bandwidth

2016-12-15 Thread Tomas Henzl
On 14.12.2016 22:54, Sasikumar PC wrote: > Hi Tomas, > > Please see my response inline > > Thanks > sasi > > -Original Message- > From: Tomas Henzl [mailto:the...@redhat.com] > Sent: Friday, December 09, 2016 8:59 AM > To: Sasikumar Chandrasekaran; j...@ke

Re: [PATCH V4 08/11] megaraid_sas: Enable or Disable Fast path based on the PCI Threshold Bandwidth

2016-12-15 Thread Tomas Henzl
On 14.12.2016 22:54, Sasikumar PC wrote: > Hi Tomas, > > Please see my response inline > > Thanks > sasi > > -Original Message- > From: Tomas Henzl [mailto:the...@redhat.com] > Sent: Friday, December 09, 2016 8:59 AM > To: Sasikumar Chandrasekaran; j...@ke

Re: [PATCH V5 06/11] megaraid_sas: Dynamic Raid Map Changes for SAS3.5 Generic Megaraid Controllers

2016-12-15 Thread Tomas Henzl
On 14.12.2016 23:13, Sasikumar Chandrasekaran wrote: > SAS3.5 Generic Megaraid Controllers FW will support new dynamic RaidMap to > have different > sizes for different number of supported VDs. > > This patch is depending on patch 5 > Code indentation is fixed for VD_EXT_DEBUG macro > >

Re: [PATCH V5 06/11] megaraid_sas: Dynamic Raid Map Changes for SAS3.5 Generic Megaraid Controllers

2016-12-15 Thread Tomas Henzl
On 14.12.2016 23:13, Sasikumar Chandrasekaran wrote: > SAS3.5 Generic Megaraid Controllers FW will support new dynamic RaidMap to > have different > sizes for different number of supported VDs. > > This patch is depending on patch 5 > Code indentation is fixed for VD_EXT_DEBUG macro > >

Re: [PATCH V5 04/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Stream Detection and IO Coalescing

2016-12-15 Thread Tomas Henzl
pace changes (for example a non-ascii char has been removed). Other then the indentation is still not correct - see in text. I haven't found any other important issues so ok. > > Signed-off-by: Sasikumar Chandrasekaran <sasikumar...@broadcom.com> > Reviewed-by: Tomas Henzl <the...@red

Re: [PATCH V5 04/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Stream Detection and IO Coalescing

2016-12-15 Thread Tomas Henzl
pace changes (for example a non-ascii char has been removed). Other then the indentation is still not correct - see in text. I haven't found any other important issues so ok. > > Signed-off-by: Sasikumar Chandrasekaran > Reviewed-by: Tomas Henzl > --- > drivers/scsi/megaraid/megaraid_sas.

Re: [PATCH V4 04/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Stream Detection and IO Coalescing

2016-12-12 Thread Tomas Henzl
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote: > Detect sequential IO streams and pass those IOs directly to FW. > > This patch is depending on patch 3 > > Signed-off-by: Sasikumar Chandrasekaran > --- > drivers/scsi/megaraid/megaraid_sas.h| 5 +- >

Re: [PATCH V4 04/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Stream Detection and IO Coalescing

2016-12-12 Thread Tomas Henzl
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote: > Detect sequential IO streams and pass those IOs directly to FW. > > This patch is depending on patch 3 > > Signed-off-by: Sasikumar Chandrasekaran > --- > drivers/scsi/megaraid/megaraid_sas.h| 5 +- >

Re: [PATCH V4 10/11] megaraid_sas: Implement the PD Map support for SAS3.5 Generic Megaraid Controllers

2016-12-09 Thread Tomas Henzl
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote: > Update Linux driver to use new pdTargetId field for JBOD target ID > > This patch is depending on patch 9 > > Signed-off-by: Sasikumar Chandrasekaran <sasikumar...@broadcom.com> Reviewed-by: Tomas Henzl <the...@redhat.com> Tomas

Re: [PATCH V4 11/11] megaraid_sas: driver version upgrade

2016-12-09 Thread Tomas Henzl
t;07.700.00.00-rc1" > +#define MEGASAS_RELDATE "November 29, 2016" > > /* > * Device IDs Reviewed-by: Tomas Henzl <the...@redhat.com> Tomas

Re: [PATCH V4 10/11] megaraid_sas: Implement the PD Map support for SAS3.5 Generic Megaraid Controllers

2016-12-09 Thread Tomas Henzl
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote: > Update Linux driver to use new pdTargetId field for JBOD target ID > > This patch is depending on patch 9 > > Signed-off-by: Sasikumar Chandrasekaran Reviewed-by: Tomas Henzl Tomas

Re: [PATCH V4 11/11] megaraid_sas: driver version upgrade

2016-12-09 Thread Tomas Henzl
AS_RELDATE "November 29, 2016" > > /* > * Device IDs Reviewed-by: Tomas Henzl Tomas

Re: [PATCH V4 09/11] megaraid_sas: ldio_outstanding variable is not decremented in completion path

2016-12-09 Thread Tomas Henzl
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote: > ldio outstanding variable needs to be decremented in io completion path for > iMR dual queue depth > > This patch is depending on patch 8 > > Signed-off-by: Sasikumar Chandrasekaran <sasikumar...@broadcom.com>

Re: [PATCH V4 09/11] megaraid_sas: ldio_outstanding variable is not decremented in completion path

2016-12-09 Thread Tomas Henzl
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote: > ldio outstanding variable needs to be decremented in io completion path for > iMR dual queue depth > > This patch is depending on patch 8 > > Signed-off-by: Sasikumar Chandrasekaran Reviewed-by: Tomas Henzl Tomas

Re: [PATCH V4 08/11] megaraid_sas: Enable or Disable Fast path based on the PCI Threshold Bandwidth

2016-12-09 Thread Tomas Henzl
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote: > Large SEQ IO workload should sent as non fast path commands > > This patch is depending on patch 7 > > Signed-off-by: Sasikumar Chandrasekaran > --- > drivers/scsi/megaraid/megaraid_sas.h| 8 + >

Re: [PATCH V4 08/11] megaraid_sas: Enable or Disable Fast path based on the PCI Threshold Bandwidth

2016-12-09 Thread Tomas Henzl
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote: > Large SEQ IO workload should sent as non fast path commands > > This patch is depending on patch 7 > > Signed-off-by: Sasikumar Chandrasekaran > --- > drivers/scsi/megaraid/megaraid_sas.h| 8 + >

Re: [PATCH V4 07/11] megaraid_sas: Add the Support for SAS3.5 Generic Megaraid Controllers Capabilities

2016-12-09 Thread Tomas Henzl
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote: > The Megaraid driver has to support the SAS3.5 Generic Megaraid Controllers > Firmware functionality. > > This patch is depending on patch 6 > > Signed-off-by: Sasikumar Chandrasekaran > --- >

Re: [PATCH V4 07/11] megaraid_sas: Add the Support for SAS3.5 Generic Megaraid Controllers Capabilities

2016-12-09 Thread Tomas Henzl
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote: > The Megaraid driver has to support the SAS3.5 Generic Megaraid Controllers > Firmware functionality. > > This patch is depending on patch 6 > > Signed-off-by: Sasikumar Chandrasekaran > --- > drivers/scsi/megaraid/megaraid_sas_base.c | 53

Re: [PATCH V4 07/11] megaraid_sas: Add the Support for SAS3.5 Generic Megaraid Controllers Capabilities

2016-12-09 Thread Tomas Henzl
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote: > The Megaraid driver has to support the SAS3.5 Generic Megaraid Controllers > Firmware functionality. > > This patch is depending on patch 6 > > Signed-off-by: Sasikumar Chandrasekaran <sasikumar...@broadcom.com>

Re: [PATCH V4 07/11] megaraid_sas: Add the Support for SAS3.5 Generic Megaraid Controllers Capabilities

2016-12-09 Thread Tomas Henzl
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote: > The Megaraid driver has to support the SAS3.5 Generic Megaraid Controllers > Firmware functionality. > > This patch is depending on patch 6 > > Signed-off-by: Sasikumar Chandrasekaran Reviewed-by: Tomas Henzl Tomas

Re: [PATCH V4 06/11] megaraid_sas: Dynamic Raid Map Changes for SAS3.5 Generic Megaraid Controllers

2016-12-09 Thread Tomas Henzl
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote: > SAS3.5 Generic Megaraid Controllers FW will support new dynamic RaidMap to > have different > sizes for different number of supported VDs. > > This patch is depending on patch 5 > > Signed-off-by: Sasikumar Chandrasekaran

Re: [PATCH V4 06/11] megaraid_sas: Dynamic Raid Map Changes for SAS3.5 Generic Megaraid Controllers

2016-12-09 Thread Tomas Henzl
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote: > SAS3.5 Generic Megaraid Controllers FW will support new dynamic RaidMap to > have different > sizes for different number of supported VDs. > > This patch is depending on patch 5 > > Signed-off-by: Sasikumar Chandrasekaran > --- >

Re: [PATCH V4 05/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Fast Path for RAID 1/10 Writes

2016-12-09 Thread Tomas Henzl
n <sasikumar...@broadcom.com> Reviewed-by: Tomas Henzl <the...@redhat.com> Tomas

Re: [PATCH V4 05/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Fast Path for RAID 1/10 Writes

2016-12-09 Thread Tomas Henzl
the OS logical IO) and > wait for > all Write IOs to complete. If any of the Write IOs fail or time out, the IO > will be > re issued to FW as an LD IO so FW can perform the error handling. > > This patch is depending on patch 4 > > Signed-off-by: Sasikumar Chandrasekaran Reviewed-by: Tomas Henzl Tomas

Re: [PATCH V4 04/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Stream Detection and IO Coalescing

2016-12-08 Thread Tomas Henzl
ong on several places, but ok for now. Reviewed-by: Tomas Henzl <the...@redhat.com> Tomas

Re: [PATCH V4 04/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Stream Detection and IO Coalescing

2016-12-08 Thread Tomas Henzl
now. Reviewed-by: Tomas Henzl Tomas

Re: [PATCH V4 03/11] megaraid_sas: EEDP Escape Mode Support for SAS3.5 Generic Megaraid Controllers

2016-12-08 Thread Tomas Henzl
types 1 > and 2. > A value of 3 should be set to disable all PI checks if the Logical Block > Application > Tag is 0x and the Logical Block Reference Tag is 0x for PI type 3. > > This patch is depending on patch 2 > > Signed-off-by: Sasikumar Chandraseka

Re: [PATCH V4 03/11] megaraid_sas: EEDP Escape Mode Support for SAS3.5 Generic Megaraid Controllers

2016-12-08 Thread Tomas Henzl
types 1 > and 2. > A value of 3 should be set to disable all PI checks if the Logical Block > Application > Tag is 0x and the Logical Block Reference Tag is 0x for PI type 3. > > This patch is depending on patch 2 > > Signed-off-by: Sasikumar Chandrasekaran Reviewed-by: Tomas Henzl Tomas

Re: [PATCH V4 02/11] megaraid_sas: 128 MSIX Support

2016-12-08 Thread Tomas Henzl
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote: > SAS3.5 Generic Megaraid based Controllers will have the support for 128 MSI-X > vectors, > resulting in the need to support 128 reply queues > > This patch is depending on patch 1 > > Signed-off-by: Sasikumar Chandrasekaran

Re: [PATCH V4 02/11] megaraid_sas: 128 MSIX Support

2016-12-08 Thread Tomas Henzl
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote: > SAS3.5 Generic Megaraid based Controllers will have the support for 128 MSI-X > vectors, > resulting in the need to support 128 reply queues > > This patch is depending on patch 1 > > Signed-off-by: Sasikumar Chandrasekaran > --- >

Re: [PATCH V4 01/11] megaraid_sas: Add new pci device Ids for SAS3.5 Generic Megaraid Controllers

2016-12-08 Thread Tomas Henzl
panic my machine like the V3. Reviewed-by: Tomas Henzl <the...@redhat.com> Tomas

Re: [PATCH V4 01/11] megaraid_sas: Add new pci device Ids for SAS3.5 Generic Megaraid Controllers

2016-12-08 Thread Tomas Henzl
On 7.12.2016 00:00, Sasikumar Chandrasekaran wrote: > This patch contains new pci device ids for SAS3.5 Generic Megaraid Controllers > > V4: Removed the not supported PCI Device Ids > > Signed-off-by: Sasikumar Chandrasekaran The V4 does not panic my machine like the V3. Rev

Re: [PATCH V3 01/11] megaraid_sas: Add new pci device Ids for SAS3.5 Generic Megaraid Controllers

2016-12-06 Thread Tomas Henzl
On 5.12.2016 17:27, Sasikumar Chandrasekaran wrote: > This patch contains new pci device ids for SAS3.5 Generic Megaraid Controllers > > Signed-off-by: Sasikumar Chandrasekaran > --- > drivers/scsi/megaraid/megaraid_sas.h| 11 ++- >

Re: [PATCH V3 01/11] megaraid_sas: Add new pci device Ids for SAS3.5 Generic Megaraid Controllers

2016-12-06 Thread Tomas Henzl
On 5.12.2016 17:27, Sasikumar Chandrasekaran wrote: > This patch contains new pci device ids for SAS3.5 Generic Megaraid Controllers > > Signed-off-by: Sasikumar Chandrasekaran > --- > drivers/scsi/megaraid/megaraid_sas.h| 11 ++- > drivers/scsi/megaraid/megaraid_sas_base.c |

Re: [PATCH 00/11] Updates for scsi-next

2016-12-02 Thread Tomas Henzl
On 2.12.2016 15:07, Sasikumar Chandrasekaran wrote: > Sasikumar Chandrasekaran (11): > megaraid_sas: Add new pci device Ids for SAS3.5 Generic Megaraid > Controllers > megaraid_sas: 128 MSIX Support > megaraid_sas: EEDP Escape Mode Support for SAS3.5 Generic Megaraid > Controllers >

Re: [PATCH 00/11] Updates for scsi-next

2016-12-02 Thread Tomas Henzl
On 2.12.2016 15:07, Sasikumar Chandrasekaran wrote: > Sasikumar Chandrasekaran (11): > megaraid_sas: Add new pci device Ids for SAS3.5 Generic Megaraid > Controllers > megaraid_sas: 128 MSIX Support > megaraid_sas: EEDP Escape Mode Support for SAS3.5 Generic Megaraid > Controllers >

Re: [PATCH v2] scsi: aic94xx: Add a missing call to kfree

2016-11-28 Thread Tomas Henzl
f-by: Quentin Lambert <lambert.quen...@gmail.com> Looks good, Reviewed-by: Tomas Henzl <the...@redhat.com> Tomas

Re: [PATCH v2] scsi: aic94xx: Add a missing call to kfree

2016-11-28 Thread Tomas Henzl
entin Lambert Looks good, Reviewed-by: Tomas Henzl Tomas

Re: [PATCH] scsi: pmcraid: Add missing resource releases

2016-11-22 Thread Tomas Henzl
ontain > a call to class_destroy. This patch add these calls where they are > missing. > > This issue was found with Hector. > > Signed-off-by: Quentin Lambert <lambert.quen...@gmail.com> Looks good, Reviewed-by: Tomas Henzl <the...@redhat.com> Tomas > > --- > drivers

Re: [PATCH] scsi: pmcraid: Add missing resource releases

2016-11-22 Thread Tomas Henzl
ontain > a call to class_destroy. This patch add these calls where they are > missing. > > This issue was found with Hector. > > Signed-off-by: Quentin Lambert Looks good, Reviewed-by: Tomas Henzl Tomas > > --- > drivers/scsi/pmcraid.c | 10 +++--- >

Re: [PATCH] scsi: aic94xx: Add a missing call to kfree

2016-11-22 Thread Tomas Henzl
On 19.11.2016 18:40, Quentin Lambert wrote: > Most error branches following the call to kzalloc contain > a call to kfree. This patch add these calls where they are > missing. > > This issue was found with Hector. Hi Quentin, most error branches also do set the freed pointer to NULL, please do

Re: [PATCH] scsi: aic94xx: Add a missing call to kfree

2016-11-22 Thread Tomas Henzl
On 19.11.2016 18:40, Quentin Lambert wrote: > Most error branches following the call to kzalloc contain > a call to kfree. This patch add these calls where they are > missing. > > This issue was found with Hector. Hi Quentin, most error branches also do set the freed pointer to NULL, please do

Re: [PATCH 01/10] mpt3sas: Fix for improper info displayed in var log, while blocking or unblocking the device.

2016-10-25 Thread Tomas Henzl
; > Signed-off-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com> > --- Reviewed-by: Tomas Henzl <the...@redhat.com> Tomas

Re: [PATCH 01/10] mpt3sas: Fix for improper info displayed in var log, while blocking or unblocking the device.

2016-10-25 Thread Tomas Henzl
On 20.10.2016 14:20, Suganath Prabu S wrote: > Return value and Device_handle Arguments passed in correct order > to match with its format string. > > Signed-off-by: Chaitra P B > Signed-off-by: Sathya Prakash > Signed-off-by: Suganath Prabu S > --- Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 10/10] mpt3sas: Fix for Endianness issue.

2016-10-25 Thread Tomas Henzl
Suganath Prabu S <suganath-prabu.subram...@broadcom.com> Reviewed-by: Tomas Henzl <the...@redhat.com> Tomas

Re: [PATCH 10/10] mpt3sas: Fix for Endianness issue.

2016-10-25 Thread Tomas Henzl
On 20.10.2016 14:20, Suganath Prabu S wrote: > Use le16_to_cpu only for accessing two byte data provided by controller. > > Signed-off-by: Chaitra P B > Signed-off-by: Sathya Prakash > Signed-off-by: Suganath Prabu S Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 09/10] mpt3sas: Use the new MPI 2.6 32-bit Atomic Request Descriptors for SAS35 devices.

2016-10-25 Thread Tomas Henzl
bu S <suganath-prabu.subram...@broadcom.com> > --- Reviewed-by: Tomas Henzl <the...@redhat.com> Tomas

Re: [PATCH 09/10] mpt3sas: Use the new MPI 2.6 32-bit Atomic Request Descriptors for SAS35 devices.

2016-10-25 Thread Tomas Henzl
On 20.10.2016 14:20, Suganath Prabu S wrote: > Support Atomic Request Descriptors for Ventura/SAS35 devices. > > Signed-off-by: Chaitra P B > Signed-off-by: Sathya Prakash > Signed-off-by: Suganath Prabu S > --- Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 04/10] mpt3sas: Removing unused macro "MPT_DEVICE_TLR_ON"

2016-10-25 Thread Tomas Henzl
ine MFG_PAGE10_HIDE_SSDS_MASK(0x0003) > #define MFG_PAGE10_HIDE_ALL_DISKS(0x00) Reviewed-by: Tomas Henzl <the...@redhat.com> Tomas

Re: [PATCH 02/10] mpt3sas: Fix for incorrect numbers for MSIX vectors enabled when non RDPQ card is enumerated first.

2016-10-25 Thread Tomas Henzl
enumerated first , MSIX vectors enabled > depends on the cards capability. > > Signed-off-by: Chaitra P B <chaitra.basa...@broadcom.com> > Signed-off-by: Sathya Prakash <sathya.prak...@broadcom.com> > Signed-off-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com> Reviewed-by: Tomas Henzl <the...@redhat.com> Tomas

Re: [PATCH 04/10] mpt3sas: Removing unused macro "MPT_DEVICE_TLR_ON"

2016-10-25 Thread Tomas Henzl
@ struct MPT3SAS_TARGET { > * per device private data > */ > #define MPT_DEVICE_FLAGS_INIT0x01 > -#define MPT_DEVICE_TLR_ON0x02 > > #define MFG_PAGE10_HIDE_SSDS_MASK(0x00000003) > #define MFG_PAGE10_HIDE_ALL_DISKS(0x00) Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 02/10] mpt3sas: Fix for incorrect numbers for MSIX vectors enabled when non RDPQ card is enumerated first.

2016-10-25 Thread Tomas Henzl
enumerated first , MSIX vectors enabled > depends on the cards capability. > > Signed-off-by: Chaitra P B > Signed-off-by: Sathya Prakash > Signed-off-by: Suganath Prabu S Reviewed-by: Tomas Henzl Tomas

Re: [PATCH 08/10] mpt3sas: set EEDP-escape-flags for SAS35 devices.

2016-10-25 Thread Tomas Henzl
com> > Signed-off-by: Suganath Prabu S <suganath-prabu.subram...@broadcom.com> Reviewed-by: Tomas Henzl <the...@redhat.com> Tomas

  1   2   3   4   >