Re: [PATCH v5 09/12] media: uvcvideo: Implement UVC_QUIRK_PRIVACY_DURING_STREAM

2021-04-19 Thread Tomasz Figa
On Wed, Dec 23, 2020 at 9:56 PM Ricardo Ribalda wrote: > > Hi again > > On Wed, Dec 23, 2020 at 9:31 AM Ricardo Ribalda wrote: > > > > Hi Laurent > > > > On Wed, Dec 23, 2020 at 9:05 AM Laurent Pinchart > > wrote: > > > > > > Hi Ricardo, > > > > > > On Tue, Dec 22, 2020 at 09:04:19PM +0100,

Re: [PATCH v2 2/2] media: staging/intel-ipu3: Fix set_fmt error handling

2021-04-08 Thread Tomasz Figa
alda > --- > drivers/staging/media/ipu3/ipu3-v4l2.c | 25 ++--- > 1 file changed, 14 insertions(+), 11 deletions(-) Reviewed-by: Tomasz Figa Best regards, Tomasz

Re: [PATCH v9 22/22] uvc: use vb2 ioctl and fop helpers

2021-04-01 Thread Tomasz Figa
Hi Ricardo, On Fri, Mar 26, 2021 at 7:00 PM Ricardo Ribalda wrote: > > From: Hans Verkuil > > When uvc was written the vb2 ioctl and file operation helpers didn't exist. > > This patch switches uvc over to those helpers, which removes a lot of > boilerplate > code and simplifies

Re: [PATCH 0/8] videobuf2: support new noncontiguous DMA API

2021-03-24 Thread Tomasz Figa
de/media/videobuf2-core.h| 57 +++--- > include/uapi/linux/videodev2.h| 13 +- > 13 files changed, 396 insertions(+), 179 deletions(-) > > -- > 2.30.1.766.gb4fecdf3b7-goog > Just some minor nits for patch 8. Otherwise, with Hans's comments addressed: Acked-by: Tomasz Figa Thanks for the great job. Best regards, Tomasz

Re: [PATCH 8/8] videobuf2: handle non-contiguous DMA allocations

2021-03-24 Thread Tomasz Figa
On Tue, Mar 02, 2021 at 09:46:24AM +0900, Sergey Senozhatsky wrote: > This adds support for new noncontiguous DMA API, which > requires allocators to have two execution branches: one > for the current API, and one for the new one. > > Signed-off-by: Sergey Senozhatsky > [hch: untested conversion

Re: [PATCHv3 5/6] media: uvcvideo: add UVC 1.5 ROI control

2021-03-23 Thread Tomasz Figa
On Wed, Mar 24, 2021 at 11:52 AM Sergey Senozhatsky wrote: > > On (21/03/24 11:34), Tomasz Figa wrote: > > On Wed, Mar 24, 2021 at 11:31 AM Sergey Senozhatsky > > wrote: > [..] > > > > Adjusting the rectangle to something supported by the hardware is > > &

Re: [PATCHv3 5/6] media: uvcvideo: add UVC 1.5 ROI control

2021-03-23 Thread Tomasz Figa
On Wed, Mar 24, 2021 at 11:31 AM Sergey Senozhatsky wrote: > > On (21/03/24 11:14), Tomasz Figa wrote: > > > > > +static int uvc_ioctl_s_roi(struct file *file, void *fh, > > > > > + struct v4l2_selection *sel) > > > > &

Re: [PATCHv3 5/6] media: uvcvideo: add UVC 1.5 ROI control

2021-03-23 Thread Tomasz Figa
On Wed, Mar 24, 2021 at 11:01 AM Sergey Senozhatsky wrote: > > On (21/03/23 17:16), Ricardo Ribalda wrote: > [..] > > > +static bool validate_roi_bounds(struct uvc_streaming *stream, > > > + struct v4l2_selection *sel) > > > +{ > > > + if (sel->r.left >

Re: [PATCH] media: venus: use contig vb2 ops

2021-03-01 Thread Tomasz Figa
On Mon, Mar 1, 2021 at 7:22 PM Stanimir Varbanov wrote: > > > > On 3/1/21 11:23 AM, Tomasz Figa wrote: > > Hi Alex, Stanimir, > > > > On Wed, Dec 16, 2020 at 12:15 PM Tomasz Figa wrote: > >> > >> On Wed, Dec 16, 2020 at 4:21 AM Nicolas Dufresne &

Re: [PATCH] media: venus: use contig vb2 ops

2021-03-01 Thread Tomasz Figa
Hi Alex, Stanimir, On Wed, Dec 16, 2020 at 12:15 PM Tomasz Figa wrote: > > On Wed, Dec 16, 2020 at 4:21 AM Nicolas Dufresne wrote: > > > > Le mardi 15 décembre 2020 à 15:54 +0200, Stanimir Varbanov a écrit : > > > Hi Tomasz, > > > > > > On 12/15/

Re: [PATCH 6/7] dma-iommu: implement ->alloc_noncontiguous

2021-02-16 Thread Tomasz Figa
Hi Christoph On Tue, Feb 2, 2021 at 6:51 PM Christoph Hellwig wrote: > > Implement support for allocating a non-contiguous DMA region. > > Signed-off-by: Christoph Hellwig > --- > drivers/iommu/dma-iommu.c | 35 +++ > 1 file changed, 35 insertions(+) > > diff

Re: [PATCH v5 06/27] dt-bindings: mediatek: Add binding for mt8192 IOMMU

2021-02-09 Thread Tomasz Figa
On Mon, Feb 1, 2021 at 7:44 PM Robin Murphy wrote: > > On 2021-01-29 11:45, Tomasz Figa wrote: > > On Mon, Jan 25, 2021 at 4:34 PM Yong Wu wrote: > >> > >> On Mon, 2021-01-25 at 13:18 +0900, Tomasz Figa wrote: > >>> On Wed, Jan 20, 2021 at 4:08 PM Yong W

Re: add a new dma_alloc_noncontiguous API v2

2021-02-08 Thread Tomasz Figa
Hi Christoph, On Mon, Feb 8, 2021 at 3:49 AM Christoph Hellwig wrote: > > Any comments? > Sorry for the delay. The whole series looks very good to me. Thanks a lot. Reviewed-by: Tomasz Figa Best regards, Tomasz > On Tue, Feb 02, 2021 at 10:51:03AM +0100, Christoph Hellwig wrote

Re: [PATCH v5 06/27] dt-bindings: mediatek: Add binding for mt8192 IOMMU

2021-01-24 Thread Tomasz Figa
On Wed, Jan 20, 2021 at 4:08 PM Yong Wu wrote: > > On Wed, 2021-01-20 at 13:15 +0900, Tomasz Figa wrote: > > On Wed, Jan 13, 2021 at 3:45 PM Yong Wu wrote: > > > > > > On Wed, 2021-01-13 at 14:30 +0900, Tomasz Figa wrote: > > > > On T

Re: [PATCH v5 06/27] dt-bindings: mediatek: Add binding for mt8192 IOMMU

2021-01-19 Thread Tomasz Figa
On Wed, Jan 13, 2021 at 3:45 PM Yong Wu wrote: > > On Wed, 2021-01-13 at 14:30 +0900, Tomasz Figa wrote: > > On Thu, Dec 24, 2020 at 8:35 PM Yong Wu wrote: > > > > > > On Wed, 2020-12-23 at 17:18 +0900, Tomasz Figa wrote: > > > > On Wed, Dec 0

Re: [PATCH v5 06/27] dt-bindings: mediatek: Add binding for mt8192 IOMMU

2021-01-12 Thread Tomasz Figa
On Thu, Dec 24, 2020 at 8:35 PM Yong Wu wrote: > > On Wed, 2020-12-23 at 17:18 +0900, Tomasz Figa wrote: > > On Wed, Dec 09, 2020 at 04:00:41PM +0800, Yong Wu wrote: > > > This patch adds decriptions for mt8192 IOMMU and SMI. > > > > > > mt8192 also

Re: [PATCH v5 04/27] dt-bindings: memory: mediatek: Add domain definition

2021-01-12 Thread Tomasz Figa
On Thu, Dec 24, 2020 at 8:27 PM Yong Wu wrote: > > On Wed, 2020-12-23 at 17:15 +0900, Tomasz Figa wrote: > > Hi Yong, > > > > On Wed, Dec 09, 2020 at 04:00:39PM +0800, Yong Wu wrote: > > > In the latest SoC, there are several HW IP require a sepecial iova &g

Re: [RFC PATCH v3 0/6] Restricted DMA

2021-01-12 Thread Tomasz Figa
On Wed, Jan 13, 2021 at 12:56 PM Florian Fainelli wrote: > > > > On 1/12/2021 6:29 PM, Tomasz Figa wrote: > > Hi Florian, > > > > On Wed, Jan 13, 2021 at 3:01 AM Florian Fainelli > > wrote: > >> > >> On 1/11/21 11:48 PM, Claire Chang wrote:

Re: [RFC PATCH v3 0/6] Restricted DMA

2021-01-12 Thread Tomasz Figa
Hi Florian, On Wed, Jan 13, 2021 at 3:01 AM Florian Fainelli wrote: > > On 1/11/21 11:48 PM, Claire Chang wrote: > > On Fri, Jan 8, 2021 at 1:59 AM Florian Fainelli > > wrote: > >> > >> On 1/7/21 9:42 AM, Claire Chang wrote: > >> > Can you explain how ATF gets involved and to what extent

Re: [PATCH v5 2/7] media: v4l2: Add extended buffer operations

2021-01-08 Thread Tomasz Figa
On Wed, Dec 23, 2020 at 9:04 PM Helen Koike wrote: > > Hi Tomasz, > > On 12/21/20 12:13 AM, Tomasz Figa wrote: > > On Thu, Dec 17, 2020 at 10:20 PM Helen Koike > > wrote: > >> > >> Hi Tomasz, > >> > >> Thanks for your comments,

Re: [PATCH v3 6/7] iommu/mediatek: Gather iova in iommu_unmap to achieve tlb sync once

2021-01-08 Thread Tomasz Figa
On Wed, Dec 23, 2020 at 8:00 PM Robin Murphy wrote: > > On 2020-12-23 08:56, Tomasz Figa wrote: > > On Wed, Dec 16, 2020 at 06:36:06PM +0800, Yong Wu wrote: > >> In current iommu_unmap, this code is: > >> > >> iommu_iotlb_gather_init(_gather); > >

Re: [PATCH v3 6/7] iommu/mediatek: Gather iova in iommu_unmap to achieve tlb sync once

2021-01-08 Thread Tomasz Figa
On Wed, Dec 23, 2020 at 8:00 PM Robin Murphy wrote: > > On 2020-12-23 08:56, Tomasz Figa wrote: > > On Wed, Dec 16, 2020 at 06:36:06PM +0800, Yong Wu wrote: > >> In current iommu_unmap, this code is: > >> > >> iommu_iotlb_gather_init(_gather); > >

Re: [PATCH v5 18/27] iommu/mediatek: Add power-domain operation

2021-01-08 Thread Tomasz Figa
On Tue, Dec 29, 2020 at 8:06 PM Yong Wu wrote: > > On Wed, 2020-12-23 at 17:36 +0900, Tomasz Figa wrote: > > On Wed, Dec 09, 2020 at 04:00:53PM +0800, Yong Wu wrote: > > > In the previous SoC, the M4U HW is in the EMI power domain which is > > > always on. the late

Re: [PATCH v2] media: ov8856: Fix Bayer format dependance on mode

2021-01-08 Thread Tomasz Figa
Hi Robert, On Thu, Jan 7, 2021 at 11:21 PM Robert Foss wrote: > > The Bayer GRBG10 mode used for earlier modes 3280x2460 and > 1640x1232 isn't the mode output by the sensor for the > 3264x2448 and 1632x1224 modes. > > Switch from MEDIA_BUS_FMT_SGRBG10_1X10 to MEDIA_BUS_FMT_SBGGR10_1X10 > for

Re: [PATCH v3 6/7] iommu/mediatek: Gather iova in iommu_unmap to achieve tlb sync once

2020-12-23 Thread Tomasz Figa
On Wed, Dec 16, 2020 at 06:36:06PM +0800, Yong Wu wrote: > In current iommu_unmap, this code is: > > iommu_iotlb_gather_init(_gather); > ret = __iommu_unmap(domain, iova, size, _gather); > iommu_iotlb_sync(domain, _gather); > > We could gather the whole iova range in

Re: [PATCH v5 18/27] iommu/mediatek: Add power-domain operation

2020-12-23 Thread Tomasz Figa
On Wed, Dec 09, 2020 at 04:00:53PM +0800, Yong Wu wrote: > In the previous SoC, the M4U HW is in the EMI power domain which is > always on. the latest M4U is in the display power domain which may be > turned on/off, thus we have to add pm_runtime interface for it. > > When the engine work, the

Re: [PATCH v5 17/27] iommu/mediatek: Add pm runtime callback

2020-12-23 Thread Tomasz Figa
On Wed, Dec 09, 2020 at 04:00:52PM +0800, Yong Wu wrote: > This patch adds pm runtime callback. > > In pm runtime case, all the registers backup/restore and bclk are > controlled in the pm_runtime callback, then pm_suspend is not needed in > this case. > > runtime PM is disabled when suspend,

Re: [PATCH v5 16/27] iommu/mediatek: Add device link for smi-common and m4u

2020-12-23 Thread Tomasz Figa
On Wed, Dec 09, 2020 at 04:00:51PM +0800, Yong Wu wrote: > In the lastest SoC, M4U has its special power domain. thus, If the engine > begin to work, it should help enable the power for M4U firstly. > Currently if the engine work, it always enable the power/clocks for > smi-larbs/smi-common. This

Re: [PATCH v5 15/27] iommu/mediatek: Add fail handle for sysfs_add and device_register

2020-12-23 Thread Tomasz Figa
On Wed, Dec 09, 2020 at 04:00:50PM +0800, Yong Wu wrote: > Add fail handle for iommu_device_sysfs_add and iommu_device_register. > > Fixes: b16c0170b53c ("iommu/mediatek: Make use of iommu_device_register > interface") > Signed-off-by: Yong Wu > --- > drivers/iommu/mtk_iommu.c | 13

Re: [PATCH v5 09/27] iommu/io-pgtable-arm-v7s: Extend PA34 for MediaTek

2020-12-23 Thread Tomasz Figa
On Wed, Dec 09, 2020 at 04:00:44PM +0800, Yong Wu wrote: > MediaTek extend the bit5 in lvl1 and lvl2 descriptor as PA34. > > Signed-off-by: Yong Wu > Acked-by: Will Deacon > Reviewed-by: Robin Murphy > --- > drivers/iommu/io-pgtable-arm-v7s.c | 9 +++-- > drivers/iommu/mtk_iommu.c

Re: [PATCH v5 06/27] dt-bindings: mediatek: Add binding for mt8192 IOMMU

2020-12-23 Thread Tomasz Figa
On Wed, Dec 09, 2020 at 04:00:41PM +0800, Yong Wu wrote: > This patch adds decriptions for mt8192 IOMMU and SMI. > > mt8192 also is MTK IOMMU gen2 which uses ARM Short-Descriptor translation > table format. The M4U-SMI HW diagram is as below: > > EMI >

Re: [PATCH v5 04/27] dt-bindings: memory: mediatek: Add domain definition

2020-12-23 Thread Tomasz Figa
Hi Yong, On Wed, Dec 09, 2020 at 04:00:39PM +0800, Yong Wu wrote: > In the latest SoC, there are several HW IP require a sepecial iova > range, mainly CCU and VPU has this requirement. Take CCU as a example, > CCU require its iova locate in the range(0x4000_ ~ 0x43ff_). Is this really a

Re: [PATCH v5 2/7] media: v4l2: Add extended buffer operations

2020-12-20 Thread Tomasz Figa
On Thu, Dec 17, 2020 at 10:20 PM Helen Koike wrote: > > Hi Tomasz, > > Thanks for your comments, I have a few questions below. > > On 12/16/20 12:13 AM, Tomasz Figa wrote: > > On Tue, Dec 15, 2020 at 11:37 PM Helen Koike > > wrote: > >> > >> Hi To

Re: [PATCH] media: venus: use contig vb2 ops

2020-12-15 Thread Tomasz Figa
On Wed, Dec 16, 2020 at 4:21 AM Nicolas Dufresne wrote: > > Le mardi 15 décembre 2020 à 15:54 +0200, Stanimir Varbanov a écrit : > > Hi Tomasz, > > > > On 12/15/20 1:47 PM, Tomasz Figa wrote: > > > On Tue, Dec 15, 2020 at 8:16 PM Stanimir Varbanov

Re: [PATCH v5 2/7] media: v4l2: Add extended buffer operations

2020-12-15 Thread Tomasz Figa
On Tue, Dec 15, 2020 at 11:37 PM Helen Koike wrote: > > Hi Tomasz, > > On 12/14/20 7:46 AM, Tomasz Figa wrote: > > On Fri, Dec 4, 2020 at 4:52 AM Helen Koike > > wrote: > >> > >> Hi, > >> > >> Please see my 2 points be

Re: [PATCH] media: venus: use contig vb2 ops

2020-12-15 Thread Tomasz Figa
x/v5.10.1/source/drivers/iommu/dma-iommu.c#L782 > > > is always enforced. Since the device is supposed to be behind an IOMMU > > this should have little to none practical consequences beyond making the > > driver not rely on a particular behavior of the SG implementat

Re: [PATCH v5 2/7] media: v4l2: Add extended buffer operations

2020-12-15 Thread Tomasz Figa
On Mon, Dec 14, 2020 at 10:24 PM Helen Koike wrote: > > Hi Tomasz, > > Thank you for your comments, > > On 12/14/20 7:36 AM, Tomasz Figa wrote: > > On Tue, Nov 24, 2020 at 5:33 AM Helen Koike > > wrote: > >> > >> Hi Tomasz, > >> > &g

Re: [PATCH] media: venus: use contig vb2 ops

2020-12-15 Thread Tomasz Figa
> is always enforced. Since the device is supposed to be behind an IOMMU > this should have little to none practical consequences beyond making the > driver not rely on a particular behavior of the SG implementation. > > Reported-by: Tomasz Figa > Signed-off-by: Alexandr

Re: [PATCH v5 2/7] media: v4l2: Add extended buffer operations

2020-12-14 Thread Tomasz Figa
On Fri, Dec 4, 2020 at 4:52 AM Helen Koike wrote: > > Hi, > > Please see my 2 points below (about v4l2_ext_buffer and another about > timestamp). > > On 12/3/20 12:11 PM, Hans Verkuil wrote: > > On 23/11/2020 18:40, Helen Koike wrote: > >> > >>

Re: [PATCH v5 2/7] media: v4l2: Add extended buffer operations

2020-12-14 Thread Tomasz Figa
On Fri, Dec 4, 2020 at 12:11 AM Hans Verkuil wrote: > > On 23/11/2020 18:40, Helen Koike wrote: > > > > > > On 11/23/20 12:46 PM, Tomasz Figa wrote: > >> On Tue, Nov 24, 2020 at 12:08 AM Helen Koike > >> wrote: > >>> > >>> Hi Ha

Re: [PATCH v5 2/7] media: v4l2: Add extended buffer operations

2020-12-14 Thread Tomasz Figa
On Tue, Nov 24, 2020 at 5:33 AM Helen Koike wrote: > > Hi Tomasz, > > > On 11/20/20 8:14 AM, Tomasz Figa wrote: > > Hi Helen, > > > > On Tue, Aug 04, 2020 at 04:29:34PM -0300, Helen Koike wrote: > >> From: Hans Verkuil > >> > >> Those

Re: [PATCH v5 1/7] media: v4l2: Extend pixel formats to unify single/multi-planar handling (and more)

2020-12-14 Thread Tomasz Figa
On Thu, Nov 19, 2020 at 10:43 PM Helen Koike wrote: > > > > On 11/19/20 7:08 AM, Helen Koike wrote: > > Hi Tomasz, > > > > On 11/19/20 2:45 AM, Tomasz Figa wrote: > >> On Sat, Nov 14, 2020 at 11:21:26AM -0300, Helen Koike wrote: > >>> Hi Tomasz

Re: [PATCH v5 3/7] media: videobuf2: Expose helpers to implement the _ext_fmt and _ext_buf hooks

2020-12-14 Thread Tomasz Figa
Hi Helen, On Tue, Aug 04, 2020 at 04:29:35PM -0300, Helen Koike wrote: > The VB2 layer is used by a lot of drivers. Patch it to support the > _EXT_PIX_FMT and _EXT_BUF ioctls in order to ease conversion of existing > drivers to these new APIs. > > Note that internally, the VB2 core is now only

Re: [PATCH v3 5/6] media: uvcvideo: Use dma_alloc_noncontiguos API

2020-12-09 Thread Tomasz Figa
On Wed, Dec 9, 2020 at 10:05 PM Robin Murphy wrote: > > On 2020-12-09 11:12, Christoph Hellwig wrote: > > On Tue, Dec 08, 2020 at 01:54:00PM +0900, Tomasz Figa wrote: > >> >From the media perspective, it would be good to have the vmap > >> optional, similarly

Re: [PATCH] media: ov8856: Remove 3280x2464 mode

2020-12-08 Thread Tomasz Figa
ve seen still suggest that only the middle 3264x2448 are active pixels to be output, so this warrants double checking this with Omnivision. Let me see what we can do about this. Best regards, Tomasz > > On Fri, 27 Nov 2020 at 11:26, Tomasz Figa wrote: > > > > On Thu, Nov

Re: [PATCH v3 5/6] media: uvcvideo: Use dma_alloc_noncontiguos API

2020-12-07 Thread Tomasz Figa
Hi Christoph, On Tue, Dec 1, 2020 at 11:49 PM Christoph Hellwig wrote: > > On Tue, Dec 01, 2020 at 12:36:58PM +0900, Sergey Senozhatsky wrote: > > Not that I have any sound experience in this area, but the helper > > probably won't hurt. Do you also plan to add vmap() to that helper > > or

Re: media: i2c: add OV02A10 image sensor driver

2020-12-03 Thread Tomasz Figa
On Fri, Dec 4, 2020 at 11:47 AM Dongchun Zhu wrote: > > Hi Andy, > > On Thu, 2020-12-03 at 20:10 +0200, Andy Shevchenko wrote: > > On Thu, Dec 3, 2020 at 8:03 PM Colin Ian King > > wrote: > > > > > Static analysis on linux-next with Coverity has detected an issue with > > > the following

Re: [PATCH] media: vb2: always set buffer cache sync hints

2020-11-27 Thread Tomasz Figa
On Sat, Nov 28, 2020 at 1:35 AM Sergey Senozhatsky wrote: > > On (20/11/27 15:56), Hans Verkuil wrote: > > Yes. > > > > BTW, wouldn't it be sufficient to change this code to: > > > > if (!q->allow_cache_hints && q->memory != VB2_MEMORY_DMABUF) { > >

Re: [PATCH] media: ov8856: Remove 3280x2464 mode

2020-11-27 Thread Tomasz Figa
On Thu, Nov 26, 2020 at 7:00 PM Robert Foss wrote: > > On Wed, 25 Nov 2020 at 08:32, Tomasz Figa wrote: > > > > Hi Bingbu, > > > > On Wed, Nov 25, 2020 at 1:15 PM Bingbu Cao > > wrote: > > > > > > > > > > > > On 11/24/20

Re: [PATCH] media: ov8856: Remove 3280x2464 mode

2020-11-24 Thread Tomasz Figa
Hi Bingbu, On Wed, Nov 25, 2020 at 1:15 PM Bingbu Cao wrote: > > > > On 11/24/20 6:20 PM, Robert Foss wrote: > > On Tue, 24 Nov 2020 at 10:42, Bingbu Cao wrote: > >> > >> Hi, Robert > >> > >> I remember that the full size of ov8856 image sensor is 3296x2480 and we > >> can get the 3280x2464 >

Re: [PATCH] media: ov8856: Remove 3280x2464 mode

2020-11-24 Thread Tomasz Figa
Hi Robert, On Tue, Nov 17, 2020 at 12:52 AM Robert Foss wrote: > > Remove the 3280x2464 mode as it can't be reproduced and yields > an output resolution of 3264x2448 instead of the desired one. > > Furthermore the 3264x2448 resolution is the highest resolution > that the product brief lists. > >

Re: [PATCH v5 2/7] media: v4l2: Add extended buffer operations

2020-11-23 Thread Tomasz Figa
On Tue, Nov 24, 2020 at 12:08 AM Helen Koike wrote: > > Hi Hans, > > Thank you for your review. > > On 9/9/20 9:27 AM, Hans Verkuil wrote: > > Hi Helen, > > > > Again I'm just reviewing the uAPI. > > > > On 04/08/2020 21:29, Helen Koike wrote: > >> From: Hans Verkuil > >> > >> Those extended

Re: [PATCH v5 7/7] media: docs: add documentation for the Extended API

2020-11-20 Thread Tomasz Figa
On Fri, Nov 20, 2020 at 9:24 PM Hans Verkuil wrote: > > On 20/11/2020 12:06, Tomasz Figa wrote:z > > Hi Helen, > > > > On Tue, Aug 04, 2020 at 04:29:39PM -0300, Helen Koike wrote: > >> Add documentation and update references in current documentation for the >

Re: [PATCH v6 09/17] media/videbuf1|2: Mark follow_pfn usage as unsafe

2020-11-20 Thread Tomasz Figa
u_notifier, without breaking how this all works. The only real fix > >>>>>> is to deprecate userptr support for VM_IO | VM_PFNMAP mappings and > >>>>>> tell everyone to cut over to dma-buf memory sharing for zerocopy. > >>>>>> > >>>>

Re: [PATCH v5 2/7] media: v4l2: Add extended buffer operations

2020-11-20 Thread Tomasz Figa
Hi Helen, On Tue, Aug 04, 2020 at 04:29:34PM -0300, Helen Koike wrote: > From: Hans Verkuil > > Those extended buffer ops have several purpose: > 1/ Fix y2038 issues by converting the timestamp into an u64 counting >the number of ns elapsed since 1970 > 2/ Unify single/multiplanar handling

Re: [PATCH v5 7/7] media: docs: add documentation for the Extended API

2020-11-20 Thread Tomasz Figa
Hi Helen, On Tue, Aug 04, 2020 at 04:29:39PM -0300, Helen Koike wrote: > Add documentation and update references in current documentation for the > Extended API. > Thank you for the patch. Please see my comments inline. > Signed-off-by: Helen Koike > --- > Changes in v5: > - new patch > >

Re: [PATCH v6 09/17] media/videbuf1|2: Mark follow_pfn usage as unsafe

2020-11-20 Thread Tomasz Figa
O | VM_PFNMAP mappings and > >> tell everyone to cut over to dma-buf memory sharing for zerocopy. > >> > >> userptr for normal memory will keep working as-is, this only affects > >> the zerocopy userptr usage enabled in 50ac952d2263 ("[media] > >> vi

Re: [PATCH v5 1/7] media: v4l2: Extend pixel formats to unify single/multi-planar handling (and more)

2020-11-18 Thread Tomasz Figa
On Sat, Nov 14, 2020 at 11:21:26AM -0300, Helen Koike wrote: > Hi Tomasz, > > On 10/2/20 4:49 PM, Tomasz Figa wrote: > > Hi Helen, > > > > On Tue, Aug 04, 2020 at 04:29:33PM -0300, Helen Koike wrote: [snip] > >> +static void v4l_print_ext_pix_for

Re: [PATCH 8/8] WIP: add a dma_alloc_contiguous API

2020-11-10 Thread Tomasz Figa
On Tue, Nov 10, 2020 at 6:33 PM Ricardo Ribalda wrote: > > Hi Christoph > > On Tue, Nov 10, 2020 at 10:25 AM Christoph Hellwig wrote: > > > > On Mon, Nov 09, 2020 at 03:53:55PM +0100, Ricardo Ribalda wrote: > > > Hi Christoph > > > > > > I have started now to give a try to your patchset. Sorry

Re: [PATCH v5 05/15] mm/frame-vector: Use FOLL_LONGTERM

2020-11-02 Thread Tomasz Figa
On Fri, Oct 30, 2020 at 3:38 PM Daniel Vetter wrote: > > On Fri, Oct 30, 2020 at 3:11 PM Tomasz Figa wrote: > > > > On Fri, Oct 30, 2020 at 11:08 AM Daniel Vetter > > wrote: > > > > > > This is used by media/videbuf2 for persistent dma mappings,

Re: [PATCH v5 05/15] mm/frame-vector: Use FOLL_LONGTERM

2020-10-30 Thread Tomasz Figa
gned-off-by: Daniel Vetter > Cc: Jason Gunthorpe > Cc: Pawel Osciak > Cc: Marek Szyprowski > Cc: Kyungmin Park > Cc: Tomasz Figa > Cc: Mauro Carvalho Chehab > Cc: Andrew Morton > Cc: John Hubbard > Cc: Jérôme Glisse > Cc: Jan Kara > Cc: Dan Williams > Cc

Re: [PATCH] media: i2c: imx258: correct mode to GBGB/RGRG

2020-10-28 Thread Tomasz Figa
On Wed, Oct 28, 2020 at 11:15 AM Krzysztof Kozlowski wrote: > > On Wed, 28 Oct 2020 at 11:03, Sakari Ailus > wrote: > > > > On Wed, Oct 28, 2020 at 10:56:55AM +0100, Krzysztof Kozlowski wrote: > > > On Wed, 28 Oct 2020 at 10:45, Krzysztof Kozlowski wrote: > > > > > > > > On Wed, 28 Oct 2020 at

Re: [PATCH] ASoC: Intel: kbl_rt5663_max98927: Fix kabylake_ssp_fixup function

2020-10-26 Thread Tomasz Figa
On Wed, Oct 14, 2020 at 08:02:26PM +0100, Mark Brown wrote: > On Wed, Oct 14, 2020 at 02:16:24PM +0000, Tomasz Figa wrote: > > > Fixes a boot crash on a HP Chromebook x2: > > > > [ 16.582225] BUG: kernel NULL pointer dereference, address: > > 0

Re: [PATCH v4 05/15] mm/frame-vector: Use FOLL_LONGTERM

2020-10-26 Thread Tomasz Figa
ot. > > Signed-off-by: Daniel Vetter > Cc: Jason Gunthorpe > Cc: Pawel Osciak > Cc: Marek Szyprowski > Cc: Kyungmin Park > Cc: Tomasz Figa > Cc: Mauro Carvalho Chehab > Cc: Andrew Morton > Cc: John Hubbard > Cc: Jérôme Glisse > Cc: Jan Kara

Re: [PATCH v4 06/15] media: videobuf2: Move frame_vector into media subsystem

2020-10-26 Thread Tomasz Figa
viewed-by: John Hubbard > Acked-by: Mauro Carvalho Chehab > Signed-off-by: Daniel Vetter > Cc: Jason Gunthorpe > Cc: Pawel Osciak > Cc: Marek Szyprowski > Cc: Kyungmin Park > Cc: Tomasz Figa > Cc: Mauro Carvalho Chehab > Cc: Andrew Morton > Cc: John Hubbard &

Re: [PATCH v4 09/15] media/videbuf1|2: Mark follow_pfn usage as unsafe

2020-10-26 Thread Tomasz Figa
this is a good first step towards deprecating this legacy code, so: Acked-by: Tomasz Figa Of course the last word goes to Mauro. :) Best regards, Tomasz > > Signed-off-by: Daniel Vetter > Cc: Jason Gunthorpe > Cc: Kees Cook > Cc: Dan Williams > Cc: Andrew Morton > Cc: Jo

Re: [PATCH 2/2] venus: venc: fix handlig of S_SELECTION and G_SELECTION

2020-10-22 Thread Tomasz Figa
On Thu, Oct 22, 2020 at 6:37 AM wrote: > > Hi Tomasz, > > On 2020-10-13 19:09, Tomasz Figa wrote: > > Hi Vikash, > > > > On Tue, Oct 13, 2020 at 02:56:21PM +0530, vgaro...@codeaurora.org > > wrote: > >> > >> On 2020-10-08 19:51, Tomasz Fi

Re: [PATCH] media: staging: rkisp1: cap: refactor enable/disable stream to allow multistreaming

2020-10-16 Thread Tomasz Figa
On Fri, Oct 16, 2020 at 4:28 PM Dafna Hirschfeld wrote: > > Hi, > > Am 15.10.20 um 21:57 schrieb Helen Koike: > > Allow streaming from self picture path and main picture path at the same > > time. > > > > Take care for s_stream() callbacks to not be called twice. > > When starting a stream,

Re: [PATCH v5 8/9] arm64: dts: rockchip: add isp0 node for rk3399

2020-10-14 Thread Tomasz Figa
On Wed, Oct 14, 2020 at 6:27 PM Helen Koike wrote: > > Hi Tomasz, > > On 9/26/20 10:00 AM, Tomasz Figa wrote: > > Hi Helen, > > > > On Wed, Jul 22, 2020 at 12:55:32PM -0300, Helen Koike wrote: > >> From: Shunqian Zheng > >> > >> RK3399 h

[PATCH] ASoC: Intel: kbl_rt5663_max98927: Fix kabylake_ssp_fixup function

2020-10-14 Thread Tomasz Figa
0050 [ 16.584248] ---[ end trace c8511d090c11edff ]--- Suggested-by: Łukasz Majczak Fixes: 2e5894d73789e ("ASoC: pcm: Add support for DAI multicodec") Signed-off-by: Tomasz Figa --- sound/soc/intel/boards/kbl_rt5663_max98927.c | 39 1 file changed, 31 insertion

Re: [PATCH 8/8] WIP: add a dma_alloc_contiguous API

2020-10-14 Thread Tomasz Figa
+CC Ricardo who will be looking into using this in the USB stack (UVC camera driver). On Wed, Sep 30, 2020 at 6:09 PM Christoph Hellwig wrote: > > Add a new API that returns a virtually non-contigous array of pages > and dma address. This API is only implemented for dma-iommu and will > not be

Re: [PATCH] v4l: Add source change event for colorimetry

2020-10-13 Thread Tomasz Figa
On Tue, Oct 13, 2020 at 4:53 PM Stanimir Varbanov wrote: > > > > On 10/13/20 5:07 PM, Tomasz Figa wrote: > > On Tue, Oct 13, 2020 at 3:53 PM Stanimir Varbanov > > wrote: > >> > >> > >> > >> On 10/13/20 4:40 PM, Tomasz Figa wro

Re: [PATCH] v4l: Add source change event for colorimetry

2020-10-13 Thread Tomasz Figa
On Tue, Oct 13, 2020 at 3:53 PM Stanimir Varbanov wrote: > > > > On 10/13/20 4:40 PM, Tomasz Figa wrote: > > On Tue, Oct 13, 2020 at 11:03 AM Stanimir Varbanov > > wrote: > >> > >> Hi, > >> > >> On 7/2/20 2:52 PM, Stanimir V

Re: [PATCH] v4l: Add source change event for colorimetry

2020-10-13 Thread Tomasz Figa
On Tue, Oct 13, 2020 at 11:03 AM Stanimir Varbanov wrote: > > Hi, > > On 7/2/20 2:52 PM, Stanimir Varbanov wrote: > > Hi, > > > > Once we have this event there is still open question how the client will > > know the data buffer on which the new colorspace is valid/applied. > > > > The options

Re: [PATCH 2/2] venus: venc: fix handlig of S_SELECTION and G_SELECTION

2020-10-13 Thread Tomasz Figa
Hi Vikash, On Tue, Oct 13, 2020 at 02:56:21PM +0530, vgaro...@codeaurora.org wrote: > > On 2020-10-08 19:51, Tomasz Figa wrote: > > On Wed, Oct 7, 2020 at 9:33 PM wrote: > > > > > > Hi Tomasz, > > > > > > On 2020-10-01 20:47, Tomasz Figa wrote:

Re: [PATCH] v4l2-ctrl: add control for thumnails

2020-10-13 Thread Tomasz Figa
On Tue, Oct 13, 2020 at 2:52 PM Stanimir Varbanov wrote: > > Hi, > > On 6/4/20 3:57 PM, Tomasz Figa wrote: > > On Thu, Jun 4, 2020 at 2:56 PM Hans Verkuil > > wrote: > >> > >> On 04/06/2020 14:34, Stanimir Varbanov wrote: > >>> Hi Ha

Re: [PATCH v2 09/17] mm: Add unsafe_follow_pfn

2020-10-10 Thread Tomasz Figa
Hi Mauro, On Fri, Oct 9, 2020 at 2:37 PM Mauro Carvalho Chehab wrote: > > Em Fri, 9 Oct 2020 09:21:11 -0300 > Jason Gunthorpe escreveu: > > > On Fri, Oct 09, 2020 at 12:34:21PM +0200, Mauro Carvalho Chehab wrote: > > > Hi, > > > > > > Em Fri, 9 Oct 2020 09:59:26 +0200 > > > Daniel Vetter

Re: [PATCH v2 09/17] mm: Add unsafe_follow_pfn

2020-10-10 Thread Tomasz Figa
Hi Daniel, On Fri, Oct 9, 2020 at 7:52 PM Daniel Vetter wrote: > > On Fri, Oct 9, 2020 at 2:48 PM Jason Gunthorpe wrote: > > > > On Fri, Oct 09, 2020 at 02:37:23PM +0200, Mauro Carvalho Chehab wrote: > > > > > I'm not a mm/ expert, but, from what I understood from Daniel's patch > > >

Re: [PATCH 2/2] venus: venc: fix handlig of S_SELECTION and G_SELECTION

2020-10-08 Thread Tomasz Figa
On Wed, Oct 7, 2020 at 9:33 PM wrote: > > Hi Tomasz, > > On 2020-10-01 20:47, Tomasz Figa wrote: > > On Thu, Oct 1, 2020 at 3:32 AM Stanimir Varbanov > > wrote: > >> > >> Hi Tomasz, > >> > >> On 9/25/20 11:55 PM, Tomasz Figa wrote: >

Re: [PATCH 2/2] mm/frame-vec: use FOLL_LONGTERM

2020-10-07 Thread Tomasz Figa
On Wed, Oct 7, 2020 at 4:23 PM Daniel Vetter wrote: > > On Wed, Oct 7, 2020 at 4:12 PM Tomasz Figa wrote: > > > > On Wed, Oct 7, 2020 at 4:09 PM Daniel Vetter wrote: > > > > > > On Wed, Oct 7, 2020 at 3:34 PM Tomasz Figa wrote: > > > > > &

Re: [PATCH 2/2] mm/frame-vec: use FOLL_LONGTERM

2020-10-07 Thread Tomasz Figa
On Wed, Oct 7, 2020 at 4:09 PM Daniel Vetter wrote: > > On Wed, Oct 7, 2020 at 3:34 PM Tomasz Figa wrote: > > > > On Wed, Oct 7, 2020 at 3:06 PM Jason Gunthorpe wrote: > > > > > > On Wed, Oct 07, 2020 at 02:58:33PM +0200, Daniel Vetter wrote: > > >

Re: [PATCH 2/2] mm/frame-vec: use FOLL_LONGTERM

2020-10-07 Thread Tomasz Figa
On Wed, Oct 7, 2020 at 3:06 PM Jason Gunthorpe wrote: > > On Wed, Oct 07, 2020 at 02:58:33PM +0200, Daniel Vetter wrote: > > On Wed, Oct 7, 2020 at 2:48 PM Tomasz Figa wrote: > > > > > > On Wed, Oct 7, 2020 at 2:44 PM Jason Gunthorpe wrote: > > > >

Re: [PATCH 2/2] mm/frame-vec: use FOLL_LONGTERM

2020-10-07 Thread Tomasz Figa
On Sat, Oct 3, 2020 at 1:31 AM Jason Gunthorpe wrote: > > On Fri, Oct 02, 2020 at 08:16:48PM +0200, Daniel Vetter wrote: > > On Fri, Oct 2, 2020 at 8:06 PM Jason Gunthorpe wrote: > > > On Fri, Oct 02, 2020 at 07:53:03PM +0200, Daniel Vetter wrote: > > > > For $reasons I've stumbled over this

Re: [PATCH 2/2] mm/frame-vec: use FOLL_LONGTERM

2020-10-07 Thread Tomasz Figa
On Wed, Oct 7, 2020 at 2:44 PM Jason Gunthorpe wrote: > > On Wed, Oct 07, 2020 at 02:33:56PM +0200, Marek Szyprowski wrote: > > Well, it was in vb2_get_vma() function, but now I see that it has been > > lost in fb639eb39154 and 6690c8c78c74 some time ago... > > There is no guarentee that holding

Re: [PATCH 8/8] WIP: add a dma_alloc_contiguous API

2020-10-07 Thread Tomasz Figa
On Wed, Oct 7, 2020 at 8:21 AM Christoph Hellwig wrote: > > On Tue, Oct 06, 2020 at 10:56:04PM +0200, Tomasz Figa wrote: > > > Yes. And make sure the API isn't implemented when VIVT caches are > > > used, but that isn't really different from the current interface. > &g

Re: [PATCH 8/8] WIP: add a dma_alloc_contiguous API

2020-10-06 Thread Tomasz Figa
On Mon, Oct 5, 2020 at 10:26 AM Christoph Hellwig wrote: > > On Fri, Oct 02, 2020 at 05:50:40PM +, Tomasz Figa wrote: > > Hi Christoph, > > > > On Wed, Sep 30, 2020 at 06:09:17PM +0200, Christoph Hellwig wrote: > > > Add a new API that returns a virtu

Re: [PATCH v8 6/6] at24: Support probing while off

2020-10-06 Thread Tomasz Figa
Hi Sakari, On Thu, Sep 3, 2020 at 10:15 AM Sakari Ailus wrote: > > In certain use cases (where the chip is part of a camera module, and the > camera module is wired together with a camera privacy LED), powering on > the device during probe is undesirable. Add support for the at24 to > execute

Re: [PATCH v8 6/6] at24: Support probing while off

2020-10-06 Thread Tomasz Figa
On Tue, Oct 6, 2020 at 1:20 PM Tomasz Figa wrote: > > Hi Sakari, > > On Thu, Sep 3, 2020 at 10:15 AM Sakari Ailus > wrote: > > > > In certain use cases (where the chip is part of a camera module, and the > > camera module is wired together with a camera privacy

Re: [PATCH v5 1/7] media: v4l2: Extend pixel formats to unify single/multi-planar handling (and more)

2020-10-02 Thread Tomasz Figa
Hi Helen, On Tue, Aug 04, 2020 at 04:29:33PM -0300, Helen Koike wrote: > This is part of the multiplanar and singleplanar unification process. > v4l2_ext_pix_format is supposed to work for both cases. > > We also add the concept of modifiers already employed in DRM to expose > HW-specific

Re: [PATCH 1/2] mm/frame-vec: Drop gup_flags from get_vaddr_frames()

2020-10-02 Thread Tomasz Figa
ed-off-by: Daniel Vetter > Cc: Inki Dae > Cc: Joonyoung Shim > Cc: Seung-Woo Kim > Cc: Kyungmin Park > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Cc: Pawel Osciak > Cc: Marek Szyprowski > Cc: Tomasz Figa > Cc: Andrew Morton > Cc: Oded Gabbay > Cc: Omer S

Re: [PATCH 8/8] WIP: add a dma_alloc_contiguous API

2020-10-02 Thread Tomasz Figa
Hi Christoph, On Wed, Sep 30, 2020 at 06:09:17PM +0200, Christoph Hellwig wrote: > Add a new API that returns a virtually non-contigous array of pages > and dma address. This API is only implemented for dma-iommu and will > not be implemented for non-iommu DMA API instances that have to allocate

Re: [PATCH 2/2] venus: venc: fix handlig of S_SELECTION and G_SELECTION

2020-10-01 Thread Tomasz Figa
On Thu, Oct 1, 2020 at 3:32 AM Stanimir Varbanov wrote: > > Hi Tomasz, > > On 9/25/20 11:55 PM, Tomasz Figa wrote: > > Hi Dikshita, Stanimir, > > > > On Thu, Sep 24, 2020 at 7:31 PM Dikshita Agarwal > > wrote: > >> > >> From: Stanimir

Re: [PATCH v8 0/6] Support running driver's probe for a device powered off

2020-09-28 Thread Tomasz Figa
On Mon, Sep 28, 2020 at 4:18 PM Rafael J. Wysocki wrote: > > On Sun, Sep 27, 2020 at 9:44 PM Tomasz Figa wrote: > > > > On Sun, Sep 27, 2020 at 9:39 PM Wolfram Sang wrote: > > > > > > > > > > I think we might be overly complicating things. IMHO

Re: [PATCH v8 0/6] Support running driver's probe for a device powered off

2020-09-27 Thread Tomasz Figa
On Sun, Sep 27, 2020 at 9:39 PM Wolfram Sang wrote: > > > > I think we might be overly complicating things. IMHO the series as is > > with the "i2c_" prefix removed from the flags introduced would be > > reusable as is for any other subsystem that needs it. Of course, for > > now, the handling of

Re: [PATCH 17/18] dma-iommu: implement ->alloc_noncoherent

2020-09-26 Thread Tomasz Figa
On Sat, Sep 26, 2020 at 4:14 PM Christoph Hellwig wrote: > > On Fri, Sep 25, 2020 at 06:46:22PM +, Tomasz Figa wrote: > > > +static void *iommu_dma_alloc_noncoherent(struct device *dev, size_t size, > > > + dma_addr_t *handle, enum dma_data_

Re: [PATCH v5 0/9] move Rockchip ISP bindings out of staging / add ISP DT nodes for RK3399

2020-09-26 Thread Tomasz Figa
tion with if/then schema > Besides one comment to patch 8/9, Reviewed-by: Tomasz Figa Best regards, Tomasz

Re: [PATCH v5 8/9] arm64: dts: rockchip: add isp0 node for rk3399

2020-09-26 Thread Tomasz Figa
Hi Helen, On Wed, Jul 22, 2020 at 12:55:32PM -0300, Helen Koike wrote: > From: Shunqian Zheng > > RK3399 has two ISPs, but only isp0 was tested. > Add isp0 node in rk3399 dtsi > > Verified with: > make ARCH=arm64 dtbs_check >

Re: [PATCH v8 0/6] Support running driver's probe for a device powered off

2020-09-26 Thread Tomasz Figa
s a patch that affects the I²C core changes > here (see below). The patches apart from that apply to Bartosz's > at24/for-next as well as Mauro's linux-media master branch. Besides the suggestion to make the defintions added less specific to i2c (but still keeping the implementation so for now), feel free to add: Reviewed-by: Tomasz Figa Best regards, Tomasz

Re: [PATCH v8 0/6] Support running driver's probe for a device powered off

2020-09-26 Thread Tomasz Figa
On Mon, Sep 14, 2020 at 12:47:27PM +0300, Sakari Ailus wrote: > Hi Luca, > > On Mon, Sep 14, 2020 at 09:58:24AM +0200, Luca Ceresoli wrote: > > Hi Sakari, > > > > On 11/09/20 15:01, Sakari Ailus wrote: > > > Hi Luca, > > > > > > On Fri, Sep 11, 2020 at 02:49:26PM +0200, Luca Ceresoli wrote: > >

Re: [PATCH 2/2] venus: venc: fix handlig of S_SELECTION and G_SELECTION

2020-09-25 Thread Tomasz Figa
Hi Dikshita, Stanimir, On Thu, Sep 24, 2020 at 7:31 PM Dikshita Agarwal wrote: > > From: Stanimir Varbanov > > - return correct width and height for G_SELECTION > - if requested rectangle wxh doesn't match with capture port wxh > adjust the rectangle to supported wxh. > > Signed-off-by:

  1   2   3   4   5   6   7   8   9   10   >