[PATCH v13 3/3] drm/i915: Put "cooked" vlank counters in frame CRC lines

Use drm_accurate_vblank_count so we have the full 32 bit to represent the frame counter and userspace has a simpler way of knowing when the counter wraps around. Signed-off-by: Tomeu Vizoso Reviewed-by: Emil Velikov --- drivers/gpu/drm/i915/i915_irq.c | 6 +++--- 1 file changed, 3 insertions

[RESEND PATCH v12] drm/i915/debugfs: Move out pipe CRC code

intel_display_crc_init accept a drm_i915_private instead. v12: Rebased. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> --- drivers/gpu/drm/i915/Makefile | 2 +- drivers/gpu/drm/i915/i915_debug

[RESEND PATCH v12] drm/i915/debugfs: Move out pipe CRC code

intel_display_crc_init accept a drm_i915_private instead. v12: Rebased. Signed-off-by: Tomeu Vizoso Reviewed-by: Emil Velikov --- drivers/gpu/drm/i915/Makefile | 2 +- drivers/gpu/drm/i915/i915_debugfs.c | 882 +-- drivers/gpu/drm/i915/intel_drv.h | 5 + drivers

[PATCH] drm/edid: Don't print an error if the checksum of a CEA block is wrong

<ch...@chris-wilson.co.uk> Cc: Tomi Sarvela <tomi.p.sarv...@intel.com> Cc: intel-...@lists.freedesktop.org Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- drivers/gpu/drm/drm_edid.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git

[PATCH] drm/edid: Don't print an error if the checksum of a CEA block is wrong

Cc: Tomi Sarvela Cc: intel-...@lists.freedesktop.org Signed-off-by: Tomeu Vizoso --- drivers/gpu/drm/drm_edid.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 6798c3ad9d53..db79bc949216 100644

[RESEND PATCH v12 2/4] drm: Move locking into drm_debugfs_crtc_crc_add

There's no reason any more for callers of this function to take the lock themselves, so just move the lock to the function to avoid confusion and bugs when more callers are contributed. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- drivers/gpu/drm/drm_debugfs_crc

[RESEND PATCH v12 4/4] drm/i915: Put "cooked" vlank counters in frame CRC lines

Use drm_accurate_vblank_count so we have the full 32 bit to represent the frame counter and userspace has a simpler way of knowing when the counter wraps around. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> --- dri

[RESEND PATCH v12 2/4] drm: Move locking into drm_debugfs_crtc_crc_add

There's no reason any more for callers of this function to take the lock themselves, so just move the lock to the function to avoid confusion and bugs when more callers are contributed. Signed-off-by: Tomeu Vizoso --- drivers/gpu/drm/drm_debugfs_crc.c | 9 +++-- 1 file changed, 7

[RESEND PATCH v12 4/4] drm/i915: Put "cooked" vlank counters in frame CRC lines

Use drm_accurate_vblank_count so we have the full 32 bit to represent the frame counter and userspace has a simpler way of knowing when the counter wraps around. Signed-off-by: Tomeu Vizoso Reviewed-by: Emil Velikov --- drivers/gpu/drm/i915/i915_irq.c | 6 +++--- 1 file changed, 3 insertions

[RESEND PATCH v12 1/4] drm/i915/debugfs: Move out pipe CRC code

intel_display_crc_init accept a drm_i915_private instead. v12: Rebased. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> --- drivers/gpu/drm/i915/Makefile | 2 +- drivers/gpu/drm/i915/i915_debug

[RESEND PATCH v12 0/4] New debugfs API for capturing CRC of frames

Tomeu Vizoso (4): drm/i915/debugfs: Move out pipe CRC code drm: Move locking into drm_debugfs_crtc_crc_add drm/i915: Use new CRC debugfs API drm/i915: Put "cooked" vlank counters in frame CRC lines drivers/gpu/drm/drm_debugfs_crc.c |9 +- drivers/gpu/drm/i915/Makefile

[RESEND PATCH v12 3/4] drm/i915: Use new CRC debugfs API

skip the 1st or 2nd frames. v9: - Add stub for intel_crtc_set_crc_source. v12: - Rebased. - Remove stub for intel_crtc_set_crc_source and instead set the callback to NULL (Jani Nikula). Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Reviewed-by: Emil

[RESEND PATCH v12 1/4] drm/i915/debugfs: Move out pipe CRC code

intel_display_crc_init accept a drm_i915_private instead. v12: Rebased. Signed-off-by: Tomeu Vizoso Reviewed-by: Emil Velikov --- drivers/gpu/drm/i915/Makefile | 2 +- drivers/gpu/drm/i915/i915_debugfs.c | 882 +-- drivers/gpu/drm/i915/intel_drv.h | 5 + drivers

[RESEND PATCH v12 0/4] New debugfs API for capturing CRC of frames

Tomeu Vizoso (4): drm/i915/debugfs: Move out pipe CRC code drm: Move locking into drm_debugfs_crtc_crc_add drm/i915: Use new CRC debugfs API drm/i915: Put "cooked" vlank counters in frame CRC lines drivers/gpu/drm/drm_debugfs_crc.c |9 +- drivers/gpu/drm/i915/Makefile

[RESEND PATCH v12 3/4] drm/i915: Use new CRC debugfs API

skip the 1st or 2nd frames. v9: - Add stub for intel_crtc_set_crc_source. v12: - Rebased. - Remove stub for intel_crtc_set_crc_source and instead set the callback to NULL (Jani Nikula). Signed-off-by: Tomeu Vizoso Reviewed-by: Emil Velikov --- drivers/gpu/drm/i915/i915_drv

[PATCH v12 3/4] drm/i915: Use new CRC debugfs API

skip the 1st or 2nd frames. v9: - Add stub for intel_crtc_set_crc_source. v12: - Rebased. - Remove stub for intel_crtc_set_crc_source and instead set the callback to NULL (Jani Nikula). Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Reviewed-by: Emil

[PATCH v12 2/4] drm: Move locking into drm_debugfs_crtc_crc_add

There's no reason any more for callers of this function to take the lock themselves, so just move the lock to the function to avoid confusion and bugs when more callers are contributed. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- drivers/gpu/drm/drm_debugfs_crc

[PATCH v12 3/4] drm/i915: Use new CRC debugfs API

skip the 1st or 2nd frames. v9: - Add stub for intel_crtc_set_crc_source. v12: - Rebased. - Remove stub for intel_crtc_set_crc_source and instead set the callback to NULL (Jani Nikula). Signed-off-by: Tomeu Vizoso Reviewed-by: Emil Velikov --- drivers/gpu/drm/i915/i915_drv

[PATCH v12 2/4] drm: Move locking into drm_debugfs_crtc_crc_add

There's no reason any more for callers of this function to take the lock themselves, so just move the lock to the function to avoid confusion and bugs when more callers are contributed. Signed-off-by: Tomeu Vizoso --- drivers/gpu/drm/drm_debugfs_crc.c | 9 +++-- 1 file changed, 7

[PATCH v12 0/4] New debugfs API for capturing CRC of frames

Tomeu Vizoso (4): drm/i915/debugfs: Move out pipe CRC code drm: Move locking into drm_debugfs_crtc_crc_add drm/i915: Use new CRC debugfs API drm/i915: Put "cooked" vlank counters in frame CRC lines drivers/gpu/drm/drm_debugfs_crc.c |9 +- drivers/gpu/drm/i915/Makefile

[PATCH v12 1/4] drm/i915/debugfs: Move out pipe CRC code

intel_display_crc_init accept a drm_i915_private instead. v12: Rebased. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> --- drivers/gpu/drm/i915/Makefile | 2 +- drivers/gpu/drm/i915/i915_debug

[PATCH v12 0/4] New debugfs API for capturing CRC of frames

Tomeu Vizoso (4): drm/i915/debugfs: Move out pipe CRC code drm: Move locking into drm_debugfs_crtc_crc_add drm/i915: Use new CRC debugfs API drm/i915: Put "cooked" vlank counters in frame CRC lines drivers/gpu/drm/drm_debugfs_crc.c |9 +- drivers/gpu/drm/i915/Makefile

[PATCH v12 1/4] drm/i915/debugfs: Move out pipe CRC code

intel_display_crc_init accept a drm_i915_private instead. v12: Rebased. Signed-off-by: Tomeu Vizoso Reviewed-by: Emil Velikov --- drivers/gpu/drm/i915/Makefile | 2 +- drivers/gpu/drm/i915/i915_debugfs.c | 882 +-- drivers/gpu/drm/i915/intel_drv.h | 5 + drivers

[PATCH v12 4/4] drm/i915: Put "cooked" vlank counters in frame CRC lines

Use drm_accurate_vblank_count so we have the full 32 bit to represent the frame counter and userspace has a simpler way of knowing when the counter wraps around. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> --- dri

[PATCH v12 4/4] drm/i915: Put "cooked" vlank counters in frame CRC lines

Use drm_accurate_vblank_count so we have the full 32 bit to represent the frame counter and userspace has a simpler way of knowing when the counter wraps around. Signed-off-by: Tomeu Vizoso Reviewed-by: Emil Velikov --- drivers/gpu/drm/i915/i915_irq.c | 6 +++--- 1 file changed, 3 insertions

Re: [Intel-gfx] [PATCH v11 3/4] drm/i915: Use new CRC debugfs API

On 16 November 2016 at 13:58, Jani Nikula <jani.nik...@linux.intel.com> wrote: > On Wed, 16 Nov 2016, Tomeu Vizoso <tomeu.viz...@collabora.com> wrote: >> On 15 November 2016 at 09:27, Jani Nikula <jani.nik...@linux.intel.com> >> wrote: >>> On Tue, 15

Re: [Intel-gfx] [PATCH v11 3/4] drm/i915: Use new CRC debugfs API

On 16 November 2016 at 13:58, Jani Nikula wrote: > On Wed, 16 Nov 2016, Tomeu Vizoso wrote: >> On 15 November 2016 at 09:27, Jani Nikula >> wrote: >>> On Tue, 15 Nov 2016, David Weinehall wrote: >>>> On Mon, Nov 14, 2016 at 12:44:25PM +0200, Jani Nikula wro

Re: [Intel-gfx] [PATCH v11 3/4] drm/i915: Use new CRC debugfs API

On 15 November 2016 at 09:27, Jani Nikula <jani.nik...@linux.intel.com> wrote: > On Tue, 15 Nov 2016, David Weinehall <t...@kernel.org> wrote: >> On Mon, Nov 14, 2016 at 12:44:25PM +0200, Jani Nikula wrote: >>> On Thu, 06 Oct 2016, Tomeu Vizoso <tomeu.viz...@colla

Re: [Intel-gfx] [PATCH v11 3/4] drm/i915: Use new CRC debugfs API

On 15 November 2016 at 09:27, Jani Nikula wrote: > On Tue, 15 Nov 2016, David Weinehall wrote: >> On Mon, Nov 14, 2016 at 12:44:25PM +0200, Jani Nikula wrote: >>> On Thu, 06 Oct 2016, Tomeu Vizoso wrote: >>> > diff --git a/drivers/gpu/drm/i915/intel_display.c

Re: [PATCH] ARM: dts: rockchip: add i2c-bus subnode to edp

On 10/20/2016 03:45 PM, Heiko Stübner wrote: > Am Donnerstag, 20. Oktober 2016, 10:07:25 schrieb Tomeu Vizoso: >> Add an empty 'i2c-bus' subnode to the edp node just so that the I2C core >> doesn't attemp to parse the 'ports' subnode as containing i2c devices. >> >>

Re: [PATCH] ARM: dts: rockchip: add i2c-bus subnode to edp

On 10/20/2016 03:45 PM, Heiko Stübner wrote: > Am Donnerstag, 20. Oktober 2016, 10:07:25 schrieb Tomeu Vizoso: >> Add an empty 'i2c-bus' subnode to the edp node just so that the I2C core >> doesn't attemp to parse the 'ports' subnode as containing i2c devices. >> >>

[PATCH] ARM: dts: rockchip: add i2c-bus subnode to edp

Add an empty 'i2c-bus' subnode to the edp node just so that the I2C core doesn't attemp to parse the 'ports' subnode as containing i2c devices. This is to avoid spurious failure messages such as: i2c i2c-6: of_i2c: modalias failure on /dp@ff97/ports Signed-off-by: Tomeu Vizoso <tomeu.

[PATCH] ARM: dts: rockchip: add i2c-bus subnode to edp

Add an empty 'i2c-bus' subnode to the edp node just so that the I2C core doesn't attemp to parse the 'ports' subnode as containing i2c devices. This is to avoid spurious failure messages such as: i2c i2c-6: of_i2c: modalias failure on /dp@ff97/ports Signed-off-by: Tomeu Vizoso Cc: Randy Li

Re: the dp helper would try to enable the i2c channel for rockchip-edp

On 20 October 2016 at 09:38, Randy Li <randy...@rock-chips.com> wrote: > > > On 10/20/2016 03:18 PM, Tomeu Vizoso wrote: >> >> On 19 October 2016 at 15:52, Randy Li <randy...@rock-chips.com> wrote: >>> >>> Hello, >>> >>>

Re: the dp helper would try to enable the i2c channel for rockchip-edp

On 20 October 2016 at 09:38, Randy Li wrote: > > > On 10/20/2016 03:18 PM, Tomeu Vizoso wrote: >> >> On 19 October 2016 at 15:52, Randy Li wrote: >>> >>> Hello, >>> >>> Recently, I want to use a eDP panel in my RK3288 platform, but I

Re: the dp helper would try to enable the i2c channel for rockchip-edp

On 19 October 2016 at 15:52, Randy Li wrote: > Hello, > > Recently, I want to use a eDP panel in my RK3288 platform, but I got the > following message: > > [8.935918] i2c i2c-6: of_i2c: modalias failure on /dp@ff97/ports > [8.936018] rockchip-drm

Re: the dp helper would try to enable the i2c channel for rockchip-edp

On 19 October 2016 at 15:52, Randy Li wrote: > Hello, > > Recently, I want to use a eDP panel in my RK3288 platform, but I got the > following message: > > [8.935918] i2c i2c-6: of_i2c: modalias failure on /dp@ff97/ports > [8.936018] rockchip-drm display-subsystem: bound ff97.dp

Re: [PATCH v11 2/4] drm: Add API for capturing frame CRCs

Adding Benjamin Gaignard to CC in case he wants to comment on the usage of the registration functions, as suggested by Daniel Vetter. Regards, Tomeu On 6 October 2016 at 17:21, Tomeu Vizoso <tomeu.viz...@collabora.com> wrote: > Adds files and directories to debugfs for controlling an

Re: [PATCH v11 2/4] drm: Add API for capturing frame CRCs

Adding Benjamin Gaignard to CC in case he wants to comment on the usage of the registration functions, as suggested by Daniel Vetter. Regards, Tomeu On 6 October 2016 at 17:21, Tomeu Vizoso wrote: > Adds files and directories to debugfs for controlling and reading frame > CRCs, pe

[PATCH v11 2/4] drm: Add API for capturing frame CRCs

Velikov) v11: - Remove extra brace that broke compilation. Sorry! Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- Documentation/gpu/drm-uapi.rst| 6 + drivers/gpu/drm/Makefile | 3 +- drivers/gpu/drm/drm_crtc.c| 34 +++- drivers/gpu/drm/drm_deb

[PATCH v11 3/4] drm/i915: Use new CRC debugfs API

skip the 1st or 2nd frames. v9: - Add stub for intel_crtc_set_crc_source. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i

[PATCH v11 2/4] drm: Add API for capturing frame CRCs

Velikov) v11: - Remove extra brace that broke compilation. Sorry! Signed-off-by: Tomeu Vizoso --- Documentation/gpu/drm-uapi.rst| 6 + drivers/gpu/drm/Makefile | 3 +- drivers/gpu/drm/drm_crtc.c| 34 +++- drivers/gpu/drm/drm_debugfs.c | 34 +++- drivers/gpu

[PATCH v11 3/4] drm/i915: Use new CRC debugfs API

skip the 1st or 2nd frames. v9: - Add stub for intel_crtc_set_crc_source. Signed-off-by: Tomeu Vizoso Reviewed-by: Emil Velikov --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_irq.c | 83 +-- drivers/gpu/drm/i915/intel_di

[PATCH v11 1/4] drm/i915/debugfs: Move out pipe CRC code

intel_display_crc_init accept a drm_i915_private instead. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> --- drivers/gpu/drm/i915/Makefile | 2 +- drivers/gpu/drm/i915/i915_debugfs.c | 886 +---

[PATCH v11 1/4] drm/i915/debugfs: Move out pipe CRC code

intel_display_crc_init accept a drm_i915_private instead. Signed-off-by: Tomeu Vizoso Reviewed-by: Emil Velikov --- drivers/gpu/drm/i915/Makefile | 2 +- drivers/gpu/drm/i915/i915_debugfs.c | 886 +--- drivers/gpu/drm/i915/intel_drv.h | 5 + drivers/gpu/drm/i915

[PATCH v11 4/4] drm/i915: Put "cooked" vlank counters in frame CRC lines

Use drm_accurate_vblank_count so we have the full 32 bit to represent the frame counter and userspace has a simpler way of knowing when the counter wraps around. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> --- dri

[PATCH v11 0/4] New debugfs API for capturing CRC of frames

for hardware that can provide frame CRCs (including eDP panels that support self-refresh) can easily implement the new callback and provide userspace with the CRC values. Sorry about that, but there was a dangling brace in v10 breaking the build so here is this v11. Thanks, Tomeu Tomeu Vizoso (4

[PATCH v11 4/4] drm/i915: Put "cooked" vlank counters in frame CRC lines

Use drm_accurate_vblank_count so we have the full 32 bit to represent the frame counter and userspace has a simpler way of knowing when the counter wraps around. Signed-off-by: Tomeu Vizoso Reviewed-by: Emil Velikov --- drivers/gpu/drm/i915/i915_irq.c | 6 +++--- 1 file changed, 3 insertions

[PATCH v11 0/4] New debugfs API for capturing CRC of frames

for hardware that can provide frame CRCs (including eDP panels that support self-refresh) can easily implement the new callback and provide userspace with the CRC values. Sorry about that, but there was a dangling brace in v10 breaking the build so here is this v11. Thanks, Tomeu Tomeu Vizoso (4

[PATCH v10 1/4] drm/i915/debugfs: Move out pipe CRC code

intel_display_crc_init accept a drm_i915_private instead. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> --- drivers/gpu/drm/i915/Makefile | 2 +- drivers/gpu/drm/i915/i915_debugfs.c | 886 +---

[PATCH v10 1/4] drm/i915/debugfs: Move out pipe CRC code

intel_display_crc_init accept a drm_i915_private instead. Signed-off-by: Tomeu Vizoso Reviewed-by: Emil Velikov --- drivers/gpu/drm/i915/Makefile | 2 +- drivers/gpu/drm/i915/i915_debugfs.c | 886 +--- drivers/gpu/drm/i915/intel_drv.h | 5 + drivers/gpu/drm/i915

[PATCH v10 3/4] drm/i915: Use new CRC debugfs API

skip the 1st or 2nd frames. v9: - Add stub for intel_crtc_set_crc_source. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i

[PATCH v10 3/4] drm/i915: Use new CRC debugfs API

skip the 1st or 2nd frames. v9: - Add stub for intel_crtc_set_crc_source. Signed-off-by: Tomeu Vizoso Reviewed-by: Emil Velikov --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_irq.c | 83 +-- drivers/gpu/drm/i915/intel_di

[PATCH v10 4/4] drm/i915: Put "cooked" vlank counters in frame CRC lines

Use drm_accurate_vblank_count so we have the full 32 bit to represent the frame counter and userspace has a simpler way of knowing when the counter wraps around. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> --- dri

[PATCH v10 2/4] drm: Add API for capturing frame CRCs

Velikov) Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- Documentation/gpu/drm-uapi.rst| 6 + drivers/gpu/drm/Makefile | 3 +- drivers/gpu/drm/drm_crtc.c| 34 +++- drivers/gpu/drm/drm_debugfs.c | 34 +++- drivers/gpu/drm/drm_debugfs_crc.c

[PATCH v10 4/4] drm/i915: Put "cooked" vlank counters in frame CRC lines

Use drm_accurate_vblank_count so we have the full 32 bit to represent the frame counter and userspace has a simpler way of knowing when the counter wraps around. Signed-off-by: Tomeu Vizoso Reviewed-by: Emil Velikov --- drivers/gpu/drm/i915/i915_irq.c | 6 +++--- 1 file changed, 3 insertions

[PATCH v10 2/4] drm: Add API for capturing frame CRCs

Velikov) Signed-off-by: Tomeu Vizoso --- Documentation/gpu/drm-uapi.rst| 6 + drivers/gpu/drm/Makefile | 3 +- drivers/gpu/drm/drm_crtc.c| 34 +++- drivers/gpu/drm/drm_debugfs.c | 34 +++- drivers/gpu/drm/drm_debugfs_crc.c | 351

[PATCH v10 0/4] New debugfs API for capturing CRC of frames

for hardware that can provide frame CRCs (including eDP panels that support self-refresh) can easily implement the new callback and provide userspace with the CRC values. In this v10 debugfs creation failures don't abort CRTC registration, as suggested by Emil Velikov. Thanks, Tomeu Tomeu Vizoso

[PATCH v10 0/4] New debugfs API for capturing CRC of frames

for hardware that can provide frame CRCs (including eDP panels that support self-refresh) can easily implement the new callback and provide userspace with the CRC values. In this v10 debugfs creation failures don't abort CRTC registration, as suggested by Emil Velikov. Thanks, Tomeu Tomeu Vizoso

Re: [PATCH v9 2/4] drm: Add API for capturing frame CRCs

On 10/06/2016 01:13 PM, Emil Velikov wrote: > On 6 October 2016 at 09:56, Tomeu Vizoso <tomeu.viz...@collabora.com> wrote: >> Adds files and directories to debugfs for controlling and reading frame >> CRCs, per CRTC: >> >> dri/0/crtc-0/crc >> dri/0/crtc

Re: [PATCH v9 2/4] drm: Add API for capturing frame CRCs

On 10/06/2016 01:13 PM, Emil Velikov wrote: > On 6 October 2016 at 09:56, Tomeu Vizoso wrote: >> Adds files and directories to debugfs for controlling and reading frame >> CRCs, per CRTC: >> >> dri/0/crtc-0/crc >> dri/0/crtc-0/crc/control >> dri/0/crtc

[PATCH v9 3/4] drm/i915: Use new CRC debugfs API

skip the 1st or 2nd frames. v9: - Add stub for intel_crtc_set_crc_source. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i

[PATCH v9 1/4] drm/i915/debugfs: Move out pipe CRC code

intel_display_crc_init accept a drm_i915_private instead. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> --- drivers/gpu/drm/i915/Makefile | 2 +- drivers/gpu/drm/i915/i915_debugfs.c | 886 +---

[PATCH v9 2/4] drm: Add API for capturing frame CRCs

definition of drm_debugfs_crtc_crc_add to drm_internal.h v8: - Call debugfs_remove_recursive when we fail to create the minor device v9: - Register the debugfs directory for a crtc from drm_crtc_register_all() Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- Documen

[PATCH v9 2/4] drm: Add API for capturing frame CRCs

definition of drm_debugfs_crtc_crc_add to drm_internal.h v8: - Call debugfs_remove_recursive when we fail to create the minor device v9: - Register the debugfs directory for a crtc from drm_crtc_register_all() Signed-off-by: Tomeu Vizoso --- Documentation/gpu/drm-uapi.rst| 6

[PATCH v9 3/4] drm/i915: Use new CRC debugfs API

skip the 1st or 2nd frames. v9: - Add stub for intel_crtc_set_crc_source. Signed-off-by: Tomeu Vizoso Reviewed-by: Emil Velikov --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_irq.c | 83 +-- drivers/gpu/drm/i915/intel_di

[PATCH v9 1/4] drm/i915/debugfs: Move out pipe CRC code

intel_display_crc_init accept a drm_i915_private instead. Signed-off-by: Tomeu Vizoso Reviewed-by: Emil Velikov --- drivers/gpu/drm/i915/Makefile | 2 +- drivers/gpu/drm/i915/i915_debugfs.c | 886 +--- drivers/gpu/drm/i915/intel_drv.h | 5 + drivers/gpu/drm/i915

[PATCH v9 0/4] New debugfs API for capturing CRC of frames

callback (tested on Tegra124). Thanks, Tomeu Tomeu Vizoso (4): drm/i915/debugfs: Move out pipe CRC code drm: Add API for capturing frame CRCs drm/i915: Use new CRC debugfs API drm/i915: Put "cooked" vlank counters in frame CRC lines Documentation/gpu/drm-uapi.rst|6

[PATCH v9 0/4] New debugfs API for capturing CRC of frames

callback (tested on Tegra124). Thanks, Tomeu Tomeu Vizoso (4): drm/i915/debugfs: Move out pipe CRC code drm: Add API for capturing frame CRCs drm/i915: Use new CRC debugfs API drm/i915: Put "cooked" vlank counters in frame CRC lines Documentation/gpu/drm-uapi.rst|6

[PATCH v9 4/4] drm/i915: Put "cooked" vlank counters in frame CRC lines

Use drm_accurate_vblank_count so we have the full 32 bit to represent the frame counter and userspace has a simpler way of knowing when the counter wraps around. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> --- dri

[PATCH v9 4/4] drm/i915: Put "cooked" vlank counters in frame CRC lines

Use drm_accurate_vblank_count so we have the full 32 bit to represent the frame counter and userspace has a simpler way of knowing when the counter wraps around. Signed-off-by: Tomeu Vizoso Reviewed-by: Emil Velikov --- drivers/gpu/drm/i915/i915_irq.c | 6 +++--- 1 file changed, 3 insertions

[PATCH v2] drm/i915: Fix build when !CONFIG_DEBUG_FS

Add stub for intel_crtc_set_crc_source() and fix arguments of intel_display_crc_init(). Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Fixes: 21165bd933ac ("drm/i915/debugfs: Move out pipe CRC code") Fixes: 13fa0253d97a ("drm/i915: Use new CRC debugfs API")

[PATCH v2] drm/i915: Fix build when !CONFIG_DEBUG_FS

Add stub for intel_crtc_set_crc_source() and fix arguments of intel_display_crc_init(). Signed-off-by: Tomeu Vizoso Fixes: 21165bd933ac ("drm/i915/debugfs: Move out pipe CRC code") Fixes: 13fa0253d97a ("drm/i915: Use new CRC debugfs API") --- drivers/gpu/drm/i915/

[PATCH] drm/i915: Fix build when !CONFIG_DEBUG_FS

Add stub for intel_crtc_set_crc_source() and fix arguments of stub for intel_display_crc_init(). Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Fixes: 21165bd933ac ("drm/i915/debugfs: Move out pipe CRC code") Fixes: 13fa0253d97a ("drm/i915: Use new CRC debugfs API&q

[PATCH] drm/i915: Fix build when !CONFIG_DEBUG_FS

Add stub for intel_crtc_set_crc_source() and fix arguments of stub for intel_display_crc_init(). Signed-off-by: Tomeu Vizoso Fixes: 21165bd933ac ("drm/i915/debugfs: Move out pipe CRC code") Fixes: 13fa0253d97a ("drm/i915: Use new CRC debugfs API") --- drivers/gpu/drm/

[PATCH 1/2] drm/bridge: analogix_dp: Add analogix_dp_psr_supported

So users know whether PSR should be enabled or not. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Cc: Sean Paul <seanp...@chromium.org> Cc: Yakir Yang <y...@rock-chips.com> Cc: Archit Taneja <arch...@codeaurora.org> --- drivers/gpu/drm/bridge/analogi

[PATCH 2/2] drm/rockchip: analogix_dp: Refuse to enable PSR if panel doesn't support it

without PSR (veyron-jaq Chromebook). It's very easy to reproduce by running the kms_rmfb test in IGT a few times. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Cc: Sean Paul <seanp...@chromium.org> Cc: Yakir Yang <y...@rock-chips.com> Cc: Archit Taneja <a

[PATCH 1/2] drm/bridge: analogix_dp: Add analogix_dp_psr_supported

So users know whether PSR should be enabled or not. Signed-off-by: Tomeu Vizoso Cc: Sean Paul Cc: Yakir Yang Cc: Archit Taneja --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 8 include/drm/bridge/analogix_dp.h | 1 + 2 files changed, 9 insertions(+) diff

[PATCH 2/2] drm/rockchip: analogix_dp: Refuse to enable PSR if panel doesn't support it

without PSR (veyron-jaq Chromebook). It's very easy to reproduce by running the kms_rmfb test in IGT a few times. Signed-off-by: Tomeu Vizoso Cc: Sean Paul Cc: Yakir Yang Cc: Archit Taneja --- drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [PATCH] soc: rockchip: power-domain: Handle errors from of_genpd_add_provider_onecell

On 09/16/2016 12:31 AM, Heiko Stübner wrote: > Am Donnerstag, 15. September 2016, 16:39:34 schrieb Heiko Stübner: >> Am Donnerstag, 15. September 2016, 12:43:41 schrieb Tomeu Vizoso: >>> It was a bit surprising that the device was reported to have probed just >>> fine, b

Re: [PATCH] soc: rockchip: power-domain: Handle errors from of_genpd_add_provider_onecell

On 09/16/2016 12:31 AM, Heiko Stübner wrote: > Am Donnerstag, 15. September 2016, 16:39:34 schrieb Heiko Stübner: >> Am Donnerstag, 15. September 2016, 12:43:41 schrieb Tomeu Vizoso: >>> It was a bit surprising that the device was reported to have probed just >>> fine, b

[PATCH v2] PM / Domains: Allow holes in genpd_data.domains array

: 0159ec670763 ("PM / Domains: Verify the PM domain is present when adding a provider") Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Cc: Jon Hunter <jonath...@nvidia.com> Cc: Heiko Stuebner <he...@sntech.de> --- v2: Also skip holes in the error path. --- dri

[PATCH v2] PM / Domains: Allow holes in genpd_data.domains array

: 0159ec670763 ("PM / Domains: Verify the PM domain is present when adding a provider") Signed-off-by: Tomeu Vizoso Cc: Jon Hunter Cc: Heiko Stuebner --- v2: Also skip holes in the error path. --- drivers/base/power/domain.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/

[PATCH] PM / Domains: Allow holes in genpd_data.domains array

: 0159ec670763 ("PM / Domains: Verify the PM domain is present when adding a provider") Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Cc: Jon Hunter <jonath...@nvidia.com> Cc: Heiko Stuebner <he...@sntech.de> --- drivers/base/power/domain.c | 2 ++ 1 file changed,

[PATCH] PM / Domains: Allow holes in genpd_data.domains array

: 0159ec670763 ("PM / Domains: Verify the PM domain is present when adding a provider") Signed-off-by: Tomeu Vizoso Cc: Jon Hunter Cc: Heiko Stuebner --- drivers/base/power/domain.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/base/power/domain.c b/drivers/base/power/doma

[PATCH] soc: rockchip: power-domain: Handle errors from of_genpd_add_provider_onecell

It was a bit surprising that the device was reported to have probed just fine, but the provider hadn't been registered. So handle any errors when registering the provider and fail the probe accordingly. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Cc: Caesar Wang <w...@rock-

[PATCH] soc: rockchip: power-domain: Handle errors from of_genpd_add_provider_onecell

It was a bit surprising that the device was reported to have probed just fine, but the provider hadn't been registered. So handle any errors when registering the provider and fail the probe accordingly. Signed-off-by: Tomeu Vizoso Cc: Caesar Wang --- drivers/soc/rockchip/pm_domains.c | 6

[PATCH] clk: rk808: Pass the right pointer as the get_hw context

Right now we are passing a pointer to a pointer to the structure that will be used to fetch the clk hw, which gets casted later to a pointer to the structure, thus getting garbage in the hw structs. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Fixes: a8b6e85db6a6 ("clk: rk8

[PATCH] clk: rk808: Pass the right pointer as the get_hw context

Right now we are passing a pointer to a pointer to the structure that will be used to fetch the clk hw, which gets casted later to a pointer to the structure, thus getting garbage in the hw structs. Signed-off-by: Tomeu Vizoso Fixes: a8b6e85db6a6 ("clk: rk808: Migrate to clk_hw

[PATCH v8 3/4] drm/i915: Use new CRC debugfs API

skip the 1st or 2nd frames. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_irq.c | 83 +-- drivers/gpu/drm/i

[PATCH v8 2/4] drm: Add API for capturing frame CRCs

definition of drm_debugfs_crtc_crc_add to drm_internal.h v8: - Call debugfs_remove_recursive when we fail to create the minor device Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> --- Documentation/gpu/drm-uapi.

[PATCH v8 4/4] drm/i915: Put "cooked" vlank counters in frame CRC lines

Use drm_accurate_vblank_count so we have the full 32 bit to represent the frame counter and userspace has a simpler way of knowing when the counter wraps around. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> --- dri

[PATCH v8 2/4] drm: Add API for capturing frame CRCs

definition of drm_debugfs_crtc_crc_add to drm_internal.h v8: - Call debugfs_remove_recursive when we fail to create the minor device Signed-off-by: Tomeu Vizoso Reviewed-by: Emil Velikov --- Documentation/gpu/drm-uapi.rst| 6 + drivers/gpu/drm/Makefile | 3 +- drivers/gpu/drm

[PATCH v8 4/4] drm/i915: Put "cooked" vlank counters in frame CRC lines

Use drm_accurate_vblank_count so we have the full 32 bit to represent the frame counter and userspace has a simpler way of knowing when the counter wraps around. Signed-off-by: Tomeu Vizoso Reviewed-by: Emil Velikov --- drivers/gpu/drm/i915/i915_irq.c | 6 +++--- 1 file changed, 3 insertions

[PATCH v8 3/4] drm/i915: Use new CRC debugfs API

skip the 1st or 2nd frames. Signed-off-by: Tomeu Vizoso Reviewed-by: Emil Velikov --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_irq.c | 83 +-- drivers/gpu/drm/i915/intel_display.c | 1 + drivers/gpu/drm/i915/intel_drv.h |

[PATCH v8 1/4] drm/i915/debugfs: Move out pipe CRC code

In preparation to using a generic API in the DRM core for continuous CRC generation, move the related code out of i915_debugfs.c into a new file. Eventually, only the Intel-specific code will remain in this new file. v2: Rebased. v6: Rebased. v7: Fix whitespace issue. Signed-off-by: Tomeu

[PATCH v8 1/4] drm/i915/debugfs: Move out pipe CRC code

In preparation to using a generic API in the DRM core for continuous CRC generation, move the related code out of i915_debugfs.c into a new file. Eventually, only the Intel-specific code will remain in this new file. v2: Rebased. v6: Rebased. v7: Fix whitespace issue. Signed-off-by: Tomeu

[PATCH v8 0/4] New debugfs API for capturing CRC of frames

for hardware that can provide frame CRCs (including eDP panels that support self-refresh) can easily implement the new callback and provide userspace with the CRC values. Thanks, Tomeu Tomeu Vizoso (4): drm/i915/debugfs: Move out pipe CRC code drm: Add API for capturing frame CRCs drm/i915

[PATCH v8 0/4] New debugfs API for capturing CRC of frames

for hardware that can provide frame CRCs (including eDP panels that support self-refresh) can easily implement the new callback and provide userspace with the CRC values. Thanks, Tomeu Tomeu Vizoso (4): drm/i915/debugfs: Move out pipe CRC code drm: Add API for capturing frame CRCs drm/i915

[PATCH v7 2/4] drm: Add API for capturing frame CRCs

definition of drm_debugfs_crtc_crc_add to drm_internal.h Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> --- Documentation/gpu/drm-uapi.rst| 6 + drivers/gpu/drm/Makefile | 3 +- drivers/gpu/drm/drm_crtc.c

<    1   2   3   4   5   6   7   8   9   10   >