RE: [PATCH 2/2] Fixed typo Intel RNG driver for2.6.21-rc7-mm1

Hi Jan, Thank you for the comment. > ># Do you think that a "FWH not detected" message is noisy? > > No, I think it helps understanding why there's no RNG device > in the system. OK, the typo fixes patch was corrected. intel-rng.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[PATCH 1/2] Fix the memory leak Intel RNG driver for 2.6.21-rc7-mm1

This patch fixes a memory leak in mod_init(). In the error, intel_rng_hw was freed. intel-rng.c |8 1 file changed, 4 insertions(+), 4 deletions(-) --- linux-2.6.21-rc7-mm1/drivers/char/hw_random/intel-rng.c.orig 2007-04-26 11:56:03.0 +0900 +++

[PATCH 2/2] Fixed typo Intel RNG driver for 2.6.21-rc7-mm1

This patch fixes a typo in mod_init(). fwh_done is performed when Intel fwh is found. intel-rng.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- linux-2.6.21-rc7-mm1/drivers/char/hw_random/intel-rng.c~2007-04-26 13:41:53.0 +0900 +++

RE: [PATCH 2/2] Fixed typo Intel RNG driver for2.6.21-rc7-mm1

> But why do you remove the printk()? I think that FWH connected to LPC of ICHx are not only Intel products. For example, sst... etc. Does rng address differ in except Intel products? I think that this driver is targeting Intel FWH. Therefore, printk() was removed. # Do you think that a "FWH

[PATCH 0/2] Clean up Intel RNG driver for 2.6.21-rc7-mm1

Hi Prarit and Jan, Clean up Intel RNG driver for 2.6.21-rc7-mm1. Patch 1/2 fixed the memory leak. Patch 2/2 fixed typo. Please give me a comment. -- Haruo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info

[PATCH 0/2] Clean up Intel RNG driver for 2.6.21-rc7-mm1

Hi Prarit and Jan, Clean up Intel RNG driver for 2.6.21-rc7-mm1. Patch 1/2 fixed the memory leak. Patch 2/2 fixed typo. Please give me a comment. -- Haruo - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at

[PATCH 1/2] Fix the memory leak Intel RNG driver for 2.6.21-rc7-mm1

This patch fixes a memory leak in mod_init(). In the error, intel_rng_hw was freed. intel-rng.c |8 1 file changed, 4 insertions(+), 4 deletions(-) --- linux-2.6.21-rc7-mm1/drivers/char/hw_random/intel-rng.c.orig 2007-04-26 11:56:03.0 +0900 +++

[PATCH 2/2] Fixed typo Intel RNG driver for 2.6.21-rc7-mm1

This patch fixes a typo in mod_init(). fwh_done is performed when Intel fwh is found. intel-rng.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- linux-2.6.21-rc7-mm1/drivers/char/hw_random/intel-rng.c~2007-04-26 13:41:53.0 +0900 +++

RE: [PATCH 2/2] Fixed typo Intel RNG driver for2.6.21-rc7-mm1

But why do you remove the printk()? I think that FWH connected to LPC of ICHx are not only Intel products. For example, sst... etc. Does rng address differ in except Intel products? I think that this driver is targeting Intel FWH. Therefore, printk() was removed. # Do you think that a FWH not

RE: [PATCH 2/2] Fixed typo Intel RNG driver for2.6.21-rc7-mm1

Hi Jan, Thank you for the comment. # Do you think that a FWH not detected message is noisy? No, I think it helps understanding why there's no RNG device in the system. OK, the typo fixes patch was corrected. intel-rng.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) ---

RE: libata-dev queue updated

Hi Bunk, Thank you for your replay. > With SCSI=m and SCSI_SATA=y this allows the static enabling > of the SATA drivers with unwanted effects, e.g.: > - SCSI=m, SCSI_SATA=y, SCSI_ATA_ADMA=y > -> SCSI_ATA_ADMA is built statically but scsi/built-in.o is > not linked > into the kernel > -

RE: libata-dev queue updated

Hi Bunk, Thank you for your replay. With SCSI=m and SCSI_SATA=y this allows the static enabling of the SATA drivers with unwanted effects, e.g.: - SCSI=m, SCSI_SATA=y, SCSI_ATA_ADMA=y - SCSI_ATA_ADMA is built statically but scsi/built-in.o is not linked into the kernel - SCSI=m,

RE: libata-dev queue updated

On Thursday, August 25, 2005 8:02 PM (JST), Adrian Bunk wrote: > > 2.6.13- rc7-libata1.patch.bz2 was used. > > A combined mode of ata_piix seems not to work. > > Is the following patches correct? > > > > diff -urN linux-2.6.13-rc7.orig/drivers/scsi/Kconfig >

RE: libata-dev queue updated

Hi Jeff, 2.6.13- rc7-libata1.patch.bz2 was used. A combined mode of ata_piix seems not to work. Is the following patches correct? diff -urN linux-2.6.13-rc7.orig/drivers/scsi/Kconfig linux-2.6.13-rc7/drivers/scsi/Kconfig --- linux-2.6.13-rc7.orig/drivers/scsi/Kconfig 2005-08-25

RE: libata-dev queue updated

Hi Jeff, 2.6.13- rc7-libata1.patch.bz2 was used. A combined mode of ata_piix seems not to work. Is the following patches correct? diff -urN linux-2.6.13-rc7.orig/drivers/scsi/Kconfig linux-2.6.13-rc7/drivers/scsi/Kconfig --- linux-2.6.13-rc7.orig/drivers/scsi/Kconfig 2005-08-25

RE: libata-dev queue updated

On Thursday, August 25, 2005 8:02 PM (JST), Adrian Bunk wrote: 2.6.13- rc7-libata1.patch.bz2 was used. A combined mode of ata_piix seems not to work. Is the following patches correct? diff -urN linux-2.6.13-rc7.orig/drivers/scsi/Kconfig linux-2.6.13-rc7/drivers/scsi/Kconfig ---

RE: Isn't there race issue during fput() and the dentry_open()?

Hi Viro, (B (BThank you for your help and advice. (BI made the following patches referring to your advice. (BI try to debugging by using this patch. (B (BThanks again, (BHaruo (B (Bdiff -urN linux-2.6.12-rc2.orig/fs/file_table.c linux-2.6.12-rc2/fs/file_table.c (B---

RE: Isn't there race issue during fput() and the dentry_open()?

Hi Viro, (B (BThank you for your help and advice. (BI made the following patches referring to your advice. (BI try to debugging by using this patch. (B (BThanks again, (BHaruo (B (Bdiff -urN linux-2.6.12-rc2.orig/fs/file_table.c linux-2.6.12-rc2/fs/file_table.c (B---

RE: Isn't there race issue during fput() and the dentry_open()?

Hi Viro, (B (BThank you for your replay. (B (B> > Stack traceback for pid 2130 (B> > 0xf717f1b0 21301 1 0 R (B> 0xf717f400 *irqbalance (B> > ESP EIP Function (args) (B> > 0xf75bfe38 0xc02d04b2 _spin_lock+0x2e (0xf7441a80) (B> > 0xf75bff34 0xc015667c

RE: Isn't there race issue during fput() and the dentry_open()?

Hi Viro, (B (BThank you for your replay. (B (B Stack traceback for pid 2130 (B 0xf717f1b0 21301 1 0 R (B 0xf717f400 *irqbalance (B ESP EIP Function (args) (B 0xf75bfe38 0xc02d04b2 _spin_lock+0x2e (0xf7441a80) (B 0xf75bff34 0xc015667c file_move+0x14

Isn't there race issue during fput() and the dentry_open()?

Isn't there race issue during fput() and the dentry_open()? (BWhen booting kernel, the following deadlocks are experienced. (B (BStack traceback for pid 2130 (B0xf717f1b0 21301 1 0 R 0xf717f400 *irqbalance (BESP EIP Function (args) (B0xf75bfe38

Isn't there race issue during fput() and the dentry_open()?

Isn't there race issue during fput() and the dentry_open()? (BWhen booting kernel, the following deadlocks are experienced. (B (BStack traceback for pid 2130 (B0xf717f1b0 21301 1 0 R 0xf717f400 *irqbalance (BESP EIP Function (args) (B0xf75bfe38

tty->driver_data is NULL

I obtained following oops. (B (BModules Linked in: parport_pc lp parport autofs4 i2c_dev i2c_core xxxnrpc dm_mod (Bbutton battery ac md5 ipv6 uhci_hcd ehci_hcd e1000 floppy ext3 jbd ata_piix liba (Bta sd_mod scsi_mod (BCPU:0 (BEIP:0060:[<021f39cd>] Not tainted VLI (BEFLAGS:

tty-driver_data is NULL

I obtained following oops. (B (BModules Linked in: parport_pc lp parport autofs4 i2c_dev i2c_core xxxnrpc dm_mod (Bbutton battery ac md5 ipv6 uhci_hcd ehci_hcd e1000 floppy ext3 jbd ata_piix liba (Bta sd_mod scsi_mod (BCPU:0 (BEIP:0060:[021f39cd] Not tainted VLI (BEFLAGS: