Re: [PATCH 00/19] staging/wilc1000 cleanups

2015-10-27 Thread Tony Cho
and contribution. Thanks, Tony. On 2015년 10월 23일 16:51, Tony Cho wrote: Hi Arnd, First of all, I would like to say "thank you" for your efforts and contributions. We are updating the driver because new revision came up and making new patches to make it stable and elegant as Linux driver. In

Re: [PATCH 00/19] staging/wilc1000 cleanups

2015-10-27 Thread Tony Cho
and contribution. Thanks, Tony. On 2015년 10월 23일 16:51, Tony Cho wrote: Hi Arnd, First of all, I would like to say "thank you" for your efforts and contributions. We are updating the driver because new revision came up and making new patches to make it stable and elegant as Linux driver. In

Re: [PATCH 00/19] staging/wilc1000 cleanups

2015-10-23 Thread Tony Cho
Hi Arnd, First of all, I would like to say "thank you" for your efforts and contributions. We are updating the driver because new revision came up and making new patches to make it stable and elegant as Linux driver. In these days, we are sending big changes while testing such patches and

Re: [PATCH 00/19] staging/wilc1000 cleanups

2015-10-23 Thread Tony Cho
Hi Arnd, First of all, I would like to say "thank you" for your efforts and contributions. We are updating the driver because new revision came up and making new patches to make it stable and elegant as Linux driver. In these days, we are sending big changes while testing such patches and

Re: [PATCH] staging/wilc: fix Kconfig dependencies, second try

2015-10-19 Thread Tony Cho
Hi Arnd Bergmann, When I apply this patch, I cannot make WILC1000 module (wilc1000.ko) because CONFIG_WILC1000 is y and also I can see some link errors for the cfg80211 APIs. Can you consider this patch? Thanks, Tony. On 2015년 10월 17일 05:45, Arnd Bergmann wrote: My first attempt to fix

Re: [PATCH] staging/wilc: fix Kconfig dependencies, second try

2015-10-19 Thread Tony Cho
Hi Arnd Bergmann, When I apply this patch, I cannot make WILC1000 module (wilc1000.ko) because CONFIG_WILC1000 is y and also I can see some link errors for the cfg80211 APIs. Can you consider this patch? Thanks, Tony. On 2015년 10월 17일 05:45, Arnd Bergmann wrote: My first attempt to fix

Re: staging: wilc1000: WILC1000_DYNAMICALLY_ALLOCATE_MEMROY

2015-10-11 Thread Tony Cho
On 2015년 10월 09일 03:47, Greg KH wrote: On Thu, Oct 08, 2015 at 09:29:35PM +0300, Stanislav Kholmanskikh wrote: Hi! I noticed that drivers/staging/wilc1000/Kconfic defines: config WILC1000_DYNAMICALLY_ALLOCATE_MEMROY bool "Dynamically allocate memory in real time"

Re: staging: wilc1000: WILC1000_DYNAMICALLY_ALLOCATE_MEMROY

2015-10-11 Thread Tony Cho
On 2015년 10월 09일 03:29, Stanislav Kholmanskikh wrote: Hi! I noticed that drivers/staging/wilc1000/Kconfic defines: config WILC1000_DYNAMICALLY_ALLOCATE_MEMROY bool "Dynamically allocate memory in real time" ---help--- This choice supports dynamic allocation of

Re: staging: wilc1000: WILC1000_DYNAMICALLY_ALLOCATE_MEMROY

2015-10-11 Thread Tony Cho
On 2015년 10월 09일 03:29, Stanislav Kholmanskikh wrote: Hi! I noticed that drivers/staging/wilc1000/Kconfic defines: config WILC1000_DYNAMICALLY_ALLOCATE_MEMROY bool "Dynamically allocate memory in real time" ---help--- This choice supports dynamic allocation of

Re: staging: wilc1000: WILC1000_DYNAMICALLY_ALLOCATE_MEMROY

2015-10-11 Thread Tony Cho
On 2015년 10월 09일 03:47, Greg KH wrote: On Thu, Oct 08, 2015 at 09:29:35PM +0300, Stanislav Kholmanskikh wrote: Hi! I noticed that drivers/staging/wilc1000/Kconfic defines: config WILC1000_DYNAMICALLY_ALLOCATE_MEMROY bool "Dynamically allocate memory in real time"

Re: [PATCH 2/2] drivers: staging: wilc1000: Call kfree only for error cases

2015-10-04 Thread Tony Cho
On 2015년 10월 04일 19:28, Chandra Gorentla wrote: On Sun, Oct 04, 2015 at 09:44:57AM +0100, Greg KH wrote: On Sat, Oct 03, 2015 at 02:57:30PM +0530, Chandra S Gorentla wrote: - kfree is being called for the members of the queue without de-queuing them; they are just inserted within this

Re: [PATCH 1/2] drivers: staging: wilc1000: Move spin lock to the start of critical section

2015-10-04 Thread Tony Cho
On 2015년 10월 04일 17:43, Greg KH wrote: On Sat, Oct 03, 2015 at 02:57:29PM +0530, Chandra S Gorentla wrote: The spin_lock_irqsave is moved to just beginning of critical section. This change moves a couple of return statements out of the lock. Signed-off-by: Chandra S Gorentla ---

Re: [PATCH 2/2] drivers: staging: wilc1000: Call kfree only for error cases

2015-10-04 Thread Tony Cho
On 2015년 10월 04일 19:28, Chandra Gorentla wrote: On Sun, Oct 04, 2015 at 09:44:57AM +0100, Greg KH wrote: On Sat, Oct 03, 2015 at 02:57:30PM +0530, Chandra S Gorentla wrote: - kfree is being called for the members of the queue without de-queuing them; they are just inserted within this

Re: [PATCH 1/2] drivers: staging: wilc1000: Move spin lock to the start of critical section

2015-10-04 Thread Tony Cho
On 2015년 10월 04일 17:43, Greg KH wrote: On Sat, Oct 03, 2015 at 02:57:29PM +0530, Chandra S Gorentla wrote: The spin_lock_irqsave is moved to just beginning of critical section. This change moves a couple of return statements out of the lock. Signed-off-by: Chandra S Gorentla