Re: [PATCH] Remove MODULE_ALIAS() calls that take undefined macro

2019-05-06 Thread Tony Lindgren
> > Reported-by: Stephen Rothwell > > Signed-off-by: Masahiro Yamada > > --- > > Acked-by: Daniel Lezcano Thanks, please feel free to merge together with your series: Acked-by: Tony Lindgren Or if you want me to queue it separately, please let me know. Regards, Tony

Re: [PATCH] ARM: dts: dra76x: Update MMC2_HS200_MANUAL1 iodelay values

2019-05-02 Thread Tony Lindgren
* Faiz Abbas [190502 06:28]: > Hi Tony, > > On 30/04/19 9:24 PM, Tony Lindgren wrote: > > Hi, > > > > * Faiz Abbas [190429 23:09]: > >> Update the MMC2_HS200_MANUAL1 iodelay values to match with the latest > >> dra76x data manual[1]. > >> &

Re: [PATCH] ARM: dts: am57xx-idk: Remove support for voltage switching for SD card

2019-05-02 Thread Tony Lindgren
* Faiz Abbas [190502 14:30]: > Hi Tony, > > On 02/05/19 7:50 PM, Tony Lindgren wrote: > > * Faiz Abbas [190502 01:48]: > >> If UHS speed modes are enabled, a compatible SD card switches down to > >> 1.8V during enumeration. If after this a software reboot/crash

Re: [PATCH] ARM: dts: am57xx-idk: Remove support for voltage switching for SD card

2019-05-02 Thread Tony Lindgren
* Faiz Abbas [190502 01:48]: > If UHS speed modes are enabled, a compatible SD card switches down to > 1.8V during enumeration. If after this a software reboot/crash takes > place and on-chip ROM tries to enumerate the SD card, the difference in > IO voltages (host @ 3.3V and card @ 1.8V) may end

[PATCH 2/2] bus: ti-sysc: Handle devices with no control registers

2019-05-01 Thread Tony Lindgren
: Tony Lindgren --- arch/arm/boot/dts/am33xx-l4.dtsi | 4 arch/arm/boot/dts/am437x-l4.dtsi | 4 drivers/bus/ti-sysc.c| 23 +++ 3 files changed, 11 insertions(+), 20 deletions(-) diff --git a/arch/arm/boot/dts/am33xx-l4.dtsi b/arch/arm/boot/dts/am33xx-l4

[PATCH 0/2] Two ti-sysc driver fixes for v5.3 merge window

2019-05-01 Thread Tony Lindgren
Hi all, Here are few fixes for the am335x d_can boot issue Sebastian reported for Beaglebone. Regards, Tony Tony Lindgren (2): ARM: dts: Configure osc clock for d_can on am335x bus: ti-sysc: Handle devices with no control registers arch/arm/boot/dts/am33xx-l4.dtsi | 14

[PATCH 1/2] ARM: dts: Configure osc clock for d_can on am335x

2019-05-01 Thread Tony Lindgren
: Enable all clocks directly during init to read revision") Reported-by: Sebastian Andrzej Siewior Signed-off-by: Tony Lindgren --- arch/arm/boot/dts/am33xx-l4.dtsi | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/am33xx-l4.dtsi b/arch/arm/boo

Re: next/master boot bisection: next-20190430 on beagle-xm

2019-05-01 Thread Tony Lindgren
* Sebastian Andrzej Siewior [190501 21:14]: > On 2019-05-01 13:21:49 [-0700], Tony Lindgren wrote: > > Hi, > Hi, > > > OK I found two issues. It seems that d_can also needs osc clock > > on am335x. And there's no revision register for d_can.. We're now >

Re: next/master boot bisection: next-20190430 on beagle-xm

2019-05-01 Thread Tony Lindgren
Hi, * Sebastian Andrzej Siewior [190501 19:03]: > On 2019-05-01 10:44:31 [-0700], Tony Lindgren wrote: > > Hmm so I tried without "earlycon" in command line thinking it might be > > happening with just "earlyprintk" but still no luck. > > > > BTW,

Re: next/master boot bisection: next-20190430 on beagle-xm

2019-05-01 Thread Tony Lindgren
* Sebastian Andrzej Siewior [190501 17:01]: > On 2019-05-01 09:52:24 [-0700], Tony Lindgren wrote: > > > > Oh interesting thanks for letting me know. Next boots fine for me here > > > > with NFSroot on BBB. > > > > > > > > Do you ha

Re: next/master boot bisection: next-20190430 on beagle-xm

2019-05-01 Thread Tony Lindgren
* Sebastian Andrzej Siewior [190501 16:45]: > On 2019-05-01 09:29:44 [-0700], Tony Lindgren wrote: > > Hi, > > > > * Sebastian Andrzej Siewior [190501 15:37]: > > > > > > On 2019-04-30 13:51:40 [-0700], kernelci.org bot wrote: > > > > nex

Re: next/master boot bisection: next-20190430 on beagle-xm

2019-05-01 Thread Tony Lindgren
Hi, * Sebastian Andrzej Siewior [190501 15:37]: > > On 2019-04-30 13:51:40 [-0700], kernelci.org bot wrote: > > next/master boot bisection: next-20190430 on beagle-xm > > > > Summary: > > Start: f43b05fd4c17 Add linux-next specific files for 20190430 > > Details:https://kernelci.or

Re: [PATCH v8 00/14] Add support for TISCI Interrupt controller drivers

2019-05-01 Thread Tony Lindgren
t; > object. Want to start posting DT nodes. > > Santosh, Tony: what do you prefer? I don't care either way, but I need > a word from either of you. Best to keep the series together IMO, and it's a tiny patch unlikely to conflict with anything. Here's an ack from me for patch 14 from me: Acked-by: Tony Lindgren

Re: [PATCH] ARM: dts: dra76x: Update MMC2_HS200_MANUAL1 iodelay values

2019-04-30 Thread Tony Lindgren
Hi, * Faiz Abbas [190429 23:09]: > Update the MMC2_HS200_MANUAL1 iodelay values to match with the latest > dra76x data manual[1]. > > Also this particular pinctrl-array is using spaces instead of tabs for > spacing between the values and the comments. Fix this as well. Is this needed as a fix o

Re: [PATCH] soc: ti: pm33xx: Add a print while entering RTC only mode with DDR in self-refresh

2019-04-29 Thread Tony Lindgren
* santosh.shilim...@oracle.com [190429 18:40]: > On 4/28/19 9:44 PM, Keerthy wrote: > > Currently there is no way to distinguish if the SoC entered DS0 > > mode or the RTC only mode. Hence add a print before entering > > the RTC only mode. > > > > Signed-off-by: Keerthy > > --- > Acked-by: Santo

Re: clk/clk-next boot bisection: v5.1-rc1-142-ga55b079c961b on panda

2019-04-25 Thread Tony Lindgren
Hi, * Guillaume Tucker [190425 17:44]: > On 25/04/2019 18:28, Mark Brown wrote: > > On Tue, Apr 23, 2019 at 07:40:28AM -0700, Tony Lindgren wrote: > > > >> Hmm do you guys have some index page of all the found "boot bisection" > >> issues that I ca

Re: linux-next: manual merge of the tegra tree with the rockchip tree

2019-04-24 Thread Tony Lindgren
* Stephen Rothwell [190423 23:43]: > Hi all, > > Today's linux-next merge of the tegra tree got a conflict in: > > arch/arm/configs/multi_v7_defconfig > > between commit: > > 366391f04177 ("ARM: multi_v7_defconfig: Enable missing drivers for > supported Chromebooks") > > from the rockchi

Re: [PATCH v3 1/4] ARM: use arch_extension directive instead of arch argument

2019-04-24 Thread Tony Lindgren
* Stefan Agner [190423 20:20]: > On 11.04.2019 09:54, Stefan Agner wrote: > > The LLVM Target parser currently does not allow to specify the security > > extension as part of -march (see also LLVM Bug 40186 [0]). When trying > > to use Clang with LLVM's integrated assembler, this leads to build >

Re: [PATCH v3 2/4] ARM: OMAP2: drop explicit assembler architecture

2019-04-24 Thread Tony Lindgren
* Stefan Agner [190411 07:53]: > OMAP2 depends on ARCH_MULTI_V6, which makes sure that the kernel is > compiled with -march=armv6. The compiler frontend will pass the > architecture to the assembler. There is no explicit architecture > specification necessary. Acked-by: Tony Lindgren

Re: clk/clk-next boot bisection: v5.1-rc1-142-ga55b079c961b on panda

2019-04-23 Thread Tony Lindgren
e *dev, > > init.name = name; > > init.ops = &clk_fixed_factor_ops; > > init.flags = flags | CLK_IS_BASIC; > > - init.parent_names = &parent_name; > > + if (parent_name) > > + init.parent_names = &parent_n

Re: [PATCH] ARM: OMAP1: ams-delta: fix early boot crash when LED support is disabled

2019-04-16 Thread Tony Lindgren
* Pavel Machek [190416 07:14]: > On Tue 2019-04-16 02:37:32, Aaro Koskinen wrote: > > When we boot with the LED support (CONFIG_NEW_LEDS) disabled, > > gpio_led_register_device() will return a NULL pointer and we try > > to dereference it. Fix by checking also for a NULL pointer. > > > > Fixes: 1

Re: [PATCH 00/17] ARM: dts: am335x: Replace numeric pinmux address w. macro for remaining boards

2019-04-15 Thread Tony Lindgren
* Christina Quast [190412 09:27]: > Last patch set of the patch series for the remaining 17 boards. Thanks applying into omap-for-v5.2/dt-am3. Regards, Tony

Re: [PATCH v2 1/1] ARM: dts: dra7: Separate AM57 dtsi files

2019-04-12 Thread Tony Lindgren
* Roger Quadros [190408 09:43]: > AM5 and DRA7 SoC families have different set of modules > in them so the SoC sepecific dtsi files need to be separated. > > e.g. Some of the major differences between AM576 and DRA76 > > DRA76x AM576x > > USB3 x > USB4 x > ATL

Re: [PATCH 1/2] dt-binding: arm: omap: Add information for AM5748

2019-04-12 Thread Tony Lindgren
* Roger Quadros [190405 13:28]: > Add DT binding details for AM5748 SoC and AM5748 IDK. Seems trivial enough for me to pick up with no acks. Adding into omap-for-v5.2/dt. Regards, Tony > Signed-off-by: Roger Quadros > --- > Documentation/devicetree/bindings/arm/omap/omap.txt | 6 ++ > 1

Re: [PATCH 00/15] ARM: dts: am335x: Replace numeric pinmux address w. macro for more boards

2019-04-12 Thread Tony Lindgren
* Christina Quast [190409 09:04]: > Depends on the following patch set: > [PATCH v2 0/6] ARM: dts: am335x: Replace numeric pinmux address with macro > defines > > Replace the numeric pinmux address with the macro defines for an additional > 15 boards. Thanks applying these into omap-for-v5.2/d

Re: [PATCH -next] bus: ti-sysc: Use PTR_ERR_OR_ZERO in sysc_init_resets()

2019-04-12 Thread Tony Lindgren
* YueHaibing [190411 02:36]: > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Thanks but I'll rather skip this one as I find it a bit hard to read unless there's some reasoning other than compress few lines out of the code. Regards, TOny

Re: [PATCH] clocksource/drivers/timer-ti-dm: Remove omap_dm_timer_set_load_start

2019-04-12 Thread Tony Lindgren
* Nathan Chancellor [190412 05:00]: > On Thu, Apr 11, 2019 at 01:56:57PM -0700, Tony Lindgren wrote: > > Hi, > > > > * Daniel Lezcano [190411 19:21]: > > > On 10/04/2019 22:07, Tony Lindgren wrote: > > > > Hi, > > > > > > > > *

Re: [PATCH v6 06/12] dt-bindings: irqchip: Introduce TISCI Interrupt router bindings

2019-04-12 Thread Tony Lindgren
* Tero Kristo [190412 08:43]: > On 12/04/2019 07:24, Lokesh Vutla wrote: > > > > > > On 11/04/19 8:30 PM, Tony Lindgren wrote: > > > Hi, > > > > > > * Lokesh Vutla [190410 04:15]: > > > > +Example: > > > > + &g

Re: [PATCH v6 04/12] firmware: ti_sci: Add RM mapping table for am654

2019-04-12 Thread Tony Lindgren
* Lokesh Vutla [190412 04:08]: > > > On 11/04/19 8:24 PM, Tony Lindgren wrote: > > Hi, > > > > * Lokesh Vutla [190410 04:15]: > >> From: Peter Ujfalusi > >> diff --git a/Documentation/devicetree/bindings/arm/keystone/ti,sci.txt > >&g

Re: [PATCH] clocksource/drivers/timer-ti-dm: Remove omap_dm_timer_set_load_start

2019-04-11 Thread Tony Lindgren
Hi, * Daniel Lezcano [190411 19:21]: > On 10/04/2019 22:07, Tony Lindgren wrote: > > Hi, > > > > * Daniel Lezcano [190410 17:02]: > >> can you ask for an acked-by before pulling a patch in your tree? > > > > I certainly do ask and wait for acks wh

Re: [PATCH] clocksource/drivers/timer-ti-dm: Remove omap_dm_timer_set_load_start

2019-04-11 Thread Tony Lindgren
Hi, * Daniel Lezcano [190411 20:13]: > I can see those fixes in timers/core: > > Fixes: 592ea6bd1fad ("clocksource: timer-ti-dm: Make unexported > functions static") Hmm so this one was over a year ago related to the PWM series :) > Fixes: 008258d995a6 ("clocksource/drivers/timer-ti-dm: Make >

Re: [PATCH v2] bus: ti-sysc: Add generic enable/disable functions

2019-04-11 Thread Tony Lindgren
Hi, * Roger Quadros [190408 02:53]: > For non legacy cases, add generic sysc_enable_module() > and sysc_disable_module() functions. ... > - Add helper to get best idle mode. > - Add comment about not preventing clockdomain autoidle > during enable/disable. FYI I have a patch in works to popul

Re: [PATCH v6 06/12] dt-bindings: irqchip: Introduce TISCI Interrupt router bindings

2019-04-11 Thread Tony Lindgren
Hi, * Lokesh Vutla [190410 04:15]: > +Example: > + > +The following example demonstrates both interrupt router node and the > consumer > +node(main gpio) on the AM654 SoC: > + > +main_intr: interrupt-controller0 { > + compatible = "ti,sci-intr"; > + ti,intr-trigger-type = <1>; >

Re: [PATCH v6 04/12] firmware: ti_sci: Add RM mapping table for am654

2019-04-11 Thread Tony Lindgren
t;ti,k2g-sci", .data = &ti_sci_pmmc_k2g_desc}, > + {.compatible = "ti,am654-sci", .data = &ti_sci_pmmc_am654_desc}, > { /* Sentinel */ }, > }; > MODULE_DEVICE_TABLE(of, ti_sci_of_match); Great, this approach with mapping table in the driver based on the compatible looks good to me and avoids stuffing the IDs into device tree: Acked-by: Tony Lindgren

Re: [PATCH] clocksource/drivers/timer-ti-dm: Remove omap_dm_timer_set_load_start

2019-04-10 Thread Tony Lindgren
ent "seems like no other takers" was for Ladislav regarding somebody picking up his earlier work, not for picking up this patch :) In any case, I've been waiting for you guys to pick up the patch, here's my ack if you're waiting for it: Acked-by: Tony Lindgren > On

Re: [PATCH v2] bus: ti-sysc: Add generic enable/disable functions

2019-04-09 Thread Tony Lindgren
* Roger Quadros [190408 02:53]: > For non legacy cases, add generic sysc_enable_module() > and sysc_disable_module() functions. > > Signed-off-by: Roger Quadros > --- > Boot tested on > - beagle-x15 (AM5728 GP EVM) > - AM571x IDK > - DRA7 EVM > > Changelog: > v2: > - Add helper to get best idle

Re: [PATCH 4/4] ARM: dts: omap2420-n810: Use new CODEC reset pin name

2019-04-09 Thread Tony Lindgren
* Andrew F. Davis [190329 11:13]: > The correct DT property for specifying a GPIO used for reset > is "reset-gpios", the driver now accepts this name, use it here. I'll apply this patch into omap-for-v5.2/dt thanks. Tony

Re: [PATCH 4/5] ARM: OMAP: Wakeupgen: AM43xx HS devices should save context like non-HS

2019-04-09 Thread Tony Lindgren
* Andrew F. Davis [190329 17:53]: > Unlike some previous generation devices, AM43xx HS IRQ and Wakegen > context is handled by the ROM for us, and no secure service call > is needed or supported. Non-GP AM43xx devices should take the > same path as GP. Applying the two SoC related changes into om

Re: [PATCH 1/5] ARM: dts: am43xx-epos-evm: Keep DCDC5 and DCDC6 always on

2019-04-09 Thread Tony Lindgren
* Andrew F. Davis [190329 10:53]: > From: Kabir Sahane > > These regulator outputs are needed even in deep sleep modes to prevent > low-voltage detection events. Make these always ON to avoid this. Thanks applying the three dts changes into omap-for-v5.2/dt. Regards, Tony

Re: [PATCH] ARM: dts: dra7: Add properties to enable PCIe x2 lane mode

2019-04-09 Thread Tony Lindgren
* Kishon Vijay Abraham I [190325 02:46]: > ti,syscon-lane-sel and ti,syscon-lane-conf properties specific to enable > PCIe x2 lane mode are added here. Applying into omap-for-v5.2/dt thanks. Tony

Re: [GIT PULL v2] LM3532 backlight support improvements and relocation

2019-04-09 Thread Tony Lindgren
* Dan Murphy [190408 20:04]: > Tony > > On 4/8/19 2:30 PM, Tony Lindgren wrote: > > * Dan Murphy [190408 15:54]: > > > On 4/7/19 5:17 PM, Pavel Machek wrote: > > > > Plus, I'd kind of expect ALS enabled/disabled to be runtime controled, > > > &

Re: [PATCH v2 1/3] ARM: use arch_extension directive instead of arch argument

2019-04-09 Thread Tony Lindgren
Hi, * Stefan Agner [190408 20:59]: > --- a/arch/arm/mach-omap2/Makefile > +++ b/arch/arm/mach-omap2/Makefile > @@ -41,11 +41,6 @@ obj-$(CONFIG_SOC_OMAP5)+= > $(omap-4-5-common) $(smp-y) sleep44xx.o > obj-$(CONFIG_SOC_AM43XX) += $(omap-4-5-common) > obj-$(CONFIG_

Re: linux-next: manual merge of the rtc tree with the omap tree

2019-04-09 Thread Tony Lindgren
* Keerthy [190409 13:25]: > > > On 09/04/19 10:52 AM, Stephen Rothwell wrote: > > Hi all, > > > > Today's linux-next merge of the rtc tree got a conflict in: > > > >drivers/rtc/rtc-omap.c > > > > between commit: > > > >6256f7f7f217 ("rtc: OMAP: Add support for rtc-only mode") > > >

Re: [PATCH 3/3] ARM: omap2: move platform-specific asm-offset.h to arch/arm/mach-omap2

2019-04-09 Thread Tony Lindgren
* Masahiro Yamada [190409 07:06]: > On Tue, Apr 9, 2019 at 2:17 PM Keerthy wrote: > > > > > > > > On 09/04/19 10:37 AM, Masahiro Yamada wrote: > > > On Tue, Apr 9, 2019 at 2:00 PM Keerthy wrote: > > >> > > >> > &

Re: [GIT PULL v2] LM3532 backlight support improvements and relocation

2019-04-08 Thread Tony Lindgren
* Dan Murphy [190408 15:54]: > On 4/7/19 5:17 PM, Pavel Machek wrote: > > Plus, I'd kind of expect ALS enabled/disabled to be runtime controled, > > not from the device tree. > > We can always add runtime override control to the driver. Yeah that sounds good to me :) Sounds like this can be done

Re: [PATCH 11/14] bus: ti-sysc: Add quirk handling for external optional functional clock

2019-04-08 Thread Tony Lindgren
* Tony Lindgren [190325 22:00]: > @@ -200,6 +278,12 @@ static int sysc_get_clocks(struct sysc *ddata) > if (ddata->nr_clocks < 1) > return 0; > > + if ((ddata->cfg.quirks & SYSC_QUIRK_EXT_OPT_CLOCK)) { > + error = sysc

Re: [PATCH 3/3] ARM: omap2: move platform-specific asm-offset.h to arch/arm/mach-omap2

2019-04-08 Thread Tony Lindgren
Hi, * Masahiro Yamada [190408 07:56]: > is only generated and included > by arch/arm/mach-omap2/, so it does not need to reside in the > globally visible include/generated/. > > I moved and renamed it to arch/arm/mach-omap2/pm-asm-offsets.h > since the prefix 'omap2-' is just redundant in mach-

Re: [PATCH 2/4] ARM: dts: omap4-droid4: Update backlight dt properties

2019-04-04 Thread Tony Lindgren
t; > > + linux,default-trigger = "backlight"; > > + }; > > + > > + led@1 { > > + reg = <1>; > > + led-sources = <1>; > > + ti,led-mode = &

Re: [PATCH][V2] Documentation: bus: ti-sysc: fix spelling mistakes "multipe" and "interconnet"

2019-04-04 Thread Tony Lindgren
* Mukesh Ojha [190404 11:23]: > > On 4/4/2019 4:46 PM, Colin King wrote: > > From: Colin Ian King > > > > There is are a couple of spelling mistakes in the Documentation. Fix them. Thanks will pick this up for v5.2. Regards, Tony

Re: [PATCH] clocksource/drivers/timer-ti-dm: Remove omap_dm_timer_set_load_start

2019-04-04 Thread Tony Lindgren
* Ladislav Michl [190327 08:12]: > Hello Nathan, > > On Tue, Mar 26, 2019 at 10:01:27PM -0700, Nathan Chancellor wrote: > > Commit 008258d995a6 ("clocksource/drivers/timer-ti-dm: Make > > omap_dm_timer_set_load_start() static") made omap_dm_time_set_load_start > > static because its prototype was

Re: [PATCH] clocksource: timer-ti-dm: Remove unused omap_dm_timer_set_load_start

2019-04-04 Thread Tony Lindgren
* Keerthy [190404 06:35]: > omap_dm_timer_set_load_start is no longer used hence delete the > function and remove the below warning. > > drivers/clocksource/timer-ti-dm.c:589:12: > warning: ‘omap_dm_timer_set_load_start’ defined but not used Hmm see earlier "[PATCH] clocksource/drivers/timer-ti-

Re: [PATCH 4/4] leds: lm3532: Introduce the lm3532 LED driver

2019-04-03 Thread Tony Lindgren
with linux-next and Sebastian's DSI command mode patches "[PATCHv6 0/4] omapdrm: DSI command mode panel support". So feel free to add: Tested-by: Tony Lindgren

Re: [PATCH 3/4] mfd: ti-lmu: Remove LM3532 backlight driver references

2019-04-03 Thread Tony Lindgren
* Dan Murphy [190321 14:29]: > Remove the LM3532 backlight driver references from the ti-lmu > code as dedicated driver support is available. Acked-by: Tony Lindgren

Re: [PATCH 1/4] dt: lm3532: Add lm3532 dt doc and update ti_lmu doc

2019-04-03 Thread Tony Lindgren
not control bank configurable. These include the runtime ramp > and the ALS configuration. Acked-by: Tony Lindgren

Re: [PATCH 2/4] ARM: dts: omap4-droid4: Update backlight dt properties

2019-04-03 Thread Tony Lindgren
Hi, * Dan Murphy [190321 14:29]: > Update the properties for the lm3532 device node for droid4. > With this change the backlight LED string and the keypad > LED strings will be controlled separately. We also need the following incremental change to prevent panel-dsi-cm trying to use of_find_back

Re: [PATCH 4/4] leds: lm3532: Introduce the lm3532 LED driver

2019-04-03 Thread Tony Lindgren
* Tony Lindgren [190403 13:06]: > * Sebastian Reichel [190329 05:36]: > > Hi, > > > > On Mon, Mar 25, 2019 at 11:01:18AM -0500, Dan Murphy wrote: > > > On 3/25/19 9:54 AM, Tony Lindgren wrote: > > > > * Dan Murphy [190325 12:36]: > > > >

Re: [PATCH 4/4] leds: lm3532: Introduce the lm3532 LED driver

2019-04-03 Thread Tony Lindgren
* Sebastian Reichel [190329 05:36]: > Hi, > > On Mon, Mar 25, 2019 at 11:01:18AM -0500, Dan Murphy wrote: > > On 3/25/19 9:54 AM, Tony Lindgren wrote: > > > * Dan Murphy [190325 12:36]: > > >> On 3/22/19 5:16 PM, Tony Lindgren wrote: > > >>> I

Re: [PATCH 05/14] bus: ti-sysc: Add separate functions for handling clocks

2019-04-03 Thread Tony Lindgren
* Tony Lindgren [190325 22:00]: > Let's also add error handling to shut down already enabled clocks > while at it. ... > --- a/drivers/bus/ti-sysc.c > +++ b/drivers/bus/ti-sysc.c > +err_disable: > + for (; i >= 0; i--) { > + clock = ddata->clocks

Re: [RFC PATCH 1/4] ARM: dts: dra7: Keep usb_otg_ss3 and usb_otg_ss4 disabled

2019-04-03 Thread Tony Lindgren
* Roger Quadros [190403 14:54]: > Below patch is just to get initial feedback. Is the overall approach of > splitting > into DRA7 vs AM5 dtsi files OK? Yes makes sense to me. And if the devices are on the interconnect but not fully functional, we probably want to set the status = "disabled" only

Re: [RFC PATCH 2/4] bus: ti-sysc: Add generic enable/disable functions

2019-04-02 Thread Tony Lindgren
* Roger Quadros [190402 13:38]: > For non legacy cases, add generic sysc_enable_module() > and sysc_disable_module() functions. Looks OK to me. Can you please add a comment mentioning that we're not currently blocking clockdomain autoidle? See clkdm_deny_idle() use in omap_hwmod.c. > + if (i

Re: [RFC PATCH 4/4] bus: ti-sysc: Ensure PRU-ICSS doesn't break suspend/resume

2019-04-02 Thread Tony Lindgren
* Roger Quadros [190402 13:38]: > The PRU-ICSS subsystem's SYSCONFIG register is similar to > omap4-simple but has 2 special bits STANDBY_INIT and SUB_MWAIT. > > The STANDBY_INIT bit initiates a Standby sequence (when set) and > triggers a MStandby request to the SoC's PRCM module. This same > bi

Re: [RFC PATCH 1/4] ARM: dts: dra7: Keep usb_otg_ss3 and usb_otg_ss4 disabled

2019-04-02 Thread Tony Lindgren
* Roger Quadros [190402 13:38]: > These 2 modules are not present on all families (e.g. AM57). > Keep them disabled. Can you please add comments to the dtsi file for why "disabled" is set? Otherwise we may end up removing them at some point as the default should be just enabled with no status pro

Re: [BUG/PATCH 1/4] DTS: GTA04: SPI / gpiolib: work around a regression that unhides a broken legacy handler, which makes the gta04 display inoperable

2019-04-01 Thread Tony Lindgren
* H. Nikolaus Schaller [190401 16:57]: > > Am 01.04.2019 um 18:46 schrieb Tony Lindgren : > > So what's the plan with this fix? Add this for v5.2-rc cycle, > > then revert it later? I'd probably go directly for the proper > > fix if possible. > > Well, I

Re: [BUG/PATCH 1/4] DTS: GTA04: SPI / gpiolib: work around a regression that unhides a broken legacy handler, which makes the gta04 display inoperable

2019-04-01 Thread Tony Lindgren
Hi, * H. Nikolaus Schaller [190331 10:08]: > This is an ugly workaround for a regression introduced into v5.1-rc1 by > > You should standardized commit references like this instead: c1c04cea13dc ("gpio: of: Fix logic inversion") Then please also include a proper Fixes tag. You can configure

Re: [PATCH 3/4] ARM: dts: dra7: add PRU-ICSS modules

2019-04-01 Thread Tony Lindgren
* Roger Quadros [190329 14:02]: > Hi Tony, > > On 04/02/2019 20:03, Tony Lindgren wrote: > > * Roger Quadros [190204 15:54]: > >> --- a/arch/arm/boot/dts/dra7.dtsi > >> +++ b/arch/arm/boot/dts/dra7.dtsi > >> @@ -167,6 +167,200 @@ >

Re: [PATCH 09/14] bus: ti-sysc: Move rstctrl reset to happen later

2019-03-27 Thread Tony Lindgren
* Suman Anna [190327 16:27]: > On 3/26/19 6:40 PM, Tony Lindgren wrote: > > That's for rstctrl. I just did a quick test with my earlier > > reset-simple patch and I noticed sgx on am33xx produces a > > clock error unless we deassert it's rstrctrl before enabling &g

Re: [PATCH 09/14] bus: ti-sysc: Move rstctrl reset to happen later

2019-03-26 Thread Tony Lindgren
Hi, * Suman Anna [190326 23:22]: > On 3/26/19 6:13 PM, Tony Lindgren wrote: > Hmm, are you envisioning the SYSC reset (OCP SoftReset) here or the PRCM > RSTCTRL hardresets here? The latter in general requires the clocks to be > running first (module won't be in ready status u

Re: [PATCH 09/14] bus: ti-sysc: Move rstctrl reset to happen later

2019-03-26 Thread Tony Lindgren
* Tony Lindgren [190325 22:00]: > We should not do the reset until the clocks are enabled. Let's only init > restctrl in sysc_init_resets() and do the reset later on in sysc_reset(). ... > static int sysc_reset(struct sysc *ddata) > { > int offset = ddata->

[PATCH 02/14] bus: ti-sysc: Handle missed no-idle property in addition to no-idle-on-init

2019-03-25 Thread Tony Lindgren
ned-off-by: Tony Lindgren --- Documentation/devicetree/bindings/bus/ti-sysc.txt | 2 ++ arch/arm/mach-omap2/omap_hwmod.c | 2 ++ drivers/bus/ti-sysc.c | 5 - include/linux/platform_data/ti-sysc.h | 5 +++-- 4 files changed, 11 insert

[PATCH 06/14] bus: ti-sysc: Enable all clocks directly during init to read revision

2019-03-25 Thread Tony Lindgren
() at this point. To read the revision register, let's just enable the all the clocks for the interconnect target module during init even if the optional clocks are not needed. That way we can read the revision register to configure the quirks needed for PM runtime. Signed-off-by: Ton

[PATCH 07/14] bus: ti-sysc: Allocate mdata as needed and do platform data based init later

2019-03-25 Thread Tony Lindgren
ocate mdata as needed so it's available for sysc_legacy_init() that we call with module clocks enabled from sysc_init_module(). Signed-off-by: Tony Lindgren --- drivers/bus/ti-sysc.c | 54 +++ 1 file changed, 39 insertions(+), 15 deletions(-) diff --git

[PATCH 03/14] bus: ti-sysc: Make functions static

2019-03-25 Thread Tony Lindgren
We can make sysc_write() and sysc_child_pm_domain static as noted by sparse. Signed-off-by: Tony Lindgren --- drivers/bus/ti-sysc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c --- a/drivers/bus/ti-sysc.c +++ b/drivers/bus

[PATCH 11/14] bus: ti-sysc: Add quirk handling for external optional functional clock

2019-03-25 Thread Tony Lindgren
ff-by: Tony Lindgren --- drivers/bus/ti-sysc.c | 90 ++- include/linux/platform_data/ti-sysc.h | 1 + 2 files changed, 90 insertions(+), 1 deletion(-) diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c --- a/drivers/bus/ti-sysc.c +++ b/drivers/bus/ti-s

[PATCH 10/14] bus: ti-sysc: Add support for early quirks based on register address

2019-03-25 Thread Tony Lindgren
n for sysc_init_early_quirks(). Note that we cannot yet enable the early quirks for mcpdm until the optional external clocks are handled in the in the following patch. Signed-off-by: Tony Lindgren --- drivers/bus/ti-sysc.c | 46 +++ 1 file changed, 42 insertions(

[PATCH 14/14] bus: ti-sysc: Detect DMIC for debugging

2019-03-25 Thread Tony Lindgren
Detect DMIC to see what we have connected if config DEBUG is enabled. Signed-off-by: Tony Lindgren --- drivers/bus/ti-sysc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c --- a/drivers/bus/ti-sysc.c +++ b/drivers/bus/ti-sysc.c @@ -999,6 +999,7

[PATCH 09/14] bus: ti-sysc: Move rstctrl reset to happen later

2019-03-25 Thread Tony Lindgren
We should not do the reset until the clocks are enabled. Let's only init restctrl in sysc_init_resets() and do the reset later on in sysc_reset(). Signed-off-by: Tony Lindgren --- drivers/bus/ti-sysc.c | 61 ++- 1 file changed, 37 insertions(+

[PATCH 12/14] bus: ti-sysc: Pass clockactivity quirk to platform functions

2019-03-25 Thread Tony Lindgren
We already have the clockactivity quirk set for some modules like i2c, timers and smartreflex. But we're not passing it to the platform functions yet. Let's start doing that in preparation of dropping interconnect target module platform data in favor of device tree based data. Signed-of

[PATCH 05/14] bus: ti-sysc: Add separate functions for handling clocks

2019-03-25 Thread Tony Lindgren
ocks while at it. Signed-off-by: Tony Lindgren --- drivers/bus/ti-sysc.c | 141 -- 1 file changed, 123 insertions(+), 18 deletions(-) diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c --- a/drivers/bus/ti-sysc.c +++ b/drivers/bus/ti-sysc.c

[PATCH 08/14] bus: ti-sysc: Manage clocks for the interconnect target module in all cases

2019-03-25 Thread Tony Lindgren
ff-by: Tony Lindgren --- drivers/bus/ti-sysc.c | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c --- a/drivers/bus/ti-sysc.c +++ b/drivers/bus/ti-sysc.c @@ -783,10 +783,8 @@ static int __maybe_u

[PATCH 13/14] bus: ti-sysc: Handle swsup idle mode quirks

2019-03-25 Thread Tony Lindgren
as we drop the platform data and test the changes. Signed-off-by: Tony Lindgren --- arch/arm/mach-omap2/omap_hwmod.c | 6 ++ drivers/bus/ti-sysc.c | 6 +++--- include/linux/platform_data/ti-sysc.h | 3 +++ 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/arc

[PATCH 01/14] bus: ti-sysc: Fix sysc_unprepare() when no clocks have been allocated

2019-03-25 Thread Tony Lindgren
If we return early before ddata->clocks have been allocated we will get a NULL pointer dereference in sysc_unprepare(). Let's fix this by returning early when no clocks are allocated. Fixes: 0eecc636e5a2 ("bus: ti-sysc: Add minimal TI sysc interconnect target driver") S

[PATCH 04/14] bus: ti-sysc: Move legacy platform data idling into separate functions

2019-03-25 Thread Tony Lindgren
Let's move the legacy idle and enable into separate functions to simplify PM runtime functions a bit. Signed-off-by: Tony Lindgren --- drivers/bus/ti-sysc.c | 78 +++ 1 file changed, 50 insertions(+), 28 deletions(-) diff --git a/drivers/bus/ti-sys

[PATCH 00/14] ti-sysc changes to probe devices with dts data only

2019-03-25 Thread Tony Lindgren
Y HWMOD_RECONFIG_IO_CHAIN HWMOD_CLKDM_NOAUTO I'll be posting patches for these later on as needed. Regards, Tony Tony Lindgren (14): bus: ti-sysc: Fix sysc_unprepare() when no clocks have been allocated bus: ti-sysc: Handle missed no-idle property in addition to no-idle-on-init bus: ti-sysc: M

Re: [PATCH 4/4] leds: lm3532: Introduce the lm3532 LED driver

2019-03-25 Thread Tony Lindgren
* Dan Murphy [190325 12:36]: > On 3/22/19 5:16 PM, Tony Lindgren wrote: > > I can control the backlight brightness just fine via /sys, and > > backlight shows up as the trigger in /sys/class/leds/lm3532:backlight, > > but /sys/class/backlight is empty and looks like drm can&#

Re: [PATCH 11/12] ARM: OMAP2+: add missing of_node_put after of_device_is_available

2019-03-22 Thread Tony Lindgren
* Julia Lawall [190223 13:58]: > Add an of_node_put when a tested device node is not available. > > The semantic patch that fixes this problem is as follows > (http://coccinelle.lip6.fr): > > // > @@ > identifier f; > local idexpression e; > expression x; > @@ > > e = f(...); > ... when != of_

Re: [PATCH] ARM: OMAP1: ams-delta: Fix broken GPIO ID allocation

2019-03-22 Thread Tony Lindgren
* Aaro Koskinen [190320 01:02]: > On Tue, Mar 19, 2019 at 09:19:52PM +0100, Janusz Krzysztofik wrote: > > In order to request dynamic allocationn of GPIO IDs, a negative number > > should be passed as a base GPIO ID via platform data. Unfortuntely, > > commit 771e53c4d1a1 ("ARM: OMAP1: ams-delta:

Re: [PATCH 4/4] leds: lm3532: Introduce the lm3532 LED driver

2019-03-22 Thread Tony Lindgren
Hi, * Dan Murphy [190321 14:29]: > Introduce the Texas Instruments LM3532 White LED driver. > The driver supports ALS configurability or manual brightness > control. > > The driver also supports associating LED strings with specific > control banks in a group or as individually controlled string

Re: [PATCH 2/2] ARM: dts: am335x: Replaced register offsets with defines

2019-03-14 Thread Tony Lindgren
* Christina Quast [190314 16:03]: > On 14/03/2019 16:05, Tony Lindgren wrote: > > * Christina Quast [190313 14:28]: > >> The defines are taken from dt-bindings/pinctrl/am335x.h > >> > >> Updated AM33XX_IOPAD to take three instead of two parameter

Re: [PATCH] ARM: omap2: remove incorrect __init annotation

2019-03-14 Thread Tony Lindgren
nd Bergmann > > Reviewed-by: Nathan Chancellor Arnd please just apply this directly, this should not cause merge conflicts: Acked-by: Tony Lindgren

Re: [PATCH 2/2] ARM: dts: am335x: Replaced register offsets with defines

2019-03-14 Thread Tony Lindgren
* Christina Quast [190313 14:28]: > The defines are taken from dt-bindings/pinctrl/am335x.h > > Updated AM33XX_IOPAD to take three instead of two parameters: > AM33XX_IOPAD(register_offset, pin_direction_pullups, mux_mode) Thanks that works great for making things work eventually with #pinctrl-c

Re: [PATCH 1/2] ARM: dts: am335x: Replace numeric pinmux address with macro defines

2019-03-14 Thread Tony Lindgren
Hi, * Christina Quast [190313 14:28]: > The values are extraced from the "AM335x SitaraTM Processors Technical > Reference Manual", Section 9.3.1 CONTROL_MODULE Registers, based on the > file autogenerated by TI PinMux. Thanks for updating this series. Few comments below. > diff --git a/include

Re: [PATCH v5 00/18] mfd: demodularization of non-modular drivers

2019-03-07 Thread Tony Lindgren
* Pavel Machek [190307 08:35]: > > > > Pavel, I hope this more extended explanation makes sense to you, and > > > that you simply have not seen me write these same details in the past. > > > > Blimey. That's a really long winded way of saying: > > > > "Modular-ness is actually broken in thes

Re: [PATCH 3/3] phy: mapphone-mdm6600: add gpiolib dependency

2019-03-05 Thread Tony Lindgren
mapphone-mdm6600.c:220:24: error: 'values[0]' is > used uninitialized in this function [-Werror=uninitialized] > > This could be fixed more generally in gpiolib by returning a failure > code, but for this specific case, the easier workaround is to add a > gpiolib dependency. Thanks for fixing it: Acked-by: Tony Lindgren

Re: [PATCH] Revert "dma-contiguous: do not allocate a single page from CMA area"

2019-02-26 Thread Tony Lindgren
t; > I guess the question is whether to add alloc_page()/free_page() fallbacks to > those call sites, or stuff them directly into the CMA helpers here. Well if you come up with some test patch, I can easily test it :) > > Would you please test and verify? Thanks! Yes this revert works for me: Tested-by: Tony Lindgren

Re: Regression: SUNRPC: Use poll() to fix up the socket requeue races

2019-02-26 Thread Tony Lindgren
* Trond Myklebust [190226 20:40]: > I've applied the following patch to my 'testing' branch: > http://git.linux-nfs.org/?p=trondmy/linux-nfs.git;a=patch;h=a73881c96d73ee72b7dbbd38a6eeef66182a8ef7 > > It has so far stood up to testing on my side, so I'm expecting to push > it to linux-next this e

Regression in Linux next with dma cma changes

2019-02-26 Thread Tony Lindgren
Hi, Looks like commit d222e42e8816 ("dma-contiguous: do not allocate a single page from CMA area") caused a regression at least for omap dss where we now get the following error on init: omapdss_dispc 58001000.dispc: dispc_errata_i734_wa_init: dma_alloc_writecombine failed Any ideas what might b

Re: Regression: SUNRPC: Use poll() to fix up the socket requeue races

2019-02-26 Thread Tony Lindgren
Hi, * Trond Myklebust [700101 00:00]: > On Mon, 2019-02-25 at 22:27 +, Jon Hunter wrote: > > On 25/02/2019 21:03, Trond Myklebust wrote: > > This is nfsroot. I don't specify any particular NFS version from > > the kernel cmdline, but this is seen with ARM kernel configs > > tegra_defconfig a

Re: [PATCH 2/2] regulator: cpcap: Constify omap4_regulators and xoom_regulators

2019-02-26 Thread Tony Lindgren
* Axel Lin [190226 05:52]: > They should never change, make them const. Acked-by: Tony Lindgren

Re: [PATCH 1/2] regulator: cpcap: Remove unused vsel_shift from struct cpcap_regulator

2019-02-26 Thread Tony Lindgren
* Axel Lin [190226 05:52]: > This driver uses regulator_get/set_voltage_sel_regmap so it does not use > vsel_shift. Actually, vsel_shift can be calculated by vsel_mask setting. Thanks for doing this, still works for me: Tested-by: Tony Lindgren

Re: [PATCH] mfd: twl-core: disable irq while suspended

2019-02-23 Thread Tony Lindgren
i2c access problems when the irq registers are checked. Thanks for fixing this, still works fine for me for rtcwake: Tested-by: Tony Lindgren

<    3   4   5   6   7   8   9   10   11   12   >