This patch adds support for the Power Button keypad found on
Wondermedia netbooks/tablets.
A keymap property is exposed to allowing defining the key
event to be generated when the power button is pressed.
Signed-off-by: Tony Prisk
---
.../bindings/input/vt8500-power-keypad.txt | 17
This patch adds support for the Wondermedia serial flash controller
found on WM8505, WM8650 and WM8850 SoCs.
Signed-off-by: Tony Prisk
---
v2: Whitespace tidyup
drivers/mtd/devices/Kconfig |7 +
drivers/mtd/devices/Makefile |3 +-
drivers/mtd/devices/wmt_sflash.c | 614
This patch adds support for the Wondermedia serial flash controller
found on WM8505, WM8650 and WM8850 SoCs.
Signed-off-by: Tony Prisk
---
drivers/mtd/devices/Kconfig |7 +
drivers/mtd/devices/Makefile |3 +-
drivers/mtd/devices/wmt_sflash.c | 614
The vendor does not provide numbering for gpio pins. Vendor source
exports dedicated gpio pins first, followed by multifunction pins.
As this is what end users expect, this patch changes vt8500 and wm8505
to do the same.
Signed-off-by: Tony Prisk
---
drivers/gpio/gpio-vt8500.c |4 ++--
1
. Change
pwm_busy_wait() to use readl rather than readb.
Improve readability of code with defines for registers and bitfields.
Signed-off-by: Tony Prisk
---
Thierry,
This patch is a fix but it can go to 3.9 rather than 3.8 (if you prefer)
as the incorrect behaviour doesn't seem to cause a problem
Add support to set polarity on pwm devices, allowing for inverted
duty cycles.
Also update the binding document to #pwm-cells = <3> to allow
passing the flags from devicetree.
Signed-off-by: Tony Prisk
---
.../devicetree/bindings/pwm/vt8500-pwm.txt |7 ---
drivers/p
year field is incorrectly masked when setting the date. If the year
is beyond 2099, the year field will be incorrectly updated in hardware.
This patch masks the year field correctly.
Signed-off-by: Edgar Toernig
Signed-off-by: Tony Prisk
---
Patch based on 3.8-rc1
drivers/rtc/rtc-vt8500.c
year field is incorrectly masked when setting the date. If the year
is beyond 2099, the year field will be incorrectly updated in hardware.
This patch masks the year field correctly.
Signed-off-by: Edgar Toernig fro...@gmx.de
Signed-off-by: Tony Prisk li...@prisktech.co.nz
---
Patch based on 3.8
. Change
pwm_busy_wait() to use readl rather than readb.
Improve readability of code with defines for registers and bitfields.
Signed-off-by: Tony Prisk li...@prisktech.co.nz
---
Thierry,
This patch is a fix but it can go to 3.9 rather than 3.8 (if you prefer)
as the incorrect behaviour doesn't seem
Add support to set polarity on pwm devices, allowing for inverted
duty cycles.
Also update the binding document to #pwm-cells = 3 to allow
passing the flags from devicetree.
Signed-off-by: Tony Prisk li...@prisktech.co.nz
---
.../devicetree/bindings/pwm/vt8500-pwm.txt |7
The vendor does not provide numbering for gpio pins. Vendor source
exports dedicated gpio pins first, followed by multifunction pins.
As this is what end users expect, this patch changes vt8500 and wm8505
to do the same.
Signed-off-by: Tony Prisk li...@prisktech.co.nz
---
drivers/gpio/gpio
This patch adds support for the Wondermedia serial flash controller
found on WM8505, WM8650 and WM8850 SoCs.
Signed-off-by: Tony Prisk li...@prisktech.co.nz
---
drivers/mtd/devices/Kconfig |7 +
drivers/mtd/devices/Makefile |3 +-
drivers/mtd/devices/wmt_sflash.c | 614
This patch adds support for the Wondermedia serial flash controller
found on WM8505, WM8650 and WM8850 SoCs.
Signed-off-by: Tony Prisk li...@prisktech.co.nz
---
v2: Whitespace tidyup
drivers/mtd/devices/Kconfig |7 +
drivers/mtd/devices/Makefile |3 +-
drivers/mtd/devices
This patch adds support for the Power Button keypad found on
Wondermedia netbooks/tablets.
A keymap property is exposed to allowing defining the key
event to be generated when the power button is pressed.
Signed-off-by: Tony Prisk li...@prisktech.co.nz
---
.../bindings/input/vt8500-power
platform at compile-time. If compiling for a multiplatform
kernel, all platforms must use the DT version or only one platform
can have i8042 support.
The DT version assumes memory-mapped i8042 registers. It can not handle
IO-mapped modules (eg. x86)
Tony Prisk (1):
input: i8042: Add support
This patch adds basic devicetree support for the i8042 controller
driver.
Simple properties to specify the register offsets.
Optional properties to specify the linux device descriptions.
Signed-off-by: Tony Prisk li...@prisktech.co.nz
---
.../devicetree/bindings/input/intel-8042.txt
+Example:
+ powerkey: pwrkey@0 {
+ compatible = wm,power-keypad;
+ interrupts = 22;
+ keymap = 116; /* KEY_POWER */
Do we really need this in DT? I'd say just having it manageable from
userspace is enough.
Just seemed easier this way. Will be changed.
This patch adds support for the Power Button keypad found on
Wondermedia netbooks/tablets.
Signed-off-by: Tony Prisk li...@prisktech.co.nz
---
v2:
Remove devicetree binding for keycode
Add dependency on OF in Kconfig
Move static variables in a struct
Remove redundant inline modifier from
of the
century flag.
Signed-off-by: Edgar Toernig
Signed-off-by: Tony Prisk
---
This patch is based on 3.8rc1 with the previous fix applied:
Previous patch: 77cdf96a0654cb45b4dd530f3393c6a8f2fa1e0b
rtc: vt8500: Correct handling of CR_24H bitfield
drivers/rtc/rtc-vt8500.c |7 ---
1 file changed
of the
century flag.
Signed-off-by: Edgar Toernig fro...@gmx.de
Signed-off-by: Tony Prisk li...@prisktech.co.nz
---
This patch is based on 3.8rc1 with the previous fix applied:
Previous patch: 77cdf96a0654cb45b4dd530f3393c6a8f2fa1e0b
rtc: vt8500: Correct handling of CR_24H bitfield
drivers/rtc/rtc
On Fri, 2012-12-28 at 10:21 +0600, Alexey Charkov wrote:
>
> On Dec 28, 2012 3:21 AM, "Tony Prisk" wrote:
> >
> > This patch moves debug-macro.S from arm/mach-vt8500/include/mach to
> > arm/include/debug/vt8500.S to provide multiplatform support.
>
&
This patch moves debug-macro.S from arm/mach-vt8500/include/mach to
arm/include/debug/vt8500.S to provide multiplatform support.
Minor style changes in code for readability.
Signed-off-by: Tony Prisk
---
Patch resend due to missing arch/arm/include/debug/vt8500.S
arch/arm/Kconfig.debug
This patch moves debug-macro.S from arm/mach-vt8500/include/mach to
arm/include/debug/vt8500.S to provide multiplatform support.
Minor style changes in code for readability.
Signed-off-by: Tony Prisk li...@prisktech.co.nz
---
Patch resend due to missing arch/arm/include/debug/vt8500.S
arch/arm
On Fri, 2012-12-28 at 10:21 +0600, Alexey Charkov wrote:
On Dec 28, 2012 3:21 AM, Tony Prisk li...@prisktech.co.nz wrote:
This patch moves debug-macro.S from arm/mach-vt8500/include/mach to
arm/include/debug/vt8500.S to provide multiplatform support.
Hi Tony!
Looks like you haven't
This patch adds support for the I2C controller found on Wondermedia
SoCs.
Due to the lack of pinmux support, GPIO pin alternate functions are
configured by machine's compatible property, as are pullups.
Signed-off-by: Tony Prisk
---
.../devicetree/bindings/i2c/i2c-vt8500.txt | 24
This patch adds support for the new PLL module found in WM8750 and
WM8850 SoCs.
Signed-off-by: Tony Prisk
---
drivers/clk/clk-vt8500.c | 102 +-
1 file changed, 100 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/clk-vt8500.c b/drivers/clk
This patch moves debug-macro.S from arm/mach-vt8500/include/mach to
arm/include/debug/vt8500.S to provide multiplatform support.
Minor style changes in code for readability.
Signed-off-by: Tony Prisk
---
arch/arm/Kconfig.debug |8 ++
arch/arm/mach-vt8500
This patch adds support for the WM8750 (ARMv6) and WM8850 (ARMv7).
Common features across all SoCs are split into ARCH_VT8500 and
unique features are specified by each SoC option.
Signed-off-by: Tony Prisk
---
Documentation/devicetree/bindings/arm/vt8500.txt |8 ++
arch/arm/Kconfig
Remove the last two mach-vt8500/include/mach headers as they are
no longer required with multiplatform-only configuration.
Signed-off-by: Tony Prisk
---
arch/arm/mach-vt8500/include/mach/timex.h | 26 -
arch/arm/mach-vt8500/include/mach/uncompress.h | 37
Hi Arnd/Olaf,
These patches should be pretty self explanatory.
#1 - Adds support for WM8750 and WM8850.
#2 - Remove the single-platform Kconfig options.
#3 - Move the early debug code so it can be used for multiplatform.
#4 - Cleanup the unused headers in arch/arm/mach-vt8500/include.
Tony
This patch completes the move of arch-vt8500 to multiplatform only.
The remaining single-image Kconfig options are removed from
arch/arm/Kconfig and the options in arch/arm/mach-vt8500/Kconfig
are updated.
Signed-off-by: Tony Prisk
---
arch/arm/Kconfig | 21
Hi Arnd/Olaf,
These patches should be pretty self explanatory.
#1 - Adds support for WM8750 and WM8850.
#2 - Remove the single-platform Kconfig options.
#3 - Move the early debug code so it can be used for multiplatform.
#4 - Cleanup the unused headers in arch/arm/mach-vt8500/include.
Tony
This patch completes the move of arch-vt8500 to multiplatform only.
The remaining single-image Kconfig options are removed from
arch/arm/Kconfig and the options in arch/arm/mach-vt8500/Kconfig
are updated.
Signed-off-by: Tony Prisk li...@prisktech.co.nz
---
arch/arm/Kconfig | 21
This patch moves debug-macro.S from arm/mach-vt8500/include/mach to
arm/include/debug/vt8500.S to provide multiplatform support.
Minor style changes in code for readability.
Signed-off-by: Tony Prisk li...@prisktech.co.nz
---
arch/arm/Kconfig.debug |8 ++
arch
This patch adds support for the WM8750 (ARMv6) and WM8850 (ARMv7).
Common features across all SoCs are split into ARCH_VT8500 and
unique features are specified by each SoC option.
Signed-off-by: Tony Prisk li...@prisktech.co.nz
---
Documentation/devicetree/bindings/arm/vt8500.txt |8
Remove the last two mach-vt8500/include/mach headers as they are
no longer required with multiplatform-only configuration.
Signed-off-by: Tony Prisk li...@prisktech.co.nz
---
arch/arm/mach-vt8500/include/mach/timex.h | 26 -
arch/arm/mach-vt8500/include/mach/uncompress.h
This patch adds support for the new PLL module found in WM8750 and
WM8850 SoCs.
Signed-off-by: Tony Prisk li...@prisktech.co.nz
---
drivers/clk/clk-vt8500.c | 102 +-
1 file changed, 100 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/clk
This patch adds support for the I2C controller found on Wondermedia
SoCs.
Due to the lack of pinmux support, GPIO pin alternate functions are
configured by machine's compatible property, as are pullups.
Signed-off-by: Tony Prisk li...@prisktech.co.nz
---
.../devicetree/bindings/i2c/i2c-vt8500
This patch adds support for .fb_check_var which is required when
X attempts to initialize the framebuffer. The only supported
resolution is the native resolution of the LCD panel, so we test
against the resolution supplied from the DT panel definition.
Signed-off-by: Tony Prisk
---
drivers
Control register bitfield for 12H/24H mode is handled incorrectly.
Setting CR_24H actually enables 12H mode. This patch renames the
define and changes the initialization code to correctly set
24H mode.
Signed-off-by: Tony Prisk
---
drivers/rtc/rtc-vt8500.c |4 ++--
1 file changed, 2
A request to vt8500_dclk_(round_rate/set_rate) with rate=0 results
in a division-by-0 in the kernel.
Signed-off-by: Tony Prisk
---
drivers/clk/clk-vt8500.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/clk-vt8500.c b/drivers/clk/clk-vt8500.c
When a PLL frequency calculation is performed and a non-exact match
is found the wrong multiplier and divisors are returned.
Signed-off-by: Tony Prisk
---
drivers/clk/clk-vt8500.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/clk/clk-vt8500.c b/drivers/clk
would have had a decimal result.
Signed-off-by: Tony Prisk
---
drivers/clk/clk-vt8500.c |8
1 file changed, 8 insertions(+)
diff --git a/drivers/clk/clk-vt8500.c b/drivers/clk/clk-vt8500.c
index 0cb26be..3306c2b 100644
--- a/drivers/clk/clk-vt8500.c
+++ b/drivers/clk/clk-vt8500.c
Mike,
Three bugfixes for 3.8.
#1 was a boo-boo on my part, function returned the wrong variables.
#2 is a truncation problem which results in a higher-than-requested clock rate.
#3 became apparent when the MMC driver started requesting rate=0 during init.
Tony Prisk (3):
clk: vt8500: Fix
Mike,
Three bugfixes for 3.8.
#1 was a boo-boo on my part, function returned the wrong variables.
#2 is a truncation problem which results in a higher-than-requested clock rate.
#3 became apparent when the MMC driver started requesting rate=0 during init.
Tony Prisk (3):
clk: vt8500: Fix
When a PLL frequency calculation is performed and a non-exact match
is found the wrong multiplier and divisors are returned.
Signed-off-by: Tony Prisk li...@prisktech.co.nz
---
drivers/clk/clk-vt8500.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/clk/clk
would have had a decimal result.
Signed-off-by: Tony Prisk li...@prisktech.co.nz
---
drivers/clk/clk-vt8500.c |8
1 file changed, 8 insertions(+)
diff --git a/drivers/clk/clk-vt8500.c b/drivers/clk/clk-vt8500.c
index 0cb26be..3306c2b 100644
--- a/drivers/clk/clk-vt8500.c
+++ b
A request to vt8500_dclk_(round_rate/set_rate) with rate=0 results
in a division-by-0 in the kernel.
Signed-off-by: Tony Prisk li...@prisktech.co.nz
---
drivers/clk/clk-vt8500.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/clk-vt8500.c b
Control register bitfield for 12H/24H mode is handled incorrectly.
Setting CR_24H actually enables 12H mode. This patch renames the
define and changes the initialization code to correctly set
24H mode.
Signed-off-by: Tony Prisk li...@prisktech.co.nz
---
drivers/rtc/rtc-vt8500.c |4 ++--
1
This patch adds support for .fb_check_var which is required when
X attempts to initialize the framebuffer. The only supported
resolution is the native resolution of the LCD panel, so we test
against the resolution supplied from the DT panel definition.
Signed-off-by: Tony Prisk li
On Wed, 2012-12-19 at 19:08 +, Russell King - ARM Linux wrote:
> On Thu, Dec 20, 2012 at 08:00:49AM +1300, Tony Prisk wrote:
> > On Thu, 2012-12-20 at 06:34 +1300, Tony Prisk wrote:
> > > On Wed, 2012-12-19 at 09:26 +, Russell King - ARM Linux wrote:
> > > >
On Thu, 2012-12-20 at 06:34 +1300, Tony Prisk wrote:
> On Wed, 2012-12-19 at 09:26 +, Russell King - ARM Linux wrote:
> > On Wed, Dec 19, 2012 at 05:10:33PM +1300, Tony Prisk wrote:
> > > Hi Mike,
> > >
> > > In attempting to remove some IS_ERR_OR_NULL
On Wed, 2012-12-19 at 09:26 +, Russell King - ARM Linux wrote:
> On Wed, Dec 19, 2012 at 05:10:33PM +1300, Tony Prisk wrote:
> > Hi Mike,
> >
> > In attempting to remove some IS_ERR_OR_NULL references, it was pointed
> > out that clk_get() can return NULL if CON
On Wed, 2012-12-19 at 09:26 +, Russell King - ARM Linux wrote:
On Wed, Dec 19, 2012 at 05:10:33PM +1300, Tony Prisk wrote:
Hi Mike,
In attempting to remove some IS_ERR_OR_NULL references, it was pointed
out that clk_get() can return NULL if CONFIG_HAVE_CLK is not defined
On Thu, 2012-12-20 at 06:34 +1300, Tony Prisk wrote:
On Wed, 2012-12-19 at 09:26 +, Russell King - ARM Linux wrote:
On Wed, Dec 19, 2012 at 05:10:33PM +1300, Tony Prisk wrote:
Hi Mike,
In attempting to remove some IS_ERR_OR_NULL references, it was pointed
out that clk_get() can
On Wed, 2012-12-19 at 19:08 +, Russell King - ARM Linux wrote:
On Thu, Dec 20, 2012 at 08:00:49AM +1300, Tony Prisk wrote:
On Thu, 2012-12-20 at 06:34 +1300, Tony Prisk wrote:
On Wed, 2012-12-19 at 09:26 +, Russell King - ARM Linux wrote:
On Wed, Dec 19, 2012 at 05:10:33PM +1300
to be defined in clk.h
when HAVE_CLK is undefined - is this correct?
Regards
Tony Prisk
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please re
On Wed, 2012-12-19 at 08:11 +1300, Tony Prisk wrote:
> On Tue, 2012-12-18 at 22:03 +0300, Dan Carpenter wrote:
> > I don't care either way, but being different from the documentation
> > is less bad than crashing which is what your patch does. Please
> > be more
On Tue, 2012-12-18 at 22:03 +0300, Dan Carpenter wrote:
> I don't care either way, but being different from the documentation
> is less bad than crashing which is what your patch does. Please
> be more careful in the future.
>
> regards,
> dan carpenter
Critism accepted.
Given that the driver
On Tue, 2012-12-18 at 21:39 +0300, Dan Carpenter wrote:
> On Wed, Dec 19, 2012 at 06:34:05AM +1300, Tony Prisk wrote:
> > Resend to include mailing lists.
> >
> > Replace IS_ERR_OR_NULL with IS_ERR on clk_get results.
> >
>
> The original code is correct. cl
Resend to include mailing lists.
Replace IS_ERR_OR_NULL with IS_ERR on clk_get results.
Signed-off-by: Tony Prisk
CC: Kyungmin Park
CC: Tomasz Stanislawski
CC: linux-me...@vger.kernel.org
---
drivers/media/platform/s5p-g2d/g2d.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions
Resend to include mailing lists.
Replace IS_ERR_OR_NULL with IS_ERR on clk_get results.
Signed-off-by: Tony Prisk
CC: Kyungmin Park
CC: Tomasz Stanislawski
CC: linux-me...@vger.kernel.org
---
drivers/media/platform/s5p-fimc/fimc-mdevice.c |2 +-
1 file changed, 1 insertion(+), 1 deletion
been clk_get'd yet.
Signed-off-by: Tony Prisk
CC: Inki Dae
CC: Joonyoung Shim
CC: Seung-Woo Kim
CC: Kyungmin Park
CC: dri-de...@lists.freedesktop.org
---
drivers/gpu/drm/exynos/exynos_mixer.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm
Resend to include mailing lists.
Replace IS_ERR_OR_NULL with IS_ERR on clk_get results.
Signed-off-by: Tony Prisk
Acked-by: Tony Lindgren
---
arch/arm/plat-omap/dmtimer.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/plat-omap/dmtimer.c b/arch/arm/plat
Resend to include mailing lists.
Replace IS_ERR_OR_NULL with IS_ERR on clk_get results.
Signed-off-by: Tony Prisk
CC: Inki Dae
CC: Joonyoung Shim
CC: Seung-Woo Kim
CC: Kyungmin Park
CC: dri-de...@lists.freedesktop.org
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 10 +-
1 file
Resend to include mailing lists.
Replace IS_ERR_OR_NULL with IS_ERR on clk_get results.
Signed-off-by: Tony Prisk
CC: Kyungmin Park
CC: Tomasz Stanislawski
CC: linux-me...@vger.kernel.org
---
drivers/media/platform/s5p-tv/hdmi_drv.c | 10 +-
drivers/media/platform/s5p-tv
lid IS_ERR() condition containing errno.
This patch set replaces instances of IS_ERR_OR_NULL tests againt clk_get()
results with IS_ERR tests.
Tony Prisk (6):
clk: omap: Fix incorrect usage of IS_ERR_OR_NULL
clk: exynos: Fix incorrect usage of IS_ERR_OR_NULL
clk: exynos: Fix incor
() condition containing errno.
This patch set replaces instances of IS_ERR_OR_NULL tests againt clk_get()
results with IS_ERR tests.
Tony Prisk (6):
clk: omap: Fix incorrect usage of IS_ERR_OR_NULL
clk: exynos: Fix incorrect usage of IS_ERR_OR_NULL
clk: exynos: Fix incorrect usage
Resend to include mailing lists.
Replace IS_ERR_OR_NULL with IS_ERR on clk_get results.
Signed-off-by: Tony Prisk li...@prisktech.co.nz
CC: Kyungmin Park kyungmin.p...@samsung.com
CC: Tomasz Stanislawski t.stanisl...@samsung.com
CC: linux-me...@vger.kernel.org
---
drivers/media/platform/s5p-tv
Resend to include mailing lists.
Replace IS_ERR_OR_NULL with IS_ERR on clk_get results.
Signed-off-by: Tony Prisk li...@prisktech.co.nz
CC: Inki Dae inki@samsung.com
CC: Joonyoung Shim jy0922.s...@samsung.com
CC: Seung-Woo Kim sw0312@samsung.com
CC: Kyungmin Park kyungmin.p
Resend to include mailing lists.
Replace IS_ERR_OR_NULL with IS_ERR on clk_get results.
Signed-off-by: Tony Prisk li...@prisktech.co.nz
Acked-by: Tony Lindgren t...@atomide.com
---
arch/arm/plat-omap/dmtimer.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm
been clk_get'd yet.
Signed-off-by: Tony Prisk li...@prisktech.co.nz
CC: Inki Dae inki@samsung.com
CC: Joonyoung Shim jy0922.s...@samsung.com
CC: Seung-Woo Kim sw0312@samsung.com
CC: Kyungmin Park kyungmin.p...@samsung.com
CC: dri-de...@lists.freedesktop.org
---
drivers/gpu/drm/exynos
Resend to include mailing lists.
Replace IS_ERR_OR_NULL with IS_ERR on clk_get results.
Signed-off-by: Tony Prisk li...@prisktech.co.nz
CC: Kyungmin Park kyungmin.p...@samsung.com
CC: Tomasz Stanislawski t.stanisl...@samsung.com
CC: linux-me...@vger.kernel.org
---
drivers/media/platform/s5p
Resend to include mailing lists.
Replace IS_ERR_OR_NULL with IS_ERR on clk_get results.
Signed-off-by: Tony Prisk li...@prisktech.co.nz
CC: Kyungmin Park kyungmin.p...@samsung.com
CC: Tomasz Stanislawski t.stanisl...@samsung.com
CC: linux-me...@vger.kernel.org
---
drivers/media/platform/s5p-g2d
On Tue, 2012-12-18 at 21:39 +0300, Dan Carpenter wrote:
On Wed, Dec 19, 2012 at 06:34:05AM +1300, Tony Prisk wrote:
Resend to include mailing lists.
Replace IS_ERR_OR_NULL with IS_ERR on clk_get results.
The original code is correct. clk_get() can return NULL depending
On Tue, 2012-12-18 at 22:03 +0300, Dan Carpenter wrote:
I don't care either way, but being different from the documentation
is less bad than crashing which is what your patch does. Please
be more careful in the future.
regards,
dan carpenter
Critism accepted.
Given that the driver
On Wed, 2012-12-19 at 08:11 +1300, Tony Prisk wrote:
On Tue, 2012-12-18 at 22:03 +0300, Dan Carpenter wrote:
I don't care either way, but being different from the documentation
is less bad than crashing which is what your patch does. Please
be more careful in the future.
regards
to be defined in clk.h
when HAVE_CLK is undefined - is this correct?
Regards
Tony Prisk
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ
On Mon, 2012-12-17 at 13:02 -0800, Stephen Boyd wrote:
> Reduce lines of code and simplify this driver by using the
> generic clock binding parsing function.
>
> Signed-off-by: Stephen Boyd
> Cc: Tony Prisk
> ---
> drivers/clk/clk-vt8500.c | 39 +++-
On Mon, 2012-12-17 at 13:02 -0800, Stephen Boyd wrote:
Reduce lines of code and simplify this driver by using the
generic clock binding parsing function.
Signed-off-by: Stephen Boyd sb...@codeaurora.org
Cc: Tony Prisk li...@prisktech.co.nz
---
drivers/clk/clk-vt8500.c | 39
so this is
> moved up to the place where it is needed, eliminating the need for all
> gotos and labels in the function. This was suggested by Tony Prisk.
>
> The initializations of fbi and ret at the beginning of the function are not
> necessary and are removed. The call platform_set
On Sun, 2012-12-09 at 08:21 +0100, Julia Lawall wrote:
> > Rather than the goto, add the fail path code in directly, and return.
> >
> >
> > ret = register_framebuffer(>fb);
> > if (ret < 0) {
> > dev_err(>dev,
> > "Failed to register framebuffer device: %d\n", ret);
> > if (fbi->fb.cmap.len)
>
On Sun, 2012-12-09 at 08:21 +0100, Julia Lawall wrote:
Rather than the goto, add the fail path code in directly, and return.
ret = register_framebuffer(fbi-fb);
if (ret 0) {
dev_err(pdev-dev,
Failed to register framebuffer device: %d\n, ret);
if (fbi-fb.cmap.len)
. This was suggested by Tony Prisk.
The initializations of fbi and ret at the beginning of the function are not
necessary and are removed. The call platform_set_drvdata(pdev, NULL); at
the end of the function is also removed.
Signed-off-by: Julia Lawall julia.law...@lip6.fr
---
Only
On Sat, 2012-12-08 at 17:31 +0100, Julia Lawall wrote:
> From: Julia Lawall
>
> The various devm_ functions allocate memory that is released when a driver
> detaches. This patch uses these functions for data that is allocated in
> the probe function of a platform device and is only freed in the
On Sat, 2012-12-08 at 17:31 +0100, Julia Lawall wrote:
From: Julia Lawall julia.law...@lip6.fr
The various devm_ functions allocate memory that is released when a driver
detaches. This patch uses these functions for data that is allocated in
the probe function of a platform device and is
sertions(+), 30 deletions(-)
>
Thanks for the tidy up.
All patches Acked-by: Tony Prisk
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
.
All patches Acked-by: Tony Prisk li...@prisktech.co.nz
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
unload.
Looking for your thoughts (or anyone else that wants to chime in).
Regards
Tony Prisk
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.h
unload.
Looking for your thoughts (or anyone else that wants to chime in).
Regards
Tony Prisk
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read
This patch updates pwm-vt8500.c to support devicetree probing and
make use of the common clock subsystem.
A binding document describing the PWM controller found on
arch-vt8500 is also included.
Signed-off-by: Tony Prisk
---
v4:
return err from clk_enable rather than -EBUSY
v5:
replace
This patch updates pwm-vt8500.c to support devicetree probing and
make use of the common clock subsystem.
A binding document describing the PWM controller found on
arch-vt8500 is also included.
Signed-off-by: Tony Prisk li...@prisktech.co.nz
---
v4:
return err from clk_enable rather than -EBUSY
This patch updates pwm-vt8500.c to support devicetree probing and
make use of the common clock subsystem.
A binding document describing the PWM controller found on
arch-vt8500 is also included.
Signed-off-by: Tony Prisk
---
v4:
return err from clk_enable rather than -EBUSY
.../devicetree
On Wed, 2012-10-24 at 07:41 +0200, Thierry Reding wrote:
> On Wed, Oct 24, 2012 at 04:46:58PM +1300, Tony Prisk wrote:
> > This patch updates pwm-vt8500.c to support devicetree probing and
> > make use of the common clock subsystem.
> >
> > A binding document describi
On Wed, 2012-10-24 at 07:41 +0200, Thierry Reding wrote:
On Wed, Oct 24, 2012 at 04:46:58PM +1300, Tony Prisk wrote:
This patch updates pwm-vt8500.c to support devicetree probing and
make use of the common clock subsystem.
A binding document describing the PWM controller found on
arch
This patch updates pwm-vt8500.c to support devicetree probing and
make use of the common clock subsystem.
A binding document describing the PWM controller found on
arch-vt8500 is also included.
Signed-off-by: Tony Prisk li...@prisktech.co.nz
---
v4:
return err from clk_enable rather than -EBUSY
On Wed, 2012-10-24 at 00:14 +0200, Thierry Reding wrote:
> On Tue, Oct 23, 2012 at 07:10:24AM +1300, Tony Prisk wrote:
> [...]
> > @@ -87,6 +98,11 @@ static int vt8500_pwm_enable(struct pwm_chip *chip,
> > struct pwm_device *pwm)
> > {
> > struct vt8500_chip
This patch updates pwm-vt8500.c to support devicetree probing and
make use of the common clock subsystem.
A binding document describing the PWM controller found on
arch-vt8500 is also included.
Signed-off-by: Tony Prisk
---
v2/v3:
Fix errors/coding style as pointed out by Thierry Reding
On Mon, 2012-10-22 at 10:04 +0200, Thierry Reding wrote:
> On Mon, Oct 22, 2012 at 08:36:22PM +1300, Tony Prisk wrote:
> > On Mon, 2012-10-22 at 09:24 +0200, Thierry Reding wrote:
> > > On Mon, Oct 22, 2012 at 08:09:07PM +1300, Tony Prisk wrote:
> > > > On Mon, 2
On Mon, 2012-10-22 at 10:04 +0200, Thierry Reding wrote:
On Mon, Oct 22, 2012 at 08:36:22PM +1300, Tony Prisk wrote:
On Mon, 2012-10-22 at 09:24 +0200, Thierry Reding wrote:
On Mon, Oct 22, 2012 at 08:09:07PM +1300, Tony Prisk wrote:
On Mon, 2012-10-22 at 19:51 +1300, Tony Prisk wrote
501 - 600 of 734 matches
Mail list logo
