Re: [PATCH linux-next v2 1/1] dmaengine: at_hdmac: fix residue computation

2015-06-19 Thread Torsten Fleischer
On Thursday 18 June 2015 at 13:25:41 Cyrille Pitchen wrote: > > Signed-off-by: Cyrille Pitchen > --- Looks good to me. Acked-by: Torsten Fleischer Regards, Torsten -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

Re: [PATCH linux-next 1/1] dmaengine: at_hdmac: fix residue computation

2015-06-19 Thread Torsten Fleischer
On Tuesday 16 June 2015 at 18:11:56 Torsten Fleischer wrote: > On Monday 15 June 2015 at 17:17:51 Cyrille Pitchen wrote: [...] > > @@ -365,16 +371,13 @@ static int atc_get_bytes_left(struct dma_chan *chan, > > dma_cookie_t cookie) } > > > > /* > >

Re: [PATCH linux-next 1/1] dmaengine: at_hdmac: fix residue computation

2015-06-16 Thread Torsten Fleischer
On Monday 15 June 2015 at 17:17:51 Cyrille Pitchen wrote: > As claimed by the programmer datasheet and confirmed by the IP designer, > the Block Transfer Size (BTSIZE) bitfield of the Channel x Control A > Register (CTRLAx) always refers to a number of Source Width (SRC_WIDTH) > transfers. > > Bot

[PATCH v3 2/2] dma: at_hdmac: Add support for memory to memory sg transfers

2015-02-23 Thread Torsten Fleischer
From: Torsten Fleischer This patch adds support for memory to memory scatter-gather transfers. Changes from V1: * Fixed coding style of the multi-line comments. Changes from V2: * Added setup of 'desc->tx_width' that is needed to calculate the residue. Signed-of

[PATCH v3 1/2] dma: at_hdmac: Fix calculation of the residual bytes

2015-02-23 Thread Torsten Fleischer
From: Torsten Fleischer This patch fixes the following issues regarding to the calculation of the residue: 1. The residue is always calculated for the current transfer even if the cookie is associated to a pending transfer. 2. For scatter/gather DMA the calculation of the residue for the

[PATCH v3 0/2] dma: at_hdmac: Fix residue calculation and add mem to

2015-02-23 Thread Torsten Fleischer
From: Torsten Fleischer This series fixes the calculation of the residual bytes and adds support for memory to memory scatter-gather transfers. Changes from V1: * Fixed coding style of the multi-line comments. * Improved accuracy of the residue calculation. Changes from V2: * Fixed

[PATCH v2 1/2] dma: at_hdmac: Fix calculation of the residual bytes

2015-02-19 Thread Torsten Fleischer
From: Torsten Fleischer This patch fixes the following issues regarding to the calculation of the residue: 1. The residue is always calculated for the current transfer even if the cookie is associated to a pending transfer. 2. For scatter/gather DMA the calculation of the residue for the

[PATCH v2 0/2] dma: at_hdmac: Fix residue calculation and add mem to

2015-02-19 Thread Torsten Fleischer
From: Torsten Fleischer This series fixes the calculation of the residual bytes and adds support for memory to memory scatter-gather transfers. Changes from V1: * Fixed coding style of the multi-line comments. * Improved accuracy of the residue calculation. Torsten Fleischer (2): dma

[PATCH v2 2/2] dma: at_hdmac: Add support for memory to memory sg transfers

2015-02-19 Thread Torsten Fleischer
From: Torsten Fleischer This patch adds support for memory to memory scatter-gather transfers. Changes from V1: * Fixed coding style of the multi-line comments. Signed-off-by: Torsten Fleischer --- drivers/dma/at_hdmac.c | 169 + 1 file

Re: [PATCH 1/2] dma: at_hdmac: Fix calculation of the residual bytes

2015-02-18 Thread Torsten Fleischer
Hello Ludovic, >> >> transfer 1: residue = 975584 >> transfer 2: residue = 1048380 >> > > You're right about these points. Good job. I think it should be sent to > stable if it can be applied properly. > > For multilines comments, please follow the coding rule > /* > * my > * comments > */ > th

Re: [PATCH 0/2] dma: at_hdmac: Fix residue calculation and add mem to mem sg support

2015-02-17 Thread Torsten Fleischer
2015-02-08 10:29 GMT+01:00 Torsten Fleischer : > From: Torsten Fleischer > > This series fixes the calculation of the residual bytes and adds support for > memory to memory scatter-gather transfers. > > Torsten Fleischer (2): > dma: at_hdmac: Fix calculation of the r

[PATCH 1/2] dma: at_hdmac: Fix calculation of the residual bytes

2015-02-08 Thread Torsten Fleischer
From: Torsten Fleischer This patch fixes the following issues regarding to the calculation of the residue: 1. The residue is always calculated for the current transfer even if the cookie is associated to a pending transfer. 2. For scatter/gather DMA the calculation of the residue for the

[PATCH 2/2] dma: at_hdmac: Add support for memory to memory sg transfers

2015-02-08 Thread Torsten Fleischer
From: Torsten Fleischer This patch adds support for memory to memory scatter-gather transfers. Signed-off-by: Torsten Fleischer --- drivers/dma/at_hdmac.c | 165 + 1 file changed, 154 insertions(+), 11 deletions(-) diff --git a/drivers/dma

[PATCH 0/2] dma: at_hdmac: Fix residue calculation and add mem to mem sg support

2015-02-08 Thread Torsten Fleischer
From: Torsten Fleischer This series fixes the calculation of the residual bytes and adds support for memory to memory scatter-gather transfers. Torsten Fleischer (2): dma: at_hdmac: Fix calculation of the residual bytes dma: at_hdmac: Add support for memory to memory sg transfers drivers

[PATCH 1/1] spi: spi-gpio: Fix compiler warning when building for 64 bit systems

2014-11-07 Thread Torsten Fleischer
From: Torsten Fleischer The assignment of SPI_GPIO_NO_CHIPSELECT to cs_gpios[0] causes the following compiler warning, when building for 64 bit systems: "warning: overflow in implicit constant conversion [-Woverflow]". This is because the SPI_GPIO_NO_CHIPSELECT flag is a '-1&

[PATCH v2 1/1] spi: spi-gpio: Add dt support for a single device with no chip select

2014-11-03 Thread Torsten Fleischer
From: Torsten Fleischer In order to describe a single slave device that has no chip select line the 'num-chipselects' property has to be <0> and the 'cs-gpios' property doesn't need to be set. Signed-off-by: Torsten Fleischer --- Documentation/devicetree

Re: [PATCH 1/1] spi: spi-gpio: Add dt support for a single device with no chip select

2014-10-29 Thread Torsten Fleischer
2014-10-27 18:30 GMT+01:00 Mark Rutland : > On Mon, Oct 27, 2014 at 03:27:17PM +0000, Torsten Fleischer wrote: >> From: Torsten Fleischer >> >> Use an empty 'cs-gpios' property if a single device is connected which >> has no chip select. >> This refers

[PATCH 1/1] spi: spi-gpio: Add dt support for a single device with no chip select

2014-10-27 Thread Torsten Fleischer
From: Torsten Fleischer Use an empty 'cs-gpios' property if a single device is connected which has no chip select. This refers to the discussion at https://lkml.org/lkml/2013/11/13/62. Signed-off-by: Torsten Fleischer --- Documentation/devicetree/bindings/spi/spi-gpio.txt | 6 -