[PATCH 05/10] ASoC: wm8741: Convert to use devm_regmap_init_{spi,i2c}()

Signed-off-by: Tushar Behera --- sound/soc/codecs/wm8741.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/wm8741.c b/sound/soc/codecs/wm8741.c index 4281a08..99b8ebe 100644 --- a/sound/soc/codecs/wm8741.c +++ b/sound/soc/codecs/wm8741.c @@ -522,7

[PATCH 00/10] ASoC: codec: devm_ related modifications

This patchset includes devm_ related modifications for sound codecs. First 2 patches fix warning for freeing of devm_ allocated data. The next patch introduces usage of devm_kzalloc() in wm8995 codec. Following 7 patches introduce usage of devm_regmap_init_xxx() in remaining codecs. Tushar

[PATCH 4/4] video: vt8500: Convert to use devm_ioremap()

While at it, fix the return statements. Signed-off-by: Tushar Behera --- drivers/video/vt8500lcdfb.c | 14 -- 1 files changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/video/vt8500lcdfb.c b/drivers/video/vt8500lcdfb.c index c42f15d..96a955e 100644 --- a/drivers/video

[PATCH 06/10] ASoC: wm8753: Convert to use devm_regmap_init_{spi,i2c}()

Signed-off-by: Tushar Behera --- sound/soc/codecs/wm8753.c | 32 ++-- 1 files changed, 6 insertions(+), 26 deletions(-) diff --git a/sound/soc/codecs/wm8753.c b/sound/soc/codecs/wm8753.c index 9914215..50a5dc7 100644 --- a/sound/soc/codecs/wm8753.c +++ b/sound/soc

[PATCH 10/10] ASoC: wm8995: Convert to use devm_regmap_init_{spi,i2c}()

Signed-off-by: Tushar Behera --- sound/soc/codecs/wm8995.c | 26 +++--- 1 files changed, 3 insertions(+), 23 deletions(-) diff --git a/sound/soc/codecs/wm8995.c b/sound/soc/codecs/wm8995.c index 2eb68c1..f1a7cf1 100644 --- a/sound/soc/codecs/wm8995.c +++ b/sound/soc/codecs

[PATCH 01/10] ASoC: wm8510: remove invalid free of devm_ allocated data

Fixes following warning. sound/soc/codecs/wm8510.c:614:1-6: WARNING: invalid free of devm_ allocated data Signed-off-by: Tushar Behera --- sound/soc/codecs/wm8510.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/wm8510.c b/sound/soc/codecs/wm8510.c

[PATCH 1/4] video: vt8500: Fix memory leak in probe function

In case of error in probe function, there is a possibility of either iounmap not getting called or memory allocated for fb_mem_virt not getting freed. Signed-off-by: Tushar Behera --- drivers/video/vt8500lcdfb.c | 16 1 files changed, 12 insertions(+), 4 deletions(-) diff

[PATCH 3/4] video: vt8500: Convert to use devm_request_mem_region()

While at it, fix the return statements. Signed-off-by: Tushar Behera --- drivers/video/vt8500lcdfb.c | 12 +++- 1 files changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/video/vt8500lcdfb.c b/drivers/video/vt8500lcdfb.c index 2438368..c42f15d 100644 --- a/drivers/video

[PATCH 07/10] ASoC: wm8804: Convert to use devm_regmap_init_{spi,i2c}()

Signed-off-by: Tushar Behera --- sound/soc/codecs/wm8804.c | 17 ++--- 1 files changed, 2 insertions(+), 15 deletions(-) diff --git a/sound/soc/codecs/wm8804.c b/sound/soc/codecs/wm8804.c index c088020..837bfb5 100644 --- a/sound/soc/codecs/wm8804.c +++ b/sound/soc/codecs/wm8804.c

[PATCH 09/10] ASoC: wm8988: Convert to use devm_regmap_init_{spi,i2c}()

Signed-off-by: Tushar Behera --- sound/soc/codecs/wm8988.c | 14 ++ 1 files changed, 2 insertions(+), 12 deletions(-) diff --git a/sound/soc/codecs/wm8988.c b/sound/soc/codecs/wm8988.c index 1d4c5cf..715788d 100644 --- a/sound/soc/codecs/wm8988.c +++ b/sound/soc/codecs/wm8988.c

[PATCH 04/10] ASoC: ak4104: Convert to use devm_regmap_init_spi()

Signed-off-by: Tushar Behera --- sound/soc/codecs/ak4104.c | 19 --- 1 files changed, 4 insertions(+), 15 deletions(-) diff --git a/sound/soc/codecs/ak4104.c b/sound/soc/codecs/ak4104.c index eec086b..4b11b82 100644 --- a/sound/soc/codecs/ak4104.c +++ b/sound/soc/codecs/ak4104

[PATCH] usb: gadget: s3c-hsotg: Fix invalid free of devm_ allocated data

Since hsotg object is allocated using devm_kzalloc() API, there is no need to free this explicitly. But we need to keep the release API to prevent warnings. Signed-off-by: Tushar Behera --- drivers/usb/gadget/s3c-hsotg.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH 0/4] video: vt8500: cleanup and use of devm_ apis

Patch 1 fixes a possible memory leak in the driver. Rest 3 patches add/update usage of devm_ apis. These patches are only build-tested. Tushar Behera (4): video: vt8500: Fix memory leak in probe function video: vt8500: Fix invalid free of devm_ allocated data video: vt8500: Convert to use

[PATCH 0/4] video: vt8500: cleanup and use of devm_ apis

Patch 1 fixes a possible memory leak in the driver. Rest 3 patches add/update usage of devm_ apis. These patches are only build-tested. Tushar Behera (4): video: vt8500: Fix memory leak in probe function video: vt8500: Fix invalid free of devm_ allocated data video: vt8500: Convert to use

[PATCH] usb: gadget: s3c-hsotg: Fix invalid free of devm_ allocated data

Since hsotg object is allocated using devm_kzalloc() API, there is no need to free this explicitly. But we need to keep the release API to prevent warnings. Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- drivers/usb/gadget/s3c-hsotg.c |5 ++--- 1 files changed, 2 insertions(+), 3

[PATCH 04/10] ASoC: ak4104: Convert to use devm_regmap_init_spi()

Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- sound/soc/codecs/ak4104.c | 19 --- 1 files changed, 4 insertions(+), 15 deletions(-) diff --git a/sound/soc/codecs/ak4104.c b/sound/soc/codecs/ak4104.c index eec086b..4b11b82 100644 --- a/sound/soc/codecs/ak4104.c +++ b

[PATCH 09/10] ASoC: wm8988: Convert to use devm_regmap_init_{spi,i2c}()

Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- sound/soc/codecs/wm8988.c | 14 ++ 1 files changed, 2 insertions(+), 12 deletions(-) diff --git a/sound/soc/codecs/wm8988.c b/sound/soc/codecs/wm8988.c index 1d4c5cf..715788d 100644 --- a/sound/soc/codecs/wm8988.c +++ b

[PATCH 07/10] ASoC: wm8804: Convert to use devm_regmap_init_{spi,i2c}()

Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- sound/soc/codecs/wm8804.c | 17 ++--- 1 files changed, 2 insertions(+), 15 deletions(-) diff --git a/sound/soc/codecs/wm8804.c b/sound/soc/codecs/wm8804.c index c088020..837bfb5 100644 --- a/sound/soc/codecs/wm8804.c +++ b

[PATCH 3/4] video: vt8500: Convert to use devm_request_mem_region()

While at it, fix the return statements. Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- drivers/video/vt8500lcdfb.c | 12 +++- 1 files changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/video/vt8500lcdfb.c b/drivers/video/vt8500lcdfb.c index 2438368..c42f15d

[PATCH 1/4] video: vt8500: Fix memory leak in probe function

In case of error in probe function, there is a possibility of either iounmap not getting called or memory allocated for fb_mem_virt not getting freed. Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- drivers/video/vt8500lcdfb.c | 16 1 files changed, 12 insertions

[PATCH 01/10] ASoC: wm8510: remove invalid free of devm_ allocated data

Fixes following warning. sound/soc/codecs/wm8510.c:614:1-6: WARNING: invalid free of devm_ allocated data Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- sound/soc/codecs/wm8510.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/wm8510.c b

[PATCH 10/10] ASoC: wm8995: Convert to use devm_regmap_init_{spi,i2c}()

Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- sound/soc/codecs/wm8995.c | 26 +++--- 1 files changed, 3 insertions(+), 23 deletions(-) diff --git a/sound/soc/codecs/wm8995.c b/sound/soc/codecs/wm8995.c index 2eb68c1..f1a7cf1 100644 --- a/sound/soc/codecs/wm8995

[PATCH 06/10] ASoC: wm8753: Convert to use devm_regmap_init_{spi,i2c}()

Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- sound/soc/codecs/wm8753.c | 32 ++-- 1 files changed, 6 insertions(+), 26 deletions(-) diff --git a/sound/soc/codecs/wm8753.c b/sound/soc/codecs/wm8753.c index 9914215..50a5dc7 100644 --- a/sound/soc/codecs

[PATCH 4/4] video: vt8500: Convert to use devm_ioremap()

While at it, fix the return statements. Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- drivers/video/vt8500lcdfb.c | 14 -- 1 files changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/video/vt8500lcdfb.c b/drivers/video/vt8500lcdfb.c index c42f15d..96a955e

[PATCH 00/10] ASoC: codec: devm_ related modifications

This patchset includes devm_ related modifications for sound codecs. First 2 patches fix warning for freeing of devm_ allocated data. The next patch introduces usage of devm_kzalloc() in wm8995 codec. Following 7 patches introduce usage of devm_regmap_init_xxx() in remaining codecs. Tushar

[PATCH 05/10] ASoC: wm8741: Convert to use devm_regmap_init_{spi,i2c}()

Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- sound/soc/codecs/wm8741.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/wm8741.c b/sound/soc/codecs/wm8741.c index 4281a08..99b8ebe 100644 --- a/sound/soc/codecs/wm8741.c +++ b/sound/soc

[PATCH 02/10] ASoC: wm8753: remove invalid free of devm_ allocated data

Fixes following warning. sound/soc/codecs/wm8753.c:1594:1-6: WARNING: invalid free of devm_ allocated data Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- sound/soc/codecs/wm8753.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/sound/soc/codecs/wm8753.c b

[PATCH 2/4] video: vt8500: Fix invalid free of devm_ allocated data

While at it, also fix the related return statements. Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- drivers/video/vt8500lcdfb.c | 15 +++ 1 files changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/video/vt8500lcdfb.c b/drivers/video/vt8500lcdfb.c index

[PATCH] watchdog: da9052: Fix invalid free of devm_ allocated data

It is not required to free devm_ allocated data. Since kref_put needs a valid release function, da9052_wdt_release_resources() is not deleted. Fixes following warning. drivers/watchdog/da9052_wdt.c:59:1-6: WARNING: invalid free of devm_ allocated data Signed-off-by: Tushar Behera tushar.beh

[PATCH 08/10] ASoC: wm8985: Convert to use devm_regmap_init_{spi,i2c}()

Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- sound/soc/codecs/wm8985.c | 30 -- 1 files changed, 4 insertions(+), 26 deletions(-) diff --git a/sound/soc/codecs/wm8985.c b/sound/soc/codecs/wm8985.c index 14f6663..7b3f409 100644 --- a/sound/soc/codecs

[PATCH 03/10] ASoC: wm8995: Convert to use devm_kzalloc()

Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- sound/soc/codecs/wm8995.c | 14 -- 1 files changed, 4 insertions(+), 10 deletions(-) diff --git a/sound/soc/codecs/wm8995.c b/sound/soc/codecs/wm8995.c index 28c89b0..2eb68c1 100644 --- a/sound/soc/codecs/wm8995.c +++ b

[PATCH 0/7] i2c: s3c2410: Add devm_* apis and cleanup

This patchset cleans up the probe function of i2c-s3c2410 driver. These have been tested on Exynos4210 based Origen board. Tushar Behera (7): i2c: s3c2410: Remove unnecessary label err_noclk i2c: s3c2410: Convert to use devm_clk_get() i2c: s3c2410: Convert to use devm_request_mem_region

[PATCH 2/7] i2c: s3c2410: Convert to use devm_clk_get()

Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- drivers/i2c/busses/i2c-s3c2410.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c index 7522f40..019c3d7 100644 --- a/drivers/i2c/busses/i2c

[PATCH 3/7] i2c: s3c2410: Convert to use devm_request_mem_region()

Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- drivers/i2c/busses/i2c-s3c2410.c | 12 +++- 1 files changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c index 019c3d7..a274ef7 100644 --- a/drivers/i2c/busses

[PATCH 1/7] i2c: s3c2410: Remove unnecessary label err_noclk

err_noclk label redirects to a simple return statement. Move the return statement to the caller location and remove the label. Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- drivers/i2c/busses/i2c-s3c2410.c |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) diff --git

[PATCH 4/7] i2c: s3c2410: Convert to use devm_ioremap()

Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- drivers/i2c/busses/i2c-s3c2410.c | 13 - 1 files changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c index a274ef7..3446af2 100644 --- a/drivers/i2c

[PATCH 5/7] i2c: s3c2410: Convert to use devm_request_irq()

Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- drivers/i2c/busses/i2c-s3c2410.c | 10 +++--- 1 files changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c index 3446af2..3e4143c 100644 --- a/drivers/i2c/busses

[PATCH 6/7] i2c: s3c2410: Move location of clk_prepare_enable() call in probe function

In probe call, only s3c24xx_i2c_init() needs the I2C clock to be enabled. Moving clk_prepare_enable() and clk_disable_unprepare() calls to around this function simplifies the return path of probe call. Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- drivers/i2c/busses/i2c-s3c2410.c

[PATCH 7/7] i2c: s3c2410: Remove err_cpufreq label

err_cpufreq label is now used only once. It can be removed and related code can be moved to the caller location. Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- drivers/i2c/busses/i2c-s3c2410.c |7 ++- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/i2c

Re: [PATCH 4/7] i2c: s3c2410: Convert to use devm_ioremap()

On 11/23/2012 11:44 AM, Sachin Kamat wrote: Hi Tushar, On 23 November 2012 11:29, Tushar Behera tushar.beh...@linaro.org wrote: Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- drivers/i2c/busses/i2c-s3c2410.c | 13 - 1 files changed, 4 insertions(+), 9 deletions

Re: [PATCH 0/7] i2c: s3c2410: Add devm_* apis and cleanup

On 11/23/2012 11:45 AM, Shubhrajyoti Datta wrote: On Fri, Nov 23, 2012 at 11:29 AM, Tushar Behera tushar.beh...@linaro.org wrote: This patchset cleans up the probe function of i2c-s3c2410 driver. These have been tested on Exynos4210 based Origen board. Tushar Behera (7): i2c: s3c2410

[PATCH 0/2] drivers/rtc/rtc-s3c.c: Add devm_* APIs and cleanup

This patchset adds devm_* APIs to rtc-s3c driver and cleans up the probe function. Tushar Behera (2): drivers/rtc/rtc-s3c.c: Remove unnecessary err_nores label drivers/rtc/rtc-s3c.c: Convert to use devm_* API drivers/rtc/rtc-s3c.c | 48 1

[PATCH 1/2] drivers/rtc/rtc-s3c.c: Remove unnecessary err_nores label

err_nores label redirects to a simple return statement. Move the return statement to caller location and remove the label. Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- drivers/rtc/rtc-s3c.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/rtc/rtc

[PATCH 2/2] drivers/rtc/rtc-s3c.c: Convert to use devm_* API

rtc-s3c driver is modified to use devm_request_and_ioremap() (combining request_mem_region and ioremap), devm_clk_get() and devm_request_irq() APIs. Since this removes the necessity of freeing the related resources the return path is also simplified. Signed-off-by: Tushar Behera tushar.beh

[PATCH] bug: Fix sparse warning related to BUILD_BUG_ON_INVALID

6:9: error: undefined identifier 'BUILD_BUG_ON_INVALID' mm/filemap.c:397:9: error: undefined identifier 'BUILD_BUG_ON_INVALID' include/linux/mm.h:419:9: error: undefined identifier 'BUILD_BUG_ON_INVALID' include/linux/mm.h:419:9: error: not a function Signed-off-by: Tushar Behera --- include/l

[PATCH] fsnotify: Fix sparse warning

Fixes following sparse warning. fs/notify/inode_mark.c:127:22: warning: symbol 'fsnotify_find_inode_mark_locked' was not declared. Should it be static? Signed-off-by: Tushar Behera --- fs/notify/inode_mark.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/notify

[PATCH] block: Fix sparse warning

blk_drain_queue is only used in this file, so should be marked static. Fixes following sparse warning. block/blk-core.c:361:6: warning: symbol 'blk_drain_queue' was not declared. Should it be static? Signed-off-by: Tushar Behera --- block/blk-core.c |2 +- 1 files changed, 1 insertions

Re: [Xen-devel] [PATCH 09/14] xen: events: Remove redundant check on unsigned variable

On 11/19/2012 04:01 PM, Ian Campbell wrote: > On Mon, 2012-11-19 at 03:52 +0000, Tushar Behera wrote: >> On 11/16/2012 10:23 PM, Jeremy Fitzhardinge wrote: >>> To be honest I'd nack this kind of patch. The test is only redundant in the >>> most trivial sense that the c

Re: [Xen-devel] [PATCH 09/14] xen: events: Remove redundant check on unsigned variable

On 11/19/2012 04:01 PM, Ian Campbell wrote: On Mon, 2012-11-19 at 03:52 +, Tushar Behera wrote: On 11/16/2012 10:23 PM, Jeremy Fitzhardinge wrote: To be honest I'd nack this kind of patch. The test is only redundant in the most trivial sense that the compiler can easily optimise away

[PATCH] block: Fix sparse warning

blk_drain_queue is only used in this file, so should be marked static. Fixes following sparse warning. block/blk-core.c:361:6: warning: symbol 'blk_drain_queue' was not declared. Should it be static? Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- block/blk-core.c |2 +- 1 files

[PATCH] fsnotify: Fix sparse warning

Fixes following sparse warning. fs/notify/inode_mark.c:127:22: warning: symbol 'fsnotify_find_inode_mark_locked' was not declared. Should it be static? Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- fs/notify/inode_mark.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions

[PATCH] bug: Fix sparse warning related to BUILD_BUG_ON_INVALID

: undefined identifier 'BUILD_BUG_ON_INVALID' mm/filemap.c:397:9: error: undefined identifier 'BUILD_BUG_ON_INVALID' include/linux/mm.h:419:9: error: undefined identifier 'BUILD_BUG_ON_INVALID' include/linux/mm.h:419:9: error: not a function noident Signed-off-by: Tushar Behera tushar.beh...@linaro.org

Re: [PATCH 05/14] [media] atmel-isi: Update error check for unsigned variables

On 11/18/2012 04:46 AM, Guennadi Liakhovetski wrote: > On Fri, 16 Nov 2012, Tushar Behera wrote: > >> Checking '< 0' for unsigned variables always returns false. For error >> codes, use IS_ERR_VALUE() instead. > > Wouldn't just changing "irq" type t

Re: [PATCH 09/14] xen: events: Remove redundant check on unsigned variable

ue, that would be caught by the check irq >= nr_irqs. > Konrad Rzeszutek Wilk wrote: > >> On Fri, Nov 16, 2012 at 12:20:41PM +0530, Tushar Behera wrote: >>> No need to check whether unsigned variable is less than 0. >>> >>> CC: Konrad Rzeszutek Wilk >

Re: [PATCH 09/14] xen: events: Remove redundant check on unsigned variable

by the check irq = nr_irqs. Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote: On Fri, Nov 16, 2012 at 12:20:41PM +0530, Tushar Behera wrote: No need to check whether unsigned variable is less than 0. CC: Konrad Rzeszutek Wilk konrad.w...@oracle.com Acked-by: Konrad Rzeszutek Wilk konrad.w

Re: [PATCH 05/14] [media] atmel-isi: Update error check for unsigned variables

On 11/18/2012 04:46 AM, Guennadi Liakhovetski wrote: On Fri, 16 Nov 2012, Tushar Behera wrote: Checking ' 0' for unsigned variables always returns false. For error codes, use IS_ERR_VALUE() instead. Wouldn't just changing irq type to int also work? I think that would be a more straight

[PATCH 02/14] [media] meye: Remove redundant check on unsigned variable

No need to check whether unsigned variable is less than 0. CC: Mauro Carvalho Chehab CC: linux-me...@vger.kernel.org Signed-off-by: Tushar Behera --- drivers/media/pci/meye/meye.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/pci/meye/meye.c b/drivers

[PATCH 08/14] xen: netback: Remove redundant check on unsigned variable

No need to check whether unsigned variable is less than 0. CC: Ian Campbell CC: xen-de...@lists.xensource.com CC: net...@vger.kernel.org Signed-off-by: Tushar Behera --- drivers/net/xen-netback/netback.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net

[PATCH 07/14] pinctrl: SPEAr: Update error check for unsigned variables

Checking '< 0' for unsigned variables always returns false. For error codes, use IS_ERR_VALUE() instead. CC: Linus Walleij Signed-off-by: Tushar Behera --- drivers/pinctrl/spear/pinctrl-plgpio.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/pinctrl/sp

[PATCH 06/14] pinctrl: samsung: Update error check for unsigned variables

Checking '< 0' for unsigned variables always returns false. For error codes, use IS_ERR_VALUE() instead. CC: Linus Walleij Signed-off-by: Tushar Behera --- drivers/pinctrl/pinctrl-samsung.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/pinctrl/pinc

[PATCH 05/14] [media] atmel-isi: Update error check for unsigned variables

Checking '< 0' for unsigned variables always returns false. For error codes, use IS_ERR_VALUE() instead. CC: Mauro Carvalho Chehab CC: linux-me...@vger.kernel.org Signed-off-by: Tushar Behera --- drivers/media/platform/soc_camera/atmel-isi.c |2 +- 1 files changed, 1 insertions(+)

[PATCH 03/14] [media] saa7134: Remove redundant check on unsigned variable

No need to check whether the unsigned variable is less than 0. CC: Mauro Carvalho Chehab CC: linux-me...@vger.kernel.org Signed-off-by: Tushar Behera --- drivers/media/pci/saa7134/saa7134-video.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/pci

[PATCH 00/14] Modify signed comparisons of unsigned variables

. Tushar Behera (14): [media] ivtv: Remove redundant check on unsigned variable [media] meye: Remove redundant check on unsigned variable [media] saa7134: Remove redundant check on unsigned variable [media] tlg2300: Remove redundant check on unsigned variable [media] atmel-isi: Update error check

[PATCH 10/14] atm: Removed redundant check on unsigned variable

No need to check whether unsigned variable is less than 0. CC: Chas Williams CC: linux-atm-gene...@lists.sourceforge.net CC: net...@vger.kernel.org Signed-off-by: Tushar Behera --- drivers/atm/fore200e.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/atm

[PATCH 12/14] gru: Remove redundant check on unsigned variable

No need to check whether unsigned variable is less than 0. CC: Jack Steiner Signed-off-by: Tushar Behera --- drivers/misc/sgi-gru/grukdump.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/misc/sgi-gru/grukdump.c b/drivers/misc/sgi-gru/grukdump.c index 9b2062d

[PATCH 14/14] wlcore: Remove redundant check on unsigned variable

No need to check whether unsigned variable is less than 0. CC: Luciano Coelho CC: linux-wirel...@vger.kernel.org CC: net...@vger.kernel.org Signed-off-by: Tushar Behera --- drivers/net/wireless/ti/wlcore/debugfs.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[PATCH 13/14] misc: tsl2550: Remove redundant check on unsigned variable

No need to check whether unsigned variable is less than 0. CC: Arnd Bergmann Signed-off-by: Tushar Behera --- drivers/misc/tsl2550.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/tsl2550.c b/drivers/misc/tsl2550.c index 0beb298..0438569 100644

[PATCH 11/14] HID: hiddev: Remove redundant check on unsigned variable

No need to check whether unsigned variable is less than 0. CC: Jiri Kosina CC: linux-...@vger.kernel.org CC: linux-in...@vger.kernel.org Signed-off-by: Tushar Behera --- drivers/hid/usbhid/hiddev.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/hid/usbhid

[PATCH 09/14] xen: events: Remove redundant check on unsigned variable

No need to check whether unsigned variable is less than 0. CC: Konrad Rzeszutek Wilk CC: Jeremy Fitzhardinge CC: xen-de...@lists.xensource.com CC: virtualizat...@lists.linux-foundation.org Signed-off-by: Tushar Behera --- drivers/xen/events.c |2 +- 1 files changed, 1 insertions(+), 1

[PATCH 04/14] [media] tlg2300: Remove redundant check on unsigned variable

No need to check whether unsigned variable is less than 0. CC: Mauro Carvalho Chehab CC: linux-me...@vger.kernel.org Signed-off-by: Tushar Behera --- drivers/media/usb/tlg2300/pd-video.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/usb/tlg2300/pd

[PATCH 01/14] [media] ivtv: Remove redundant check on unsigned variable

No need to check whether unsigned variable is less than 0. CC: Mauro Carvalho Chehab CC: ivtv-de...@ivtvdriver.org CC: linux-me...@vger.kernel.org Signed-off-by: Tushar Behera --- drivers/media/pci/ivtv/ivtv-ioctl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[PATCH 01/14] [media] ivtv: Remove redundant check on unsigned variable

No need to check whether unsigned variable is less than 0. CC: Mauro Carvalho Chehab mche...@infradead.org CC: ivtv-de...@ivtvdriver.org CC: linux-me...@vger.kernel.org Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- drivers/media/pci/ivtv/ivtv-ioctl.c |2 +- 1 files changed, 1

[PATCH 04/14] [media] tlg2300: Remove redundant check on unsigned variable

No need to check whether unsigned variable is less than 0. CC: Mauro Carvalho Chehab mche...@infradead.org CC: linux-me...@vger.kernel.org Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- drivers/media/usb/tlg2300/pd-video.c |2 +- 1 files changed, 1 insertions(+), 1 deletions

[PATCH 09/14] xen: events: Remove redundant check on unsigned variable

No need to check whether unsigned variable is less than 0. CC: Konrad Rzeszutek Wilk konrad.w...@oracle.com CC: Jeremy Fitzhardinge jer...@goop.org CC: xen-de...@lists.xensource.com CC: virtualizat...@lists.linux-foundation.org Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- drivers

[PATCH 11/14] HID: hiddev: Remove redundant check on unsigned variable

No need to check whether unsigned variable is less than 0. CC: Jiri Kosina jkos...@suse.cz CC: linux-...@vger.kernel.org CC: linux-in...@vger.kernel.org Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- drivers/hid/usbhid/hiddev.c |2 +- 1 files changed, 1 insertions(+), 1 deletions

[PATCH 13/14] misc: tsl2550: Remove redundant check on unsigned variable

No need to check whether unsigned variable is less than 0. CC: Arnd Bergmann a...@arndb.de Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- drivers/misc/tsl2550.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/tsl2550.c b/drivers/misc/tsl2550.c

[PATCH 12/14] gru: Remove redundant check on unsigned variable

No need to check whether unsigned variable is less than 0. CC: Jack Steiner stei...@sgi.com Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- drivers/misc/sgi-gru/grukdump.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/misc/sgi-gru/grukdump.c b

[PATCH 14/14] wlcore: Remove redundant check on unsigned variable

No need to check whether unsigned variable is less than 0. CC: Luciano Coelho coe...@ti.com CC: linux-wirel...@vger.kernel.org CC: net...@vger.kernel.org Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- drivers/net/wireless/ti/wlcore/debugfs.c |2 +- 1 files changed, 1 insertions

[PATCH 10/14] atm: Removed redundant check on unsigned variable

No need to check whether unsigned variable is less than 0. CC: Chas Williams c...@cmf.nrl.navy.mil CC: linux-atm-gene...@lists.sourceforge.net CC: net...@vger.kernel.org Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- drivers/atm/fore200e.c |2 +- 1 files changed, 1 insertions

[PATCH 00/14] Modify signed comparisons of unsigned variables

. Tushar Behera (14): [media] ivtv: Remove redundant check on unsigned variable [media] meye: Remove redundant check on unsigned variable [media] saa7134: Remove redundant check on unsigned variable [media] tlg2300: Remove redundant check on unsigned variable [media] atmel-isi: Update error check

[PATCH 03/14] [media] saa7134: Remove redundant check on unsigned variable

No need to check whether the unsigned variable is less than 0. CC: Mauro Carvalho Chehab mche...@infradead.org CC: linux-me...@vger.kernel.org Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- drivers/media/pci/saa7134/saa7134-video.c |2 +- 1 files changed, 1 insertions(+), 1

[PATCH 05/14] [media] atmel-isi: Update error check for unsigned variables

Checking ' 0' for unsigned variables always returns false. For error codes, use IS_ERR_VALUE() instead. CC: Mauro Carvalho Chehab mche...@infradead.org CC: linux-me...@vger.kernel.org Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- drivers/media/platform/soc_camera/atmel-isi.c |2

[PATCH 06/14] pinctrl: samsung: Update error check for unsigned variables

Checking ' 0' for unsigned variables always returns false. For error codes, use IS_ERR_VALUE() instead. CC: Linus Walleij linus.wall...@linaro.org Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- drivers/pinctrl/pinctrl-samsung.c |2 +- 1 files changed, 1 insertions(+), 1 deletions

[PATCH 08/14] xen: netback: Remove redundant check on unsigned variable

No need to check whether unsigned variable is less than 0. CC: Ian Campbell ian.campb...@citrix.com CC: xen-de...@lists.xensource.com CC: net...@vger.kernel.org Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- drivers/net/xen-netback/netback.c |4 ++-- 1 files changed, 2 insertions

[PATCH 07/14] pinctrl: SPEAr: Update error check for unsigned variables

Checking ' 0' for unsigned variables always returns false. For error codes, use IS_ERR_VALUE() instead. CC: Linus Walleij linus.wall...@linaro.org Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- drivers/pinctrl/spear/pinctrl-plgpio.c |2 +- 1 files changed, 1 insertions(+), 1

[PATCH 02/14] [media] meye: Remove redundant check on unsigned variable

No need to check whether unsigned variable is less than 0. CC: Mauro Carvalho Chehab mche...@infradead.org CC: linux-me...@vger.kernel.org Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- drivers/media/pci/meye/meye.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff

[PATCH v2] regulator: core: Update regulator_is_supported_voltage for fixed voltages

Commit c5f3939b8fe0 ("regulator: core: Support fixed voltages in regulator_is_supported_voltage()") returns success when the regulator voltage is less than both min_uV and max_uV. Modify this to return success only when the regulator voltage is within the specified range. Signed-off-

[PATCH v2] regulator: core: Update regulator_is_supported_voltage for fixed voltages

Commit c5f3939b8fe0 (regulator: core: Support fixed voltages in regulator_is_supported_voltage()) returns success when the regulator voltage is less than both min_uV and max_uV. Modify this to return success only when the regulator voltage is within the specified range. Signed-off-by: Tushar

[PATCH] [media] videobuf2-core: print current state of buffer in vb2_buffer_done

In vb2_buffer_done, it would be better the print the value of 'state' (current state of buffer) than to print 'vb->state' which is always VB2_BUF_STATE_ACTIVE. Signed-off-by: Tushar Behera --- drivers/media/v4l2-core/videobuf2-core.c |2 +- 1 files changed, 1 insertions(+), 1 deleti

[PATCH] [media] videobuf2-core: print current state of buffer in vb2_buffer_done

In vb2_buffer_done, it would be better the print the value of 'state' (current state of buffer) than to print 'vb-state' which is always VB2_BUF_STATE_ACTIVE. Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- drivers/media/v4l2-core/videobuf2-core.c |2 +- 1 files changed, 1

Re: [PATCH 0/8] Fix coding style in sdhci.c

On 11/12/2012 12:42 PM, Chris Ball wrote: > Hi, > > On Sun, Nov 11 2012, Tushar Behera wrote: >> Yes, I can do that. I did split it specifically so that we could drop >> any patches if required. >> >> I will wait for a word from Chris regarding what he prefer

Re: [PATCH] regulator: core: Update regulator_is_supported_voltage for fixed voltages

On 11/09/2012 10:39 PM, Mark Brown wrote: > On Fri, Nov 09, 2012 at 04:21:49PM +0530, Tushar Behera wrote: > >> In case of fixed regulators for which voltage cannot be changed, >> regulator_is_supported_voltage should return success only if the >> min_uV and ma

Re: [PATCH 0/8] Fix coding style in sdhci.c

t; Best Regards, > Jaehoon Chung > > On 11/09/2012 08:39 PM, Tushar Behera wrote: >> Documents/CodingStyle Chapter 3 recommends usage of braces for both >> if and else statements if any of the branches contains multiple >> statements. >> >> Cleaning up drivers/mm

Re: [PATCH 0/8] Fix coding style in sdhci.c

, Jaehoon Chung On 11/09/2012 08:39 PM, Tushar Behera wrote: Documents/CodingStyle Chapter 3 recommends usage of braces for both if and else statements if any of the branches contains multiple statements. Cleaning up drivers/mmc/host/sdhci.c for all these occurrences. Tushar Behera (8): mmc

Re: [PATCH] regulator: core: Update regulator_is_supported_voltage for fixed voltages

On 11/09/2012 10:39 PM, Mark Brown wrote: On Fri, Nov 09, 2012 at 04:21:49PM +0530, Tushar Behera wrote: In case of fixed regulators for which voltage cannot be changed, regulator_is_supported_voltage should return success only if the min_uV and max_uV parameters are same and it is equal

Re: [PATCH 0/8] Fix coding style in sdhci.c

On 11/12/2012 12:42 PM, Chris Ball wrote: Hi, On Sun, Nov 11 2012, Tushar Behera wrote: Yes, I can do that. I did split it specifically so that we could drop any patches if required. I will wait for a word from Chris regarding what he prefers. I would want to merge one patch, but I'm

[PATCH 2/8] mmc: sdhci: fix coding style in sdhci_set_transfer_mode

Signed-off-by: Tushar Behera --- drivers/mmc/host/sdhci.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 2ff2b9e..2d3d76e 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -898,9 +898,9

[PATCH 4/8] mmc: sdhci: fix coding style in sdhci_set_clock

Signed-off-by: Tushar Behera --- drivers/mmc/host/sdhci.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 73bb41f..28da461 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -1138,9 +1138,9

[PATCH 8/8] mmc: sdhci: fix coding style in sdhci_add_host

Signed-off-by: Tushar Behera --- drivers/mmc/host/sdhci.c | 20 1 files changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 47cac71..5cddb74 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c

[PATCH 7/8] mmc: sdhci: fix coding style in sdhci_data_irq

Signed-off-by: Tushar Behera --- drivers/mmc/host/sdhci.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 4bed582..47cac71 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -2286,9 +2286,9

<    2   3   4   5   6   7   8   >