Re: [PATCH] scripts/kconfig: replace single character strcat() appends

On Sat, Mar 3, 2018 at 12:12 AM, Joey Pabalinas wrote: > On Fri, Mar 02, 2018 at 02:44:53PM +0100, Ulf Magnusson wrote: >> Not sure this is an improvement. Zeroing the bytes after the initial >> null terminator is redundant, and the explicit '\0' makes it clearer to >> me wha

Re: [PATCH v2 09/11] kconfig: unittest: test randconfig for choice in choice

On Fri, Mar 2, 2018 at 10:29 PM, Luis R. Rodriguez <mcg...@kernel.org> wrote: > > > On Fri, Mar 2, 2018, 3:14 AM Ulf Magnusson <ulfali...@gmail.com> wrote: >> >> On Fri, Mar 2, 2018 at 5:31 AM, Masahiro Yamada >> > This is complicated usage, but it is stil

Re: [PATCH v2 09/11] kconfig: unittest: test randconfig for choice in choice

On Fri, Mar 2, 2018 at 10:29 PM, Luis R. Rodriguez wrote: > > > On Fri, Mar 2, 2018, 3:14 AM Ulf Magnusson wrote: >> >> On Fri, Mar 2, 2018 at 5:31 AM, Masahiro Yamada >> > This is complicated usage, but it is still used in the real world; >> > driver

Re: [PATCH] scripts/kconfig: replace single character strcat() appends

On Thu, Mar 01, 2018 at 09:44:24PM -1000, Joey Pabalinas wrote: > Convert strcat() calls which only append single characters > to the end of res into simpler (and most likely cheaper) > single assignment statements. > > Signed-off-by: Joey Pabalinas > > 1 file changed,

Re: [PATCH] scripts/kconfig: replace single character strcat() appends

On Thu, Mar 01, 2018 at 09:44:24PM -1000, Joey Pabalinas wrote: > Convert strcat() calls which only append single characters > to the end of res into simpler (and most likely cheaper) > single assignment statements. > > Signed-off-by: Joey Pabalinas > > 1 file changed, 9 insertions(+), 10

Re: [PATCH v2 09/11] kconfig: unittest: test randconfig for choice in choice

/kconfig/tests/rand_nested_choice/expected_stdout1 > b/scripts/kconfig/tests/rand_nested_choice/expected_stdout1 > new file mode 100644 > index 000..37ab295 > --- /dev/null > +++ b/scripts/kconfig/tests/rand_nested_choice/expected_stdout1 > @@ -0,0 +1,4 @@ > +# CONFIG_A is not set > +CONFIG_B=y > +CONFIG_C=y > +# CONFIG_D is not set > diff --git a/scripts/kconfig/tests/rand_nested_choice/expected_stdout2 > b/scripts/kconfig/tests/rand_nested_choice/expected_stdout2 > new file mode 100644 > index 000..849ff47 > --- /dev/null > +++ b/scripts/kconfig/tests/rand_nested_choice/expected_stdout2 > @@ -0,0 +1,5 @@ > +# CONFIG_A is not set > +CONFIG_B=y > +# CONFIG_C is not set > +CONFIG_D=y > +CONFIG_E=y > -- > 2.7.4 > Reviewed-by: Ulf Magnusson <ulfali...@gmail.com> Cheers, Ulf

Re: [PATCH v2 09/11] kconfig: unittest: test randconfig for choice in choice

sts/rand_nested_choice/expected_stdout1 > new file mode 100644 > index 000..37ab295 > --- /dev/null > +++ b/scripts/kconfig/tests/rand_nested_choice/expected_stdout1 > @@ -0,0 +1,4 @@ > +# CONFIG_A is not set > +CONFIG_B=y > +CONFIG_C=y > +# CONFIG_D is not set > diff --git a/scripts/kconfig/tests/rand_nested_choice/expected_stdout2 > b/scripts/kconfig/tests/rand_nested_choice/expected_stdout2 > new file mode 100644 > index 000..849ff47 > --- /dev/null > +++ b/scripts/kconfig/tests/rand_nested_choice/expected_stdout2 > @@ -0,0 +1,5 @@ > +# CONFIG_A is not set > +CONFIG_B=y > +# CONFIG_C is not set > +CONFIG_D=y > +CONFIG_E=y > -- > 2.7.4 > Reviewed-by: Ulf Magnusson Cheers, Ulf

Re: [PATCH v2 08/11] kconfig: unittest: test defconfig when two choices interact

+Related Linux commit: fbe98bb9ed3dae23e320c6b113e35f129538d14a > +""" > + > + > +def test(conf): > +assert conf.defconfig('defconfig') == 0 > +assert conf.config_contains('expected_config') > diff --git a/scripts/kconfig/tests/inter_choice/defconfig >

Re: [PATCH v2 08/11] kconfig: unittest: test defconfig when two choices interact

;"" > + > + > +def test(conf): > +assert conf.defconfig('defconfig') == 0 > +assert conf.config_contains('expected_config') > diff --git a/scripts/kconfig/tests/inter_choice/defconfig > b/scripts/kconfig/tests/inter_choice/defconfig > new file mode 100644 >

Re: [PATCH] kconfig: fix line number in recursive inclusion error message

fprintf(stderr, " included from: '%s:%d'\n", > - iter->name, iter->lineno+1); > + iter->name, iter->lineno - 1); > + } while (strcmp(iter->name, current_file->name)); > exit(1); > } > } > -- > 2.7.4 > Much neater. Reviewed-by: Ulf Magnusson <ulfali...@gmail.com> Cheers, Ulf

Re: [PATCH] kconfig: fix line number in recursive inclusion error message

_file; > + do { > iter = iter->parent; > - } > - if (iter) > fprintf(stderr, " included from: '%s:%d'\n", > -

Re: [PATCH 00/23] kconfig: move compiler capability tests to Kconfig

On Fri, Mar 02, 2018 at 10:03:26AM +0100, Ulf Magnusson wrote: > On Fri, Mar 02, 2018 at 02:50:39PM +0900, Masahiro Yamada wrote: > > 2018-02-22 6:39 GMT+09:00 Ulf Magnusson <ulfali...@gmail.com>: > > > On Wed, Feb 21, 2018 at 09:57:03PM +0900, Masahiro Yamada wrote: > &

Re: [PATCH 00/23] kconfig: move compiler capability tests to Kconfig

On Fri, Mar 02, 2018 at 10:03:26AM +0100, Ulf Magnusson wrote: > On Fri, Mar 02, 2018 at 02:50:39PM +0900, Masahiro Yamada wrote: > > 2018-02-22 6:39 GMT+09:00 Ulf Magnusson : > > > On Wed, Feb 21, 2018 at 09:57:03PM +0900, Masahiro Yamada wrote: > > >> 2018-02-21

Re: [PATCH 00/23] kconfig: move compiler capability tests to Kconfig

On Fri, Mar 02, 2018 at 02:50:39PM +0900, Masahiro Yamada wrote: > 2018-02-22 6:39 GMT+09:00 Ulf Magnusson <ulfali...@gmail.com>: > > On Wed, Feb 21, 2018 at 09:57:03PM +0900, Masahiro Yamada wrote: > >> 2018-02-21 19:52 GMT+09:00 Arnd Bergmann <a...@arndb.de>: > &

Re: [PATCH 00/23] kconfig: move compiler capability tests to Kconfig

On Fri, Mar 02, 2018 at 02:50:39PM +0900, Masahiro Yamada wrote: > 2018-02-22 6:39 GMT+09:00 Ulf Magnusson : > > On Wed, Feb 21, 2018 at 09:57:03PM +0900, Masahiro Yamada wrote: > >> 2018-02-21 19:52 GMT+09:00 Arnd Bergmann : > >> > On Wed, Feb 21, 2018 at 11:20 AM,

Re: [PATCH 04/23] kconfig: set SYMBOL_AUTO to the symbol marked with defconfig_list

t_entry->sym) >> zconf_error("trying to redefine defconfig symbol"); >> + sym_defconfig_list->flags |= SYMBOL_AUTO; >> break; >> case T_OPT_ENV: >> prop_add_env(arg); >> -- >> 2.7.4 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in >> the body of a message to majord...@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > -- > Best Regards > Masahiro Yamada Seems reasonable to me. Reviewed-by: Ulf Magnusson <ulfali...@gmail.com> Cheers, Ulf

Re: [PATCH 04/23] kconfig: set SYMBOL_AUTO to the symbol marked with defconfig_list

2,7 @@ void menu_add_option(int token, char *arg) >> sym_defconfig_list = current_entry->sym; >> else if (sym_defconfig_list != current_entry->sym) >> zconf_error("trying to redefine defconfig symbol"); >> + sym_defconfig_list->flags |= SYMBOL_AUTO; >> break; >> case T_OPT_ENV: >> prop_add_env(arg); >> -- >> 2.7.4 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in >> the body of a message to majord...@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > -- > Best Regards > Masahiro Yamada Seems reasonable to me. Reviewed-by: Ulf Magnusson Cheers, Ulf

Re: [PATCH] kconfig: remove redundant streamline_config.pl prerequisite

On Thu, Mar 1, 2018 at 3:39 PM, Masahiro Yamada <yamada.masah...@socionext.com> wrote: > 2018-03-01 20:18 GMT+09:00 Ulf Magnusson <ulfali...@gmail.com>: >> The local{yes,mod}config targets currently have streamline_config.pl as >> a prerequisite. This is redundant, b

Re: [PATCH] kconfig: remove redundant streamline_config.pl prerequisite

On Thu, Mar 1, 2018 at 3:39 PM, Masahiro Yamada wrote: > 2018-03-01 20:18 GMT+09:00 Ulf Magnusson : >> The local{yes,mod}config targets currently have streamline_config.pl as >> a prerequisite. This is redundant, because streamline_config.pl is a >> checked-in file

Re: [PATCH v3 2/2] kconfig: rename silentoldconfig to syncconfig

+583,7 @@ int main(int ac, char **av) > } > break; > case savedefconfig: > - case silentoldconfig: > + case syncconfig: > case oldaskconfig: > case oldconfig: > case listnewconfig: > @@ -667,7 +667,7 @@ int main(int ac, char **av) > /* fall through */ > case oldconfig: > case listnewconfig: > - case silentoldconfig: > + case syncconfig: > /* Update until a loop caused no more changes */ > do { > conf_cnt = 0; > @@ -680,7 +680,7 @@ int main(int ac, char **av) > } > > if (sync_kconfig) { > - /* silentoldconfig is used during the build so we shall > update autoconf. > + /* syncconfig is used during the build so we shall update > autoconf. > * All other commands are only used to generate a config. > */ > if (conf_get_changed() && conf_write(NULL)) { > -- > 2.7.4 > Reviewed-by: Ulf Magnusson <ulfali...@gmail.com> Cheers, Ulf

Re: [PATCH v3 2/2] kconfig: rename silentoldconfig to syncconfig

break; > case savedefconfig: > - case silentoldconfig: > + case syncconfig: > case oldaskconfig: > case oldconfig: > case listnewconfig: > @@ -667,7 +667,7 @@ int main(int ac, char **av) > /* fall through */ > case oldconfig: > case listnewconfig: > - case silentoldconfig: > + case syncconfig: > /* Update until a loop caused no more changes */ > do { > conf_cnt = 0; > @@ -680,7 +680,7 @@ int main(int ac, char **av) > } > > if (sync_kconfig) { > - /* silentoldconfig is used during the build so we shall > update autoconf. > + /* syncconfig is used during the build so we shall update > autoconf. > * All other commands are only used to generate a config. > */ > if (conf_get_changed() && conf_write(NULL)) { > -- > 2.7.4 > Reviewed-by: Ulf Magnusson Cheers, Ulf

[PATCH] kconfig: remove redundant streamline_config.pl prerequisite

-by: Ulf Magnusson <ulfali...@gmail.com> --- scripts/kconfig/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile index 1f74336d4e23..58be52cb464d 100644 --- a/scripts/kconfig/Makefile +++ b/scripts/kconfig/Ma

[PATCH] kconfig: remove redundant streamline_config.pl prerequisite

-by: Ulf Magnusson --- scripts/kconfig/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile index 1f74336d4e23..58be52cb464d 100644 --- a/scripts/kconfig/Makefile +++ b/scripts/kconfig/Makefile @@ -77,9 +77,9

Re: [PATCH v2 6/6] kconfig: rename silentoldconfig to syncconfig

On Wed, Feb 28, 2018 at 6:41 AM, Ulf Magnusson <ulfali...@gmail.com> wrote: > On Wed, Feb 28, 2018 at 09:15:26AM +0900, Masahiro Yamada wrote: >> As commit cedd55d49dee ("kconfig: Remove silentoldconfig from help >> and docs; fix kconfig/conf's help&quo

Re: [PATCH v2 6/6] kconfig: rename silentoldconfig to syncconfig

On Wed, Feb 28, 2018 at 6:41 AM, Ulf Magnusson wrote: > On Wed, Feb 28, 2018 at 09:15:26AM +0900, Masahiro Yamada wrote: >> As commit cedd55d49dee ("kconfig: Remove silentoldconfig from help >> and docs; fix kconfig/conf's help") mentioned, 'silentoldconfig' is

Re: [PATCH v2 6/6] kconfig: rename silentoldconfig to syncconfig

On Wed, Feb 28, 2018 at 09:15:26AM +0900, Masahiro Yamada wrote: > As commit cedd55d49dee ("kconfig: Remove silentoldconfig from help > and docs; fix kconfig/conf's help") mentioned, 'silentoldconfig' is a > historical misnomer. That commit removed it from help and docs since > it is an internal

Re: [PATCH v2 6/6] kconfig: rename silentoldconfig to syncconfig

On Wed, Feb 28, 2018 at 09:15:26AM +0900, Masahiro Yamada wrote: > As commit cedd55d49dee ("kconfig: Remove silentoldconfig from help > and docs; fix kconfig/conf's help") mentioned, 'silentoldconfig' is a > historical misnomer. That commit removed it from help and docs since > it is an internal

Re: [PATCH v2 5/6] kconfig: invoke oldconfig instead of silentoldconfig from local*config

$(obj)/conf $(silent) --oldconfig $(Kconfig); \ Ditto here. > fi > $(Q)rm -f .tmp.config > > -- > 2.7.4 > I'm not an expert on the Makefiles, but seems reasonable to me. Reviewed-by: Ulf Magnusson <ulfali...@gmail.com> Cheers, Ulf

Re: [PATCH v2 5/6] kconfig: invoke oldconfig instead of silentoldconfig from local*config

(Kconfig); \ Ditto here. > fi > $(Q)rm -f .tmp.config > > -- > 2.7.4 > I'm not an expert on the Makefiles, but seems reasonable to me. Reviewed-by: Ulf Magnusson Cheers, Ulf

Re: [PATCH 0/3] Improve and extend checkpatch.pl Kconfig help text checks

On Fri, Feb 16, 2018 at 10:14 PM, Joe Perches <j...@perches.com> wrote: > On Fri, 2018-02-16 at 21:22 +0100, Ulf Magnusson wrote: >> Hello, >> >> This patchset contains some improvements for the Kconfig help text check in >> scripts/checkconfig.pl: > > Se

Re: [PATCH 0/3] Improve and extend checkpatch.pl Kconfig help text checks

On Fri, Feb 16, 2018 at 10:14 PM, Joe Perches wrote: > On Fri, 2018-02-16 at 21:22 +0100, Ulf Magnusson wrote: >> Hello, >> >> This patchset contains some improvements for the Kconfig help text check in >> scripts/checkconfig.pl: > > Seems sensible enough to

Re: [PATCH v2 20/20] x86/PCI: VMD: Fix malformed Kconfig default

On Fri, Feb 23, 2018 at 12:00 AM, Bjorn Helgaas <helg...@kernel.org> wrote: > On Tue, Feb 06, 2018 at 11:11:06PM +0100, Ulf Magnusson wrote: >> 'default N' should be 'default n', though they happen to have the same >> effect here, due to undefined symbols (N in this

Re: [PATCH v2 20/20] x86/PCI: VMD: Fix malformed Kconfig default

On Fri, Feb 23, 2018 at 12:00 AM, Bjorn Helgaas wrote: > On Tue, Feb 06, 2018 at 11:11:06PM +0100, Ulf Magnusson wrote: >> 'default N' should be 'default n', though they happen to have the same >> effect here, due to undefined symbols (N in this case) evaluating to n >>

Re: [PATCH 00/23] kconfig: move compiler capability tests to Kconfig

rgmann <a...@arndb.de>: > >>> On Wed, Feb 21, 2018 at 8:38 AM, Masahiro Yamada > >>> <yamada.masah...@socionext.com> wrote: > >>>> 2018-02-20 0:18 GMT+09:00 Ulf Magnusson <ulfali...@gmail.com>: > >> > >> Let me clarify my conc

Re: [PATCH 00/23] kconfig: move compiler capability tests to Kconfig

:38 AM, Masahiro Yamada > >>> wrote: > >>>> 2018-02-20 0:18 GMT+09:00 Ulf Magnusson : > >> > >> Let me clarify my concern. > >> > >> When we test the compiler flag, is there a case > >> where a particular flag depends o

Re: [PATCH 11/23] kconfig: add 'shell-stdout' function

On Wed, Feb 21, 2018 at 01:59:59PM +0900, Masahiro Yamada wrote: > 2018-02-20 3:01 GMT+09:00 Linus Torvalds : > > On Mon, Feb 19, 2018 at 9:44 AM, Linus Torvalds > > wrote: > >> > >> I do like your "success"/"stdout" more than

Re: [PATCH 11/23] kconfig: add 'shell-stdout' function

On Wed, Feb 21, 2018 at 01:59:59PM +0900, Masahiro Yamada wrote: > 2018-02-20 3:01 GMT+09:00 Linus Torvalds : > > On Mon, Feb 19, 2018 at 9:44 AM, Linus Torvalds > > wrote: > >> > >> I do like your "success"/"stdout" more than "shell"/"shell-stdout", > >> because with that naming I don't get the

Re: [PATCH] kconfig: Print reverse dependencies in groups

so please: > Reviewed-by: Petr Vorel <pvo...@suse.cz> > > Kind regards, > Petr Looks good to me too. Reviewed-by: Ulf Magnusson <ulfali...@gmail.com> Cheers, Ulf

Re: [PATCH] kconfig: Print reverse dependencies in groups

On Wed, Feb 21, 2018 at 12:17 PM, Petr Vorel wrote: > Hi Masahiro, > >> > Signed-off-by: Masahiro Yamada >> Acked-by: Petr Vorel > Well, I'm not really the one to ack anything here, so please: > Reviewed-by: Petr Vorel > > Kind regards, > Petr Looks good to

Re: [PATCH] kconfig: Don't leak choice names during parsing

SYMBOL_AUTO; > menu_add_entry(sym); > menu_add_expr(P_CHOICE, NULL, NULL); > + free($2); > printd(DEBUG_PARSE, "%s:%d:choice\n", zconf_curname(), > zconf_lineno()); > }; > > -- > 2.7.4 > Reviewed-by: Ulf Magnusson <ulfali...@gmail.com

Re: [PATCH] kconfig: Don't leak choice names during parsing

CE, NULL, NULL); > + free($2); > printd(DEBUG_PARSE, "%s:%d:choice\n", zconf_curname(), > zconf_lineno()); > }; > > -- > 2.7.4 > Reviewed-by: Ulf Magnusson Only place I've seen named choices in practice is in the esp-idf project. Not sure what they're using them for. They were handy for writing tests too. :P Cheers, Ulf

Re: [PATCH 07/23] kconfig: add function support and implement 'shell' function

On Mon, Feb 19, 2018 at 09:06:55PM +0100, Ulf Magnusson wrote: > On Mon, Feb 19, 2018 at 6:50 PM, Ulf Magnusson <ulfali...@gmail.com> wrote: > > On Tue, Feb 20, 2018 at 12:57:13AM +0900, Masahiro Yamada wrote: > >> 2018-02-18 1:16 GMT+09:00 Ulf Magnusson <ulfali...@gma

Re: [PATCH 07/23] kconfig: add function support and implement 'shell' function

On Mon, Feb 19, 2018 at 09:06:55PM +0100, Ulf Magnusson wrote: > On Mon, Feb 19, 2018 at 6:50 PM, Ulf Magnusson wrote: > > On Tue, Feb 20, 2018 at 12:57:13AM +0900, Masahiro Yamada wrote: > >> 2018-02-18 1:16 GMT+09:00 Ulf Magnusson : > >> > On Sat, Feb 17, 2018

Re: [PATCH 07/23] kconfig: add function support and implement 'shell' function

On Mon, Feb 19, 2018 at 6:50 PM, Ulf Magnusson <ulfali...@gmail.com> wrote: > On Tue, Feb 20, 2018 at 12:57:13AM +0900, Masahiro Yamada wrote: >> 2018-02-18 1:16 GMT+09:00 Ulf Magnusson <ulfali...@gmail.com>: >> > On Sat, Feb 17, 2018 at 03:38:35AM +0900, Masahiro Y

Re: [PATCH 07/23] kconfig: add function support and implement 'shell' function

On Mon, Feb 19, 2018 at 6:50 PM, Ulf Magnusson wrote: > On Tue, Feb 20, 2018 at 12:57:13AM +0900, Masahiro Yamada wrote: >> 2018-02-18 1:16 GMT+09:00 Ulf Magnusson : >> > On Sat, Feb 17, 2018 at 03:38:35AM +0900, Masahiro Yamada wrote: >> >> This commit adds a new

Re: [PATCH 11/23] kconfig: add 'shell-stdout' function

On Mon, Feb 19, 2018 at 10:01:49AM -0800, Linus Torvalds wrote: > On Mon, Feb 19, 2018 at 9:44 AM, Linus Torvalds > wrote: > > > > I do like your "success"/"stdout" more than "shell"/"shell-stdout", > > because with that naming I don't get the feeling that one

Re: [PATCH 11/23] kconfig: add 'shell-stdout' function

On Mon, Feb 19, 2018 at 10:01:49AM -0800, Linus Torvalds wrote: > On Mon, Feb 19, 2018 at 9:44 AM, Linus Torvalds > wrote: > > > > I do like your "success"/"stdout" more than "shell"/"shell-stdout", > > because with that naming I don't get the feeling that one should > > subsume the other. > >

Re: [PATCH 07/23] kconfig: add function support and implement 'shell' function

On Tue, Feb 20, 2018 at 12:57:13AM +0900, Masahiro Yamada wrote: > 2018-02-18 1:16 GMT+09:00 Ulf Magnusson <ulfali...@gmail.com>: > > On Sat, Feb 17, 2018 at 03:38:35AM +0900, Masahiro Yamada wrote: > >> This commit adds a new concept 'function' to Kconfig. A func

Re: [PATCH 07/23] kconfig: add function support and implement 'shell' function

On Tue, Feb 20, 2018 at 12:57:13AM +0900, Masahiro Yamada wrote: > 2018-02-18 1:16 GMT+09:00 Ulf Magnusson : > > On Sat, Feb 17, 2018 at 03:38:35AM +0900, Masahiro Yamada wrote: > >> This commit adds a new concept 'function' to Kconfig. A function call > >> res

Re: [PATCH 10/20] lib/Kconfig: Remove leftover select of GENERIC_IO

On Mon, Feb 19, 2018 at 4:48 PM, Rob Herring <r...@kernel.org> wrote: > On Sun, Feb 4, 2018 at 7:21 PM, Ulf Magnusson <ulfali...@gmail.com> wrote: >> GENERIC_IO was removed by commit 9de8da47742b ("kconfig: kill off >> GENERIC_IO option"), but HAS_IOMEM stil

Re: [PATCH 10/20] lib/Kconfig: Remove leftover select of GENERIC_IO

On Mon, Feb 19, 2018 at 4:48 PM, Rob Herring wrote: > On Sun, Feb 4, 2018 at 7:21 PM, Ulf Magnusson wrote: >> GENERIC_IO was removed by commit 9de8da47742b ("kconfig: kill off >> GENERIC_IO option"), but HAS_IOMEM still selects it. >> >> Remove th

Re: [PATCH 00/23] kconfig: move compiler capability tests to Kconfig

Hello, On Sun, Feb 18, 2018 at 11:13 PM, Sam Ravnborg wrote: > Hi Masahiro. > > On Sat, Feb 17, 2018 at 03:38:28AM +0900, Masahiro Yamada wrote: >> I brushed up the implementation in this version. >> >> In the previous RFC, CC_HAS_ was described by using 'option shell=', >>

Re: [PATCH 00/23] kconfig: move compiler capability tests to Kconfig

Hello, On Sun, Feb 18, 2018 at 11:13 PM, Sam Ravnborg wrote: > Hi Masahiro. > > On Sat, Feb 17, 2018 at 03:38:28AM +0900, Masahiro Yamada wrote: >> I brushed up the implementation in this version. >> >> In the previous RFC, CC_HAS_ was described by using 'option shell=', >> like this: >> >>

Re: [PATCH 11/23] kconfig: add 'shell-stdout' function

On Fri, Feb 16, 2018 at 11:17:52AM -0800, Linus Torvalds wrote: > On Fri, Feb 16, 2018 at 10:38 AM, Masahiro Yamada > wrote: > > This is the second built-in function, which retrieves the first line > > of stdout from the given shell command. > > This is the only

Re: [PATCH 11/23] kconfig: add 'shell-stdout' function

On Fri, Feb 16, 2018 at 11:17:52AM -0800, Linus Torvalds wrote: > On Fri, Feb 16, 2018 at 10:38 AM, Masahiro Yamada > wrote: > > This is the second built-in function, which retrieves the first line > > of stdout from the given shell command. > > This is the only part I really don't much like in

Re: [PATCH v2] Makefile: Fix lying comment re. silentoldconfig

On Mon, Feb 19, 2018 at 12:37 AM, Masahiro Yamada <yamada.masah...@socionext.com> wrote: > 2018-02-13 16:58 GMT+09:00 Ulf Magnusson <ulfali...@gmail.com>: >> The comment above the silentoldconfig invocation is outdated. >> 'make oldconfig' updates just .config and d

Re: [PATCH v2] Makefile: Fix lying comment re. silentoldconfig

On Mon, Feb 19, 2018 at 12:37 AM, Masahiro Yamada wrote: > 2018-02-13 16:58 GMT+09:00 Ulf Magnusson : >> The comment above the silentoldconfig invocation is outdated. >> 'make oldconfig' updates just .config and doesn't touch the >> include/config/ tree. >> >>

Re: [PATCH 06/23] kconfig: reference environments directly and remove 'option env=' syntax

On Sat, Feb 17, 2018 at 03:38:34AM +0900, Masahiro Yamada wrote: > To get an environment value, Kconfig needs to define a symbol using > "option env=" syntax. It is tedious to add a config entry for each > environment given that we need more environments such as 'CC', 'AS', > 'srctree' etc. to

Re: [PATCH 06/23] kconfig: reference environments directly and remove 'option env=' syntax

On Sat, Feb 17, 2018 at 03:38:34AM +0900, Masahiro Yamada wrote: > To get an environment value, Kconfig needs to define a symbol using > "option env=" syntax. It is tedious to add a config entry for each > environment given that we need more environments such as 'CC', 'AS', > 'srctree' etc. to

Re: [PATCH 07/23] kconfig: add function support and implement 'shell' function

On Sat, Feb 17, 2018 at 03:38:35AM +0900, Masahiro Yamada wrote: > This commit adds a new concept 'function' to Kconfig. A function call > resembles a variable reference with arguments, and looks like this: > > $(function arg1, arg2, arg3, ...) > > (Actually, this syntax was inspired by

Re: [PATCH 07/23] kconfig: add function support and implement 'shell' function

On Sat, Feb 17, 2018 at 03:38:35AM +0900, Masahiro Yamada wrote: > This commit adds a new concept 'function' to Kconfig. A function call > resembles a variable reference with arguments, and looks like this: > > $(function arg1, arg2, arg3, ...) > > (Actually, this syntax was inspired by

Re: [PATCH 08/23] kconfig: add 'macro' keyword to support user-defined function

On Fri, Feb 16, 2018 at 11:44:25PM -0500, Nicolas Pitre wrote: > On Sat, 17 Feb 2018, Ulf Magnusson wrote: > > > On Sat, Feb 17, 2018 at 3:30 AM, Nicolas Pitre <n...@fluxnic.net> wrote: > > > On Sat, 17 Feb 2018, Ulf Magnusson wrote: > > > > > >> O

Re: [PATCH 08/23] kconfig: add 'macro' keyword to support user-defined function

On Fri, Feb 16, 2018 at 11:44:25PM -0500, Nicolas Pitre wrote: > On Sat, 17 Feb 2018, Ulf Magnusson wrote: > > > On Sat, Feb 17, 2018 at 3:30 AM, Nicolas Pitre wrote: > > > On Sat, 17 Feb 2018, Ulf Magnusson wrote: > > > > > >> On Fri, Feb 16, 201

Re: [PATCH 08/23] kconfig: add 'macro' keyword to support user-defined function

On Sat, Feb 17, 2018 at 3:30 AM, Nicolas Pitre <n...@fluxnic.net> wrote: > On Sat, 17 Feb 2018, Ulf Magnusson wrote: > >> On Fri, Feb 16, 2018 at 02:49:31PM -0500, Nicolas Pitre wrote: >> > On Sat, 17 Feb 2018, Masahiro Yamada wrote: >> > >> > &

Re: [PATCH 08/23] kconfig: add 'macro' keyword to support user-defined function

On Sat, Feb 17, 2018 at 3:30 AM, Nicolas Pitre wrote: > On Sat, 17 Feb 2018, Ulf Magnusson wrote: > >> On Fri, Feb 16, 2018 at 02:49:31PM -0500, Nicolas Pitre wrote: >> > On Sat, 17 Feb 2018, Masahiro Yamada wrote: >> > >> > > Now, we got a basic abil

Re: [PATCH 08/23] kconfig: add 'macro' keyword to support user-defined function

On Fri, Feb 16, 2018 at 02:49:31PM -0500, Nicolas Pitre wrote: > On Sat, 17 Feb 2018, Masahiro Yamada wrote: > > > Now, we got a basic ability to test compiler capability in Kconfig. > > > > config CC_HAS_STACKPROTECTOR > > bool > > default $(shell $CC -Werror -fstack-protector

Re: [PATCH 08/23] kconfig: add 'macro' keyword to support user-defined function

On Fri, Feb 16, 2018 at 02:49:31PM -0500, Nicolas Pitre wrote: > On Sat, 17 Feb 2018, Masahiro Yamada wrote: > > > Now, we got a basic ability to test compiler capability in Kconfig. > > > > config CC_HAS_STACKPROTECTOR > > bool > > default $(shell $CC -Werror -fstack-protector

[PATCH 2/3] checkpatch: kconfig: check help texts for menuconfig and choice

', 'endchoice', and 'source' as ending a symbol/choice definition. Signed-off-by: Ulf Magnusson <ulfali...@gmail.com> --- scripts/checkpatch.pl | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 2b4043

[PATCH 2/3] checkpatch: kconfig: check help texts for menuconfig and choice

', 'endchoice', and 'source' as ending a symbol/choice definition. Signed-off-by: Ulf Magnusson --- scripts/checkpatch.pl | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 2b404317daea..54b782fab4fd 100755

[PATCH 3/3] checkpatch: kconfig: prefer 'help' over '---help---'

c2264564df3d ("kconfig: warn of unhandled characters in Kconfig commands"), '---help---' is a proper keyword and can only appear in that form. Prior to that commit, '---help---' working was more of a syntactic quirk. Signed-off-by: Ulf Magnusson <ulfali...@gmail.com> --- scripts/checkpatch.

[PATCH 1/3] checkpatch: kconfig: recognize more prompts when checking help texts

The check for a missing or short help text only considers symbols with a prompt, but doesn't recognize any of the following as a prompt: bool 'foo' tristate 'foo' prompt "foo" prompt 'foo' Make the check recognize those too. Signed-off-by: Ulf Magnuss

[PATCH 3/3] checkpatch: kconfig: prefer 'help' over '---help---'

c2264564df3d ("kconfig: warn of unhandled characters in Kconfig commands"), '---help---' is a proper keyword and can only appear in that form. Prior to that commit, '---help---' working was more of a syntactic quirk. Signed-off-by: Ulf Magnusson --- scripts/checkpatch.pl | 6 +- 1 file

[PATCH 1/3] checkpatch: kconfig: recognize more prompts when checking help texts

The check for a missing or short help text only considers symbols with a prompt, but doesn't recognize any of the following as a prompt: bool 'foo' tristate 'foo' prompt "foo" prompt 'foo' Make the check recognize those too. Signed-off-by: Ulf

[PATCH 0/3] Improve and extend checkpatch.pl Kconfig help text checks

using --fix or --fix-inplace. Kconfig.test_help_check has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Cheers, Ulf Ulf Magnusson (3): checkpatch: kc

[PATCH 0/3] Improve and extend checkpatch.pl Kconfig help text checks

using --fix or --fix-inplace. Kconfig.test_help_check has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Cheers, Ulf Ulf Magnusson (3): checkpatch: kc

[PATCH] video: fbdev: kconfig: Add help text to FB_I810_I2C

The FB_I810_I2C symbol previously had a blank help text, which was removed in e9829ac4e5fd ("video: fbdev: kconfig: Remove blank help text"). Give it a proper help text, derived from commit 74f6ae84b23 ("[PATCH] i810fb: Add > i2c/DDC support"). Signed-off-by: Ulf Magnuss

[PATCH] video: fbdev: kconfig: Add help text to FB_I810_I2C

The FB_I810_I2C symbol previously had a blank help text, which was removed in e9829ac4e5fd ("video: fbdev: kconfig: Remove blank help text"). Give it a proper help text, derived from commit 74f6ae84b23 ("[PATCH] i810fb: Add > i2c/DDC support"). Signed-off-by: Ulf Magnusson

Re: Linux 4.16-rc1: regression bisected, Debian kernel package tool make-kpkg stalls indefinitely during kernel build due to commit "kconfig: remove check_stdin()"

On Tue, Feb 13, 2018 at 1:35 PM, Ulf Magnusson <ulfali...@gmail.com> wrote: > On Tue, Feb 13, 2018 at 12:33:24PM +0100, Ulf Magnusson wrote: >> On Tue, Feb 13, 2018 at 11:00:49AM +0100, Sander Eikelenboom wrote: >> > On 13/02/18 05:09, Masahiro Yamada wrote: >> > &

Re: Linux 4.16-rc1: regression bisected, Debian kernel package tool make-kpkg stalls indefinitely during kernel build due to commit "kconfig: remove check_stdin()"

On Tue, Feb 13, 2018 at 1:35 PM, Ulf Magnusson wrote: > On Tue, Feb 13, 2018 at 12:33:24PM +0100, Ulf Magnusson wrote: >> On Tue, Feb 13, 2018 at 11:00:49AM +0100, Sander Eikelenboom wrote: >> > On 13/02/18 05:09, Masahiro Yamada wrote: >> > > 2018-02-13

Re: Linux 4.16-rc1: regression bisected, Debian kernel package tool make-kpkg stalls indefinitely during kernel build due to commit "kconfig: remove check_stdin()"

On Tue, Feb 13, 2018 at 12:33:24PM +0100, Ulf Magnusson wrote: > On Tue, Feb 13, 2018 at 11:00:49AM +0100, Sander Eikelenboom wrote: > > On 13/02/18 05:09, Masahiro Yamada wrote: > > > 2018-02-13 12:00 GMT+09:00 Woody Suwalski <terraluna...@gmail.com>: > &g

Re: Linux 4.16-rc1: regression bisected, Debian kernel package tool make-kpkg stalls indefinitely during kernel build due to commit "kconfig: remove check_stdin()"

On Tue, Feb 13, 2018 at 12:33:24PM +0100, Ulf Magnusson wrote: > On Tue, Feb 13, 2018 at 11:00:49AM +0100, Sander Eikelenboom wrote: > > On 13/02/18 05:09, Masahiro Yamada wrote: > > > 2018-02-13 12:00 GMT+09:00 Woody Suwalski : > > >> Sander Eikelenb

Re: Linux 4.16-rc1: regression bisected, Debian kernel package tool make-kpkg stalls indefinitely during kernel build due to commit "kconfig: remove check_stdin()"

-n 4 stdout > >>>Console input/output is redirected. Run 'make oldconfig' to update > >>> configuration. > >>> scripts/kconfig/Makefile:40: recipe for target > >>> 'silentoldconfig' failed > >>>Makefile:507: recipe f

Re: Linux 4.16-rc1: regression bisected, Debian kernel package tool make-kpkg stalls indefinitely during kernel build due to commit "kconfig: remove check_stdin()"

rm -f .config; touch .config > >>>$ yes "" | make silentoldconfig > stdout > >>>make[1]: *** [silentoldconfig] Error 1 > >>>make: *** [silentoldconfig] Error 2 > >>>$ tail -n 4 stdout > >>>

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Tue, Feb 13, 2018 at 01:10:34AM +0900, Masahiro Yamada wrote: > 2018-02-13 0:46 GMT+09:00 Kees Cook : > > On Mon, Feb 12, 2018 at 2:44 AM, Masahiro Yamada > > wrote: > >> Linus said: > >> > >>> But yes, I also reacted to your earlier " It

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Tue, Feb 13, 2018 at 01:10:34AM +0900, Masahiro Yamada wrote: > 2018-02-13 0:46 GMT+09:00 Kees Cook : > > On Mon, Feb 12, 2018 at 2:44 AM, Masahiro Yamada > > wrote: > >> Linus said: > >> > >>> But yes, I also reacted to your earlier " It can't silently rewrite it > >>> to _REGULAR because the

[PATCH v2] Makefile: Fix lying comment re. silentoldconfig

/config/auto.conf would still be out of date re. .config if the operation fails. Cop out and leave the prerequisite in for now. Signed-off-by: Ulf Magnusson <ulfali...@gmail.com> --- Changes in v2: include/config/auto.conf depends on .config, not the other way around, so swap them in some

[PATCH v2] Makefile: Fix lying comment re. silentoldconfig

/config/auto.conf would still be out of date re. .config if the operation fails. Cop out and leave the prerequisite in for now. Signed-off-by: Ulf Magnusson --- Changes in v2: include/config/auto.conf depends on .config, not the other way around, so swap them in some places in the commit message

[PATCH] Makefile: Fix lying comment re. silentoldconfig

would still be out of date re. include/config/auto.conf if the operation fails. Cop out and leave the prerequisite in for now though. Signed-off-by: Ulf Magnusson <ulfali...@gmail.com> --- Makefile | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/Makefile b/Ma

[PATCH] Makefile: Fix lying comment re. silentoldconfig

would still be out of date re. include/config/auto.conf if the operation fails. Cop out and leave the prerequisite in for now though. Signed-off-by: Ulf Magnusson --- Makefile | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index 79ad2bfa24b6

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, Feb 12, 2018 at 4:22 PM, Masahiro Yamada <yamada.masah...@socionext.com> wrote: > 2018-02-12 23:53 GMT+09:00 Ulf Magnusson <ulfali...@gmail.com>: >> On Mon, Feb 12, 2018 at 3:21 PM, Masahiro Yamada >> <yamada.masah...@socionext.com> wrote: >&

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, Feb 12, 2018 at 4:22 PM, Masahiro Yamada wrote: > 2018-02-12 23:53 GMT+09:00 Ulf Magnusson : >> On Mon, Feb 12, 2018 at 3:21 PM, Masahiro Yamada >> wrote: >>> 'syncconfig' in a more proper name >> >> Wonder if --update-config-files-for-build or somet

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

le making it somewhat clear what kind of stuff it deals with. :P Cheers, Ulf On Mon, Feb 12, 2018 at 3:21 PM, Masahiro Yamada <yamada.masah...@socionext.com> wrote: > 2018-02-12 21:54 GMT+09:00 Ulf Magnusson <ulfali...@gmail.com>: >> On Sun, Feb 11, 2018 at 09:42:09PM +0100, U

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

ind of stuff it deals with. :P Cheers, Ulf On Mon, Feb 12, 2018 at 3:21 PM, Masahiro Yamada wrote: > 2018-02-12 21:54 GMT+09:00 Ulf Magnusson : >> On Sun, Feb 11, 2018 at 09:42:09PM +0100, Ulf Magnusson wrote: >>> On Sun, Feb 11, 2018 at 9:29 PM, Ulf Magnusson wrote: >>>

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, Feb 12, 2018 at 3:23 PM, Masahiro Yamada <yamada.masah...@socionext.com> wrote: > 2018-02-12 23:21 GMT+09:00 Masahiro Yamada <yamada.masah...@socionext.com>: >> 2018-02-12 21:54 GMT+09:00 Ulf Magnusson <ulfali...@gmail.com>: >>> On Sun, Feb 11, 2018 at 0

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, Feb 12, 2018 at 3:23 PM, Masahiro Yamada wrote: > 2018-02-12 23:21 GMT+09:00 Masahiro Yamada : >> 2018-02-12 21:54 GMT+09:00 Ulf Magnusson : >>> On Sun, Feb 11, 2018 at 09:42:09PM +0100, Ulf Magnusson wrote: >>>> On Sun, Feb 11, 2018 at 9:29 PM, Ulf Magnusson

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, Feb 12, 2018 at 3:21 PM, Masahiro Yamada <yamada.masah...@socionext.com> wrote: > 2018-02-12 21:54 GMT+09:00 Ulf Magnusson <ulfali...@gmail.com>: >> On Sun, Feb 11, 2018 at 09:42:09PM +0100, Ulf Magnusson wrote: >>> On Sun, Feb 11, 2018 at 9:29 PM, Ulf Magnuss

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, Feb 12, 2018 at 3:21 PM, Masahiro Yamada wrote: > 2018-02-12 21:54 GMT+09:00 Ulf Magnusson : >> On Sun, Feb 11, 2018 at 09:42:09PM +0100, Ulf Magnusson wrote: >>> On Sun, Feb 11, 2018 at 9:29 PM, Ulf Magnusson wrote: >>> > On Sun, Feb 11, 2018 at 6:56 PM, Ke

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, Feb 12, 2018 at 2:53 PM, Masahiro Yamada <yamada.masah...@socionext.com> wrote: > 2018-02-12 20:44 GMT+09:00 Ulf Magnusson <ulfali...@gmail.com>: > >>> >>> I think Linus's comment was dismissed here. >>> >>> >>> Linus sa

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, Feb 12, 2018 at 2:53 PM, Masahiro Yamada wrote: > 2018-02-12 20:44 GMT+09:00 Ulf Magnusson : > >>> >>> I think Linus's comment was dismissed here. >>> >>> >>> Linus said: >>> >>>> But yes, I also reacted to your earl

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 09:42:09PM +0100, Ulf Magnusson wrote: > On Sun, Feb 11, 2018 at 9:29 PM, Ulf Magnusson <ulfali...@gmail.com> wrote: > > On Sun, Feb 11, 2018 at 6:56 PM, Kees Cook <keesc...@chromium.org> wrote: > >> Another case I mentioned before that I j

<    1   2   3   4   5   6   7   >