is not found, just skip and free
> the others.
>
nit, typo error "If if one".
> Fixes: 510e340efe0c ("staging: greybus: audio: Add helper APIs for dynamic
> audio module")
> Reported-by: Hulk Robot
> Signed-off-by: Wang Hai
> ---
Reviewed-by: Vaibhav Agarwal
--
thanks,
vaibhav
On Fri, Dec 4, 2020 at 2:10 PM Johan Hovold wrote:
>
> On Fri, Dec 04, 2020 at 10:13:50AM +0800, Wang Hai wrote:
> > Add the missing unlock before return from function
> > gbaudio_dapm_free_controls() in the error handling case.
> >
> > Fixes: 510e340efe0c ("staging: greybus: audio: Add helper
--
Hi Coiby,
Thanks for sharing the patch. Sorry, I could not reply to the v1 series.
Now, I have gone through the patches. Looks good (all 3 patches).
Reviewed-by: Vaibhav Agarwal
--
Thanks,
if (gbvalue.value.integer_value[0] != val) {
This patch fixes the issue with fetching the gbvalue before using it for
comparision.
Fixes: 6339d2322c47 ("greybus: audio: Add topology parser for GB codec")
Reported-by: Colin Ian King
Signed-off-by: Vaibhav Agarwal
---
Changelo
if (gbvalue.value.integer_value[0] != val) {
This patch fixes the issue with fetching the gbvalue before using it for
comparision.
Fixes: 6339d2322c47 ("greybus: audio: Add topology parser for GB codec")
Reported-by: Colin Ian King
Signed-off-by: Vaibhav Agarwal
---
Changelo
On Mon, Aug 10, 2020 at 8:34 PM Dan Carpenter wrote:
>
> On Thu, Aug 06, 2020 at 09:51:57PM +0530, Vaibhav Agarwal wrote:
> > diff --git a/drivers/staging/greybus/audio_topology.c
> > b/drivers/staging/greybus/audio_topology.c
> > index 2f9fdbdcd547..4b914d0edef2 100644
&
if (gbvalue.value.integer_value[0] != val) {
This patch fixes the issue with fetching the gbvalue before using it for
comparision.
Fixes: 6339d2322c47 ("greybus: audio: Add topology parser for GB codec")
Reported-by: Colin Ian King
Signed-off-by: Vaibhav Agarwal
---
drivers/stagi
On Wed, Aug 05, 2020 at 08:35:15AM -0500, Alex Elder wrote:
>
> I think the fix is to add a call to this:
>
> ret = gb_audio_gb_get_control(module->mgmt_connection, data->ctl_id,
> GB_AUDIO_INVALID_INDEX, );
>
> before the field within gbvalue is
On Wed, Aug 5, 2020 at 6:35 PM Alex Elder wrote:
>
> On 7/9/20 5:27 AM, Vaibhav Agarwal wrote:
> > snd_soc_jack APIs are modified in recent kernel versions. This patch
> > updates the codec driver to resolve the compilation errors related to
> > jack framework.
>
On Thu, Jul 30, 2020 at 05:02:22PM +0100, Colin Ian King wrote:
> Hi,
>
> Static analysis with Coverity has detected an uninitialized value being
> used in a comparison. The error was detected on a recent change to
> drivers/staging/greybus/audio_topology.c however the issue actually
> dates
This patch fixes the warning reported for missing prototypes due to
missing header file. Also, it includes changes to remove
unused_but_set_variables.
Reported-by: kernel test robot
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/audio_helper.c | 1 +
drivers/staging/greybus
Fix compilation errors for GB Audio topology parser code with recent
kernel versions.
Signed-off-by: Vaibhav Agarwal
Reviewed-by: Dan Carpenter
---
drivers/staging/greybus/audio_topology.c | 123 +++
1 file changed, 57 insertions(+), 66 deletions(-)
diff --git a/drivers
to modules which are dynamically added or removed. The
source is primarily based on snd_dapm.c
Signed-off-by: Vaibhav Agarwal
Reviewed-by: Dan Carpenter
---
drivers/staging/greybus/Makefile | 2 +-
drivers/staging/greybus/audio_codec.c | 12 +-
drivers/staging/greybus/audio_helper.c | 197
to update the dependencies for GREYBUS_AUDIO to
make the compile work.
Signed-off-by: Vaibhav Agarwal
Reviewed-by: Dan Carpenter
---
drivers/staging/greybus/Kconfig | 14 +-
drivers/staging/greybus/Makefile | 4 ++--
2 files changed, 15 insertions(+), 3 deletions(-)
diff --git
snd_soc_jack APIs are modified in recent kernel versions. This patch
updates the codec driver to resolve the compilation errors related to
jack framework.
Signed-off-by: Vaibhav Agarwal
Reviewed-by: Dan Carpenter
---
drivers/staging/greybus/audio_codec.c | 54 +--
1
maintained within gbaudio_module_info as well. This patch provides the
relevant changes for the same.
Signed-off-by: Vaibhav Agarwal
Reviewed-by: Dan Carpenter
---
drivers/staging/greybus/audio_codec.c | 74 +-
drivers/staging/greybus/audio_codec.h | 10 +++-
drivers
...@intel.com/
Vaibhav Agarwal (7):
staging: greybus: audio: Update snd_jack FW usage as per new APIs
staging: greybus: audio: Maintain jack list within GB Audio module
staging: greybus: audio: Resolve compilation errors for GB codec
module
staging: greybus: audio: Resolve compilation
Due to dependencies on ASoC framework changes, GB dummy codec module
compilation is currently disabled. This patch updates codec driver as
per the latest ASoC APIs.
Signed-off-by: Vaibhav Agarwal
Reviewed-by: Dan Carpenter
---
drivers/staging/greybus/audio_codec.c | 88
On Wed, Jul 01, 2020 at 03:36:55PM +0200, Greg Kroah-Hartman wrote:
> On Fri, Jun 19, 2020 at 04:50:26PM +0530, Vaibhav Agarwal wrote:
> > Currently you can't enable the Gey Bus Audio Codec because there is no
> > entry for it in the Kconfig file. Originally the config
to modules which are dynamically added or removed. The
source is primarily based on snd_dapm.c
Signed-off-by: Vaibhav Agarwal
Reviewed-by: Dan Carpenter
---
drivers/staging/greybus/Makefile | 2 +-
drivers/staging/greybus/audio_codec.c | 12 +-
drivers/staging/greybus/audio_helper.c | 197
to update the dependencies for GREYBUS_AUDIO to
make the compile work.
Signed-off-by: Vaibhav Agarwal
Reviewed-by: Dan Carpenter
---
drivers/staging/greybus/Kconfig | 14 +-
drivers/staging/greybus/Makefile | 4 ++--
2 files changed, 15 insertions(+), 3 deletions(-)
diff --git
Fix compilation errors for GB Audio topology parser code with recent
kernel versions.
Signed-off-by: Vaibhav Agarwal
Reviewed-by: Dan Carpenter
---
drivers/staging/greybus/audio_topology.c | 123 +++
1 file changed, 57 insertions(+), 66 deletions(-)
diff --git a/drivers
Due to dependencies on ASoC framework changes, GB dummy codec module
compilation is currently disabled. This patch updates codec driver as
per the latest ASoC APIs.
Signed-off-by: Vaibhav Agarwal
Reviewed-by: Dan Carpenter
---
drivers/staging/greybus/audio_codec.c | 88
maintained within gbaudio_module_info as well. This patch provides the
relevant changes for the same.
Signed-off-by: Vaibhav Agarwal
Reviewed-by: Dan Carpenter
---
drivers/staging/greybus/audio_codec.c | 74 +-
drivers/staging/greybus/audio_codec.h | 10 +++-
drivers
defining unused 'update' pointer
- Fix the missing connect bool value required during mixer_update_power
- Added Reviewed-by tag from Dan
- Rebase to latest staging-next
Vaibhav Agarwal (6):
staging: greybus: audio: Update snd_jack FW usage as per new APIs
staging: greybus: audio: Maintain jack list
snd_soc_jack APIs are modified in recent kernel versions. This patch
updates the codec driver to resolve the compilation errors related to
jack framework.
Signed-off-by: Vaibhav Agarwal
Reviewed-by: Dan Carpenter
---
drivers/staging/greybus/audio_codec.c | 54 +--
1
On Thu, Jun 11, 2020 at 09:26:16AM +0100, Mark Brown wrote:
> On Wed, Jun 10, 2020 at 11:53:24PM +0530, Vaibhav Agarwal wrote:
>
> > With patch#6 in this series, I'm proposing some of the (dummy) helper
> > APIs required to link DAPM DAI widgets for the GB Audio modules
On Wed, Jun 10, 2020 at 08:45:35PM +0300, Dan Carpenter wrote:
> On Wed, Jun 10, 2020 at 10:58:28PM +0530, Vaibhav Agarwal wrote:
> > @@ -437,11 +433,12 @@ static int gbcodec_mixer_dapm_ctl_put(struct
> > snd_kcontrol *kcontrol,
> > struct gbaudio_module_info *m
On Wed, Jun 10, 2020 at 06:37:11PM +0100, Mark Brown wrote:
> On Wed, Jun 10, 2020 at 10:58:24PM +0530, Vaibhav Agarwal wrote:
> > The existing GB Audio codec driver is dependent on MSM8994 Audio driver.
> > During the development stage, this dependency was configured due to
>
the necessary changes.
[1]
https://lore.kernel.org/lkml/20200507212912.599433-1-alexandre.bell...@bootlin.com/
Changes from v1
- Include the changes for the review comments suggested by Dan
- Rebase to latest staging-next
Vaibhav Agarwal (6):
staging: greybus: audio: Update snd_jack FW usage as per
to modules which are dynamically added or removed. The
source is primarily based on snd_dapm.c
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/Makefile | 2 +-
drivers/staging/greybus/audio_codec.c | 12 +-
drivers/staging/greybus/audio_helper.c | 197
maintained within gbaudio_module_info as well. This patch provides the
relevant changes for the same.
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/audio_codec.c | 74 +-
drivers/staging/greybus/audio_codec.h | 10 +++-
drivers/staging/greybus/audio_module.c
to update the dependencies for GREYBUS_AUDIO to
make the compile work.
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/Kconfig | 14 +-
drivers/staging/greybus/Makefile | 4 ++--
2 files changed, 15 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/greybus/Kconfig
Fix compilation errors for GB Audio topology parser code with recent
kernel versions.
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/audio_topology.c | 128 +++
1 file changed, 60 insertions(+), 68 deletions(-)
diff --git a/drivers/staging/greybus
Due to dependencies on ASoC framework changes, GB dummy codec module
compilation is currently disabled. This patch updates codec driver as
per the latest ASoC APIs.
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/audio_codec.c | 88 +--
drivers/staging/greybus
snd_soc_jack APIs are modified in recent kernel versions. This patch
updates the codec driver to resolve the compilation errors related to
jack framework.
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/audio_codec.c | 54 +--
1 file changed, 42 insertions
On Tue, Jun 02, 2020 at 03:57:15PM +0300, Dan Carpenter wrote:
> On Tue, Jun 02, 2020 at 10:51:15AM +0530, Vaibhav Agarwal wrote:
> > Currently, GB codec and audio module is conditionally compiled based on
> > GREYBUS_AUDIO_MSM8994. However, audio module is not dependent on MSM89
to modules which are dynamically added or removed. The
source is primarily based on snd_dapm.c
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/Makefile | 2 +-
drivers/staging/greybus/audio_codec.c | 13 +-
drivers/staging/greybus/audio_helper.c | 197
Fix compilation errors for GB Audio topology parser code with recent
kernel versions.
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/audio_topology.c | 130 +++
1 file changed, 61 insertions(+), 69 deletions(-)
diff --git a/drivers/staging/greybus
represented by I2S port
available on Toshiba AP Bridge. Added config option for the same in
kconfig file and accordingly updated Makefile.
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/Kconfig | 14 +-
drivers/staging/greybus/Makefile | 4 ++--
2 files changed, 15 insertions
maintained within gbaudio_module_info as well. This patch provides the
relevant changes for the same.
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/audio_codec.c | 76 ++
drivers/staging/greybus/audio_codec.h | 10 +++-
drivers/staging/greybus/audio_module.c
Due to dependencies on ASoC framework changes, GB dummy codec module
compilation is currently disabled. This patch updates codec driver as
per the latest ASoC APIs.
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/audio_codec.c | 87 +--
drivers/staging/greybus
snd_soc_jack APIs are modified in recent kernel versions. This patch
updates the codec driver to resolve the compilation errors related to
jack framework.
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/audio_codec.c | 59 +--
1 file changed, 47 insertions
of
modules.
Patch 6: Finally provides config options and related Makefile changes to
enable GB Codec driver.
Thanks to Alexandre for raising the headsup [1] and motivating me to provide
the necessary changes.
[1]
https://lore.kernel.org/lkml/20200507212912.599433-1-alexandre.bell...@bootlin.com/
On Sun, May 17, 2020 at 07:37:06PM +0200, Alexandre Belloni wrote:
> Hi,
>
> On 17/05/2020 22:47:20+0530, Vaibhav Agarwal wrote:
> > Greybus Codec driver allows modules to be dynamically added and removed,
> > which further requires updating the DAPM configurations as well.
represented by I2S port
available on Toshiba AP Bridge. Added config option for the same in
kconfig file and accordingly updated Makefile.
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/Kconfig | 14 +-
drivers/staging/greybus/Makefile | 4 ++--
2 files changed, 15 insertions
the necessary changes.
[1]
https://lore.kernel.org/lkml/20200507212912.599433-1-alexandre.bell...@bootlin.com/
Vaibhav Agarwal (6):
staging: greybus: audio: Update snd_jack FW usage as per new APIs
staging: greybus: audio: Maintain jack list within GB Audio module
staging: greybus: audio: Resolve
snd_soc_jack APIs are modified in recent kernel versions. This patch
updates the codec driver to resolve the compilation errors related to
jack framework.
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/audio_codec.c | 59 ---
1 file changed, 47
Due to dependencies on ASoC framework changes, GB dummy codec module
compilation is currently disabled. This patch updates codec driver as
per the latest ASoC APIs.
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/audio_codec.c | 87 +--
drivers/staging
to modules which are dynamically added or removed. The
source is primarily based on snd_dapm.c
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/Makefile | 2 +-
drivers/staging/greybus/audio_codec.c | 13 ++-
drivers/staging/greybus/audio_helper.c | 197
maintained within gbaudio_module_info as well. This patch provides the
relevant changes for the same.
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/audio_codec.c | 76 ++
drivers/staging/greybus/audio_codec.h | 10 -
drivers/staging/greybus
Fix compilation errors for GB Audio topology parser code with recent
kernel versions.
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/audio_topology.c | 130 +++
1 file changed, 61 insertions(+), 69 deletions(-)
diff --git a/drivers/staging/greybus
On Wed, May 13, 2020 at 11:15 PM Mark Greer wrote:
>
> On Thu, May 07, 2020 at 11:29:11PM +0200, Alexandre Belloni wrote:
> > GREYBUS_AUDIO_MSM8994 is not an existing configuration option and as
> > reported in September 2016, it depends on an "out-of-tree qualcomm audio
> > driver". This driver
er_module *module, *next;
> - int is_empty = 1;
> + int is_empty;
>
> down_write(_rwsem);
>
> --
> 2.20.1
>
Reviewed-by: Vaibhav Agarwal
t
> gb_audio_manager_module_descriptor *desc)
> int err;
>
> id = ida_simple_get(_id, 0, 0, GFP_KERNEL);
> + if (id < 0)
> + return id;
> +
> err = gb_audio_manager_module_create(, manager_kset,
>
gt; --- a/drivers/staging/mt7621-eth/mtk_eth_soc.c
> +++ b/drivers/staging/mt7621-eth/mtk_eth_soc.c
> @@ -2167,7 +2167,6 @@ static int mtk_remove(struct platform_device *pdev)
> .remove = mtk_remove,
> .driver = {
> .name = "mtk_soc_eth",
> - .owner = THIS_MODULE,
> .of_match_table = of_mtk_match,
> },
> };
> --
> 1.7.12.4
>
Acked-by: Vaibhav Agarwal
gt; --- a/drivers/staging/mt7621-eth/mtk_eth_soc.c
> +++ b/drivers/staging/mt7621-eth/mtk_eth_soc.c
> @@ -2167,7 +2167,6 @@ static int mtk_remove(struct platform_device *pdev)
> .remove = mtk_remove,
> .driver = {
> .name = "mtk_soc_eth",
> - .owner = THIS_MODULE,
> .of_match_table = of_mtk_match,
> },
> };
> --
> 1.7.12.4
>
Acked-by: Vaibhav Agarwal
count=%d for %s\n",
> + dev_err(module->dev, "Invalid kcontrol count=%d for %s\n",
> w->ncontrols, w->name);
> return ret;
> }
> --
> 2.17.0
Acked-by: Vaibhav Agarwal <vaibhav...@gmail.com>
unt=%d for %s\n",
> w->ncontrols, w->name);
> return ret;
> }
> --
> 2.17.0
Acked-by: Vaibhav Agarwal
> +/*
> + * device_type should be same as defined in audio.h
> + * (Android media layer)
> + */
Acked-by: Vaibhav Agarwal <vaibhav...@gmail.com>
--
thanks,
./va
ging/greybus/audio_codec.h
> +++ b/drivers/staging/greybus/audio_codec.h
> @@ -23,7 +23,10 @@ enum {
> NUM_CODEC_DAIS,
> };
>
> -/* device_type should be same as defined in audio.h (Android media layer) */
> +/*
> + * device_type should be same as defined in audio.h
> + * (Android media layer)
> + */
Acked-by: Vaibhav Agarwal
--
thanks,
./va
On Wed, Jan 3, 2018 at 3:09 PM, Sumit Pundir wrote:
> This patch fixes the following checkpatch.pl issue at multiple lines:
>
> CHECK: Prefer kernel type 'u32' over 'uint32_t'
> + uint32_t format, rate;
>
> Signed-off-by: Sumit Pundir
> ---
On Wed, Jan 3, 2018 at 3:09 PM, Sumit Pundir wrote:
> This patch fixes the following checkpatch.pl issue at multiple lines:
>
> CHECK: Prefer kernel type 'u32' over 'uint32_t'
> + uint32_t format, rate;
>
> Signed-off-by: Sumit Pundir
> ---
Hi Sumit,
Similar patches are already submitted
hannels,
>
> CHECK: Prefer kernel type 'u32' over 'uint32_t'
> + uint32_t format, uint32_t rate, u8 channels,
>
> Signed-off-by: Marcos Paulo de Souza <marcos.souza@gmail.com>
> ---
Acked-by: Vaibhav Agarwal <vaibhav...@gmail.com>
r kernel type 'u32' over 'uint32_t'
> + uint32_t format, uint32_t rate, u8 channels,
>
> Signed-off-by: Marcos Paulo de Souza
> ---
Acked-by: Vaibhav Agarwal
On Mon, Oct 17, 2016 at 9:01 PM, Johan Hovold wrote:
> On Sun, Oct 16, 2016 at 03:29:14PM +0530, Pankaj Bharadiya wrote:
>> gb_audio_manager_module_descriptor's cport field is actually used to
>> manage and pass interface id to user space.
>>
>> Thus rename
On Mon, Oct 17, 2016 at 9:01 PM, Johan Hovold wrote:
> On Sun, Oct 16, 2016 at 03:29:14PM +0530, Pankaj Bharadiya wrote:
>> gb_audio_manager_module_descriptor's cport field is actually used to
>> manage and pass interface id to user space.
>>
>> Thus rename gb_audio_manager_module_descriptor's
desc.name, , , _id,
> + _devices, _devices);
>
> if (num != 7)
> return -EINVAL;
> diff --git a/drivers/staging/greybus/audio_module.c
> b/drivers/staging/greybus/audio_module.c
> index 45b2519..0269a1d 100644
> --- a/drivers/staging/greybus/audio_module.c
> +++ b/drivers/staging/greybus/audio_module.c
> @@ -345,7 +345,6 @@ static int gb_audio_probe(struct gb_bundle *bundle,
> dev_dbg(dev, "Inform set_event:%d to above layer\n", 1);
> /* prepare for the audio manager */
> strlcpy(desc.name, gbmodule->name, GB_AUDIO_MANAGER_MODULE_NAME_LEN);
> - desc.slot = 1; /* todo */
> desc.vid = 2; /* todo */
> desc.pid = 3; /* todo */
> desc.intf_id = gbmodule->dev_id;
> --
> 1.9.1
>
Reviewed-by: Vaibhav Agarwal <vaibhav...@gmail.com>
vices);
>
> if (num != 7)
> return -EINVAL;
> diff --git a/drivers/staging/greybus/audio_module.c
> b/drivers/staging/greybus/audio_module.c
> index 45b2519..0269a1d 100644
> --- a/drivers/staging/greybus/audio_module.c
> +++ b/drivers/staging/greybus/audio_module.c
> @@ -345,7 +345,6 @@ static int gb_audio_probe(struct gb_bundle *bundle,
> dev_dbg(dev, "Inform set_event:%d to above layer\n", 1);
> /* prepare for the audio manager */
> strlcpy(desc.name, gbmodule->name, GB_AUDIO_MANAGER_MODULE_NAME_LEN);
> - desc.slot = 1; /* todo */
> desc.vid = 2; /* todo */
> desc.pid = 3; /* todo */
> desc.intf_id = gbmodule->dev_id;
> --
> 1.9.1
>
Reviewed-by: Vaibhav Agarwal
)
> return -EINVAL;
> diff --git a/drivers/staging/greybus/audio_module.c
> b/drivers/staging/greybus/audio_module.c
> index ae1c0fa..45b2519 100644
> --- a/drivers/staging/greybus/audio_module.c
> +++ b/drivers/staging/greybus/audio_module.c
> @@ -348,7 +348,7 @@ static int gb_audio_probe(struct gb_bundle *bundle,
> desc.slot = 1; /* todo */
> desc.vid = 2; /* todo */
> desc.pid = 3; /* todo */
> - desc.cport = gbmodule->dev_id;
> + desc.intf_id = gbmodule->dev_id;
> desc.op_devices = gbmodule->op_devices;
> desc.ip_devices = gbmodule->ip_devices;
> gbmodule->manager_id = gb_audio_manager_add();
> --
> 1.9.1
>
Reviewed-by: Vaibhav Agarwal <vaibhav...@gmail.com>
/drivers/staging/greybus/audio_module.c
> b/drivers/staging/greybus/audio_module.c
> index ae1c0fa..45b2519 100644
> --- a/drivers/staging/greybus/audio_module.c
> +++ b/drivers/staging/greybus/audio_module.c
> @@ -348,7 +348,7 @@ static int gb_audio_probe(struct gb_bundle *bundle,
> desc.slot = 1; /* todo */
> desc.vid = 2; /* todo */
> desc.pid = 3; /* todo */
> - desc.cport = gbmodule->dev_id;
> + desc.intf_id = gbmodule->dev_id;
> desc.op_devices = gbmodule->op_devices;
> desc.ip_devices = gbmodule->ip_devices;
> gbmodule->manager_id = gb_audio_manager_add();
> --
> 1.9.1
>
Reviewed-by: Vaibhav Agarwal
On Wed, Oct 12, 2016 at 5:19 AM, Chase Metzger wrote:
> Added braces for else and else if statements where checkpatch complained.
>
> Signed-off-by: Chase Metzger
> ---
> drivers/staging/greybus/audio_topology.c | 7 +--
> 1 file changed,
On Wed, Oct 12, 2016 at 5:19 AM, Chase Metzger wrote:
> Added braces for else and else if statements where checkpatch complained.
>
> Signed-off-by: Chase Metzger
> ---
> drivers/staging/greybus/audio_topology.c | 7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git
cmp("all", buf, 3))
> + } else if (!strncmp("all", buf, 3)) {
> gb_audio_manager_dump_all();
> - else
> + } else {
> return -EINVAL;
> + }
>
> return count;
> }
> --
> 2.1.4
>
Reviewed-by: Vaibhav Agarwal <vaibhav...@gmail.com>
gb_audio_manager_dump_all();
> - else
> + } else {
> return -EINVAL;
> + }
>
> return count;
> }
> --
> 2.1.4
>
Reviewed-by: Vaibhav Agarwal
CODEC_STOP;
> - } else
> + } else {
> ret = -EINVAL;
> + }
> +
> if (ret)
> dev_err_ratelimited(dai->dev,
> "%s:Error during %s %s stream:%d\n",
> --
> 2.1.4
>
Reviewed-by: Vaibhav Agarwal <vaibhav...@gmail.com>
; ret = -EINVAL;
> + }
> +
> if (ret)
> dev_err_ratelimited(dai->dev,
> "%s:Error during %s %s stream:%d\n",
> --
> 2.1.4
>
Reviewed-by: Vaibhav Agarwal
On Fri, Oct 7, 2016 at 8:08 AM, Chase Metzger <chasemetzge...@gmail.com> wrote:
> Added braces to else statements where checkpatch complained.
>
> Signed-off-by: Chase Metzger <chasemetzge...@gmail.com>
> ---
Reviewed-by: Vaibhav Agarwal <vaibhav...@gmail.com>
On Fri, Oct 7, 2016 at 8:08 AM, Chase Metzger wrote:
> Added braces to else statements where checkpatch complained.
>
> Signed-off-by: Chase Metzger
> ---
Reviewed-by: Vaibhav Agarwal
Ian King <colin.k...@canonical.com>
Signed-off-by: Vaibhav Agarwal <vaibhav...@gmail.com>
---
drivers/staging/greybus/audio_topology.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/greybus/audio_topology.c
b/drivers/staging/greybus/audio_t
Ian King
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/audio_topology.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/greybus/audio_topology.c
b/drivers/staging/greybus/audio_topology.c
index f9f33817a092..b6251691a33d 100644
--- a/driv
On Fri, Sep 23, 2016 at 10:28 PM, Greg Kroah-Hartman
wrote:
> On Fri, Sep 23, 2016 at 11:25:40AM +0100, Colin King wrote:
>> From: Colin Ian King
>>
>> Currently, if info is null, the dev_err message is dereferencing an
>> uninitialized
On Fri, Sep 23, 2016 at 10:28 PM, Greg Kroah-Hartman
wrote:
> On Fri, Sep 23, 2016 at 11:25:40AM +0100, Colin King wrote:
>> From: Colin Ian King
>>
>> Currently, if info is null, the dev_err message is dereferencing an
>> uninitialized module pointer. Instead, initialize module before the
>>
+new email ids for myself & Vaibhav H
--
thanks,
./va
On 20 September 2016 at 12:11, Greg KH wrote:
> On Fri, Sep 16, 2016 at 04:24:59PM +0200, Greg KH wrote:
>> On Fri, Sep 16, 2016 at 03:22:08PM +0200, Greg KH wrote:
>> > On Fri, Sep 16, 2016 at 11:18:07AM +0100,
+new email ids for myself & Vaibhav H
--
thanks,
./va
On 20 September 2016 at 12:11, Greg KH wrote:
> On Fri, Sep 16, 2016 at 04:24:59PM +0200, Greg KH wrote:
>> On Fri, Sep 16, 2016 at 03:22:08PM +0200, Greg KH wrote:
>> > On Fri, Sep 16, 2016 at 11:18:07AM +0100, Mark Brown wrote:
>> > > On
85 matches
Mail list logo