Re: [PATCH v3 1/2] tty: serial: 8250: Add Mediatek UART driver

2014-08-08 Thread Varka Bhadram
orm_driver() Thanks. -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v3 2/2] DTS: serial: Add bindings documention for the Mediatek UARTs

2014-08-08 Thread Varka Bhadram
+1,19 @@ +* Mediatek Universal Asynchronous Receiver/Transmitter (UART) + Missing Required Properties:? -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo inf

Re: [PATCH v3 2/2] DTS: serial: Add bindings documention for the Mediatek UARTs

2014-08-08 Thread Varka Bhadram
/mtk-uart.txt @@ -0,0 +1,19 @@ +* Mediatek Universal Asynchronous Receiver/Transmitter (UART) + Missing Required Properties:? -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v3 1/2] tty: serial: 8250: Add Mediatek UART driver

2014-08-08 Thread Varka Bhadram
() Thanks. -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 2/3] tty: serial: 8250: Add Mediatek UART driver

2014-08-05 Thread Varka Bhadram
On 08/05/2014 05:32 PM, Alan Cox wrote: On Tue, 2014-08-05 at 17:25 +0530, Varka Bhadram wrote: On 08/05/2014 04:24 PM, Matthias Brugger wrote: (...) +#include +#include +#include +#include +#include +#include +#include +#include +#include "8250.h" + Better if we hav

Re: [PATCH v2 1/2] dma: Add Xilinx Central DMA DT Binding Documentation

2014-08-05 Thread Varka Bhadram
ies... Required properties: - compatible: Should be "xlnx,axi-cdma-1.00.a" - #dma-cells: Should be <1>, see "dmas" property below - reg : Should contain cdma registers location and length. . -- Regards, Varka Bhadram. -- To unsubscribe from this list:

Re: [PATCH 2/3] tty: serial: 8250: Add Mediatek UART driver

2014-08-05 Thread Varka Bhadram
.of_match_table = mtk8250_of_match, + }, + .probe = mtk8250_probe, + .remove = mtk8250_remove, +}; +module_platform_driver(mtk8250_platform_driver); -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubs

Re: [PATCH v6 1/2] i2c: imx: add DMA support for freescale i2c driver

2014-08-05 Thread Varka Bhadram
esult; } @@ -432,6 +584,160 @@ static irqreturn_t i2c_imx_isr(int irq, void *dev_id) return IRQ_NONE; } +static int i2c_imx_dma_write(struct imx_i2c_struct *i2c_imx, + struct i2c_msg *msgs) static int i2c_imx_dma_write(struct imx_i2c_struct *i2c_i

Re: [PATCH] ASoC: fsl_sai: Add asynchronous mode support

2014-08-05 Thread Varka Bhadram
On 08/05/2014 04:37 PM, Nicolin Chen wrote: Hi Varka, On Tue, Aug 05, 2014 at 04:29:50PM +0530, Varka Bhadram wrote: diff --git a/Documentation/devicetree/bindings/sound/fsl-sai.txt b/Documentation/devicetree/bindings/sound/fsl-sai.txt index 0f4e238..77864f4 100644 --- a/Documentation

Re: [PATCH] ASoC: fsl_sai: Add asynchronous mode support

2014-08-05 Thread Varka Bhadram
and frame sync clocks separately. . -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.h

Re: [PATCH] ASoC: fsl_sai: Add asynchronous mode support

2014-08-05 Thread Varka Bhadram
and receive data by following their own bit clocks and frame sync clocks separately. . -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] ASoC: fsl_sai: Add asynchronous mode support

2014-08-05 Thread Varka Bhadram
On 08/05/2014 04:37 PM, Nicolin Chen wrote: Hi Varka, On Tue, Aug 05, 2014 at 04:29:50PM +0530, Varka Bhadram wrote: diff --git a/Documentation/devicetree/bindings/sound/fsl-sai.txt b/Documentation/devicetree/bindings/sound/fsl-sai.txt index 0f4e238..77864f4 100644 --- a/Documentation

Re: [PATCH v6 1/2] i2c: imx: add DMA support for freescale i2c driver

2014-08-05 Thread Varka Bhadram
on this patch... -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 2/3] tty: serial: 8250: Add Mediatek UART driver

2014-08-05 Thread Varka Bhadram
= mtk8250_pm_ops, + .of_match_table = mtk8250_of_match, + }, + .probe = mtk8250_probe, + .remove = mtk8250_remove, +}; +module_platform_driver(mtk8250_platform_driver); -- Regards, Varka Bhadram. -- To unsubscribe from

Re: [PATCH v2 1/2] dma: Add Xilinx Central DMA DT Binding Documentation

2014-08-05 Thread Varka Bhadram
properties: - compatible: Should be xlnx,axi-cdma-1.00.a - #dma-cells: Should be 1, see dmas property below - reg : Should contain cdma registers location and length. . -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH 2/3] tty: serial: 8250: Add Mediatek UART driver

2014-08-05 Thread Varka Bhadram
On 08/05/2014 05:32 PM, Alan Cox wrote: On Tue, 2014-08-05 at 17:25 +0530, Varka Bhadram wrote: On 08/05/2014 04:24 PM, Matthias Brugger wrote: (...) +#include linux/io.h +#include linux/module.h +#include linux/serial_8250.h +#include linux/of_irq.h +#include linux/of_platform.h +#include

Re: [PATCH v5 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

2014-07-25 Thread Varka Bhadram
c.c create mode 100644 sound/soc/fsl/fsl_asrc.h create mode 100644 sound/soc/fsl/fsl_asrc_dma.c check patch warnings on this patch... -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.ker

Re: [PATCH v4 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

2014-07-25 Thread Varka Bhadram
On 07/25/2014 01:27 PM, Nicolin Chen wrote: Hi Varka, Thank you for the comments! On Fri, Jul 25, 2014 at 01:05:05PM +0530, Varka Bhadram wrote: On 07/25/2014 12:49 PM, Nicolin Chen wrote: (...) +static const struct platform_device_id fsl_asrc_devtype[] = { + { + .name

Re: [PATCH v4 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

2014-07-25 Thread Varka Bhadram
_ERR(asrc_priv->regmap); + } + + irq = platform_get_irq(pdev, 0); + if (irq < 0) { + dev_err(>dev, "no irq for node %s\n", np->full_name); + return irq; + } + + ret = devm_request_irq(>dev, irq, fsl_asrc_isr, 0, +

Re: [PATCH v3 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

2014-07-25 Thread Varka Bhadram
Hi Nicolin, On 07/25/2014 11:24 AM, Nicolin Chen wrote: Hi Varka, Regarding a point you suggested. On Fri, Jul 25, 2014 at 09:54:43AM +0530, Varka Bhadram wrote: On 07/25/2014 09:33 AM, Nicolin Chen wrote: (...) + +static const struct platform_device_id fsl_asrc_devtype

Re: [PATCH v3 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

2014-07-25 Thread Varka Bhadram
Hi Nicolin, On 07/25/2014 11:24 AM, Nicolin Chen wrote: Hi Varka, Regarding a point you suggested. On Fri, Jul 25, 2014 at 09:54:43AM +0530, Varka Bhadram wrote: On 07/25/2014 09:33 AM, Nicolin Chen wrote: (...) + +static const struct platform_device_id fsl_asrc_devtype

Re: [PATCH v4 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

2014-07-25 Thread Varka Bhadram
, np-full_name); + return irq; + } + + ret = devm_request_irq(pdev-dev, irq, fsl_asrc_isr, 0, + asrc_priv-name, asrc_priv); same... Thanks... -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH v4 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

2014-07-25 Thread Varka Bhadram
On 07/25/2014 01:27 PM, Nicolin Chen wrote: Hi Varka, Thank you for the comments! On Fri, Jul 25, 2014 at 01:05:05PM +0530, Varka Bhadram wrote: On 07/25/2014 12:49 PM, Nicolin Chen wrote: (...) +static const struct platform_device_id fsl_asrc_devtype[] = { + { + .name

Re: [PATCH v5 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

2014-07-25 Thread Varka Bhadram
/fsl_asrc.c create mode 100644 sound/soc/fsl/fsl_asrc.h create mode 100644 sound/soc/fsl/fsl_asrc_dma.c check patch warnings on this patch... -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH v3 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

2014-07-24 Thread Varka Bhadram
s to here... +static struct platform_driver fsl_asrc_driver = { + .probe = fsl_asrc_probe, + .driver = { + .name = "fsl-asrc", + .of_match_table = fsl_asrc_ids, + .pm = _asrc_pm, + }, +}; +module_platform_driver(fsl_asrc_driver); Thanks... -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v3 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

2014-07-24 Thread Varka Bhadram
= { + .probe = fsl_asrc_probe, + .driver = { + .name = fsl-asrc, + .of_match_table = fsl_asrc_ids, + .pm = fsl_asrc_pm, + }, +}; +module_platform_driver(fsl_asrc_driver); Thanks... -- Regards, Varka Bhadram. -- To unsubscribe from this list: send

Re: [PATCH v2] irqchip: add keystone irq controller ip driver

2014-07-23 Thread Varka Bhadram
On Wednesday 23 July 2014 11:31 PM, Grygorii Strashko wrote: Hi, On 07/23/2014 06:32 PM, Varka Bhadram wrote: On Wednesday 23 July 2014 08:10 PM, Grygorii Strashko wrote: On Keystone SOCs, DSP cores can send interrupts to ARM host using the IRQ controller IP. It provides 28 IRQ signals

Re: [PATCH v2] gpio: keystone: add dsp gpio controller driver

2014-07-23 Thread Varka Bhadram
trl_regs, bank->devctrl_offset, ); + if (ret < 0) + dev_dbg(bank->dev, "gpio read failed ret(%d)\n", ret); If this read fails what will happen...? we will get the debug message and return (val >> bit) & 1, But this val can be garbage or zero...?

Re: [PATCH v2] irqchip: add keystone irq controller ip driver

2014-07-23 Thread Varka Bhadram
THIS_MODULE, No need to update it. Its done by module_platform_driver().. + .of_match_table = of_match_ptr(keystone_irq_dt_ids), This driver is always populate through the dts file. So no need to use of_match_ptr -- -Varka Bhadram -- To unsubscribe from this list

Re: [PATCH v5 1/2] i2c: add DMA support for freescale i2c driver

2014-07-23 Thread Varka Bhadram
egards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH net-next 1/2] net: filter: split filter.c into two files

2014-07-23 Thread Varka Bhadram
tch only moves functions. If we are moving the code also its good to do cleanup. Run checkpatch.pl on this... -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH net-next 1/2] net: filter: split filter.c into two files

2014-07-23 Thread Varka Bhadram
only moves functions. If we are moving the code also its good to do cleanup. Run checkpatch.pl on this... -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v5 1/2] i2c: add DMA support for freescale i2c driver

2014-07-23 Thread Varka Bhadram
on fail... -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v2] irqchip: add keystone irq controller ip driver

2014-07-23 Thread Varka Bhadram
= keystone_irq, + .owner = THIS_MODULE, No need to update it. Its done by module_platform_driver().. + .of_match_table = of_match_ptr(keystone_irq_dt_ids), This driver is always populate through the dts file. So no need to use of_match_ptr -- -Varka Bhadram

Re: [PATCH v2] gpio: keystone: add dsp gpio controller driver

2014-07-23 Thread Varka Bhadram
...? + + return (val bit) 1; +} -- -Varka Bhadram -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v2] irqchip: add keystone irq controller ip driver

2014-07-23 Thread Varka Bhadram
On Wednesday 23 July 2014 11:31 PM, Grygorii Strashko wrote: Hi, On 07/23/2014 06:32 PM, Varka Bhadram wrote: On Wednesday 23 July 2014 08:10 PM, Grygorii Strashko wrote: On Keystone SOCs, DSP cores can send interrupts to ARM host using the IRQ controller IP. It provides 28 IRQ signals

Re: [PATCH v4 04/11] pwm: add DT bindings documentation for atmel-hlcdc-pwm driver

2014-07-22 Thread Varka Bhadram
The third cell encodes the PWM flags (the only supported flag is PWM_POLARITY_INVERTED) -- Regards, Varka Bhadram -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.

Re: [PATCH v4 02/11] mfd: add documentation for atmel-hlcdc DT bindings

2014-07-22 Thread Varka Bhadram
HLCDC device registers. - clock-names : the name of the 3 clocks requested by the HLCDC device. Should contain "periph_clk", "sys_clk" and "slow_clk". - clocks : should contain the 3 clocks requested by the HLCDC device. .. -- Regards, V

Re: [PATCH v2] iio: exynos-adc: add experimental touchscreen support

2014-07-22 Thread Varka Bhadram
ADC_S3C2410_MUX_TS); + + timeout = wait_for_completion_timeout + (>completion, EXYNOS_ADC_TIMEOUT); Should be properly aligned: wait_for_completion_timeout(>completion, EXYNOS_ADC_TIMEOUT); -- Regards, Varka Bhadram

Re: [PATCH v4 2/2] usb: gadget: Add xilinx usb2 device support

2014-07-22 Thread Varka Bhadram
+static struct platform_driver xudc_driver = { + .driver = { + .name = driver_name, + .owner = THIS_MODULE, We can drop the owner field update... It updated automatically by module_platform_driver(). Please run checkpatch.pl on this patch. You may get more war

Re: [PATCH 5/5] gpio: move gpio_ensure_requested() into legacy C file

2014-07-22 Thread Varka Bhadram
gpiod_dbg(desc, "%s: chip request fail, %d\n", + __func__, err); Dto.. (...) -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More maj

Re: [PATCH 5/5] gpio: move gpio_ensure_requested() into legacy C file

2014-07-22 Thread Varka Bhadram
, + __func__, err); Dto.. (...) -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org

Re: [PATCH v4 2/2] usb: gadget: Add xilinx usb2 device support

2014-07-22 Thread Varka Bhadram
= { + .name = driver_name, + .owner = THIS_MODULE, We can drop the owner field update... It updated automatically by module_platform_driver(). Please run checkpatch.pl on this patch. You may get more warnings and errors. -- Regards, Varka Bhadram. -- To unsubscribe from this list: send

Re: [PATCH v2] iio: exynos-adc: add experimental touchscreen support

2014-07-22 Thread Varka Bhadram
, ADC_S3C2410_MUX_TS); + + timeout = wait_for_completion_timeout + (info-completion, EXYNOS_ADC_TIMEOUT); Should be properly aligned: wait_for_completion_timeout(info-completion, EXYNOS_ADC_TIMEOUT); -- Regards, Varka Bhadram

Re: [PATCH v4 02/11] mfd: add documentation for atmel-hlcdc DT bindings

2014-07-22 Thread Varka Bhadram
. - clock-names : the name of the 3 clocks requested by the HLCDC device. Should contain periph_clk, sys_clk and slow_clk. - clocks : should contain the 3 clocks requested by the HLCDC device. .. -- Regards, Varka Bhadram -- To unsubscribe from this list: send the line

Re: [PATCH v4 04/11] pwm: add DT bindings documentation for atmel-hlcdc-pwm driver

2014-07-22 Thread Varka Bhadram
. The third cell encodes the PWM flags (the only supported flag is PWM_POLARITY_INVERTED) -- Regards, Varka Bhadram -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v10 1/8] phy: add a driver for the Berlin SATA PHY

2014-07-18 Thread Varka Bhadram
filed automatically update with module_platform_driver(). see:http://lxr.free-electrons.com/source/include/linux/platform_device.h#L190 -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.

Re: [PATCH 1/2] net: macb: Separate rx and tx ring init function

2014-07-18 Thread Varka Bhadram
On 07/18/2014 03:43 PM, Neil Armstrong wrote: Le 18/07/2014 12:10, Varka Bhadram a écrit : On 07/18/2014 03:22 PM, Neil Armstrong wrote: A single method is called to initialize the TX and RX rings. Separate the methods into distinct ones for MACB and GEM context. Signed-off-by: Neil Armstrong

Re: [PATCH] Hyperv: Trigger DHCP renew after host hibernation

2014-07-18 Thread Varka Bhadram
the carrier offline for 10 seconds +* to notify ifplugd daemon network change +*/ This should be networking comment style.. /* bla bla.. * bla */ -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubs

Re: [PATCH 1/2] net: macb: Separate rx and tx ring init function

2014-07-18 Thread Varka Bhadram
+ void(*mog_init_tx_rings)(struct macb *bp); int (*mog_rx)(struct macb *bp, int budget); }; -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 2/2] net: macb: Handle errors in RX path

2014-07-18 Thread Varka Bhadram
on this patch... -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH V3] netxen: fix ethtool rx_dropped information in ethtool get_ethtool_stats()

2014-07-18 Thread Varka Bhadram
On 07/18/2014 11:35 AM, Ethan Zhao wrote: On Fri, Jul 18, 2014 at 11:47 AM, Varka Bhadram wrote: On 07/18/2014 09:13 AM, Ethan Zhao wrote: netxen driver has implemented netxen_nic_get_ethtool_stats() interface, but it doesn't collect stats.rxdropped in driver, so we will get different

Re: [PATCH V3] netxen: fix ethtool rx_dropped information in ethtool get_ethtool_stats()

2014-07-18 Thread Varka Bhadram
On 07/18/2014 11:35 AM, Ethan Zhao wrote: On Fri, Jul 18, 2014 at 11:47 AM, Varka Bhadram varkabhad...@gmail.com wrote: On 07/18/2014 09:13 AM, Ethan Zhao wrote: netxen driver has implemented netxen_nic_get_ethtool_stats() interface, but it doesn't collect stats.rxdropped in driver, so we

Re: [PATCH 2/2] net: macb: Handle errors in RX path

2014-07-18 Thread Varka Bhadram
errors/warnings on this patch... -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org

Re: [PATCH 1/2] net: macb: Separate rx and tx ring init function

2014-07-18 Thread Varka Bhadram
); }; -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] Hyperv: Trigger DHCP renew after host hibernation

2014-07-18 Thread Varka Bhadram
the carrier offline for 10 seconds +* to notify ifplugd daemon network change +*/ This should be networking comment style.. /* bla bla.. * bla */ -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH 1/2] net: macb: Separate rx and tx ring init function

2014-07-18 Thread Varka Bhadram
On 07/18/2014 03:43 PM, Neil Armstrong wrote: Le 18/07/2014 12:10, Varka Bhadram a écrit : On 07/18/2014 03:22 PM, Neil Armstrong wrote: A single method is called to initialize the TX and RX rings. Separate the methods into distinct ones for MACB and GEM context. Signed-off-by: Neil Armstrong

Re: [PATCH v10 1/8] phy: add a driver for the Berlin SATA PHY

2014-07-18 Thread Varka Bhadram
with module_platform_driver(). see:http://lxr.free-electrons.com/source/include/linux/platform_device.h#L190 -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH V3] netxen: fix ethtool rx_dropped information in ethtool get_ethtool_stats()

2014-07-17 Thread Varka Bhadram
ault case, then it will be always in switch case ...? + } + data[index] = (netxen_nic_gstrings_stats[index].sizeof_stat == sizeof(u64)) ? *(u64 *) p : *(u32 *) p; -- Regards, Varka Bhadram. -- To unsubscribe from this list

Re: [PATCH V3] netxen: fix ethtool rx_dropped information in ethtool get_ethtool_stats()

2014-07-17 Thread Varka Bhadram
== sizeof(u64)) ? *(u64 *) p : *(u32 *) p; -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

Re: [PATCH net-next V2 3/3] virtio-net: rx busy polling support

2014-07-16 Thread Varka Bhadram
On Thursday 17 July 2014 10:13 AM, Jason Wang wrote: On 07/17/2014 11:27 AM, Varka Bhadram wrote: On Thursday 17 July 2014 08:25 AM, Jason Wang wrote: On 07/16/2014 04:38 PM, Varka Bhadram wrote: On 07/16/2014 11:51 AM, Jason Wang wrote: Add basic support for rx busy polling. Test was done

Re: [PATCH net-next V2 3/3] virtio-net: rx busy polling support

2014-07-16 Thread Varka Bhadram
On Thursday 17 July 2014 08:25 AM, Jason Wang wrote: On 07/16/2014 04:38 PM, Varka Bhadram wrote: On 07/16/2014 11:51 AM, Jason Wang wrote: Add basic support for rx busy polling. Test was done between a kvm guest and an external host. Two hosts were connected through 40gb mlx4 cards

Re: [PATCH v4] hwmon: pwm-fan: Add pwm-fan driver

2014-07-16 Thread Varka Bhadram
mode 100644 drivers/hwmon/pwm-fan.c This version addressed all of my comments.. Thanks :-) Reviewed-by: Varka Bhadram -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.or

Re: [PATCH v1] gpio: keystone: add dsp gpio controller driver

2014-07-16 Thread Varka Bhadram
obe, + .remove = keystone_gpio_remove, + .driver = { + .name = "keystone-dsp-gpio", + .owner = THIS_MODULE, We can drop owner field... :-) .It will update by module_platform_driver -- Regards, Varka Bhadram. -- To unsubscribe

Re: [PATCH v3 05/12] phy: add the Berlin USB PHY driver

2014-07-16 Thread Varka Bhadram
On 07/16/2014 03:17 PM, Antoine Ténart wrote: On Wed, Jul 16, 2014 at 03:03:14PM +0530, Varka Bhadram wrote: On 07/16/2014 02:55 PM, Antoine Ténart wrote: Hi Varka, On Wed, Jul 16, 2014 at 02:49:05PM +0530, Varka Bhadram wrote: On 07/16/2014 01:55 PM, Antoine Ténart wrote: +static const

Re: [PATCH v3 05/12] phy: add the Berlin USB PHY driver

2014-07-16 Thread Varka Bhadram
On 07/16/2014 02:55 PM, Antoine Ténart wrote: Hi Varka, On Wed, Jul 16, 2014 at 02:49:05PM +0530, Varka Bhadram wrote: On 07/16/2014 01:55 PM, Antoine Ténart wrote: +static const struct of_device_id phy_berlin_sata_of_match[] = { + { + .compatible = "marvell,berlin

Re: [PATCH v3 1/8] of: Add NVIDIA Tegra SATA controller binding

2014-07-16 Thread Varka Bhadram
-5v-supply : Defines the SATA 5V power regulator +- target-12v-supply : Defines the SATA 12V power regulator Same -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.or

Re: [PATCH v3 05/12] phy: add the Berlin USB PHY driver

2014-07-16 Thread Varka Bhadram
_ERR(phy_provider)) + return PTR_ERR(phy_provider); + + return 0; +} + +static struct platform_driver phy_berlin_usb_driver = { + .probe = phy_berlin_usb_probe, + .driver = { + .name = "phy-berlin-usb", + .owner = THI

Re: [PATCH net-next V2 3/3] virtio-net: rx busy polling support

2014-07-16 Thread Varka Bhadram
ev) if (netif_running(vi->dev)) { virtnet_napi_disable_all(vi); - for (i = 0; i < vi->max_queue_pairs; i++) + for (i = 0; i < vi->max_queue_pairs; i++) { + napi_hash_del(>rq[i].napi); netif_napi_del(>

Re: [PATCH net-next V2 3/3] virtio-net: rx busy polling support

2014-07-16 Thread Varka Bhadram
; i++) + for (i = 0; i vi-max_queue_pairs; i++) { + napi_hash_del(vi-rq[i].napi); netif_napi_del(vi-rq[i].napi); + } } remove_vq_common(vi); -- Regards, Varka Bhadram. -- To unsubscribe from this list: send

Re: [PATCH v3 05/12] phy: add the Berlin USB PHY driver

2014-07-16 Thread Varka Bhadram
); + + return 0; +} + +static struct platform_driver phy_berlin_usb_driver = { + .probe = phy_berlin_usb_probe, + .driver = { + .name = phy-berlin-usb, + .owner = THIS_MODULE, No need to update owner field. -- Regards, Varka Bhadram

Re: [PATCH v3 1/8] of: Add NVIDIA Tegra SATA controller binding

2014-07-16 Thread Varka Bhadram
-supply : Defines the SATA 5V power regulator +- target-12v-supply : Defines the SATA 12V power regulator Same -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH v3 05/12] phy: add the Berlin USB PHY driver

2014-07-16 Thread Varka Bhadram
On 07/16/2014 02:55 PM, Antoine Ténart wrote: Hi Varka, On Wed, Jul 16, 2014 at 02:49:05PM +0530, Varka Bhadram wrote: On 07/16/2014 01:55 PM, Antoine Ténart wrote: +static const struct of_device_id phy_berlin_sata_of_match[] = { + { + .compatible = marvell,berlin2-usb-phy

Re: [PATCH v3 05/12] phy: add the Berlin USB PHY driver

2014-07-16 Thread Varka Bhadram
On 07/16/2014 03:17 PM, Antoine Ténart wrote: On Wed, Jul 16, 2014 at 03:03:14PM +0530, Varka Bhadram wrote: On 07/16/2014 02:55 PM, Antoine Ténart wrote: Hi Varka, On Wed, Jul 16, 2014 at 02:49:05PM +0530, Varka Bhadram wrote: On 07/16/2014 01:55 PM, Antoine Ténart wrote: +static const

Re: [PATCH v1] gpio: keystone: add dsp gpio controller driver

2014-07-16 Thread Varka Bhadram
= { + .probe = keystone_gpio_probe, + .remove = keystone_gpio_remove, + .driver = { + .name = keystone-dsp-gpio, + .owner = THIS_MODULE, We can drop owner field... :-) .It will update by module_platform_driver -- Regards, Varka

Re: [PATCH v4] hwmon: pwm-fan: Add pwm-fan driver

2014-07-16 Thread Varka Bhadram
100644 drivers/hwmon/pwm-fan.c This version addressed all of my comments.. Thanks :-) Reviewed-by: Varka Bhadram varkabhad...@gmail.com -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org

Re: [PATCH net-next V2 3/3] virtio-net: rx busy polling support

2014-07-16 Thread Varka Bhadram
On Thursday 17 July 2014 08:25 AM, Jason Wang wrote: On 07/16/2014 04:38 PM, Varka Bhadram wrote: On 07/16/2014 11:51 AM, Jason Wang wrote: Add basic support for rx busy polling. Test was done between a kvm guest and an external host. Two hosts were connected through 40gb mlx4 cards

Re: [PATCH net-next V2 3/3] virtio-net: rx busy polling support

2014-07-16 Thread Varka Bhadram
On Thursday 17 July 2014 10:13 AM, Jason Wang wrote: On 07/17/2014 11:27 AM, Varka Bhadram wrote: On Thursday 17 July 2014 08:25 AM, Jason Wang wrote: On 07/16/2014 04:38 PM, Varka Bhadram wrote: On 07/16/2014 11:51 AM, Jason Wang wrote: Add basic support for rx busy polling. Test was done

Re: [PATCH v3] hwmon: pwm-fan: Add pwm-fan driver

2014-07-15 Thread Varka Bhadram
ike this... Required properties: - compatible: should be "pwm-fan" - pwms : The PWM that is used to control the PWM fan -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a m

Re: [PATCH v3] hwmon: pwm-fan: Add pwm-fan driver

2014-07-15 Thread Varka Bhadram
= _fan_pm, + .of_match_table = of_match_ptr(of_pwm_fan_match), This driver will always populate through the dts file. So no need of using 'of_match_ptr' here. + }, +}; + +module_platform_driver(pwm_fan_driver); + +MODULE_AUTHOR("Kamil Debski "); +MODU

Re: [RFC v5 1/2] backlight: add new tps611xx backlight driver

2014-07-15 Thread Varka Bhadram
xx_backlight_driver = { + .driver = { + .name = TPS611XX_NAME, + .owner = THIS_MODULE, No need to update .owner see:http://lxr.free-electrons.com/source/include/linux/platform_device.h#L190 -- Regards, Varka Bhadram. -- To unsubscribe from this list: send th

Re: [RFC v5 1/2] backlight: add new tps611xx backlight driver

2014-07-15 Thread Varka Bhadram
platform_driver tps611xx_backlight_driver = { + .driver = { + .name = TPS611XX_NAME, + .owner = THIS_MODULE, No need to update .owner see:http://lxr.free-electrons.com/source/include/linux/platform_device.h#L190 -- Regards, Varka Bhadram. -- To unsubscribe from this list

Re: [PATCH v3] hwmon: pwm-fan: Add pwm-fan driver

2014-07-15 Thread Varka Bhadram
. So no need of using 'of_match_ptr' here. + }, +}; + +module_platform_driver(pwm_fan_driver); + +MODULE_AUTHOR(Kamil Debski k.deb...@samsung.com); +MODULE_ALIAS(platform:pwm-fan); +MODULE_DESCRIPTION(PWM FAN driver); +MODULE_LICENSE(GPL); -- Regards, Varka Bhadram. -- To unsubscribe from

Re: [PATCH v3] hwmon: pwm-fan: Add pwm-fan driver

2014-07-15 Thread Varka Bhadram
this... Required properties: - compatible: should be pwm-fan - pwms : The PWM that is used to control the PWM fan -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org

Re: [PATCH v9 2/4] Documentation: dts: Add bindings for APM X-Gene SoC ethernet driver

2014-07-14 Thread Varka Bhadram
ndle = <>; + mdio { + compatible = "apm,xgene-mdio"; + #address-cells = <1>; + #size-cells = <0>; + menetphy: menetphy@3 { + compatible = "ethernet-phy-id001c.c915"; +

Re: [PATCHv6 2/2] dt/bindings: Add the DT binding documentation for endianness

2014-07-14 Thread Varka Bhadram
0x40031000 0x1000>; + ... +}; + +Scenario 4 : CPU in BE mode & device in LE mode. +dev: dev@40031000 { + compatible = "name"; + reg = <0x40031000 0x1000>; + ... + little-endian; +}; -- Regards, Varka Bhadram. --

Re: [PATCH 1/2] net: cadence: macb: add support for the WOL

2014-07-14 Thread Varka Bhadram
On 07/14/2014 04:19 PM, David Laight wrote: From: Varka Bhadram On 07/14/2014 02:32 PM, Jongsung Kim wrote: This patch enables the ethtool utility to control the WOL function of the PHY connected to the GEM/MACB. (if supported) ... +static int macb_set_wol(struct net_device *netdev, struct

Re: [PATCH 1/2] net: cadence: macb: add support for the WOL

2014-07-14 Thread Varka Bhadram
macb_set_wol, .get_link = ethtool_op_get_link, .get_ts_info= ethtool_op_get_ts_info, }; -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More m

Re: [PATCH net-next v2 3/6] ethernet: amd: dynamic debug fixes

2014-07-14 Thread Varka Bhadram
On 07/14/2014 01:36 PM, Joe Perches wrote: On Mon, 2014-07-14 at 11:55 +0530, varkabhad...@gmail.com wrote: From: Varka Bhadram [] diff --git a/drivers/net/ethernet/amd/amd8111e.c b/drivers/net/ethernet/amd/amd8111e.c [] @@ -501,8 +501,7 @@ static int amd8111e_restart(struct net_device

Re: [PATCH net-next v2 3/6] ethernet: amd: dynamic debug fixes

2014-07-14 Thread Varka Bhadram
On 07/14/2014 01:36 PM, Joe Perches wrote: On Mon, 2014-07-14 at 11:55 +0530, varkabhad...@gmail.com wrote: From: Varka Bhadram var...@cdac.in [] diff --git a/drivers/net/ethernet/amd/amd8111e.c b/drivers/net/ethernet/amd/amd8111e.c [] @@ -501,8 +501,7 @@ static int amd8111e_restart(struct

Re: [PATCH 1/2] net: cadence: macb: add support for the WOL

2014-07-14 Thread Varka Bhadram
= macb_set_wol, .get_link = ethtool_op_get_link, .get_ts_info= ethtool_op_get_ts_info, }; -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH 1/2] net: cadence: macb: add support for the WOL

2014-07-14 Thread Varka Bhadram
On 07/14/2014 04:19 PM, David Laight wrote: From: Varka Bhadram On 07/14/2014 02:32 PM, Jongsung Kim wrote: This patch enables the ethtool utility to control the WOL function of the PHY connected to the GEM/MACB. (if supported) ... +static int macb_set_wol(struct net_device *netdev, struct

Re: [PATCHv6 2/2] dt/bindings: Add the DT binding documentation for endianness

2014-07-14 Thread Varka Bhadram
: CPU in BE mode device in LE mode. +dev: dev@40031000 { + compatible = name; + reg = 0x40031000 0x1000; + ... + little-endian; +}; -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH v9 2/4] Documentation: dts: Add bindings for APM X-Gene SoC ethernet driver

2014-07-14 Thread Varka Bhadram
{ + compatible = ethernet-phy-id001c.c915; + reg = 0x3; + }; + + }; + }; + +/* Board-specific peripheral configurations */ +menet { +status = ok; +}; -- Regards, Varka Bhadram. -- To unsubscribe from this list: send

Re: [PATCH 2/2 V3] PCI: implement VFs assignment reference counter

2014-07-11 Thread Varka Bhadram
atomic_t VFs_assigned_cnt; /* counter of VFs assigned to VM */ struct pci_dev *dev;/* lowest numbered PF */ struct pci_dev *self; /* this PF */ struct mutex lock; /* lock for VF bus */ -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "uns

Re: [PATCH net-next 0/8] cleanup for AMD811E ethernet driver

2014-07-11 Thread Varka Bhadram
Hi David, On 07/11/2014 01:05 PM, varkabhad...@gmail.com wrote: From: Varka Bhadram This series cleanup for AMD811E ethernet driver Varka Bhadram (8): ethernet: amd: move amd111e_remove_one after probe ethernet: amd: use devm_ioremap() ethernet: amd: dynamic debug fixes ethernet

Re: [PATCH net-next 0/8] cleanup for AMD811E ethernet driver

2014-07-11 Thread Varka Bhadram
Hi David, On 07/11/2014 01:05 PM, varkabhad...@gmail.com wrote: From: Varka Bhadram var...@cdac.in This series cleanup for AMD811E ethernet driver Varka Bhadram (8): ethernet: amd: move amd111e_remove_one after probe ethernet: amd: use devm_ioremap() ethernet: amd: dynamic debug

Re: [PATCH 2/2 V3] PCI: implement VFs assignment reference counter

2014-07-11 Thread Varka Bhadram
*/ struct pci_dev *self; /* this PF */ struct mutex lock; /* lock for VF bus */ -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v7 15/33] net: xen-netback - set name assign type

2014-07-10 Thread Varka Bhadram
vif) ??? if (dev == NULL) { pr_warn("Could not allocate netdev for %s\n", name); return ERR_PTR(-ENOMEM); -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: [PATCH v7 15/33] net: xen-netback - set name assign type

2014-07-10 Thread Varka Bhadram
this suggestion In place sizeof(struct xenvif) -- sizeof(*vif) ??? if (dev == NULL) { pr_warn(Could not allocate netdev for %s\n, name); return ERR_PTR(-ENOMEM); -- Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-kernel

<    1   2   3   4   >