Re: [PATCH v2] tracing/tools: Remove unneeded semicolon

2021-03-08 Thread Viktor.Rosendahl
On Mon, 2021-03-08 at 02:24 +, Xu Wang wrote: > fix semicolon.cocci warning: > tools/tracing/latency/latency-collector.c:1021:2-3: Unneeded semicolon > > Signed-off-by: Xu Wang Reviewed-by: Viktor Rosendahl > --- > Changes since v2: > - Fix another instance of superfluous semicolon. > ---

Re: [PATCH] tracing/tools: Remove unneeded semicolon

2021-03-05 Thread Viktor.Rosendahl
On Fri, 2021-03-05 at 09:40 +, Xu Wang wrote: > fix semicolon.cocci warning: > tools/tracing/latency/latency-collector.c:1021:2-3: Unneeded semicolon > > Signed-off-by: Xu Wang > --- > tools/tracing/latency/latency-collector.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [EXTERNAL] [PATCH][next][V3] tracing/tools: fix a couple of spelling mistakes

2021-02-16 Thread Viktor.Rosendahl
This looks good to me. best regards, Viktor On Tue, 2021-02-16 at 15:30 +, Colin King wrote: > EXTERNAL SENDER - be CAUTIOUS, particularly with links and attachments. > EXTERNER Absender - Bitte VORSICHT beim Öffnen von Links und Anhängen. >

Re: [PATCH] tracing/tools: fix a couple of spelling mistakes

2021-02-16 Thread Viktor.Rosendahl
Hi, Thanks for finding these mistakes. On Tue, 2021-02-16 at 14:08 +, Colin King wrote: > printf( > -"Warning! Using trivial random nummer seed, since %s not available\n", > +"Warning! Using trivial random number seed, since %s not available\n", >

Re: [PATCH] Add the latency-collector to tools

2021-02-15 Thread Viktor.Rosendahl
On Fri, 2021-02-12 at 13:16 +0100, Viktor Rosendahl wrote: > > > However, for some reason I cannot reproduce the behavior now, allthough I use > exactly the same kernel. > > Because humans are more often at fault than computers, I cannot deny the > possibility that I would have misconfigured

Re: [PATCH] Add the latency-collector to tools

2021-02-12 Thread Viktor.Rosendahl
On Thu, 2021-02-11 at 14:56 -0500, Steven Rostedt wrote: > On Thu, 11 Feb 2021 17:17:42 +0100 > Viktor Rosendahl wrote: > > > It seems to work but I discovered during testing that it seems like newer > > kernels have a tendency to lose some latencies in longer bursts. I guess > > this > > is

Re: [PATCH 2/4] preemptirq_delay_test: Add the burst feature and a sysfs trigger

2019-01-23 Thread Viktor.Rosendahl
Hi Joel, On Tue, 2019-01-22 at 16:53 -0500, Joel Fernandes wrote: > Could you CC me on the other patches as well, next time? I am quite > interested and recently have worked on the latency tracer. > Sure, I will. > > > +MODULE_PARM_DESC(burst_size, "The size of a burst (default 1)"); > >