e-tree binding
> which is not available in uio_pdrv.
>
> That's why this uio_pdrv driver can be just removed.
>
The idea is sound and I like it - it removes a lot of duplicated code.
Reviewed-by: Vitalii Demianets
--
To unsubscribe from this list: send the line "unsubscribe linux-ker
is not available in uio_pdrv.
That's why this uio_pdrv driver can be just removed.
The idea is sound and I like it - it removes a lot of duplicated code.
Reviewed-by: Vitalii Demianets vi...@nppfactor.kiev.ua
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
waits for the completion of the irq handler;
- Change atomic bit-manipulation routines to their non-atomic counterparts
as we already are guarding the code by spinlock.
Signed-off-by: Vitalii Demianets
---
drivers/uio/uio_pdrv_genirq.c | 18 +-
1 file changed, 13 insertions(+), 5
waits for the completion of the irq handler;
- Change atomic bit-manipulation routines to their non-atomic counterparts
as we already are guarding the code by spinlock.
Signed-off-by: Vitalii Demianets vi...@nppfactor.kiev.ua
---
drivers/uio/uio_pdrv_genirq.c | 18 +-
1 file
On Saturday 15 December 2012 19:25:40 Hans J. Koch wrote:
> On Fri, Dec 14, 2012 at 11:33:50AM +0200, Vitalii Demianets wrote:
> > Hans, why do you want to put in this patch, which is dealing with
> > memory-freeing issues only, completely unrelated functional changes?
>
>
On Saturday 15 December 2012 19:25:40 Hans J. Koch wrote:
On Fri, Dec 14, 2012 at 11:33:50AM +0200, Vitalii Demianets wrote:
Hans, why do you want to put in this patch, which is dealing with
memory-freeing issues only, completely unrelated functional changes?
Because during review of your
On Thursday 13 December 2012 20:13:54 Hans J. Koch wrote:
> On Mon, Dec 10, 2012 at 11:44:45AM +0200, Vitalii Demianets wrote:
> > 1. uioinfo was kfreed based on the presence of pdev->dev.of_node, which
> > was obviously wrong and unrelated to the fact if uioinfo was alloca
On Thursday 13 December 2012 20:13:54 Hans J. Koch wrote:
On Mon, Dec 10, 2012 at 11:44:45AM +0200, Vitalii Demianets wrote:
1. uioinfo was kfreed based on the presence of pdev-dev.of_node, which
was obviously wrong and unrelated to the fact if uioinfo was allocated
statically
On Thursday 13 December 2012 19:34:00 Hans J. Koch wrote:
> On Thu, Dec 13, 2012 at 07:23:21PM +0200, Vitalii Demianets wrote:
> > On Thursday 13 December 2012 19:11:09 Hans J. Koch wrote:
> > > On Tue, Dec 11, 2012 at 12:47:35PM +0200, Vitalii Demianets wrote:
> > &
On Thursday 13 December 2012 19:11:09 Hans J. Koch wrote:
> On Tue, Dec 11, 2012 at 12:47:35PM +0200, Vitalii Demianets wrote:
> > Please, review the v3 of "Fix memory freeing issues" patch (first in the
> > series I posted yesterday) and ignore the second, as we haven'
On Thursday 13 December 2012 19:11:09 Hans J. Koch wrote:
On Tue, Dec 11, 2012 at 12:47:35PM +0200, Vitalii Demianets wrote:
Please, review the v3 of Fix memory freeing issues patch (first in the
series I posted yesterday) and ignore the second, as we haven't agreed
on it.
I can't find
On Thursday 13 December 2012 19:34:00 Hans J. Koch wrote:
On Thu, Dec 13, 2012 at 07:23:21PM +0200, Vitalii Demianets wrote:
On Thursday 13 December 2012 19:11:09 Hans J. Koch wrote:
On Tue, Dec 11, 2012 at 12:47:35PM +0200, Vitalii Demianets wrote:
Please, review the v3 of Fix memory
On Tuesday 11 December 2012 00:37:59 Hans J. Koch wrote:
> On Mon, Dec 10, 2012 at 12:24:04PM +0200, Vitalii Demianets wrote:
> > > > > Hi Vitalii,
> > > > > thanks a lot for analyzing the problem so thoroughly. It made me
> > > > > review uio_p
On Tuesday 11 December 2012 00:37:59 Hans J. Koch wrote:
On Mon, Dec 10, 2012 at 12:24:04PM +0200, Vitalii Demianets wrote:
Hi Vitalii,
thanks a lot for analyzing the problem so thoroughly. It made me
review uio_pdrv_genirq.c again, and I noticed several issues and
came
On Monday 10 December 2012 11:52:18 Hans J. Koch wrote:
> On Mon, Dec 10, 2012 at 11:03:59AM +0200, Vitalii Demianets wrote:
> > On Saturday 08 December 2012 01:47:21 Hans J. Koch wrote:
> > > On Fri, Dec 07, 2012 at 05:00:54PM +0200, Vitalii Demianets wrote:
> > > >
for the completion of the irq handler
- Change atomic bit-manipulation routines to their non-atomic counterparts as
we already are guarding the code by spinlock.
Signed-off-by: Vitalii Demianets
---
drivers/uio/uio_pdrv_genirq.c | 13 -
1 files changed, 8 insertions(+), 5 deletions
;
2. Fix: priv data was not freed in case platform_get_irq() failed. As it was
caused mainly by improper exit labels naming, labels were renamed too;
3. The case of uioinfo AND pdev->dev.of_node both NULL (not initialized
in platform data) was not treated properly.
Signed-off-by: Vitalii Dem
This patch series consists of two patches fixing different issues but in the
same file, so the second patch depends on the first:
1. Fix memory freeing issues
2. Fix concurrency issue on SMP systems.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a
On Saturday 08 December 2012 01:47:21 Hans J. Koch wrote:
> On Fri, Dec 07, 2012 at 05:00:54PM +0200, Vitalii Demianets wrote:
> > > On second thought, we can't call enable_irq()/disable_irq()
> > > unconditionally because of the potential disable counter
> > > (irq_d
On Saturday 08 December 2012 01:47:21 Hans J. Koch wrote:
On Fri, Dec 07, 2012 at 05:00:54PM +0200, Vitalii Demianets wrote:
On second thought, we can't call enable_irq()/disable_irq()
unconditionally because of the potential disable counter
(irq_desc-depth) disbalance. That's why we
This patch series consists of two patches fixing different issues but in the
same file, so the second patch depends on the first:
1. Fix memory freeing issues
2. Fix concurrency issue on SMP systems.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a
. Fix: priv data was not freed in case platform_get_irq() failed. As it was
caused mainly by improper exit labels naming, labels were renamed too;
3. The case of uioinfo AND pdev-dev.of_node both NULL (not initialized
in platform data) was not treated properly.
Signed-off-by: Vitalii Demianets vi
for the completion of the irq handler
- Change atomic bit-manipulation routines to their non-atomic counterparts as
we already are guarding the code by spinlock.
Signed-off-by: Vitalii Demianets vi...@nppfactor.kiev.ua
---
drivers/uio/uio_pdrv_genirq.c | 13 -
1 files changed, 8
On Monday 10 December 2012 11:52:18 Hans J. Koch wrote:
On Mon, Dec 10, 2012 at 11:03:59AM +0200, Vitalii Demianets wrote:
On Saturday 08 December 2012 01:47:21 Hans J. Koch wrote:
On Fri, Dec 07, 2012 at 05:00:54PM +0200, Vitalii Demianets wrote:
On second thought, we can't call
On Friday 07 December 2012 15:51:02 Vitalii Demianets wrote:
> On Friday 07 December 2012 11:41:45 Vitalii Demianets wrote:
> > On Friday 07 December 2012 00:15:59 Hans J. Koch wrote:
> > > On Thu, Dec 06, 2012 at 11:11:38AM +0200, Vitalii Demianets wrote:
> > > > O
On Friday 07 December 2012 11:41:45 Vitalii Demianets wrote:
> On Friday 07 December 2012 00:15:59 Hans J. Koch wrote:
> > On Thu, Dec 06, 2012 at 11:11:38AM +0200, Vitalii Demianets wrote:
> > > On Thursday 06 December 2012 04:41:01 Hans J. Koch wrote:
> > > &
On Friday 07 December 2012 00:15:59 Hans J. Koch wrote:
> On Thu, Dec 06, 2012 at 11:11:38AM +0200, Vitalii Demianets wrote:
> > On Thursday 06 December 2012 04:41:01 Hans J. Koch wrote:
> > > > @@ -63,7 +68,7 @@ static irqreturn_t uio_pdrv_genirq_handler(int irq,
> >
&g
On Friday 07 December 2012 00:15:59 Hans J. Koch wrote:
On Thu, Dec 06, 2012 at 11:11:38AM +0200, Vitalii Demianets wrote:
On Thursday 06 December 2012 04:41:01 Hans J. Koch wrote:
@@ -63,7 +68,7 @@ static irqreturn_t uio_pdrv_genirq_handler(int irq,
struct uio_info *dev_info
On Friday 07 December 2012 11:41:45 Vitalii Demianets wrote:
On Friday 07 December 2012 00:15:59 Hans J. Koch wrote:
On Thu, Dec 06, 2012 at 11:11:38AM +0200, Vitalii Demianets wrote:
On Thursday 06 December 2012 04:41:01 Hans J. Koch wrote:
@@ -63,7 +68,7 @@ static irqreturn_t
On Friday 07 December 2012 15:51:02 Vitalii Demianets wrote:
On Friday 07 December 2012 11:41:45 Vitalii Demianets wrote:
On Friday 07 December 2012 00:15:59 Hans J. Koch wrote:
On Thu, Dec 06, 2012 at 11:11:38AM +0200, Vitalii Demianets wrote:
On Thursday 06 December 2012 04:41:01 Hans
On Thursday 06 December 2012 04:41:01 Hans J. Koch wrote:
> > @@ -63,7 +68,7 @@ static irqreturn_t uio_pdrv_genirq_handler(int irq,
struct uio_info *dev_info)
> > * remember the state so we can allow user space to enable it later.
> > */
> >
> > - if (!test_and_set_bit(0, >flags))
>
On Thursday 06 December 2012 04:41:01 Hans J. Koch wrote:
@@ -63,7 +68,7 @@ static irqreturn_t uio_pdrv_genirq_handler(int irq,
struct uio_info *dev_info)
* remember the state so we can allow user space to enable it later.
*/
- if (!test_and_set_bit(0, priv-flags))
+
;
2. Fix: priv data was not freed in case platform_get_irq() failed. As it was
caused mainly by improper exit labels naming, labels were renamed too;
3. The case of uioinfo AND pdev->dev.of_node both NULL (not initialized
in platform data) was not treated properly.
Signed-off-by: Vitalii Dem
. Fix: priv data was not freed in case platform_get_irq() failed. As it was
caused mainly by improper exit labels naming, labels were renamed too;
3. The case of uioinfo AND pdev-dev.of_node both NULL (not initialized
in platform data) was not treated properly.
Signed-off-by: Vitalii Demianets vi
> On Friday 30 November 2012 23:39:06 Hans J. Koch wrote:
> > Thanks a lot for reporting and discussing that problem. I'll add a
> >
> > Reported-by: Vitalii Demianets
> >
> > if you have no objections.
>
> No objections. Thanks, Hans.
By the way, wha
On Friday 30 November 2012 23:39:06 Hans J. Koch wrote:
>
> Thanks a lot for reporting and discussing that problem. I'll add a
>
> Reported-by: Vitalii Demianets
>
> if you have no objections.
>
No objections. Thanks, Hans.
--
To unsubscribe from this list: send the li
On Friday 30 November 2012 23:39:06 Hans J. Koch wrote:
Thanks a lot for reporting and discussing that problem. I'll add a
Reported-by: Vitalii Demianets vi...@nppfactor.kiev.ua
if you have no objections.
No objections. Thanks, Hans.
--
To unsubscribe from this list: send the line
On Friday 30 November 2012 23:39:06 Hans J. Koch wrote:
Thanks a lot for reporting and discussing that problem. I'll add a
Reported-by: Vitalii Demianets vi...@nppfactor.kiev.ua
if you have no objections.
No objections. Thanks, Hans.
By the way, what do you think about my revised
On Friday 30 November 2012 01:58:22 Hans J. Koch wrote:
> On Thu, Nov 29, 2012 at 06:36:59PM +0200, Vitalii Demianets wrote:
> > > On Thursday 29 November 2012 18:05:27 Tux9 wrote:
> > > > Hans, I think there are something wrong in your patch, while
> > > > V
On Friday 30 November 2012 01:58:22 Hans J. Koch wrote:
On Thu, Nov 29, 2012 at 06:36:59PM +0200, Vitalii Demianets wrote:
On Thursday 29 November 2012 18:05:27 Tux9 wrote:
Hans, I think there are something wrong in your patch, while
Vitalii's is right. The variable ret is reused
> cases in more wordily manner.
>
Oops, disregard this. After looking at it more thoroughly I got your point.
You are right, ret is overridden at first iteration (mi == 0), so Hans's
approach does not work.
I must do more thinking before replying in a hurry.
> > On Wed, Nov 28,
>
> On Wed, Nov 28, 2012 at 10:05 PM, Hans J. Koch wrote:
> > On Wed, Nov 28, 2012 at 10:58:32AM +0200, Vitalii Demianets wrote:
> >> On Wednesday 28 November 2012 00:43:41 Hans J. Koch wrote:
> >> >
> >> > Thanks, good catch, but why don't you simply
;
2. Fix: priv data was not freed in case platform_get_irq() failed. As it was
caused mainly by improper exit labels naming, labels were renamed too;
3. The case of uioinfo AND pdev->dev.of_node both NULL (not initialized
in platform data) was not treated properly.
Signed-off-by: Vitalii Dem
. Fix: priv data was not freed in case platform_get_irq() failed. As it was
caused mainly by improper exit labels naming, labels were renamed too;
3. The case of uioinfo AND pdev-dev.of_node both NULL (not initialized
in platform data) was not treated properly.
Signed-off-by: Vitalii Demianets vi
:
On Wed, Nov 28, 2012 at 10:58:32AM +0200, Vitalii Demianets wrote:
On Wednesday 28 November 2012 00:43:41 Hans J. Koch wrote:
Thanks, good catch, but why don't you simply do this:
Just a matter of personal preference.
Your patch: 1 files changed, 12 insertions(+), 4 deletions
point.
You are right, ret is overridden at first iteration (mi == 0), so Hans's
approach does not work.
I must do more thinking before replying in a hurry.
On Wed, Nov 28, 2012 at 10:05 PM, Hans J. Koch h...@hansjkoch.de wrote:
On Wed, Nov 28, 2012 at 10:58:32AM +0200, Vitalii Demianets wrote
On Wednesday 28 November 2012 02:37:50 Hans J. Koch wrote:
>
> In other words, the case of uioinfo AND pdev->dev.of_node both being NULL
> is not handled properly and will have ugly results.
>
Moreover, the case of (uioinfo != NULL) && (pdev->dev.of_node != NULL) leads
to equally ugly results
.c
> +++ b/drivers/uio/uio.c
> @@ -263,7 +263,7 @@ static struct class uio_class = {
> */
> static int uio_dev_add_attributes(struct uio_device *idev)
> {
> - int ret;
> + int ret = -ENOMEM;
> int mi, pi;
> int map_found = 0;
> int portio_found = 0;
= {
*/
static int uio_dev_add_attributes(struct uio_device *idev)
{
- int ret;
+ int ret = -ENOMEM;
int mi, pi;
int map_found = 0;
int portio_found = 0;
--
With Best Regards,
Vitalii Demianets
--
To unsubscribe from this list: send the line unsubscribe linux
On Wednesday 28 November 2012 02:37:50 Hans J. Koch wrote:
In other words, the case of uioinfo AND pdev-dev.of_node both being NULL
is not handled properly and will have ugly results.
Moreover, the case of (uioinfo != NULL) (pdev-dev.of_node != NULL) leads
to equally ugly results too
Memory leak was caused by jumping to the wrong exit label. So, it is good time
to improve misleading label names too.
Signed-off-by: Vitalii Demianets
---
drivers/uio/uio_pdrv_genirq.c | 21 +++--
1 files changed, 11 insertions(+), 10 deletions(-)
diff --git a/drivers/uio
oesn't modern gcc warn about obvious use of uninitialized
variable. Is it some known regression in gcc?
--
With Best Regards,
Vitalii Demianets
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More m
Fix warning: 'ret' might be used uninitialized
Signed-off-by: Vitalii Demianets
---
drivers/uio/uio.c | 16
1 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c
index 5110f36..c33fd18 100644
--- a/drivers/uio/uio.c
+++ b
Fix warning: 'ret' might be used uninitialized
Signed-off-by: Vitalii Demianets vi...@nppfactor.kiev.ua
---
drivers/uio/uio.c | 16
1 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c
index 5110f36..c33fd18 100644
--- a/drivers
of uninitialized
variable. Is it some known regression in gcc?
--
With Best Regards,
Vitalii Demianets
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please
Memory leak was caused by jumping to the wrong exit label. So, it is good time
to improve misleading label names too.
Signed-off-by: Vitalii Demianets vi...@nppfactor.kiev.ua
---
drivers/uio/uio_pdrv_genirq.c | 21 +++--
1 files changed, 11 insertions(+), 10 deletions(-)
diff
56 matches
Mail list logo
