Re: [PATCH v2] zbud: allow up to PAGE_SIZE allocations

2015-09-23 Thread Vitaly Wool
On Wed, Sep 23, 2015 at 5:18 AM, Seth Jennings <sjenni...@variantweb.net> wrote: > On Tue, Sep 22, 2015 at 02:17:33PM +0200, Vitaly Wool wrote: >> Currently zbud is only capable of allocating not more than >> PAGE_SIZE - ZHDR_SIZE_ALIGNED - CHUNK_SIZE. This is okay as

Re: [PATCH v2] zbud: allow up to PAGE_SIZE allocations

2015-09-23 Thread Vitaly Wool
bud page lists * page->private to hold 'under_reclaim' flag page->private will also be used to indicate if this page contains a zbud header in the beginning or not ('headless' flag). Signed-off-by: Vitaly Wool <vitalyw...@gmail.com> ---

[PATCH v2] zbud: allow up to PAGE_SIZE allocations

2015-09-22 Thread Vitaly Wool
eclaim' flag page->private will also be used to indicate if this page contains a zbud header in the beginning or not ('headless' flag). Signed-off-by: Vitaly Wool --- mm/zbud.c | 194 +- 1 file changed, 128 insertions(+), 66 deletions

Re: [PATCH 1/2] zbud: allow PAGE_SIZE allocations

2015-09-22 Thread Vitaly Wool
Hi Dan, On Mon, Sep 21, 2015 at 6:17 PM, Dan Streetman wrote: > Please make sure to cc Seth also, he's the owner of zbud. Sure :) >> @@ -514,8 +552,17 @@ int zbud_reclaim_page(struct zbud_pool *pool, unsigned >> int retries) >> return -EINVAL; >> } >> for (i =

Re: [PATCH 1/2] zbud: allow PAGE_SIZE allocations

2015-09-22 Thread Vitaly Wool
Hi Dan, On Mon, Sep 21, 2015 at 6:17 PM, Dan Streetman wrote: > Please make sure to cc Seth also, he's the owner of zbud. Sure :) >> @@ -514,8 +552,17 @@ int zbud_reclaim_page(struct zbud_pool *pool, unsigned >> int retries) >> return -EINVAL; >> }

[PATCH v2] zbud: allow up to PAGE_SIZE allocations

2015-09-22 Thread Vitaly Wool
eclaim' flag page->private will also be used to indicate if this page contains a zbud header in the beginning or not ('headless' flag). Signed-off-by: Vitaly Wool <vitalyw...@gmail.com> --- mm/zbud.c | 194 +- 1 file changed, 128 in

Re: [PATCH 0/2] prepare zbud to be used by zram as underlying allocator

2015-09-21 Thread Vitaly Wool
Hello Minchan, > Sorry, because you wrote up "zram" in the title. > As I said earlier, we need several numbers to investigate. > > First of all, what is culprit of your latency? > It seems you are thinking about compaction. so compaction what? > Frequent scanning? lock collision? or frequent

Re: [PATCH 0/2] prepare zbud to be used by zram as underlying allocator

2015-09-21 Thread Vitaly Wool
Hello Minchan, > Sorry, because you wrote up "zram" in the title. > As I said earlier, we need several numbers to investigate. > > First of all, what is culprit of your latency? > It seems you are thinking about compaction. so compaction what? > Frequent scanning? lock collision? or frequent

Re: [PATCH 1/2] zbud: allow PAGE_SIZE allocations

2015-09-18 Thread Vitaly Wool
> I don't know how zsmalloc handles uncompressible PAGE_SIZE allocations, but > I wouldn't expect it to be any more clever than this? So why duplicate the > functionality in zswap and zbud? This could be handled e.g. at the zpool > level? Or maybe just in zram, as IIRC in zswap (frontswap) it's

Re: [PATCH 1/2] zbud: allow PAGE_SIZE allocations

2015-09-18 Thread Vitaly Wool
> I don't know how zsmalloc handles uncompressible PAGE_SIZE allocations, but > I wouldn't expect it to be any more clever than this? So why duplicate the > functionality in zswap and zbud? This could be handled e.g. at the zpool > level? Or maybe just in zram, as IIRC in zswap (frontswap) it's

Re: [PATCH 0/2] prepare zbud to be used by zram as underlying allocator

2015-09-17 Thread Vitaly Wool
On Thu, Sep 17, 2015 at 1:30 AM, Sergey Senozhatsky wrote: > > just a side note, > I'm afraid this is not how it works. numbers go first, to justify > the patch set. > These patches are extension/alignment patches, why would anyone need to justify that? But just to help you understand where I

Re: [PATCH 0/2] prepare zbud to be used by zram as underlying allocator

2015-09-17 Thread Vitaly Wool
On Thu, Sep 17, 2015 at 1:30 AM, Sergey Senozhatsky wrote: > > just a side note, > I'm afraid this is not how it works. numbers go first, to justify > the patch set. > These patches are extension/alignment patches, why would anyone need to justify that? But

[PATCH 2/2] zpool/zsmalloc/zbud: align on interfaces

2015-09-16 Thread Vitaly Wool
simplified 'compact' API/callbacks. Signed-off-by: Vitaly Wool --- drivers/block/zram/zram_drv.c | 4 ++-- include/linux/zpool.h | 14 ++ include/linux/zsmalloc.h | 8 ++-- mm/zbud.c | 12 mm/zpool.c| 21

[PATCH 1/2] zbud: allow PAGE_SIZE allocations

2015-09-16 Thread Vitaly Wool
. To be able to keep track of zbud pages in any case, struct page's lru pointer will be used for zbud page lists instead of the one that used to be part of the aforementioned internal structure. Signed-off-by: Vitaly Wool --- include/linux/page-flags.h | 3 ++ mm/zbud.c | 71

[PATCH 0/2] prepare zbud to be used by zram as underlying allocator

2015-09-16 Thread Vitaly Wool
. -- Vitaly Wool -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH 2/2] zpool/zsmalloc/zbud: align on interfaces

2015-09-16 Thread Vitaly Wool
simplified 'compact' API/callbacks. Signed-off-by: Vitaly Wool <vitalyw...@gmail.com> --- drivers/block/zram/zram_drv.c | 4 ++-- include/linux/zpool.h | 14 ++ include/linux/zsmalloc.h | 8 ++-- mm/zbud.c | 12 mm/z

[PATCH 0/2] prepare zbud to be used by zram as underlying allocator

2015-09-16 Thread Vitaly Wool
. -- Vitaly Wool <vitalyw...@gmail.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH 1/2] zbud: allow PAGE_SIZE allocations

2015-09-16 Thread Vitaly Wool
. To be able to keep track of zbud pages in any case, struct page's lru pointer will be used for zbud page lists instead of the one that used to be part of the aforementioned internal structure. Signed-off-by: Vitaly Wool <vitalyw...@gmail.com> --- include/linux/page-flags.h | 3 ++ mm/

Re: [PATCH 0/3] allow zram to use zbud as underlying allocator

2015-09-14 Thread Vitaly Wool
On Mon, Sep 14, 2015 at 4:01 PM, Vlastimil Babka wrote: > > On 09/14/2015 03:49 PM, Vitaly Wool wrote: >> >> While using ZRAM on a small RAM footprint devices, together with >> KSM, >> I ran into several occasions when moving pages from compressed swap back >>

[PATCH 3/3] zram: use common zpool interface

2015-09-14 Thread Vitaly Wool
Update zram driver to use common zpool API instead of calling zsmalloc functions directly. This patch also adds a parameter that allows for changing underlying compressor storage to zbud. Signed-off-by: Vitaly Wool --- drivers/block/zram/Kconfig| 3 ++- drivers/block/zram/zram_drv.c | 44

[PATCH 2/3] zpool/zsmalloc/zbud: align on interfaces

2015-09-14 Thread Vitaly Wool
As a preparation step for zram to be able to use common zpool API, there has to be some alignment done on it. This patch adds functions that correspond to zsmalloc-specific API to the common zpool API and takes care of the callbacks that have to be introduced, too. Signed-off-by: Vitaly Wool

[PATCH 1/3] zram: make max_zpage_size configurable

2015-09-14 Thread Vitaly Wool
configurable as a module parameter. Signed-off-by: Vitaly Wool --- drivers/block/zram/zram_drv.c | 13 + drivers/block/zram/zram_drv.h | 16 2 files changed, 13 insertions(+), 16 deletions(-) diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index

[PATCH 0/3] allow zram to use zbud as underlying allocator

2015-09-14 Thread Vitaly Wool
ism, lower latencies and lower fragmentation, so in the coming patches I tried to generalize what I've done to enable zbud for zram so far. -- Vitaly Wool -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org

[PATCH 0/3] allow zram to use zbud as underlying allocator

2015-09-14 Thread Vitaly Wool
ism, lower latencies and lower fragmentation, so in the coming patches I tried to generalize what I've done to enable zbud for zram so far. -- Vitaly Wool <vitalyw...@gmail.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

[PATCH 3/3] zram: use common zpool interface

2015-09-14 Thread Vitaly Wool
Update zram driver to use common zpool API instead of calling zsmalloc functions directly. This patch also adds a parameter that allows for changing underlying compressor storage to zbud. Signed-off-by: Vitaly Wool <vitalyw...@gmail.com> --- drivers/block/zram/Kconfig| 3 ++- drivers

Re: [PATCH 0/3] allow zram to use zbud as underlying allocator

2015-09-14 Thread Vitaly Wool
On Mon, Sep 14, 2015 at 4:01 PM, Vlastimil Babka <vba...@suse.cz> wrote: > > On 09/14/2015 03:49 PM, Vitaly Wool wrote: >> >> While using ZRAM on a small RAM footprint devices, together with >> KSM, >> I ran into several occasions when moving pages from comp

[PATCH 2/3] zpool/zsmalloc/zbud: align on interfaces

2015-09-14 Thread Vitaly Wool
As a preparation step for zram to be able to use common zpool API, there has to be some alignment done on it. This patch adds functions that correspond to zsmalloc-specific API to the common zpool API and takes care of the callbacks that have to be introduced, too. Signed-off-by: Vitaly Wool

[PATCH 1/3] zram: make max_zpage_size configurable

2015-09-14 Thread Vitaly Wool
configurable as a module parameter. Signed-off-by: Vitaly Wool <vitalyw...@gmail.com> --- drivers/block/zram/zram_drv.c | 13 + drivers/block/zram/zram_drv.h | 16 2 files changed, 13 insertions(+), 16 deletions(-) diff --git a/drivers/block/zram/zram_drv.c b/drivers

[PATCH/RFC] mm: do not regard CMA pages as free on watermark check

2015-09-09 Thread Vitaly Wool
also adds some primitive testing for the method implemented which has proven that it works as it should. Signed-off-by: Vitaly Wool --- include/linux/mmzone.h | 1 + mm/page_alloc.c| 56 +- mm/page_isolation.c| 2 +- 3 files changed

[PATCH/RFC] mm: do not regard CMA pages as free on watermark check

2015-09-09 Thread Vitaly Wool
also adds some primitive testing for the method implemented which has proven that it works as it should. Signed-off-by: Vitaly Wool <vitalyw...@gmail.com> --- include/linux/mmzone.h | 1 + mm/page_alloc.c| 56 +- mm/page_isolation.c

[RFC/PATCH] ksm: add vma size threshold parameter

2014-05-27 Thread Vitaly Wool
Hi, I have recently been poking around saving memory on low-RAM Android devices, basically following the Google KSM+ZRAM guidelines for KitKat and measuring the gain/performance. While getting quite some RAM savings indeed (in the range of 10k-20k pages) we noticed that kswapd used a lot of

[RFC/PATCH] ksm: add vma size threshold parameter

2014-05-27 Thread Vitaly Wool
Hi, I have recently been poking around saving memory on low-RAM Android devices, basically following the Google KSM+ZRAM guidelines for KitKat and measuring the gain/performance. While getting quite some RAM savings indeed (in the range of 10k-20k pages) we noticed that kswapd used a lot of

Re: [PATCH] 8250: make probing for TXEN bug a config option

2007-03-14 Thread Vitaly Wool
On 2/14/07, Andrew Morton <[EMAIL PROTECTED]> wrote: I think this should be a module option/boot parameter, not a config-time option. NM, the recent changes in 8250 driver eliminated the need for this patch :) Vitaly - To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [PATCH] 8250: make probing for TXEN bug a config option

2007-03-14 Thread Vitaly Wool
On 2/14/07, Andrew Morton [EMAIL PROTECTED] wrote: I think this should be a module option/boot parameter, not a config-time option. NM, the recent changes in 8250 driver eliminated the need for this patch :) Vitaly - To unsubscribe from this list: send the line unsubscribe linux-kernel in

Re: [PATCH] 8250: make probing for TXEN bug a config option

2007-02-14 Thread Vitaly Wool
On 2/14/07, Andrew Morton <[EMAIL PROTECTED]> wrote: On Wed, 14 Feb 2007 11:37:52 +0300 "Vitaly Wool" <[EMAIL PROTECTED]> wrote: > Hmm, why? I can't think of a platform where one 8250-compatible UART is > problematic and another isn't :) > Is it not possible t

Re: [PATCH] 8250: make probing for TXEN bug a config option

2007-02-14 Thread Vitaly Wool
On 2/14/07, Andrew Morton [EMAIL PROTECTED] wrote: On Wed, 14 Feb 2007 11:37:52 +0300 Vitaly Wool [EMAIL PROTECTED] wrote: Hmm, why? I can't think of a platform where one 8250-compatible UART is problematic and another isn't :) Is it not possible that the same kernel package can be installed

[PATCH] 8250: make probing for TXEN bug a config option

2006-12-26 Thread Vitaly Wool
-off-by: Vitaly Wool <[EMAIL PROTECTED]> diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c index 51f3c73..cf3eb31 100644 --- a/drivers/serial/8250.c +++ b/drivers/serial/8250.c @@ -1645,6 +1645,7 @@ static int serial8250_startup(struct uar serial8250_set_mctrl(>port, up-&g

[PATCH] 8250: make probing for TXEN bug a config option

2006-12-26 Thread Vitaly Wool
-off-by: Vitaly Wool [EMAIL PROTECTED] diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c index 51f3c73..cf3eb31 100644 --- a/drivers/serial/8250.c +++ b/drivers/serial/8250.c @@ -1645,6 +1645,7 @@ static int serial8250_startup(struct uar serial8250_set_mctrl(up-port, up-port.mctrl

[PATCH -mm] pnx8xxx-uart: irq and ktermios fixes

2006-12-21 Thread Vitaly Wool
Hello Andrew, this patch adds irq 2.6.19 changes and 2.6.20 ktermios changes to pnx8xxx-uart.c (which was added to -mm tree with pnx8550-uart-driver.patch). drivers/serial/pnx8xxx_uart.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) Signed-off-by: Vitaly Wool <[EM

[PATCH -mm] pnx8xxx-uart: irq and ktermios fixes

2006-12-21 Thread Vitaly Wool
Hello Andrew, this patch adds irq 2.6.19 changes and 2.6.20 ktermios changes to pnx8xxx-uart.c (which was added to -mm tree with pnx8550-uart-driver.patch). drivers/serial/pnx8xxx_uart.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) Signed-off-by: Vitaly Wool [EMAIL

[PATCH] smc911x: fix netpoll compilation faliure

2006-12-15 Thread Vitaly Wool
Hello folks, the trivial patch below fixes the compilation failure for smc911x.c when NET_POLL_CONTROLLER is set. drivers/net/smc911x.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Signed-off-by: Vitaly Wool <[EMAIL PROTECTED]> diff --git a/drivers/net/smc911x.c b/drive

[PATCH] smc911x: fix netpoll compilation faliure

2006-12-15 Thread Vitaly Wool
Hello folks, the trivial patch below fixes the compilation failure for smc911x.c when NET_POLL_CONTROLLER is set. drivers/net/smc911x.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Signed-off-by: Vitaly Wool [EMAIL PROTECTED] diff --git a/drivers/net/smc911x.c b/drivers/net

[PATCH][resend] PNX8550 UART driver

2006-12-08 Thread Vitaly Wool
been accepted yet due to merge window miss at that moment. drivers/serial/Kconfig| 16 drivers/serial/Makefile |1 drivers/serial/pnx8xxx_uart.c | 853 ++ 3 files changed, 870 insertions(+) Signed-off-by: Vitaly Wool <[EM

[PATCH][resend] PNX8550 UART driver

2006-12-08 Thread Vitaly Wool
been accepted yet due to merge window miss at that moment. drivers/serial/Kconfig| 16 drivers/serial/Makefile |1 drivers/serial/pnx8xxx_uart.c | 853 ++ 3 files changed, 870 insertions(+) Signed-off-by: Vitaly Wool [EMAIL

[PATCH][resend] fix PNX8550 serial breakage

2006-12-07 Thread Vitaly Wool
+ 3 files changed, 82 insertions(+), 82 deletions(-) Signed-off-by: Vitaly Wool <[EMAIL PROTECTED]> Index: linux-2.6/include/linux/serial_ip3106.h === --- linux-2.6.orig/include/linux/serial_ip

[PATCH][resend] fix PNX8550 serial breakage

2006-12-07 Thread Vitaly Wool
+ 3 files changed, 82 insertions(+), 82 deletions(-) Signed-off-by: Vitaly Wool [EMAIL PROTECTED] Index: linux-2.6/include/linux/serial_ip3106.h === --- linux-2.6.orig/include/linux/serial_ip3106.h

Re: [PATCH] fix "prev->state: 2 != TASK_RUNNING??" problem on SD/MMC card removal

2006-11-27 Thread Vitaly Wool
On 11/26/06, Pierre Ossman <[EMAIL PROTECTED]> wrote: Hmm... I can't find any such requirement in HEAD, or 2.6.18. What kernel are you running? 2.6.18 + -rt patches by Ingo. Vitaly - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL

Re: [PATCH] fix prev-state: 2 != TASK_RUNNING?? problem on SD/MMC card removal

2006-11-27 Thread Vitaly Wool
On 11/26/06, Pierre Ossman [EMAIL PROTECTED] wrote: Hmm... I can't find any such requirement in HEAD, or 2.6.18. What kernel are you running? 2.6.18 + -rt patches by Ingo. Vitaly - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL

Re: [PATCH] custom PM support for 8250

2005-09-06 Thread Vitaly Wool
the first patch I've sent for 8250 in place first? I'll continue to work on 8250 PM/platform_serial_data changes then. Vitaly Grigory Tolstolytkin wrote: Hi Russel, I tried the patch provided by Vitaly Wool. And it works correctly. And now I'm successful with the PM support for my own serial8250

Re: [PATCH] custom PM support for 8250

2005-09-06 Thread Vitaly Wool
the first patch I've sent for 8250 in place first? I'll continue to work on 8250 PM/platform_serial_data changes then. Vitaly Grigory Tolstolytkin wrote: Hi Russel, I tried the patch provided by Vitaly Wool. And it works correctly. And now I'm successful with the PM support for my own serial8250

[PATCH] custom PM support for 8250 serial (updated)

2005-08-31 Thread Vitaly Wool
such facility. drivers/serial/8250.c | 77 include/linux/serial_8250.h |6 +++ 2 files changed, 69 insertions(+), 14 deletions(-) Signed-off-by: Vitaly Wool <[EMAIL PROTECTED]> Index: linux-2.6.13/drivers/serial/

Re: [PATCH] custom PM support for 8250

2005-08-31 Thread Vitaly Wool
you suggest and work it out to the new patch. ;) Best regards, Vitaly Russell King wrote: On Wed, Aug 31, 2005 at 03:10:09PM +0400, Vitaly Wool wrote: please find the patch that allows passing the pointer to custom power management routine (via platform_device) to 8250 serial driver. Ple

Re: [PATCH] custom PM support for 8250

2005-08-31 Thread Vitaly Wool
Sorry for format. Attached is the better one :) Vitaly Wool wrote: Greetings, please find the patch that allows passing the pointer to custom power management routine (via platform_device) to 8250 serial driver. Please note that the interface to the outer world (i. e. exported functions

[PATCH] custom PM support for 8250

2005-08-31 Thread Vitaly Wool
(+), 7 deletions(-) Signed-off-by: Vitaly Wool <[EMAIL PROTECTED]> Index: linux-2.6.10/drivers/serial/8250.c === --- linux-2.6.10.orig/drivers/serial/8250.c +++ linux-2.6.10/drivers/serial/8250.c @@ -2360,6 +

Re: 8250 serial driver and PM

2005-08-31 Thread Vitaly Wool
Hi Grigory, it's unclear from your letter where you take pnx4008_uart_pm from. Can you please elaborate? What I would think of if I were you is adding a field 'pm' to struct plat_serial8250_port which is filled in in the architecture-specific part and setting up->pm accrodingly. I'll send a

Re: 8250 serial driver and PM

2005-08-31 Thread Vitaly Wool
Hi Grigory, it's unclear from your letter where you take pnx4008_uart_pm from. Can you please elaborate? What I would think of if I were you is adding a field 'pm' to struct plat_serial8250_port which is filled in in the architecture-specific part and setting up-pm accrodingly. I'll send a

[PATCH] custom PM support for 8250

2005-08-31 Thread Vitaly Wool
(+), 7 deletions(-) Signed-off-by: Vitaly Wool [EMAIL PROTECTED] Index: linux-2.6.10/drivers/serial/8250.c === --- linux-2.6.10.orig/drivers/serial/8250.c +++ linux-2.6.10/drivers/serial/8250.c @@ -2360,6 +2360,8 @@ uart_resume_port

Re: [PATCH] custom PM support for 8250

2005-08-31 Thread Vitaly Wool
Sorry for format. Attached is the better one :) Vitaly Wool wrote: Greetings, please find the patch that allows passing the pointer to custom power management routine (via platform_device) to 8250 serial driver. Please note that the interface to the outer world (i. e. exported functions

Re: [PATCH] custom PM support for 8250

2005-08-31 Thread Vitaly Wool
suggest and work it out to the new patch. ;) Best regards, Vitaly Russell King wrote: On Wed, Aug 31, 2005 at 03:10:09PM +0400, Vitaly Wool wrote: please find the patch that allows passing the pointer to custom power management routine (via platform_device) to 8250 serial driver. Please

[PATCH] custom PM support for 8250 serial (updated)

2005-08-31 Thread Vitaly Wool
such facility. drivers/serial/8250.c | 77 include/linux/serial_8250.h |6 +++ 2 files changed, 69 insertions(+), 14 deletions(-) Signed-off-by: Vitaly Wool [EMAIL PROTECTED] Index: linux-2.6.13/drivers/serial/8250.c

<    1   2   3   4   5