Re: [PATCH 2/2] crypto: s5p-sss: Add HASH support for Exynos

kernel.org> > Signed-off-by: Kamil Konieczny <k.koniec...@partner.samsung.com> > --- I won't linger this time :) Please feel free to add Acked-by: Vladimir Zapolskiy <v...@mleia.com> -- With best wishes, Vladimir

Re: [PATCH 2/2] crypto: s5p-sss: Add HASH support for Exynos

; Signed-off-by: Kamil Konieczny > --- I won't linger this time :) Please feel free to add Acked-by: Vladimir Zapolskiy -- With best wishes, Vladimir

Re: [PATCH v7 2/2] crypto: s5p-sss: Add HASH support for Exynos

ly almost all of your remarks, > see answers below. > > On 22.10.2017 12:18, Vladimir Zapolskiy wrote: >> Hi Kamil, >> >> thank you for updates, I have just a few more comments. >> [snip] >>> +/** >>> + * s5p_hash_import - import hash state

Re: [PATCH v7 2/2] crypto: s5p-sss: Add HASH support for Exynos

ly almost all of your remarks, > see answers below. > > On 22.10.2017 12:18, Vladimir Zapolskiy wrote: >> Hi Kamil, >> >> thank you for updates, I have just a few more comments. >> [snip] >>> +/** >>> + * s5p_hash_import - import hash state

Re: [PATCH v7 1/2] crypto: s5p-sss: change spaces into tabs in defines

Hi Kamil, On 10/24/2017 01:19 PM, Kamil Konieczny wrote: > Hi Vladimir, > > Thank you for review. > > On 22.10.2017 12:18, Vladimir Zapolskiy wrote: >> Hi Kamil, >> >> On 10/17/2017 02:28 PM, Kamil Konieczny wrote: >>> change spaces into tabs in

Re: [PATCH v7 1/2] crypto: s5p-sss: change spaces into tabs in defines

Hi Kamil, On 10/24/2017 01:19 PM, Kamil Konieczny wrote: > Hi Vladimir, > > Thank you for review. > > On 22.10.2017 12:18, Vladimir Zapolskiy wrote: >> Hi Kamil, >> >> On 10/17/2017 02:28 PM, Kamil Konieczny wrote: >>> change spaces into tabs in

Re: [PATCH v7 1/2] crypto: s5p-sss: change spaces into tabs in defines

Hi Kamil, On 10/17/2017 02:28 PM, Kamil Konieczny wrote: > change spaces into tabs in defines Here a grammatically correct sentence in English is welcome. > > Signed-off-by: Kamil Konieczny <k.koniec...@partner.samsung.com> > --- Please feel free to add a tag Acked-by: Vla

Re: [PATCH v7 1/2] crypto: s5p-sss: change spaces into tabs in defines

Hi Kamil, On 10/17/2017 02:28 PM, Kamil Konieczny wrote: > change spaces into tabs in defines Here a grammatically correct sentence in English is welcome. > > Signed-off-by: Kamil Konieczny > --- Please feel free to add a tag Acked-by: Vladimir Zapolskiy -- With best wishes, Vladimir

Re: [PATCH v7 2/2] crypto: s5p-sss: Add HASH support for Exynos

Hi Kamil, thank you for updates, I have just a few more comments. On 10/17/2017 02:28 PM, Kamil Konieczny wrote: > Add support for MD5, SHA1, SHA256 hash algorithms for Exynos HW. > It uses the crypto framework asynchronous hash api. > It is based on omap-sham.c driver. > S5P has some HW

Re: [PATCH v7 2/2] crypto: s5p-sss: Add HASH support for Exynos

Hi Kamil, thank you for updates, I have just a few more comments. On 10/17/2017 02:28 PM, Kamil Konieczny wrote: > Add support for MD5, SHA1, SHA256 hash algorithms for Exynos HW. > It uses the crypto framework asynchronous hash api. > It is based on omap-sham.c driver. > S5P has some HW

Re: [PATCH v5] crypto: s5p-sss: Add HASH support for Exynos

Hello Kamil, thank you for the change, please find below a number of minor review comments. On 10/09/2017 02:12 PM, Kamil Konieczny wrote: > Add support for MD5, SHA1, SHA256 hash algorithms for Exynos HW. > It uses the crypto framework asynchronous hash api. > It is based on omap-sham.c driver.

Re: [PATCH v5] crypto: s5p-sss: Add HASH support for Exynos

Hello Kamil, thank you for the change, please find below a number of minor review comments. On 10/09/2017 02:12 PM, Kamil Konieczny wrote: > Add support for MD5, SHA1, SHA256 hash algorithms for Exynos HW. > It uses the crypto framework asynchronous hash api. > It is based on omap-sham.c driver.

Re: [PATCH v3 2/2] ARM: dts: tegra20: Add video decoder node

t may lead to conflicts for IRAM resource between users. My proposal is to add a valid device tree node to describe an IRAM region firstly, then reserve a subregion in it by using a new "iram" property. 8< From: Vladimir Zapolskiy <v...@mleia.com> Date: Thu, 12 Oct 2017

Re: [PATCH v3 2/2] ARM: dts: tegra20: Add video decoder node

r IRAM resource between users. My proposal is to add a valid device tree node to describe an IRAM region firstly, then reserve a subregion in it by using a new "iram" property. 8< From: Vladimir Zapolskiy Date: Thu, 12 Oct 2017 10:25:45 +0300 Subject: [PATCH] ARM: tegra:

Re: [PATCH v7 3/3] clk: stm32h7: Add stm32h743 clock driver

Hi Gabriel, On 07/20/2017 11:31 AM, Gabriel FERNANDEZ wrote: > Hi Vladimir, > > > On 07/19/2017 11:20 PM, Vladimir Zapolskiy wrote: >> Hello Gabriel, >> >> On 07/19/2017 05:25 PM, gabriel.fernan...@st.com wrote: >>> From: Gabriel Fernandez <gabriel.fe

Re: [PATCH v7 3/3] clk: stm32h7: Add stm32h743 clock driver

Hi Gabriel, On 07/20/2017 11:31 AM, Gabriel FERNANDEZ wrote: > Hi Vladimir, > > > On 07/19/2017 11:20 PM, Vladimir Zapolskiy wrote: >> Hello Gabriel, >> >> On 07/19/2017 05:25 PM, gabriel.fernan...@st.com wrote: >>> From: Gabriel Fernandez >>> &g

Re: [PATCH v7 3/3] clk: stm32h7: Add stm32h743 clock driver

Hello Gabriel, On 07/19/2017 05:25 PM, gabriel.fernan...@st.com wrote: > From: Gabriel Fernandez > > This patch enables clocks for STM32H743 boards. > > Signed-off-by: Gabriel Fernandez > > for MFD changes: > Acked-by: Lee Jones

Re: [PATCH v7 3/3] clk: stm32h7: Add stm32h743 clock driver

Hello Gabriel, On 07/19/2017 05:25 PM, gabriel.fernan...@st.com wrote: > From: Gabriel Fernandez > > This patch enables clocks for STM32H743 boards. > > Signed-off-by: Gabriel Fernandez > > for MFD changes: > Acked-by: Lee Jones > > for DT-Bindings > Acked-by: Rob Herring > --- >

Re: [PATCH v7 1/3] clk: nxp: clk-lpc32xx: rename clk_gate_is_enabled()

LPC32xx clock driver. > We changed all gate op with 'lpc32xx_' prefix: > lpc32xx_clk_gate_enable(), > lpc32xx_clk_gate_disable(), > lpc32xx_clk_gate_is_enabled(). > > Signed-off-by: Gabriel Fernandez <gabriel.fernan...@st.com> Acked-by: Vladimir Zapolskiy <v...@mleia.com> -- With best wishes, Vladimir

Re: [PATCH v7 1/3] clk: nxp: clk-lpc32xx: rename clk_gate_is_enabled()

hanged all gate op with 'lpc32xx_' prefix: > lpc32xx_clk_gate_enable(), > lpc32xx_clk_gate_disable(), > lpc32xx_clk_gate_is_enabled(). > > Signed-off-by: Gabriel Fernandez Acked-by: Vladimir Zapolskiy -- With best wishes, Vladimir

Re: [PATCH v7 2/3] clk: gate: expose clk_gate_ops::is_enabled

On 07/19/2017 05:25 PM, gabriel.fernan...@st.com wrote: > From: Gabriel Fernandez > > This patch exposes clk_gate_ops::is_enabled as functions > that can be directly called and assigned in places like this so > we don't need wrapper functions that do nothing besides

Re: [PATCH v7 2/3] clk: gate: expose clk_gate_ops::is_enabled

On 07/19/2017 05:25 PM, gabriel.fernan...@st.com wrote: > From: Gabriel Fernandez > > This patch exposes clk_gate_ops::is_enabled as functions > that can be directly called and assigned in places like this so > we don't need wrapper functions that do nothing besides forward > the call. > >

Re: [PATCH] irqchip: Convert to using %pOF instead of full_name

; Cc: Florian Fainelli <f.faine...@gmail.com> > Cc: Ray Jui <r...@broadcom.com> > Cc: Scott Branden <sbran...@broadcom.com> > Cc: bcm-kernel-feedback-l...@broadcom.com > Cc: Baruch Siach <bar...@tkos.co.il> > Cc: Vladimir Zapolskiy <v...@mleia.com> > Cc:

Re: [PATCH] irqchip: Convert to using %pOF instead of full_name

ixner > Cc: Jason Cooper > Cc: Marc Zyngier > Cc: Lee Jones > Cc: Eric Anholt > Cc: Stefan Wahren > Cc: Florian Fainelli > Cc: Ray Jui > Cc: Scott Branden > Cc: bcm-kernel-feedback-l...@broadcom.com > Cc: Baruch Siach > Cc: Vladimir Zapolskiy > Cc: Sylvain

Re: [PATCH v6 2/3] clk: gate: expose clk_gate_ops::is_enabled

On 07/19/2017 01:52 AM, Stephen Boyd wrote: > On 07/18, Vladimir Zapolskiy wrote: >> On 07/18/2017 10:53 AM, gabriel.fernan...@st.com wrote: >>> From: Gabriel Fernandez <gabriel.fernan...@st.com> >>> } >>> +EXPORT_SYMBOL_GPL(clk_gate_is_enabled); &g

Re: [PATCH v6 2/3] clk: gate: expose clk_gate_ops::is_enabled

On 07/19/2017 01:52 AM, Stephen Boyd wrote: > On 07/18, Vladimir Zapolskiy wrote: >> On 07/18/2017 10:53 AM, gabriel.fernan...@st.com wrote: >>> From: Gabriel Fernandez >>> } >>> +EXPORT_SYMBOL_GPL(clk_gate_is_enabled); >>> >>>

Re: [PATCH v6 3/3] clk: stm32h7: Add stm32h743 clock driver

Hello Gabriel, On 07/18/2017 10:53 AM, gabriel.fernan...@st.com wrote: > From: Gabriel Fernandez > > This patch enables clocks for STM32H743 boards. > > Signed-off-by: Gabriel Fernandez > > for MFD changes: > Acked-by: Lee Jones

Re: [PATCH v6 3/3] clk: stm32h7: Add stm32h743 clock driver

Hello Gabriel, On 07/18/2017 10:53 AM, gabriel.fernan...@st.com wrote: > From: Gabriel Fernandez > > This patch enables clocks for STM32H743 boards. > > Signed-off-by: Gabriel Fernandez > > for MFD changes: > Acked-by: Lee Jones > > for DT-Bindings > Acked-by: Rob Herring > --- >

Re: [PATCH v6 2/3] clk: gate: expose clk_gate_ops::is_enabled

On 07/18/2017 10:53 AM, gabriel.fernan...@st.com wrote: > From: Gabriel Fernandez > > This patch exposes clk_gate_ops::is_enabled as functions > that can be directly called and assigned in places like this so > we don't need wrapper functions that do nothing besides

Re: [PATCH v6 2/3] clk: gate: expose clk_gate_ops::is_enabled

On 07/18/2017 10:53 AM, gabriel.fernan...@st.com wrote: > From: Gabriel Fernandez > > This patch exposes clk_gate_ops::is_enabled as functions > that can be directly called and assigned in places like this so > we don't need wrapper functions that do nothing besides forward > the call. > >

Re: [PATCH v6 1/3] clk: nxp: clk-lpc32xx: rename clk_gate_is_enabled()

Hello Gabriel, On 07/18/2017 10:53 AM, gabriel.fernan...@st.com wrote: > From: Gabriel Fernandez > > We need to export clk_gate_is_enabled() from clk framework, then first of all let's clarify if you really need to export clk_gate_is_enabled() from the CCF. > to

Re: [PATCH v6 1/3] clk: nxp: clk-lpc32xx: rename clk_gate_is_enabled()

Hello Gabriel, On 07/18/2017 10:53 AM, gabriel.fernan...@st.com wrote: > From: Gabriel Fernandez > > We need to export clk_gate_is_enabled() from clk framework, then first of all let's clarify if you really need to export clk_gate_is_enabled() from the CCF. > to avoid compilation issue we

Re: [PATCH v2] pata_imx: print error message on platform_get_irq failure

Hello Gustavo, On 07/01/2017 12:30 AM, Gustavo A. R. Silva wrote: > Print error message on platform_get_irq failure before return. > > Signed-off-by: Gustavo A. R. Silva > --- > Changes in v2: > Print the return value of platform_get_irq on failure. > >

Re: [PATCH v2] pata_imx: print error message on platform_get_irq failure

Hello Gustavo, On 07/01/2017 12:30 AM, Gustavo A. R. Silva wrote: > Print error message on platform_get_irq failure before return. > > Signed-off-by: Gustavo A. R. Silva > --- > Changes in v2: > Print the return value of platform_get_irq on failure. > > drivers/ata/pata_imx.c | 5 +++-- > 1

Re: [PATCH] dmaengine: idma64: print error message on platform_get_irq failure

Hello Gustavo, On 06/30/2017 10:34 AM, Gustavo A. R. Silva wrote: > Print error message on platform_get_irq failure before return. > > Signed-off-by: Gustavo A. R. Silva > --- > drivers/dma/idma64.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff

Re: [PATCH] dmaengine: idma64: print error message on platform_get_irq failure

Hello Gustavo, On 06/30/2017 10:34 AM, Gustavo A. R. Silva wrote: > Print error message on platform_get_irq failure before return. > > Signed-off-by: Gustavo A. R. Silva > --- > drivers/dma/idma64.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git

Re: [PATCH v1 1/1] gpio: of: provide option generic property for initial line states

Hi Oleksij, On 06/15/2017 08:56 AM, Oleksij Rempel wrote: > Hi Vladimir, > > On Sun, Jun 11, 2017 at 10:57:18PM +0300, Vladimir Zapolskiy wrote: >> Hi Oleksij, >> >> On 06/11/2017 09:19 AM, Oleksij Rempel wrote: >>> Hi Rob, >>> >>> On Fr

Re: [PATCH v1 1/1] gpio: of: provide option generic property for initial line states

Hi Oleksij, On 06/15/2017 08:56 AM, Oleksij Rempel wrote: > Hi Vladimir, > > On Sun, Jun 11, 2017 at 10:57:18PM +0300, Vladimir Zapolskiy wrote: >> Hi Oleksij, >> >> On 06/11/2017 09:19 AM, Oleksij Rempel wrote: >>> Hi Rob, >>> >>> On Fr

Re: [PATCH 2/2] mfd: max7360: Add mfd core device driver

Hi Valentin, On 06/13/2017 03:20 PM, Valentin Sitdikov wrote: > From: Andrei Dranitca > > This patch adds core/irq driver to support MAX7360 i2c chip > which contains keypad, gpio, pwm, gpo and rotary encoder submodules. > > Signed-off-by: Andrei Dranitca

Re: [PATCH 2/2] mfd: max7360: Add mfd core device driver

Hi Valentin, On 06/13/2017 03:20 PM, Valentin Sitdikov wrote: > From: Andrei Dranitca > > This patch adds core/irq driver to support MAX7360 i2c chip > which contains keypad, gpio, pwm, gpo and rotary encoder submodules. > > Signed-off-by: Andrei Dranitca > Signed-off-by: Valentin Sitdikov >

Re: [PATCH 1/2] dt-bindings: mfd: Add DT bindings documentation for the max7360 mfd driver

Hi Valentin, On 06/13/2017 03:20 PM, Valentin Sitdikov wrote: > This patch adds documentation for the max7360 bindings. > The max7360 is Multi-functional Device containing gpio, > keypad, pwm and rotary encoder submodules. > > Signed-off-by: Andrei Dranitca >

Re: [PATCH 1/2] dt-bindings: mfd: Add DT bindings documentation for the max7360 mfd driver

Hi Valentin, On 06/13/2017 03:20 PM, Valentin Sitdikov wrote: > This patch adds documentation for the max7360 bindings. > The max7360 is Multi-functional Device containing gpio, > keypad, pwm and rotary encoder submodules. > > Signed-off-by: Andrei Dranitca > Signed-off-by: Valentin Sitdikov >

Re: [PATCH v8 00/34] i.MX Media Driver

On 06/10/2017 02:26 AM, Hans Verkuil wrote: > On 10/06/17 01:16, Steve Longerbeam wrote: >> >> >> On 06/07/2017 12:02 PM, Hans Verkuil wrote: >>> We're still waiting for an Ack for patch 02/34, right? >>> >> >> Hi Hans, Rub has provided an Ack for patch 2. >> >>> Other than that everything is

Re: [PATCH v8 00/34] i.MX Media Driver

On 06/10/2017 02:26 AM, Hans Verkuil wrote: > On 10/06/17 01:16, Steve Longerbeam wrote: >> >> >> On 06/07/2017 12:02 PM, Hans Verkuil wrote: >>> We're still waiting for an Ack for patch 02/34, right? >>> >> >> Hi Hans, Rub has provided an Ack for patch 2. >> >>> Other than that everything is

Re: [PATCH v1 1/1] gpio: of: provide option generic property for initial line states

Hi Oleksij, On 06/11/2017 09:19 AM, Oleksij Rempel wrote: > Hi Rob, > > On Fri, Jun 09, 2017 at 10:41:30AM -0500, Rob Herring wrote: >> On Fri, Jun 9, 2017 at 9:16 AM, Oleksij Rempel >> wrote: >>> This property is needed for barebox or may be other bootloaders >>> to

Re: [PATCH v1 1/1] gpio: of: provide option generic property for initial line states

Hi Oleksij, On 06/11/2017 09:19 AM, Oleksij Rempel wrote: > Hi Rob, > > On Fri, Jun 09, 2017 at 10:41:30AM -0500, Rob Herring wrote: >> On Fri, Jun 9, 2017 at 9:16 AM, Oleksij Rempel >> wrote: >>> This property is needed for barebox or may be other bootloaders >>> to set proper gpio

[PATCH] regmap: irq: allow to register one cell interrupt controllers

The change makes possible to use regmap-irq interface within drivers of simple interrupt controllers, which don't have an option to handle different interrupt types and thus have one cell interrupt controllers described in device tree bindings. Signed-off-by: Vladimir Zapolskiy <vladimir_zap

[PATCH] regmap: irq: allow to register one cell interrupt controllers

The change makes possible to use regmap-irq interface within drivers of simple interrupt controllers, which don't have an option to handle different interrupt types and thus have one cell interrupt controllers described in device tree bindings. Signed-off-by: Vladimir Zapolskiy --- drivers/base

Re: [PATCH] of: Introduce of_node_get_match_data() helper

te to of_match_device(), which is truly convenient. > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> The change itself is good. Reviewed-by: Vladimir Zapolskiy <vladimir_zapols...@mentor.com> -- With best wishes, Vladimir

Re: [PATCH] of: Introduce of_node_get_match_data() helper

te to of_match_device(), which is truly convenient. > Signed-off-by: Geert Uytterhoeven The change itself is good. Reviewed-by: Vladimir Zapolskiy -- With best wishes, Vladimir

Re: [PATCH v6 17/39] platform: add video-multiplexer subdevice driver

Hi Steve, On 03/28/2017 03:40 AM, Steve Longerbeam wrote: > From: Philipp Zabel > > This driver can handle SoC internal and external video bus multiplexers, > controlled either by register bit fields or by a GPIO. The subdevice > passes through frame interval and mbus

Re: [PATCH v6 17/39] platform: add video-multiplexer subdevice driver

Hi Steve, On 03/28/2017 03:40 AM, Steve Longerbeam wrote: > From: Philipp Zabel > > This driver can handle SoC internal and external video bus multiplexers, > controlled either by register bit fields or by a GPIO. The subdevice > passes through frame interval and mbus configuration of the

Re: [PATCH v10 2/2] media: i2c: Add support for OV5647 sensor.

roliv...@synopsys.com> All updates are fine, thank you. Feel free to add my Reviewed-by: Vladimir Zapolskiy <vladimir_zapols...@mentor.com> > --- > MAINTAINERS| 7 + > drivers/media/i2c/Kconfig | 11 + > drivers/media/i2c/Makefile |

Re: [PATCH v10 2/2] media: i2c: Add support for OV5647 sensor.

l updates are fine, thank you. Feel free to add my Reviewed-by: Vladimir Zapolskiy > --- > MAINTAINERS| 7 + > drivers/media/i2c/Kconfig | 11 + > drivers/media/i2c/Makefile | 1 + > drivers/media/i2c/ov5647.c | 636 > +

Re: [PATCH v10 1/2] Documentation: DT: Add OV5647 bindings

Hi Ramiro, On 03/06/2017 01:16 PM, Ramiro Oliveira wrote: > Create device tree bindings documentation. > > Signed-off-by: Ramiro Oliveira <roliv...@synopsys.com> The device tree binding description looks perfect from my perspective. Reviewed-by: Vladimir Zapolskiy &

Re: [PATCH v10 1/2] Documentation: DT: Add OV5647 bindings

Hi Ramiro, On 03/06/2017 01:16 PM, Ramiro Oliveira wrote: > Create device tree bindings documentation. > > Signed-off-by: Ramiro Oliveira The device tree binding description looks perfect from my perspective. Reviewed-by: Vladimir Zapolskiy -- With best wishes, Vladimir

Re: [PATCH v2] drm/bridge: dw_hdmi: support i2c extended read mode

tion is correct. Thank you for the change. Please feel free to update the commit message and add my Acked-by: Vladimir Zapolskiy <vladimir_zapols...@mentor.com> -- With best wishes, Vladimir

Re: [PATCH v2] drm/bridge: dw_hdmi: support i2c extended read mode

h this patch,dw-hdmi can read EDID data with 1/2/4 blocks. > > Signed-off-by: Nickey Yang > Reviewed-by: Douglas Anderson > --- Unfortunately I don't have a chance to test the change thoroughly, but from what I see the implementation is correct. Thank you for the change. Please feel free

Re: [PATCH v5 00/39] i.MX Media Driver

On 03/19/2017 04:22 PM, Russell King - ARM Linux wrote: > On Sun, Mar 19, 2017 at 02:21:10PM +, Russell King - ARM Linux wrote: >> There's a good reason why I dumped a full debug log using GST_DEBUG=*:9, >> analysed it for the cause of the failure, and tried several different >> pipelines,

Re: [PATCH v5 00/39] i.MX Media Driver

On 03/19/2017 04:22 PM, Russell King - ARM Linux wrote: > On Sun, Mar 19, 2017 at 02:21:10PM +, Russell King - ARM Linux wrote: >> There's a good reason why I dumped a full debug log using GST_DEBUG=*:9, >> analysed it for the cause of the failure, and tried several different >> pipelines,

Re: [PATCH v5 00/39] i.MX Media Driver

Hi Russell, On 03/18/2017 10:43 PM, Russell King - ARM Linux wrote: > On Sat, Mar 18, 2017 at 12:58:27PM -0700, Steve Longerbeam wrote: >> Can you share your gstreamer pipeline? For now, until >> VIDIOC_ENUM_FRAMESIZES is implemented, try a pipeline that >> does not attempt to specify a frame

Re: [PATCH v5 00/39] i.MX Media Driver

Hi Russell, On 03/18/2017 10:43 PM, Russell King - ARM Linux wrote: > On Sat, Mar 18, 2017 at 12:58:27PM -0700, Steve Longerbeam wrote: >> Can you share your gstreamer pipeline? For now, until >> VIDIOC_ENUM_FRAMESIZES is implemented, try a pipeline that >> does not attempt to specify a frame

Re: [PATCH v2] MAINTAINERS: Add maintianer entry for crypto/s5p-sss

On 03/11/2017 08:11 AM, Krzysztof Kozlowski wrote: > Add Krzysztof Kozlowski and Vladimir Zapolskiy as maintainers of s5p-sss > driver for handling reviews, testing and getting bug reports from the > users. > > Cc: Vladimir Zapolskiy <v...@mleia.com> > Cc: Herbert Xu <

Re: [PATCH v2] MAINTAINERS: Add maintianer entry for crypto/s5p-sss

On 03/11/2017 08:11 AM, Krzysztof Kozlowski wrote: > Add Krzysztof Kozlowski and Vladimir Zapolskiy as maintainers of s5p-sss > driver for handling reviews, testing and getting bug reports from the > users. > > Cc: Vladimir Zapolskiy > Cc: Herbert Xu > Signed-off-by

Re: [PATCH] MAINTAINERS: Add Krzysztof Kozlowski as maintainer of crypto/s5p-sss

Hi Krzysztof, On 03/10/2017 09:10 PM, Krzysztof Kozlowski wrote: > Beside developing of this driver recently, I handle also reviews and > bug reports from users so having a maintainer entry will ensure that I > will be CC-ed on important emails. if you assume that the driver needs a special

Re: [PATCH] MAINTAINERS: Add Krzysztof Kozlowski as maintainer of crypto/s5p-sss

Hi Krzysztof, On 03/10/2017 09:10 PM, Krzysztof Kozlowski wrote: > Beside developing of this driver recently, I handle also reviews and > bug reports from users so having a maintainer entry will ensure that I > will be CC-ed on important emails. if you assume that the driver needs a special

Re: [PATCH v9 2/2] Add support for OV5647 sensor.

On 02/22/2017 12:51 PM, Ramiro Oliveira wrote: > Hi Zakari, > > On 2/21/2017 8:36 PM, Vladimir Zapolskiy wrote: >> Hi Ramiro, >> >> On 02/21/2017 06:42 PM, Ramiro Oliveira wrote: >>> Hi Vladimir, >>> >>> Thank you for your feedback >>&

Re: [PATCH v9 2/2] Add support for OV5647 sensor.

On 02/22/2017 12:51 PM, Ramiro Oliveira wrote: > Hi Zakari, > > On 2/21/2017 8:36 PM, Vladimir Zapolskiy wrote: >> Hi Ramiro, >> >> On 02/21/2017 06:42 PM, Ramiro Oliveira wrote: >>> Hi Vladimir, >>> >>> Thank you for your feedback >>&

Re: [PATCH v9 1/2] Add OV5647 device tree documentation

Hi Ramiro, On 02/22/2017 12:57 PM, Ramiro Oliveira wrote: > Hi Vladimir > > On 2/21/2017 10:37 PM, Vladimir Zapolskiy wrote: >> Hi Sakari, >> >> On 02/21/2017 11:48 PM, Sakari Ailus wrote: >>> Hi, Vladimir! >>> >>> How do you do? :-) >>

Re: [PATCH v9 1/2] Add OV5647 device tree documentation

Hi Ramiro, On 02/22/2017 12:57 PM, Ramiro Oliveira wrote: > Hi Vladimir > > On 2/21/2017 10:37 PM, Vladimir Zapolskiy wrote: >> Hi Sakari, >> >> On 02/21/2017 11:48 PM, Sakari Ailus wrote: >>> Hi, Vladimir! >>> >>> How do you do? :-) >>

Re: [PATCH v9 1/2] Add OV5647 device tree documentation

Hi Sakari, On 02/21/2017 11:48 PM, Sakari Ailus wrote: > Hi, Vladimir! > > How do you do? :-) deferring execution of boring tasks by doing code review :) > On Tue, Feb 21, 2017 at 10:48:09PM +0200, Vladimir Zapolskiy wrote: >> Hi Ramiro, >> >> On 02/21/2017 1

Re: [PATCH v9 1/2] Add OV5647 device tree documentation

Hi Sakari, On 02/21/2017 11:48 PM, Sakari Ailus wrote: > Hi, Vladimir! > > How do you do? :-) deferring execution of boring tasks by doing code review :) > On Tue, Feb 21, 2017 at 10:48:09PM +0200, Vladimir Zapolskiy wrote: >> Hi Ramiro, >> >> On 02/21/2017 1

Re: [PATCH v9 1/2] Add OV5647 device tree documentation

Hi Ramiro, On 02/21/2017 10:13 PM, Ramiro Oliveira wrote: > Hi Vladimir, > > Thank you for your feedback > > On 2/21/2017 3:58 PM, Vladimir Zapolskiy wrote: >> Hi Ramiro, >> >> On 02/17/2017 03:14 PM, Ramiro Oliveira wrote: >>> Create device tree

Re: [PATCH v9 1/2] Add OV5647 device tree documentation

Hi Ramiro, On 02/21/2017 10:13 PM, Ramiro Oliveira wrote: > Hi Vladimir, > > Thank you for your feedback > > On 2/21/2017 3:58 PM, Vladimir Zapolskiy wrote: >> Hi Ramiro, >> >> On 02/17/2017 03:14 PM, Ramiro Oliveira wrote: >>> Create device tree

Re: [PATCH v9 2/2] Add support for OV5647 sensor.

Hi Ramiro, On 02/21/2017 06:42 PM, Ramiro Oliveira wrote: > Hi Vladimir, > > Thank you for your feedback > > On 2/21/2017 3:54 PM, Vladimir Zapolskiy wrote: >> Hi Ramiro, >> >> please find some review comments below. >> >> On 02/17/2017 03:14 PM,

Re: [PATCH v9 2/2] Add support for OV5647 sensor.

Hi Ramiro, On 02/21/2017 06:42 PM, Ramiro Oliveira wrote: > Hi Vladimir, > > Thank you for your feedback > > On 2/21/2017 3:54 PM, Vladimir Zapolskiy wrote: >> Hi Ramiro, >> >> please find some review comments below. >> >> On 02/17/2017 03:14 PM,

Re: [PATCH v9 1/2] Add OV5647 device tree documentation

Hi Ramiro, On 02/17/2017 03:14 PM, Ramiro Oliveira wrote: > Create device tree bindings documentation. > > Signed-off-by: Ramiro Oliveira > Acked-by: Rob Herring > --- > .../devicetree/bindings/media/i2c/ov5647.txt | 35 > ++ >

Re: [PATCH v9 1/2] Add OV5647 device tree documentation

Hi Ramiro, On 02/17/2017 03:14 PM, Ramiro Oliveira wrote: > Create device tree bindings documentation. > > Signed-off-by: Ramiro Oliveira > Acked-by: Rob Herring > --- > .../devicetree/bindings/media/i2c/ov5647.txt | 35 > ++ > 1 file changed, 35 insertions(+) >

Re: [PATCH v9 2/2] Add support for OV5647 sensor.

Hi Ramiro, please find some review comments below. On 02/17/2017 03:14 PM, Ramiro Oliveira wrote: > The OV5647 sensor from Omnivision supports up to 2592x1944 @ 15 fps, RAW 8 > and RAW 10 output formats, and MIPI CSI-2 interface. > > The driver adds support for 640x480 RAW 8. > >

Re: [PATCH v9 2/2] Add support for OV5647 sensor.

Hi Ramiro, please find some review comments below. On 02/17/2017 03:14 PM, Ramiro Oliveira wrote: > The OV5647 sensor from Omnivision supports up to 2592x1944 @ 15 fps, RAW 8 > and RAW 10 output formats, and MIPI CSI-2 interface. > > The driver adds support for 640x480 RAW 8. > >

Re: [PATCH v8 2/2] Add support for OV5647 sensor.

Hi Ramiro, On 02/13/2017 09:14 PM, Ramiro Oliveira wrote: > Hi Vladimir, > > Thank you for your feedback. > > On 2/13/2017 12:21 PM, Vladimir Zapolskiy wrote: >> Hello Ramiro, >> >> On 02/13/2017 01:25 PM, Ramiro Oliveira wrote: >>> Modes supported: >

Re: [PATCH v8 2/2] Add support for OV5647 sensor.

Hi Ramiro, On 02/13/2017 09:14 PM, Ramiro Oliveira wrote: > Hi Vladimir, > > Thank you for your feedback. > > On 2/13/2017 12:21 PM, Vladimir Zapolskiy wrote: >> Hello Ramiro, >> >> On 02/13/2017 01:25 PM, Ramiro Oliveira wrote: >>> Modes supported: >

Re: [PATCH v8 2/2] Add support for OV5647 sensor.

Hello Ramiro, On 02/13/2017 01:25 PM, Ramiro Oliveira wrote: > Modes supported: > - 640x480 RAW 8 > It is a pretty short commit message, please consider to write a couple of words about the sensor. > Signed-off-by: Ramiro Oliveira > --- [snip] > + > +struct cfg_array

Re: [PATCH v8 2/2] Add support for OV5647 sensor.

Hello Ramiro, On 02/13/2017 01:25 PM, Ramiro Oliveira wrote: > Modes supported: > - 640x480 RAW 8 > It is a pretty short commit message, please consider to write a couple of words about the sensor. > Signed-off-by: Ramiro Oliveira > --- [snip] > + > +struct cfg_array { > + struct

Re: [PATCH 1/5] of: introduce of_graph_get_remote_node

Hi Rob, On 02/04/2017 05:36 AM, Rob Herring wrote: > The OF graph API leaves too much of the graph walking to clients when > in many cases the driver doesn't care about accessing the port or > endpoint nodes. The drivers typically just want the device connected via > a particular graph

Re: [PATCH 1/5] of: introduce of_graph_get_remote_node

Hi Rob, On 02/04/2017 05:36 AM, Rob Herring wrote: > The OF graph API leaves too much of the graph walking to clients when > in many cases the driver doesn't care about accessing the port or > endpoint nodes. The drivers typically just want the device connected via > a particular graph

Re: [PATCH] i2c: core: helper function to detect slave mode

Hello Luis, On 01/16/2017 12:32 PM, Luis Oliveira wrote: > On 12-Jan-17 17:01, Andy Shevchenko wrote: >> On Sat, 2017-01-07 at 03:24 +0200, Vladimir Zapolskiy wrote: >>> On 01/07/2017 02:19 AM, Andy Shevchenko wrote: >>>> On Sat, Jan 7, 2017 at 1:43 AM, Vlad

Re: [PATCH] i2c: core: helper function to detect slave mode

Hello Luis, On 01/16/2017 12:32 PM, Luis Oliveira wrote: > On 12-Jan-17 17:01, Andy Shevchenko wrote: >> On Sat, 2017-01-07 at 03:24 +0200, Vladimir Zapolskiy wrote: >>> On 01/07/2017 02:19 AM, Andy Shevchenko wrote: >>>> On Sat, Jan 7, 2017 at 1:43 AM, Vladimir Zapo

Re: [PATCH 44/62] watchdog: pnx4008_wdt: Convert to use device managed functions

t; - Drop remove function > - Use devm_watchdog_register_driver() to register watchdog device > > Cc: Vladimir Zapolskiy <v...@mleia.com> Acked-by: Vladimir Zapolskiy <v...@mleia.com> Thank you for the cleanup. > Cc: Sylvain Lemieux <slemieux.t...@gmail.com> > Sign

Re: [PATCH 44/62] watchdog: pnx4008_wdt: Convert to use device managed functions

t; - Drop remove function > - Use devm_watchdog_register_driver() to register watchdog device > > Cc: Vladimir Zapolskiy Acked-by: Vladimir Zapolskiy Thank you for the cleanup. > Cc: Sylvain Lemieux > Signed-off-by: Guenter Roeck -- With best wishes, Vladimir

Re: [PATCH 56/62] watchdog: tangox_wdt: Convert to use device managed functions

Hello Uwe, On 01/11/2017 04:39 PM, Uwe Kleine-König wrote: > On Wed, Jan 11, 2017 at 01:31:47PM +0100, Marc Gonzalez wrote: >> On 11/01/2017 11:52, Guenter Roeck wrote: >> >>> On 01/11/2017 01:07 AM, Marc Gonzalez wrote: >>> > @@ -134,12 +134,15 @@ static int tangox_wdt_probe(struct

Re: [PATCH 56/62] watchdog: tangox_wdt: Convert to use device managed functions

Hello Uwe, On 01/11/2017 04:39 PM, Uwe Kleine-König wrote: > On Wed, Jan 11, 2017 at 01:31:47PM +0100, Marc Gonzalez wrote: >> On 11/01/2017 11:52, Guenter Roeck wrote: >> >>> On 01/11/2017 01:07 AM, Marc Gonzalez wrote: >>> > @@ -134,12 +134,15 @@ static int tangox_wdt_probe(struct

Re: [PATCH] i2c: print correct device invalid address

r *adap, > > if (i2c_check_addr_validity(addr, info.flags)) { > dev_err(>dev, "of_i2c: invalid addr=%x on %s\n", > - info.addr, node->full_name); > + addr, node->full_name); > retur

Re: [PATCH] i2c: print correct device invalid address

if (i2c_check_addr_validity(addr, info.flags)) { > dev_err(>dev, "of_i2c: invalid addr=%x on %s\n", > - info.addr, node->full_name); > + addr, node->full_name); > return ERR_PTR(-EINVAL); > }

Re: [PATCH] i2c: core: helper function to detect slave mode

On 01/07/2017 02:19 AM, Andy Shevchenko wrote: > On Sat, Jan 7, 2017 at 1:43 AM, Vladimir Zapolskiy <v...@mleia.com> wrote: >> On 01/07/2017 12:45 AM, Andy Shevchenko wrote: >>> On Fri, Jan 6, 2017 at 11:46 PM, Vladimir Zapolskiy <v...@mleia.com> wrote: >>>&g

Re: [PATCH] i2c: core: helper function to detect slave mode

On 01/07/2017 02:19 AM, Andy Shevchenko wrote: > On Sat, Jan 7, 2017 at 1:43 AM, Vladimir Zapolskiy wrote: >> On 01/07/2017 12:45 AM, Andy Shevchenko wrote: >>> On Fri, Jan 6, 2017 at 11:46 PM, Vladimir Zapolskiy wrote: >>>>> + if (IS_B

Re: [PATCH] i2c: core: helper function to detect slave mode

On 01/07/2017 12:45 AM, Andy Shevchenko wrote: > On Fri, Jan 6, 2017 at 11:46 PM, Vladimir Zapolskiy <v...@mleia.com> wrote: >>> + if (IS_BUILTIN(CONFIG_OF) && dev->of_node) { >> >> IS_BUILTIN(CONFIG_OF) looks excessive, check for non-NULL dev->

Re: [PATCH] i2c: core: helper function to detect slave mode

On 01/07/2017 12:45 AM, Andy Shevchenko wrote: > On Fri, Jan 6, 2017 at 11:46 PM, Vladimir Zapolskiy wrote: >>> + if (IS_BUILTIN(CONFIG_OF) && dev->of_node) { >> >> IS_BUILTIN(CONFIG_OF) looks excessive, check for non-NULL dev->of_node >> shou

Re: [PATCH v2] i2c: core: helper function to detect slave mode

Hi Luis, On 01/06/2017 08:14 PM, Luis Oliveira wrote: > This function has the purpose of mode detection by checking the > device nodes for a reg matching with the I2C_OWN_SLAVE_ADDREESS flag. > Currently only checks using OF functions (ACPI slave not supported yet). > I've accidentally reviewed

Re: [PATCH v2] i2c: core: helper function to detect slave mode

Hi Luis, On 01/06/2017 08:14 PM, Luis Oliveira wrote: > This function has the purpose of mode detection by checking the > device nodes for a reg matching with the I2C_OWN_SLAVE_ADDREESS flag. > Currently only checks using OF functions (ACPI slave not supported yet). > I've accidentally reviewed

<    1   2   3   4   5   6   7   8   9   >