Re: [PATCH] i2c: core: helper function to detect slave mode

Hello Luis, On 01/05/2017 07:24 PM, Luis Oliveira wrote: > This function has the purpose of mode detection by checking the > device nodes for a reg matching with the I2C_OWN_SLAVE_ADDREESS flag. > Currently only checks using OF functions (ACPI slave not supported yet). > > Signed-off-by: Luis

Re: [PATCH] i2c: core: helper function to detect slave mode

Hello Luis, On 01/05/2017 07:24 PM, Luis Oliveira wrote: > This function has the purpose of mode detection by checking the > device nodes for a reg matching with the I2C_OWN_SLAVE_ADDREESS flag. > Currently only checks using OF functions (ACPI slave not supported yet). > > Signed-off-by: Luis

Re: [PATCH] i2c: i2c-cadence: Don't register the adapter until it's ready

Hello Mike, On 01/05/2017 12:47 PM, Mike Looijmans wrote: > The driver calls i2c_add_adapter before writing to config registers, > resulting in dmesg output like this, where devices fail to initialize: > > cdns-i2c ff03.i2c: timeout waiting on completion > pca953x 1-0041: failed reading

Re: [PATCH] i2c: i2c-cadence: Don't register the adapter until it's ready

Hello Mike, On 01/05/2017 12:47 PM, Mike Looijmans wrote: > The driver calls i2c_add_adapter before writing to config registers, > resulting in dmesg output like this, where devices fail to initialize: > > cdns-i2c ff03.i2c: timeout waiting on completion > pca953x 1-0041: failed reading

Re: [PATCH 1/1] spi: imx: support to set watermark level via DTS

Hi Jiada, On 01/05/2017 08:10 AM, Jiada Wang wrote: > Previously watermark level is configured to fifosize/2, > DMA mode can be used only when transfer length can be divided > by 'watermark level * bpw', which makes DMA mode not practical. > > This patch adds new DTS property 'dma-wml', user can

Re: [PATCH 1/1] spi: imx: support to set watermark level via DTS

Hi Jiada, On 01/05/2017 08:10 AM, Jiada Wang wrote: > Previously watermark level is configured to fifosize/2, > DMA mode can be used only when transfer length can be divided > by 'watermark level * bpw', which makes DMA mode not practical. > > This patch adds new DTS property 'dma-wml', user can

Re: [PATCH v2 15/19] media: imx: Add MIPI CSI-2 Receiver subdev driver

On 01/03/2017 10:57 PM, Steve Longerbeam wrote: > Adds MIPI CSI-2 Receiver subdev driver. This subdev is required > for sensors with a MIPI CSI2 interface. > > Signed-off-by: Steve Longerbeam > --- > drivers/staging/media/imx/Makefile| 1 + >

Re: [PATCH v2 15/19] media: imx: Add MIPI CSI-2 Receiver subdev driver

On 01/03/2017 10:57 PM, Steve Longerbeam wrote: > Adds MIPI CSI-2 Receiver subdev driver. This subdev is required > for sensors with a MIPI CSI2 interface. > > Signed-off-by: Steve Longerbeam > --- > drivers/staging/media/imx/Makefile| 1 + > drivers/staging/media/imx/imx-mipi-csi2.c

Re: [PATCH v2 14/19] media: imx: Add Camera Interface subdev driver

On 01/03/2017 10:57 PM, Steve Longerbeam wrote: > This is the camera interface driver that provides the v4l2 > user interface. Frames can be received from various sources: > > - directly from SMFC for capturing unconverted images directly from > camera sensors. > > - from the IC pre-process

Re: [PATCH v2 14/19] media: imx: Add Camera Interface subdev driver

On 01/03/2017 10:57 PM, Steve Longerbeam wrote: > This is the camera interface driver that provides the v4l2 > user interface. Frames can be received from various sources: > > - directly from SMFC for capturing unconverted images directly from > camera sensors. > > - from the IC pre-process

Re: [PATCH v2 13/19] media: imx: Add IC subdev drivers

On 01/03/2017 10:57 PM, Steve Longerbeam wrote: > This is a set of three media entity subdevice drivers for the i.MX > Image Converter. The i.MX IC module contains three independent > "tasks": > > - Pre-processing Encode task: video frames are routed directly from > the CSI and can be scaled,

Re: [PATCH v2 13/19] media: imx: Add IC subdev drivers

On 01/03/2017 10:57 PM, Steve Longerbeam wrote: > This is a set of three media entity subdevice drivers for the i.MX > Image Converter. The i.MX IC module contains three independent > "tasks": > > - Pre-processing Encode task: video frames are routed directly from > the CSI and can be scaled,

Re: [PATCH v2 12/19] media: imx: Add SMFC subdev driver

On 01/03/2017 10:57 PM, Steve Longerbeam wrote: > This is a media entity subdevice driver for the i.MX Sensor Multi-FIFO > Controller module. Video frames are received from the CSI and can > be routed to various sinks including the i.MX Image Converter for > scaling, color-space conversion, motion

Re: [PATCH v2 12/19] media: imx: Add SMFC subdev driver

On 01/03/2017 10:57 PM, Steve Longerbeam wrote: > This is a media entity subdevice driver for the i.MX Sensor Multi-FIFO > Controller module. Video frames are received from the CSI and can > be routed to various sinks including the i.MX Image Converter for > scaling, color-space conversion, motion

Re: [PATCH v2 10/19] media: Add i.MX media core driver

Hi Steve, On 01/03/2017 10:57 PM, Steve Longerbeam wrote: > Add the core media driver for i.MX SOC. > > Signed-off-by: Steve Longerbeam > --- > Documentation/devicetree/bindings/media/imx.txt | 205 + v2 was sent before getting Rob's review comments, but

Re: [PATCH v2 10/19] media: Add i.MX media core driver

Hi Steve, On 01/03/2017 10:57 PM, Steve Longerbeam wrote: > Add the core media driver for i.MX SOC. > > Signed-off-by: Steve Longerbeam > --- > Documentation/devicetree/bindings/media/imx.txt | 205 + v2 was sent before getting Rob's review comments, but still they should be addressed in

Re: [PATCH v2 11/19] media: imx: Add CSI subdev driver

On 01/03/2017 10:57 PM, Steve Longerbeam wrote: > This is a media entity subdevice for the i.MX Camera > Serial Interface module. > > Signed-off-by: Steve Longerbeam > --- [snip] > diff --git a/drivers/staging/media/imx/imx-csi.c >

Re: [PATCH v2 11/19] media: imx: Add CSI subdev driver

On 01/03/2017 10:57 PM, Steve Longerbeam wrote: > This is a media entity subdevice for the i.MX Camera > Serial Interface module. > > Signed-off-by: Steve Longerbeam > --- [snip] > diff --git a/drivers/staging/media/imx/imx-csi.c > b/drivers/staging/media/imx/imx-csi.c > new file mode 100644

Re: [PATCH v2 09/19] ARM: dts: imx6-sabreauto: add the ADV7180 video decoder

On 01/03/2017 10:57 PM, Steve Longerbeam wrote: > Enables the ADV7180 decoder sensor. The ADV7180 connects to the > parallel-bus mux input on ipu1_csi0_mux. > > On the sabreauto, two analog video inputs are routed to the ADV7180, > composite on Ain1, and composite on Ain3. Those inputs are

Re: [PATCH v2 09/19] ARM: dts: imx6-sabreauto: add the ADV7180 video decoder

On 01/03/2017 10:57 PM, Steve Longerbeam wrote: > Enables the ADV7180 decoder sensor. The ADV7180 connects to the > parallel-bus mux input on ipu1_csi0_mux. > > On the sabreauto, two analog video inputs are routed to the ADV7180, > composite on Ain1, and composite on Ain3. Those inputs are

Re: [PATCH v2 05/19] ARM: dts: imx6-sabresd: add OV5642 and OV5640 camera sensors

On 01/03/2017 10:57 PM, Steve Longerbeam wrote: > Enables the OV5642 parallel-bus sensor, and the OV5640 MIPI CSI-2 sensor. > > The OV5642 connects to the parallel-bus mux input port on ipu1_csi0_mux. > > The OV5640 connects to the input port on the MIPI CSI-2 receiver on > mipi_csi. It is set

Re: [PATCH v2 05/19] ARM: dts: imx6-sabresd: add OV5642 and OV5640 camera sensors

On 01/03/2017 10:57 PM, Steve Longerbeam wrote: > Enables the OV5642 parallel-bus sensor, and the OV5640 MIPI CSI-2 sensor. > > The OV5642 connects to the parallel-bus mux input port on ipu1_csi0_mux. > > The OV5640 connects to the input port on the MIPI CSI-2 receiver on > mipi_csi. It is set

Re: [PATCH v2 04/19] ARM: dts: imx6-sabrelite: add OV5642 and OV5640 camera sensors

Hi Steve, On 01/03/2017 10:57 PM, Steve Longerbeam wrote: > Enables the OV5642 parallel-bus sensor, and the OV5640 MIPI CSI-2 sensor. > Both hang off the same i2c2 bus, so they require different (and non- > default) i2c slave addresses. > > The OV5642 connects to the parallel-bus mux input port

Re: [PATCH v2 04/19] ARM: dts: imx6-sabrelite: add OV5642 and OV5640 camera sensors

Hi Steve, On 01/03/2017 10:57 PM, Steve Longerbeam wrote: > Enables the OV5642 parallel-bus sensor, and the OV5640 MIPI CSI-2 sensor. > Both hang off the same i2c2 bus, so they require different (and non- > default) i2c slave addresses. > > The OV5642 connects to the parallel-bus mux input port

Re: [PATCH] gpio: pca953x: Add optional reset gpio control

; + GPIOD_OUT_LOW); > + if (IS_ERR(reset_gpio)) { > + dev_err(>dev, "request for reset pin failed\n"); I'm not confident that the error message is wanted here, you may consider either to remove i

Re: [PATCH] gpio: pca953x: Add optional reset gpio control

(IS_ERR(reset_gpio)) { > + dev_err(>dev, "request for reset pin failed\n"); I'm not confident that the error message is wanted here, you may consider either to remove it or at least print it out if (PTR_ERR(reset_gpio) != -EPROBE_DEFER). > + return PTR_ERR(reset_gpio); > + } > } > > chip->client = client; > Reviewed-by: Vladimir Zapolskiy -- With best wishes, Vladimir

Re: [PATCH] gpio: pca953x: Add optional reset gpio control

On 01/04/2017 01:37 AM, Andy Shevchenko wrote: > On Mon, Jan 2, 2017 at 11:07 PM, Steve Longerbeam > wrote: >> Add optional reset-gpios pin control. If present, de-assert the >> specified reset gpio pin to bring the chip out of reset. > >> ---

Re: [PATCH] gpio: pca953x: Add optional reset gpio control

On 01/04/2017 01:37 AM, Andy Shevchenko wrote: > On Mon, Jan 2, 2017 at 11:07 PM, Steve Longerbeam > wrote: >> Add optional reset-gpios pin control. If present, de-assert the >> specified reset gpio pin to bring the chip out of reset. > >> --- a/drivers/gpio/gpio-pca953x.c >> +++

Re: [PATCH] DTS: MCCMON6: IMX: Provide support for iMX6Q based Liebherr mccmon6 board

Hi Lukasz, please find some comments below as usual. On 01/02/2017 04:44 PM, Lukasz Majewski wrote: > Hi Vladimir, > > Thank you for review. Comments without my remarks have been applied > already. > >> Hello Lukasz, >> >> On 12/27/2016 01:19 AM, Lukasz Majewski wrote: >>> Signed-off-by:

Re: [PATCH] DTS: MCCMON6: IMX: Provide support for iMX6Q based Liebherr mccmon6 board

Hi Lukasz, please find some comments below as usual. On 01/02/2017 04:44 PM, Lukasz Majewski wrote: > Hi Vladimir, > > Thank you for review. Comments without my remarks have been applied > already. > >> Hello Lukasz, >> >> On 12/27/2016 01:19 AM, Lukasz Majewski wrote: >>> Signed-off-by:

Re: [PATCH] DTS: MCCMON6: IMX: Provide support for iMX6Q based Liebherr mccmon6 board

Hello Lukasz, On 12/27/2016 01:19 AM, Lukasz Majewski wrote: > Signed-off-by: Lukasz Majewski please add a commit message with a short description of the change. Also change subject line to "ARM: dts: imx6q: Add mccmon6 board support". > --- > MCCMON6 board support

Re: [PATCH] DTS: MCCMON6: IMX: Provide support for iMX6Q based Liebherr mccmon6 board

Hello Lukasz, On 12/27/2016 01:19 AM, Lukasz Majewski wrote: > Signed-off-by: Lukasz Majewski please add a commit message with a short description of the change. Also change subject line to "ARM: dts: imx6q: Add mccmon6 board support". > --- > MCCMON6 board support depends on following

Re: [RFC] Question about freeing of resource in 'atlas7_pinmux_probe()', in file 'drivers/pinctrl/sirf/pinctrl-atlas7.c'

Hi, On 12/19/2016 08:19 AM, Marion & Christophe JAILLET wrote: > Hi, > > while playing with coccinelle, a missing 'of_node_put()' triggered in > 'atlas7_pinmux_probe()', in file 'drivers/pinctrl/sirf/pinctrl-atlas7.c'. > > /* The sd3 and sd9 shared all pins, and the function select by >

Re: [RFC] Question about freeing of resource in 'atlas7_pinmux_probe()', in file 'drivers/pinctrl/sirf/pinctrl-atlas7.c'

Hi, On 12/19/2016 08:19 AM, Marion & Christophe JAILLET wrote: > Hi, > > while playing with coccinelle, a missing 'of_node_put()' triggered in > 'atlas7_pinmux_probe()', in file 'drivers/pinctrl/sirf/pinctrl-atlas7.c'. > > /* The sd3 and sd9 shared all pins, and the function select by >

Re: [PATCH v10 3/3] fpga: Add support for Lattice iCE40 FPGAs

Hi Joel, On 12/18/2016 07:33 AM, Joel Holdsworth wrote: > This patch adds support to the FPGA manager for configuring the SRAM of > iCE40LM, iCE40LP, iCE40HX, iCE40 Ultra, iCE40 UltraLite and iCE40 > UltraPlus devices, through slave SPI. > > Signed-off-by: Joel Holdsworth

Re: [PATCH v10 3/3] fpga: Add support for Lattice iCE40 FPGAs

Hi Joel, On 12/18/2016 07:33 AM, Joel Holdsworth wrote: > This patch adds support to the FPGA manager for configuring the SRAM of > iCE40LM, iCE40LP, iCE40HX, iCE40 Ultra, iCE40 UltraLite and iCE40 > UltraPlus devices, through slave SPI. > > Signed-off-by: Joel Holdsworth > Reviewed-by: Marek

Re: [PATCH] driver core: flush async calls before testing driver removal

Hello Greg, I'm adding Tejun to the list of addressees. On 12/10/2016 03:04 PM, Greg Kroah-Hartman wrote: > On Sat, Dec 10, 2016 at 02:38:41PM +0200, Vladimir Zapolskiy wrote: >> Hello Greg, >> >> On 12/10/2016 09:32 AM, Greg Kroah-Hartman wrote: >>> On Sat, De

Re: [PATCH] driver core: flush async calls before testing driver removal

Hello Greg, I'm adding Tejun to the list of addressees. On 12/10/2016 03:04 PM, Greg Kroah-Hartman wrote: > On Sat, Dec 10, 2016 at 02:38:41PM +0200, Vladimir Zapolskiy wrote: >> Hello Greg, >> >> On 12/10/2016 09:32 AM, Greg Kroah-Hartman wrote: >>> On Sat, De

Re: [PATCH] driver core: flush async calls before testing driver removal

Hello Dmitry, On 12/10/2016 03:59 AM, Dmitry Torokhov wrote: > On Fri, Dec 9, 2016 at 4:15 PM, Vladimir Zapolskiy <v...@mleia.com> wrote: >> If CONFIG_DEBUG_TEST_DRIVER_REMOVE option is enabled a number of false >> positives are reported for ATA controller drivers, becau

Re: [PATCH] driver core: flush async calls before testing driver removal

Hello Dmitry, On 12/10/2016 03:59 AM, Dmitry Torokhov wrote: > On Fri, Dec 9, 2016 at 4:15 PM, Vladimir Zapolskiy wrote: >> If CONFIG_DEBUG_TEST_DRIVER_REMOVE option is enabled a number of false >> positives are reported for ATA controller drivers, because ATA port >

Re: [PATCH] driver core: flush async calls before testing driver removal

Hello Greg, On 12/10/2016 09:32 AM, Greg Kroah-Hartman wrote: > On Sat, Dec 10, 2016 at 02:15:19AM +0200, Vladimir Zapolskiy wrote: >> If CONFIG_DEBUG_TEST_DRIVER_REMOVE option is enabled a number of false >> positives are reported for ATA controller drivers, because ATA port >

Re: [PATCH] driver core: flush async calls before testing driver removal

Hello Greg, On 12/10/2016 09:32 AM, Greg Kroah-Hartman wrote: > On Sat, Dec 10, 2016 at 02:15:19AM +0200, Vladimir Zapolskiy wrote: >> If CONFIG_DEBUG_TEST_DRIVER_REMOVE option is enabled a number of false >> positives are reported for ATA controller drivers, because ATA port >

[PATCH] driver core: flush async calls before testing driver removal

Suggested-by: Tejun Heo <t...@kernel.org> Signed-off-by: Vladimir Zapolskiy <v...@mleia.com> --- Some time ago the issue was discussed on the linux-ide mailing list, see https://www.spinics.net/lists/linux-ide/msg53481.html drivers/base/dd.c | 2 ++ 1 file changed, 2 insertions(+)

[PATCH] driver core: flush async calls before testing driver removal

Suggested-by: Tejun Heo Signed-off-by: Vladimir Zapolskiy --- Some time ago the issue was discussed on the linux-ide mailing list, see https://www.spinics.net/lists/linux-ide/msg53481.html drivers/base/dd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/base/dd.c b/drivers/base/

Re: [PATCH v2 3/3] USB: OHCI: nxp: remove useless extern declaration

On 12/08/2016 12:34 AM, csmanjuvi...@gmail.com wrote: > From: Manjunath Goudar <csmanjuvi...@gmail.com> > > Remove usb_disabled() extern declaration as it is already declared > as extern in include/linux/usb.h. > > Signed-off-by: Manjunath Goudar <csmanjuvi...@gmail.co

Re: [PATCH v2 3/3] USB: OHCI: nxp: remove useless extern declaration

On 12/08/2016 12:34 AM, csmanjuvi...@gmail.com wrote: > From: Manjunath Goudar > > Remove usb_disabled() extern declaration as it is already declared > as extern in include/linux/usb.h. > > Signed-off-by: Manjunath Goudar > Cc: Vladimir Zapolskiy > Cc: Sylvain Lemieux

Re: [PATCH] USB: OHCI: nxp: fix code warnings

nt blocks > > Signed-off-by: Manjunath Goudar <csmanjuvi...@gmail.com> > Cc: Vladimir Zapolskiy <v...@mleia.com> > Cc: Sylvain Lemieux <slemieux.t...@gmail.com> > Cc: Alan Stern <st...@rowland.harvard.edu> > Cc: Greg Kroah-Hartman <gre...@linuxfoun

Re: [PATCH] USB: OHCI: nxp: fix code warnings

-by: Manjunath Goudar > Cc: Vladimir Zapolskiy > Cc: Sylvain Lemieux > Cc: Alan Stern > Cc: Greg Kroah-Hartman > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- Looks good, thank you for the change. Acked

[PATCH] dt-bindings: add MYIR Tech hardware vendor prefix

MYIR Tech Limited offers a range of ARM powered development boards and SoMs, for details reference a list on http://elinux.org/Development_Platforms#ARM or company's website http://myirtech.com Signed-off-by: Vladimir Zapolskiy <v...@mleia.com> --- Documentation/devicetree/bindings/

[PATCH] dt-bindings: add MYIR Tech hardware vendor prefix

MYIR Tech Limited offers a range of ARM powered development boards and SoMs, for details reference a list on http://elinux.org/Development_Platforms#ARM or company's website http://myirtech.com Signed-off-by: Vladimir Zapolskiy --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1

Re: [PATCH] pinctrl: imx: fix imx_pinctrl_desc initialization

_dt(pdev, info); if (ret) { excellent catch, my compiler does not report the issue. Subject and commit message are not quite informative, but the change is trivial, so please feel free to add my Reviewed-by: Vladimir Zapolskiy <vladimir_zapols...@mentor.com> -- With best wishes, Vladimir

Re: [PATCH] pinctrl: imx: fix imx_pinctrl_desc initialization

et) { excellent catch, my compiler does not report the issue. Subject and commit message are not quite informative, but the change is trivial, so please feel free to add my Reviewed-by: Vladimir Zapolskiy -- With best wishes, Vladimir

Re: [PATCH] misc: sram: remove useless #ifdef

quot;) I can not find the referenced commit on Torvald's branch, won't it be rebased and get a changed commit hash after merge? Signed-off-by: Arnd Bergmann <a...@arndb.de> --- The change itself is good, thank you for the fix. Reviewed-by: Vladimir Zapolskiy <v...@mleia.com> -- Best wishes, Vladimir

Re: [PATCH] misc: sram: remove useless #ifdef

quot;) I can not find the referenced commit on Torvald's branch, won't it be rebased and get a changed commit hash after merge? Signed-off-by: Arnd Bergmann --- The change itself is good, thank you for the fix. Reviewed-by: Vladimir Zapolskiy -- Best wishes, Vladimir

Re: [patch v5 repost 1/1] i2c: add master driver for mellanox systems

ellanox.com> Reviewed-by: Vladimir Zapolskiy <v...@mleia.com> Still valid. [snip] diff --git a/drivers/i2c/busses/i2c-mlxcpld.c b/drivers/i2c/busses/i2c-mlxcpld.c new file mode 100644 index 000..f7a6f3a --- /dev/null +++ b/drivers/i2c/busses/i2c-mlxcpld.c @@ -0,0 +1,551 @@

Re: [patch v5 repost 1/1] i2c: add master driver for mellanox systems

- Polling mode The Kconfig currently controlling compilation of this code is: drivers/i2c/busses/Kconfig:config I2C_MLXCPLD Signed-off-by: Michael Shych Signed-off-by: Vadim Pasternak Reviewed-by: Jiri Pirko Reviewed-by: Vladimir Zapolskiy Still valid. [snip] diff --git a/drivers/i2c/busses/i2c

Re: [PATCH v5] pwm: add pwm driver for HiSilicon BVT SOCs

On 11/16/2016 11:50 AM, Jian Yuan wrote: From: yuanjian Add PWM driver for the PWM controller found on HiSilicon BVT SOCs, like Hi3519V100, Hi3516CV300, etc. The PWM controller is primarily in charge of controlling P-Iris lens. Reviewed-by: Jiancheng Xue

Re: [PATCH v5] pwm: add pwm driver for HiSilicon BVT SOCs

On 11/16/2016 11:50 AM, Jian Yuan wrote: From: yuanjian Add PWM driver for the PWM controller found on HiSilicon BVT SOCs, like Hi3519V100, Hi3516CV300, etc. The PWM controller is primarily in charge of controlling P-Iris lens. Reviewed-by: Jiancheng Xue Signed-off-by: Jian Yuan --- Change

Re: [PATCH v2 1/3] ARM: dts: imx6qdl-apalis: Do not rely on DDC I2C bus bitbang for HDMI

Hi Stefan, Philipp, On 11/09/2016 02:50 AM, Stefan Agner wrote: On 2016-11-08 09:33, maitysancha...@gmail.com wrote: Hello Shawn, On 16-10-22 15:43:04, Vladimir Zapolskiy wrote: Hi Shawn, On 10/22/2016 06:25 AM, Shawn Guo wrote: On Mon, Sep 19, 2016 at 10:41:51AM +0530, Sanchayan Maity

Re: [PATCH v2 1/3] ARM: dts: imx6qdl-apalis: Do not rely on DDC I2C bus bitbang for HDMI

Hi Stefan, Philipp, On 11/09/2016 02:50 AM, Stefan Agner wrote: On 2016-11-08 09:33, maitysancha...@gmail.com wrote: Hello Shawn, On 16-10-22 15:43:04, Vladimir Zapolskiy wrote: Hi Shawn, On 10/22/2016 06:25 AM, Shawn Guo wrote: On Mon, Sep 19, 2016 at 10:41:51AM +0530, Sanchayan Maity

Re: [patch v4 1/1] i2c: add master driver for mellanox systems

return err; Note, dev_err() is not needed here, because printing of the error message is delegated to the I2C core. +} + Please feel free to add a tag to the next version: Reviewed-by: Vladimir Zapolskiy <v...@mleia.com> -- With best wishes, Vladimir

Re: [patch v4 1/1] i2c: add master driver for mellanox systems

ev_err() is not needed here, because printing of the error message is delegated to the I2C core. +} + Please feel free to add a tag to the next version: Reviewed-by: Vladimir Zapolskiy -- With best wishes, Vladimir

Re: [PATCH 13/22] mtd: nand: lpc32xx: return error code of nand_scan_ident/tail() on error

Hi Boris, On 11/06/2016 08:27 PM, Boris Brezillon wrote: On Fri, 4 Nov 2016 19:43:01 +0900 Masahiro Yamada wrote: The nand_scan_ident/tail() returns an appropriate error value when it fails. Use it instead of the fixed error code -ENXIO. Signed-off-by:

Re: [PATCH 13/22] mtd: nand: lpc32xx: return error code of nand_scan_ident/tail() on error

Hi Boris, On 11/06/2016 08:27 PM, Boris Brezillon wrote: On Fri, 4 Nov 2016 19:43:01 +0900 Masahiro Yamada wrote: The nand_scan_ident/tail() returns an appropriate error value when it fails. Use it instead of the fixed error code -ENXIO. Signed-off-by: Masahiro Yamada --- [snip] -

Re: [PATCH 13/22] mtd: nand: lpc32xx: return error code of nand_scan_ident/tail() on error

On 11/04/2016 12:43 PM, Masahiro Yamada wrote: The nand_scan_ident/tail() returns an appropriate error value when it fails. Use it instead of the fixed error code -ENXIO. Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com> --- Acked-by: Vladimir Zapolskiy <v...@mleia.co

Re: [PATCH 13/22] mtd: nand: lpc32xx: return error code of nand_scan_ident/tail() on error

On 11/04/2016 12:43 PM, Masahiro Yamada wrote: The nand_scan_ident/tail() returns an appropriate error value when it fails. Use it instead of the fixed error code -ENXIO. Signed-off-by: Masahiro Yamada --- Acked-by: Vladimir Zapolskiy Thank you for the change. -- With best wishes

Re: [patch v3 1/1] i2c: add master driver for mellanox systems

On 04.11.2016 00:34, Vladimir Zapolskiy wrote: >> + >> +static int mlxcpld_i2c_probe(struct platform_device *pdev) >> +{ >> +struct mlxcpld_i2c_priv *priv; >> +int err; >> + >> +priv = devm_kzalloc(>dev, sizeof(struct mlxcpld_i2c_

Re: [patch v3 1/1] i2c: add master driver for mellanox systems

On 04.11.2016 00:34, Vladimir Zapolskiy wrote: >> + >> +static int mlxcpld_i2c_probe(struct platform_device *pdev) >> +{ >> +struct mlxcpld_i2c_priv *priv; >> +int err; >> + >> +priv = devm_kzalloc(>dev, sizeof(struct mlxcpld_i2c_

Re: [patch v3 1/1] i2c: add master driver for mellanox systems

Hi Vadim, please find some more review comments below. On 03.11.2016 20:50, vad...@mellanox.com wrote: > From: Vadim Pasternak > > Device driver for Mellanox I2C controller logic, implemented in Lattice > CPLD device. > Device supports: > - Master mode > - One physical

Re: [patch v3 1/1] i2c: add master driver for mellanox systems

Hi Vadim, please find some more review comments below. On 03.11.2016 20:50, vad...@mellanox.com wrote: > From: Vadim Pasternak > > Device driver for Mellanox I2C controller logic, implemented in Lattice > CPLD device. > Device supports: > - Master mode > - One physical bus > - Polling mode

Re: [patch v2] i2c: add master driver for mellanox systems

Hi Vadim, On 19.09.2016 18:00, vad...@mellanox.com wrote: > From: Vadim Pasternak > > Device driver for Mellanox I2C controller logic, implemented in Lattice > CPLD device. > Device supports: > - Master mode > - One physical bus > - Polling mode > > The Kconfig

Re: [patch v2] i2c: add master driver for mellanox systems

Hi Vadim, On 19.09.2016 18:00, vad...@mellanox.com wrote: > From: Vadim Pasternak > > Device driver for Mellanox I2C controller logic, implemented in Lattice > CPLD device. > Device supports: > - Master mode > - One physical bus > - Polling mode > > The Kconfig currently controlling

Re: [PATCH] pinctrl: imx: reset group index on probe

Hi Linus, Stefan, On 25.10.2016 12:11, Linus Walleij wrote: > On Wed, Oct 19, 2016 at 12:40 AM, Vladimir Zapolskiy <v...@mleia.com> wrote: > >> I've recently developed a pinctrl driver for the last remaining >> i.MX31 platform from the SoC series (not published yet),

Re: [PATCH] pinctrl: imx: reset group index on probe

Hi Linus, Stefan, On 25.10.2016 12:11, Linus Walleij wrote: > On Wed, Oct 19, 2016 at 12:40 AM, Vladimir Zapolskiy wrote: > >> I've recently developed a pinctrl driver for the last remaining >> i.MX31 platform from the SoC series (not published yet), it does >> not fit

Re: [RFC PATCH] gpio: of: fix GPIO drivers with multiple gpio_chip for a single node

Hi Masahiro, On 24.10.2016 10:43, Masahiro Yamada wrote: > Sylvain Lemieux reports the LPC32xx GPIO driver is broken since > commit 762c2e46c059 ("gpio: of: remove of_gpiochip_and_xlate() and > struct gg_data"). Probably, gpio-etraxfs.c and gpio-davinci.c are > broken as well. > > Those drivers

Re: [RFC PATCH] gpio: of: fix GPIO drivers with multiple gpio_chip for a single node

Hi Masahiro, On 24.10.2016 10:43, Masahiro Yamada wrote: > Sylvain Lemieux reports the LPC32xx GPIO driver is broken since > commit 762c2e46c059 ("gpio: of: remove of_gpiochip_and_xlate() and > struct gg_data"). Probably, gpio-etraxfs.c and gpio-davinci.c are > broken as well. > > Those drivers

Re: [PATCH v2 1/3] ARM: dts: imx6qdl-apalis: Do not rely on DDC I2C bus bitbang for HDMI

Hi Shawn, On 10/22/2016 06:25 AM, Shawn Guo wrote: On Mon, Sep 19, 2016 at 10:41:51AM +0530, Sanchayan Maity wrote: Remove the use of DDC I2C bus bitbang to support reading of EDID and rely on support from internal HDMI I2C master controller instead. As a result remove the device tree property

Re: [PATCH v2 1/3] ARM: dts: imx6qdl-apalis: Do not rely on DDC I2C bus bitbang for HDMI

Hi Shawn, On 10/22/2016 06:25 AM, Shawn Guo wrote: On Mon, Sep 19, 2016 at 10:41:51AM +0530, Sanchayan Maity wrote: Remove the use of DDC I2C bus bitbang to support reading of EDID and rely on support from internal HDMI I2C master controller instead. As a result remove the device tree property

Re: [PATCH] pinctrl: imx: reset group index on probe

Hi Stefan, On 19.10.2016 00:09, Stefan Agner wrote: > Group index is incremented on every new group parsed. Since the > field is part of struct imx_pinctrl_soc_info, which is typically > a global variable passed by the individual pinctrl-imx.c based > driver, it does not get cleared automatically

Re: [PATCH] pinctrl: imx: reset group index on probe

Hi Stefan, On 19.10.2016 00:09, Stefan Agner wrote: > Group index is incremented on every new group parsed. Since the > field is part of struct imx_pinctrl_soc_info, which is typically > a global variable passed by the individual pinctrl-imx.c based > driver, it does not get cleared automatically

Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when freeing GPIO

On 09/29/2016 09:46 AM, Viresh Kumar wrote: On 28-09-16, 15:07, Vladimir Zapolskiy wrote: I would expect that the change below improves the situation, but I didn't perform any tests and here the core change is governed by the accepted i.MX i2c bus driver specific changes, thus conceptually

Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when freeing GPIO

On 09/29/2016 09:46 AM, Viresh Kumar wrote: On 28-09-16, 15:07, Vladimir Zapolskiy wrote: I would expect that the change below improves the situation, but I didn't perform any tests and here the core change is governed by the accepted i.MX i2c bus driver specific changes, thus conceptually

Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when freeing GPIO

On 09/28/2016 06:38 AM, Stefan Agner wrote: On 2016-09-27 19:00, Viresh Kumar wrote: On 27-09-16, 12:34, Stefan Agner wrote: Added Viresh Kumar to the discussion, he implemented the I2C recovery functions. Yes, reordering the pinctrl/gpio_free calls would fix the problem too. However, I

Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when freeing GPIO

On 09/28/2016 06:38 AM, Stefan Agner wrote: On 2016-09-27 19:00, Viresh Kumar wrote: On 27-09-16, 12:34, Stefan Agner wrote: Added Viresh Kumar to the discussion, he implemented the I2C recovery functions. Yes, reordering the pinctrl/gpio_free calls would fix the problem too. However, I

Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when freeing GPIO

On 09/27/2016 10:34 PM, Stefan Agner wrote: On 2016-09-27 11:17, Vladimir Zapolskiy wrote: Hi Stefan, On 09/27/2016 07:37 PM, Stefan Agner wrote: On 2016-09-27 05:12, Vladimir Zapolskiy wrote: Hi Stefan, On 09/27/2016 03:26 AM, Stefan Agner wrote: If a GPIO gets freed after selecting a new

Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when freeing GPIO

On 09/27/2016 10:34 PM, Stefan Agner wrote: On 2016-09-27 11:17, Vladimir Zapolskiy wrote: Hi Stefan, On 09/27/2016 07:37 PM, Stefan Agner wrote: On 2016-09-27 05:12, Vladimir Zapolskiy wrote: Hi Stefan, On 09/27/2016 03:26 AM, Stefan Agner wrote: If a GPIO gets freed after selecting a new

Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when freeing GPIO

Hi Stefan, On 09/27/2016 07:37 PM, Stefan Agner wrote: On 2016-09-27 05:12, Vladimir Zapolskiy wrote: Hi Stefan, On 09/27/2016 03:26 AM, Stefan Agner wrote: If a GPIO gets freed after selecting a new pinctrl configuration the driver should not change pinctrl anymore. Otherwise

Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when freeing GPIO

Hi Stefan, On 09/27/2016 07:37 PM, Stefan Agner wrote: On 2016-09-27 05:12, Vladimir Zapolskiy wrote: Hi Stefan, On 09/27/2016 03:26 AM, Stefan Agner wrote: If a GPIO gets freed after selecting a new pinctrl configuration the driver should not change pinctrl anymore. Otherwise

Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when freeing GPIO

Hi Stefan, On 09/27/2016 03:26 AM, Stefan Agner wrote: If a GPIO gets freed after selecting a new pinctrl configuration the driver should not change pinctrl anymore. Otherwise this will likely lead to a unusable pin configuration for > the newly selected pinctrl. Signed-off-by: Stefan Agner

Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when freeing GPIO

Hi Stefan, On 09/27/2016 03:26 AM, Stefan Agner wrote: If a GPIO gets freed after selecting a new pinctrl configuration the driver should not change pinctrl anymore. Otherwise this will likely lead to a unusable pin configuration for > the newly selected pinctrl. Signed-off-by: Stefan Agner

Re: [PATCH] clk: nxp: clk-lpc32xx: Unmap region obtained by of_iomap

clk_init(struct device_node > *np) > if (IS_ERR(clk_regmap)) { > pr_err("failed to regmap system control block: %ld\n", > PTR_ERR(clk_regmap)); > + iounmap(base); > return; > } > > A

Re: [PATCH] clk: nxp: clk-lpc32xx: Unmap region obtained by of_iomap

map)) { > pr_err("failed to regmap system control block: %ld\n", > PTR_ERR(clk_regmap)); > + iounmap(base); > return; > } > > Acked-by: Vladimir Zapolskiy Thank you for the patch. -- With best wishes, Vladimir

Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift gpio_mxc_init() to subsys_initcall level'

Hi, On 09/20/2016 03:55 PM, Shawn Guo wrote: On Sun, Sep 18, 2016 at 01:24:42PM +0200, Linus Walleij wrote: On Sun, Sep 18, 2016 at 2:59 AM, Guenter Roeck <li...@roeck-us.net> wrote: On 09/17/2016 05:08 PM, Shawn Guo wrote: Hi Guenter, On Thu, Sep 15, 2016 at 04:35:04PM +0300, Vl

Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift gpio_mxc_init() to subsys_initcall level'

Hi, On 09/20/2016 03:55 PM, Shawn Guo wrote: On Sun, Sep 18, 2016 at 01:24:42PM +0200, Linus Walleij wrote: On Sun, Sep 18, 2016 at 2:59 AM, Guenter Roeck wrote: On 09/17/2016 05:08 PM, Shawn Guo wrote: Hi Guenter, On Thu, Sep 15, 2016 at 04:35:04PM +0300, Vladimir Zapolskiy wrote

[PATCH 00/19] ARM: imx legacy: move peripheral initializations to .init_late

are compilation tested only, probably some of the proposed changes are excessive or may be insufficient. Vladimir Zapolskiy (19): ARM: imx legacy: kzm: move peripheral initialization to .init_late ARM: imx legacy: mx31lite: move peripheral initialization to .init_late ARM: imx legacy: mx31ads

[PATCH 00/19] ARM: imx legacy: move peripheral initializations to .init_late

are compilation tested only, probably some of the proposed changes are excessive or may be insufficient. Vladimir Zapolskiy (19): ARM: imx legacy: kzm: move peripheral initialization to .init_late ARM: imx legacy: mx31lite: move peripheral initialization to .init_late ARM: imx legacy: mx31ads

Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift gpio_mxc_init() to subsys_initcall level'

Hi Linus, On 09/15/2016 04:18 PM, Vladimir Zapolskiy wrote: Hi Linus, On 09/15/2016 03:19 PM, Linus Walleij wrote: On Wed, Sep 14, 2016 at 4:33 PM, Guenter Roeck <li...@roeck-us.net> wrote: On 09/14/2016 12:19 AM, Linus Walleij wrote: On Wed, Sep 14, 2016 at 5:20 AM, Guenter Roe

Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift gpio_mxc_init() to subsys_initcall level'

Hi Linus, On 09/15/2016 04:18 PM, Vladimir Zapolskiy wrote: Hi Linus, On 09/15/2016 03:19 PM, Linus Walleij wrote: On Wed, Sep 14, 2016 at 4:33 PM, Guenter Roeck wrote: On 09/14/2016 12:19 AM, Linus Walleij wrote: On Wed, Sep 14, 2016 at 5:20 AM, Guenter Roeck wrote: So, in other words

Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift gpio_mxc_init() to subsys_initcall level'

Hi Guenter, On 09/14/2016 06:20 AM, Guenter Roeck wrote: Hi Vladimir, your commit e188cbf7564f ("gpio: mxc: shift gpio_mxc_init() to subsys_initcall level") in -next causes the following crash when running the 'kzm' target (and most likely the real thing) with qemu. [1.211426] Unable to

Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift gpio_mxc_init() to subsys_initcall level'

Hi Guenter, On 09/14/2016 06:20 AM, Guenter Roeck wrote: Hi Vladimir, your commit e188cbf7564f ("gpio: mxc: shift gpio_mxc_init() to subsys_initcall level") in -next causes the following crash when running the 'kzm' target (and most likely the real thing) with qemu. [1.211426] Unable to

<    1   2   3   4   5   6   7   8   9   >