Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift gpio_mxc_init() to subsys_initcall level'

2016-09-15 Thread Vladimir Zapolskiy
Hi Linus, On 09/15/2016 03:19 PM, Linus Walleij wrote: On Wed, Sep 14, 2016 at 4:33 PM, Guenter Roeck wrote: On 09/14/2016 12:19 AM, Linus Walleij wrote: On Wed, Sep 14, 2016 at 5:20 AM, Guenter Roeck wrote: So, in other words, lots of bugs here.

Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift gpio_mxc_init() to subsys_initcall level'

2016-09-15 Thread Vladimir Zapolskiy
Hi Linus, On 09/15/2016 03:19 PM, Linus Walleij wrote: On Wed, Sep 14, 2016 at 4:33 PM, Guenter Roeck wrote: On 09/14/2016 12:19 AM, Linus Walleij wrote: On Wed, Sep 14, 2016 at 5:20 AM, Guenter Roeck wrote: So, in other words, lots of bugs here. Nevertheless, I would suggest to keep

Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift gpio_mxc_init() to subsys_initcall level'

2016-09-15 Thread Vladimir Zapolskiy
Hi Linus, Guenter, On 09/14/2016 10:19 AM, Linus Walleij wrote: On Wed, Sep 14, 2016 at 5:20 AM, Guenter Roeck wrote: So, in other words, lots of bugs here. Nevertheless, I would suggest to keep using postcore_initcall(), at least until it is sure that all gpio clients

Re: Crashing 'kzm' target in next-20160913 due to 'gpio: mxc: shift gpio_mxc_init() to subsys_initcall level'

2016-09-15 Thread Vladimir Zapolskiy
Hi Linus, Guenter, On 09/14/2016 10:19 AM, Linus Walleij wrote: On Wed, Sep 14, 2016 at 5:20 AM, Guenter Roeck wrote: So, in other words, lots of bugs here. Nevertheless, I would suggest to keep using postcore_initcall(), at least until it is sure that all gpio clients handle -EPROBE_DEFER

Re: [PATCH v5 1/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM

2016-08-29 Thread Vladimir Zapolskiy
Hi Marcel, On 02/05/2016 06:12 PM, Marcel Ziswiler wrote: From: Petr Štetiar Signed-off-by: Marcel Ziswiler Signed-off-by: Petr Štetiar Reviewed-by: Stefan Agner --- because the change is in mainline now below

Re: [PATCH v5 1/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM

2016-08-29 Thread Vladimir Zapolskiy
Hi Marcel, On 02/05/2016 06:12 PM, Marcel Ziswiler wrote: From: Petr Štetiar Signed-off-by: Marcel Ziswiler Signed-off-by: Petr Štetiar Reviewed-by: Stefan Agner --- because the change is in mainline now below is kind of out of date information, but you may find it helpful. [snip] -

Re: [PATCH v2 5/8] i2c: mux: add support for 'i2c-mux', 'i2c-arb' and 'i2c-gate' DT subnodes

2016-08-15 Thread Vladimir Zapolskiy
Hi Peter, On 08/15/2016 04:40 PM, Peter Rosin wrote: Backwards compatibility is preserved; the subnodes are in practice optional. However, the mux core needs to know what subnode it should examine, so add a couple of new flags for i2c_mux_alloc for this purpose. The rule is that if the mux

Re: [PATCH v2 5/8] i2c: mux: add support for 'i2c-mux', 'i2c-arb' and 'i2c-gate' DT subnodes

2016-08-15 Thread Vladimir Zapolskiy
Hi Peter, On 08/15/2016 04:40 PM, Peter Rosin wrote: Backwards compatibility is preserved; the subnodes are in practice optional. However, the mux core needs to know what subnode it should examine, so add a couple of new flags for i2c_mux_alloc for this purpose. The rule is that if the mux

Re: [PATCH] i2c: don't print error when adding adapter fails

2016-08-09 Thread Vladimir Zapolskiy
t; ret = i2c_add_numbered_adapter(_data->adapter); > - if (ret < 0) { > - dev_err(>dev, "I2C: Failed to add bus\n"); > + if (ret < 0) > goto out_clock; > - } > > dev_dbg(>dev, "%s: Master at %#8x, irq

Re: [PATCH] i2c: don't print error when adding adapter fails

2016-08-09 Thread Vladimir Zapolskiy
er(_data->adapter); > - if (ret < 0) { > - dev_err(>dev, "I2C: Failed to add bus\n"); > + if (ret < 0) > goto out_clock; > - } > > dev_dbg(>dev, "%s: Master at %#8x, irq %d.\n", >

Re: [RFC][PATCH 0/4] SRAM based reboot reason driver for HiKey

2016-08-08 Thread Vladimir Zapolskiy
Hi Rob, On 08/06/2016 01:37 AM, Rob Herring wrote: On Fri, Aug 5, 2016 at 7:46 AM, Vladimir Zapolskiy <vladimir_zapols...@mentor.com> wrote: Hi John, On 08/04/2016 02:05 AM, John Stultz wrote: Now that Andy's reboot reason core driver has landed, I wanted to resubmit a reworked v

Re: [RFC][PATCH 0/4] SRAM based reboot reason driver for HiKey

2016-08-08 Thread Vladimir Zapolskiy
Hi Rob, On 08/06/2016 01:37 AM, Rob Herring wrote: On Fri, Aug 5, 2016 at 7:46 AM, Vladimir Zapolskiy wrote: Hi John, On 08/04/2016 02:05 AM, John Stultz wrote: Now that Andy's reboot reason core driver has landed, I wanted to resubmit a reworked version of my SRAM based reboot reason

Re: [RFC][PATCH 0/4] SRAM based reboot reason driver for HiKey

2016-08-05 Thread Vladimir Zapolskiy
Hi John, On 08/04/2016 02:05 AM, John Stultz wrote: Now that Andy's reboot reason core driver has landed, I wanted to resubmit a reworked version of my SRAM based reboot reason driver. This allows the kernel to communicate to the bootloader what mode it should reboot to using some reserved

Re: [RFC][PATCH 0/4] SRAM based reboot reason driver for HiKey

2016-08-05 Thread Vladimir Zapolskiy
Hi John, On 08/04/2016 02:05 AM, John Stultz wrote: Now that Andy's reboot reason core driver has landed, I wanted to resubmit a reworked version of my SRAM based reboot reason driver. This allows the kernel to communicate to the bootloader what mode it should reboot to using some reserved

Re: [PATCH v3 0/6] watchdog: add watchdog pretimeout framework

2016-06-24 Thread Vladimir Zapolskiy
Hi Wolfram, Guenter, On 24.06.2016 16:45, Guenter Roeck wrote: > On 06/24/2016 02:46 AM, Wolfram Sang wrote: >> On Tue, Jun 07, 2016 at 08:38:41PM +0300, Vladimir Zapolskiy wrote: >>> The change adds a simple watchdog pretimeout framework infrastructure, >>> it

Re: [PATCH v3 0/6] watchdog: add watchdog pretimeout framework

2016-06-24 Thread Vladimir Zapolskiy
Hi Wolfram, Guenter, On 24.06.2016 16:45, Guenter Roeck wrote: > On 06/24/2016 02:46 AM, Wolfram Sang wrote: >> On Tue, Jun 07, 2016 at 08:38:41PM +0300, Vladimir Zapolskiy wrote: >>> The change adds a simple watchdog pretimeout framework infrastructure, >>> it

Re: [PATCH] mfd: intel-lpss: fix compilation issue if PM_SLEEP is not set

2016-06-24 Thread Vladimir Zapolskiy
On 24.06.2016 11:28, Andy Shevchenko wrote: > On Fri, 2016-06-24 at 03:11 +0300, Vladimir Zapolskiy wrote: >> If kernel build configuration has enabled CONFIG_PM and unset >> CONFIG_PM_SLEEP, then intel-lpss-pci.c and intel-lpss-acpi.c can not >> be comp

Re: [PATCH] mfd: intel-lpss: fix compilation issue if PM_SLEEP is not set

2016-06-24 Thread Vladimir Zapolskiy
On 24.06.2016 11:28, Andy Shevchenko wrote: > On Fri, 2016-06-24 at 03:11 +0300, Vladimir Zapolskiy wrote: >> If kernel build configuration has enabled CONFIG_PM and unset >> CONFIG_PM_SLEEP, then intel-lpss-pci.c and intel-lpss-acpi.c can not >> be comp

Re: [PATCH] mfd: intel-lpss: fix compilation issue if PM_SLEEP is not set

2016-06-23 Thread Vladimir Zapolskiy
On 24.06.2016 03:11, Vladimir Zapolskiy wrote: > If kernel build configuration has enabled CONFIG_PM and unset > CONFIG_PM_SLEEP, then intel-lpss-pci.c and intel-lpss-acpi.c can not > be compiled due to a missing INTEL_LPSS_SLEEP_PM_OPS macro > declaration: > > drivers/mfd/int

Re: [PATCH] mfd: intel-lpss: fix compilation issue if PM_SLEEP is not set

2016-06-23 Thread Vladimir Zapolskiy
On 24.06.2016 03:11, Vladimir Zapolskiy wrote: > If kernel build configuration has enabled CONFIG_PM and unset > CONFIG_PM_SLEEP, then intel-lpss-pci.c and intel-lpss-acpi.c can not > be compiled due to a missing INTEL_LPSS_SLEEP_PM_OPS macro > declaration: > > drivers/mfd/int

[PATCH] mfd: intel-lpss: fix compilation issue if PM_SLEEP is not set

2016-06-23 Thread Vladimir Zapolskiy
' drivers/mfd/intel-lpss-pci.c:63:58: error: ‘INTEL_LPSS_SLEEP_PM_OPS’ undeclared here (not in a function) Fixes: d35dbf0dbaa7 ("mfd: Add support for Intel Sunrisepoint LPSS devices") Signed-off-by: Vladimir Zapolskiy <vladimir_zapols...@mentor.com> --- drivers/mfd/intel-lpss.

[PATCH] mfd: intel-lpss: fix compilation issue if PM_SLEEP is not set

2016-06-23 Thread Vladimir Zapolskiy
' drivers/mfd/intel-lpss-pci.c:63:58: error: ‘INTEL_LPSS_SLEEP_PM_OPS’ undeclared here (not in a function) Fixes: d35dbf0dbaa7 ("mfd: Add support for Intel Sunrisepoint LPSS devices") Signed-off-by: Vladimir Zapolskiy --- drivers/mfd/intel-lpss.h | 2 ++ 1 file changed, 2 insertions(+)

Re: [PATCH v3 0/6] watchdog: add watchdog pretimeout framework

2016-06-08 Thread Vladimir Zapolskiy
Hi Wolfram, On 08.06.2016 10:56, Wolfram Sang wrote: > >> Changes from v2 to v3: > > This series was odd to review. I am used to that we build stuff on top > of each other to strive for the best technical solution. I didn't expect > that you like all of my changes, but at least some of them

Re: [PATCH v3 0/6] watchdog: add watchdog pretimeout framework

2016-06-08 Thread Vladimir Zapolskiy
Hi Wolfram, On 08.06.2016 10:56, Wolfram Sang wrote: > >> Changes from v2 to v3: > > This series was odd to review. I am used to that we build stuff on top > of each other to strive for the best technical solution. I didn't expect > that you like all of my changes, but at least some of them

Re: [PATCH v3 4/6] watchdog: add watchdog pretimeout framework

2016-06-08 Thread Vladimir Zapolskiy
On 08.06.2016 16:53, Guenter Roeck wrote: > On 06/08/2016 06:37 AM, Vladimir Zapolskiy wrote: > >>>> >>>> +comment "Watchdog Pretimeout Governors" >>>> + >>>> +config WATCHDOG_PRETIMEOUT_GOV >>>> + bool "Enable

Re: [PATCH v3 4/6] watchdog: add watchdog pretimeout framework

2016-06-08 Thread Vladimir Zapolskiy
On 08.06.2016 16:53, Guenter Roeck wrote: > On 06/08/2016 06:37 AM, Vladimir Zapolskiy wrote: > >>>> >>>> +comment "Watchdog Pretimeout Governors" >>>> + >>>> +config WATCHDOG_PRETIMEOUT_GOV >>>> + bool "Enable

[PATCH] watchdog: drop redundant 'default n' option for WATCHDOG_SYSFS

2016-06-08 Thread Vladimir Zapolskiy
The option 'default n' and its absence are equal for kbuild, which makes explicit 'default n' redundant. Signed-off-by: Vladimir Zapolskiy <vladimir_zapols...@mentor.com> --- drivers/watchdog/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/watchdog/Kconfig b/drivers/wa

[PATCH] watchdog: drop redundant 'default n' option for WATCHDOG_SYSFS

2016-06-08 Thread Vladimir Zapolskiy
The option 'default n' and its absence are equal for kbuild, which makes explicit 'default n' redundant. Signed-off-by: Vladimir Zapolskiy --- drivers/watchdog/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig index b54f26c..8d38cb8

Re: [PATCH v3 6/6] watchdog: pretimeout: add noop pretimeout governor

2016-06-08 Thread Vladimir Zapolskiy
On 08.06.2016 10:10, Wolfram Sang wrote: >> +static void pretimeout_noop(struct watchdog_device *wdd) >> +{ >> +pr_alert("watchdog pretimeout event\n"); >> +} > > My version said which watchdog caused the event, why not adding that? > I will add it. It's a bit sad that a virtual volatile id

Re: [PATCH v3 6/6] watchdog: pretimeout: add noop pretimeout governor

2016-06-08 Thread Vladimir Zapolskiy
On 08.06.2016 10:10, Wolfram Sang wrote: >> +static void pretimeout_noop(struct watchdog_device *wdd) >> +{ >> +pr_alert("watchdog pretimeout event\n"); >> +} > > My version said which watchdog caused the event, why not adding that? > I will add it. It's a bit sad that a virtual volatile id

Re: [PATCH v3 5/6] watchdog: pretimeout: add panic pretimeout governor

2016-06-08 Thread Vladimir Zapolskiy
Hi Wolfram, On 08.06.2016 10:08, Wolfram Sang wrote: > >> +static void pretimeout_panic(struct watchdog_device *wdd) >> +{ >> +panic("panic on watchdog pretimeout event\n"); >> +} > > And here we have the same redundant message again ("panic on") :( I will remove it then. > Did you look

Re: [PATCH v3 5/6] watchdog: pretimeout: add panic pretimeout governor

2016-06-08 Thread Vladimir Zapolskiy
Hi Wolfram, On 08.06.2016 10:08, Wolfram Sang wrote: > >> +static void pretimeout_panic(struct watchdog_device *wdd) >> +{ >> +panic("panic on watchdog pretimeout event\n"); >> +} > > And here we have the same redundant message again ("panic on") :( I will remove it then. > Did you look

Re: [PATCH v3 4/6] watchdog: add watchdog pretimeout framework

2016-06-08 Thread Vladimir Zapolskiy
Hi Wolfram, On 08.06.2016 09:54, Wolfram Sang wrote: > On Tue, Jun 07, 2016 at 08:38:45PM +0300, Vladimir Zapolskiy wrote: >> The change adds a simple watchdog pretimeout framework infrastructure, >> its purpose is to allow users to select a desired handling of watchdog >&

Re: [PATCH v3 4/6] watchdog: add watchdog pretimeout framework

2016-06-08 Thread Vladimir Zapolskiy
Hi Wolfram, On 08.06.2016 09:54, Wolfram Sang wrote: > On Tue, Jun 07, 2016 at 08:38:45PM +0300, Vladimir Zapolskiy wrote: >> The change adds a simple watchdog pretimeout framework infrastructure, >> its purpose is to allow users to select a desired handling of watchdog >&

Re: [PATCH v3 4/6] watchdog: add watchdog pretimeout framework

2016-06-08 Thread Vladimir Zapolskiy
Hi Guenter, On 08.06.2016 00:43, Guenter Roeck wrote: > On Tue, Jun 07, 2016 at 08:38:45PM +0300, Vladimir Zapolskiy wrote: >> The change adds a simple watchdog pretimeout framework infrastructure, >> its purpose is to allow users to select a desired handling of watchdog >&

Re: [PATCH v3 4/6] watchdog: add watchdog pretimeout framework

2016-06-08 Thread Vladimir Zapolskiy
Hi Guenter, On 08.06.2016 00:43, Guenter Roeck wrote: > On Tue, Jun 07, 2016 at 08:38:45PM +0300, Vladimir Zapolskiy wrote: >> The change adds a simple watchdog pretimeout framework infrastructure, >> its purpose is to allow users to select a desired handling of watchdog >&

Re: [PATCH v3 1/6] watchdog: add set_pretimeout interface

2016-06-08 Thread Vladimir Zapolskiy
Hi Wolfram, On 08.06.2016 09:34, Wolfram Sang wrote: > On Tue, Jun 07, 2016 at 08:38:42PM +0300, Vladimir Zapolskiy wrote: >> From: Robin Gong <b38...@freescale.com> >> >> Add set_pretimeout since our watchdog driver has those interfaces and >> obviously, the new

Re: [PATCH v3 1/6] watchdog: add set_pretimeout interface

2016-06-08 Thread Vladimir Zapolskiy
Hi Wolfram, On 08.06.2016 09:34, Wolfram Sang wrote: > On Tue, Jun 07, 2016 at 08:38:42PM +0300, Vladimir Zapolskiy wrote: >> From: Robin Gong >> >> Add set_pretimeout since our watchdog driver has those interfaces and >> obviously, the new common watchdog

[PATCH v3 0/6] watchdog: add watchdog pretimeout framework

2016-06-07 Thread Vladimir Zapolskiy
: add WDIOC_SETPRETIMEOUT and WDIOC_GETPRETIMEOUT Vladimir Zapolskiy (4): watchdog: add pretimeout read-only device attribute to sysfs watchdog: add watchdog pretimeout framework watchdog: pretimeout: add panic pretimeout governor watchdog: pretimeout: add noop pretimeout governor drivers

[PATCH v3 0/6] watchdog: add watchdog pretimeout framework

2016-06-07 Thread Vladimir Zapolskiy
: add WDIOC_SETPRETIMEOUT and WDIOC_GETPRETIMEOUT Vladimir Zapolskiy (4): watchdog: add pretimeout read-only device attribute to sysfs watchdog: add watchdog pretimeout framework watchdog: pretimeout: add panic pretimeout governor watchdog: pretimeout: add noop pretimeout governor drivers

[PATCH v3 3/6] watchdog: add pretimeout read-only device attribute to sysfs

2016-06-07 Thread Vladimir Zapolskiy
The change allows for WDIOF_PRETIMEOUT capable watchdog devices to get a configured pretimeout value over sysfs, the correspondent device attribute name is "pretimeout". Signed-off-by: Vladimir Zapolskiy <vladimir_zapols...@mentor.com> --- Changes from v2 to v3: * none, new chan

[PATCH v3 2/6] watchdog: add WDIOC_SETPRETIMEOUT and WDIOC_GETPRETIMEOUT

2016-06-07 Thread Vladimir Zapolskiy
] Signed-off-by: Vladimir Zapolskiy <vladimir_zapols...@mentor.com> --- Changes from v2 to v3: * none, new change Changes from v1 to v2: * none, new change drivers/watchdog/watchdog_dev.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/drivers/watchdog/watchd

[PATCH v3 3/6] watchdog: add pretimeout read-only device attribute to sysfs

2016-06-07 Thread Vladimir Zapolskiy
The change allows for WDIOF_PRETIMEOUT capable watchdog devices to get a configured pretimeout value over sysfs, the correspondent device attribute name is "pretimeout". Signed-off-by: Vladimir Zapolskiy --- Changes from v2 to v3: * none, new change Changes from v1 to v2: * none,

[PATCH v3 2/6] watchdog: add WDIOC_SETPRETIMEOUT and WDIOC_GETPRETIMEOUT

2016-06-07 Thread Vladimir Zapolskiy
From: Robin Gong Since the watchdog common framework centrialize the IOCTL interfaces of device driver now, the SETPRETIMEOUT and GETPRETIMEOUT need to be added in common code. Signed-off-by: Robin Gong [vzapolskiy: rebased, cleanups] Signed-off-by: Vladimir Zapolskiy --- Changes from v2

[PATCH v3 5/6] watchdog: pretimeout: add panic pretimeout governor

2016-06-07 Thread Vladimir Zapolskiy
Panic watchdog pretimeout governor, on watchdog pretimeout event the kernel shall panic. Signed-off-by: Vladimir Zapolskiy <vladimir_zapols...@mentor.com> --- Changes from v2 to v3: * temporarily removed tristate option, the governor can be built-in only Changes from v1 to v2: * removed

[PATCH v3 5/6] watchdog: pretimeout: add panic pretimeout governor

2016-06-07 Thread Vladimir Zapolskiy
Panic watchdog pretimeout governor, on watchdog pretimeout event the kernel shall panic. Signed-off-by: Vladimir Zapolskiy --- Changes from v2 to v3: * temporarily removed tristate option, the governor can be built-in only Changes from v1 to v2: * removed #ifdef

[PATCH v3 4/6] watchdog: add watchdog pretimeout framework

2016-06-07 Thread Vladimir Zapolskiy
, and such watchdog devices do not require the framework. Signed-off-by: Vladimir Zapolskiy <vladimir_zapols...@mentor.com> --- Changes from v2 to v3: * essentially simplified the implementation due to removal of runtime dynamic selection of watchdog pretimeout governors by a user, this f

[PATCH v3 4/6] watchdog: add watchdog pretimeout framework

2016-06-07 Thread Vladimir Zapolskiy
, and such watchdog devices do not require the framework. Signed-off-by: Vladimir Zapolskiy --- Changes from v2 to v3: * essentially simplified the implementation due to removal of runtime dynamic selection of watchdog pretimeout governors by a user, this feature is supposed to be added later

[PATCH v3 1/6] watchdog: add set_pretimeout interface

2016-06-07 Thread Vladimir Zapolskiy
to describe new interface] Signed-off-by: Vladimir Zapolskiy <vladimir_zapols...@mentor.com> --- Changes from v2 to v3: * none, new change Changes from v1 to v2: * none, new change include/linux/watchdog.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/linux/watchdog

[PATCH v3 1/6] watchdog: add set_pretimeout interface

2016-06-07 Thread Vladimir Zapolskiy
From: Robin Gong Add set_pretimeout since our watchdog driver has those interfaces and obviously, the new common watchdog framework didn't implement this interface. Signed-off-by: Robin Gong [vzapolskiy: rebased, added an inline comment to describe new interface] Signed-off-by: Vladimir

[PATCH v3 6/6] watchdog: pretimeout: add noop pretimeout governor

2016-06-07 Thread Vladimir Zapolskiy
Noop watchdog pretimeout governor, only an informational message is added to the kernel log buffer. Signed-off-by: Vladimir Zapolskiy <vladimir_zapols...@mentor.com> --- Changes from v2 to v3: * temporarily removed tristate option, the governor can be built-in only Changes from v1

[PATCH v3 6/6] watchdog: pretimeout: add noop pretimeout governor

2016-06-07 Thread Vladimir Zapolskiy
Noop watchdog pretimeout governor, only an informational message is added to the kernel log buffer. Signed-off-by: Vladimir Zapolskiy --- Changes from v2 to v3: * temporarily removed tristate option, the governor can be built-in only Changes from v1 to v2: * removed #ifdef

Re: [PATCH] crypto: s5p-sss - Use consistent indentation for variables and members

2016-05-28 Thread Vladimir Zapolskiy
as mixing usage of such indentation and lack of it. >When removing indentation, reorder variables in >reversed-christmas-tree order with first variables being initialized >ones. > > Signed-off-by: Krzysztof Kozlowski <k.kozlow...@samsung.com> it looks like a trivial and nice ch

Re: [PATCH] crypto: s5p-sss - Use consistent indentation for variables and members

2016-05-28 Thread Vladimir Zapolskiy
as mixing usage of such indentation and lack of it. >When removing indentation, reorder variables in >reversed-christmas-tree order with first variables being initialized >ones. > > Signed-off-by: Krzysztof Kozlowski it looks like a trivial and nice change, thank you. Acked-by: Vla

Re: [PATCH] ARM: lpc32xx: fix NR_IRQS confict

2016-05-19 Thread Vladimir Zapolskiy
Hi Arnd, On 19.05.2016 11:35, Arnd Bergmann wrote: > With the change to sparse IRQs, the lpc32xx platform gets a warning about > conflicting macros: > > In file included from arch/arm/mach-lpc32xx/irq.c:31:0: > arch/arm/mach-lpc32xx/include/mach/irqs.h:115:0: warning: "NR_IRQS" redefined >

Re: [PATCH] ARM: lpc32xx: fix NR_IRQS confict

2016-05-19 Thread Vladimir Zapolskiy
Hi Arnd, On 19.05.2016 11:35, Arnd Bergmann wrote: > With the change to sparse IRQs, the lpc32xx platform gets a warning about > conflicting macros: > > In file included from arch/arm/mach-lpc32xx/irq.c:31:0: > arch/arm/mach-lpc32xx/include/mach/irqs.h:115:0: warning: "NR_IRQS" redefined >

Re: [PATCH v1 00/10] *** imx-sdma: misc fix ***

2016-05-16 Thread Vladimir Zapolskiy
Hi Jiada, On 16.05.2016 11:37, Jiada Wang wrote: > this patch set contains the following changes > 1. fix issues in cyclic dma > 2. add support to SYNC DMA termination > 3. avoid system hang, when SDMA channel 0 timeouts > 4. add lock to prevent race condition > > Jiada Wang (10): > dma:

Re: [PATCH v1 00/10] *** imx-sdma: misc fix ***

2016-05-16 Thread Vladimir Zapolskiy
Hi Jiada, On 16.05.2016 11:37, Jiada Wang wrote: > this patch set contains the following changes > 1. fix issues in cyclic dma > 2. add support to SYNC DMA termination > 3. avoid system hang, when SDMA channel 0 timeouts > 4. add lock to prevent race condition > > Jiada Wang (10): > dma:

Re: [PATCH 0/3] MAINTAINERS: add new maintainers of NXP LPC32xx SoC

2016-04-28 Thread Vladimir Zapolskiy
On 29.04.2016 02:14, Arnd Bergmann wrote: > On Friday 29 April 2016 02:10:32 Vladimir Zapolskiy wrote: >> Hi Arnd, >> >> On 27.04.2016 12:39, Arnd Bergmann wrote: >>> On Wednesday 27 April 2016 02:55:16 Vladimir Zapolskiy wrote: >>>> Roland Stigge added

Re: [PATCH 0/3] MAINTAINERS: add new maintainers of NXP LPC32xx SoC

2016-04-28 Thread Vladimir Zapolskiy
On 29.04.2016 02:14, Arnd Bergmann wrote: > On Friday 29 April 2016 02:10:32 Vladimir Zapolskiy wrote: >> Hi Arnd, >> >> On 27.04.2016 12:39, Arnd Bergmann wrote: >>> On Wednesday 27 April 2016 02:55:16 Vladimir Zapolskiy wrote: >>>> Roland Stigge added

Re: [PATCH 0/3] MAINTAINERS: add new maintainers of NXP LPC32xx SoC

2016-04-28 Thread Vladimir Zapolskiy
Hi Arnd, On 27.04.2016 12:39, Arnd Bergmann wrote: > On Wednesday 27 April 2016 02:55:16 Vladimir Zapolskiy wrote: >> Roland Stigge added initial support of NXP LPC32xx SoC series and >> first boards powered by it, but for a while since v3.18-rc1 the >> SoC support is un

Re: [PATCH 0/3] MAINTAINERS: add new maintainers of NXP LPC32xx SoC

2016-04-28 Thread Vladimir Zapolskiy
Hi Arnd, On 27.04.2016 12:39, Arnd Bergmann wrote: > On Wednesday 27 April 2016 02:55:16 Vladimir Zapolskiy wrote: >> Roland Stigge added initial support of NXP LPC32xx SoC series and >> first boards powered by it, but for a while since v3.18-rc1 the >> SoC support is un

[PATCH 1/3] MAINTAINERS: move ARM/NXP LPC32xx record to ARM section

2016-04-26 Thread Vladimir Zapolskiy
while we are here correct the title name to emphasize that the maintenance concerns SoC support in general. Signed-off-by: Vladimir Zapolskiy <v...@mleia.com> --- MAINTAINERS | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 0

[PATCH 0/3] MAINTAINERS: add new maintainers of NXP LPC32xx SoC

2016-04-26 Thread Vladimir Zapolskiy
Roland Stigge added initial support of NXP LPC32xx SoC series and first boards powered by it, but for a while since v3.18-rc1 the SoC support is unmaintained and became stale. Vladimir Zapolskiy and Sylvain Lemieux expressed interest in continuation of NXP LPC32xx maintenance, reflect

[PATCH 2/3] MAINTAINERS: add new maintainers of NXP LPC32xx SoC

2016-04-26 Thread Vladimir Zapolskiy
Roland Stigge added initial support of NXP LPC32xx SoC series and first boards powered by it, but for a while since v3.18-rc1 the SoC support is unmaintained and became stale. Vladimir Zapolskiy and Sylvain Lemieux expressed interest in continuation of NXP LPC32xx maintenance, reflect

[PATCH 1/3] MAINTAINERS: move ARM/NXP LPC32xx record to ARM section

2016-04-26 Thread Vladimir Zapolskiy
while we are here correct the title name to emphasize that the maintenance concerns SoC support in general. Signed-off-by: Vladimir Zapolskiy --- MAINTAINERS | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 03e00c7..233c9bf 100644

[PATCH 0/3] MAINTAINERS: add new maintainers of NXP LPC32xx SoC

2016-04-26 Thread Vladimir Zapolskiy
Roland Stigge added initial support of NXP LPC32xx SoC series and first boards powered by it, but for a while since v3.18-rc1 the SoC support is unmaintained and became stale. Vladimir Zapolskiy and Sylvain Lemieux expressed interest in continuation of NXP LPC32xx maintenance, reflect

[PATCH 2/3] MAINTAINERS: add new maintainers of NXP LPC32xx SoC

2016-04-26 Thread Vladimir Zapolskiy
Roland Stigge added initial support of NXP LPC32xx SoC series and first boards powered by it, but for a while since v3.18-rc1 the SoC support is unmaintained and became stale. Vladimir Zapolskiy and Sylvain Lemieux expressed interest in continuation of NXP LPC32xx maintenance, reflect

[PATCH 3/3] MAINTAINERS: add ARM/NXP LPC32XX SoC specific drivers to the section

2016-04-26 Thread Vladimir Zapolskiy
-by: Vladimir Zapolskiy <v...@mleia.com> --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index e70c5a8..117a3c3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1312,7 +1312,13 @@ M: Sylvain Lemieux <slemieux.t...@gmail.com> L: l

[PATCH 3/3] MAINTAINERS: add ARM/NXP LPC32XX SoC specific drivers to the section

2016-04-26 Thread Vladimir Zapolskiy
-by: Vladimir Zapolskiy --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index e70c5a8..117a3c3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1312,7 +1312,13 @@ M: Sylvain Lemieux L: linux-arm-ker...@lists.infradead.org (moderated for non

Re: [PATCH] i2c: imx: use usleep_range(50,100) instead of udelay(50)

2016-04-26 Thread Vladimir Zapolskiy
4.29%--i2c_imx_trx_complete >|| | |--1.42%--i2c_imx_start <<<<-- >|| | | |--0.71%--usleep_range >|| | | |--0.53%--i2c_imx_bus_busy > > Signed-off-by: Oleksij Rempel <li...@rempel-privat.de> mis

Re: [PATCH] i2c: imx: use usleep_range(50,100) instead of udelay(50)

2016-04-26 Thread Vladimir Zapolskiy
mplete >|| | |--1.42%--i2c_imx_start <<<<-- >|| | | |--0.71%--usleep_range >|| | | |--0.53%--i2c_imx_bus_busy > > Signed-off-by: Oleksij Rempel missing your Signed-off-by. Reviewed-by: Vladimir Zapolskiy

[PATCH] rapidio: fix potential NULL pointer dereference

2016-04-21 Thread Vladimir Zapolskiy
The change fixes improper check for a returned error value by class_create() function, which on error returns ERR_PTR() value, thus the original check always results in a dead code on error path. Signed-off-by: Vladimir Zapolskiy <v...@mleia.com> --- drivers/rapidio/devices/rio_mport_cdev

[PATCH] rapidio: fix potential NULL pointer dereference

2016-04-21 Thread Vladimir Zapolskiy
The change fixes improper check for a returned error value by class_create() function, which on error returns ERR_PTR() value, thus the original check always results in a dead code on error path. Signed-off-by: Vladimir Zapolskiy --- drivers/rapidio/devices/rio_mport_cdev.c | 4 ++-- 1 file

Re: [PATCH 2/2] crypto: s5p-sss - Remove useless hash interrupt handler

2016-04-20 Thread Vladimir Zapolskiy
nterrupt bit. > > Driver does not provide hash functions so it is safe to remove the hash > interrupt related code and to not require the interrupt in Device Tree. > > Signed-off-by: Krzysztof Kozlowski <k.kozlow...@samsung.com> Thank you for the change. Acked-by: V

Re: [PATCH 2/2] crypto: s5p-sss - Remove useless hash interrupt handler

2016-04-20 Thread Vladimir Zapolskiy
nterrupt bit. > > Driver does not provide hash functions so it is safe to remove the hash > interrupt related code and to not require the interrupt in Device Tree. > > Signed-off-by: Krzysztof Kozlowski Thank you for the change. Acked-by: Vladimir Zapolskiy > --- > .../d

Re: [PATCH 1/2] crypto: s5p-sss - Fix use after free of copied input buffer in error path

2016-04-20 Thread Vladimir Zapolskiy
ung.com> I see that Herbert have just applied the changes, but anyway I reviewed them and they are good in my opinion. Acked-by: Vladimir Zapolskiy <v...@mleia.com> > --- > drivers/crypto/s5p-sss.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/cry

Re: [PATCH 1/2] crypto: s5p-sss - Fix use after free of copied input buffer in error path

2016-04-20 Thread Vladimir Zapolskiy
rt have just applied the changes, but anyway I reviewed them and they are good in my opinion. Acked-by: Vladimir Zapolskiy > --- > drivers/crypto/s5p-sss.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c > index 4

Re: [PATCH 1/5] arm/defconfigs: Remove CONFIG_IPV6_PRIVACY

2016-04-20 Thread Vladimir Zapolskiy
Hi Borislav, On 30.03.2016 14:42, Borislav Petkov wrote: > From: Borislav Petkov > > Option is long gone, see > > 5d9efa7ee99e ("ipv6: Remove privacy config option.") > > Signed-off-by: Borislav Petkov > Cc: linux-arm-ker...@lists.infradead.org > --- >

Re: [PATCH 1/5] arm/defconfigs: Remove CONFIG_IPV6_PRIVACY

2016-04-20 Thread Vladimir Zapolskiy
Hi Borislav, On 30.03.2016 14:42, Borislav Petkov wrote: > From: Borislav Petkov > > Option is long gone, see > > 5d9efa7ee99e ("ipv6: Remove privacy config option.") > > Signed-off-by: Borislav Petkov > Cc: linux-arm-ker...@lists.infradead.org > --- > arch/arm/configs/lpc32xx_defconfig |

Re: [PATCH v2] misc: sram: fix check of devm_ioremap*() return value

2016-04-17 Thread Vladimir Zapolskiy
Hi Greg, On 23.03.2016 04:52, Vladimir Zapolskiy wrote: > Both devm_ioremap() and devm_ioremap_wc() functions return either > a pointer to valid iomem region or NULL, check for IS_ERR() is improper > and may result in oops on error path. Now on error -ENOMEM is returned. > > Fixe

Re: [PATCH v2] misc: sram: fix check of devm_ioremap*() return value

2016-04-17 Thread Vladimir Zapolskiy
Hi Greg, On 23.03.2016 04:52, Vladimir Zapolskiy wrote: > Both devm_ioremap() and devm_ioremap_wc() functions return either > a pointer to valid iomem region or NULL, check for IS_ERR() is improper > and may result in oops on error path. Now on error -ENOMEM is returned. > > Fixe

Re: [PATCH] i2c: core: Add missing of_node_put()

2016-04-15 Thread Vladimir Zapolskiy
On 15.04.2016 15:43, Jon Hunter wrote: > for_each_available_child_of_node performs an of_node_get on each > iteration, so of_node_put() must be called on each iteration once > we are finished with the node pointer. This is wrong, embedded of_get_next_available_child() correctly decrements ref

Re: [PATCH] i2c: core: Add missing of_node_put()

2016-04-15 Thread Vladimir Zapolskiy
On 15.04.2016 15:43, Jon Hunter wrote: > for_each_available_child_of_node performs an of_node_get on each > iteration, so of_node_put() must be called on each iteration once > we are finished with the node pointer. This is wrong, embedded of_get_next_available_child() correctly decrements ref

Re: [PATCH v2] ARM: dts: imx6: Add dts for Embest MarS Board

2016-04-12 Thread Vladimir Zapolskiy
Hi Sergio, On 12.04.2016 03:25, Sergio Prado wrote: > Embest MarS Board [1] is a multi-core platform based on Freescale i.MX6 > Cortex-A9 Dual Core, running up to 1GHz with 1 GB of RAM, 4GB of eMMC > and with a 4MB SPI flash. > > [1] http://www.embest-tech.com/shop/star/marsboard.html > >

Re: [PATCH v2] ARM: dts: imx6: Add dts for Embest MarS Board

2016-04-12 Thread Vladimir Zapolskiy
Hi Sergio, On 12.04.2016 03:25, Sergio Prado wrote: > Embest MarS Board [1] is a multi-core platform based on Freescale i.MX6 > Cortex-A9 Dual Core, running up to 1GHz with 1 GB of RAM, 4GB of eMMC > and with a 4MB SPI flash. > > [1] http://www.embest-tech.com/shop/star/marsboard.html > >

Re: [PATCH v2] USB: whci-hcd: add more checks for dma mapping error

2016-03-30 Thread Vladimir Zapolskiy
; in qset_free_std() as suggested by Vladimir Zapolskiy. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov <khoroshi...@ispras.ru> Reviewed-by: Vladimir Zapolskiy <v...@mleia.com> > --- > drivers/usb/ho

Re: [PATCH v2] USB: whci-hcd: add more checks for dma mapping error

2016-03-30 Thread Vladimir Zapolskiy
; in qset_free_std() as suggested by Vladimir Zapolskiy. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov Reviewed-by: Vladimir Zapolskiy > --- > drivers/usb/host/whci/qset.c | 8 ++-- > 1 file changed, 6 insert

[tip:x86/urgent] x86/cpufreq: Remove duplicated TDP MSR macro definitions

2016-03-29 Thread tip-bot for Vladimir Zapolskiy
Commit-ID: 4a6772f514891eaacf26bcb7c2c808c557d23c6f Gitweb: http://git.kernel.org/tip/4a6772f514891eaacf26bcb7c2c808c557d23c6f Author: Vladimir Zapolskiy <vladimir_zapols...@mentor.com> AuthorDate: Sat, 26 Mar 2016 20:47:00 +0200 Committer: Thomas Gleixner <t...@linutronix.de>

[tip:x86/urgent] x86/cpufreq: Remove duplicated TDP MSR macro definitions

2016-03-29 Thread tip-bot for Vladimir Zapolskiy
Commit-ID: 4a6772f514891eaacf26bcb7c2c808c557d23c6f Gitweb: http://git.kernel.org/tip/4a6772f514891eaacf26bcb7c2c808c557d23c6f Author: Vladimir Zapolskiy AuthorDate: Sat, 26 Mar 2016 20:47:00 +0200 Committer: Thomas Gleixner CommitDate: Tue, 29 Mar 2016 11:12:10 +0200 x86/cpufreq

Re: ARC dw-mshc binding compat string

2016-03-28 Thread Vladimir Zapolskiy
Hi, On 28.03.2016 15:50, Marek Vasut wrote: > On 03/28/2016 12:34 PM, Jaehoon Chung wrote: >> Hi, > > Hi, > > [...] > > That said, I would rather prefer to see "snps,dw-mshc" prefix on > description > of an MMC controller found on SoCFPGA series, "altr,socfpga-dw-mshc"

Re: ARC dw-mshc binding compat string

2016-03-28 Thread Vladimir Zapolskiy
Hi, On 28.03.2016 15:50, Marek Vasut wrote: > On 03/28/2016 12:34 PM, Jaehoon Chung wrote: >> Hi, > > Hi, > > [...] > > That said, I would rather prefer to see "snps,dw-mshc" prefix on > description > of an MMC controller found on SoCFPGA series, "altr,socfpga-dw-mshc"

Re: ARC dw-mshc binding compat string

2016-03-26 Thread Vladimir Zapolskiy
On 26.03.2016 21:52, Marek Vasut wrote: > On 03/26/2016 07:16 PM, Vladimir Zapolskiy wrote: >> On 26.03.2016 20:10, Marek Vasut wrote: >>> On 03/26/2016 06:52 PM, Vladimir Zapolskiy wrote: >>>> Hi Marek, >>>> >>>> On 26.03.2016 19:30, Mar

Re: ARC dw-mshc binding compat string

2016-03-26 Thread Vladimir Zapolskiy
On 26.03.2016 21:52, Marek Vasut wrote: > On 03/26/2016 07:16 PM, Vladimir Zapolskiy wrote: >> On 26.03.2016 20:10, Marek Vasut wrote: >>> On 03/26/2016 06:52 PM, Vladimir Zapolskiy wrote: >>>> Hi Marek, >>>> >>>> On 26.03.2016 19:30, Mar

[PATCH] x86: cpufreq: remove duplicated TDP MSR macro definitions

2016-03-26 Thread Vladimir Zapolskiy
The list of CPU model specific registers contains two copies of TDP registers, remove the one, which is out of numerical order in the list. Fixes: 6a35fc2d6c22 ("cpufreq: intel_pstate: get P1 from TAR when available") Signed-off-by: Vladimir Zapolskiy <vladimir_zapols...@mentor.com&g

[PATCH] x86: cpufreq: remove duplicated TDP MSR macro definitions

2016-03-26 Thread Vladimir Zapolskiy
The list of CPU model specific registers contains two copies of TDP registers, remove the one, which is out of numerical order in the list. Fixes: 6a35fc2d6c22 ("cpufreq: intel_pstate: get P1 from TAR when available") Signed-off-by: Vladimir Zapolskiy --- arch/x86/include/asm/msr-i

Re: ARC dw-mshc binding compat string

2016-03-26 Thread Vladimir Zapolskiy
On 26.03.2016 20:10, Marek Vasut wrote: > On 03/26/2016 06:52 PM, Vladimir Zapolskiy wrote: >> Hi Marek, >> >> On 26.03.2016 19:30, Marek Vasut wrote: >>> On 03/26/2016 06:26 PM, Vladimir Zapolskiy wrote: >>>> On 26.03.2016 12:14, Marek Vasut wrote: >

Re: ARC dw-mshc binding compat string

2016-03-26 Thread Vladimir Zapolskiy
On 26.03.2016 20:10, Marek Vasut wrote: > On 03/26/2016 06:52 PM, Vladimir Zapolskiy wrote: >> Hi Marek, >> >> On 26.03.2016 19:30, Marek Vasut wrote: >>> On 03/26/2016 06:26 PM, Vladimir Zapolskiy wrote: >>>> On 26.03.2016 12:14, Marek Vasut wrote: >

Re: ARC dw-mshc binding compat string

2016-03-26 Thread Vladimir Zapolskiy
Hi Marek, On 26.03.2016 19:30, Marek Vasut wrote: > On 03/26/2016 06:26 PM, Vladimir Zapolskiy wrote: >> On 26.03.2016 12:14, Marek Vasut wrote: >>> Hi! >>> >>> I noticed that arch/arc/boot/dts/axs10x_mb.dtsi uses "altr," prefix in >

Re: ARC dw-mshc binding compat string

2016-03-26 Thread Vladimir Zapolskiy
Hi Marek, On 26.03.2016 19:30, Marek Vasut wrote: > On 03/26/2016 06:26 PM, Vladimir Zapolskiy wrote: >> On 26.03.2016 12:14, Marek Vasut wrote: >>> Hi! >>> >>> I noticed that arch/arc/boot/dts/axs10x_mb.dtsi uses "altr," prefix in >

<    1   2   3   4   5   6   7   8   9   >