Re: [PATCH net-next] selftests: net: check jq command is supported

2025-10-13 Thread Wang Liang
在 2025/10/10 22:56, Paolo Abeni 写道: On 10/10/25 5:30 AM, Wang Liang wrote: The jq command is used in vlan_bridge_binding.sh, if it is not supported, the test will spam the following log. # ./vlan_bridge_binding.sh: line 51: jq: command not found # ./vlan_bridge_binding.sh: line 51: jq

[PATCH net-next] vsock: use sizeof(struct sockaddr_storage) instead of magic value

2025-08-11 Thread Wang Liang
CK_ADDR constant"). The comment in vsock_getname() is outdated, use sizeof(struct sockaddr_storage) instead of magic value 128. Signed-off-by: Wang Liang --- net/vmw_vsock/af_vsock.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/net/vmw_vsock/af_vsock.c b/net

Re: [PATCH] VSOCK: fix Integer Overflow in vmci_transport_recv_dgram_cb()

2025-08-05 Thread Wang Liang
在 2025/8/5 12:17, bsdhenrymar...@gmail.com 写道: From: Henry Martin The vulnerability is triggered when processing a malicious VMCI datagram with an extremely large `payload_size` value. The attack path is: 1. Attacker crafts a malicious `vmci_datagram` with `payload_size` set to a value n

Re: [PATCH v1] VSOCK: fix Information Leak in virtio_transport_shutdown()

2025-08-04 Thread Wang Liang
在 2025/8/5 13:10, bsdhenrymar...@gmail.com 写道: From: Henry Martin The `struct virtio_vsock_pkt_info` is declared on the stack but only partially initialized (only `op`, `flags`, and `vsk` are set) The uninitialized fields (including `pkt_len`, `remote_cid`, `remote_port`, etc.) contain resid

Re: [PATCH net] net: check the minimum value of gso size in virtio_net_hdr_to_skb()

2025-07-29 Thread Wang Liang
在 2025/7/25 16:55, Xuan Zhuo 写道: On Thu, 24 Jul 2025 16:30:05 +0800, Wang Liang wrote: When sending a packet with virtio_net_hdr to tun device, if the gso_type in virtio_net_hdr is SKB_GSO_UDP and the gso_size is less than udphdr size, below crash may happen. [ cut here

Re: [PATCH net] net: check the minimum value of gso size in virtio_net_hdr_to_skb()

2025-07-27 Thread Wang Liang
在 2025/7/28 1:15, Willem de Bruijn 写道: Willem de Bruijn wrote: But so the real bug, an skb with 4B in the UDP layer happens before that. An skb_dump in udp_queue_rcv_skb of the GSO skb shows [ 174.151409] skb len=190 headroom=64 headlen=190 tailroom=66 [ 174.151409] mac=(64,14) mac_len=14

Re: [PATCH net] net: check the minimum value of gso size in virtio_net_hdr_to_skb()

2025-07-25 Thread Wang Liang
在 2025/7/24 21:29, Willem de Bruijn 写道: Wang Liang wrote: When sending a packet with virtio_net_hdr to tun device, if the gso_type in virtio_net_hdr is SKB_GSO_UDP and the gso_size is less than udphdr size, below crash may happen. gso_size is the size of the segment payload, excluding the

[PATCH net-next] vsock: remove unnecessary null check in vsock_getname()

2025-07-24 Thread Wang Liang
The local variable 'vm_addr' is always not NULL, no need to check it. Signed-off-by: Wang Liang --- net/vmw_vsock/af_vsock.c | 5 - 1 file changed, 5 deletions(-) diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c index 1053662725f8..fae512594849 100644 --- a/net

[PATCH net] net: check the minimum value of gso size in virtio_net_hdr_to_skb()

2025-07-24 Thread Wang Liang
UDP GRO packet misdirection") Fixes: 3d010c8031e3 ("udp: do not accept non-tunnel GSO skbs landing in a tunnel") Signed-off-by: Wang Liang --- include/linux/virtio_net.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/linux/virtio_net.h b/include/linux/vi

[PATCH net-next v3] net: replace ND_PRINTK with dynamic debug

2025-07-07 Thread Wang Liang
ND_PRINTK with val > 1 only works when the ND_DEBUG was set in compilation phase. Replace it with dynamic debug. Convert ND_PRINTK with val <= 1 to net_{err,warn}_ratelimited, and convert the rest to net_dbg_ratelimited. Suggested-by: Ido Schimmel Signed-off-by: Wang Liang --- v2: - Use d

Re: [PATCH net-next v2] net: replace ND_PRINTK with dynamic debug

2025-07-04 Thread Wang Liang
在 2025/7/5 9:38, Wang Liang 写道: 在 2025/7/5 0:10, Ido Schimmel 写道: On Tue, Jul 01, 2025 at 04:11:14PM +0800, Wang Liang wrote: ND_PRINTK with val > 1 only works when the ND_DEBUG was set in compilation phase. Replace it with dynamic debug. Convert ND_PRINTK with val <= 1 to net_{er

Re: [PATCH net-next v2] net: replace ND_PRINTK with dynamic debug

2025-07-04 Thread Wang Liang
在 2025/7/5 0:10, Ido Schimmel 写道: On Tue, Jul 01, 2025 at 04:11:14PM +0800, Wang Liang wrote: ND_PRINTK with val > 1 only works when the ND_DEBUG was set in compilation phase. Replace it with dynamic debug. Convert ND_PRINTK with val <= 1 to net_{err,warn}_ratelimited, and convert the r

[PATCH net-next v2] net: replace ND_PRINTK with dynamic debug

2025-07-01 Thread Wang Liang
ND_PRINTK with val > 1 only works when the ND_DEBUG was set in compilation phase. Replace it with dynamic debug. Convert ND_PRINTK with val <= 1 to net_{err,warn}_ratelimited, and convert the rest to net_dbg_ratelimited. Suggested-by: Ido Schimmel Signed-off-by: Wang Liang --- Changes

RE: [PATCH v2] Enable SR-IOV instantiation through /sys file

2017-12-11 Thread Wang, Liang-min
> -Original Message- > From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Monday, December 11, 2017 1:13 PM > To: Wang, Liang-min > Cc: Alexander Duyck ; Kirsher, Jeffrey T > ; k...@vger.kernel.org; linux- > p...@vger.kernel.org; linux-kernel@v

RE: [PATCH v2] Enable SR-IOV instantiation through /sys file

2017-12-11 Thread Wang, Liang-min
> -Original Message- > From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Friday, December 08, 2017 6:35 PM > To: Alexander Duyck > Cc: Kirsher, Jeffrey T ; Wang, Liang-min min.w...@intel.com>; k...@vger.kernel.org; linux-...@vger.kernel

RE: [PATCH] Enable SR-IOV instantiation through /sys file

2017-10-31 Thread Wang, Liang-min
> -Original Message- > From: David Woodhouse [mailto:dw...@infradead.org] > Sent: Monday, October 30, 2017 8:39 AM > To: Christoph Hellwig ; Duyck, Alexander H > > Cc: Wang, Liang-min ; > alex.william...@redhat.com; linux-kernel@vger.kernel.org; Kir

RE: [PATCH] Enable SR-IOV instantiation through /sys file

2017-10-27 Thread Wang, Liang-min
> -Original Message- > From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Friday, October 27, 2017 6:19 PM > To: Wang, Liang-min > Cc: Kirsher, Jeffrey T ; k...@vger.kernel.org; > linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; > bhelg

RE: [PATCH] Enable SR-IOV instantiation through /sys file

2017-10-27 Thread Wang, Liang-min
> -Original Message- > From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Tuesday, October 24, 2017 6:07 PM > To: Wang, Liang-min > Cc: Kirsher, Jeffrey T ; k...@vger.kernel.org; > linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; > bhelg

RE: [PATCH] Enable SR-IOV instantiation through /sys file

2017-10-24 Thread Wang, Liang-min
> -Original Message- > From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Tuesday, October 24, 2017 6:07 PM > To: Wang, Liang-min > Cc: Kirsher, Jeffrey T ; k...@vger.kernel.org; > linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; > bhelg

RE: [PATCH] Enable SR-IOV instantiation through /sys file

2017-10-24 Thread Wang, Liang-min
> -Original Message- > From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Tuesday, October 24, 2017 5:44 PM > To: Kirsher, Jeffrey T > Cc: Wang, Liang-min ; k...@vger.kernel.org; > linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; > bhelg...@google.co