free_cpumask_var(cfd->cpumask);
> return notifier_from_errno(-ENOMEM);
> }
> --
> 1.7.7.6
Acked-by: Wang YanQing
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Mon, Jul 08, 2013 at 04:50:24PM +0800, Chen Gang wrote:
> When failure occurs in hotplug_cfd(), need release related resources,
> or will cause memory leak.
>
> Also beautify the related code.
>
> Signed-off-by: Chen Gang
> ---
> kernel/smp.c | 13 +
> 1 files changed, 9
On Mon, Jul 08, 2013 at 04:50:24PM +0800, Chen Gang wrote:
When failure occurs in hotplug_cfd(), need release related resources,
or will cause memory leak.
Also beautify the related code.
Signed-off-by: Chen Gang gang.c...@asianux.com
---
kernel/smp.c | 13 +
1 files
);
}
--
1.7.7.6
Acked-by: Wang YanQing udkni...@gmail.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org
On Sun, Jul 07, 2013 at 09:53:48PM +0530, Preeti U Murthy wrote:
> > "
> > /*
> >
> > * Unlocked CSDs are valid through generic_exec_single():
> >
> > */
>
On Sun, Jul 07, 2013 at 09:53:48PM +0530, Preeti U Murthy wrote:
/*
* Unlocked CSDs are valid through generic_exec_single():
*/
I don't
On Fri, Jul 05, 2013 at 04:37:14PM +0200, Thomas Gleixner wrote:
> Hmm, even there it matters, because of the following scenario:
>
> CPU 0
> smp_call_function_single(CPU 1)
> csd_lock(CPU 1)
No, smpl_call_function_single(CPU 1)
will csd_lock(CPU 0), not csd_lock(CPU 1)
> irq_enter()
>
On Fri, Jul 05, 2013 at 03:50:57PM +0200, Thomas Gleixner wrote:
> On Sat, 16 Feb 2013, Chuansheng Liu wrote:
> > There is a real case for softirq DEADLOCK case:
> >
> > CPUACPUB
> > spin_lock()
> > Any
On Sat, Jul 06, 2013 at 01:36:27PM +0530, Preeti U Murthy wrote:
> Ideally it should be under a WARN_ON(). csd_unlock() has that WARN_ON().
> Unlocking a parameter which is not locked should be seen as a bug, which
> the above code is not doing. In fact it avoids it being reported as a bug.
On Fri, Jul 05, 2013 at 09:57:11PM +0530, Preeti U Murthy wrote:
> Elaborate on when deadlocks can occur when a call is made to
> smp_call_function_single() and its friends. This avoids ambiguity about
> when to use these calls.
>
> Signed-off-by: Preeti U Murthy
> Cc: Peter Zijlstra
> Cc: Ingo
On Sat, Jul 06, 2013 at 10:59:39AM +0530, Preeti U Murthy wrote:
> Hi Wang,
>
> On 07/06/2013 08:43 AM, Wang YanQing wrote:
> > On Fri, Jul 05, 2013 at 09:57:01PM +0530, Preeti U Murthy wrote:
> >> cfd->cpumask_ipi is used only in smp_call_function_many().The existing
On Sat, Jul 06, 2013 at 10:59:39AM +0530, Preeti U Murthy wrote:
Hi Wang,
On 07/06/2013 08:43 AM, Wang YanQing wrote:
On Fri, Jul 05, 2013 at 09:57:01PM +0530, Preeti U Murthy wrote:
cfd-cpumask_ipi is used only in smp_call_function_many().The existing
comment around it says
On Fri, Jul 05, 2013 at 09:57:11PM +0530, Preeti U Murthy wrote:
Elaborate on when deadlocks can occur when a call is made to
smp_call_function_single() and its friends. This avoids ambiguity about
when to use these calls.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
Cc: Peter
On Sat, Jul 06, 2013 at 01:36:27PM +0530, Preeti U Murthy wrote:
Ideally it should be under a WARN_ON(). csd_unlock() has that WARN_ON().
Unlocking a parameter which is not locked should be seen as a bug, which
the above code is not doing. In fact it avoids it being reported as a bug.
Although
On Fri, Jul 05, 2013 at 03:50:57PM +0200, Thomas Gleixner wrote:
On Sat, 16 Feb 2013, Chuansheng Liu wrote:
There is a real case for softirq DEADLOCK case:
CPUACPUB
spin_lock(spinlock)
Any irq
On Fri, Jul 05, 2013 at 04:37:14PM +0200, Thomas Gleixner wrote:
Hmm, even there it matters, because of the following scenario:
CPU 0
smp_call_function_single(CPU 1)
csd_lock(CPU 1)
No, smpl_call_function_single(CPU 1)
will csd_lock(CPU 0), not csd_lock(CPU 1)
irq_enter()
On Fri, Jul 05, 2013 at 09:57:21PM +0530, Preeti U Murthy wrote:
> call_single_data is always locked by all callers of
> arch_send_call_function_single_ipi() or
> arch_send_call_function_ipi_mask() which results in execution of
> generic_call_function_interrupt() handler.
>
> Hence remove the
On Fri, Jul 05, 2013 at 09:57:01PM +0530, Preeti U Murthy wrote:
> cfd->cpumask_ipi is used only in smp_call_function_many().The existing
> comment around it says that this additional mask is used because
> cfd->cpumask can get overwritten.
>
> There is no reason why the cfd->cpumask can be
Commit-ID: 237d1548543312fcc8c99d302ab68fbf8ef6f97f
Gitweb: http://git.kernel.org/tip/237d1548543312fcc8c99d302ab68fbf8ef6f97f
Author: Wang YanQing
AuthorDate: Fri, 28 Jun 2013 22:45:16 +0800
Committer: H. Peter Anvin
CommitDate: Fri, 28 Jun 2013 15:27:29 -0700
x86: Fix override
Commit-ID: 237d1548543312fcc8c99d302ab68fbf8ef6f97f
Gitweb: http://git.kernel.org/tip/237d1548543312fcc8c99d302ab68fbf8ef6f97f
Author: Wang YanQing udkni...@gmail.com
AuthorDate: Fri, 28 Jun 2013 22:45:16 +0800
Committer: H. Peter Anvin h...@linux.intel.com
CommitDate: Fri, 28 Jun 2013
On Fri, Jul 05, 2013 at 09:57:01PM +0530, Preeti U Murthy wrote:
cfd-cpumask_ipi is used only in smp_call_function_many().The existing
comment around it says that this additional mask is used because
cfd-cpumask can get overwritten.
There is no reason why the cfd-cpumask can be overwritten,
On Fri, Jul 05, 2013 at 09:57:21PM +0530, Preeti U Murthy wrote:
call_single_data is always locked by all callers of
arch_send_call_function_single_ipi() or
arch_send_call_function_ipi_mask() which results in execution of
generic_call_function_interrupt() handler.
Hence remove the check for
On Mon, Jul 01, 2013 at 12:14:45PM -0400, Joseph Salisbury wrote:
> Hi Wang,
>
> A bug was opened against the Ubuntu kernel[0]. After a kernel bisect,
> it was found that reverting the following commit resolved this bug:
>
> commit 8d2f8cd424ca0b99001f3ff4f5db87c4e525f366
>
On Mon, Jul 01, 2013 at 12:14:45PM -0400, Joseph Salisbury wrote:
Hi Wang,
A bug was opened against the Ubuntu kernel[0]. After a kernel bisect,
it was found that reverting the following commit resolved this bug:
commit 8d2f8cd424ca0b99001f3ff4f5db87c4e525f366
Author: Wang YanQing udkni
We should set X86 to 486 before use cpuid
to detect the cpu type, if we set X86 to 486
after cpuid, then we will get 486 until
cpu_detect runs.
Signed-off-by: Wang YanQing
---
ChangeLog
v1-v2:
1:Use more accurate and short commit log
arch/x86/kernel/head_32.S | 2 +-
1 file changed, 1
We should set X86 to 486 before use cpuid
to detect the cpu type, if we set X86 to 486
after cpuid, then we will get 486 until
cpu_detect runs.
Signed-off-by: Wang YanQing udkni...@gmail.com
---
ChangeLog
v1-v2:
1:Use more accurate and short commit log
arch/x86/kernel/head_32.S | 2 +-
1 file
On Thu, Jun 27, 2013 at 12:54:35PM +0200, Borislav Petkov wrote:
> On Thu, Jun 27, 2013 at 12:26:40AM +0800, Wang YanQing wrote:
> >
> > We should set X86 to 486 before use cpuid
> > to detect the cpu type, if we set X86 to 486
> > after cpuid, then we will get 486 for
On Thu, Jun 27, 2013 at 12:54:35PM +0200, Borislav Petkov wrote:
On Thu, Jun 27, 2013 at 12:26:40AM +0800, Wang YanQing wrote:
We should set X86 to 486 before use cpuid
to detect the cpu type, if we set X86 to 486
after cpuid, then we will get 486 for ever.
So not for ever but until
will over write all the information
in early_cpu_init, and before early_cpu_init,
there is no user of new_cpu_data, but this is
another patch in the future.
Signed-off-by: Wang YanQing
---
arch/x86/kernel/head_32.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel
will over write all the information
in early_cpu_init, and before early_cpu_init,
there is no user of new_cpu_data, but this is
another patch in the future.
Signed-off-by: Wang YanQing udkni...@gmail.com
---
arch/x86/kernel/head_32.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
changelog
> * Add a comment above the block of new definitions ]
>
> Signed-off-by: Sedat Dilek
Acked-by: Wang YanQing
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at
-off-by: Sedat Dilek sedat.di...@gmail.com
Acked-by: Wang YanQing udkni...@gmail.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ
On Wed, Jun 12, 2013 at 10:29:17AM -0700, Yinghai Lu wrote:
> On Wed, Jun 12, 2013 at 9:08 AM, Wang YanQing wrote:
> >
> > This patch convert __init to __init_memblock
> > for functions which make reference to memblock variable
> > with attribute __meminitdata.
>
&
This patch convert __init to __init_memblock
for functions which make reference to memblock variable
with attribute __meminitdata.
Signed-off-by: Wang YanQing
---
mm/memblock.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/mm/memblock.c b/mm
This patch convert __init to __init_memblock
for functions which make reference to memblock variable
with attribute __meminitdata.
Signed-off-by: Wang YanQing udkni...@gmail.com
---
mm/memblock.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/mm
On Wed, Jun 12, 2013 at 10:29:17AM -0700, Yinghai Lu wrote:
On Wed, Jun 12, 2013 at 9:08 AM, Wang YanQing udkni...@gmail.com wrote:
This patch convert __init to __init_memblock
for functions which make reference to memblock variable
with attribute __meminitdata.
for which arch?
I just
can get better performance,
this patch add support to do merge directly in memblock_insert_region.
Signed-off-by: Wang YanQing
---
mm/memblock.c | 87 +--
1 file changed, 42 insertions(+), 45 deletions(-)
diff --git a/mm/memblock.c b/mm
can get better performance,
this patch add support to do merge directly in memblock_insert_region.
Signed-off-by: Wang YanQing udkni...@gmail.com
---
mm/memblock.c | 87 +--
1 file changed, 42 insertions(+), 45 deletions(-)
diff --git a/mm
On Thu, Jun 06, 2013 at 01:47:46PM +0200, Pavel Machek wrote:
> On Thu 2013-06-06 09:23:13, Wang YanQing wrote:
> > On Tue, Jun 04, 2013 at 10:13:18PM +0200, Pavel Machek wrote:
> > > On Tue 2013-05-21 13:15:12, Wang YanQing wrote:
> > > > Impact:
> > > &
On Thu, Jun 06, 2013 at 01:47:46PM +0200, Pavel Machek wrote:
On Thu 2013-06-06 09:23:13, Wang YanQing wrote:
On Tue, Jun 04, 2013 at 10:13:18PM +0200, Pavel Machek wrote:
On Tue 2013-05-21 13:15:12, Wang YanQing wrote:
Impact:
1:convert all remain take_over_console
On Tue, Jun 04, 2013 at 10:13:18PM +0200, Pavel Machek wrote:
> On Tue 2013-05-21 13:15:12, Wang YanQing wrote:
> > Impact:
> > 1:convert all remain take_over_console to do_take_over_console
>
> This is step backwards.
What is step backwards? do_take_over_console appear MUCH
On Tue, Jun 04, 2013 at 10:13:18PM +0200, Pavel Machek wrote:
On Tue 2013-05-21 13:15:12, Wang YanQing wrote:
Impact:
1:convert all remain take_over_console to do_take_over_console
This is step backwards.
What is step backwards? do_take_over_console appear MUCH MUCH later in kernel
than
On Thu, May 30, 2013 at 09:18:43AM +0800, Chen Gang wrote:
>
> 'boot_args' is an input args, and 'boot_command_line' has a fix length.
>
> So need use strlcpy() instead of strcpy() to avoid memory overflow.
>
>
> Signed-off-by: Chen Gang
> ---
> arch/parisc/kernel/setup.c |3 ++-
> 1
On Thu, May 30, 2013 at 09:18:43AM +0800, Chen Gang wrote:
'boot_args' is an input args, and 'boot_command_line' has a fix length.
So need use strlcpy() instead of strcpy() to avoid memory overflow.
Signed-off-by: Chen Gang gang.c...@asianux.com
---
arch/parisc/kernel/setup.c |3
write fop, and don't implement read fop.
So the 0200 is more reasonable file mode for free_buffer than
the current file mode 0644.
Signed-off-by: Wang YanQing
---
kernel/trace/trace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
write fop, and don't implement read fop.
So the 0200 is more reasonable file mode for free_buffer than
the current file mode 0644.
Signed-off-by: Wang YanQing udkni...@gmail.com
---
kernel/trace/trace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/trace.c b
On Wed, May 22, 2013 at 12:18:49AM +0800, Wang YanQing wrote:
> > Except now you're spreading the brokenness that is console_lock()
> > over many more source files than the single-use case of
> > do_take_over_console().
>
> > The actual interface is take_over_
On Tue, May 21, 2013 at 11:48:58AM -0400, Peter Hurley wrote:
> On 05/21/2013 10:42 AM, Wang YanQing wrote:
> > On Tue, May 21, 2013 at 09:10:33AM -0400, Peter Hurley wrote:
> >> I would rather revert dc9641895abb which purported to delete
> >> _unneeded_ function
|do_bind_con_driver.
This patch also fix a place include wrong description about give_up_console.
Signed-off-by: Wang YanQing
---
Documentation/console/console.txt | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/Documentation/console/console.txt
On Tue, May 21, 2013 at 09:10:33AM -0400, Peter Hurley wrote:
> I would rather revert dc9641895abb which purported to delete
> _unneeded_ functions than have this. Obviously the functions
> were needed.
>
Hi Peter, this series patches' goal is to reduce codes'
redundance and function
On Tue, May 21, 2013 at 09:10:33AM -0400, Peter Hurley wrote:
I would rather revert dc9641895abb which purported to delete
_unneeded_ functions than have this. Obviously the functions
were needed.
Hi Peter, this series patches' goal is to reduce codes'
redundance and function duplication.
|do_bind_con_driver.
This patch also fix a place include wrong description about give_up_console.
Signed-off-by: Wang YanQing udkni...@gmail.com
---
Documentation/console/console.txt | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/Documentation
On Tue, May 21, 2013 at 11:48:58AM -0400, Peter Hurley wrote:
On 05/21/2013 10:42 AM, Wang YanQing wrote:
On Tue, May 21, 2013 at 09:10:33AM -0400, Peter Hurley wrote:
I would rather revert dc9641895abb which purported to delete
_unneeded_ functions than have this. Obviously the functions
On Wed, May 22, 2013 at 12:18:49AM +0800, Wang YanQing wrote:
Except now you're spreading the brokenness that is console_lock()
over many more source files than the single-use case of
do_take_over_console().
The actual interface is take_over_console(); the _workaround_ is
exposing
ert remain take_over_console's users to new API
do_take_over_console, this patch fix it.
Signed-off-by: Wang YanQing
---
Sorry for my mistake, I believe I do the full
kernel source find|grep, but the reality is I
forget take_over_console.
I will send the patch to update DOC tonight.
arch/alpha/kernel
On Mon, May 20, 2013 at 12:27:37PM -0700, Greg KH wrote:
> Can you also send a patch fixing up the documentation to use the new
> functions as well?
>
Yes, I will do it.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
On Mon, May 20, 2013 at 12:27:37PM -0700, Greg KH wrote:
Can you also send a patch fixing up the documentation to use the new
functions as well?
Yes, I will do it.
Thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to
users to new API
do_take_over_console, this patch fix it.
Signed-off-by: Wang YanQing udkni...@gmail.com
---
Sorry for my mistake, I believe I do the full
kernel source find|grep, but the reality is I
forget take_over_console.
I will send the patch to update DOC tonight.
arch/alpha/kernel
On Thu, May 09, 2013 at 06:12:17PM +0200, Yann E. MORIN wrote:
> Wang, All,
>
> On Thu, May 09, 2013 at 11:27:31PM +0800, Wang YanQing wrote:
> > On Mon, May 06, 2013 at 11:15:31PM +0200, Yann E. MORIN wrote:
> > > From: "Yann E. MORIN"
> > >
> >
On Mon, May 06, 2013 at 11:15:31PM +0200, Yann E. MORIN wrote:
> From: "Yann E. MORIN"
>
> When searching for symbols, return the symbols sorted by relevance.
>
> Sorting is done as thus:
> - first, symbols with a prompt, [1]
> - then, smallest offset, [2]
> - then, shortest
ttp://bugs.debian.org/cgi-bin/bugreport.cgi?bug=465823
Signed-off-by: Wang YanQing
---
Changes v1-v2:
1: move the fix into n_tty_set_termios instead of change TCXONC's behavior
suggested by Peter Hurley
2: rewrite some ChangeLog and use more reasonable subject.
Changes v2-v3:
1: Fix potent
://bugs.debian.org/cgi-bin/bugreport.cgi?bug=465823
Signed-off-by: Wang YanQing udkni...@gmail.com
---
Changes v1-v2:
1: move the fix into n_tty_set_termios instead of change TCXONC's behavior
suggested by Peter Hurley
2: rewrite some ChangeLog and use more reasonable subject.
Changes v2-v3:
1
On Mon, May 06, 2013 at 11:15:31PM +0200, Yann E. MORIN wrote:
From: Yann E. MORIN yann.morin.1...@free.fr
When searching for symbols, return the symbols sorted by relevance.
Sorting is done as thus:
- first, symbols with a prompt, [1]
- then, smallest offset, [2]
-
On Thu, May 09, 2013 at 06:12:17PM +0200, Yann E. MORIN wrote:
Wang, All,
On Thu, May 09, 2013 at 11:27:31PM +0800, Wang YanQing wrote:
On Mon, May 06, 2013 at 11:15:31PM +0200, Yann E. MORIN wrote:
From: Yann E. MORIN yann.morin.1...@free.fr
When searching for symbols, return
ttp://bugs.debian.org/cgi-bin/bugreport.cgi?bug=465823
Signed-off-by: Wang YanQing
---
Changes v1-v2:
1: move the fix into n_tty_set_termios instead of change TCXONC's behavior
suggested by Peter Hurley
2: rewrite some ChangeLog and use more reasonable subject.
drivers/tty/n_tty.c
On Wed, May 08, 2013 at 02:32:23PM -0400, Peter Hurley wrote:
> Perhaps you misunderstood. The snippet above does indeed restart
> a tty which has been stopped via STOP_CHAR(tty) and the termios
> IXON flag cleared.
Thanks Peter, I get your meaning, and I think your suggestion
is right, not only
Now there is no place use unbind_con_driver,
and we can achieve unbind_con_driver's function
with do_unbind_con_driver easily, so just delete
it to reduce code size and duplication.
Signed-off-by: Wang YanQing
---
drivers/tty/vt/vt.c | 28
include/linux
Now there is no place use unregister_con_driver,
and we can achieve unregister_con_driver's function
with unregister_con_driver easily, so just delete it
to reduce code size and duplication.
Signed-off-by: Wang YanQing
---
drivers/tty/vt/vt.c | 13 +
include/linux/console.h | 1
There are only two place use unregister_con_driver now, this patch
convert them to do_unregister_con_driver too, then we can delete
unregister_con_driver whos function can be achieved with
do_unregister_con_driver
easily to reduce code size and duplication.
Signed-off-by: Wang YanQing
Now there is no place use bind_con_driver,
and do_bind_con_driver can achieve bind_con_driver's
function easily, so just delete it to reduce code size and
duplication.
Signed-off-by: Wang YanQing
---
drivers/tty/vt/vt.c | 11 ---
1 file changed, 11 deletions(-)
diff --git a/drivers/tty
There is only one place use unbind_con_driver, this patch
convert it to do_unbind_con_driver too, then we can delete
unbind_con_driver to reduce code size and duplication.
Signed-off-by: Wang YanQing
---
drivers/tty/vt/vt.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff
There is only one place use bind_con_driver now, this patch
convert it to do_bind_con_driver too, then we can delete
bind_con_driver whos function can be replaced by do_bind_con_driver
easily to reduce code size and duplication.
Signed-off-by: Wang YanQing
---
drivers/tty/vt/vt.c | 7 +--
1
Now there is no place use fbcon_takeover, and
fbcon_takeover has huge duplication code with
do_fbcon_takeover, we can achieve fbcon_takeover's
function with do_fbcon_takeover easily, so we
can just delete it.
Signed-off-by: Wang YanQing
---
drivers/video/console/fbcon.c | 28
Now there is no place use register_con_driver|take_over_console,
and we can achieve their function with do_register_con_driver|
do_take_over_console easily, so just delete them to reduce code duplication.
Signed-off-by: Wang YanQing
---
drivers/tty/vt/vt.c | 45
and duplication.
Signed-off-by: Wang YanQing
---
drivers/video/console/fbcon.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
index 3cd6759..1660644 100644
--- a/drivers/video/console/fbcon.c
+++ b/drivers/video
After commit 50e244cc793d511b86adea24972f3a7264cae114
(fb: rework locking to fix lock ordering on takeover)
and
commit e93a9a868792ad71cdd09d75e5a02d8067473c4e
(fb: Yet another band-aid for fixing lockdep mess)
We have two version functions implement almost the same function,
On Wed, May 08, 2013 at 11:18:07AM -0400, Peter Hurley wrote:
> On 05/08/2013 09:16 AM, Wang YanQing wrote:
> > On Tue, May 07, 2013 at 07:02:00PM -0700, Greg KH wrote:
> >> What about Peter's comments on this patch?
> >>
> > Peter's comments will import poli
On Tue, May 07, 2013 at 07:02:00PM -0700, Greg KH wrote:
> What about Peter's comments on this patch?
>
Peter's comments will import policy,
I means we should let userspace to decide whether
and when to restart tty with the mechanism of TCXONC
instead of restart tty accidental when make
On Tue, May 07, 2013 at 07:02:00PM -0700, Greg KH wrote:
What about Peter's comments on this patch?
Peter's comments will import policy,
I means we should let userspace to decide whether
and when to restart tty with the mechanism of TCXONC
instead of restart tty accidental when make
On Wed, May 08, 2013 at 11:18:07AM -0400, Peter Hurley wrote:
On 05/08/2013 09:16 AM, Wang YanQing wrote:
On Tue, May 07, 2013 at 07:02:00PM -0700, Greg KH wrote:
What about Peter's comments on this patch?
Peter's comments will import policy,
I means we should let userspace to decide
After commit 50e244cc793d511b86adea24972f3a7264cae114
(fb: rework locking to fix lock ordering on takeover)
and
commit e93a9a868792ad71cdd09d75e5a02d8067473c4e
(fb: Yet another band-aid for fixing lockdep mess)
We have two version functions implement almost the same function,
and duplication.
Signed-off-by: Wang YanQing udkni...@gmail.com
---
drivers/video/console/fbcon.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
index 3cd6759..1660644 100644
--- a/drivers/video/console/fbcon.c
Now there is no place use fbcon_takeover, and
fbcon_takeover has huge duplication code with
do_fbcon_takeover, we can achieve fbcon_takeover's
function with do_fbcon_takeover easily, so we
can just delete it.
Signed-off-by: Wang YanQing udkni...@gmail.com
---
drivers/video/console/fbcon.c | 28
Now there is no place use register_con_driver|take_over_console,
and we can achieve their function with do_register_con_driver|
do_take_over_console easily, so just delete them to reduce code duplication.
Signed-off-by: Wang YanQing udkni...@gmail.com
---
drivers/tty/vt/vt.c | 45
There is only one place use unbind_con_driver, this patch
convert it to do_unbind_con_driver too, then we can delete
unbind_con_driver to reduce code size and duplication.
Signed-off-by: Wang YanQing udkni...@gmail.com
---
drivers/tty/vt/vt.c | 7 +--
1 file changed, 5 insertions(+), 2
There is only one place use bind_con_driver now, this patch
convert it to do_bind_con_driver too, then we can delete
bind_con_driver whos function can be replaced by do_bind_con_driver
easily to reduce code size and duplication.
Signed-off-by: Wang YanQing udkni...@gmail.com
---
drivers/tty/vt
Now there is no place use bind_con_driver,
and do_bind_con_driver can achieve bind_con_driver's
function easily, so just delete it to reduce code size and
duplication.
Signed-off-by: Wang YanQing udkni...@gmail.com
---
drivers/tty/vt/vt.c | 11 ---
1 file changed, 11 deletions(-)
diff
There are only two place use unregister_con_driver now, this patch
convert them to do_unregister_con_driver too, then we can delete
unregister_con_driver whos function can be achieved with
do_unregister_con_driver
easily to reduce code size and duplication.
Signed-off-by: Wang YanQing udkni
Now there is no place use unregister_con_driver,
and we can achieve unregister_con_driver's function
with unregister_con_driver easily, so just delete it
to reduce code size and duplication.
Signed-off-by: Wang YanQing udkni...@gmail.com
---
drivers/tty/vt/vt.c | 13 +
include
Now there is no place use unbind_con_driver,
and we can achieve unbind_con_driver's function
with do_unbind_con_driver easily, so just delete
it to reduce code size and duplication.
Signed-off-by: Wang YanQing udkni...@gmail.com
---
drivers/tty/vt/vt.c | 28
On Wed, May 08, 2013 at 02:32:23PM -0400, Peter Hurley wrote:
Perhaps you misunderstood. The snippet above does indeed restart
a tty which has been stopped via STOP_CHAR(tty) and the termios
IXON flag cleared.
Thanks Peter, I get your meaning, and I think your suggestion
is right, not only
://bugs.debian.org/cgi-bin/bugreport.cgi?bug=465823
Signed-off-by: Wang YanQing udkni...@gmail.com
---
Changes v1-v2:
1: move the fix into n_tty_set_termios instead of change TCXONC's behavior
suggested by Peter Hurley
2: rewrite some ChangeLog and use more reasonable subject.
drivers/tty
On Tue, May 07, 2013 at 04:50:05PM -0400, Peter Hurley wrote:
> This should be fixed in n_tty_set_termios() instead of fixing userspace
> workarounds.
Sorry, I misuse the word "workaround", emacs just do the right thing I think.
But your suggestion maybe import policy.
> The problem occurs when
On Tue, May 07, 2013 at 11:58:00AM -0700, Greg KH wrote:
> On Wed, May 08, 2013 at 02:47:34AM +0800, Wang YanQing wrote:
> > The reason is before emacs takeover control the tty,
> > we use CTRL-S to XOFF it. Then when emacs takeover the
> > control, it may don't use the flow-c
w bug report:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=465823
Signed-off-by: Wang YanQing
---
drivers/tty/tty_ioctl.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/tty_ioctl.c b/drivers/tty/tty_ioctl.c
index e4455e0..42e08e5 100644
--- a/drivers/tty/tty_ioc
report:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=465823
Signed-off-by: Wang YanQing udkni...@gmail.com
---
drivers/tty/tty_ioctl.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/tty_ioctl.c b/drivers/tty/tty_ioctl.c
index e4455e0..42e08e5 100644
On Tue, May 07, 2013 at 11:58:00AM -0700, Greg KH wrote:
On Wed, May 08, 2013 at 02:47:34AM +0800, Wang YanQing wrote:
The reason is before emacs takeover control the tty,
we use CTRL-S to XOFF it. Then when emacs takeover the
control, it may don't use the flow-control, so emacs hang
event in azx_probe.
This will cause Oops due dereference NULL pointer. I meet it, good luck:)
Signed-off-by: Wang YanQing
---
sound/pci/hda/hda_codec.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c
index 622f726..9c76752 100644
--- a/sou
On Mon, May 06, 2013 at 05:28:32PM +0200, Jean Delvare wrote:
> Le Monday 06 May 2013 à 15:02 +0200, Yann E. MORIN a écrit :
> > From: "Yann E. MORIN"
> >
> > When searching for symbols, return the symbols sorted by relevance.
> >
> > Relevance is the ratio of the length of the matched string
On Mon, Apr 15, 2013 at 07:47:38PM -0700, Yinghai Lu wrote:
> On Mon, Apr 15, 2013 at 6:44 PM, Wang YanQing wrote:
> >
> > The parameter of memblock_reserve is start address,
> > and size, not address range.
> >
> > Signed-off-by: Wang YanQing
> > ---
>
301 - 400 of 529 matches
Mail list logo
