Re: [PATCH v3 1/2] Documentation: bindings: add dt doc for Rockchip PCIe controller

在 2016/6/16 15:00, Arnd Bergmann 写道: On Thursday, June 16, 2016 9:50:21 AM CEST Shawn Lin wrote: + reset-names = "core", "mgmt", "mgmt-sticky", "pipe"; + phys = <&pcie_phy>; + phy-names = "pcie-phy"; + pinctrl-names = "default"; + pinctrl-0 = <&pcie_clkreq>; +

Re: [PATCH 2/2] pci: Add PCIe driver for Rockchip Soc

Hi: On 2016/5/27 20:25, Marc Zyngier Wrote: [+Lorenzo] On 20/05/16 11:29, Shawn Lin wrote: RK3399 has a PCIe controller which can be used as Root Complex. This driver supports a PCIe controller as Root Complex mode. [] +static int rockchip_pcie_init_irq_domain(struct rockchip_pcie_por

Re: [PATCH 2/2] pci: Add PCIe driver for Rockchip Soc

Hi, On 2016/5/27 15:13, Bharat Kumar Gogada wrote: + +static int rockchip_pcie_rd_other_conf(struct rockchip_pcie_port *pp, + struct pci_bus *bus, u32 devfn, + int where, int size, u32 *val) +{ + u32 busdev; + +

Re: [PATCH 2/2] pci: Add PCIe driver for Rockchip Soc

rn 0; +} You don't seem to remove the child devices here. Have you tried unloading the module? I don't seem the remove function in other pcie host driver. I think this function could be deleted. Arnd Best Regards Wenrui Li