[PATCH v5 2/3] docs: driver-api: generic-counter: Update Count and Signal data types

2019-10-06 Thread William Breathitt Gray
Count data is now always represented as an unsigned integer, while Signal data is either SIGNAL_LOW or SIGNAL_HIGH. In addition, clarification changes and additions are made to better explain the theory of the Generic Counter interface and its use. Signed-off-by: William Breathitt Gray

[PATCH v5 3/3] counter: Fix typo in action_get description

2019-10-06 Thread William Breathitt Gray
The action_get callback returns a Synapse's action mode. Signed-off-by: William Breathitt Gray --- include/linux/counter.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/counter.h b/include/linux/counter.h index 32fb4d8cc3fd..9dbd5df4cd34 100644 --- a/in

[PATCH v5 0/3] Simplify count_read/count_write/signal_read

2019-10-06 Thread William Breathitt Gray
evel" data type. William Breathitt Gray (3): counter: Simplify the count_read and count_write callbacks docs: driver-api: generic-counter: Update Count and Signal data types counter: Fix typo in action_get description Documentation/driver-api/generic-counter.rst | 162 +++--

[PATCH v5 1/3] counter: Simplify the count_read and count_write callbacks

2019-10-06 Thread William Breathitt Gray
counter_count_write_value_get functions, are removed as they are no longer used. Cc: Patrick Havelange Acked-by: Fabrice Gasnier Acked-by: David Lechner Signed-off-by: William Breathitt Gray --- drivers/counter/104-quad-8.c| 33 +++-- drivers/counter/counter.c | 101

Re: [PATCH v4 2/2] docs: driver-api: generic-counter: Update Count and Signal data types

2019-10-06 Thread William Breathitt Gray
On Sun, Oct 06, 2019 at 01:41:42PM -0500, David Lechner wrote: > On 10/6/19 11:03 AM, William Breathitt Gray wrote: > > Count data is now always represented as an unsigned integer, while > > Signal data is either SIGNAL_LOW or SIGNAL_HIGH. > > > > Signed-off

[PATCH v4 1/2] counter: Simplify the count_read and count_write callbacks

2019-10-06 Thread William Breathitt Gray
counter_count_write_value_get functions, are removed as they are no longer used. Cc: David Lechner Cc: Patrick Havelange Acked-by: Fabrice Gasnier Signed-off-by: William Breathitt Gray --- drivers/counter/104-quad-8.c| 33 +++-- drivers/counter/counter.c | 101

[PATCH v4 0/2] Simplify count_read/count_write/signal_read

2019-10-06 Thread William Breathitt Gray
ignal *signal, enum counter_signal_value *val); The counter_signal_value enum is simply the counter_signal_level enum redefined to remove the references to the Signal data "level" data type. William Breathitt Gray (2): counter: Simplify the count_read and count_write c

[PATCH v4 2/2] docs: driver-api: generic-counter: Update Count and Signal data types

2019-10-06 Thread William Breathitt Gray
Count data is now always represented as an unsigned integer, while Signal data is either SIGNAL_LOW or SIGNAL_HIGH. Signed-off-by: William Breathitt Gray --- Documentation/driver-api/generic-counter.rst | 22 +++- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a

[PATCH v16 06/14] gpio: ws16c48: Utilize for_each_set_clump8 macro

2019-10-06 Thread William Breathitt Gray
Replace verbose implementation in get_multiple/set_multiple callbacks with for_each_set_clump8 macro to simplify code and improve clarity. Reviewed-by: Linus Walleij Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio-ws16c48.c | 73 ++--- 1 file changed

[PATCH v16 07/14] gpio: pci-idio-16: Utilize for_each_set_clump8 macro

2019-10-06 Thread William Breathitt Gray
Replace verbose implementation in get_multiple/set_multiple callbacks with for_each_set_clump8 macro to simplify code and improve clarity. Reviewed-by: Linus Walleij Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio-pci-idio-16.c | 75 - 1 file changed

[PATCH v16 10/14] gpio: 74x164: Utilize the for_each_set_clump8 macro

2019-10-06 Thread William Breathitt Gray
Replace verbose implementation in set_multiple callback with for_each_set_clump8 macro to simplify code and improve clarity. Suggested-by: Andy Shevchenko Cc: Geert Uytterhoeven Cc: Phil Reid Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio-74x164.c | 19 +-- 1

[PATCH v16 13/14] gpio: max3191x: Utilize the for_each_set_clump8 macro

2019-10-06 Thread William Breathitt Gray
Replace verbose implementation in get_multiple callback with for_each_set_clump8 macro to simplify code and improve clarity. Cc: Mathias Duckeck Cc: Lukas Wunner Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio-max3191x.c | 19 ++- 1 file changed, 10 insertions

[PATCH v16 01/14] bitops: Introduce the for_each_set_clump8 macro

2019-10-06 Thread William Breathitt Gray
lleij Signed-off-by: William Breathitt Gray --- include/asm-generic/bitops/find.h | 50 +++ include/linux/bitops.h| 5 lib/find_bit.c| 14 + 3 files changed, 69 insertions(+) diff --git a/include/asm-generic/bitops/find.h b

[PATCH v16 05/14] gpio: gpio-mm: Utilize for_each_set_clump8 macro

2019-10-06 Thread William Breathitt Gray
Replace verbose implementation in get_multiple/set_multiple callbacks with for_each_set_clump8 macro to simplify code and improve clarity. Reviewed-by: Linus Walleij Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio-gpio-mm.c | 73 +++-- 1 file changed

[PATCH v16 12/14] gpio: pisosr: Utilize the for_each_set_clump8 macro

2019-10-06 Thread William Breathitt Gray
Replace verbose implementation in get_multiple callback with for_each_set_clump8 macro to simplify code and improve clarity. Cc: Morten Hein Tiljeset Cc: Sean Nyekjaer Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio-pisosr.c | 12 ++-- 1 file changed, 6 insertions(+), 6

[PATCH v16 03/14] gpio: 104-dio-48e: Utilize for_each_set_clump8 macro

2019-10-06 Thread William Breathitt Gray
Replace verbose implementation in get_multiple/set_multiple callbacks with for_each_set_clump8 macro to simplify code and improve clarity. Reviewed-by: Linus Walleij Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio-104-dio-48e.c | 73 ++--- 1 file changed

[PATCH v16 14/14] gpio: pca953x: Utilize the for_each_set_clump8 macro

2019-10-06 Thread William Breathitt Gray
Replace verbose implementation in set_multiple callback with for_each_set_clump8 macro to simplify code and improve clarity. Cc: Phil Reid Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio-pca953x.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git

[PATCH v16 08/14] gpio: pcie-idio-24: Utilize for_each_set_clump8 macro

2019-10-06 Thread William Breathitt Gray
Replace verbose implementation in get_multiple/set_multiple callbacks with for_each_set_clump8 macro to simplify code and improve clarity. Reviewed-by: Linus Walleij Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio-pcie-idio-24.c | 109 --- 1 file changed

[PATCH v16 09/14] gpio: uniphier: Utilize for_each_set_clump8 macro

2019-10-06 Thread William Breathitt Gray
Replace verbose implementation in set_multiple callback with for_each_set_clump8 macro to simplify code and improve clarity. An improvement in this case is that banks that are not masked will now be skipped. Cc: Masahiro Yamada Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio

[PATCH v16 00/14] Introduce the for_each_set_clump8 macro

2019-10-06 Thread William Breathitt Gray
uced to get and set 8-bit values respectively. Their use is based on the behavior suggested in the patchset version 4 review. William Breathitt Gray (14): bitops: Introduce the for_each_set_clump8 macro lib/test_bitmap.c: Add for_each_set_clump8 test cases gpio: 104-dio-48e: Utilize for_each

[PATCH v16 11/14] thermal: intel: intel_soc_dts_iosf: Utilize for_each_set_clump8 macro

2019-10-06 Thread William Breathitt Gray
-off-by: William Breathitt Gray --- drivers/thermal/intel/intel_soc_dts_iosf.c | 29 +- drivers/thermal/intel/intel_soc_dts_iosf.h | 2 -- 2 files changed, 17 insertions(+), 14 deletions(-) diff --git a/drivers/thermal/intel/intel_soc_dts_iosf.c b/drivers/thermal/intel

[PATCH v16 04/14] gpio: 104-idi-48: Utilize for_each_set_clump8 macro

2019-10-06 Thread William Breathitt Gray
Replace verbose implementation in get_multiple/set_multiple callbacks with for_each_set_clump8 macro to simplify code and improve clarity. Reviewed-by: Linus Walleij Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio-104-idi-48.c | 36 +++--- 1 file changed

[PATCH v16 02/14] lib/test_bitmap.c: Add for_each_set_clump8 test cases

2019-10-06 Thread William Breathitt Gray
Villemoes Acked-by: Andrew Morton Reviewed-by: Andy Shevchenko Reviewed-by: Linus Walleij Signed-off-by: William Breathitt Gray --- lib/test_bitmap.c | 65 +++ 1 file changed, 65 insertions(+) diff --git a/lib/test_bitmap.c b/lib/test_bitmap.c index

Re: [PATCH] gpio: 104-idi-48e: make array register_offset static, makes object smaller

2019-10-06 Thread William Breathitt Gray
ta(chip); > unsigned i; > - const unsigned register_offset[6] = { 0, 1, 2, 4, 5, 6 }; > + static const unsigned int register_offset[6] = { 0, 1, 2, 4, 5, 6 }; > unsigned base_offset; > unsigned mask; > > -- > 2.20.1 Acked-by: William Breathitt Gray

Re: [PATCH v15 00/14] Introduce the for_each_set_clump8 macro

2019-10-05 Thread William Breathitt Gray
On Sat, Oct 05, 2019 at 02:36:54PM -0400, William Breathitt Gray wrote: > Changes in v15: > - Move find_next_clump8 to lib/find_bit.c since it requires round_down > (I want this to be static inline like the others, but I need help) > - Utilize for_each_set_clump8 in pisosr, m

[PATCH v15 07/14] gpio: pci-idio-16: Utilize for_each_set_clump8 macro

2019-10-05 Thread William Breathitt Gray
Replace verbose implementation in get_multiple/set_multiple callbacks with for_each_set_clump8 macro to simplify code and improve clarity. Reviewed-by: Linus Walleij Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio-pci-idio-16.c | 75 - 1 file changed

[PATCH v15 01/14] bitops: Introduce the for_each_set_clump8 macro

2019-10-05 Thread William Breathitt Gray
lleij Signed-off-by: William Breathitt Gray --- include/asm-generic/bitops/find.h | 50 +++ include/linux/bitops.h| 5 lib/find_bit.c| 14 + 3 files changed, 69 insertions(+) diff --git a/include/asm-generic/bitops/find.h b

[PATCH v15 00/14] Introduce the for_each_set_clump8 macro

2019-10-05 Thread William Breathitt Gray
go such an implementation for now. In addition, the bitmap_get_value8 and bitmap_set_value8 functions are introduced to get and set 8-bit values respectively. Their use is based on the behavior suggested in the patchset version 4 review. William Breathitt Gray (14): bitops: Introduce the for_ea

[PATCH v15 06/14] gpio: ws16c48: Utilize for_each_set_clump8 macro

2019-10-05 Thread William Breathitt Gray
Replace verbose implementation in get_multiple/set_multiple callbacks with for_each_set_clump8 macro to simplify code and improve clarity. Reviewed-by: Linus Walleij Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio-ws16c48.c | 73 ++--- 1 file changed

[PATCH v15 14/14] gpio: pca953x: Utilize the for_each_set_clump8 macro

2019-10-05 Thread William Breathitt Gray
Replace verbose implementation in set_multiple callback with for_each_set_clump8 macro to simplify code and improve clarity. Cc: Phil Reid Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio-pca953x.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git

[PATCH v15 11/14] thermal: intel: intel_soc_dts_iosf: Utilize for_each_set_clump8 macro

2019-10-05 Thread William Breathitt Gray
-off-by: William Breathitt Gray --- drivers/thermal/intel/intel_soc_dts_iosf.c | 29 +- drivers/thermal/intel/intel_soc_dts_iosf.h | 2 -- 2 files changed, 17 insertions(+), 14 deletions(-) diff --git a/drivers/thermal/intel/intel_soc_dts_iosf.c b/drivers/thermal/intel

[PATCH v15 05/14] gpio: gpio-mm: Utilize for_each_set_clump8 macro

2019-10-05 Thread William Breathitt Gray
Replace verbose implementation in get_multiple/set_multiple callbacks with for_each_set_clump8 macro to simplify code and improve clarity. Reviewed-by: Linus Walleij Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio-gpio-mm.c | 73 +++-- 1 file changed

[PATCH v15 08/14] gpio: pcie-idio-24: Utilize for_each_set_clump8 macro

2019-10-05 Thread William Breathitt Gray
Replace verbose implementation in get_multiple/set_multiple callbacks with for_each_set_clump8 macro to simplify code and improve clarity. Reviewed-by: Linus Walleij Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio-pcie-idio-24.c | 109 --- 1 file changed

[PATCH v15 03/14] gpio: 104-dio-48e: Utilize for_each_set_clump8 macro

2019-10-05 Thread William Breathitt Gray
Replace verbose implementation in get_multiple/set_multiple callbacks with for_each_set_clump8 macro to simplify code and improve clarity. Reviewed-by: Linus Walleij Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio-104-dio-48e.c | 73 ++--- 1 file changed

[PATCH v15 04/14] gpio: 104-idi-48: Utilize for_each_set_clump8 macro

2019-10-05 Thread William Breathitt Gray
Replace verbose implementation in get_multiple/set_multiple callbacks with for_each_set_clump8 macro to simplify code and improve clarity. Reviewed-by: Linus Walleij Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio-104-idi-48.c | 36 +++--- 1 file changed

[PATCH v15 10/14] gpio: 74x164: Utilize the for_each_set_clump8 macro

2019-10-05 Thread William Breathitt Gray
Replace verbose implementation in set_multiple callback with for_each_set_clump8 macro to simplify code and improve clarity. Suggested-by: Andy Shevchenko Cc: Geert Uytterhoeven Cc: Phil Reid Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio-74x164.c | 19 +-- 1

[PATCH v15 13/14] gpio: max3191x: Utilize the for_each_set_clump8 macro

2019-10-05 Thread William Breathitt Gray
Replace verbose implementation in get_multiple callback with for_each_set_clump8 macro to simplify code and improve clarity. Cc: Mathias Duckeck Cc: Lukas Wunner Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio-max3191x.c | 19 ++- 1 file changed, 10 insertions

[PATCH v15 09/14] gpio: uniphier: Utilize for_each_set_clump8 macro

2019-10-05 Thread William Breathitt Gray
Replace verbose implementation in set_multiple callback with for_each_set_clump8 macro to simplify code and improve clarity. An improvement in this case is that banks that are not masked will now be skipped. Cc: Masahiro Yamada Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio

[PATCH v15 12/14] gpio: pisosr: Utilize the for_each_set_clump8 macro

2019-10-05 Thread William Breathitt Gray
Replace verbose implementation in get_multiple callback with for_each_set_clump8 macro to simplify code and improve clarity. Cc: Morten Hein Tiljeset Cc: Sean Nyekjaer Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio-pisosr.c | 12 ++-- 1 file changed, 6 insertions(+), 6

[PATCH v15 02/14] lib/test_bitmap.c: Add for_each_set_clump8 test cases

2019-10-05 Thread William Breathitt Gray
Villemoes Acked-by: Andrew Morton Reviewed-by: Andy Shevchenko Reviewed-by: Linus Walleij Signed-off-by: William Breathitt Gray --- lib/test_bitmap.c | 65 +++ 1 file changed, 65 insertions(+) diff --git a/lib/test_bitmap.c b/lib/test_bitmap.c index

Re: [PATCH] counter: stm32: clean up indentation issue

2019-10-05 Thread William Breathitt Gray
clk_enable(priv->clk); > + if (!(cr1 & TIM_CR1_CEN)) > + clk_enable(priv->clk); > > regmap_update_bits(priv->regmap, TIM_CR1, TIM_CR1_CEN, > TIM_CR1_CEN); > -- > 2.20.1 Acked-by: William Breathitt Gray

Re: [PATCH v3 0/2] Simplify count_read/count_write/signal_read

2019-10-05 Thread William Breathitt Gray
they are ready, then later submit a git pull request to you with these changes if you prefer that route. William Breathitt Gray > On Wed, 18 Sep 2019 23:22:44 +0900 > William Breathitt Gray wrote: > > > Changes in v3: > > - Squash code changes to single patch to avoid comp

Re: [PATCH] counter: stm32-timer-cnt: fix a kernel-doc warning

2019-09-25 Thread William Breathitt Gray
On Wed, Sep 25, 2019 at 07:49:27PM -0400, William Breathitt Gray wrote: > On Wed, Sep 18, 2019 at 02:22:03PM +0200, Fabrice Gasnier wrote: > > Fix the following warning when documentation is built: > > drivers/counter/stm32-timer-cnt.c:37: warning: cannot understand function >

Re: [PATCH] counter: stm32-lptimer-cnt: fix a kernel-doc warning

2019-09-25 Thread William Breathitt Gray
;counter: stm32-lptimer: add counter device") Jonathan, please pick this fix up through IIO. Thanks, William Breathitt Gray

Re: [PATCH] counter: stm32-timer-cnt: fix a kernel-doc warning

2019-09-25 Thread William Breathitt Gray
-lptimer: add counter device") Jonathan, please pick this fix up through IIO. Thanks, William Breathitt Gray

[PATCH v3 2/2] docs: driver-api: generic-counter: Update Count and Signal data types

2019-09-18 Thread William Breathitt Gray
Count data is now always represented as an unsigned integer, while Signal data is either SIGNAL_LOW or SIGNAL_HIGH. Signed-off-by: William Breathitt Gray --- Documentation/driver-api/generic-counter.rst | 22 +++- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a

[PATCH v3 1/2] counter: Simplify the count_read and count_write callbacks

2019-09-18 Thread William Breathitt Gray
counter_count_write_value_get functions, are removed as they are no longer used. Cc: Patrick Havelange Acked-by: Fabrice Gasnier Signed-off-by: William Breathitt Gray --- drivers/counter/104-quad-8.c| 33 +++-- drivers/counter/counter.c | 101 +--- drivers/counter

[PATCH v3 0/2] Simplify count_read/count_write/signal_read

2019-09-18 Thread William Breathitt Gray
ignal *signal, enum counter_signal_value *val); The counter_signal_value enum is simply the counter_signal_level enum redefined to remove the references to the Signal data "level" data type. William Breathitt Gray (2): counter: Simplify the count_read and count_write c

Re: [PATCH v2 0/7] counter: Simplify count_read/count_write/signal_read

2019-09-18 Thread William Breathitt Gray
On Wed, Sep 18, 2019 at 04:52:41PM +0900, William Breathitt Gray wrote: > Changes in v2: > - Update the rest of the drivers under drivers/counter Jonathan, The TI eQEP driver also needs a patch for these changes if this patchset is merged. How would you like to handle the merge? We h

[PATCH v2 5/7] counter: ftm-quaddec: Update count_read and count_write callbacks

2019-09-18 Thread William Breathitt Gray
The count_read and count_write callbacks pass unsigned long now. Cc: Patrick Havelange Signed-off-by: William Breathitt Gray --- drivers/counter/ftm-quaddec.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/counter/ftm-quaddec.c b/drivers/counter/ftm

[PATCH v2 6/7] counter: stm32-lptimer-cnt: Update count_read callback

2019-09-18 Thread William Breathitt Gray
The count_read callback passes unsigned long now. Cc: Fabrice Gasnier Signed-off-by: William Breathitt Gray --- drivers/counter/stm32-lptimer-cnt.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/counter/stm32-lptimer-cnt.c b/drivers/counter/stm32-lptimer

[PATCH v2 7/7] counter: stm32-timer-cnt: Update count_read and count_write callbacks

2019-09-18 Thread William Breathitt Gray
The count_read and count_write callbacks pass unsigned long now. Cc: Fabrice Gasnier Signed-off-by: William Breathitt Gray --- drivers/counter/stm32-timer-cnt.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/drivers/counter/stm32-timer-cnt.c b/drivers

[PATCH v2 4/7] counter: 104-quad-8: Update count_read/count_write/signal_read callbacks

2019-09-18 Thread William Breathitt Gray
The count_read and count_write callbacks pass unsigned long now, while the signal_read callback passes an enum counter_signal_value. Signed-off-by: William Breathitt Gray --- drivers/counter/104-quad-8.c | 33 ++--- 1 file changed, 10 insertions(+), 23 deletions

[PATCH v2 3/7] docs: driver-api: generic-counter: Update Count and Signal data types

2019-09-18 Thread William Breathitt Gray
Count data is now always represented as an unsigned integer, while Signal data is either SIGNAL_LOW or SIGNAL_HIGH. Signed-off-by: William Breathitt Gray --- Documentation/driver-api/generic-counter.rst | 22 +++- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a

[PATCH v2 0/7] counter: Simplify count_read/count_write/signal_read

2019-09-18 Thread William Breathitt Gray
ignal, enum counter_signal_value *val); The counter_signal_value enum is simply the counter_signal_level enum redefined to remove the references to the Signal data "level" data type. William Breathitt Gray (7): counter: Simplify the count_read and count_write call

[PATCH v2 1/7] counter: Simplify the count_read and count_write callbacks

2019-09-18 Thread William Breathitt Gray
counter_count_write_value_get functions, are removed as they are no longer used. Signed-off-by: William Breathitt Gray --- drivers/counter/counter.c | 66 +-- include/linux/counter.h | 43 +++-- 2 files changed, 12 insertions(+), 97 deletions(-) diff

[PATCH v2 2/7] counter: Simplify the signal_read callback

2019-09-18 Thread William Breathitt Gray
enum is replaced by the similar counter_signal_value enum. Signed-off-by: William Breathitt Gray --- drivers/counter/counter.c | 35 +++ include/linux/counter.h | 31 +-- 2 files changed, 12 insertions(+), 54 deletions(-) diff --git a

Re: [RFC 1/4] counter: Simplify the count_read and count_write callbacks

2019-09-15 Thread William Breathitt Gray
On Sun, Sep 15, 2019 at 02:47:00PM +0100, Jonathan Cameron wrote: > On Sun, 15 Sep 2019 14:39:17 +0100 > Jonathan Cameron wrote: > > > On Sun, 15 Sep 2019 14:57:56 +0900 > > William Breathitt Gray wrote: > > > > > The count_read and count_write cal

[RFC 4/4] counter: 104-quad-8: Update count_read/count_write/signal_read callbacks

2019-09-14 Thread William Breathitt Gray
The count_read and count_write callbacks pass unsigned long now, while the signal_read callback passes an enum counter_signal_value. Signed-off-by: William Breathitt Gray --- drivers/counter/104-quad-8.c | 33 ++--- 1 file changed, 10 insertions(+), 23 deletions

[RFC 1/4] counter: Simplify the count_read and count_write callbacks

2019-09-14 Thread William Breathitt Gray
counter_count_write_value_get functions, are removed as they are no longer used. Signed-off-by: William Breathitt Gray --- drivers/counter/counter.c | 66 +-- include/linux/counter.h | 43 +++-- 2 files changed, 12 insertions(+), 97 deletions(-) diff

[RFC 3/4] docs: driver-api: generic-counter: Update Count and Signal data types

2019-09-14 Thread William Breathitt Gray
Count data is now always represented as an unsigned integer, while Signal data is either SIGNAL_LOW or SIGNAL_HIGH. Signed-off-by: William Breathitt Gray --- Documentation/driver-api/generic-counter.rst | 22 +++- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a

[RFC 2/4] counter: Simplify the signal_read callback

2019-09-14 Thread William Breathitt Gray
enum is replaced by the similar counter_signal_value enum. Signed-off-by: William Breathitt Gray --- drivers/counter/counter.c | 35 +++ include/linux/counter.h | 31 +-- 2 files changed, 12 insertions(+), 54 deletions(-) diff --git a

[RFC 0/4] counter: Simplify count_read/count_write/signal_read

2019-09-14 Thread William Breathitt Gray
enum counter_signal_value *val); The counter_signal_value enum is simply the counter_signal_level enum redefined to remove the references to the Signal data "level" data type. William Breathitt Gray (4): counter: Simplify the count_read and count_write callbacks counter:

Re: [PATCH v3 0/6] counter: new TI eQEP driver

2019-09-05 Thread William Breathitt Gray
+++++++++ > drivers/pwm/Kconfig | 9 - > drivers/pwm/Makefile | 1 - > 12 files changed, 634 insertions(+), 100 deletions(-) > create mode 100644 Documentation/devicetree/bindings/counter/ti-eqep.yaml > rename drivers/{pwm/

Re: [PATCH v2 3/5] counter: new TI eQEP driver

2019-08-15 Thread William Breathitt Gray
ction" here since it'll be automatically updated in the core counter_action_show function to the value returned by your action_get callback function. So you can safely delete those two ".action =" lines. William Breathitt Gray

Re: [PATCH 2/4] counter: new TI eQEP driver

2019-08-02 Thread William Breathitt Gray
On Fri, Aug 02, 2019 at 11:17:11AM -0500, David Lechner wrote: > On 8/2/19 4:27 AM, William Breathitt Gray wrote: > >> +static const struct counter_ops ti_eqep_counter_ops = { > >> + .count_read = ti_eqep_count_read, > >> + .count_write= ti_eqep_coun

Re: [PATCH 1/4] dt-bindings: counter: new bindings for TI eQEP

2019-08-02 Thread William Breathitt Gray
On Fri, Aug 02, 2019 at 07:34:42AM -0600, Rob Herring wrote: > On Fri, Aug 2, 2019 at 1:25 AM William Breathitt Gray > wrote: > > > > On Sat, Jul 27, 2019 at 08:48:36PM +0100, Jonathan Cameron wrote: > > > On Mon, 22 Jul 2019 10:45:35 -0500 > > > David Lechner

Re: [PATCH 2/4] counter: new TI eQEP driver

2019-08-02 Thread William Breathitt Gray
ion. The actual device has many more features > which can be added to the driver on an as-needed basis. > > Signed-off-by: David Lechner Some changes suggested below, but most of the important stuff is there and correct so good job. William Breathitt Gray > --- > MAINTAINERS

Re: [PATCH 1/4] dt-bindings: counter: new bindings for TI eQEP

2019-08-02 Thread William Breathitt Gray
gs as yaml, or shall I accept them as they are now? William Breathitt Gray > > > --- > > .../devicetree/bindings/counter/ti-eqep.txt| 18 ++ > > 1 file changed, 18 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/counter/ti-eqep

Re: [PATCH 0/4] new driver for TI eQEP

2019-07-29 Thread William Breathitt Gray
On Thu, Jul 25, 2019 at 05:52:21PM -0500, David Lechner wrote: > On 7/25/19 7:40 AM, William Breathitt Gray wrote: > > On Mon, Jul 22, 2019 at 10:45:34AM -0500, David Lechner wrote: > >> This series adds device tree bindings and a new counter driver for the > >> Texa

Re: [PATCH v2] counter/ftm-quaddec: Use device-managed registration API

2019-07-27 Thread William Breathitt Gray
This looks fine to me as well. William, if you are happy with the resend > of this, then let me know if you want me to queue it up. > > Thanks, > > Jonathan I'm all right with these changes too. Feel free to queue up the resend version in your tree when you are ready. William

Re: [PATCH 0/4] new driver for TI eQEP

2019-07-25 Thread William Breathitt Gray
d directly as an attribute. If we were to expose just the count value and timestamp since the last read, that should be enough for a user to compute the delta and derive speed. I'll think more about this since some devices may simplify that case if the hardware is able to compute the speed for us. William Breathitt Gray

Re: [PATCH] IIO: stm32: Remove quadrature related functions from trigger driver

2019-07-11 Thread William Breathitt Gray
On Thu, Jul 11, 2019 at 02:12:27PM +0200, Benjamin Gaignard wrote: > Le jeu. 11 juil. 2019 à 13:51, William Breathitt Gray > a écrit : > > > > On Tue, May 07, 2019 at 11:12:24AM +0200, Benjamin Gaignard wrote: > > > Quadrature feature is now hosted on it own framewo

Re: [PATCH] IIO: stm32: Remove quadrature related functions from trigger driver

2019-07-11 Thread William Breathitt Gray
status of this patch? Are there any objections currently for its inclusion? William Breathitt Gray

Re: [PATCH 1/1] counter: cros_ec: Add synchronization sensor

2019-07-11 Thread William Breathitt Gray
+ b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c > @@ -22,6 +22,7 @@ > static char *cros_ec_loc[] = { > [MOTIONSENSE_LOC_BASE] = "base", > [MOTIONSENSE_LOC_LID] = "lid", > + [MOTIONSENSE_LOC_CAMERA] = "camera", > [MOTIONSENSE_LOC_MAX] = "unknown", > }; > > diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c > index 41dccced5026..1c5c2c38af88 100644 > --- a/drivers/mfd/cros_ec_dev.c > +++ b/drivers/mfd/cros_ec_dev.c > @@ -332,6 +332,9 @@ static void cros_ec_sensors_register(struct cros_ec_dev > *ec) > case MOTIONSENSE_TYPE_ACTIVITY: > sensor_cells[id].name = "cros-ec-activity"; > break; > + case MOTIONSENSE_TYPE_SYNC: > + sensor_cells[id].name = "cros-ec-sync"; > + break; > default: > dev_warn(ec->dev, "unknown type %d\n", resp->info.type); > continue; > -- > 2.19.2 Since this will be a new file, please also add it to the MAINTAINERS file so we can have a record of the maintainer for this driver. If you have any troubles or need help understanding the Counter interface, just let me know and I'll be happy to assist; this subsystem is new so it'll be good to get all the kinks out that you may find. Thanks, William Breathitt Gray

Re: [PATCH] watchdog: convert remaining drivers to use SPDX license identifier

2019-06-22 Thread William Breathitt Gray
/watchdog/ebc-c384_wdt.c > +++ b/drivers/watchdog/ebc-c384_wdt.c > @@ -2,15 +2,6 @@ > /* > * Watchdog timer driver for the WinSystems EBC-C384 > * Copyright (C) 2016 William Breathitt Gray > - * > - * This program is free software; you can redistribute it and/or modify > - *

Re: [PATCH 1/1] counter/ftm-quaddec: Add missing '>' in MODULE_AUTHOR

2019-06-18 Thread William Breathitt Gray
k Havelange +MODULE_AUTHOR("Kjeld Flarup "); > +MODULE_AUTHOR("Patrick Havelange "); > -- > 2.19.1 Signed-off-by: William Breathitt Gray Jonathan, please pick up this fix as well. William Breathit Gray

Re: [PATCH] counter: fix ftm-quaddec build error on UML

2019-06-18 Thread William Breathitt Gray
On Mon, Jun 17, 2019 at 09:54:45PM +0200, Richard Weinberger wrote: > Hi! > > - Ursprüngliche Mail - > > Von: "Randy Dunlap" > > An: "linux-kernel" , linux-...@vger.kernel.org > > CC: "Geert Uytterhoeven" , "Kjeld Fl

Re: [PATCH 1/1] MAINTAINERS: add counter/ftm-quaddec driver entry

2019-06-12 Thread William Breathitt Gray
ernel/git/jikos/floppy.git > -- > 2.19.1 Thank you, this should take care of those files. Signed-off-by: William Breathitt Gray

Re: [PATCH 1/1] counter/ftm-quaddec: Add missing dependencies in Kconfig

2019-06-04 Thread William Breathitt Gray
FTM_QUADDEC > tristate "Flex Timer Module Quadrature decoder driver" > + depends on HAS_IOMEM && OF > help > Select this option to enable the Flex Timer Quadrature decoder > driver. > -- > 2.19.1 Fixes: a3b9a99 ("counter: add

Re: [PATCH] IIO: stm32: Remove quadrature related functions from trigger driver

2019-05-08 Thread William Breathitt Gray
On Tue, May 07, 2019 at 02:37:07PM +0200, Benjamin Gaignard wrote: > Le mar. 7 mai 2019 à 12:19, William Breathitt Gray > a écrit : > > > > On Tue, May 07, 2019 at 11:12:24AM +0200, Benjamin Gaignard wrote: > > > Quadrature feature is now hosted on it own framewo

Re: [PATCH] IIO: stm32: Remove quadrature related functions from trigger driver

2019-05-07 Thread William Breathitt Gray
unter subsystem. Once user applications have had enough time to migrate to the Generic Counter interface, we can consider removing the deprecated IIO Counter interface. William Breathitt Gray

Re: [PATCH v14 01/11] bitops: Introduce the for_each_set_clump8 macro

2019-04-26 Thread William Breathitt Gray
On Fri, Mar 29, 2019 at 12:04:08PM +0900, William Breathitt Gray wrote: > This macro iterates for each 8-bit group of bits (clump) with set bits, > within a bitmap memory region. For each iteration, "start" is set to the > bit offset of the found clump, while the respective clum

Re: [PATCH -next] counter: 104-quad-8: Make quad8_ops static

2019-04-26 Thread William Breathitt Gray
> .count_write = quad8_count_write, > -- > 2.7.4 Yes, thank you, this should be static. Acked-by: William Breathitt Gray

[PATCH v10 18/18] LS1021A: dtsi: add ftm quad decoder entries

2019-04-01 Thread William Breathitt Gray
From: Patrick Havelange Add the 4 Quadrature counters for this board. Reviewed-by: Esben Haabendal Signed-off-by: Patrick Havelange Signed-off-by: William Breathitt Gray --- arch/arm/boot/dts/ls1021a.dtsi | 28 1 file changed, 28 insertions(+) diff --git a/arch

Re: [PATCH 0/2] Add Updown Counter support for Milbeaut M10V SoC

2019-03-30 Thread William Breathitt Gray
uaddec.c drivers/counter/stm32-timer-cnt.c If you have any troubles or difficulties with the API, send me a message and I will be happy to help. :-) Thank you, William Breathitt Gray > > > > > Shinji Kanematsu (2): > > dt-bindings: iio: counter: Add Milbeaut Updow

[PATCH v14 10/11] gpio: 74x164: Utilize the for_each_set_clump8 macro

2019-03-28 Thread William Breathitt Gray
Replace verbose implementation in set_multiple callback with for_each_set_clump8 macro to simplify code and improve clarity. Suggested-by: Andy Shevchenko Cc: Geert Uytterhoeven Cc: Phil Reid Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio-74x164.c | 19 +-- 1

[PATCH v14 11/11] thermal: intel: intel_soc_dts_iosf: Utilize for_each_set_clump8 macro

2019-03-28 Thread William Breathitt Gray
-off-by: William Breathitt Gray --- drivers/thermal/intel/intel_soc_dts_iosf.c | 29 +- drivers/thermal/intel/intel_soc_dts_iosf.h | 2 -- 2 files changed, 17 insertions(+), 14 deletions(-) diff --git a/drivers/thermal/intel/intel_soc_dts_iosf.c b/drivers/thermal/intel

[PATCH v14 09/11] gpio: uniphier: Utilize for_each_set_clump8 macro

2019-03-28 Thread William Breathitt Gray
Replace verbose implementation in set_multiple callback with for_each_set_clump8 macro to simplify code and improve clarity. An improvement in this case is that banks that are not masked will now be skipped. Cc: Masahiro Yamada Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio

[PATCH v14 08/11] gpio: pcie-idio-24: Utilize for_each_set_clump8 macro

2019-03-28 Thread William Breathitt Gray
Replace verbose implementation in get_multiple/set_multiple callbacks with for_each_set_clump8 macro to simplify code and improve clarity. Reviewed-by: Linus Walleij Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio-pcie-idio-24.c | 109 --- 1 file changed

[PATCH v14 07/11] gpio: pci-idio-16: Utilize for_each_set_clump8 macro

2019-03-28 Thread William Breathitt Gray
Replace verbose implementation in get_multiple/set_multiple callbacks with for_each_set_clump8 macro to simplify code and improve clarity. Reviewed-by: Linus Walleij Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio-pci-idio-16.c | 75 - 1 file changed

[PATCH v14 06/11] gpio: ws16c48: Utilize for_each_set_clump8 macro

2019-03-28 Thread William Breathitt Gray
Replace verbose implementation in get_multiple/set_multiple callbacks with for_each_set_clump8 macro to simplify code and improve clarity. Reviewed-by: Linus Walleij Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio-ws16c48.c | 73 ++--- 1 file changed

[PATCH v14 05/11] gpio: gpio-mm: Utilize for_each_set_clump8 macro

2019-03-28 Thread William Breathitt Gray
Replace verbose implementation in get_multiple/set_multiple callbacks with for_each_set_clump8 macro to simplify code and improve clarity. Reviewed-by: Linus Walleij Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio-gpio-mm.c | 73 +++-- 1 file changed

[PATCH v14 04/11] gpio: 104-idi-48: Utilize for_each_set_clump8 macro

2019-03-28 Thread William Breathitt Gray
Replace verbose implementation in get_multiple/set_multiple callbacks with for_each_set_clump8 macro to simplify code and improve clarity. Reviewed-by: Linus Walleij Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio-104-idi-48.c | 36 +++--- 1 file changed

[PATCH v14 03/11] gpio: 104-dio-48e: Utilize for_each_set_clump8 macro

2019-03-28 Thread William Breathitt Gray
Replace verbose implementation in get_multiple/set_multiple callbacks with for_each_set_clump8 macro to simplify code and improve clarity. Reviewed-by: Linus Walleij Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio-104-dio-48e.c | 73 ++--- 1 file changed

[PATCH v14 01/11] bitops: Introduce the for_each_set_clump8 macro

2019-03-28 Thread William Breathitt Gray
henko Signed-off-by: William Breathitt Gray --- include/asm-generic/bitops/find.h | 61 +++ include/linux/bitops.h| 5 +++ 2 files changed, 66 insertions(+) diff --git a/include/asm-generic/bitops/find.h b/include/asm-generic/bitops/find.h index 8a1ee1

[PATCH v14 02/11] lib/test_bitmap.c: Add for_each_set_clump8 test cases

2019-03-28 Thread William Breathitt Gray
Villemoes Acked-by: Andrew Morton Reviewed-by: Andy Shevchenko Reviewed-by: Linus Walleij Signed-off-by: William Breathitt Gray --- lib/test_bitmap.c | 65 +++ 1 file changed, 65 insertions(+) diff --git a/lib/test_bitmap.c b/lib/test_bitmap.c index

[PATCH v14 00/11] Introduce the for_each_set_clump8 macro

2019-03-28 Thread William Breathitt Gray
of a true generic for_each_set_clump function, I have decided to forgo such an implementation for now. In addition, the bitmap_get_value8 and bitmap_set_value8 functions are introduced to get and set 8-bit values respectively. Their use is based on the behavior suggested in the patchset version 4 r

Re: [PATCH v13 10/11] gpio: 74x164: Utilize the for_each_set_clump8 macro

2019-03-27 Thread William Breathitt Gray
On Wed, Mar 27, 2019 at 02:33:14PM +0200, Andy Shevchenko wrote: > On Wed, Mar 27, 2019 at 02:02:39PM +0900, William Breathitt Gray wrote: > > Replace verbose implementation in set_multiple callback with > > for_each_set_clump8 macro to simplify code and

Re: [PATCH v13 01/11] bitops: Introduce the for_each_set_clump8 macro

2019-03-27 Thread William Breathitt Gray
On Wed, Mar 27, 2019 at 07:42:54AM +0100, Lukas Wunner wrote: > On Wed, Mar 27, 2019 at 01:58:45PM +0900, William Breathitt Gray wrote: > > This macro iterates for each 8-bit group of bits (clump) with set bits, > > within a bitmap memory region. For each iteration, "start&qu

<    1   2   3   4   5   6   7   8   9   10   >