Re: [PATCH 1/4] usb: dwc3: of-simple: add compatible for rockchip

2016-05-10 Thread William Wu
Dear Felipe, On 05/10/2016 04:11 PM, Felipe Balbi wrote: Hi William, William Wu <william...@rock-chips.com> writes: Dear Felipe & Doug, Thanks for your proposal. It's a good idea to sort the list. I'll fix it next patch version. cool, thanks. ps: top-posting

Re: [PATCH 1/4] usb: dwc3: of-simple: add compatible for rockchip

2016-05-10 Thread William Wu
Dear Felipe, On 05/10/2016 04:11 PM, Felipe Balbi wrote: Hi William, William Wu writes: Dear Felipe & Doug, Thanks for your proposal. It's a good idea to sort the list. I'll fix it next patch version. cool, thanks. ps: top-posting is frowned upon here. Please a

Re: [PATCH 1/4] usb: dwc3: of-simple: add compatible for rockchip

2016-05-10 Thread William Wu
, even if they aren't as fortunate as me to have been CC'd on your patch directly. Actually, I don't know the linux-rockc...@lists.infradead.org before. I'll add the list in CC next patch version. Thanks~ On Mon, May 09, 2016 at 07:46:14PM +0800, William Wu wrote: Signed-off-by: William Wu <willia

Re: [PATCH 1/4] usb: dwc3: of-simple: add compatible for rockchip

2016-05-10 Thread William Wu
as me to have been CC'd on your patch directly. Actually, I don't know the linux-rockc...@lists.infradead.org before. I'll add the list in CC next patch version. Thanks~ On Mon, May 09, 2016 at 07:46:14PM +0800, William Wu wrote: Signed-off-by: William Wu --- drivers/usb/dwc3/dwc3-of-simple.c

Re: [PATCH 1/4] usb: dwc3: of-simple: add compatible for rockchip

2016-05-10 Thread William Wu
Dear Felipe & Doug, Thanks for your proposal. It's a good idea to sort the list. I'll fix it next patch version. On 05/10/2016 03:14 PM, Felipe Balbi wrote: Hi, Doug Anderson <diand...@google.com> writes: William, On Mon, May 9, 2016 at 4:46 AM, William Wu <wi

Re: [PATCH 1/4] usb: dwc3: of-simple: add compatible for rockchip

2016-05-10 Thread William Wu
Dear Felipe & Doug, Thanks for your proposal. It's a good idea to sort the list. I'll fix it next patch version. On 05/10/2016 03:14 PM, Felipe Balbi wrote: Hi, Doug Anderson writes: William, On Mon, May 9, 2016 at 4:46 AM, William Wu wrote: Signed-off-by: Willia

Re: [PATCH 3/4] usb: dwc3: make usb2 phy interface configurable in DT

2016-05-09 Thread William Wu
On 05/09/2016 08:18 PM, Felipe Balbi wrote: Hi, William Wu <william...@rock-chips.com> writes: Add snps,phyif_utmi_16_bits devicetree property. USB2 phy this needs a quirk_ prefix... Yes, maybe a quirk is more proper. As you mentioned, the PHYIf can be configured

Re: [PATCH 3/4] usb: dwc3: make usb2 phy interface configurable in DT

2016-05-09 Thread William Wu
On 05/09/2016 08:18 PM, Felipe Balbi wrote: Hi, William Wu writes: Add snps,phyif_utmi_16_bits devicetree property. USB2 phy this needs a quirk_ prefix... Yes, maybe a quirk is more proper. As you mentioned, the PHYIf can be configured during coreconsultant. But for some

Re: [PATCH] usb: dwc3: add DWC3_GUCTL1 reg for debug

2016-05-09 Thread William Wu
On 05/09/2016 08:10 PM, Felipe Balbi wrote: William Wu <william...@rock-chips.com> writes: Thanks Felipe Balbi and Greg KH. I'm really sorry that I forgot to add changelog. Signed-off-by: William Wu <william...@rock-chips.com> no changelog = no commit, sorry. Why do you

Re: [PATCH] usb: dwc3: add DWC3_GUCTL1 reg for debug

2016-05-09 Thread William Wu
On 05/09/2016 08:10 PM, Felipe Balbi wrote: William Wu writes: Thanks Felipe Balbi and Greg KH. I'm really sorry that I forgot to add changelog. Signed-off-by: William Wu no changelog = no commit, sorry. Why do you want to dump GUCTL1? Because GUCTL1 can be written by user

[PATCH] usb: dwc3: add DWC3_GUCTL1 reg for debug

2016-05-09 Thread William Wu
Signed-off-by: William Wu <william...@rock-chips.com> --- drivers/usb/dwc3/core.h| 1 + drivers/usb/dwc3/debugfs.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index e15e307..f268869 100644 --- a/drivers/usb/dwc3/core.h +++ b/d

[PATCH] usb: dwc3: add DWC3_GUCTL1 reg for debug

2016-05-09 Thread William Wu
Signed-off-by: William Wu --- drivers/usb/dwc3/core.h| 1 + drivers/usb/dwc3/debugfs.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index e15e307..f268869 100644 --- a/drivers/usb/dwc3/core.h +++ b/drivers/usb/dwc3/core.h @@ -86,6

[PATCH 3/4] usb: dwc3: make usb2 phy interface configurable in DT

2016-05-09 Thread William Wu
to the corresponding value according to the usb2 phy interface. Signed-off-by: William Wu <william...@rock-chips.com> --- Documentation/devicetree/bindings/usb/dwc3.txt | 2 ++ drivers/usb/dwc3/core.c| 13 + drivers/usb/dwc3/core.h

[PATCH 3/4] usb: dwc3: make usb2 phy interface configurable in DT

2016-05-09 Thread William Wu
to the corresponding value according to the usb2 phy interface. Signed-off-by: William Wu --- Documentation/devicetree/bindings/usb/dwc3.txt | 2 ++ drivers/usb/dwc3/core.c| 13 + drivers/usb/dwc3/core.h| 8 drivers/usb/dwc3

[PATCH 0/4] support rockchip dwc3 driver

2016-05-09 Thread William Wu
This series add support for rockchip dwc3 driver, and add additional optional properties for specific platforms (e.g., rockchip platform). William Wu (4): usb: dwc3: of-simple: add compatible for rockchip usb: dwc3: add dis_u2_freeclk_exists_quirk usb: dwc3: make usb2 phy interface

[PATCH 0/4] support rockchip dwc3 driver

2016-05-09 Thread William Wu
This series add support for rockchip dwc3 driver, and add additional optional properties for specific platforms (e.g., rockchip platform). William Wu (4): usb: dwc3: of-simple: add compatible for rockchip usb: dwc3: add dis_u2_freeclk_exists_quirk usb: dwc3: make usb2 phy interface

[PATCH 4/4] usb: dwc3: add dis_del_phy_power_chg_quirk

2016-05-09 Thread William Wu
Add a quirk to clear the GUSB3PIPECTL.DELAYP1TRANS bit, which specifies whether disable delay PHY power change from P0 to P1/P2/P3 when link state changing from U0 to U1/U2/U3 respectively. Signed-off-by: William Wu <william...@rock-chips.com> --- Documentation/devicetree/bindings/usb/dw

[PATCH 4/4] usb: dwc3: add dis_del_phy_power_chg_quirk

2016-05-09 Thread William Wu
Add a quirk to clear the GUSB3PIPECTL.DELAYP1TRANS bit, which specifies whether disable delay PHY power change from P0 to P1/P2/P3 when link state changing from U0 to U1/U2/U3 respectively. Signed-off-by: William Wu --- Documentation/devicetree/bindings/usb/dwc3.txt | 2 ++ drivers/usb/dwc3

[PATCH 2/4] usb: dwc3: add dis_u2_freeclk_exists_quirk

2016-05-09 Thread William Wu
Add a quirk to clear the GUSB2PHYCFG.U2_FREECLK_EXISTS bit, which specifies whether the USB2.0 PHY provides a free-running PHY clock, which is active when the clock control input is active. Signed-off-by: William Wu <william...@rock-chips.com> --- Documentation/devicetree/bindings/usb/dw

[PATCH 2/4] usb: dwc3: add dis_u2_freeclk_exists_quirk

2016-05-09 Thread William Wu
Add a quirk to clear the GUSB2PHYCFG.U2_FREECLK_EXISTS bit, which specifies whether the USB2.0 PHY provides a free-running PHY clock, which is active when the clock control input is active. Signed-off-by: William Wu --- Documentation/devicetree/bindings/usb/dwc3.txt | 3 +++ drivers/usb/dwc3

[PATCH 1/4] usb: dwc3: of-simple: add compatible for rockchip

2016-05-09 Thread William Wu
Signed-off-by: William Wu <william...@rock-chips.com> --- drivers/usb/dwc3/dwc3-of-simple.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c index 9743353..1f3665b 100644 --- a/drivers/usb/dwc3/dwc3-of-simple.c

[PATCH 1/4] usb: dwc3: of-simple: add compatible for rockchip

2016-05-09 Thread William Wu
Signed-off-by: William Wu --- drivers/usb/dwc3/dwc3-of-simple.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c index 9743353..1f3665b 100644 --- a/drivers/usb/dwc3/dwc3-of-simple.c +++ b/drivers/usb/dwc3/dwc3-of-simple.c

<    1   2   3   4