>
I saw some kbuild robot issues regarding the patchset, so I would suggest you
make a v2 of the patch set and I can run some tests with the DW UFS Host design.
Yes the second round is on the way but there are (for) quite minor issues.
Tomas
On 04/03/2016 02:42 AM, Tomas Winkler wrote:
> Few storage technology such is EMMC, UFS, and NVMe support RPMB
> hardware partition with common protocol and frame layout.
> The RPMB partition cannot be accessed via standard block layer, but by
> a set of specific commands: WRITE, READ, GET_WRIT
On Thu, 2016-03-31 at 19:57 +0100, Joao Pinto wrote:
> Adding UFS 2.0 support to the UFS core driver.
>
> Signed-off-by: Joao Pinto
Looks good to me, though not tested yet
Tomas
> ---
> Changes v11->v12 (Tomas Winkler):
> - devicetree binding tweak was moved to a separated patch
> - unipro twea
diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h index
2570d94..8b0cdf0 100644
--- a/drivers/scsi/ufs/ufshcd.h
+++ b/drivers/scsi/ufs/ufshcd.h
@@ -262,6 +262,7 @@ struct ufs_pwr_mode_info {
* @suspend: called during host controller PM callback
* @resume: called during host c
Hi Thomas,
On 3/29/2016 11:41 AM, Winkler, Tomas wrote:
>
> Adding UFS 2.0 support to the UFS core driver.
>
> Signed-off-by: Joao Pinto
> Acked-by: Arnd Bergmann
> Acked-by: Rob Herring
> ---
> Changes v8->v11:
> - Nothing changed (just to keep up with patch
Adding UFS 2.0 support to the UFS core driver.
Signed-off-by: Joao Pinto
Acked-by: Arnd Bergmann
Acked-by: Rob Herring
---
Changes v8->v11:
- Nothing changed (just to keep up with patch set version).
Changes v7->v8:
- Added "jedec, ufs-2.0" to the ufschd-platform compatibility strings Changes
>
> On 03/11/2016 02:43 AM, Martin K. Petersen wrote:
> >> "Arnd" == Arnd Bergmann writes:
> >
> > Arnd> Looking through what other drivers do, I've found a couple of
> > Arnd> patterns now. n particular, most use the SG_IO ioctl to pass down
> > Arnd> commands from user space into a device s
>
> On Wed, 2016-02-17 at 12:27 +0200, Tomas Winkler wrote:
> []
> > buf_idx type was changed to size_t, and few places
> > missed out to change the print format from %ld to %zd.
>
> trivia:
>
> > diff --git a/drivers/misc/mei/interrupt.c b/drivers/misc/mei/interrupt.c
> []
> > @@ -128,7 +128,7
> -Original Message-
> From: Jiri Slaby [mailto:jsl...@suse.cz]
> Sent: Monday, February 15, 2016 17:20
> To: Shuah Khan ; sta...@vger.kernel.org
> Cc: li...@roeck-us.net; shuah...@samsung.com; linux-kernel@vger.kernel.org;
> Winkler, Tomas
> Subject: Re: [PATC
> Currently we use the host quirks mechanism in order to
> handle both device and host controller quirks.
> In order to support various of UFS devices we should separate
> handling the device quirks from the host controller's.
>
> Reviewed-by: Gilad Broner
> Signed-off-by: Raviv Shvili
> Signed-
> -Original Message-
> From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org]
> Sent: Sunday, February 07, 2016 08:09
> To: Winkler, Tomas
> Cc: Usyskin, Alexander; linux-kernel@vger.kernel.org
> Subject: Re: [char-misc-next RESEND 0/6] mei updates
>
> On
> Some of the data structures (like response UPIU) and/or its elements
> (unused fields) should be cleared before sending out the respective
> command to UFS device.
>
> This change clears the UPIU response data structure for query commands
> and NOP command before sending out the command. We al
>
> On Wed, Jan 27, 2016 at 09:22:17PM +, Winkler, Tomas wrote:
> > >
> > >
> > > >
> > > > On Thu, Jan 07, 2016 at 10:56:34PM +, Winkler, Tomas wrote:
> > > > >
> > > > >
> > > > > > On T
>
>
> >
> > On Thu, Jan 07, 2016 at 10:56:34PM +0000, Winkler, Tomas wrote:
> > >
> > >
> > > > On Thu, Jan 07, 2016 at 02:46:33PM +0200, Tomas Winkler wrote:
> > > > > I've sent those patches ~ two months ago but were
next v3 6/8] watchdog: mei_wdt: register wd device only
> if required
>
> On 12/21/2015 03:17 PM, Tomas Winkler wrote:
> > From: Alexander Usyskin
> >
> > For Intel Broadwell and newer platforms, the ME device can inform
> > the host whether the watchdog functionality is activated or not.
> > If
>
> On 12/21/2015 03:17 PM, Tomas Winkler wrote:
> > Add entry for dumping current watchdog internal state
> >
> > Signed-off-by: Tomas Winkler
> > ---
> > V2: new in the series
> > V3: rebase
> > drivers/watchdog/mei_wdt.c | 88
> ++
> > 1 file chan
>
> On 12/21/2015 11:19 PM, Winkler, Tomas wrote:
> >
> >>
> >> On 12/21/2015 03:17 PM, Tomas Winkler wrote:
> >>> Create a driver with the generic watchdog interface
> >>> for the MEI iAMT watchdog device.
> >>>
> >
>
> On 12/21/2015 03:17 PM, Tomas Winkler wrote:
> > Create a driver with the generic watchdog interface
> > for the MEI iAMT watchdog device.
> >
> > Signed-off-by: Alexander Usyskin
> > Signed-off-by: Tomas Winkler
> > ---
> > V2: The watchdog device is no longer dynamically allocated in sepa
>
> > > That breaks the existing behaviour of hot pluggable watchdog interfaces
> > > and is different to just about any other device in the kernel. Today with
> > > any desktop or server distribution you can already trivially arrange for
> > > watchdog daemons to start at the point a watchdog is
>
> On 12/17/2015 06:49 AM, Tomas Winkler wrote:
> > From: Alexander Usyskin
> >
> > For Intel Broadwell and newer platforms, the ME device can inform
> > the host whether the watchdog functionality is activated or not.
> > If the watchdog functionality is not activated then the watchdog interfac
> >>> +#if IS_ENABLED(CONFIG_DEBUG_FS)
> >>> +static const char *mei_wdt_state_str(enum mei_wdt_state state)
> >>> +{
> >>> + switch (state) {
> >>> + case MEI_WDT_IDLE: return "IDLE";
> >>> + case MEI_WDT_START: return "START";
> >>> + case MEI_WDT_RUNNING: return "RUNNING";
> >>> + case MEI_WDT
> On 12/17/2015 06:49 AM, Tomas Winkler wrote:
> > Add entry for dumping current watchdog internal state
> >
> > Signed-off-by: Tomas Winkler
> > ---
> > drivers/watchdog/mei_wdt.c | 84
> ++
> > 1 file changed, 84 insertions(+)
> >
> > diff --git a/
> The function can return negative values, so its result should
> be assigned to signed variable.
>
> The problem has been detected using proposed semantic patch
> scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107
>
> Sig
> fasync should return a negative value on error
> and not poll mask POLLERR.
>
> Cc: # 4.3+
> Reported-by: Al Viro
> Signed-off-by: Tomas Winkler
> ---
> drivers/misc/mei/main.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/misc/mei/main.c b/drivers/m
> >>
> >> Any special reason for having two data structures instead of one ?
> >> You could just move the variables from struct mei_wdt_dev into
> >> struct mei_wdt, no ?
> >
> > Yes, on newer platform mei_wdt_dev might be not present in case the the
> > device is not provisioned. This came to act
On Mon, 2015-11-30 at 09:08 -0800, Guenter Roeck wrote:
> On 11/26/2015 04:31 AM, Tomas Winkler wrote:
> > From: Alexander Usyskin
> >
> > For Intel SKL platform the ME device can inform the host via
> > asynchronous notification that the watchdog feature was activated
> > on the
> > device. The
On Mon, 2015-11-30 at 08:55 -0800, Guenter Roeck wrote:
> On 11/26/2015 04:31 AM, Tomas Winkler wrote:
> > From: Alexander Usyskin
> >
> > Create a driver with the generic watchdog interface
> > for the MEI iAMT watchdog device.
> >
> > Signed-off-by: Alexander Usyskin
> > Signed-off-by: Tomas
> + cdb_len = min_t(unsigned short, lrbp->cmd->cmd_len, MAX_CDB_SIZE);
> + memcpy(ucd_req_ptr->sc.cdb, lrbp->cmd->cmnd, cdb_len);
> + if (cdb_len < MAX_CDB_SIZE)
> + memset(ucd_req_ptr->sc.cdb + cdb_len, 0,
> +(MAX_CDB_SIZE - cdb_len));
It's just 16 byt
>
> > > > > goto err;
> > > >
> > > > You should never care if a debugfs call fails or not.
> > >
> > > The system should not be dependent on the debug feature but, it is
> > > always good to know if there our system is failing
> >
> > And what can you do if it is "failing"? Really
> > > > goto err;
> > >
> > > You should never care if a debugfs call fails or not.
> >
> > The system should not be dependent on the debug feature but, it is
> > always good to know if there our system is failing
>
> And what can you do if it is "failing"? Really nothing, so ther
>
> On Mon, Sep 21, 2015 at 10:58:15AM +0300, Tomas Winkler wrote:
> > From: Alexander Kuleshov
> >
> > Signed-off-by: Alexander Kuleshov
> > Signed-off-by: Tomas Winkler
> > ---
> > V2: fixed author address
> >
> > drivers/misc/mei/debugfs.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 delet
> -Original Message-
> From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org]
> Sent: Monday, September 21, 2015 05:25
> To: Prarit Bhargava
> Cc: linux-kernel@vger.kernel.org; Winkler, Tomas; Joe Perches; David S.
> Miller; Jiri
> Kosina; Sharon Dvir; S
> -Original Message-
> From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org]
> Sent: Monday, September 21, 2015 10:37
> To: Alexander Kuleshov
> Cc: Winkler, Tomas; Arnd Bergmann; Usyskin, Alexander; LKML
> Subject: Re: [char-misc 1/2] mei: Fix debugfs filena
>
> On Sun, 2015-08-30 at 10:36 +, Winkler, Tomas wrote:
> > > > >
> > > > >
> > > > > I'm just not sure why the patches are not merged or even rejected.
> > > >
> > > > Because ideally I want a Maintainer ack.
> On 08/29/2015 05:21 PM, Winkler, Tomas wrote:
> >>
> >> Hi Prarit,
> >>
> >> On Fri, Aug 28, 2015 at 07:50:52AM -0400, Prarit Bhargava wrote:
> >>> Heikki, Tomas?
> >>
> >> I'm afraid I don't know much about Intel
> > >
> > >
> > > I'm just not sure why the patches are not merged or even rejected.
> >
> > Because ideally I want a Maintainer ack. That's Doug Gilbert.
James
The patches were discussed and the ACked by Doug in February and reviewed again
after resend by Martin Petersen
> >
> > > I'm submi
>
> Hi Prarit,
>
> On Fri, Aug 28, 2015 at 07:50:52AM -0400, Prarit Bhargava wrote:
> > Heikki, Tomas?
>
> I'm afraid I don't know much about Intel's Management Engine
> Interface. Looks like the driver is from Samuel (CC'd) so I'm guessing
> he is the person you wanted comments from and not me.
> > + /* this should never happen */
> > + if (WARN_ON(!cmnd))
> > + return SCSI_MLQUEUE_HOST_BUSY;
> >
> > - if (NULL == cmnd || NULL == devip) {
> > - pr_warn("called with NULL cmnd or devip pointer\n");
> > + if (NULL == devip) {
> > + pr_warn("called devip
> diff --git a/drivers/misc/mei/wd.c b/drivers/misc/mei/wd.c
> index 2bc0f5089f82..b346638833b0 100644
> --- a/drivers/misc/mei/wd.c
> +++ b/drivers/misc/mei/wd.c
> @@ -364,6 +364,7 @@ int mei_watchdog_register(struct mei_device *dev)
>
> int ret;
>
> + amt_wd_dev.parent = dev->dev;
>
> > > > and consume the event notifications.
> > > > The asynchronous nature is provided via poll and fasync.
> > >
> > > What changed to require a RESEND?
> >
> > You've asked for it.
>
> You might want to give me some context, as I have no idea why I asked
> for a resend. Obviously you must ha
>
> On Sun, Jul 26, 2015 at 09:54:14AM +0300, Tomas Winkler wrote:
> > FW has gained new capability where a FW client can asynchronously
> > notify the host that an event has occurred in its process.
> > The notification doesn't provide any data and host may need to query
> > further the FW clien
>
> Destroy mei_idr on module exit, reclaiming the allocated memory.
>
> This was detected by the following semantic patch (written by Luis Rodriguez
> )
>
> @ defines_module_init @
> declarer name module_init, module_exit;
> declarer name DEFINE_IDR;
> identifier init;
> @@
>
> module_init(ini
>
> On Sat, Jun 13, 2015 at 10:11:34PM +0300, Tomas Winkler wrote:
> > the variables of type mei_cl_device are now cldev
> > the variables of type mei_cl_driver are now cldrv
>
> You are saying what you did, but not why you are doing it. Renaming
> variables for no good reason means I have to
> -Original Message-
> From: Stephen Rothwell [mailto:s...@canb.auug.org.au]
> Sent: Thursday, May 28, 2015 17:41
> To: Greg KH
> Cc: Winkler, Tomas; Samuel Ortiz; a...@arndb.de; linux-...@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] mei:
> Hi all,
>
> After merging the char-misc tree, today's linux-next build (x86_64
> allmodconfig)
> failed like this:
>
Might be the case that this one was left out ?
https://lkml.org/lkml/2015/5/7/522
uuid: extract macros for assigning raw arrays
Tomas
--
To unsubscribe from this list: send
> > > This is a lot to do in just one patch. Any chance you can split it up
> > > into reviewable pieces?
> >
> > I thought it would be harder to swallow but I'm not sure how to really
> > split this into working pieces w/o do some artificial steps which
> > I will have to validate again to keep
>
> On Thu, May 07, 2015 at 03:54:08PM +0300, Tomas Winkler wrote:
> > MEI bus was designed around nfc and was hard to extend.
> > Instead of hard coded way of adding the devices on the mei bus
> > we scan whole me client list and create a device for each
> > eligible me client; currently we suppo
> Cc: a...@arndb.de; linux-kernel@vger.kernel.org
> Subject: Re: [char-misc-next 1/4] mei: export hbm features to debugfs under
> devstate
>
> On Thu, May 21, 2015 at 01:35:48PM +0300, Tomas Winkler wrote:
> > Signed-off-by: Tomas Winkler > Signed-off-by: Tomas Winkler
>
Sorry for that, need t
> On 15-02-23 06:13 AM, Tomas Winkler wrote:
> > The use case to report 'REPORT LUNS WLUN' described
> > in scsi_debug documentation didn't work because:
> > scsi_scan_host_selected() checks for:
> > lun < shost->max_lun
> >
> > To fix this we set:
> > max_lun = SCSI_W_LUN_REPORT_LUNS +
> -Original Message-
> From: Greg KH [mailto:g...@kroah.com]
> Sent: Monday, April 13, 2015 13:43
> To: Stephen Rothwell
> Cc: Arnd Bergmann; Steven Rostedt; linux-n...@vger.kernel.org; linux-
> ker...@vger.kernel.org; Winkler, Tomas
> Subject: Re: linux-next: build
>
> From: Alexander Usyskin
>
> Keep a pointer to associated me client in the host client object to
> eliminate me client searches. Check if the me client is active in the
> firmware by checking if its is linked on the me clients list
> Add accessors for the me client properties from host clien
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Sunday, April 05, 2015 16:19
> To: Winkler, Tomas
> Cc: a...@arndb.de; linux-kernel@vger.kernel.org; Usyskin, Alexander
> Subject: Re: [char-misc-next 04/11] mei: revamp client disconnectio
> > ---
> > drivers/misc/mei/bus.c | 2 -
> > drivers/misc/mei/client.c| 158 +
> --
> > drivers/misc/mei/client.h| 3 +
> > drivers/misc/mei/hbm.c | 8 +--
> > drivers/misc/mei/interrupt.c | 46 +
> > drivers/misc/mei/
> -Original Message-
> From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> Sent: Monday, March 02, 2015 11:41
> To: Wu, Fengguang
> Cc: Winkler, Tomas; Greg Kroah-Hartman; Haiyang Zhang; linux-
> ker...@vger.kernel.org; Nick Meier; kbuild-...@01.org;
> de...@l
>
> On Tue, Feb 10, 2015 at 05:37:36AM +0800, Greg Kroah-Hartman wrote:
> > On Mon, Feb 09, 2015 at 11:27:10AM -0700, Shuah Khan wrote:
> > > On 02/09/2015 01:33 AM, Greg Kroah-Hartman wrote:
> > > > This is the start of the stable review cycle for the 3.18.7 release.
> > > > There are 39 patche
> Julian,
>
> On Mon, Jan 12, 2015 at 12:58:05AM +0100, Julian Brost wrote:
> > This patch series fixes multiple formatting issues in the documentation for
> > the
> > Intel MEI, including improperly formatted headlines and issues with spacing
> > and
> > indentation.
> >
> > Julian Brost (4):
>
> >
> > Signed-off-by: Tomas Winkler
>
> This patch adds build warnings, I can't take it:
>
> drivers/misc/mei/bus.c: In function ‘___mei_cl_send’:
> drivers/misc/mei/bus.c:276:3: warning: ‘cb’ may be used uninitialized in this
> function [-Wmaybe-uninitialized]
>mei_io_cb_free(cb);
>^
>
> -Original Message-
> From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org]
> Sent: Friday, December 19, 2014 00:15
> To: Winkler, Tomas
> Cc: a...@arndb.de; linux-kernel@vger.kernel.org
> Subject: Re: [char-misc-next 1/3 V2] mei: add ABI documenta
>
> Signed-off-by: Tomas Winkler
> ---
> V2: rephrase the description
> Documentation/ABI/testing/sysfs-class-mei | 15 +++
> 1 file changed, 15 insertions(+)
>
Greg you've included 'mei: export fw status registers through sysfs' to
3.19-rc1 pull request
but left this documentat
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Thursday, November 06, 2014 17:58
> To: Winkler, Tomas
> Cc: a...@arndb.de; linux-kernel@vger.kernel.org
> Subject: Re: [char-misc-next V3] mei: add reference counting for me clients
&
>
> On Tue, Nov 04, 2014 at 05:22:51AM +, Winkler, Tomas wrote:
> > >
> > > On Mon, Nov 03, 2014 at 10:42:05AM +0200, Tomas Winkler wrote:
> > > > To support dynamic addition/remove we add reference
> > > > counter.
> > >
> >
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Tuesday, November 04, 2014 18:32
> To: Winkler, Tomas
> Cc: a...@arndb.de; linux-kernel@vger.kernel.org; Usyskin, Alexander
> Subject: Re: [char-misc V3 3.18] mei: nfc: clean nfc inter
> > Stable: 3.15+
>
> Please read Documentation/stable_kernel_rules.txt for how to do this
> properly.
Oops, this is my internal tracking it should be replaced with proper cc to
stable, need to fix my scripts.
> Please resend, after really verifying this does need to go to the stable
> trees.
>
> On Mon, Nov 03, 2014 at 10:42:05AM +0200, Tomas Winkler wrote:
> > To support dynamic addition/remove we add reference
> > counter.
>
> What is keeping two different threads / cpus from grabbing a reference
> at the same time the other one is dropping it?
>
> You have a list here, with no lo
> Subject: [PATCH trivial] mei: Spelling s/domian/domain/, s/stucture/structure/
>
> Signed-off-by: Geert Uytterhoeven
ACK
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel
> -Original Message-
> From: jwbo...@gmail.com [mailto:jwbo...@gmail.com] On Behalf Of Josh Boyer
> Sent: Thursday, August 21, 2014 15:33
> To: Winkler, Tomas
> Cc: Greg KH; Arnd Bergmann; Linux-Kernel@Vger. Kernel. Org
> Subject: Re: [char-misc-next 03/14] mei: me_clie
> > @@ -553,6 +553,7 @@ void mei_nfc_host_exit(struct mei_device *dev)
> > {
> > struct mei_nfc_dev *ndev = &nfc_dev;
> > cancel_work_sync(&ndev->init_work);
> > + memset(ndev, 0, sizeof(struct mei_nfc_dev));
>
> This implies that something is using a "static" device structure, which
>
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Wednesday, May 28, 2014 01:07
> To: Winkler, Tomas
> Cc: a...@arndb.de; linux-kernel@vger.kernel.org; Usyskin, Alexander
> Subject: Re: [char-misc-next 3/3] mei: add WPT second mei interfac
> > +/* PCH devices MEI 2 interface */
> > +const struct mei_cfg mei_me_pch_2_cfg = {
> > + MEI_CFG_PCH_HFS,
> > + .mei_id = 1
>
> That's going to be a recipe for disaster. Have the MEI core allocate
> the id numbers as things are registered, don't have the individual
> drivers create their i
> -Original Message-
> From: Nikola Ciprich [mailto:nikola.cipr...@linuxbox.cz]
> Sent: Tuesday, April 08, 2014 09:50
> To: Winkler, Tomas
> Cc: Greg KH (gre...@linuxfoundation.org); linux-kernel@vger.kernel.org; Nikola
> Ciprich
> Subject: Re: 3.0 -> 3.10 regress
> -Original Message-
> From: Nikola Ciprich [mailto:nikola.cipr...@linuxbox.cz]
> Sent: Monday, April 07, 2014 16:26
> To: Winkler, Tomas
> Cc: Greg KH (gre...@linuxfoundation.org); linux-kernel@vger.kernel.org; Nikola
> Ciprich
> Subject: Re: 3.0 -> 3.10 regress
>
> Hello Tomas,
> > I would need the devices ids of the MEI device on your platform (lspci
> > will do
> the job), is this same platform as you tested before?
> > You should not get to requesting the HW readiness w/ my patch.
>
> yes, it's the same box.
>
> here are the IDs:
>
> 00:16.0 Co
>
> Hi Tomas,
>
> bad news, we just had failed boot with 3.10.35 with your patch:
>
> last line was:
>
> mei_me :00:16.0: wait hw ready failed. status = -110
>
> so it can probably happen that boot hangs on mei_me init attempt..
>
> colleague just told me it also happened to him with 3.
>
> NM and SPS FW types that may run on ME device on server platforms
> do not have valid MEI/HECI interface and driver should not
> be bound to it as this might lead to system hung.
> In practice not all BIOSes effectively hide such devices from the
> OS and in some cases it is not possible.
>
>
> Hi Tomas,
>
> > If this is a server platform can you please try this patch
> https://lkml.org/lkml/2014/3/25/396
>
> tried 3.10.35 with Your patch and now I can see following in dmesg:
>
> [ +0.000290] mei_me :00:16.0: Device doesn't have valid ME Interface
> [ +0.007656] mei_me
> (CC Tomas Winkler)
>
> So finally I got some time to look deeper into this, and the problem
> might not be regression after all.. It is caused by mei_me module,
> blacklisting it "fixes it" for me.
>
> So for me it's kinda of solution, although I guess MEI related people
> might be interested i
> I don't know if this also shows a possible latent bug with lockdep. It
> seems like I should be seeing this bug all the time with kernels 3.6.6 and
> onward. Testing indicates that the bug is present in 3.11, and 3.12 but
> for some reason the reporting of the bug comes-and-goes as patches ar
>
> On Wed, Mar 12, 2014 at 01:19:13PM +0200, Tomas Winkler wrote:
> > From: Alexander Usyskin
> >
> > Consistently display error on possible copy_from/to_user failures
> > use dev_dbg so it cannot be abused to flood the kernel log
> >
> > Signed-off-by: Alexander Usyskin
> > Signed-off-by: Tom
>
> On Sun, 2014-03-16 at 14:35 +0200, Tomas Winkler wrote:
> > use cl_dbg for debug log messages in cl context
>
> I think all the uses of cl_dbg and cl_err are odd.
>
> from: client.h
>
> #define cl_dbg(dev, cl, format, arg...) \
> dev_dbg(&(dev)->pdev->dev, MEI_CL_FMT format, MEI_CL_PR
> On Tue, 11 Mar 2014 14:49:25 +0200
> Tomas Winkler wrote:
>
> > From: Alexander Usyskin
> >
> > Consistently display error on possible copy_from/to_user failures
> > and replace dev_dbg with dev_err
>
> NAK
>
> This allows users to flood the logs by deliberately causing lots of these
> fai
>
> >> If an administrator wants to use MEI, they can search the logs for
> >> 'mei'. Otherwise they don't need a glaring reminder that their
> >> hardware doesn't actually support MEI.
> >>
> >> Signed-off-by: Andy Lutomirski
> >> ---
> >> drivers/misc/mei/pci-me.c | 2 +-
> >> 1 file change
> -Original Message-
> From: Andy Lutomirski [mailto:l...@amacapital.net]
> Sent: Saturday, March 08, 2014 20:58
> To: linux-kernel@vger.kernel.org
> Cc: triv...@kernel.org; Andy Lutomirski; Winkler, Tomas
> Subject: [PATCH 1/4] mei: Don't log an error when th
> > The patch 'mei: set client's read_cb to NULL when flow control fails'
> > (accb884b32e82f943340688c9cd30290531e73e0) Which is in
> > char-misc-linus, still haven't make it to the upstream...I thought it
> > would be in rc3 already.
>
> No, you sent it too late for that.
>
> > I can either f
>
> This patch fails to apply to my char-misc-next branch (I've pulled in
> 3.14-rc3 into this branch now):
> checking file drivers/misc/mei/amthif.c
> checking file drivers/misc/mei/client.c
> Hunk #4 FAILED at 681.
> Hunk #5 succeeded at 815 (offset -2 lines).
> Hu
>
> We currently include in , but I'm about to
> remove that from linux/pci.h, so add explicit includes where needed.
>
> Signed-off-by: Bjorn Helgaas
> ---
> drivers/misc/mei/hw-me.h |1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/misc/mei/hw-me.h b/drivers/misc/mei/hw-
>
> This patch fails to apply:
> checking file drivers/misc/mei/amthif.c
> checking file drivers/misc/mei/client.c
> Hunk #4 FAILED at 681.
> Hunk #5 succeeded at 815 (offset -2 lines).
> Hunk #6 succeeded at 848 (offset -2 lines).
> 1 out of 6 hunks FAILED
>
>
> Building hbm.o for v3.13.2 triggers a GCC warning:
> drivers/misc/mei/hbm.c: In function 'mei_hbm_dispatch':
> drivers/misc/mei/hbm.c:596:3: warning: 'return' with a value, in function
> returning void [enabled by default]
>return 0;
>^
>
> GCC is correct, obviously. S
> -Original Message-
> From: Ian Munsie [mailto:imun...@au1.ibm.com]
> Sent: Wednesday, January 15, 2014 03:58
> To: Winkler, Tomas
> Cc: Stephen Rothwell; Andrew Morton; Greg KH; Arnd Bergmann; linux-
> n...@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: R
> -Original Message-
> From: Stephen Rothwell [mailto:s...@canb.auug.org.au]
> Sent: Tuesday, January 14, 2014 06:51
> To: Andrew Morton; Greg KH; Arnd Bergmann
> Cc: linux-n...@vger.kernel.org; linux-kernel@vger.kernel.org; Ian Munsie;
> Winkler, Tomas
> Subjec
> On Sat, Jan 11, 2014 at 10:46:14PM +0000, Winkler, Tomas wrote:
> >
> >
> > >
> > > This is a _really_ big patch for a stable kernel tree. Are you sure
> > > it's needed there? Please go read Documentation/stable_kernel_rules.txt
> > >
>
> This is a _really_ big patch for a stable kernel tree. Are you sure
> it's needed there? Please go read Documentation/stable_kernel_rules.txt
> again.
I understand it's big though currently I do not have significantly simpler fix
for the issue, all 4 patches are needed to make the reset
> On Wed, Jan 08, 2014 at 08:19:23PM +0200, Tomas Winkler wrote:
> > 1. MEI_DEV_RESETTING device state spans only hardware reset flow
> > while starting dev state is saved into a local variable for further
> > reference, this let us to reduce big if statements in case we
> > are trying to avoid n
> -Original Message-
> From: David Howells [mailto:dhowe...@redhat.com]
> Sent: Friday, January 03, 2014 18:34
> To: Paul Bolle
> Cc: dhowe...@redhat.com; a...@linux-foundation.org; Greg Kroah-Hartman;
> Winkler, Tomas; linux-kernel@vger.kernel.org
> Subject
> On Thu, Dec 05, 2013 at 09:34:44AM +0200, Tomas Winkler wrote:
> > And Lynx Point H Refresh and Wildcat Point LP
> > device ids.
> >
> > Signed-off-by: Tomas Winkler
> > ---
> > V2: remove duplicated LPT entry
> >
> > drivers/misc/mei/hw-me-regs.h | 5 -
> > drivers/misc/mei/pci-me.c
> >
> > diff --git a/drivers/misc/mei/hw-me-regs.h b/drivers/misc/mei/hw-me-regs.h
> > index 6c0fde5..f83bc80 100644
> > --- a/drivers/misc/mei/hw-me-regs.h
> > +++ b/drivers/misc/mei/hw-me-regs.h
> > @@ -110,8 +110,12 @@
> > #define MEI_DEV_ID_PPT_3 0x1DBA /* Panther Point */
> >
> > #defi
>
> > drivers/misc/mei/amthif.c | 4 ++--
> > drivers/misc/mei/debugfs.c | 2 +-
> > drivers/misc/mei/hbm.c | 12 ++--
> > drivers/misc/mei/mei_dev.h | 2 +-
> > 4 files changed, 10 insertions(+), 10 deletions(-)
> >
> > diff --git a/drivers/misc/mei/debugfs.c b/drivers/misc/mei
>
> Correct spelling typo in comments and debug messages.
>
> Signed-off-by: Masanari Iida
Acked
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
> Correct spelling typo in comments within mei/client.c
>
> Signed-off-by: Masanari Iida
Acked
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Pleas
> Correct spelling typo in comments within mei.
>
> Signed-off-by: Masanari Iida
> ---
Acked
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Pleas
> -Original Message-
> From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org]
> Sent: Monday, November 11, 2013 17:02
> To: Winkler, Tomas
> Cc: a...@arndb.de; linux-kernel@vger.kernel.org
> Subject: Re: [char-misc-next 0/3] mei: driver cleanups
>
>
301 - 400 of 460 matches
Mail list logo
