RE: [PATCH 2/3] fpga: dfl: Add DFL bus driver for Altera SPI Master

2021-04-09 Thread Wu, Hao
> On Fri, Apr 09, 2021 at 12:02:47PM +0800, Wu, Hao wrote: > > > > > > > > > > + > > > > > > > > > > +static void dfl_spi_altera_remove(struct dfl_device > > > > > > > > > > *dfl_dev) > > > &g

RE: [PATCH 2/3] fpga: dfl: Add DFL bus driver for Altera SPI Master

2021-04-08 Thread Wu, Hao
> > > > > > > > + > > > > > > > > +static void dfl_spi_altera_remove(struct dfl_device *dfl_dev) > > > > > > > > +{ > > > > > > > > +struct dfl_altera_spi *aspi = dev_get_drvdata(_dev->dev); > > > > > > > > + > > > > > > > > +platform_device_unregister(aspi->altr_spi); > > > > > > > > +} > > > > >

RE: [PATCH 2/3] fpga: dfl: Add DFL bus driver for Altera SPI Master

2021-04-08 Thread Wu, Hao
> On Thu, Apr 08, 2021 at 09:20:19AM +0000, Wu, Hao wrote: > > > On Thu, Apr 08, 2021 at 03:30:15PM +0800, Wu, Hao wrote: > > > > > > On Mon, 5 Apr 2021, Moritz Fischer wrote: > > > > > > > > > > > > > Hi Matthew,

RE: [PATCH 2/3] fpga: dfl: Add DFL bus driver for Altera SPI Master

2021-04-08 Thread Wu, Hao
> On Thu, Apr 08, 2021 at 03:30:15PM +0800, Wu, Hao wrote: > > > > On Mon, 5 Apr 2021, Moritz Fischer wrote: > > > > > > > > > Hi Matthew, > > > > > > > > > > On Mon, Apr 05, 2021 at 04:53:00PM -0700, > &

RE: [PATCH 2/3] fpga: dfl: Add DFL bus driver for Altera SPI Master

2021-04-08 Thread Wu, Hao
> > On Mon, 5 Apr 2021, Moritz Fischer wrote: > > > > > Hi Matthew, > > > > > > On Mon, Apr 05, 2021 at 04:53:00PM -0700, > matthew.gerl...@linux.intel.com wrote: > > > > From: Matthew Gerlach > > > > > > > > This patch adds DFL bus driver for the Altera SPI Master > > > > controller. The SPI

RE: [PATCH v6 1/1] fpga: dfl: afu: harden port enable logic

2021-02-22 Thread Wu, Hao
> Subject: [PATCH v6 1/1] fpga: dfl: afu: harden port enable logic > > Port enable is not complete until ACK = 0. Change > __afu_port_enable() to guarantee that the enable process > is complete by polling for ACK == 0. Looks good to me. Acked-by: Wu Hao Thanks Hao > >

RE: [PATCH v2 1/1] fpga: dfl: afu: harden port enable logic

2021-02-03 Thread Wu, Hao
> On Wed, 3 Feb 2021, Russ Weight wrote: > > > > > > > On 2/3/21 1:28 AM, Wu, Hao wrote: > >>> Subject: Re: [PATCH v2 1/1] fpga: dfl: afu: harden port enable logic > >>> > >>> Sorry for the delay on this patch. It seemed like a lower pr

RE: [PATCH v3 1/1] fpga: dfl: afu: harden port enable logic

2021-02-03 Thread Wu, Hao
> On 2/3/21 1:01 AM, Wu, Hao wrote: > >> Subject: [PATCH v3 1/1] fpga: dfl: afu: harden port enable logic > >> > >> Port enable is not complete until ACK = 0. Change > >> __afu_port_enable() to guarantee that the enable process > >> is comple

RE: [PATCH v2 1/1] fpga: dfl: afu: harden port enable logic

2021-02-03 Thread Wu, Hao
> Subject: Re: [PATCH v2 1/1] fpga: dfl: afu: harden port enable logic > > Sorry for the delay on this patch. It seemed like a lower priority patch than > others, since we haven't seen any issues with current products. Please my > responses inline. > > On 9/17/20 7

RE: [PATCH v3 1/1] fpga: dfl: afu: harden port enable logic

2021-02-03 Thread Wu, Hao
> Subject: [PATCH v3 1/1] fpga: dfl: afu: harden port enable logic > > Port enable is not complete until ACK = 0. Change > __afu_port_enable() to guarantee that the enable process > is complete by polling for ACK == 0. > > Signed-off-by: Russ Weight > --- > v3: > - afu_port_err_clear()

RE: [PATCH v10 2/2] Documentation: fpga: dfl: Add description for DFL UIO support

2021-02-01 Thread Wu, Hao
--- a/Documentation/fpga/dfl.rst > +++ b/Documentation/fpga/dfl.rst > @@ -7,6 +7,7 @@ Authors: > - Enno Luebbers > - Xiao Guangrong > - Wu Hao > +- Xu Yilun > > The Device Feature List (DFL) FPGA framework (and drivers according to > this framework) hides the ve

RE: [PATCH v5 2/2] Documentation: fpga: dfl: Add description for DFL UIO support

2021-01-03 Thread Wu, Hao
fe6..b8497f3 100644 > --- a/Documentation/fpga/dfl.rst > +++ b/Documentation/fpga/dfl.rst > @@ -7,6 +7,7 @@ Authors: > - Enno Luebbers > - Xiao Guangrong > - Wu Hao > +- Xu Yilun > > The Device Feature List (DFL) FPGA framework (and drivers according to > th

RE: [PATCH v5 1/2] fpga: dfl: add the userspace I/O device support for DFL devices

2021-01-03 Thread Wu, Hao
> Subject: [PATCH v5 1/2] fpga: dfl: add the userspace I/O device support for > DFL devices > > This patch supports the DFL drivers be written in userspace. This is > realized by exposing the userspace I/O device interfaces. > > The driver leverages the uio_pdrv_genirq, it adds the

RE: [PATCH v3 2/3] fpga: dfl: add the userspace I/O device support for DFL devices

2020-12-20 Thread Wu, Hao
> Subject: Re: [PATCH v3 2/3] fpga: dfl: add the userspace I/O device support > for DFL devices > > On Fri, Dec 18, 2020 at 05:59:17AM -0800, Tom Rix wrote: > > > > On 12/18/20 12:05 AM, Wu, Hao wrote: > > >> Subject: [PATCH v3 2/3] fpga: dfl: add the userspace

RE: [PATCH v3 2/3] fpga: dfl: add the userspace I/O device support for DFL devices

2020-12-20 Thread Wu, Hao
> Subject: Re: [PATCH v3 2/3] fpga: dfl: add the userspace I/O device support > for DFL devices > > On 12/18/20 12:05 AM, Wu, Hao wrote: > >> Subject: [PATCH v3 2/3] fpga: dfl: add the userspace I/O device support > for > >> DFL devices > >> > >

RE: [PATCH v3 2/3] fpga: dfl: add the userspace I/O device support for DFL devices

2020-12-18 Thread Wu, Hao
> Subject: [PATCH v3 2/3] fpga: dfl: add the userspace I/O device support for > DFL devices > > This patch supports the DFL drivers be written in userspace. This is > realized by exposing the userspace I/O device interfaces. > > The driver leverages the uio_pdrv_genirq, it adds the

RE: [RFC] fpga: dfl: a prototype uio driver

2020-12-06 Thread Wu, Hao
> Subject: Re: [RFC] fpga: dfl: a prototype uio driver > > On Sun, Dec 06, 2020 at 01:55:54PM -0800, t...@redhat.com wrote: > > From: Tom Rix > > > > >From [PATCH 0/2] UIO support for dfl devices > > https://lore.kernel.org/linux-fpga/1602828151-24784-1-git-send-email- > yilun...@intel.com/ > >

RE: [PATCH v3 2/2] fpga: dfl: look for vendor specific capability

2020-12-02 Thread Wu, Hao
> Subject: Re: [PATCH v3 2/2] fpga: dfl: look for vendor specific capability > > Hi Matthew, > > On Mon, Nov 30, 2020 at 04:45:20PM -0800, > matthew.gerl...@linux.intel.com wrote: > > > > > > On Sat, 28 Nov 2020, Wu, Hao wrote: > > > > > &

RE: [PATCH v3 2/2] fpga: dfl: look for vendor specific capability

2020-12-02 Thread Wu, Hao
> > > > > > > > > + } > > > > > + > > > > > + offset = dfl_res & PCI_VNDR_DFLS_RES_OFF_MASK; > > > > > + if (offset >= len) { > > > > > + dev_err(>dev, "%s bad > offset %u >= %pa\n", > > > > > + __func__, offset,

RE: [PATCH] fpga: dfl: add missing platform_device_put in build_info_create_dev

2020-11-25 Thread Wu, Hao
> Subject: [PATCH] fpga: dfl: add missing platform_device_put in > build_info_create_dev > > platform_device_put is missing when it fails to set fdev->id. Set > a temp value to do sanity check. will this case be covered already by build_info_free()? Hao > > Fixes: 543be3d8c999 ("fpga: add

RE: [PATCH 2/2] fpga: dfl: look for vendor specific capability

2020-11-17 Thread Wu, Hao
> On Tue, 17 Nov 2020, Wu, Hao wrote: [...] > >> Open discussion > >> === > >> diff --git a/drivers/fpga/dfl-pci.c b/drivers/fpga/dfl-pci.c > >> index b1b157b41942..5418e8bf2496 100644 > >> --- a/drivers/fpga/dfl-pci.c > &

RE: [PATCH 1/2] fpga: dfl: refactor cci_enumerate_feature_devs()

2020-11-17 Thread Wu, Hao
> Subject: [PATCH 1/2] fpga: dfl: refactor cci_enumerate_feature_devs() > > From: Matthew Gerlach > > In preparation of looking for dfls based on a vendor > specific pcie capability, move code that assumes > Bar0/offset0 as start of DFL to its own function. > > Signed-off-by: Matthew Gerlach

RE: [PATCH 2/2] fpga: dfl: look for vendor specific capability

2020-11-17 Thread Wu, Hao
> > + > > + start = pci_resource_start(pcidev, bar) + offset; > > + len -= offset; > > With these code, I have the following assumption: > > 1. There is only one DFL in one bar, multiple DFLs requires multiple > bars. > > 2. The DFL region is from the "offset" to the end of

RE: [PATCH 2/2] fpga: dfl: look for vendor specific capability

2020-11-17 Thread Wu, Hao
> Subject: [PATCH 2/2] fpga: dfl: look for vendor specific capability > > From: Matthew Gerlach > > A DFL may not begin at offset 0 of BAR 0. A PCIe vendor > specific capability can be used to specify the start of a > number of DFLs. > > Signed-off-by: Matthew Gerlach > --- >

RE: [RFC PATCH 3/6] fpga: dfl: add an API to get the base device for dfl device

2020-10-25 Thread Wu, Hao
> Subject: [RFC PATCH 3/6] fpga: dfl: add an API to get the base device for dfl > device > > This patch adds an API for dfl devices to find which physical device > owns the DFL. > > This patch makes preparation for supporting DFL Ether Group private > feature driver. It uses this information to

RE: [RFC PATCH 2/6] fpga: dfl: export network configuration info for DFL based FPGA

2020-10-25 Thread Wu, Hao
> Subject: [RFC PATCH 2/6] fpga: dfl: export network configuration info for DFL > based FPGA > > This patch makes preparation for supporting DFL Ether Group private > feature driver, which reads bitstream_id.vendor_net_cfg field to > determin the interconnection of network components on FPGA

RE: [PATCH v5 1/7] fpga: sec-mgr: intel fpga security manager class driver

2020-10-25 Thread Wu, Hao
> Subject: [PATCH v5 1/7] fpga: sec-mgr: intel fpga security manager class > driver > > Create the FPGA Security Manager class driver. The security > manager provides interfaces to manage secure updates for the > FPGA and BMC images that are stored in FLASH. The driver can > also be used to

RE: [PATCH 1/2] fpga: dfl: add driver_override support

2020-10-19 Thread Wu, Hao
> On Fri, Oct 16, 2020 at 09:21:50AM -0700, Tom Rix wrote: > > > > On 10/15/20 11:02 PM, Xu Yilun wrote: > > > Add support for overriding the default matching of a dfl device to a dfl > > > driver. It follows the same way that can be used for PCI and platform > > > devices. This patch adds the

RE: [PATCH v2 4/7] fpga: sec-mgr: expose sec-mgr update errors

2020-10-05 Thread Wu, Hao
> Subject: [PATCH v2 4/7] fpga: sec-mgr: expose sec-mgr update errors > > Extend Intel Security Manager class driver to include > an update/error sysfs node that can be read for error > information when a secure update fails. > > Signed-off-by: Russ Weight > --- > v2: > - Bumped documentation

RE: [PATCH v2 3/7] fpga: sec-mgr: expose sec-mgr update status

2020-10-05 Thread Wu, Hao
> Subject: [PATCH v2 3/7] fpga: sec-mgr: expose sec-mgr update status > > Extend the Intel Security Manager class driver to > include an update/status sysfs node that can be polled > and read to monitor the progress of an ongoing secure > update. Sysfs_notify() is used to signal transitions >

RE: [PATCH v2 2/7] fpga: sec-mgr: enable secure updates

2020-10-05 Thread Wu, Hao
> -Original Message- > From: Russ Weight > Sent: Saturday, October 3, 2020 6:37 AM > To: m...@kernel.org; linux-f...@vger.kernel.org; linux- > ker...@vger.kernel.org > Cc: t...@redhat.com; lgonc...@redhat.com; Xu, Yilun ; > Wu, Hao ; Gerlach, Matthew > ; Weight

RE: [PATCH v2 1/7] fpga: sec-mgr: intel fpga security manager class driver

2020-10-05 Thread Wu, Hao
> Subject: [PATCH v2 1/7] fpga: sec-mgr: intel fpga security manager class > driver > > Create the Intel Security Manager class driver. The security > manager provides interfaces to manage secure updates for the > FPGA and BMC images that are stored in FLASH. The driver can > also be used to

RE: [PATCH 01/10] fpga: fpga-mgr: Add devm_fpga_mgr_register() API

2020-10-04 Thread Wu, Hao
> Subject: [PATCH 01/10] fpga: fpga-mgr: Add devm_fpga_mgr_register() API > > Add a devm_fpga_mgr_register() API that can be used to register a FPGA > Manager that was created using devm_fpga_mgr_create(). > > Introduce a struct fpga_mgr_devres that makes the devres > allocation a little bit

RE: [PATCH -next] fpga: dfl: simplify the return expression of fme_perf_pmu_register

2020-09-21 Thread Wu, Hao
> Subject: [PATCH -next] fpga: dfl: simplify the return expression of > fme_perf_pmu_register > > Simplify the return expression. > > Signed-off-by: Liu Shixin Looks good to me. Acked-by: Wu Hao Thanks Hao > --- > drivers/fpga/dfl-fme-perf.c | 7 +-- >

RE: [PATCH v2 1/1] fpga: dfl: afu: harden port enable logic

2020-09-17 Thread Wu, Hao
> Subject: Re: [PATCH v2 1/1] fpga: dfl: afu: harden port enable logic > > On Thu, Sep 17, 2020 at 01:28:22PM -0700, Tom Rix wrote: > > > > On 9/17/20 11:32 AM, Russ Weight wrote: > > > Port enable is not complete until ACK = 0. Change > > > __afu_port_enable() to guarantee that the enable

RE: [PATCH v2 1/1] fpga: dfl: afu: harden port enable logic

2020-09-17 Thread Wu, Hao
> -Original Message- > From: Russ Weight > Sent: Friday, September 18, 2020 2:32 AM > To: m...@kernel.org; linux-f...@vger.kernel.org; linux- > ker...@vger.kernel.org > Cc: t...@redhat.com; lgonc...@redhat.com; Xu, Yilun ; > Wu, Hao ; Gerlach, Matthew > ; Weight

RE: [PATCH v2 3/4] fpga: dfl: fix the comments of type & feature_id fields

2020-09-14 Thread Wu, Hao
ned. We also > > made the similar fix for the type field. > > > > Signed-off-by: Xu Yilun Acked-by: Wu Hao Thanks Hao > > --- > > drivers/fpga/dfl.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/driv

RE: [PATCH] memory: dfl-emif: add the DFL EMIF private feature driver

2020-09-11 Thread Wu, Hao
> Subject: [PATCH] memory: dfl-emif: add the DFL EMIF private feature driver > > This driver is for the EMIF private feature implemented under FPGA > Device Feature List (DFL) framework. It is used to expose memory > interface status information as well as memory clearing control. > > The

RE: [PATCH v1 00/12] Intel FPGA Security Manager Class Driver

2020-09-05 Thread Wu, Hao
> Subject: [PATCH v1 00/12] Intel FPGA Security Manager Class Driver > > > These patches depend on the patchset: "add regmap-spi-avmm & Intel > Max10 BMC chip support" which is currently under review. > >-- > > This patchset

RE: [PATCH v1 01/12] fpga: fpga security manager class driver

2020-09-05 Thread Wu, Hao
> On 9/4/20 5:23 PM, Moritz Fischer wrote: > > Hi Russ, > > > > On Fri, Sep 04, 2020 at 04:52:54PM -0700, Russ Weight wrote: > >> Create the Intel Security Manager class driver. The security > >> manager provides interfaces to manage secure updates for the > >> FPGA and BMC images that are stored

RE: [PATCH v6 3/3] fpga: dfl: add support for N3000 Nios private feature

2020-08-17 Thread Wu, Hao
firmware version. > > For SPI part, this driver adds a spi-altera platform device as well as > the MAX10 BMC spi slave info. A spi-altera driver will be matched to > handle the following SPI work. > > Signed-off-by: Xu Yilun > Signed-off-by: Wu Hao > Signed-off-by: Matthew G

RE: [PATCH v5 3/3] fpga: dfl: add support for N3000 Nios private feature

2020-08-14 Thread Wu, Hao
/dfl-n3000-nios.c > > > new file mode 100644 > > > index 000..aeac224 > > > --- /dev/null > > > +++ b/drivers/fpga/dfl-n3000-nios.c > > > @@ -0,0 +1,528 @@ > > > +// SPDX-License-Identifier: GPL-2.0 > > > +/* > >

RE: [PATCH v5 3/3] fpga: dfl: add support for N3000 Nios private feature

2020-08-13 Thread Wu, Hao
firmware version. > > For SPI part, this driver adds a spi-altera platform device as well as > the MAX10 BMC spi slave info. A spi-altera driver will be matched to > handle the following SPI work. > > Signed-off-by: Xu Yilun > Signed-off-by: Wu Hao > Signed-off-by: Matthew G

RE: [PATCH v5 2/3] fpga: dfl: create a dfl bus type to support DFL devices

2020-08-13 Thread Wu, Hao
ndled by separate driver modules. > > DFL feature drivers (dfl-fme, dfl-port) will create DFL devices on > enumeration. DFL drivers could be registered on this bus to match these > DFL devices. They are matched by dfl type & feature_id. > > Signed-off-by: Xu Yilun >

RE: [PATCH v4 4/4] fpga: dfl: add support for N3000 Nios private feature

2020-08-10 Thread Wu, Hao
era platform device as well as > the MAX10 BMC spi slave info. A spi-altera driver will be matched to > handle following the SPI work. > > Signed-off-by: Xu Yilun > Signed-off-by: Wu Hao > Signed-off-by: Matthew Gerlach > Signed-off-by: Russ Weight > Reviewed-by: Tom Rix

RE: [PATCH v4 3/4] fpga: dfl: create a dfl bus type to support DFL devices

2020-08-10 Thread Wu, Hao
fl-port) will create DFL devices on > enumeration. DFL drivers could be registered on this bus to match these > DFL devices. They are matched by dfl type & feature_id. > > Signed-off-by: Xu Yilun > Signed-off-by: Wu Hao > Signed-off-by: Matthew Gerlach > Signed-off-by: Russ Weight

RE: [PATCH v4 2/4] fpga: dfl: map feature mmio resources in their own feature drivers

2020-08-09 Thread Wu, Hao
> -Original Message- > From: linux-fpga-ow...@vger.kernel.org > On Behalf Of Xu Yilun > Sent: Monday, August 10, 2020 10:41 AM > To: m...@kernel.org; linux-f...@vger.kernel.org; linux- > ker...@vger.kernel.org > Cc: t...@redhat.com; lgonc...@redhat.com; Xu, Yilun

RE: [PATCH v3 3/4] fpga: dfl: create a dfl bus type to support DFL devices

2020-08-06 Thread Wu, Hao
> > > +static int dfl_bus_uevent(struct device *dev, struct kobj_uevent_env > *env) > > > +{ > > > +struct dfl_device *ddev = to_dfl_dev(dev); > > > + > > > +return add_uevent_var(env, "MODALIAS=dfl:t%08Xf%04X", > > > + ddev->type, ddev->feature_id); > > > > Then we only print 12bit of

RE: [PATCH v3 3/4] fpga: dfl: create a dfl bus type to support DFL devices

2020-08-05 Thread Wu, Hao
ndled by separate driver modules. > > DFL feature drivers (dfl-fme, dfl-port) will create DFL devices on > enumeration. DFL drivers could be registered on this bus to match these > DFL devices. They are matched by dfl type & feature_id. > > Signed-off-by: Xu Yilun >

RE: [PATCH v3 2/4] fpga: dfl: map feature mmio resources in their own feature drivers

2020-08-05 Thread Wu, Hao
FIU headers are still mapped in dfl > bus driver. The FIU headers have some fundamental functions (sriov set, > port enable/disable) needed for dfl bus devices and other sub features. > They should not be unmapped as long as dfl bus device is alive. > > Signed-off-by: Xu Yilun >

RE: [PATCH v3 1/4] fpga: dfl: change data type of feature id to u16

2020-08-05 Thread Wu, Hao
> Reviewed-by: Tom Rix Acked-by: Wu Hao Thanks Hao

RE: [PATCH v3 4/4] fpga: dfl: add support for N3000 nios private feature

2020-08-05 Thread Wu, Hao
> Subject: Re: [PATCH v3 4/4] fpga: dfl: add support for N3000 nios private > feature > > Thanks for your quick response, I'm OK with most changes. Some comments > inline. > > On Tue, Aug 04, 2020 at 08:56:12PM +0800, Wu, Hao wrote: > > > Subject: [PATCH v3 4/4] fp

RE: [PATCH] MAINTAINERS: Add Tom Rix as fpga reviewer

2020-08-05 Thread Wu, Hao
> +++ b/MAINTAINERS > > @@ -6805,6 +6805,7 @@ F:drivers/net/ethernet/nvidia/* > > > > FPGA DFL DRIVERS > > M: Wu Hao > > +R: Tom Rix > > L: linux-f...@vger.kernel.org > > S: Maintained > > F: Documentation/fpga/dfl.rst >

RE: [PATCH v3 4/4] fpga: dfl: add support for N3000 nios private feature

2020-08-04 Thread Wu, Hao
well as > the MAX10 BMC spi slave info. A spi-altera driver will be matched to > handle following the SPI work. > > Signed-off-by: Xu Yilun > Signed-off-by: Wu Hao > Signed-off-by: Matthew Gerlach > Signed-off-by: Russ Weight > Reviewed-by: Tom Rix > --- &g

RE: [PATCH 2/2] fpga: dfl: create a dfl bus type to support DFL devices

2020-07-21 Thread Wu, Hao
> > > +} > > > + > > > +dfl_dev->type = feature_dev_id_type(pdev); > > > +dfl_dev->feature_id = (unsigned long long)feature->id; > > > + > > > +dfl_dev->dev.parent = >dev; > > > +dfl_dev->dev.bus = _bus_type; > > > +dfl_dev->dev.release = release_dfl_dev; > > > +dev_set_name(_dev->dev,

RE: [PATCH 0/2] Modularization of DFL private feature drivers

2020-07-20 Thread Wu, Hao
> On 7/16/20 8:48 PM, Wu, Hao wrote: > >> Subject: Re: [PATCH 0/2] Modularization of DFL private feature drivers > >> > >> Generally i think this is a good approach. > >> > >> However I do have concern. > >> > >> The feature_i

RE: [PATCH 1/2] fpga: dfl: map feature mmio resources in their own feature drivers

2020-07-20 Thread Wu, Hao
FIU headers are still mapped in dfl > bus driver. The FIU headers have some fundamental functions (sriov set, > port enable/disable) needed for dfl bus devices and other sub features. > They should not be unmapped as long as dfl bus device is alive. > > Signed-off-by: Xu Yilun > Sig

RE: [PATCH 2/2] fpga: dfl: create a dfl bus type to support DFL devices

2020-07-17 Thread Wu, Hao
> -Original Message- > From: Xu, Yilun > Sent: Wednesday, July 15, 2020 1:38 PM > To: m...@kernel.org; linux-f...@vger.kernel.org; linux- > ker...@vger.kernel.org > Cc: t...@redhat.com; lgonc...@redhat.com; Xu, Yilun ; > Wu, Hao ; Matthew Gerlach > ; Weight, Russel

RE: [PATCH 1/2] fpga: dfl: map feature mmio resources in their own feature drivers

2020-07-17 Thread Wu, Hao
> -Original Message- > From: linux-fpga-ow...@vger.kernel.org > On Behalf Of Xu Yilun > Sent: Wednesday, July 15, 2020 1:38 PM > To: m...@kernel.org; linux-f...@vger.kernel.org; linux- > ker...@vger.kernel.org > Cc: t...@redhat.com; lgonc...@redhat.com; Xu, Yilun

RE: [PATCH 0/2] Modularization of DFL private feature drivers

2020-07-16 Thread Wu, Hao
> Subject: Re: [PATCH 0/2] Modularization of DFL private feature drivers > > Generally i think this is a good approach. > > However I do have concern. > > The feature_id in dfl is magic number, similar to pci id but without a vendor > id. > > Is it possible to add something like a vendor id so

RE: [PATCH] fpga: dfl: pci: add device id for Intel FPGA PAC N3000

2020-07-10 Thread Wu, Hao
> On Thu, Jul 09, 2020 at 06:00:40AM -0700, Tom Rix wrote: > > > > On 7/9/20 3:14 AM, Wu, Hao wrote: > > >> On Thu, Jul 09, 2020 at 05:10:49PM +0800, Wu, Hao wrote: > > >>>> Subject: [PATCH] fpga: dfl: pci: add device id for Intel FPGA PAC N3000 > &

RE: [PATCH] fpga: dfl: pci: add device id for Intel FPGA PAC N3000

2020-07-09 Thread Wu, Hao
> On Thu, Jul 09, 2020 at 05:10:49PM +0800, Wu, Hao wrote: > > > Subject: [PATCH] fpga: dfl: pci: add device id for Intel FPGA PAC N3000 > > > > > > Add PCIe Device ID for Intel FPGA PAC N3000. > > > > > > Signed-off-by: Wu Hao > > > Sign

RE: [PATCH] fpga: dfl: pci: add device id for Intel FPGA PAC N3000

2020-07-09 Thread Wu, Hao
> Subject: [PATCH] fpga: dfl: pci: add device id for Intel FPGA PAC N3000 > > Add PCIe Device ID for Intel FPGA PAC N3000. > > Signed-off-by: Wu Hao > Signed-off-by: Xu Yilun > Signed-off-by: Matthew Gerlach > Signed-off-by: Russ Weight > --- > drivers/f

RE: [PATCH] fpga: dfl: improve configuration of dfl pci devices

2020-06-29 Thread Wu, Hao
> On 6/28/20 8:12 PM, Wu, Hao wrote: > >> -Original Message- > >> From: linux-fpga-ow...@vger.kernel.org ow...@vger.kernel.org> > >> On Behalf Of Xu Yilun > >> Sent: Monday, June 29, 2020 10:19 AM > >> To: t...@redhat.com > >

RE: [PATCH] fpga: dfl: improve configuration of dfl pci devices

2020-06-28 Thread Wu, Hao
> -Original Message- > From: linux-fpga-ow...@vger.kernel.org > On Behalf Of Xu Yilun > Sent: Monday, June 29, 2020 10:19 AM > To: t...@redhat.com > Cc: m...@kernel.org; linux-f...@vger.kernel.org; linux- > ker...@vger.kernel.org; Wu, Hao ; > matthew.gerl...@linux

RE: [PATCH 1/1] fpga: dfl: Fix dead store

2020-06-07 Thread Wu, Hao
> -Original Message- > From: linux-fpga-ow...@vger.kernel.org > On Behalf Of t...@redhat.com > Sent: Sunday, June 7, 2020 5:03 AM > To: m...@kernel.org > Cc: linux-f...@vger.kernel.org; linux-kernel@vger.kernel.org; Tom Rix > > Subject: [PATCH 1/1] fpga: dfl: Fix dead store > Thanks

RE: [PATCH v3] fpga: dfl: afu: convert get_user_pages() --> pin_user_pages()

2020-05-26 Thread Wu, Hao
> -Original Message- > From: John Hubbard > Sent: Tuesday, May 26, 2020 6:18 AM > To: LKML > Cc: John Hubbard ; Xu, Yilun ; > Wu, Hao ; Moritz Fischer ; linux- > f...@vger.kernel.org > Subject: [PATCH v3] fpga: dfl: afu: convert get_user_pages() --> > p

RE: [PATCH v2] fpga: dfl: afu: convert get_user_pages() --> pin_user_pages()

2020-05-24 Thread Wu, Hao
> >> Hi Moritz and FPGA developers, > >> > >> Is this OK? And if so, is it going into your git tree? Or should I > >> send it up through a different tree? (I'm new to the FPGA development > >> model). > > > > I can take it, sorry for sluggish response. > > > > That's great news, thanks Moritz!

RE: [PATCH] fpga: dfl: afu: Corrected error handling levels

2020-05-14 Thread Wu, Hao
> -Original Message- > From: Xu, Yilun > Sent: Thursday, May 14, 2020 10:30 AM > To: Souptick Joarder > Cc: Wu, Hao ; m...@kernel.org; linux- > f...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] fpga: dfl: afu: Corrected error handling levels

RE: [PATCH] fpga: dfl: Replace zero-length array with flexible-array

2020-05-08 Thread Wu, Hao
I think Moritz had already applied it to his tree per last submission. https://lkml.org/lkml/2020/3/21/373 Thanks Hao > -Original Message- > From: matthew.gerl...@linux.intel.com > Sent: Saturday, May 9, 2020 2:21 AM > To: Gustavo A. R. Silva > Cc: Wu, Hao ; linux-f...@

Re: [PATCH v4 06/12] fpga: dfl: afu: export __port_enable/disable function.

2019-08-06 Thread Wu Hao
On Mon, Aug 05, 2019 at 05:52:40PM +0200, Greg KH wrote: > On Sun, Aug 04, 2019 at 06:20:16PM +0800, Wu Hao wrote: > > As these two functions are used by other private features. e.g. > > in error reporting private feature, it requires to check port status > > and reset po

Re: [PATCH] PCI: Add sysfs attribute for disabling PCIe link to downstream component

2019-08-04 Thread Wu Hao
On Thu, Aug 01, 2019 at 04:53:39PM -0500, Bjorn Helgaas wrote: > [+cc FPGA folks, just FYI; I'm pretty sure PCI could do a much better > job supporting FPGAs, so any input is welcome!] > > On Wed, Jul 03, 2019 at 06:03:41PM +0300, Mika Westerberg wrote: > > On Wed, Jul 03, 2019 at 08:39:53AM

Re: [PATCH v3 03/12] fpga: dfl: pci: enable SRIOV support.

2019-07-24 Thread Wu Hao
On Wed, Jul 24, 2019 at 11:37:44AM +0200, Greg KH wrote: > On Tue, Jul 23, 2019 at 12:51:26PM +0800, Wu Hao wrote: > > This patch enables the standard sriov support. It allows user to > > enable SRIOV (and VFs), then user could pass through accelerators > > (VFs) into virtu

Re: [PATCH v2 00/11] FPGA DFL updates

2019-07-10 Thread Wu Hao
On Wed, Jul 10, 2019 at 07:54:17AM +0200, Greg KH wrote: > On Wed, Jul 10, 2019 at 01:07:46PM +0800, Wu Hao wrote: > > On Fri, Jul 05, 2019 at 08:23:47AM +0800, Wu Hao wrote: > > > Hi Greg / Moritz > > > > > > This is v2 patchset which adds more features to F

Re: [PATCH v2 00/11] FPGA DFL updates

2019-07-09 Thread Wu Hao
On Fri, Jul 05, 2019 at 08:23:47AM +0800, Wu Hao wrote: > Hi Greg / Moritz > > This is v2 patchset which adds more features to FPGA DFL. This patchset > is made on top of patch[1] and char-misc-next tree. Documentation patch > for DFL is dropped from this patchset, and will re

[PATCH v2 07/11] fpga: dfl: afu: export __port_enable/disable function.

2019-07-04 Thread Wu Hao
As these two functions are used by other private features. e.g. in error reporting private feature, it requires to check port status and reset port for error clearing. Signed-off-by: Xu Yilun Signed-off-by: Wu Hao Acked-by: Moritz Fischer Acked-by: Alan Tull Signed-off-by: Moritz Fischer

[PATCH v2 09/11] fpga: dfl: afu: add STP (SignalTap) support

2019-07-04 Thread Wu Hao
STP (SignalTap) is one of the private features under the port for debugging. This patch adds private feature driver support for it to allow userspace applications to mmap related mmio region and provide STP service. Signed-off-by: Xu Yilun Signed-off-by: Wu Hao Acked-by: Moritz Fischer Acked

[PATCH v2 00/11] FPGA DFL updates

2019-07-04 Thread Wu Hao
/MODULE_VERSION modifications. (patch #1, #3, #4, #6) - remove argsz from new ioctls. (patch #2) - replace sysfs_create/remove_* with device_add/remove_* for sysfs entries. (patch #5, #8, #11) [1] [PATCH] fpga: dfl: use driver core functions, not sysfs ones. https://lkml.org/lkml/2019/7/4/36 Wu Hao

[PATCH v2 01/11] fpga: dfl: fme: support 512bit data width PR

2019-07-04 Thread Wu Hao
in integrated solution that AVX512 is always supported. This revision 2 hardware doesn't support 32bit PR. Signed-off-by: Ananda Ravuri Signed-off-by: Xu Yilun Signed-off-by: Wu Hao Acked-by: Alan Tull Signed-off-by: Moritz Fischer --- v2: remove DRV/MODULE_VERSION modifications --- drivers

[PATCH v2 02/11] fpga: dfl: fme: add DFL_FPGA_FME_PORT_RELEASE/ASSIGN ioctl support.

2019-07-04 Thread Wu Hao
userspace interfaces on PF. Signed-off-by: Zhang Yi Z Signed-off-by: Xu Yilun Signed-off-by: Wu Hao Acked-by: Alan Tull Acked-by: Moritz Fischer Signed-off-by: Moritz Fischer --- v2: remove argsz from ioctls. --- drivers/fpga/dfl-fme-main.c | 30 drivers/fpga/dfl.c| 107

[PATCH v2 08/11] fpga: dfl: afu: add error reporting support.

2019-07-04 Thread Wu Hao
Error reporting is one important private feature, it reports error detected on port and accelerated function unit (AFU). It introduces several sysfs interfaces to allow userspace to check and clear errors detected by hardware. Signed-off-by: Xu Yilun Signed-off-by: Wu Hao Acked-by: Alan Tull

[PATCH v2 03/11] fpga: dfl: pci: enable SRIOV support.

2019-07-04 Thread Wu Hao
This patch enables the standard sriov support. It allows user to enable SRIOV (and VFs), then user could pass through accelerators (VFs) into virtual machine or use VFs directly in host. Signed-off-by: Zhang Yi Z Signed-off-by: Xu Yilun Signed-off-by: Wu Hao Acked-by: Alan Tull Acked

[PATCH v2 11/11] fpga: dfl: fme: add global error reporting support

2019-07-04 Thread Wu Hao
Signed-off-by: Xu Yilun Signed-off-by: Wu Hao Acked-by: Alan Tull Signed-off-by: Moritz Fischer --- v2: switch to device_add/remove_groups for sysfs. --- Documentation/ABI/testing/sysfs-platform-dfl-fme | 75 + drivers/fpga/Makefile| 2 +- drivers/fpga/dfl-fme

[PATCH v2 04/11] fpga: dfl: afu: add AFU state related sysfs interfaces

2019-07-04 Thread Wu Hao
-by: Ananda Ravuri Signed-off-by: Xu Yilun Signed-off-by: Wu Hao Acked-by: Alan Tull Signed-off-by: Moritz Fischer --- v2: rebased, and remove DRV/MODULE_VERSION modifications --- Documentation/ABI/testing/sysfs-platform-dfl-port | 30 + drivers/fpga/dfl-afu-main.c

[PATCH v2 06/11] fpga: dfl: add id_table for dfl private feature driver

2019-07-04 Thread Wu Hao
This patch adds id_table for each dfl private feature driver, it allows to reuse same private feature driver to match and support multiple dfl private features. Signed-off-by: Xu Yilun Signed-off-by: Wu Hao Acked-by: Moritz Fischer Acked-by: Alan Tull Signed-off-by: Moritz Fischer --- v2

[PATCH v2 05/11] fpga: dfl: afu: add userclock sysfs interfaces.

2019-07-04 Thread Wu Hao
interface is exposed to userspace application for this purpose too. Signed-off-by: Ananda Ravuri Signed-off-by: Russ Weight Signed-off-by: Xu Yilun Signed-off-by: Wu Hao Acked-by: Alan Tull Signed-off-by: Moritz Fischer --- v2: rebased, and switched to use device_add/remove_groups for sysfs

[PATCH v2 10/11] fpga: dfl: fme: add capability sysfs interfaces

2019-07-04 Thread Wu Hao
This patch adds 3 read-only sysfs interfaces for FPGA Management Engine (FME) block for capabilities including cache_size, fabric_version and socket_id. Signed-off-by: Luwei Kang Signed-off-by: Xu Yilun Signed-off-by: Wu Hao Acked-by: Alan Tull Signed-off-by: Moritz Fischer --- v2: rebased

Re: [PATCH] fpga: dfl: use driver core functions, not sysfs ones.

2019-07-04 Thread Wu Hao
ce_remove_groups() Hi Greg, Thanks for this patch. It looks good, and works well in my side. I will follow the same (replace sysfs_create/remove_* with device_add/remove_group) to rework my patchset too. Thanks. Hao > > Cc: Wu Hao > Cc: Alan Tull > Cc: Moritz Fischer > Cc: li

Re: [PATCH v4 05/15] Documentation: fpga: dfl: add descriptions for virtualization and new interfaces.

2019-07-01 Thread Wu Hao
On Fri, Jun 28, 2019 at 10:13:33AM +0800, Wu Hao wrote: > On Thu, Jun 27, 2019 at 06:12:56PM -0700, Moritz Fischer wrote: > > Hi Wu, > > > > On Thu, Jun 27, 2019 at 12:44:45PM +0800, Wu Hao wrote: > > > This patch adds virtualization support description for DFL b

[PATCH v2 05/15] Documentation: fpga: dfl: add descriptions for virtualization and new interfaces.

2019-07-01 Thread Wu Hao
This patch adds virtualization support description for DFL based FPGA devices (based on PCIe SRIOV), and introductions to new interfaces added by new dfl private feature drivers. [m...@kernel.org: Fixed up to make it work with new reStructuredText docs] Signed-off-by: Xu Yilun Signed-off-by: Wu

Re: [PATCH v4 3/3] fpga: dfl: fme: add power management support

2019-06-28 Thread Wu Hao
On Fri, Jun 28, 2019 at 10:55:14AM -0700, Guenter Roeck wrote: > On Thu, Jun 27, 2019 at 12:53:38PM +0800, Wu Hao wrote: > > This patch adds support for power management private feature under > > FPGA Management Engine (FME). This private feature driver registers > &

Re: [PATCH v4 05/15] Documentation: fpga: dfl: add descriptions for virtualization and new interfaces.

2019-06-27 Thread Wu Hao
On Thu, Jun 27, 2019 at 06:12:56PM -0700, Moritz Fischer wrote: > Hi Wu, > > On Thu, Jun 27, 2019 at 12:44:45PM +0800, Wu Hao wrote: > > This patch adds virtualization support description for DFL based > > FPGA devices (based on PCIe SRIOV), and introductions to new > &

Re: [PATCH v4 2/2] fpga: dfl: fme: add performance reporting support

2019-06-27 Thread Wu Hao
On Fri, Jun 28, 2019 at 12:53:29AM +0800, Greg KH wrote: > On Thu, Jun 27, 2019 at 01:09:55PM +0800, Wu Hao wrote: > > This patch adds support for performance reporting private feature > > for FPGA Management Engine (FME). Now it supports several different > > performanc

[PATCH v4 2/2] fpga: dfl: fme: add performance reporting support

2019-06-26 Thread Wu Hao
_mmio_write,portid=0/ Performance counter stats for 'system wide': 0 fme0/fab_mmio_read/ fme0/fab_port_mmio_write,portid=0/ 2.141064085 seconds time elapsed Signed-off-by: Luwei Kang Signed-off-by: Xu Yilun Signed-off-by: Wu Hao --- v3: replace scnprintf w

[PATCH v4 1/2] Documentation: fpga: dfl: add description for performance reporting support

2019-06-26 Thread Wu Hao
From: Xu Yilun This patch adds description for performance reporting support for Device Feature List (DFL) based FPGA. Signed-off-by: Xu Yilun Signed-off-by: Wu Hao --- Documentation/fpga/dfl.txt | 83 ++ 1 file changed, 83 insertions(+) diff

[PATCH v4 0/2] add performance reporting support to FPGA DFL drivers

2019-06-26 Thread Wu Hao
) [1]https://lkml.org/lkml/2019/5/27/11 [2]https://lkml.org/lkml/2019/5/27/18 [3]https://lkml.org/lkml/2019/6/27/29 [4]https://lkml.org/lkml/2019/6/27/49 Wu Hao (1): fpga: dfl: fme: add performance reporting support Xu Yilun (1): Documentation: fpga: dfl: add description for performance reporting

[PATCH v4 05/15] Documentation: fpga: dfl: add descriptions for virtualization and new interfaces.

2019-06-26 Thread Wu Hao
This patch adds virtualization support description for DFL based FPGA devices (based on PCIe SRIOV), and introductions to new interfaces added by new dfl private feature drivers. Signed-off-by: Xu Yilun Signed-off-by: Wu Hao Acked-by: Alan Tull --- Documentation/fpga/dfl.txt | 101

[PATCH v4 13/15] fpga: dfl: afu: add STP (SignalTap) support

2019-06-26 Thread Wu Hao
STP (SignalTap) is one of the private features under the port for debugging. This patch adds private feature driver support for it to allow userspace applications to mmap related mmio region and provide STP service. Signed-off-by: Xu Yilun Signed-off-by: Wu Hao Acked-by: Moritz Fischer Acked

[PATCH v4 08/15] fpga: dfl: afu: add AFU state related sysfs interfaces

2019-06-26 Thread Wu Hao
-by: Ananda Ravuri Signed-off-by: Xu Yilun Signed-off-by: Wu Hao Acked-by: Alan Tull --- v3: replace scnprintf with sprintf in sysfs interfaces. update sysfs doc kernel version and date. v4: update sysfs doc date. --- Documentation/ABI/testing/sysfs-platform-dfl-port | 30 + drivers

[PATCH v4 10/15] fpga: dfl: add id_table for dfl private feature driver

2019-06-26 Thread Wu Hao
This patch adds id_table for each dfl private feature driver, it allows to reuse same private feature driver to match and support multiple dfl private features. Signed-off-by: Xu Yilun Signed-off-by: Wu Hao Acked-by: Moritz Fischer Acked-by: Alan Tull --- drivers/fpga/dfl-afu-main.c | 14

  1   2   3   4   5   6   7   8   9   >