Re: [PATCH 3/3] rpmsg: virtio_rpmsg_bus: get buffer size from config space

2019-06-05 Thread xiang xiao
On Wed, Jun 5, 2019 at 4:02 PM Arnaud Pouliquen wrote: > > > > On 6/5/19 4:40 AM, xiang xiao wrote: > > On Tue, Jun 4, 2019 at 10:25 PM Arnaud Pouliquen > > wrote: > >> > >> Hello Xiang, > >> > >> On 5/9/19 3:00 PM, xiang xiao

Re: [PATCH 0/3] Enhance virtio rpmsg bus driver buffer allocation

2019-06-05 Thread xiang xiao
On Wed, Jun 5, 2019 at 3:33 PM Arnaud Pouliquen wrote: > > Hi Bjorn, > > On 6/5/19 6:34 AM, Bjorn Andersson wrote: > > On Thu 31 Jan 07:41 PST 2019, Xiang Xiao wrote: > > > >> Hi, > >> This series enhance the buffer allocation by: > >> 1.Sup

Re: [PATCH 3/3] rpmsg: virtio_rpmsg_bus: get buffer size from config space

2019-06-04 Thread xiang xiao
On Tue, Jun 4, 2019 at 10:25 PM Arnaud Pouliquen wrote: > > Hello Xiang, > > On 5/9/19 3:00 PM, xiang xiao wrote: > > On Thu, May 9, 2019 at 8:36 PM Arnaud Pouliquen > > wrote: > >> > >> Hello Xiang, > >> > >> Similar mechanism has bee

Re: [PATCH 3/3] rpmsg: virtio_rpmsg_bus: get buffer size from config space

2019-05-09 Thread xiang xiao
ly, the ideal is same for both patch, just the implementation detail is different. > - define a new feature VIRTIO_RPMSG_F_NS. I add this flag to keep the compatibility with old remote peer, and also follow the common virito driver practice. > > Regards > Arnaud > > > On 1/31/19 4:41 PM,

Re: [PATCH 2/3] rpmsg: virtio_rpmsg_bus: allocate rx/tx buffer separately

2019-05-09 Thread xiang xiao
y allocation. > These memories should be declared and mmaped in rproc platform drivers > (memory region) or in resource table (carveout). > This is partially done in the API for the platform driver > (rproc_mem_entry_init) but not available for rproc clients. > > Regards > Ar

Re: [PATCH 2/2] tty: add rpmsg driver

2019-04-15 Thread xiang xiao
On Mon, Apr 15, 2019 at 9:14 PM Enrico Weigelt, metux IT consult wrote: > > On 12.04.19 18:00, Arnaud Pouliquen wrote: > > Hi folks, > > > > Haven't followed the whole thread, but I've got the impression that the > device is emulating an uart - if that's the case wouldn't it be better > to implem

Re: [PATCH 2/2] tty: add rpmsg driver

2019-04-09 Thread xiang xiao
On Tue, Apr 9, 2019 at 3:28 PM Arnaud Pouliquen wrote: > > > > On 4/8/19 3:29 PM, xiang xiao wrote: > > On Mon, Apr 8, 2019 at 8:05 PM Arnaud Pouliquen > > wrote: > >> > >> > >> > >> On 4/6/19 9:56 AM, xiang xiao wrote: > &g

Re: [PATCH 2/2] tty: add rpmsg driver

2019-04-08 Thread xiang xiao
On Mon, Apr 8, 2019 at 8:05 PM Arnaud Pouliquen wrote: > > > > On 4/6/19 9:56 AM, xiang xiao wrote: > > On Sat, Apr 6, 2019 at 12:08 AM Arnaud Pouliquen > > wrote: > >> > >> > >> > >> On 4/5/19 4:03 PM, xiang xiao wrote: > &g

Re: [PATCH 2/2] tty: add rpmsg driver

2019-04-06 Thread xiang xiao
On Sat, Apr 6, 2019 at 12:08 AM Arnaud Pouliquen wrote: > > > > On 4/5/19 4:03 PM, xiang xiao wrote: > > On Fri, Apr 5, 2019 at 8:33 PM Arnaud Pouliquen > > wrote: > >> > >> > >> > >> On 4/5/19 12:12 PM, xiang xiao wrote: > &g

Re: [PATCH 2/2] tty: add rpmsg driver

2019-04-05 Thread xiang xiao
On Fri, Apr 5, 2019 at 8:33 PM Arnaud Pouliquen wrote: > > > > On 4/5/19 12:12 PM, xiang xiao wrote: > > On Fri, Apr 5, 2019 at 12:14 AM Arnaud Pouliquen > > wrote: > >> > >> Hello Xiang, > >> > >> > >> On 4/3/19 2:47 PM, xia

Re: [PATCH 2/2] tty: add rpmsg driver

2019-04-05 Thread xiang xiao
On Fri, Apr 5, 2019 at 12:14 AM Arnaud Pouliquen wrote: > > Hello Xiang, > > > On 4/3/19 2:47 PM, xiang xiao wrote: > > On Thu, Mar 21, 2019 at 11:48 PM Fabien Dessenne > > wrote: > >> > >> This driver exposes a standard tty interface on top of th

Re: [PATCH 2/2] tty: add rpmsg driver

2019-04-03 Thread xiang xiao
On Thu, Mar 21, 2019 at 11:48 PM Fabien Dessenne wrote: > > This driver exposes a standard tty interface on top of the rpmsg > framework through the "rpmsg-tty-channel" rpmsg service. > > This driver supports multi-instances, offering a /dev/ttyRPMSGx entry > per rpmsg endpoint. > How to support

Re: [PATCH] rpmsg: virtio_rpmsg_bus: acknowledge the received creation message

2019-02-22 Thread xiang xiao
Thanks for review. On Fri, Feb 22, 2019 at 6:44 PM Arnaud Pouliquen wrote: > > Hello Xiang, > > > > On 2/12/19 8:13 AM, Xiang Xiao wrote: > > From: QianWenfa > > > > the two phase handsake make the client could initiate the transfer > > immediately with

Re: [PATCH] rpmsg: add clock API redirection driver

2019-02-22 Thread xiang xiao
On Fri, Feb 22, 2019 at 4:19 PM Arnaud Pouliquen wrote: > > Hello Xiang > > On 2/16/19 8:37 PM, Xiang Xiao wrote: > > From: Yanlin Zhu > > > > which could redirect clk API from remote to the kernel > > > > Signed-off-by: Yanlin Zhu > > --- >

[PATCH] rpmsg: add clock API redirection driver

2019-02-16 Thread Xiang Xiao
From: Yanlin Zhu which could redirect clk API from remote to the kernel Signed-off-by: Yanlin Zhu --- drivers/rpmsg/Kconfig | 10 ++ drivers/rpmsg/Makefile| 1 + drivers/rpmsg/rpmsg_clk.c | 284 ++ 3 files changed, 295 insertions(+) creat

[PATCH V3] Add syslog redirection driver

2019-02-16 Thread Xiang Xiao
Changes vs. V2: - Remove memrchr function - Output message line by line Guiding Li (1): rpmsg: add syslog redirection driver drivers/rpmsg/Kconfig| 12 drivers/rpmsg/Makefile | 1 + drivers/rpmsg/rpmsg_syslog.c | 163 +++ 3 files

[PATCH V3] rpmsg: add syslog redirection driver

2019-02-16 Thread Xiang Xiao
From: Guiding Li This driver allows the remote processor to redirect the output of syslog or printf into the kernel log, which is very useful to see what happen in the remote side. Signed-off-by: Guiding Li --- drivers/rpmsg/Kconfig| 12 drivers/rpmsg/Makefile | 1 + driv

Re: [PATCH V2 2/2] rpmsg: add syslog redirection driver

2019-02-16 Thread xiang xiao
On Fri, Feb 15, 2019 at 11:06 PM Andy Shevchenko wrote: > > On Fri, Feb 15, 2019 at 12:31:17AM +0800, xiang xiao wrote: > > On Thu, Feb 14, 2019 at 9:09 PM Andy Shevchenko > > wrote: > > > On Thu, Feb 14, 2019 at 02:02:38PM +0800, Xiang Xiao wrote: > > &g

Re: [PATCH V2 2/2] rpmsg: add syslog redirection driver

2019-02-14 Thread xiang xiao
On Thu, Feb 14, 2019 at 9:09 PM Andy Shevchenko wrote: > > On Thu, Feb 14, 2019 at 02:02:38PM +0800, Xiang Xiao wrote: > > From: Guiding Li > > > > This driver allows the remote processor to redirect the output of > > syslog or printf into the kernel log, which

[PATCH V2 1/2] lib/string: add memrchr function

2019-02-13 Thread Xiang Xiao
pointer to the matching byte or NULL if the character does not occur in the given memory area. Signed-off-by: Xiang Xiao --- include/linux/string.h | 3 +++ lib/string.c | 23 +++ 2 files changed, 26 insertions(+) diff --git a/include/linux/string.h b/include

[PATCH V2 2/2] rpmsg: add syslog redirection driver

2019-02-13 Thread Xiang Xiao
From: Guiding Li This driver allows the remote processor to redirect the output of syslog or printf into the kernel log, which is very useful to see what happen in the remote side. Signed-off-by: Guiding Li --- drivers/rpmsg/Kconfig| 12 drivers/rpmsg/Makefile | 1 + driv

[PATCH 2/2] rpmsg: add syslog redirection driver

2019-02-13 Thread Xiang Xiao
From: Guiding Li This driver allows the remote processor redirect the output of syslog/printf into the kernel log, which is very useful to see what happen in the remote side. Signed-off-by: Guiding Li --- drivers/rpmsg/Kconfig| 12 drivers/rpmsg/Makefile | 1 + drivers/rp

[PATCH 1/2] lib/string: add memrchr function

2019-02-13 Thread Xiang Xiao
pointer to the matching byte or NULL if the character does not occur in the given memory area. Signed-off-by: Xiang Xiao --- include/linux/string.h | 1 + lib/string.c | 21 + 2 files changed, 22 insertions(+) diff --git a/include/linux/string.h b/include/linux

Re: [PATCH] printk: add KERN_NOTIME to skip the timestamp

2019-02-13 Thread xiang xiao
On Wed, Feb 13, 2019 at 10:31 PM Steven Rostedt wrote: > > On Wed, 13 Feb 2019 22:00:04 +0800 > xiang xiao wrote: > > > On Wed, Feb 13, 2019 at 9:47 PM Steven Rostedt wrote: > > > > > > On Wed, 13 Feb 2019 14:19:01 +0800 > > > xiang xiao wrote:

Re: [PATCH] printk: add KERN_NOTIME to skip the timestamp

2019-02-13 Thread xiang xiao
On Wed, Feb 13, 2019 at 9:47 PM Steven Rostedt wrote: > > On Wed, 13 Feb 2019 14:19:01 +0800 > xiang xiao wrote: > > > On Wed, Feb 13, 2019 at 3:46 AM Steven Rostedt wrote: > > > > > > On Wed, 13 Feb 2019 02:11:05 +0800 > > > Xiang Xiao wrote:

Re: [PATCH] printk: add KERN_NOTIME to skip the timestamp

2019-02-13 Thread xiang xiao
On Wed, Feb 13, 2019 at 9:19 PM Petr Mladek wrote: > > On Wed 2019-02-13 14:19:01, xiang xiao wrote: > > On Wed, Feb 13, 2019 at 3:46 AM Steven Rostedt wrote: > > > > > > On Wed, 13 Feb 2019 02:11:05 +0800 > > > Xiang Xiao wrote: > > > > >

Re: [PATCH] printk: add KERN_NOTIME to skip the timestamp

2019-02-13 Thread xiang xiao
On Wed, Feb 13, 2019 at 4:08 PM Sergey Senozhatsky wrote: > > On (02/13/19 15:14), xiang xiao wrote: > > > > But how can I precisely control timestamp on/off per message > > through sysfs node? > > > > Hmm. I don't know how many kernel printk-s you have

Re: [PATCH] printk: add KERN_NOTIME to skip the timestamp

2019-02-12 Thread xiang xiao
But how can I precisely control timestamp on/off per message through sysfs node? On Wed, Feb 13, 2019 at 2:38 PM Sergey Senozhatsky wrote: > > On (02/13/19 15:29), Sergey Senozhatsky wrote: > > > > cat /sys/module/printk/parameters/time ? > ^ > cat / echo > > Works both ways. > > -ss

Re: [PATCH] printk: add KERN_NOTIME to skip the timestamp

2019-02-12 Thread xiang xiao
On Wed, Feb 13, 2019 at 8:48 AM Sergey Senozhatsky wrote: > > On (02/13/19 02:11), Xiang Xiao wrote: > > > > Because log may already add the timestamp sometime > > > > We have module_param(printk_time) which enables/disables > timestamps. And a .config option. And

Re: [PATCH] printk: add KERN_NOTIME to skip the timestamp

2019-02-12 Thread xiang xiao
On Wed, Feb 13, 2019 at 3:46 AM Steven Rostedt wrote: > > On Wed, 13 Feb 2019 02:11:05 +0800 > Xiang Xiao wrote: > > > Because log may already add the timestamp sometime > > Can you be a bit more detailed on this. When and where does this > happen? Here is my case:

Re: [PATCH] lib/string: add memrchr function

2019-02-12 Thread xiang xiao
On Wed, Feb 13, 2019 at 3:15 AM Greg KH wrote: > > On Wed, Feb 13, 2019 at 03:09:19AM +0800, xiang xiao wrote: > > On Wed, Feb 13, 2019 at 2:34 AM Greg KH wrote: > > > > > > On Wed, Feb 13, 2019 at 02:06:49AM +0800, Xiang Xiao wrote: > > > > He

Re: [v2] lib/string: add memrchr function

2019-02-12 Thread xiang xiao
On Wed, Feb 13, 2019 at 3:12 AM Greg KH wrote: > > On Wed, Feb 13, 2019 at 02:54:43AM +0800, Xiang Xiao wrote: > > Here is the detailed description for memrchr: > > > > void *memrchr(const void *s, int c, size_t n); > > > > The memrchr() function is like the m

Re: [PATCH] lib/string: add memrchr function

2019-02-12 Thread xiang xiao
On Wed, Feb 13, 2019 at 2:34 AM Greg KH wrote: > > On Wed, Feb 13, 2019 at 02:06:49AM +0800, Xiang Xiao wrote: > > Here is the detailed description for memrchr: > > https://linux.die.net/man/3/memrchr > > Please put it in the changelog, as web pages move and go away :(

[v2] lib/string: add memrchr function

2019-02-12 Thread Xiang Xiao
pointer to the matching byte or NULL if the character does not occur in the given memory area. Signed-off-by: Xiang Xiao --- include/linux/string.h | 1 + lib/string.c | 21 + 2 files changed, 22 insertions(+) diff --git a/include/linux/string.h b/include/linux

[PATCH] printk: add KERN_NOTIME to skip the timestamp

2019-02-12 Thread Xiang Xiao
Because log may already add the timestamp sometime Signed-off-by: Xiang Xiao --- include/linux/kern_levels.h | 2 ++ include/linux/printk.h | 1 + kernel/printk/printk.c | 7 ++- 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/include/linux/kern_levels.h b/include

[PATCH] lib/string: add memrchr function

2019-02-12 Thread Xiang Xiao
Here is the detailed description for memrchr: https://linux.die.net/man/3/memrchr Signed-off-by: Xiang Xiao --- include/linux/string.h | 1 + lib/string.c | 21 + 2 files changed, 22 insertions(+) diff --git a/include/linux/string.h b/include/linux/string.h index

[PATCH] rpmsg: virtio_rpmsg_bus: acknowledge the received creation message

2019-02-11 Thread Xiang Xiao
From: QianWenfa the two phase handsake make the client could initiate the transfer immediately without the server side send any dummy message first. Signed-off-by: Wenfa Qian Signed-off-by: Xiang Xiao --- drivers/rpmsg/virtio_rpmsg_bus.c | 25 - 1 file changed, 20

[PATCH] rpmsg: add match optional callback to rpmsg_driver

2019-01-31 Thread Xiang Xiao
so the driver could decide whether support a particular device at runtime Signed-off-by: Xiang Xiao --- drivers/rpmsg/rpmsg_core.c | 3 +++ include/linux/rpmsg.h | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c index ea88fd4

[PATCH 2/3] rpmsg: virtio_rpmsg_bus: allocate rx/tx buffer separately

2019-01-31 Thread Xiang Xiao
many dma allocator align the returned address with buffer size, so two small allocation could reduce the alignment requirement and save the the memory space wasted by the potential alignment. Signed-off-by: Xiang Xiao --- drivers/rpmsg/virtio_rpmsg_bus.c | 58

[PATCH 1/3] rpmsg: virtio_rpmsg_bus: allow the different vring size for send/recv

2019-01-31 Thread Xiang Xiao
it's useful if the communication throughput is different from each side Signed-off-by: Xiang Xiao --- drivers/rpmsg/virtio_rpmsg_bus.c | 47 1 file changed, 24 insertions(+), 23 deletions(-) diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/

[PATCH 3/3] rpmsg: virtio_rpmsg_bus: get buffer size from config space

2019-01-31 Thread Xiang Xiao
512 bytes isn't always suitable for all case, let firmware maker decide the best value from resource table. enable by VIRTIO_RPMSG_F_BUFSZ feature bit. Signed-off-by: Xiang Xiao --- drivers/rpmsg/virtio_rpmsg_bus.c | 50 +-- include/uapi/linux/virtio_rp

[PATCH 0/3] Enhance virtio rpmsg bus driver buffer allocation

2019-01-31 Thread Xiang Xiao
Hi, This series enhance the buffer allocation by: 1.Support the different buffer number in rx/tx direction 2.Get the individual rx/tx buffer size from config space Here is the related OpenAMP change: https://github.com/OpenAMP/open-amp/pull/155 Xiang Xiao (3): rpmsg: virtio_rpmsg_bus: allow

Re: [PATCH 1/1] remoteproc: fix recovery procedure

2019-01-21 Thread xiang xiao
On Mon, Jan 21, 2019 at 9:51 PM Loic PALLARDY wrote: > > > > > -Original Message- > > From: xiang xiao > > Sent: lundi 21 janvier 2019 13:45 > > To: Loic PALLARDY > > Cc: bjorn.anders...@linaro.org; o...@wizery.com; linux- > > remotep...@

Re: [PATCH 1/1] remoteproc: fix recovery procedure

2019-01-21 Thread xiang xiao
On Fri, Jan 18, 2019 at 5:44 AM Loic PALLARDY wrote: > > > > > -Original Message- > > From: linux-remoteproc-ow...@vger.kernel.org > ow...@vger.kernel.org> On Behalf Of Loic PALLARDY > > Sent: jeudi 17 janvier 2019 21:52 > > To: Bjorn Andersso

Re: [PATCH 1/1] remoteproc: fix recovery procedure

2019-01-21 Thread xiang xiao
On Fri, Jan 18, 2019 at 1:15 AM Loic PALLARDY wrote: > > Hi Xiang, > > > -Original Message- > > From: linux-remoteproc-ow...@vger.kernel.org > ow...@vger.kernel.org> On Behalf Of xiang xiao > > Sent: mardi 15 janvier 2019 07:46 > > To: Loic PALLARDY

Re: [PATCH 1/1] remoteproc: fix recovery procedure

2019-01-14 Thread xiang xiao
15, 2019 at 4:23 AM Loic PALLARDY wrote: > > Hi Xiang, > > > -Original Message- > > From: xiang xiao > > Sent: samedi 12 janvier 2019 19:29 > > To: Loic PALLARDY > > Cc: bjorn.anders...@linaro.org; o...@wizery.com; linux- > > remotep...@

Re: [PATCH 1/1] remoteproc: fix recovery procedure

2019-01-12 Thread xiang xiao
io_dev to 0 before using it and > registering it. > > Fixes: 7e83cab824a8 ("remoteproc: Modify recovery path to use > rproc_{start,stop}()") > > Reported-by: Xiang Xiao > Signed-off-by: Loic Pallardy > --- > drivers/remoteproc/remoteproc_virtio.c | 2 ++ > 1