[PATCH] i2c: designware: Add device HID for future AMD I2C controller

2016-03-09 Thread Xiangliang Yu
Add device HID AMDI0010 to match the AMD ACPI Vendor ID (AMDI) that was registered in http://www.uefi.org/acpi_id_list, and the I2C controller on future AMD paltform will use the HID instead of AMD0010. Signed-off-by: Xiangliang Yu <xiangliang...@amd.com> --- drivers/acpi/acpi

[PATCH] i2c: designware: Add device HID for future AMD I2C controller

2016-03-09 Thread Xiangliang Yu
Add device HID AMDI0010 to match the AMD ACPI Vendor ID (AMDI) that was registered in http://www.uefi.org/acpi_id_list, and the I2C controller on future AMD paltform will use the HID instead of AMD0010. Signed-off-by: Xiangliang Yu --- drivers/acpi/acpi_apd.c | 1 + drivers

[Resend PATCH V5 0/1] AMD NTB V5 changes

2016-01-20 Thread Xiangliang Yu
Resend V5 for more convenient pick up. Main changes in V5 Only change Signed-off-by to Reviewed-by. Xiangliang Yu (1): [Resend patch V5] NTB: Add support for AMD PCI-Express Non-Transparent Bridge MAINTAINERS |6 + drivers/ntb/hw/Kconfig |1 + drivers/ntb

[Resend PATCH V5 1/1] NTB: Add support for AMD PCI-Express Non-Transparent Bridge

2016-01-20 Thread Xiangliang Yu
scratch-pad registers, and supports up to 16 PCIe lanes running a Gen3 speeds. Signed-off-by: Xiangliang Yu Reviewed-by: Jon Mason Reviewed-by: Allen Hubbe --- MAINTAINERS |6 + drivers/ntb/hw/Kconfig |1 + drivers/ntb/hw/Makefile |1 + drivers/ntb

[PATCH V5 1/1] NTB: Add support for AMD PCI-Express Non-Transparent Bridge

2016-01-20 Thread Xiangliang Yu
scratch-pad registers, and supports up to 16 PCIe lanes running a Gen3 speeds. Signed-off-by: Xiangliang Yu Signed-off-by: Jon Mason Signed-off-by: Allen Hubbe --- MAINTAINERS |6 + drivers/ntb/hw/Kconfig |1 + drivers/ntb/hw/Makefile |1 + drivers

[PATCH V5 0/1] AMD NTB V5 changes

2016-01-20 Thread Xiangliang Yu
Main changes in V5 Change ioread64/iowrite64 to read64/write64 to keep consistent with readl/writel, readw/writel. Add a comment for link check function. Xiangliang Yu (1): NTB: Add support for AMD PCI-Express Non-Transparent Bridge MAINTAINERS |6 + drivers/ntb/hw

[Resend PATCH V5 1/1] NTB: Add support for AMD PCI-Express Non-Transparent Bridge

2016-01-20 Thread Xiangliang Yu
scratch-pad registers, and supports up to 16 PCIe lanes running a Gen3 speeds. Signed-off-by: Xiangliang Yu <xiangliang...@amd.com> Reviewed-by: Jon Mason <jdma...@kudzu.us> Reviewed-by: Allen Hubbe <allen.hu...@emc.com> --- MAINTAINERS |6 + driv

[PATCH V5 1/1] NTB: Add support for AMD PCI-Express Non-Transparent Bridge

2016-01-20 Thread Xiangliang Yu
scratch-pad registers, and supports up to 16 PCIe lanes running a Gen3 speeds. Signed-off-by: Xiangliang Yu <xiangliang...@amd.com> Signed-off-by: Jon Mason <jdma...@kudzu.us> Signed-off-by: Allen Hubbe <allen.hu...@emc.com> --- MAINTAINERS |6 + driv

[PATCH V5 0/1] AMD NTB V5 changes

2016-01-20 Thread Xiangliang Yu
Main changes in V5 Change ioread64/iowrite64 to read64/write64 to keep consistent with readl/writel, readw/writel. Add a comment for link check function. Xiangliang Yu (1): NTB: Add support for AMD PCI-Express Non-Transparent Bridge MAINTAINERS |6 + drivers/ntb/hw

[Resend PATCH V5 0/1] AMD NTB V5 changes

2016-01-20 Thread Xiangliang Yu
Resend V5 for more convenient pick up. Main changes in V5 Only change Signed-off-by to Reviewed-by. Xiangliang Yu (1): [Resend patch V5] NTB: Add support for AMD PCI-Express Non-Transparent Bridge MAINTAINERS |6 + drivers/ntb/hw/Kconfig |1 + drivers/ntb

[PATCH V2 0/3] Change notes of V2

2015-12-23 Thread Xiangliang Yu
Main changes in V2: 1. Fixed compiler warning; 2. Add marcro argument of ndev in NTB_READ_REG/NTB_WRITE_REG; 3. Add notes for flush and wakeup interfaces; Xiangliang Yu (3): NTB: Add AMD PCI-Express NTB driver NTB: Add AMD NTB support in Kconfig and Makefile NTB: Add flush_req and wakeup

[PATCH V2 3/3] NTB: Add flush_req and wakeup interface

2015-12-23 Thread Xiangliang Yu
AMD NTB support two features: flush pending requests and wakeup opposite side from low power state. This patch add two interface to support these features. Signed-off-by: Xiangliang Yu --- drivers/ntb/hw/amd/ntb_hw_amd.c | 40 ++-- drivers/ntb/hw/amd

[PATCH V2 2/3] NTB: Add AMD NTB support in Kconfig and Makefile

2015-12-23 Thread Xiangliang Yu
This patch is to enable AMD NTB support in Kconfig and Makefile. Signed-off-by: Xiangliang Yu --- drivers/ntb/hw/Kconfig | 1 + drivers/ntb/hw/Makefile | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/ntb/hw/Kconfig b/drivers/ntb/hw/Kconfig index 4d5535c..0c5c2a6 100644

[PATCH V2 1/3] NTB: Add AMD PCI-Express NTB driver

2015-12-23 Thread Xiangliang Yu
mechanisms between two systems; Signed-off-by: Xiangliang Yu --- drivers/ntb/hw/amd/Kconfig |7 + drivers/ntb/hw/amd/Makefile |1 + drivers/ntb/hw/amd/ntb_hw_amd.c | 1229 +++ drivers/ntb/hw/amd/ntb_hw_amd.h | 263 + 4 files changed, 1500

[PATCH V2 0/3] Change notes of V2

2015-12-23 Thread Xiangliang Yu
Main changes in V2: 1. Fixed compiler warning; 2. Add marcro argument of ndev in NTB_READ_REG/NTB_WRITE_REG; 3. Add notes for flush and wakeup interfaces; Xiangliang Yu (3): NTB: Add AMD PCI-Express NTB driver NTB: Add AMD NTB support in Kconfig and Makefile NTB: Add flush_req and wakeup

[PATCH V2 1/3] NTB: Add AMD PCI-Express NTB driver

2015-12-23 Thread Xiangliang Yu
mechanisms between two systems; Signed-off-by: Xiangliang Yu <xiangliang...@amd.com> --- drivers/ntb/hw/amd/Kconfig |7 + drivers/ntb/hw/amd/Makefile |1 + drivers/ntb/hw/amd/ntb_hw_amd.c | 1229 +++ drivers/ntb/hw/amd/ntb_hw_amd.h

[PATCH V2 3/3] NTB: Add flush_req and wakeup interface

2015-12-23 Thread Xiangliang Yu
AMD NTB support two features: flush pending requests and wakeup opposite side from low power state. This patch add two interface to support these features. Signed-off-by: Xiangliang Yu <xiangliang...@amd.com> --- drivers/ntb/hw/amd/ntb_hw_amd.

[PATCH V2 2/3] NTB: Add AMD NTB support in Kconfig and Makefile

2015-12-23 Thread Xiangliang Yu
This patch is to enable AMD NTB support in Kconfig and Makefile. Signed-off-by: Xiangliang Yu <xiangliang...@amd.com> --- drivers/ntb/hw/Kconfig | 1 + drivers/ntb/hw/Makefile | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/ntb/hw/Kconfig b/drivers/ntb/hw/Kconfig index 4

[PATCH 2/3] NTB: Add AMD NTB support in Kconfig and Makefile

2015-12-16 Thread Xiangliang Yu
This patch is to enable AMD NTB support in Kconfig and Makefile. Signed-off-by: Xiangliang Yu --- drivers/ntb/hw/Kconfig | 1 + drivers/ntb/hw/Makefile | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/ntb/hw/Kconfig b/drivers/ntb/hw/Kconfig index 4d5535c..0c5c2a6 100644

[PATCH 3/3] NTB: Add flush_req and wakeup interface

2015-12-16 Thread Xiangliang Yu
AMD NTB support two features: flush pending requests and wakeup opposite side from low power state. This patch add two interface to support these features. Signed-off-by: Xiangliang Yu --- drivers/ntb/hw/amd/ntb_hw_amd.c | 16 drivers/ntb/hw/amd/ntb_hw_amd.h | 2 ++ include

[PATCH 1/3] NTB: Add AMD PCI-Express NTB driver

2015-12-16 Thread Xiangliang Yu
mechanisms between two systems; Signed-off-by: Xiangliang Yu --- drivers/ntb/hw/amd/Kconfig |7 + drivers/ntb/hw/amd/Makefile |1 + drivers/ntb/hw/amd/ntb_hw_amd.c | 1225 +++ drivers/ntb/hw/amd/ntb_hw_amd.h | 266 + 4 files changed, 1499

[PATCH 2/3] NTB: Add AMD NTB support in Kconfig and Makefile

2015-12-16 Thread Xiangliang Yu
This patch is to enable AMD NTB support in Kconfig and Makefile. Signed-off-by: Xiangliang Yu <xiangliang...@amd.com> --- drivers/ntb/hw/Kconfig | 1 + drivers/ntb/hw/Makefile | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/ntb/hw/Kconfig b/drivers/ntb/hw/Kconfig index 4

[PATCH 1/3] NTB: Add AMD PCI-Express NTB driver

2015-12-16 Thread Xiangliang Yu
mechanisms between two systems; Signed-off-by: Xiangliang Yu <xiangliang...@amd.com> --- drivers/ntb/hw/amd/Kconfig |7 + drivers/ntb/hw/amd/Makefile |1 + drivers/ntb/hw/amd/ntb_hw_amd.c | 1225 +++ drivers/ntb/hw/amd/ntb_hw_amd.h

[PATCH 3/3] NTB: Add flush_req and wakeup interface

2015-12-16 Thread Xiangliang Yu
AMD NTB support two features: flush pending requests and wakeup opposite side from low power state. This patch add two interface to support these features. Signed-off-by: Xiangliang Yu <xiangliang...@amd.com> --- drivers/ntb/hw/amd/ntb_hw_amd.c | 16 drivers/ntb/

[PATCH v2] I2C: designware: fix IO timeout issue for AMD controller

2015-12-10 Thread Xiangliang Yu
controller interrupt and re-enable i2c interrupt before exiting ISR. To reduce the performance impacts on other vendors, use unlikely function to check flag in ISR. --- Changes in v2: - pass flags with ->driver_data - unmask interrupt right after masking Signed-off-by: Xiangliang Yu --- driv

[PATCH v2] I2C: designware: fix IO timeout issue for AMD controller

2015-12-10 Thread Xiangliang Yu
controller interrupt and re-enable i2c interrupt before exiting ISR. To reduce the performance impacts on other vendors, use unlikely function to check flag in ISR. --- Changes in v2: - pass flags with ->driver_data - unmask interrupt right after masking Signed-off-by: Xiangliang Yu <xian

[PATCH 1/1] AHCI: Fix softreset failed issue of Port Multiplier

2015-11-25 Thread Xiangliang Yu
when sending command. For the first way, i can't find any related rule in AHCI Spec. The second way can avoid disabling FBS and has better performance. Signed-off-by: Xiangliang Yu --- drivers/ata/libahci.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/ata/libahci.c b

[PATCH 1/1] AHCI: Fix softreset failed issue of Port Multiplier

2015-11-25 Thread Xiangliang Yu
when sending command. For the first way, i can't find any related rule in AHCI Spec. The second way can avoid disabling FBS and has better performance. Signed-off-by: Xiangliang Yu <xiangliang...@amd.com> --- drivers/ata/libahci.c | 9 + 1 file changed, 9 insertions(+) diff

[PATCH 1/1] I2C: designware: fix IO timeout issue for AMD controller

2015-11-04 Thread Xiangliang Yu
interrupt after clearing interrupt bits when entering ISR and to enable i2c interrupt before exiting ISR. To reduce the performance impacts on other vendors, use unlikely function to check flag in ISR. Signed-off-by: Xiangliang Yu --- drivers/i2c/busses/i2c-designware-core.c| 6

[PATCH 1/1] I2C: designware: fix IO timeout issue for AMD controller

2015-11-04 Thread Xiangliang Yu
interrupt after clearing interrupt bits when entering ISR and to enable i2c interrupt before exiting ISR. To reduce the performance impacts on other vendors, use unlikely function to check flag in ISR. Signed-off-by: Xiangliang Yu <xiangliang...@amd.com> --- drivers/i2c/busses/i2c-desi

RE: [PATCH 1/3] libsas: modify SATA error handler

2014-08-08 Thread Xiangliang Yu
Hi, Dan > Hi, some notes below: > > On Thu, Apr 24, 2014 at 6:27 AM, Xiangliang Yu wrote: >> Add support for SATA port softreset and port multiplier error >> handling. > > Some more detailed notes about the approach and any caveats would be > appreciated. > &

RE: [PATCH 1/3] libsas: modify SATA error handler

2014-08-08 Thread Xiangliang Yu
Hi, Dan Hi, some notes below: On Thu, Apr 24, 2014 at 6:27 AM, Xiangliang Yu yxlr...@gmail.com wrote: Add support for SATA port softreset and port multiplier error handling. Some more detailed notes about the approach and any caveats would be appreciated. Signed-off-by: Xiangliang Yu

RE: [PATCH 1/3] libsas: modify SATA error handler

2014-08-06 Thread Xiangliang Yu
Hi, Dan I haven't receive your review comments, could you send it to me again, thanks! PS: I can't login my gmail, so please send mail to this count. -Original Message- From: Dan Williams [mailto:dan.j.willi...@intel.com] Sent: 2014年8月7日 1:22 To: Xiangliang Yu Cc: jbottom

RE: [PATCH 1/3] libsas: modify SATA error handler

2014-08-06 Thread Xiangliang Yu
Hi, Dan & James How about the patches about support for PM? Two months had passed since I submitted the patches. Thanks! -Original Message- From: Dan Williams [mailto:dan.j.willi...@intel.com] Sent: 2014年6月4日 0:05 To: Xiangliang Yu Cc: t...@kernel.org; jbottom...@parallels

RE: [PATCH 1/3] libsas: modify SATA error handler

2014-08-06 Thread Xiangliang Yu
Hi, Dan James How about the patches about support for PM? Two months had passed since I submitted the patches. Thanks! -Original Message- From: Dan Williams [mailto:dan.j.willi...@intel.com] Sent: 2014年6月4日 0:05 To: Xiangliang Yu Cc: t...@kernel.org; jbottom...@parallels.com

RE: [PATCH 1/3] libsas: modify SATA error handler

2014-08-06 Thread Xiangliang Yu
Hi, Dan I haven't receive your review comments, could you send it to me again, thanks! PS: I can't login my gmail, so please send mail to this count. -Original Message- From: Dan Williams [mailto:dan.j.willi...@intel.com] Sent: 2014年8月7日 1:22 To: Xiangliang Yu Cc: jbottom

RE: [PATCH 1/3] libsas: modify SATA error handler

2014-06-03 Thread Xiangliang Yu
Hi, How about the patch? >From: Xiangliang Yu >Date: 2014-04-24 21:27 GMT+08:00 >Subject: [PATCH 1/3] libsas: modify SATA error handler >To: t...@kernel.org, jbottom...@parallels.com >Cc: dan.j.willi...@intel.com, todd.e.bra...@intel.com, >>lukasz.do...@intel.com, linu

RE: [PATCH 1/3] libsas: modify SATA error handler

2014-06-03 Thread Xiangliang Yu
Hi, How about the patch? From: Xiangliang Yu yxlr...@gmail.com Date: 2014-04-24 21:27 GMT+08:00 Subject: [PATCH 1/3] libsas: modify SATA error handler To: t...@kernel.org, jbottom...@parallels.com Cc: dan.j.willi...@intel.com, todd.e.bra...@intel.com, lukasz.do...@intel.com, linux

RE: PATCH: mvsas: add support for Supermicro AOC-SAS2LP-MV8

2014-04-28 Thread Xiangliang Yu
> Ben Hutchings already submitted a patch for this twice, which I cc'd you > on: > > http://marc.info/?t=13927720393 > > will you ack it? I can't find this mail in my mail box. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

RE: PATCH: mvsas: add support for Supermicro AOC-SAS2LP-MV8

2014-04-28 Thread Xiangliang Yu
> Ben Hutchings already submitted a patch for this twice, which I cc'd you > on: > > http://marc.info/?t=13927720393 > > will you ack it? PCI_VDEVICE() is a sort of take it or leave it macro. > It's not important and it will look untidy and a bit confusing having a > mix of open coding and

RE: PATCH: mvsas: add support for Supermicro AOC-SAS2LP-MV8

2014-04-28 Thread Xiangliang Yu
Hi, Jan I think below change may be better: { PCI_VDEVICE(MARVELL_EXT, 0x9485), chip_9485 }, > Add support for the AOC-SAS2LP-MV8 SAS-2 controller from SuperMicro. > This controller has subdevice id 0x9485 instead of 0x9480, and apparently > this simple patch is the only thing needed to make it

RE: PATCH: mvsas: add support for Supermicro AOC-SAS2LP-MV8

2014-04-28 Thread Xiangliang Yu
Hi, Jan I think below change may be better: { PCI_VDEVICE(MARVELL_EXT, 0x9485), chip_9485 }, Add support for the AOC-SAS2LP-MV8 SAS-2 controller from SuperMicro. This controller has subdevice id 0x9485 instead of 0x9480, and apparently this simple patch is the only thing needed to make it

RE: PATCH: mvsas: add support for Supermicro AOC-SAS2LP-MV8

2014-04-28 Thread Xiangliang Yu
Ben Hutchings already submitted a patch for this twice, which I cc'd you on: http://marc.info/?t=13927720393 will you ack it? PCI_VDEVICE() is a sort of take it or leave it macro. It's not important and it will look untidy and a bit confusing having a mix of open coding and macros,

RE: PATCH: mvsas: add support for Supermicro AOC-SAS2LP-MV8

2014-04-28 Thread Xiangliang Yu
Ben Hutchings already submitted a patch for this twice, which I cc'd you on: http://marc.info/?t=13927720393 will you ack it? I can't find this mail in my mail box. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

[PATCH 3/3] mvsas: implement port mulitplier functional interface

2014-04-24 Thread Xiangliang Yu
Implement PM interface of libsas to prepare for SATA PM support. Signed-off-by: Xiangliang Yu --- drivers/scsi/mvsas/mv_64xx.c |2 + drivers/scsi/mvsas/mv_94xx.c | 19 drivers/scsi/mvsas/mv_defs.h |1 + drivers/scsi/mvsas/mv_init.c |7 ++ drivers/scsi/mvsas/mv_sas.c | 246

[PATCH 2/3] libsas: add support for SATA port multiplier(PM)

2014-04-24 Thread Xiangliang Yu
Add support for SATA PM so that host can find devices that is attached to PM, and add PM hotplug event support. Signed-off-by: Xiangliang Yu --- drivers/ata/libata-scsi.c | 48 - drivers/scsi/libsas/sas_ata.c | 358 ++- drivers/scsi/libsas

[PATCH 1/3] libsas: modify SATA error handler

2014-04-24 Thread Xiangliang Yu
Add support for SATA port softreset and port multiplier error handling. Signed-off-by: Xiangliang Yu --- drivers/scsi/libsas/sas_ata.c | 226 - include/scsi/libsas.h |6 + 2 files changed, 231 insertions(+), 1 deletions(-) diff --git

[PATCH 0/3] libsas: add support for port multiplier

2014-04-24 Thread Xiangliang Yu
This patch set will support SATA port multiplier(PM) in LIBSAS. LIBSAS is need to implement several key handling to support SATA PM: First,low level driver notify libsas that SATA PM is attached to HBA port. Then, LIBSAS will need to schedule SATA PMP error handler to scan SATA device that is

[PATCH 0/3] libsas: add support for port multiplier

2014-04-24 Thread Xiangliang Yu
This patch set will support SATA port multiplier(PM) in LIBSAS. LIBSAS is need to implement several key handling to support SATA PM: First,low level driver notify libsas that SATA PM is attached to HBA port. Then, LIBSAS will need to schedule SATA PMP error handler to scan SATA device that is

[PATCH 2/3] libsas: add support for SATA port multiplier(PM)

2014-04-24 Thread Xiangliang Yu
Add support for SATA PM so that host can find devices that is attached to PM, and add PM hotplug event support. Signed-off-by: Xiangliang Yu yxlr...@gmail.com --- drivers/ata/libata-scsi.c | 48 - drivers/scsi/libsas/sas_ata.c | 358

[PATCH 1/3] libsas: modify SATA error handler

2014-04-24 Thread Xiangliang Yu
Add support for SATA port softreset and port multiplier error handling. Signed-off-by: Xiangliang Yu yxlr...@gmail.com --- drivers/scsi/libsas/sas_ata.c | 226 - include/scsi/libsas.h |6 + 2 files changed, 231 insertions(+), 1 deletions

[PATCH 3/3] mvsas: implement port mulitplier functional interface

2014-04-24 Thread Xiangliang Yu
Implement PM interface of libsas to prepare for SATA PM support. Signed-off-by: Xiangliang Yu yxlr...@gmail.com --- drivers/scsi/mvsas/mv_64xx.c |2 + drivers/scsi/mvsas/mv_94xx.c | 19 drivers/scsi/mvsas/mv_defs.h |1 + drivers/scsi/mvsas/mv_init.c |7 ++ drivers/scsi/mvsas

Re: [PATCH 1/1] AHCI: disabled FBS prior to issuing software reset

2013-11-13 Thread xiangliang yu
hi how about this patch? do you have any update? thanks! > On Wed, Oct 16, 2013 at 11:36:20AM2013/10/27 Tejun Heo : > Hello, > +0800, xiangliang yu wrote: >> diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c >> index 34c8216..fbe592f 100644 >> --- a/dri

Re: [PATCH 1/1] AHCI: disabled FBS prior to issuing software reset

2013-11-13 Thread xiangliang yu
hi how about this patch? do you have any update? thanks! On Wed, Oct 16, 2013 at 11:36:20AM2013/10/27 Tejun Heo t...@kernel.org: Hello, +0800, xiangliang yu wrote: diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c index 34c8216..fbe592f 100644 --- a/drivers/ata/libahci.c +++ b

Re: [PATCH 1/1] AHCI: disabled FBS prior to issuing software reset

2013-10-27 Thread xiangliang yu
Hi, > Your patch is still completely white space corrupted. Please check > your mail settings. Using git-send-email is usually a good idea. I'm > applying the patch manually this time but *please* make sure your mail > setup is working before posting things next time. Sorry, my gmail maybe

Re: [PATCH 1/1] AHCI: disabled FBS prior to issuing software reset

2013-10-27 Thread xiangliang yu
Hi, Your patch is still completely white space corrupted. Please check your mail settings. Using git-send-email is usually a good idea. I'm applying the patch manually this time but *please* make sure your mail setup is working before posting things next time. Sorry, my gmail maybe has

Re: [PATCH 1/1] AHCI: disabled FBS prior to issuing software reset

2013-10-14 Thread xiangliang yu
Hi, > On Sat, Oct 12, 2013 at 02:56:34PM +0800, xiangliang yu wrote: >> > So it can't find the disk if FBS stays enabled? Can you please attach >> > the boot log before & after? >> >> Below is boot log: > > And it works after the patch, right? Can y

Re: [PATCH 1/1] AHCI: disabled FBS prior to issuing software reset

2013-10-14 Thread xiangliang yu
Hi, On Sat, Oct 12, 2013 at 02:56:34PM +0800, xiangliang yu wrote: So it can't find the disk if FBS stays enabled? Can you please attach the boot log before after? Below is boot log: And it works after the patch, right? Can you please update the patch description so that it includes

Re: [PATCH 1/1] AHCI: disabled FBS prior to issuing software reset

2013-10-13 Thread xiangliang yu
Hi, > On Sat, Oct 12, 2013 at 02:56:34PM +0800, xiangliang yu wrote: >> > So it can't find the disk if FBS stays enabled? Can you please attach >> > the boot log before & after? >> >> Below is boot log: > > And it works after the patch, right? Can y

Re: [PATCH 1/1] AHCI: disabled FBS prior to issuing software reset

2013-10-13 Thread xiangliang yu
Hi, On Sat, Oct 12, 2013 at 02:56:34PM +0800, xiangliang yu wrote: So it can't find the disk if FBS stays enabled? Can you please attach the boot log before after? Below is boot log: And it works after the patch, right? Can you please update the patch description so that it includes

Re: [PATCH 1/1] AHCI: disabled FBS prior to issuing software reset

2013-10-12 Thread xiangliang yu
Hi, > On Sat, Sep 28, 2013 at 09:04:15PM +0800, xiangliang yu wrote: >> hi, Tejun >> i had tested the patch with Marvell 88se9235. And driver can find disk >> if FBS disabled, or can't find disk. > > So it can't find the disk if FBS stays enabled? Can you please a

Re: [PATCH 1/1] AHCI: disabled FBS prior to issuing software reset

2013-10-12 Thread xiangliang yu
Hi, On Sat, Sep 28, 2013 at 09:04:15PM +0800, xiangliang yu wrote: hi, Tejun i had tested the patch with Marvell 88se9235. And driver can find disk if FBS disabled, or can't find disk. So it can't find the disk if FBS stays enabled? Can you please attach the boot log before after

Re: [PATCH 1/1] AHCI: disabled FBS prior to issuing software reset

2013-09-28 Thread xiangliang yu
hi, Tejun i had tested the patch with Marvell 88se9235. And driver can find disk if FBS disabled, or can't find disk. Please see chapter 9.3.9 and 9.3.8 of AHCI spec. Thanks. 2013/9/28 Tejun Heo : > Hello, > > On Sat, Sep 28, 2013 at 07:13:36PM +0800, Xiangliang Yu wrote: >

[PATCH 1/1] AHCI: disabled FBS prior to issuing software reset

2013-09-28 Thread Xiangliang Yu
to issuing software reset, software shall clear PxCMD.ST to '0' and then clear PxFBS.EN to '0'. Signed-off-by: Xiangliang Yu --- drivers/ata/libahci.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c index acfd0f7..8d024a4

[PATCH 1/1] AHCI: disabled FBS prior to issuing software reset

2013-09-28 Thread Xiangliang Yu
to issuing software reset, software shall clear PxCMD.ST to '0' and then clear PxFBS.EN to '0'. Signed-off-by: Xiangliang Yu yxlr...@gmail.com --- drivers/ata/libahci.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c index

Re: [PATCH 1/1] AHCI: disabled FBS prior to issuing software reset

2013-09-28 Thread xiangliang yu
hi, Tejun i had tested the patch with Marvell 88se9235. And driver can find disk if FBS disabled, or can't find disk. Please see chapter 9.3.9 and 9.3.8 of AHCI spec. Thanks. 2013/9/28 Tejun Heo t...@kernel.org: Hello, On Sat, Sep 28, 2013 at 07:13:36PM +0800, Xiangliang Yu wrote: If device

RE: [PATCH 2/2] PCI: fix system hang issue of Marvell SATA host controller

2013-03-09 Thread Xiangliang Yu
Hi, Bjorn >> >> > Fix system hang issue: if first accessed resource file of BAR0 ~ >> >> > BAR4, system will hang after executing lspci command >> >> >> >> This needs more explanation. We've already read the BARs by the >> >> time header quirks are run, so apparently it's not just the mere >>

RE: [PATCH 2/2] PCI: fix system hang issue of Marvell SATA host controller

2013-03-09 Thread Xiangliang Yu
Hi, Bjorn Fix system hang issue: if first accessed resource file of BAR0 ~ BAR4, system will hang after executing lspci command This needs more explanation. We've already read the BARs by the time header quirks are run, so apparently it's not just the mere act of accessing a BAR

RE: [PATCH 2/2] PCI: fix system hang issue of Marvell SATA host controller

2013-03-07 Thread Xiangliang Yu
Hi, Bjorn > >> > Fix system hang issue: if first accessed resource file of BAR0 ~ > >> > BAR4, system will hang after executing lspci command > >> > >> This needs more explanation. We've already read the BARs by the time > >> header quirks are run, so apparently it's not just the mere act of >

RE: [PATCH 2/2] PCI: fix system hang issue of Marvell SATA host controller

2013-03-07 Thread Xiangliang Yu
Hi, Bjorn > > Fix system hang issue: if first accessed resource file of BAR0 ~ > > BAR4, system will hang after executing lspci command > > This needs more explanation. We've already read the BARs by the time > header quirks are run, so apparently it's not just the mere act of > accessing a BAR

RE: [PATCH 1/2] PCI: define macro for marvell vendor ID

2013-03-07 Thread Xiangliang Yu
org; Xiangliang Yu > Subject: Re: [PATCH 1/2] PCI: define macro for marvell vendor ID > > On Thu, Mar 7, 2013 at 7:28 AM, wrote: > > From: Xiangliang Yu > > > > Define PCI_VENDOR_MARVELL_ID_EXT macro for 0x1b4b vendor ID > > "PCI_VENDOR_MARVELL_ID_EXT&qu

RE: [PATCH 1/2] PCI: define macro for marvell vendor ID

2013-03-07 Thread Xiangliang Yu
Hi, Bjorn I will update mvsas and ahci with the macro, just need more time to test it. Thanks! -Original Message- From: Bjorn Helgaas [mailto:bhelg...@google.com] Sent: 2013年3月8日 0:25 To: yxlr...@gmail.com Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; Xiangliang Yu

RE: [PATCH 2/2] PCI: fix system hang issue of Marvell SATA host controller

2013-03-07 Thread Xiangliang Yu
Hi, Bjorn Fix system hang issue: if first accessed resource file of BAR0 ~ BAR4, system will hang after executing lspci command This needs more explanation. We've already read the BARs by the time header quirks are run, so apparently it's not just the mere act of accessing a BAR that

RE: [PATCH 2/2] PCI: fix system hang issue of Marvell SATA host controller

2013-03-07 Thread Xiangliang Yu
Hi, Bjorn Fix system hang issue: if first accessed resource file of BAR0 ~ BAR4, system will hang after executing lspci command This needs more explanation. We've already read the BARs by the time header quirks are run, so apparently it's not just the mere act of accessing a BAR

RE: [PATCH 2/3] [SCSI] mvsas: fix shift in mvs_94xx_free_reg_set()

2012-11-15 Thread Xiangliang Yu
Hi, Xi > > About patch 3, I check the ffz code and found it will check ~0 conditions. > > Can you point me to the ~0 check in ffz code? I also feel like using > __ffs64 makes the code simpler. Yes, it seem to be ok > > Does patch 1 look good to you? Thanks. > Yes Thanks! -- To unsubscribe

RE: [PATCH 2/3] [SCSI] mvsas: fix shift in mvs_94xx_free_reg_set()

2012-11-15 Thread Xiangliang Yu
Hi, Xi About patch 3, I check the ffz code and found it will check ~0 conditions. Can you point me to the ~0 check in ffz code? I also feel like using __ffs64 makes the code simpler. Yes, it seem to be ok Does patch 1 look good to you? Thanks. Yes Thanks! -- To unsubscribe from

RE: [PATCH 2/3] [SCSI] mvsas: fix shift in mvs_94xx_free_reg_set()

2012-11-08 Thread Xiangliang Yu
> On 11/6/12 7:06 AM, James Bottomley wrote: > > > > Why is this necessary? As I read the reg set assignment code, it finds > > a free bit in the 64 bit register and uses that ... which can never be > > greater than 64 so there's no need for the check. > > This patch just tries to be more

RE: [PATCH 2/3] [SCSI] mvsas: fix shift in mvs_94xx_free_reg_set()

2012-11-08 Thread Xiangliang Yu
On 11/6/12 7:06 AM, James Bottomley wrote: Why is this necessary? As I read the reg set assignment code, it finds a free bit in the 64 bit register and uses that ... which can never be greater than 64 so there's no need for the check. This patch just tries to be more defensive for