Re: [PATCH] staging: wilc1000: Fix incorrent type in assignment

On Tue, Feb 26, 2019 at 06:39:28AM +, ajay.kat...@microchip.com wrote: On 2/26/2019 8:58 AM, Bo YU wrote: The patch fixes following sparse warning: drivers/staging/wilc1000/host_interface.c:450:30: warning: incorrect type in assignment (different base types)

Re: [PATCH] staging/ks7070: Removed unused varibale

On Sat, Feb 23, 2019 at 08:43:20AM +0100, Greg KH wrote: On Sat, Feb 23, 2019 at 01:39:39AM -0500, Bo YU wrote: From: Bo Yu Compiling the kernel with W=1 results in the following warning: drivers/staging/ks7010/ks_hostif.c:465:6: warning: variable ‘mib_val_type’ set but not used

Re: [PATCH V2] staging: ks7070: removed unused varibales

On Sat, Feb 23, 2019 at 02:27:12AM -0500, Bo YU wrote: From: Bo Yu Compiling the kernel with W=1 results in the following warning: drivers/staging/ks7010/ks_hostif.c:465:6: warning: variable ‘mib_val_type’ set but not used [-Wunused-but-set-variable] u16 mib_val_type;

Re: [PATCH] staging/erofs: fix sparse's warnings on undeclared symbols in erofs

Hi, On Thu, Feb 21, 2019 at 10:35:01PM +0800, Gao Xiang wrote: Hi Bo, On 2019/2/21 22:28, Bo YU wrote: From: Bo Yu Fix sparse warnings: drivers/staging/erofs/utils.c:134:6: warning: symbol 'erofs_try_to_release_workgroup' was not declared. Should it be static? Fixes:

Re: [PATCH] perf trace: Fix potential USE_AFTER_FREE problem

Hi, On Thu, Feb 14, 2019 at 09:34:11AM +0100, Jiri Olsa wrote: On Thu, Feb 14, 2019 at 12:23:56AM -0500, Bo YU wrote: From: Bo Yu There is a freed pointer "evsel", so fix it. Detected by CoverityScan, CID#1442595("Memory-illegalaccesses (USE_AFTER_FREE)") Fixes: 6ab3bc240ade4("perf trace:

Re: [PATCH V5 2/2] kobject: drop newline from msg string

On Wed, Jan 09, 2019 at 10:21:37AM +0100, Rafael J. Wysocki wrote: On Wed, Jan 9, 2019 at 10:17 AM Bo YU wrote: There is currently a missing terminating newline in non-switch case match when msg == NULL Signed-off-by: Bo YU I have given you an R-by for this one already, so why haven't you

Re: [PATCH v4 1/2] kobject: use pr_warn to replace printk

Hi, On Tue, Jan 08, 2019 at 10:39:57AM +0100, Rafael J. Wysocki wrote: On Tue, Jan 8, 2019 at 4:11 AM Bo YU wrote: This is a fix to replace printk with pr_warn You call it a "fix", but what exactly is wrong with the code as is? Is there any differentions between pr_* and printk? If they

Re: [PATCH v3 2/2] kobject: drop newline from msg string

On Fri, Dec 07, 2018 at 01:04:05PM +0100, Greg KH wrote: On Fri, Dec 07, 2018 at 05:21:49AM -0500, Bo YU wrote: There is currently a missing terminating newline in non-switch case match, when msg == NULL. Signed-off-by: Bo YU --- Changes in v3: Improve the commit log,requested by rafael.

Re: [PATCH v3 2/2] kobject: drop newline from msg string

On Fri, Dec 07, 2018 at 01:04:05PM +0100, Greg KH wrote: On Fri, Dec 07, 2018 at 05:21:49AM -0500, Bo YU wrote: There is currently a missing terminating newline in non-switch case match, when msg == NULL. Signed-off-by: Bo YU --- Changes in v3: Improve the commit log,requested by rafael.

Re: [PATCH v2] kobject: to use pr_warn replace KERN_WARNING

On Tue, Nov 06, 2018 at 09:09:15AM +0100, Rafael J. Wysocki wrote: On Tue, Nov 6, 2018 at 8:58 AM Joe Perches wrote: On Tue, 2018-11-06 at 08:49 +0100, Rafael J. Wysocki wrote: > On Tue, Nov 6, 2018 at 3:42 AM Bo YU wrote: > > Fix warning form checkpatch, use pr_warn replace KERN_WARNING > >

Re: [PATCH v2] kobject: to use pr_warn replace KERN_WARNING

On Tue, Nov 06, 2018 at 09:09:15AM +0100, Rafael J. Wysocki wrote: On Tue, Nov 6, 2018 at 8:58 AM Joe Perches wrote: On Tue, 2018-11-06 at 08:49 +0100, Rafael J. Wysocki wrote: > On Tue, Nov 6, 2018 at 3:42 AM Bo YU wrote: > > Fix warning form checkpatch, use pr_warn replace KERN_WARNING > >

Re: [PATCH 3/3] kobject: fix warnings use pr_* to replace printk

On Wed, Oct 31, 2018 at 09:48:15AM -0700, Joe Perches wrote: On Wed, 2018-10-31 at 09:41 -0400, YU Bo wrote: Hi, On Tue, Oct 30, 2018 at 08:01:50AM -0700, Joe Perches wrote: > On Tue, 2018-10-30 at 08:01 -0400, Bo YU wrote: > > Fix warning from checkpatch.pl use pr_* to repla

Re: [PATCH 3/3] kobject: fix warnings use pr_* to replace printk

On Wed, Oct 31, 2018 at 09:48:15AM -0700, Joe Perches wrote: On Wed, 2018-10-31 at 09:41 -0400, YU Bo wrote: Hi, On Tue, Oct 30, 2018 at 08:01:50AM -0700, Joe Perches wrote: > On Tue, 2018-10-30 at 08:01 -0400, Bo YU wrote: > > Fix warning from checkpatch.pl use pr_* to repla

Re: [PATCH 3/3] kobject: fix warnings use pr_* to replace printk

Hi, On Tue, Oct 30, 2018 at 08:01:50AM -0700, Joe Perches wrote: On Tue, 2018-10-30 at 08:01 -0400, Bo YU wrote: Fix warning from checkpatch.pl use pr_* to replace printk If you look at msg, it can be unterminated with newline. diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c []

Re: [PATCH 3/3] kobject: fix warnings use pr_* to replace printk

Hi, On Tue, Oct 30, 2018 at 08:01:50AM -0700, Joe Perches wrote: On Tue, 2018-10-30 at 08:01 -0400, Bo YU wrote: Fix warning from checkpatch.pl use pr_* to replace printk If you look at msg, it can be unterminated with newline. diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c []

Re: [PATCH] isdn: eicon: fix a missing-check bug

Hello, I am just notice your subject line.There are missing something i think On Sat, May 05, 2018 at 02:32:46PM -0500, Wenwen Wang wrote: In divasmain.c, the function divas_write() firstly invokes the function diva_xdi_open_adapter() to open the adapter that matches with the adapter number

Re: [PATCH] isdn: eicon: fix a missing-check bug

Hello, I am just notice your subject line.There are missing something i think On Sat, May 05, 2018 at 02:32:46PM -0500, Wenwen Wang wrote: In divasmain.c, the function divas_write() firstly invokes the function diva_xdi_open_adapter() to open the adapter that matches with the adapter number

[PATCH] Staging: wlan-ng: Fix trailing */ in block comments.

Fix checkpatch.pl warning: WARNING: Block comments use a trailing */ on a separate line. Signed-off-by: Bo Yu --- drivers/staging/wlan-ng/prism2mib.c | 506 ++-- 1 file changed, 253 insertions(+), 253 deletions(-) diff --git

[PATCH] Staging: wlan-ng: Fix trailing */ in block comments.

Fix checkpatch.pl warning: WARNING: Block comments use a trailing */ on a separate line. Signed-off-by: Bo Yu --- drivers/staging/wlan-ng/prism2mib.c | 506 ++-- 1 file changed, 253 insertions(+), 253 deletions(-) diff --git a/drivers/staging/wlan-ng/prism2mib.c

Re: [PATCH] Staging: wlan-ng: fix comments style

Hi Greg, On Mon, May 09, 2016 at 02:26:13PM +0200, Kroah-Hartman wrote: On Sun, May 08, 2016 at 10:45:16AM -0400, YU Bo wrote: The patch fixed warning reported by checkpatch.pl: Block comments use a trailing */ on a separate line. Signed-off-by: YU Bo <tsu.y...@gmail.com> --- drivers/s

Re: [PATCH] Staging: wlan-ng: fix comments style

Hi Greg, On Mon, May 09, 2016 at 02:26:13PM +0200, Kroah-Hartman wrote: On Sun, May 08, 2016 at 10:45:16AM -0400, YU Bo wrote: The patch fixed warning reported by checkpatch.pl: Block comments use a trailing */ on a separate line. Signed-off-by: YU Bo --- drivers/staging/wlan-ng/prism2mgmt.h

[PATCH] Staging: wlan-ng: fix comments style

The patch fixed warning reported by checkpatch.pl: Block comments use a trailing */ on a separate line. Signed-off-by: YU Bo <tsu.y...@gmail.com> --- drivers/staging/wlan-ng/prism2mgmt.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/w

[PATCH] Staging: wlan-ng: fix comments style

The patch fixed warning reported by checkpatch.pl: Block comments use a trailing */ on a separate line. Signed-off-by: YU Bo --- drivers/staging/wlan-ng/prism2mgmt.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/prism2mgmt.h b/drivers

Re: [PATCH] staging:xgifb: Fix Comparisons should place the constant on the right side of the test warning

On Wed, Apr 27, 2016 at 04:58:36PM +0300, Dan Carpenter wrote: On Wed, Apr 27, 2016 at 09:27:39AM -0400, YU Bo wrote: Fixed checkpatch.pl's warning 'Comparisons should place the constant on the right side of the test' Signed-off-by: YU Bo <tsu.y...@gmail.com> --- drivers/staging

Re: [PATCH] staging:xgifb: Fix Comparisons should place the constant on the right side of the test warning

On Wed, Apr 27, 2016 at 04:58:36PM +0300, Dan Carpenter wrote: On Wed, Apr 27, 2016 at 09:27:39AM -0400, YU Bo wrote: Fixed checkpatch.pl's warning 'Comparisons should place the constant on the right side of the test' Signed-off-by: YU Bo --- drivers/staging/xgifb/vb_setmode.c |4 ++-- 1

Re: [PATCH] staging:xgifb: Fix Comparisons should place the constant on the right side of the test warning

On Wed, Apr 27, 2016 at 04:58:36PM +0300, Dan Carpenter wrote: On Wed, Apr 27, 2016 at 09:27:39AM -0400, YU Bo wrote: Fixed checkpatch.pl's warning 'Comparisons should place the constant on the right side of the test' Signed-off-by: YU Bo <tsu.y...@gmail.com> --- drivers/staging

Re: [PATCH] staging:xgifb: Fix Comparisons should place the constant on the right side of the test warning

On Wed, Apr 27, 2016 at 04:58:36PM +0300, Dan Carpenter wrote: On Wed, Apr 27, 2016 at 09:27:39AM -0400, YU Bo wrote: Fixed checkpatch.pl's warning 'Comparisons should place the constant on the right side of the test' Signed-off-by: YU Bo --- drivers/staging/xgifb/vb_setmode.c |4 ++-- 1

[PATCH] staging:xgifb: Fix Comparisons should place the constant on the right side of the test warning

Fixed checkpatch.pl's warning 'Comparisons should place the constant on the right side of the test' Signed-off-by: YU Bo <tsu.y...@gmail.com> --- drivers/staging/xgifb/vb_setmode.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/xgifb/vb_setmod

[PATCH] staging:xgifb: Fix Comparisons should place the constant on the right side of the test warning

Fixed checkpatch.pl's warning 'Comparisons should place the constant on the right side of the test' Signed-off-by: YU Bo --- drivers/staging/xgifb/vb_setmode.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb

Re: [PATCH] USB: cdc-acm: add support for Sagem Monetel ELC930

On Sat, Mar 12, 2016 at 11:44:51PM +, Nicolas Saenz Julienne wrote: I think that you should add something in here.Describe your change or imporvment. Signed-off-by: Nicolas Saenz Julienne --- drivers/usb/class/cdc-acm.c | 3 +++ 1 file changed, 3 insertions(+) diff

Re: [PATCH] USB: cdc-acm: add support for Sagem Monetel ELC930

On Sat, Mar 12, 2016 at 11:44:51PM +, Nicolas Saenz Julienne wrote: I think that you should add something in here.Describe your change or imporvment. Signed-off-by: Nicolas Saenz Julienne --- drivers/usb/class/cdc-acm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH] staging: xgifb: Fix comment style

Fix comments to use * on subsequent lines. Signed-off-by: YU BO <tsu.y...@gmail.com> --- drivers/staging/xgifb/vb_init.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/xgifb/vb_init.c b/drivers/staging/xgifb/vb_init.c index 26b539

[PATCH] staging: xgifb: Fix comment style

Fix comments to use * on subsequent lines. Signed-off-by: YU BO --- drivers/staging/xgifb/vb_init.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/xgifb/vb_init.c b/drivers/staging/xgifb/vb_init.c index 26b539bc6faf..c7f02c7db4a2 100644

[PATCH] staging: xgifb: Fix comment style

Fix comments to use trailing */ on separste lines. Signed-off-by: YU BO <tsu.y...@gmail.com> --- drivers/staging/xgifb/vb_init.c|3 ++- drivers/staging/xgifb/vb_setmode.c |3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/xgifb/vb_init.c b/d

[PATCH] staging: xgifb: Fix comment style

Fix comments to use trailing */ on separste lines. Signed-off-by: YU BO --- drivers/staging/xgifb/vb_init.c|3 ++- drivers/staging/xgifb/vb_setmode.c |3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/xgifb/vb_init.c b/drivers/staging/xgifb

Re: [PATCH] staging: xgifb: Fix comments style in vb_init.c

On Fri, Mar 11, 2016 at 01:41:40PM -0800, Kroah-Hartman wrote: On Tue, Feb 23, 2016 at 11:45:18PM -0500, YU Bo wrote: Fix comments to use trailing */ on separate lines. Signed-off-by: YU BO <tsu.y...@gmail.com> You sent me 2 patches that did different things yet had the same subjec

Re: [PATCH] staging: xgifb: Fix comments style in vb_init.c

On Fri, Mar 11, 2016 at 01:41:40PM -0800, Kroah-Hartman wrote: On Tue, Feb 23, 2016 at 11:45:18PM -0500, YU Bo wrote: Fix comments to use trailing */ on separate lines. Signed-off-by: YU BO You sent me 2 patches that did different things yet had the same subject line :( Please fix up

[PATCH] staging: xgifb: Fix comments style in vb_init.c

Fix comments to use trailing */ on separate lines. Signed-off-by: YU BO <tsu.y...@gmail.com> --- drivers/staging/xgifb/vb_init.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/xgifb/vb_init.c b/drivers/staging/xgifb/vb_init.c index 4

[PATCH] staging: xgifb: Fix comments style in vb_init.c

Fix comments to use trailing */ on separate lines. Signed-off-by: YU BO --- drivers/staging/xgifb/vb_init.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/xgifb/vb_init.c b/drivers/staging/xgifb/vb_init.c index 4cb9ff4..8fc8a95 100644

[PATCH] staging: xgifb: Fix comments style in vb_init.c

Fix comments to use trailing */ on separate lines. Signed-off-by: YU BO <tsu.y...@gmail.com> --- drivers/staging/xgifb/vb_init.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/xgifb/vb_init.c b/drivers/staging/xgifb/vb_init.c index 26b539b..4

[PATCH] staging: xgifb: Fix comments style in vb_init.c

Fix comments to use trailing */ on separate lines. Signed-off-by: YU BO --- drivers/staging/xgifb/vb_init.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/xgifb/vb_init.c b/drivers/staging/xgifb/vb_init.c index 26b539b..4cb9ff4 100644 --- a/drivers

[PATCH] Staging: xgifb: vb_init.c: Coding style warning fix block comment

This is a patch to the vb_init.c file that fixes up a warning reported by checkpatch.pl: WARNING: Block comments use * on subsequent lines Signed-off-by: YU BO --- drivers/staging/xgifb/vb_init.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging

[PATCH] Staging: xgifb: vb_init: Coding style warning fix block comments

This is a patch to the vb_init.c file that fixes up a warning reported by checkpatch.pl: WARNING: Block comments use a trailing */ on a separate line Singed-off-by: YU BO --- drivers/staging/xgifb/vb_init.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH] Staging: xgifb: vb_init.c: Coding style warning fix block comments

This patch is to vb_init.c file that fixes up following warnings reported by checkpatch.pl: WARNING: Block comments use a trailing */ on a separate line Signed-off-by: YU BO --- drivers/staging/xgifb/vb_init.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH] Staging: xgifb: vb_init.c: Coding style warning fix block comments

This patch is to vb_init.c file that fixes up following warnings reported by checkpatch.pl: WARNING: Block comments use a trailing */ on a separate line Signed-off-by: YU BO <tsu.y...@gmail.com> --- drivers/staging/xgifb/vb_init.c |6 -- 1 file changed, 4 insertions(+), 2 del

[PATCH] Staging: xgifb: vb_init: Coding style warning fix block comments

This is a patch to the vb_init.c file that fixes up a warning reported by checkpatch.pl: WARNING: Block comments use a trailing */ on a separate line Singed-off-by: YU BO <tsu.y...@gmail.com> --- drivers/staging/xgifb/vb_init.c |6 -- 1 file changed, 4 insertions(+), 2 del

[PATCH] Staging: xgifb: vb_init.c: Coding style warning fix block comment

This is a patch to the vb_init.c file that fixes up a warning reported by checkpatch.pl: WARNING: Block comments use * on subsequent lines Signed-off-by: YU BO <tsu.y...@gmail.com> --- drivers/staging/xgifb/vb_init.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-)