of kernel logs.
Signed-off-by: Subhash Jadavani <subha...@codeaurora.org>
Signed-off-by: Yaniv Gardi <yga...@codeaurora.org>
---
drivers/scsi/ufs/ufshcd.c | 93 +++
drivers/scsi/ufs/ufshci.h | 2 +
2 files changed, 95 insertions(+)
diff --g
Shvili <rshv...@codeaurora.org>
Signed-off-by: Yaniv Gardi <yga...@codeaurora.org>
---
drivers/scsi/ufs/Makefile | 2 +-
drivers/scsi/ufs/ufs.h| 32 +++
drivers/scsi/ufs/ufs_quirks.c | 100 ++
drivers/scsi/ufs/
port UniPro ver 1.6 or later, we have to manually
tune them. But to keep manual tuning logic simple, we will only do
manual tuning if local unipro version doesn't support ver1.6 or later.
Signed-off-by: Subhash Jadavani <subha...@codeaurora.org>
Signed-off-by: Yaniv Gardi <yga...@c
Query commands have 100ms timeout and it may timeout if they are
issued in parallel to ongoing read/write SCSI commands, this change
adds the retry (max: 10) in case command timeouts.
Signed-off-by: Subhash Jadavani <subha...@codeaurora.org>
Signed-off-by: Yaniv Gardi <yga...@codea
Query commands have 100ms timeout and it may timeout if they are
issued in parallel to ongoing read/write SCSI commands, this change
adds the retry (max: 10) in case command timeouts.
Signed-off-by: Subhash Jadavani <subha...@codeaurora.org>
Signed-off-by: Yaniv Gardi <yga...@codea
Different platform may have different number of lanes
for the UFS link.
Add parameter to device tree specifying how many lanes
should be configured for the UFS link.
Signed-off-by: Gilad Broner <gbro...@codeaurora.org>
Signed-off-by: Yaniv Gardi <yga...@codeaurora.org>
---
..
the
PRDT table length to zero which should take care of commands which doesn't
have any data associated with it. We are also clearing the unused fields in
request UPIU for NOP command.
Reviewed-by: Gilad Broner
Reviewed-by: Dolev Raviv
Signed-off-by: Subhash Jadavani
Signed-off-by: Yaniv Gardi
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/ufshcd.c | 22 --
1 file changed, 20 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 8a34f61..4863e93 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
is done with tag which was set to -1
and so it is invalid.
Assert command tag passed from scsi layer is valid.
Reviewed-by: Subhash Jadavani
Reviewed-by: Dolev Raviv
Signed-off-by: Gilad Broner
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/ufshcd.c | 24 ++--
1 file changed
have to retry fDeviceInit query requests multiple times and
each query request timeout prints one error message.
Reviewed-by: Gilad Broner
Reviewed-by: Dolev Raviv
Signed-off-by: Subhash Jadavani
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/ufshcd.c | 12 +++-
1 file changed, 11
from first 2 context listed above. This change fixes
the recovery by adding proper error handling mechanism.
Reviewed-by: Gilad Broner
Reviewed-by: Dolev Raviv
Signed-off-by: Subhash Jadavani
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/ufshcd.c | 58
of descriptors takes places before ringing the
doorbell, similarly to setting up a transfer request.
Reviewed-by: Dolev Raviv
Signed-off-by: Gilad Broner
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/ufshcd.c | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/ufshcd.c | 41 +++--
1 file changed, 27 insertions(+), 14 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 87da429..a1e9d82 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b
Reviewed-by: Dolev Raviv
Signed-off-by: Lee Susman
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/ufshcd.c | 40 +---
1 file changed, 29 insertions(+), 11 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index e374b79..4c0827f
is recovered to active state, tries to put the UFS link in
hibern8 enter again until retry count expires.
Reviewed-by: Gilad Broner
Reviewed-by: Dolev Raviv
Signed-off-by: Subhash Jadavani
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/ufshcd.c | 26 --
1 file changed, 24
Broner
Reviewed-by: Dolev Raviv
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/ufshcd.c | 51 ---
1 file changed, 44 insertions(+), 7 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 2fc678d..7ab6a45 100644
-by: Gilad Broner
Signed-off-by: Subhash Jadavani
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/ufshcd.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 1893a14..2fc678d 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs
UFS flag query requests may fail sometimes due to timeouts etc.
Add a wrapper function to retry up to 10 times in case of such
failure, similar to retries being made for attribute queries.
Reviewed-by: Dolev Raviv
Signed-off-by: Gilad Broner
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs
while PM callbacks are running.
Reviewed-by: Gilad Broner
Reviewed-by: Dolev Raviv
Signed-off-by: Subhash Jadavani
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/ufshcd.c | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi
.
V2:
a few minor changes
V1:
This serie of 15 small patches should be pushed after the series of 8 patches
I have uploaded to the upstream a week ago:
"Fix error message and present UFS variant probe"
Yaniv Gardi (14):
scsi: ufs: clear UTRD, UPIU req and rsp before new transfers
-by: Dolev Raviv
Signed-off-by: Subhash Jadavani
Signed-off-by: Maya Erez
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/ufshcd.c | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 85cd256..03533f0
from first 2 context listed above. This change fixes
the recovery by adding proper error handling mechanism.
Reviewed-by: Gilad Broner <gbro...@codeaurora.org>
Reviewed-by: Dolev Raviv <dra...@codeaurora.org>
Signed-off-by: Subhash Jadavani <subha...@codeaurora.org>
Signed-off-by
have to retry fDeviceInit query requests multiple times and
each query request timeout prints one error message.
Reviewed-by: Gilad Broner <gbro...@codeaurora.org>
Reviewed-by: Dolev Raviv <dra...@codeaurora.org>
Signed-off-by: Subhash Jadavani <subha...@codeaurora.org>
Signed-off-by
bro...@codeaurora.org>
Reviewed-by: Dolev Raviv <dra...@codeaurora.org>
Signed-off-by: Subhash Jadavani <subha...@codeaurora.org>
Signed-off-by: Maya Erez <me...@codeaurora.org>
Signed-off-by: Yaniv Gardi <yga...@codeaurora.org>
---
drivers/scsi/ufs/ufshcd.c | 16 ++
is done with tag which was set to -1
and so it is invalid.
Assert command tag passed from scsi layer is valid.
Reviewed-by: Subhash Jadavani <subha...@codeaurora.org>
Reviewed-by: Dolev Raviv <dra...@codeaurora.org>
Signed-off-by: Gilad Broner <gbro...@codeaurora.org>
Signed-off-by
Broner <gbro...@codeaurora.org>
Reviewed-by: Dolev Raviv <dra...@codeaurora.org>
Signed-off-by: Yaniv Gardi <yga...@codeaurora.org>
---
drivers/scsi/ufs/ufshcd.c | 22 --
1 file changed, 20 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/d
dra...@codeaurora.org>
Signed-off-by: Gilad Broner <gbro...@codeaurora.org>
Signed-off-by: Subhash Jadavani <subha...@codeaurora.org>
Signed-off-by: Yaniv Gardi <yga...@codeaurora.org>
---
drivers/scsi/ufs/ufshcd.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/scsi/ufs/ufs
g>
Signed-off-by: Yaniv Gardi <yga...@codeaurora.org>
---
drivers/scsi/ufs/ufshcd.c | 63 ---
drivers/scsi/ufs/ufshcd.h | 4 +++
2 files changed, 41 insertions(+), 26 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufsh
while PM callbacks are running.
Reviewed-by: Gilad Broner <gbro...@codeaurora.org>
Reviewed-by: Dolev Raviv <dra...@codeaurora.org>
Signed-off-by: Subhash Jadavani <subha...@codeaurora.org>
Signed-off-by: Yaniv Gardi <yga...@codeaurora.org>
---
drivers/scsi/ufs/ufshcd.c | 15
.
V2:
a few minor changes
V1:
This serie of 15 small patches should be pushed after the series of 8 patches
I have uploaded to the upstream a week ago:
"Fix error message and present UFS variant probe"
Yaniv Gardi (14):
scsi: ufs: clear UTRD, UPIU req and rsp before new transfers
Broner <gbro...@codeaurora.org>
Reviewed-by: Dolev Raviv <dra...@codeaurora.org>
Signed-off-by: Yaniv Gardi <yga...@codeaurora.org>
---
drivers/scsi/ufs/ufshcd.c | 51 ---
1 file changed, 44 insertions(+), 7 deletions(-)
diff --git
<gbro...@codeaurora.org>
Reviewed-by: Dolev Raviv <dra...@codeaurora.org>
Signed-off-by: Lee Susman <lsus...@codeaurora.org>
Signed-off-by: Yaniv Gardi <yga...@codeaurora.org>
---
drivers/scsi/ufs/ufshcd.c | 40 +---
1 file changed, 29 ins
is recovered to active state, tries to put the UFS link in
hibern8 enter again until retry count expires.
Reviewed-by: Gilad Broner <gbro...@codeaurora.org>
Reviewed-by: Dolev Raviv <dra...@codeaurora.org>
Signed-off-by: Subhash Jadavani <subha...@codeaurora.org>
Signed-off-by
of descriptors takes places before ringing the
doorbell, similarly to setting up a transfer request.
Reviewed-by: Dolev Raviv <dra...@codeaurora.org>
Signed-off-by: Gilad Broner <gbro...@codeaurora.org>
Signed-off-by: Yaniv Gardi <yga...@codeaurora.org>
---
drivers/scsi
v <dra...@codeaurora.org>
Signed-off-by: Subhash Jadavani <subha...@codeaurora.org>
Signed-off-by: Yaniv Gardi <yga...@codeaurora.org>
---
drivers/scsi/ufs/ufshcd.c | 41 +++--
1 file changed, 27 insertions(+), 14 deletions(-)
diff --git a/dri
;
Signed-off-by: Subhash Jadavani <subha...@codeaurora.org>
Signed-off-by: Yaniv Gardi <yga...@codeaurora.org>
---
drivers/scsi/ufs/ufshcd.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 03533f0..7ae87c9 10064
is recovered to active state, tries to put the UFS link in
hibern8 enter again until retry count expires.
Reviewed-by: Gilad Broner
Reviewed-by: Dolev Raviv
Signed-off-by: Subhash Jadavani
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/ufshcd.c | 26 --
1 file changed, 24
According to UFS device specification REQUEST_SENSE command can
only report back up to 18 bytes of data.
Reviewed-by: Dolev Raviv
Signed-off-by: Gilad Broner
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/ufshcd.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/ufshcd.c | 22 --
1 file changed, 20 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 8860a57..e0b8755 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
lls to wmb() since they are redundant.
V2:
a few minor changes
V1:
This serie of 15 small patches should be pushed after the series of 8 patches
I have uploaded to the upstream a week ago:
"Fix error message and present UFS variant probe"
Yaniv Gardi (15):
scsi: ufs: clear UTRD, UPIU re
-by: Dolev Raviv
Signed-off-by: Subhash Jadavani
Signed-off-by: Maya Erez
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/ufshcd.c | 17 +
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 131c720..3428f72
while PM callbacks are running.
Reviewed-by: Gilad Broner
Reviewed-by: Dolev Raviv
Signed-off-by: Subhash Jadavani
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/ufshcd.c | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi
is done with tag which was set to -1
and so it is invalid.
Assert command tag passed from scsi layer is valid.
Reviewed-by: Subhash Jadavani
Reviewed-by: Dolev Raviv
Signed-off-by: Gilad Broner
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/ufshcd.c | 24 ++--
1 file changed
Reviewed-by: Dolev Raviv
Signed-off-by: Lee Susman
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/ufshcd.c | 40 +---
1 file changed, 29 insertions(+), 11 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 8a04691..5005d12
of descriptors takes places before ringing the
doorbell, similarly to setting up a transfer request.
Reviewed-by: Dolev Raviv
Signed-off-by: Gilad Broner
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/ufshcd.c | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff
-by: Gilad Broner
Signed-off-by: Subhash Jadavani
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/ufshcd.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index dfc4ac1..ec90504 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/ufshcd.c | 41 +++--
1 file changed, 27 insertions(+), 14 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 889a7be..24a879d 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b
from first 2 context listed above. This change fixes
the recovery by adding proper error handling mechanism.
Reviewed-by: Gilad Broner
Reviewed-by: Dolev Raviv
Signed-off-by: Subhash Jadavani
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/ufshcd.c | 58
UFS flag query requests may fail sometimes due to timeouts etc.
Add a wrapper function to retry up to 10 times in case of such
failure, similar to retries being made for attribute queries.
Reviewed-by: Dolev Raviv
Signed-off-by: Gilad Broner
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs
Broner
Reviewed-by: Dolev Raviv
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/ufshcd.c | 51 ---
1 file changed, 44 insertions(+), 7 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index ec90504..1d1e681 100644
the
PRDT table length to zero which should take care of commands which doesn't
have any data associated with it. We are also clearing the unused fields in
request UPIU for NOP command.
Reviewed-by: Gilad Broner
Reviewed-by: Dolev Raviv
Signed-off-by: Subhash Jadavani
Signed-off-by: Yaniv Gardi
have to retry fDeviceInit query requests multiple times and
each query request timeout prints one error message.
Reviewed-by: Gilad Broner
Reviewed-by: Dolev Raviv
Signed-off-by: Subhash Jadavani
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/ufshcd.c | 12 +++-
1 file changed, 11
This patch adds ufshcd_get_variant() and ufshcd_set_variant()
routines in order to get/set the variant specific data.
Reviewed-by: Akinobu Mita
Reviewed-by: Subhash Jadavani
Reviewed-by: Gilad Broner
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/ufs-qcom.c | 34
This change is required in order to be able to build the component
as a module.
Reviewed-by: Akinobu Mita
Reviewed-by: Subhash Jadavani
Reviewed-by: Gilad Broner
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
qcom.ko] undefined!
make[1]: *** [__modpost] Error 1
Reviewed-by: Akinobu Mita
Reviewed-by: Subhash Jadavani
Reviewed-by: Gilad Broner
Signed-off-by: Yaniv Gardi
---
drivers/phy/phy-qcom-ufs.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/drivers/phy/phy-qcom-ufs.c b/drivers/phy/
-by: Subhash Jadavani
Reviewed-by: Gilad Broner
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/ufs-qcom.c | 640
drivers/scsi/ufs/ufs-qcom.h | 31 ++-
drivers/scsi/ufs/ufshcd.c | 8 +-
drivers/scsi/ufs/ufshcd.h | 27 +-
4 files changed, 525
ob Herring
Reviewed-by: Gilad Broner
Signed-off-by: Yaniv Gardi
---
Documentation/devicetree/bindings/ufs/ufs-qcom.txt | 58 +
.../devicetree/bindings/ufs/ufshcd-pltfrm.txt | 11 ++-
drivers/scsi/ufs/ufs-qcom.c| 62 +-
drivers/scsi
Adds support for configuring and reading the test bus and debug
registers. This change also adds another vops in order to print the
debug registers.
Reviewed-by: Subhash Jadavani
Reviewed-by: Gilad Broner
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/ufs-qcom.c | 165
lad Broner
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/ufs-qcom.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c
index 4cdffa4..6c23bbf 100644
--- a/drivers/scsi/ufs/ufs-qcom.c
+++ b/drivers/scsi/ufs/
In order to simplify the code a set of wrapper functions is created
to test and call each of the variant operations.
Reviewed-by: Akinobu Mita
Reviewed-by: Subhash Jadavani
Reviewed-by: Gilad Broner
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/ufs-qcom.c | 1 -
drivers/scsi/ufs
of unnecessary EXPORT_SYMBOL,
types of parameters in routine definition,
build errors in case CONFIG_PM is not defined and some
other minor fixes.
Yaniv Gardi (8):
phy: qcom-ufs: fix build error when the component is built as a module
scsi: ufs-qcom: fix compilation warning if compiled as a module
scsi
<gbro...@codeaurora.org>
Reviewed-by: Dolev Raviv <dra...@codeaurora.org>
Signed-off-by: Lee Susman <lsus...@codeaurora.org>
Signed-off-by: Yaniv Gardi <yga...@codeaurora.org>
---
drivers/scsi/ufs/ufshcd.c | 40 +---
1 file changed, 29 ins
dra...@codeaurora.org>
Signed-off-by: Gilad Broner <gbro...@codeaurora.org>
Signed-off-by: Subhash Jadavani <subha...@codeaurora.org>
Signed-off-by: Yaniv Gardi <yga...@codeaurora.org>
---
drivers/scsi/ufs/ufshcd.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/scsi/ufs/ufs
;
Signed-off-by: Subhash Jadavani <subha...@codeaurora.org>
Signed-off-by: Yaniv Gardi <yga...@codeaurora.org>
---
drivers/scsi/ufs/ufshcd.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 3428f72..2d3ebca 10064
g>
Signed-off-by: Yaniv Gardi <yga...@codeaurora.org>
---
drivers/scsi/ufs/ufshcd.c | 63 ---
drivers/scsi/ufs/ufshcd.h | 4 +++
2 files changed, 41 insertions(+), 26 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufsh
have to retry fDeviceInit query requests multiple times and
each query request timeout prints one error message.
Reviewed-by: Gilad Broner <gbro...@codeaurora.org>
Reviewed-by: Dolev Raviv <dra...@codeaurora.org>
Signed-off-by: Subhash Jadavani <subha...@codeaurora.org>
Signed-off-by
ob Herring <robherri...@gmail.com>
Reviewed-by: Gilad Broner <gbro...@codeaurora.org>
Signed-off-by: Yaniv Gardi <yga...@codeaurora.org>
---
Documentation/devicetree/bindings/ufs/ufs-qcom.txt | 58 +
.../devicetree/bindings/ufs/ufshcd-pltfrm.txt
v <dra...@codeaurora.org>
Signed-off-by: Subhash Jadavani <subha...@codeaurora.org>
Signed-off-by: Yaniv Gardi <yga...@codeaurora.org>
---
drivers/scsi/ufs/ufshcd.c | 41 +++--
1 file changed, 27 insertions(+), 14 deletions(-)
diff --git a/dri
from first 2 context listed above. This change fixes
the recovery by adding proper error handling mechanism.
Reviewed-by: Gilad Broner <gbro...@codeaurora.org>
Reviewed-by: Dolev Raviv <dra...@codeaurora.org>
Signed-off-by: Subhash Jadavani <subha...@codeaurora.org>
Signed-off-by
of descriptors takes places before ringing the
doorbell, similarly to setting up a transfer request.
Reviewed-by: Dolev Raviv <dra...@codeaurora.org>
Signed-off-by: Gilad Broner <gbro...@codeaurora.org>
Signed-off-by: Yaniv Gardi <yga...@codeaurora.org>
---
drivers/scsi
According to UFS device specification REQUEST_SENSE command can
only report back up to 18 bytes of data.
Reviewed-by: Dolev Raviv <dra...@codeaurora.org>
Signed-off-by: Gilad Broner <gbro...@codeaurora.org>
Signed-off-by: Yaniv Gardi <yga...@codeaurora.org>
---
drivers/scsi
Broner <gbro...@codeaurora.org>
Reviewed-by: Dolev Raviv <dra...@codeaurora.org>
Signed-off-by: Yaniv Gardi <yga...@codeaurora.org>
---
drivers/scsi/ufs/ufshcd.c | 22 --
1 file changed, 20 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/d
is recovered to active state, tries to put the UFS link in
hibern8 enter again until retry count expires.
Reviewed-by: Gilad Broner <gbro...@codeaurora.org>
Reviewed-by: Dolev Raviv <dra...@codeaurora.org>
Signed-off-by: Subhash Jadavani <subha...@codeaurora.org>
Signed-off-by
Adds support for configuring and reading the test bus and debug
registers. This change also adds another vops in order to print the
debug registers.
Reviewed-by: Subhash Jadavani <subha...@codeaurora.org>
Reviewed-by: Gilad Broner <gbro...@codeaurora.org>
Signed-off-by: Yani
Broner <gbro...@codeaurora.org>
Reviewed-by: Dolev Raviv <dra...@codeaurora.org>
Signed-off-by: Yaniv Gardi <yga...@codeaurora.org>
---
drivers/scsi/ufs/ufshcd.c | 51 ---
1 file changed, 44 insertions(+), 7 deletions(-)
diff --git
while PM callbacks are running.
Reviewed-by: Gilad Broner <gbro...@codeaurora.org>
Reviewed-by: Dolev Raviv <dra...@codeaurora.org>
Signed-off-by: Subhash Jadavani <subha...@codeaurora.org>
Signed-off-by: Yaniv Gardi <yga...@codeaurora.org>
---
drivers/scsi/ufs/ufshcd.c | 15
bro...@codeaurora.org>
Reviewed-by: Dolev Raviv <dra...@codeaurora.org>
Signed-off-by: Subhash Jadavani <subha...@codeaurora.org>
Signed-off-by: Maya Erez <me...@codeaurora.org>
Signed-off-by: Yaniv Gardi <yga...@codeaurora.org>
---
drivers/scsi/ufs/ufshcd.c | 17 +++
is done with tag which was set to -1
and so it is invalid.
Assert command tag passed from scsi layer is valid.
Reviewed-by: Subhash Jadavani <subha...@codeaurora.org>
Reviewed-by: Dolev Raviv <dra...@codeaurora.org>
Signed-off-by: Gilad Broner <gbro...@codeaurora.org>
Signed-off-by
of unnecessary EXPORT_SYMBOL,
types of parameters in routine definition,
build errors in case CONFIG_PM is not defined and some
other minor fixes.
Yaniv Gardi (8):
phy: qcom-ufs: fix build error when the component is built as a module
scsi: ufs-qcom: fix compilation warning if compiled as a module
scsi
Subhash Jadavani <subha...@codeaurora.org>
Reviewed-by: Gilad Broner <gbro...@codeaurora.org>
Signed-off-by: Yaniv Gardi <yga...@codeaurora.org>
---
drivers/scsi/ufs/ufs-qcom.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufs-qcom.c b
In order to simplify the code a set of wrapper functions is created
to test and call each of the variant operations.
Reviewed-by: Akinobu Mita <akinobu.m...@gmail.com>
Reviewed-by: Subhash Jadavani <subha...@codeaurora.org>
Reviewed-by: Gilad Broner <gbro...@codeaurora.org>
Si
-by: Subhash Jadavani <subha...@codeaurora.org>
Reviewed-by: Gilad Broner <gbro...@codeaurora.org>
Signed-off-by: Yaniv Gardi <yga...@codeaurora.org>
---
drivers/scsi/ufs/ufs-qcom.c | 640
drivers/scsi/ufs/ufs-qcom.h | 31 ++-
drivers
This change is required in order to be able to build the component
as a module.
Reviewed-by: Akinobu Mita <akinobu.m...@gmail.com>
Reviewed-by: Subhash Jadavani <subha...@codeaurora.org>
Reviewed-by: Gilad Broner <gbro...@codeaurora.org>
Signed-off-by: Yaniv Gardi <
This patch adds ufshcd_get_variant() and ufshcd_set_variant()
routines in order to get/set the variant specific data.
Reviewed-by: Akinobu Mita <akinobu.m...@gmail.com>
Reviewed-by: Subhash Jadavani <subha...@codeaurora.org>
Reviewed-by: Gilad Broner <gbro...@codeaurora.org>
Si
m.ko] undefined!
make[1]: *** [__modpost] Error 1
Reviewed-by: Akinobu Mita <akinobu.m...@gmail.com>
Reviewed-by: Subhash Jadavani <subha...@codeaurora.org>
Reviewed-by: Gilad Broner <gbro...@codeaurora.org>
Signed-off-by: Yaniv Gardi <yga...@codeaurora.org>
---
drivers/phy/p
lls to wmb() since they are redundant.
V2:
a few minor changes
V1:
This serie of 15 small patches should be pushed after the series of 8 patches
I have uploaded to the upstream a week ago:
"Fix error message and present UFS variant probe"
Yaniv Gardi (15):
scsi: ufs: clear UTRD, UPIU re
the
PRDT table length to zero which should take care of commands which doesn't
have any data associated with it. We are also clearing the unused fields in
request UPIU for NOP command.
Signed-off-by: Subhash Jadavani
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/ufshcd.c | 8
1 file
is done with tag which was set to -1
and so it is invalid.
Assert command tag passed from scsi layer is valid.
Signed-off-by: Gilad Broner
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/ufshcd.c | 24 ++--
1 file changed, 22 insertions(+), 2 deletions(-)
diff --git a/drivers
When sending a query to the device returns with a timeout error,
we clear the corresponding bit in the DOORBELL register but
we don't clear the outstanding_request field as we should.
This patch fixes this bug.
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/ufshcd.c | 22
have to retry fDeviceInit query requests multiple times and
each query request timeout prints one error message.
Signed-off-by: Subhash Jadavani
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/ufshcd.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi
According to UFS device specification REQUEST_SENSE command can
only report back up to 18 bytes of data.
Signed-off-by: Gilad Broner
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/ufshcd.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/ufs
from first 2 context listed above. This change fixes
the recovery by adding proper error handling mechanism.
Signed-off-by: Subhash Jadavani
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/ufshcd.c | 58 +++
1 file changed, 53 insertions(+), 5
UFS flag query requests may fail sometimes due to timeouts etc.
Add a wrapper function to retry up to 10 times in case of such
failure, similar to retries being made for attribute queries.
Signed-off-by: Gilad Broner
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/ufshcd.c | 63
of descriptors takes places before ringing the
doorbell, similarly to setting up a transfer request.
Signed-off-by: Gilad Broner
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/ufshcd.c | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/ufs
is recovered to active state, tries to put the UFS link in
hibern8 enter again until retry count expires.
Signed-off-by: Subhash Jadavani
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/ufshcd.c | 26 --
1 file changed, 24 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/ufshcd.c | 40 +---
1 file changed, 29 insertions(+), 11 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 8a04691..5005d12 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers
Sometimes queries from the device might return a failure so it is
recommended to retry sending the query, before giving up.
This change adds a wrapper to retry sending a query attribute,
in cases where we need to wait longer, before we continue,
or before reporting a failure.
Signed-off-by: Yaniv
while PM callbacks are running.
Signed-off-by: Subhash Jadavani
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/ufshcd.c | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 573a8cb..0e54183 100644
-by: Subhash Jadavani
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs/ufshcd.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index dfc4ac1..ec90504 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -1628,6 +1628,8
events which is not quite necessary and instead we can
just wait for the interrupt of 2nd completion, this should reduce
the number of interrupts and could reduce the unnecessary CPU wakeups
to handle extra interrupts.
Signed-off-by: Subhash Jadavani
Signed-off-by: Yaniv Gardi
---
drivers/scsi/ufs
201 - 300 of 822 matches
Mail list logo
