Re: [PATCH 4/4] dax: "Hotplug" persistent memory for use like normal RAM

2019-01-17 Thread Yanmin Zhang
On 2019/1/17 下午11:17, Dave Hansen wrote: On 1/17/19 12:19 AM, Yanmin Zhang wrote: I didn't try pmem and I am wondering it's slower than DRAM. Should a flag, such like _GFP_PMEM, be added to distinguish it from DRAM? Absolutely not. :) Agree. We already have performance-differentiated

Re: [PATCH 4/4] dax: "Hotplug" persistent memory for use like normal RAM

2019-01-17 Thread Yanmin Zhang
On 2019/1/17 上午2:19, Dave Hansen wrote: From: Dave Hansen Currently, a persistent memory region is "owned" by a device driver, either the "Direct DAX" or "Filesystem DAX" drivers. These drivers allow applications to explicitly use persistent memory, generally by being modified to use special,

Re: [PATCH] pnp: Bypass the calling to pnp_stop_dev at suspend when there is a protocol suspend

2014-01-05 Thread Yanmin Zhang
On 二, 2013-12-24 at 09:35 +0800, shuox@intel.com wrote: > From: Zhang Yanmin > > pnp pnp_bus_suspend/_resume have an issue. > pnp_bus_suspend calls pnp_stop_dev to disable the device. With ACPI, > pnp_stop_dev turns off the dev usually. Then, > pnp_bus_suspend=>pnp_dev->protocol->suspend

Re: [PATCH] pnp: Bypass the calling to pnp_stop_dev at suspend when there is a protocol suspend

2014-01-05 Thread Yanmin Zhang
On 二, 2013-12-24 at 09:35 +0800, shuox@intel.com wrote: From: Zhang Yanmin yanmin.zh...@intel.com pnp pnp_bus_suspend/_resume have an issue. pnp_bus_suspend calls pnp_stop_dev to disable the device. With ACPI, pnp_stop_dev turns off the dev usually. Then,

Re: [PATCH] PM: avoid 'autosleep' in shutdown progress

2013-07-14 Thread Yanmin Zhang
On Sat, 2013-07-13 at 13:56 +0200, Pavel Machek wrote: > On Fri 2013-07-12 10:37:33, Alan Stern wrote: > > On Fri, 12 Jul 2013, Yanmin Zhang wrote: > > > > > On Thu, 2013-07-11 at 16:03 +0800, shuox@intel.com wrote: > > > > From: Liu ShuoX > >

Re: [PATCH] PM: avoid 'autosleep' in shutdown progress

2013-07-14 Thread Yanmin Zhang
On Sat, 2013-07-13 at 13:56 +0200, Pavel Machek wrote: On Fri 2013-07-12 10:37:33, Alan Stern wrote: On Fri, 12 Jul 2013, Yanmin Zhang wrote: On Thu, 2013-07-11 at 16:03 +0800, shuox@intel.com wrote: From: Liu ShuoX shuox@intel.com In shutdown progress, system

Re: [PATCH] PM: avoid 'autosleep' in shutdown progress

2013-07-12 Thread Yanmin Zhang
On Thu, 2013-07-11 at 16:03 +0800, shuox@intel.com wrote: > From: Liu ShuoX > > In shutdown progress, system is possible to do power transition > (such as suspend-to-ram) in parallel. It is unreasonable. So, > fixes it by adding a system_state checking and queue try_to_suspend > again when

Re: [PATCH] PM: avoid 'autosleep' in shutdown progress

2013-07-12 Thread Yanmin Zhang
On Thu, 2013-07-11 at 16:03 +0800, shuox@intel.com wrote: From: Liu ShuoX shuox@intel.com In shutdown progress, system is possible to do power transition (such as suspend-to-ram) in parallel. It is unreasonable. So, fixes it by adding a system_state checking and queue try_to_suspend

Re: [PATCH 0/2] Run callback of device_prepare/complete consistently

2013-06-07 Thread Yanmin Zhang
On Sat, 2013-06-08 at 03:52 +0200, Rafael J. Wysocki wrote: > On Saturday, June 08, 2013 09:36:03 AM Yanmin Zhang wrote: > > On Sat, 2013-06-08 at 03:30 +0200, Rafael J. Wysocki wrote: > > > On Friday, June 07, 2013 06:16:25 PM Greg KH wrote: > > > > On Sat, Ju

Re: [PATCH] irq: add a new function irq_in_progress to check pending IRQ handlers

2013-06-07 Thread Yanmin Zhang
On Fri, 2013-06-07 at 08:08 -0700, Greg KH wrote: > On Fri, Jun 07, 2013 at 12:54:55PM +0800, Yanmin Zhang wrote: > > On Thu, 2013-06-06 at 21:19 -0700, Greg KH wrote: > > > On Fri, Jun 07, 2013 at 11:18:06AM +0800, Yanmin Zhang wrote: > > > > On Thu, 2013-06-06

Re: [PATCH 0/2] Run callback of device_prepare/complete consistently

2013-06-07 Thread Yanmin Zhang
On Sat, 2013-06-08 at 03:30 +0200, Rafael J. Wysocki wrote: > On Friday, June 07, 2013 06:16:25 PM Greg KH wrote: > > On Sat, Jun 08, 2013 at 08:42:12AM +0800, Yanmin Zhang wrote: > > > On Fri, 2013-06-07 at 12:36 +0200, Rafael J. Wysocki wrote: > > > > On Friday, J

Re: [PATCH 0/2] Run callback of device_prepare/complete consistently

2013-06-07 Thread Yanmin Zhang
On Fri, 2013-06-07 at 18:16 -0700, Greg KH wrote: > On Sat, Jun 08, 2013 at 08:42:12AM +0800, Yanmin Zhang wrote: > > On Fri, 2013-06-07 at 12:36 +0200, Rafael J. Wysocki wrote: > > > On Friday, June 07, 2013 04:20:30 PM shuox@intel.com wrote: > > > > dpm_run_ca

Re: [PATCH 1/2] PM: use dpm_run_callback in device_prepare

2013-06-07 Thread Yanmin Zhang
On Fri, 2013-06-07 at 18:15 -0700, Greg KH wrote: > On Sat, Jun 08, 2013 at 08:43:55AM +0800, Yanmin Zhang wrote: > > On Fri, 2013-06-07 at 10:37 -0700, Greg KH wrote: > > > On Fri, Jun 07, 2013 at 04:20:31PM +0800, shuox@intel.com wrote: >

Re: [PATCH 0/2] Run callback of device_prepare/complete consistently

2013-06-07 Thread Yanmin Zhang
On Sat, 2013-06-08 at 02:54 +0200, Rafael J. Wysocki wrote: > On Saturday, June 08, 2013 08:42:12 AM Yanmin Zhang wrote: > > On Fri, 2013-06-07 at 12:36 +0200, Rafael J. Wysocki wrote: > > > On Friday, June 07, 2013 04:20:30 PM shuox@intel.com wrote: > > > > dpm

Re: [PATCH 1/2] PM: use dpm_run_callback in device_prepare

2013-06-07 Thread Yanmin Zhang
On Fri, 2013-06-07 at 10:37 -0700, Greg KH wrote: > On Fri, Jun 07, 2013 at 04:20:31PM +0800, shuox@intel.com wrote: > > From: ShuoX Liu > > > > dpm_run_callback could show more debug info around prepare stage. > > Why? Who needs this? What problem does it solve? > > Without answers to

Re: [PATCH 0/2] Run callback of device_prepare/complete consistently

2013-06-07 Thread Yanmin Zhang
On Fri, 2013-06-07 at 12:36 +0200, Rafael J. Wysocki wrote: > On Friday, June 07, 2013 04:20:30 PM shuox@intel.com wrote: > > dpm_run_callback is used in other stages of power states changing. > > It provides debug info message and time measurement when call these > > callback. We also want to

Re: [PATCH 0/2] Run callback of device_prepare/complete consistently

2013-06-07 Thread Yanmin Zhang
On Fri, 2013-06-07 at 12:36 +0200, Rafael J. Wysocki wrote: On Friday, June 07, 2013 04:20:30 PM shuox@intel.com wrote: dpm_run_callback is used in other stages of power states changing. It provides debug info message and time measurement when call these callback. We also want to

Re: [PATCH 1/2] PM: use dpm_run_callback in device_prepare

2013-06-07 Thread Yanmin Zhang
On Fri, 2013-06-07 at 10:37 -0700, Greg KH wrote: On Fri, Jun 07, 2013 at 04:20:31PM +0800, shuox@intel.com wrote: From: ShuoX Liu shuox@intel.com dpm_run_callback could show more debug info around prepare stage. Why? Who needs this? What problem does it solve? Without

Re: [PATCH 0/2] Run callback of device_prepare/complete consistently

2013-06-07 Thread Yanmin Zhang
On Sat, 2013-06-08 at 02:54 +0200, Rafael J. Wysocki wrote: On Saturday, June 08, 2013 08:42:12 AM Yanmin Zhang wrote: On Fri, 2013-06-07 at 12:36 +0200, Rafael J. Wysocki wrote: On Friday, June 07, 2013 04:20:30 PM shuox@intel.com wrote: dpm_run_callback is used in other stages

Re: [PATCH 1/2] PM: use dpm_run_callback in device_prepare

2013-06-07 Thread Yanmin Zhang
On Fri, 2013-06-07 at 18:15 -0700, Greg KH wrote: On Sat, Jun 08, 2013 at 08:43:55AM +0800, Yanmin Zhang wrote: On Fri, 2013-06-07 at 10:37 -0700, Greg KH wrote: On Fri, Jun 07, 2013 at 04:20:31PM +0800, shuox@intel.com wrote: From: ShuoX Liu shuox@intel.com

Re: [PATCH 0/2] Run callback of device_prepare/complete consistently

2013-06-07 Thread Yanmin Zhang
On Fri, 2013-06-07 at 18:16 -0700, Greg KH wrote: On Sat, Jun 08, 2013 at 08:42:12AM +0800, Yanmin Zhang wrote: On Fri, 2013-06-07 at 12:36 +0200, Rafael J. Wysocki wrote: On Friday, June 07, 2013 04:20:30 PM shuox@intel.com wrote: dpm_run_callback is used in other stages of power

Re: [PATCH 0/2] Run callback of device_prepare/complete consistently

2013-06-07 Thread Yanmin Zhang
On Sat, 2013-06-08 at 03:30 +0200, Rafael J. Wysocki wrote: On Friday, June 07, 2013 06:16:25 PM Greg KH wrote: On Sat, Jun 08, 2013 at 08:42:12AM +0800, Yanmin Zhang wrote: On Fri, 2013-06-07 at 12:36 +0200, Rafael J. Wysocki wrote: On Friday, June 07, 2013 04:20:30 PM shuox

Re: [PATCH] irq: add a new function irq_in_progress to check pending IRQ handlers

2013-06-07 Thread Yanmin Zhang
On Fri, 2013-06-07 at 08:08 -0700, Greg KH wrote: On Fri, Jun 07, 2013 at 12:54:55PM +0800, Yanmin Zhang wrote: On Thu, 2013-06-06 at 21:19 -0700, Greg KH wrote: On Fri, Jun 07, 2013 at 11:18:06AM +0800, Yanmin Zhang wrote: On Thu, 2013-06-06 at 20:08 -0700, Greg KH wrote: On Fri

Re: [PATCH 0/2] Run callback of device_prepare/complete consistently

2013-06-07 Thread Yanmin Zhang
On Sat, 2013-06-08 at 03:52 +0200, Rafael J. Wysocki wrote: On Saturday, June 08, 2013 09:36:03 AM Yanmin Zhang wrote: On Sat, 2013-06-08 at 03:30 +0200, Rafael J. Wysocki wrote: On Friday, June 07, 2013 06:16:25 PM Greg KH wrote: On Sat, Jun 08, 2013 at 08:42:12AM +0800, Yanmin Zhang

Re: [PATCH] irq: add a new function irq_in_progress to check pending IRQ handlers

2013-06-06 Thread Yanmin Zhang
On Thu, 2013-06-06 at 21:19 -0700, Greg KH wrote: > On Fri, Jun 07, 2013 at 11:18:06AM +0800, Yanmin Zhang wrote: > > On Thu, 2013-06-06 at 20:08 -0700, Greg KH wrote: > > > On Fri, Jun 07, 2013 at 10:37:52AM +0800, Yanmin Zhang wrote: > > > > On Thu, 2013-06-06

Re: [PATCH] irq: add a new function irq_in_progress to check pending IRQ handlers

2013-06-06 Thread Yanmin Zhang
On Thu, 2013-06-06 at 20:08 -0700, Greg KH wrote: > On Fri, Jun 07, 2013 at 10:37:52AM +0800, Yanmin Zhang wrote: > > On Thu, 2013-06-06 at 18:02 -0700, Greg KH wrote: > > > On Fri, Jun 07, 2013 at 08:53:29AM +0800, Yanmin Zhang wrote: > > > > On Thu, 2013-06-06 a

Re: [PATCH] irq: add a new function irq_in_progress to check pending IRQ handlers

2013-06-06 Thread Yanmin Zhang
On Thu, 2013-06-06 at 18:02 -0700, Greg KH wrote: > On Fri, Jun 07, 2013 at 08:53:29AM +0800, Yanmin Zhang wrote: > > On Thu, 2013-06-06 at 15:18 +0200, Thomas Gleixner wrote: > > > On Thu, 6 Jun 2013, shuox@intel.com wrote: > > > > From: Zhang Yanmin > >

Re: [PATCH] irq: add a new function irq_in_progress to check pending IRQ handlers

2013-06-06 Thread Yanmin Zhang
On Thu, 2013-06-06 at 15:18 +0200, Thomas Gleixner wrote: > On Thu, 6 Jun 2013, shuox@intel.com wrote: > > From: Zhang Yanmin > > > > synchronize_irq waits pending IRQ handlers to be finished. If using this > > function while holding a resource, the IRQ handler may cause deadlock. > > > >

Re: Subject : [ PATCH ] pci-reset-error_state-to-pci_channel_io_normal-at-report_slot_reset

2013-06-06 Thread Yanmin Zhang
On Wed, 2013-06-05 at 07:30 -0600, Bjorn Helgaas wrote: > On Tue, Jun 4, 2013 at 6:38 PM, Yanmin Zhang > wrote: > > On Tue, 2013-06-04 at 12:04 -0600, Bjorn Helgaas wrote: > >> I'm not sure where we are with this patch. I think Joseph initially > >> reported a prob

Re: Subject : [ PATCH ] pci-reset-error_state-to-pci_channel_io_normal-at-report_slot_reset

2013-06-06 Thread Yanmin Zhang
On Wed, 2013-06-05 at 07:30 -0600, Bjorn Helgaas wrote: On Tue, Jun 4, 2013 at 6:38 PM, Yanmin Zhang yanmin_zh...@linux.intel.com wrote: On Tue, 2013-06-04 at 12:04 -0600, Bjorn Helgaas wrote: I'm not sure where we are with this patch. I think Joseph initially reported a problem (though I

Re: [PATCH] irq: add a new function irq_in_progress to check pending IRQ handlers

2013-06-06 Thread Yanmin Zhang
On Thu, 2013-06-06 at 15:18 +0200, Thomas Gleixner wrote: On Thu, 6 Jun 2013, shuox@intel.com wrote: From: Zhang Yanmin yanmin.zh...@intel.com synchronize_irq waits pending IRQ handlers to be finished. If using this function while holding a resource, the IRQ handler may cause

Re: [PATCH] irq: add a new function irq_in_progress to check pending IRQ handlers

2013-06-06 Thread Yanmin Zhang
On Thu, 2013-06-06 at 18:02 -0700, Greg KH wrote: On Fri, Jun 07, 2013 at 08:53:29AM +0800, Yanmin Zhang wrote: On Thu, 2013-06-06 at 15:18 +0200, Thomas Gleixner wrote: On Thu, 6 Jun 2013, shuox@intel.com wrote: From: Zhang Yanmin yanmin.zh...@intel.com synchronize_irq

Re: [PATCH] irq: add a new function irq_in_progress to check pending IRQ handlers

2013-06-06 Thread Yanmin Zhang
On Thu, 2013-06-06 at 20:08 -0700, Greg KH wrote: On Fri, Jun 07, 2013 at 10:37:52AM +0800, Yanmin Zhang wrote: On Thu, 2013-06-06 at 18:02 -0700, Greg KH wrote: On Fri, Jun 07, 2013 at 08:53:29AM +0800, Yanmin Zhang wrote: On Thu, 2013-06-06 at 15:18 +0200, Thomas Gleixner wrote

Re: [PATCH] irq: add a new function irq_in_progress to check pending IRQ handlers

2013-06-06 Thread Yanmin Zhang
On Thu, 2013-06-06 at 21:19 -0700, Greg KH wrote: On Fri, Jun 07, 2013 at 11:18:06AM +0800, Yanmin Zhang wrote: On Thu, 2013-06-06 at 20:08 -0700, Greg KH wrote: On Fri, Jun 07, 2013 at 10:37:52AM +0800, Yanmin Zhang wrote: On Thu, 2013-06-06 at 18:02 -0700, Greg KH wrote: On Fri

Re: Subject : [ PATCH ] pci-reset-error_state-to-pci_channel_io_normal-at-report_slot_reset

2013-06-04 Thread Yanmin Zhang
On Tue, 2013-06-04 at 12:04 -0600, Bjorn Helgaas wrote: > I'm not sure where we are with this patch. I think Joseph initially > reported a problem (though I haven't actually seen that), and this > patch fixed it, so it seems like there's something we want to do here. Yes, indeed. We checked

Re: Subject : [ PATCH ] pci-reset-error_state-to-pci_channel_io_normal-at-report_slot_reset

2013-06-04 Thread Yanmin Zhang
On Tue, 2013-06-04 at 12:04 -0600, Bjorn Helgaas wrote: I'm not sure where we are with this patch. I think Joseph initially reported a problem (though I haven't actually seen that), and this patch fixed it, so it seems like there's something we want to do here. Yes, indeed. We checked Powerpc

Re: Subject : [ PATCH ] pci-reset-error_state-to-pci_channel_io_normal-at-report_slot_reset

2013-05-21 Thread Yanmin Zhang
On Mon, 2013-05-20 at 10:37 -0500, Linas Vepstas wrote: > I think Joe Liu has it right. I'm going to top-post because things > are a bit tangled below. I urge a review of > /Documentation/PCI/pci-error-recovery.txt, as that gives the details. > > The intended sequence is that, after an error,

Re: Subject : [ PATCH ] pci-reset-error_state-to-pci_channel_io_normal-at-report_slot_reset

2013-05-21 Thread Yanmin Zhang
On Mon, 2013-05-20 at 16:48 -0600, Bjorn Helgaas wrote: > On Fri, Apr 26, 2013 at 06:28:59AM +, Zhang, LongX wrote: > > From: Zhang Long > > > > Specific pci device drivers might have many functions to call > > pci_channel_offline to check device states. When slot_reset happens, > > drivers'

Re: Subject : [ PATCH ] pci-reset-error_state-to-pci_channel_io_normal-at-report_slot_reset

2013-05-21 Thread Yanmin Zhang
On Mon, 2013-05-20 at 16:48 -0600, Bjorn Helgaas wrote: On Fri, Apr 26, 2013 at 06:28:59AM +, Zhang, LongX wrote: From: Zhang Long longx.zh...@intel.com Specific pci device drivers might have many functions to call pci_channel_offline to check device states. When slot_reset happens,

Re: Subject : [ PATCH ] pci-reset-error_state-to-pci_channel_io_normal-at-report_slot_reset

2013-05-21 Thread Yanmin Zhang
On Mon, 2013-05-20 at 10:37 -0500, Linas Vepstas wrote: I think Joe Liu has it right. I'm going to top-post because things are a bit tangled below. I urge a review of /Documentation/PCI/pci-error-recovery.txt, as that gives the details. The intended sequence is that, after an error, the

Re: Subject : [ PATCH ] pci-reset-error_state-to-pci_channel_io_normal-at-report_slot_reset

2013-05-06 Thread Yanmin Zhang
nas > > p.s. you didn't see my earlier reply because I forgot to hit 'plain text > reply' > > > On 2 May 2013 22:13, Yanmin Zhang wrote: > > > > On Thu, 2013-05-02 at 19:00 -0700, Greg Kroah-Hartman wrote: > > > On Fri, May 03, 2013 at 08:33:00AM +0800, Ya

Re: Subject : [ PATCH ] pci-reset-error_state-to-pci_channel_io_normal-at-report_slot_reset

2013-05-06 Thread Yanmin Zhang
'plain text reply' On 2 May 2013 22:13, Yanmin Zhang yanmin_zh...@linux.intel.com wrote: On Thu, 2013-05-02 at 19:00 -0700, Greg Kroah-Hartman wrote: On Fri, May 03, 2013 at 08:33:00AM +0800, Yanmin Zhang wrote: On Wed, 2013-05-01 at 20:20 -0500, Linas Vepstas wrote: Hi

Re: Subject : [ PATCH ] pci-reset-error_state-to-pci_channel_io_normal-at-report_slot_reset

2013-05-02 Thread Yanmin Zhang
On Thu, 2013-05-02 at 19:00 -0700, Greg Kroah-Hartman wrote: > On Fri, May 03, 2013 at 08:33:00AM +0800, Yanmin Zhang wrote: > > On Wed, 2013-05-01 at 20:20 -0500, Linas Vepstas wrote: > > > Hi, > > > > > > On 1 May 2013 19:30, Yanmin Zhang > > > wro

Re: Subject : [ PATCH ] pci-reset-error_state-to-pci_channel_io_normal-at-report_slot_reset

2013-05-02 Thread Yanmin Zhang
On Wed, 2013-05-01 at 20:20 -0500, Linas Vepstas wrote: > Hi, > > On 1 May 2013 19:30, Yanmin Zhang > wrote: > On Fri, 2013-04-26 at 06:28 +, Zhang, LongX wrote: > > From: Zhang Long > > > > Specific pci device

Re: Subject : [ PATCH ] pci-reset-error_state-to-pci_channel_io_normal-at-report_slot_reset

2013-05-02 Thread Yanmin Zhang
On Wed, 2013-05-01 at 20:20 -0500, Linas Vepstas wrote: Hi, On 1 May 2013 19:30, Yanmin Zhang yanmin_zh...@linux.intel.com wrote: On Fri, 2013-04-26 at 06:28 +, Zhang, LongX wrote: From: Zhang Long longx.zh...@intel.com Specific pci device drivers

Re: Subject : [ PATCH ] pci-reset-error_state-to-pci_channel_io_normal-at-report_slot_reset

2013-05-02 Thread Yanmin Zhang
On Thu, 2013-05-02 at 19:00 -0700, Greg Kroah-Hartman wrote: On Fri, May 03, 2013 at 08:33:00AM +0800, Yanmin Zhang wrote: On Wed, 2013-05-01 at 20:20 -0500, Linas Vepstas wrote: Hi, On 1 May 2013 19:30, Yanmin Zhang yanmin_zh...@linux.intel.com wrote: On Fri, 2013-04-26

Re: Subject : [ PATCH ] pci-reset-error_state-to-pci_channel_io_normal-at-report_slot_reset

2013-05-01 Thread Yanmin Zhang
On Fri, 2013-04-26 at 06:28 +, Zhang, LongX wrote: > From: Zhang Long > > Specific pci device drivers might have many functions to call > pci_channel_offline to check device states. When slot_reset happens, > drivers' slot_reset callback might call such functions and eventually > abort the

Re: Subject : [ PATCH ] pci-reset-error_state-to-pci_channel_io_normal-at-report_slot_reset

2013-05-01 Thread Yanmin Zhang
On Fri, 2013-04-26 at 06:28 +, Zhang, LongX wrote: From: Zhang Long longx.zh...@intel.com Specific pci device drivers might have many functions to call pci_channel_offline to check device states. When slot_reset happens, drivers' slot_reset callback might call such functions and

Re: [PATCH V2] output the cpu number when printking.

2012-12-24 Thread Yanmin Zhang
On Mon, 2012-12-24 at 09:55 -0800, Greg KH wrote: > On Mon, Dec 24, 2012 at 01:01:55PM +0800, he, bo wrote: > > From: "he, bo" > > > > We often hit kernel panic issues on SMP machines because processes race > > on multiple cpu. By adding a new parameter printk.cpu, kernel prints > > cpu number

Re: [PATCH V2] output the cpu number when printking.

2012-12-24 Thread Yanmin Zhang
On Mon, 2012-12-24 at 09:55 -0800, Greg KH wrote: On Mon, Dec 24, 2012 at 01:01:55PM +0800, he, bo wrote: From: he, bo bo...@intel.com We often hit kernel panic issues on SMP machines because processes race on multiple cpu. By adding a new parameter printk.cpu, kernel prints cpu number

Re: [PATCH V2] hrtimer: Printing timer info when hitting BUG_ON()

2012-11-05 Thread Yanmin Zhang
On Tue, 2012-10-30 at 18:27 +0800, Chuansheng Liu wrote: > We encounted one BUG_ON() issue at function __run_hrtimer(), > but the panic info is not enough to find out which hrtimer > users use the hrtimer wrongly. > (in this BUG_ON case, it is callback running at the same time > hrtimer_start() is

Re: [PATCH V2] hrtimer: Printing timer info when hitting BUG_ON()

2012-11-05 Thread Yanmin Zhang
On Tue, 2012-10-30 at 18:27 +0800, Chuansheng Liu wrote: We encounted one BUG_ON() issue at function __run_hrtimer(), but the panic info is not enough to find out which hrtimer users use the hrtimer wrongly. (in this BUG_ON case, it is callback running at the same time hrtimer_start() is

RE: [PATCH] hrtimer:__run_hrtimer races with enqueue_hrtimer

2012-10-29 Thread Yanmin Zhang
On Fri, 2012-10-26 at 14:09 +0200, Thomas Gleixner wrote: > On Fri, 26 Oct 2012, Zhang, Yanmin wrote: > > >From: Thomas Gleixner [mailto:t...@linutronix.de] > > >Your code is returning HRTIMER_RESTART from the timer callback and at > > >the same time it starts the timer from some other context.

RE: [PATCH] hrtimer:__run_hrtimer races with enqueue_hrtimer

2012-10-29 Thread Yanmin Zhang
On Fri, 2012-10-26 at 14:09 +0200, Thomas Gleixner wrote: On Fri, 26 Oct 2012, Zhang, Yanmin wrote: From: Thomas Gleixner [mailto:t...@linutronix.de] Your code is returning HRTIMER_RESTART from the timer callback and at the same time it starts the timer from some other context. That's what

[PATCH V2] hrtimer:__run_hrtimer races with enqueue_hrtimer

2012-10-26 Thread Yanmin Zhang
RTIMER_STATE_ENQUEUED, which causes the BUG_ON(timer->state != HRTIMER_STATE_CALLBACK) checking fails. The patch fixes it by checking only bit HRTIMER_STATE_CALLBACK and also bypass enqueue_hrtimer when the timer is queued. Signed-off-by: Yanmin Zhang Signed-off-by: He Bo --- kernel/hrtimer.c |

Re: [PATCH] hrtimer:__run_hrtimer races with enqueue_hrtimer

2012-10-26 Thread Yanmin Zhang
On Fri, 2012-10-26 at 10:51 +0800, he, bo wrote: > From: Yanmin Zhang > > We hit a kernel panic at __run_hrtimer=>BUG_ON(timer->state != > HRTIMER_STATE_CALLBACK). > <2>[ 10.226053, 3] kernel BUG at > /home/android/xiaobing/ymz/r4/hardware/intel/linux-2

Re: [PATCH] hrtimer:__run_hrtimer races with enqueue_hrtimer

2012-10-26 Thread Yanmin Zhang
On Fri, 2012-10-26 at 10:51 +0800, he, bo wrote: From: Yanmin Zhang yanmin.zh...@intel.com We hit a kernel panic at __run_hrtimer=BUG_ON(timer-state != HRTIMER_STATE_CALLBACK). 2[ 10.226053, 3] kernel BUG at /home/android/xiaobing/ymz/r4/hardware/intel/linux-2.6/kernel/hrtimer.c:1228

[PATCH V2] hrtimer:__run_hrtimer races with enqueue_hrtimer

2012-10-26 Thread Yanmin Zhang
HRTIMER_STATE_CALLBACK and also bypass enqueue_hrtimer when the timer is queued. Signed-off-by: Yanmin Zhang yanmin_zh...@linux.intel.com Signed-off-by: He Bo bo...@intel.com --- kernel/hrtimer.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/kernel/hrtimer.c b/kernel

Re: [PATCH v2] drivers-core: move the calling to device_pm_remove behind the calling to bus_remove_device

2012-10-24 Thread Yanmin Zhang
On Thu, 2012-10-25 at 00:33 +0200, Rafael J. Wysocki wrote: > On Wednesday 24 of October 2012 15:13:27 Greg Kroah-Hartman wrote: > > On Wed, Oct 24, 2012 at 09:46:19PM +0200, Rafael J. Wysocki wrote: > > > On Tuesday 16 of October 2012 23:28:08 zhanglong wrote: > > > > We hit an hang issue when

Re: [PATCH v2] drivers-core: move the calling to device_pm_remove behind the calling to bus_remove_device

2012-10-24 Thread Yanmin Zhang
On Thu, 2012-10-25 at 00:33 +0200, Rafael J. Wysocki wrote: On Wednesday 24 of October 2012 15:13:27 Greg Kroah-Hartman wrote: On Wed, Oct 24, 2012 at 09:46:19PM +0200, Rafael J. Wysocki wrote: On Tuesday 16 of October 2012 23:28:08 zhanglong wrote: We hit an hang issue when removing a

Re: [PATCH v2] drivers-core: move the calling to device_pm_remove behind the calling to bus_remove_device

2012-10-21 Thread Yanmin Zhang
On Tue, 2012-10-16 at 23:28 +0800, zhanglong wrote: > We hit an hang issue when removing a mmc device on Medfield Android phone by > sysfs interface. > > device_pm_remove will call pm_runtime_remove which would disable > runtime PM of the device. After that pm_runtime_get* or > pm_runtime_put*

Re: [PATCH v2] drivers-core: move the calling to device_pm_remove behind the calling to bus_remove_device

2012-10-21 Thread Yanmin Zhang
On Tue, 2012-10-16 at 23:28 +0800, zhanglong wrote: We hit an hang issue when removing a mmc device on Medfield Android phone by sysfs interface. device_pm_remove will call pm_runtime_remove which would disable runtime PM of the device. After that pm_runtime_get* or pm_runtime_put* will be

Re: Subject: [PATCH] drivers-core: move device_pm_remove behind bus_remove_device

2012-10-17 Thread Yanmin Zhang
On Mon, 2012-10-15 at 22:59 +0200, Rafael J. Wysocki wrote: > On Monday 15 of October 2012 15:39:49 Yanmin Zhang wrote: > > On Fri, 2012-09-21 at 01:58 +, Zhang, LongX wrote: > > > From: LongX Zhang > > > > > > device_pm_remove will call pm_runtime_remove

Re: Subject: [PATCH] drivers-core: move device_pm_remove behind bus_remove_device

2012-10-17 Thread Yanmin Zhang
On Mon, 2012-10-15 at 22:59 +0200, Rafael J. Wysocki wrote: On Monday 15 of October 2012 15:39:49 Yanmin Zhang wrote: On Fri, 2012-09-21 at 01:58 +, Zhang, LongX wrote: From: LongX Zhang longx.zh...@intel.com device_pm_remove will call pm_runtime_remove which would disable

Re: Subject: [PATCH] drivers-core: move device_pm_remove behind bus_remove_device

2012-10-15 Thread Yanmin Zhang
On Fri, 2012-09-21 at 01:58 +, Zhang, LongX wrote: > From: LongX Zhang > > device_pm_remove will call pm_runtime_remove which would disable > runtime PM of the device. After that pm_runtime_get* or > pm_runtime_put* will be ingored. So if we disable the runtime PM > before device really be

Re: Subject: [PATCH] drivers-core: move device_pm_remove behind bus_remove_device

2012-10-15 Thread Yanmin Zhang
On Fri, 2012-09-21 at 01:58 +, Zhang, LongX wrote: From: LongX Zhang longx.zh...@intel.com device_pm_remove will call pm_runtime_remove which would disable runtime PM of the device. After that pm_runtime_get* or pm_runtime_put* will be ingored. So if we disable the runtime PM before

Re: [PATCH] x86/fixup_irq: using the cpu_online_mask instead of cpu_all_mask

2012-08-19 Thread Yanmin Zhang
On Tue, 2012-08-14 at 06:55 +, Liu, Chuansheng wrote: > From: liu chuansheng > Subject: [PATCH] x86/fixup_irq: using the cpu_online_mask instead of > cpu_all_mask > > When one CPU is going down, and this CPU is the last one in irq affinity, > current code is setting cpu_all_mask as the new

Re: [PATCH] x86/fixup_irq: using the cpu_online_mask instead of cpu_all_mask

2012-08-19 Thread Yanmin Zhang
On Tue, 2012-08-14 at 06:55 +, Liu, Chuansheng wrote: From: liu chuansheng chuansheng@intel.com Subject: [PATCH] x86/fixup_irq: using the cpu_online_mask instead of cpu_all_mask When one CPU is going down, and this CPU is the last one in irq affinity, current code is setting

[Fwd: [PATCH] x86/smp: Fix cpuN startup panic]

2012-08-09 Thread Yanmin Zhang
; AP busy wait for it. At present, AP will wait for 2 seconds then panic. > > This patch let AP waits until BSP finish the startup sequence and gives > WARNING when BSP is preempted more than 2 seconds. > > Signed-off-by: Yanmin Zhang > Signed-off-by: Lin Chen > --- >

[Fwd: [PATCH] x86/smp: Fix cpuN startup panic]

2012-08-09 Thread Yanmin Zhang
. This patch let AP waits until BSP finish the startup sequence and gives WARNING when BSP is preempted more than 2 seconds. Signed-off-by: Yanmin Zhang yanmin_zh...@linux.intel.com Signed-off-by: Lin Chen linx.z.c...@intel.com --- arch/x86/kernel/smpboot.c | 11 ++- 1 files

Re: [PATCH] x86/smp: Fix cpuN startup panic

2012-08-07 Thread Yanmin Zhang
seconds then panic. > > > > This patch let AP waits until BSP finish the startup sequence and gives > > WARNING when BSP is preempted more than 2 seconds. > > > > Signed-off-by: Yanmin Zhang > > Signed-off-by: Lin Chen > > --- > > arch/x86/

Re: [PATCH] x86/smp: Fix cpuN startup panic

2012-08-07 Thread Yanmin Zhang
than 2 seconds. Signed-off-by: Yanmin Zhang yanmin_zh...@linux.intel.com Signed-off-by: Lin Chen linx.z.c...@intel.com --- arch/x86/kernel/smpboot.c | 11 ++- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel