Re: [PATCH 6/8] kconfig: fix randomising choice entries in presence of KCONFIG_ALLCONFIG

2013-04-27 Thread Yann E. MORIN
Arnd, All, On Sat, Apr 27, 2013 at 11:01:00PM +0200, Arnd Bergmann wrote: > On Saturday 27 April 2013, Yann E. MORIN wrote: > > > > On Fri, Apr 26, 2013 at 02:05:37PM +0200, Arnd Bergmann wrote: > > > On Thursday 25 April 2013 00:29:53 Yann E. MORIN wrote: >

Re: linux-next: Tree for Apr 26

2013-04-27 Thread Yann E. MORIN
repo :-). > Anyway, thanks for taking care and solving fast to all involved folks! Yep, that kind of command was what I was missing to check for regression on this patch. Now, I have someting to test. Thanks. Regards, Yann E. MORIN. -- .-.----.--.--

Re: linux-next: Tree for Apr 26

2013-04-27 Thread Yann E. MORIN
ions. I.e. > > $ yes "" | make oldconfig; make silentoldconfig > should always pass. Ah, OK, now I got it. Thank you for the explanations. Regards, Yann E. MORIN. -- .-..--.--------. | Yann E. MORIN | Real-Time Embedde

Re: linux-next: Tree for Apr 26

2013-04-27 Thread Yann E. MORIN
| make oldconfig; make silentoldconfig /dev/null should always pass. Ah, OK, now I got it. Thank you for the explanations. Regards, Yann E. MORIN. -- .-..--.. | Yann E. MORIN | Real-Time Embedded | /\ ASCII RIBBON | Erics

Re: linux-next: Tree for Apr 26

2013-04-27 Thread Yann E. MORIN
involved folks! Yep, that kind of command was what I was missing to check for regression on this patch. Now, I have someting to test. Thanks. Regards, Yann E. MORIN. -- .-..--.. | Yann E. MORIN | Real-Time Embedded | /\ ASCII

Re: [PATCH 6/8] kconfig: fix randomising choice entries in presence of KCONFIG_ALLCONFIG

2013-04-27 Thread Yann E. MORIN
Arnd, All, On Sat, Apr 27, 2013 at 11:01:00PM +0200, Arnd Bergmann wrote: On Saturday 27 April 2013, Yann E. MORIN wrote: On Fri, Apr 26, 2013 at 02:05:37PM +0200, Arnd Bergmann wrote: On Thursday 25 April 2013 00:29:53 Yann E. MORIN wrote: From: Yann E. MORIN yann.morin.1...@free.fr

[PATCH 1/1] Revert "kconfig: fix randomising choice entries in presence of KCONFIG_ALLCONFIG"

2013-04-26 Thread Yann E. MORIN
From: "Yann E. MORIN" This reverts commit 422c809f03f043d0950d8362214818e956a9daee. It causes more harm than it solves issues. Reported-by: Sedat Dilek Reported-by: Arnd Bergmann Signed-off-by: "Yann E. MORIN" Tested-by: Sedat Dilek Cc: Sedat Dilek Cc: Arnd Bergmann

[pull request] Pull request for branch yem-kconfig-for-next

2013-04-26 Thread Yann E. MORIN
From: "Yann E. MORIN" Michal, Please pull this to revert: 422c809: fix randomising choice entries in presence of KCONFIG_ALLCONFIG It causes more harm that it fixes issues, and I couldn't find a proper fix for now. To avoid breakage so close to the opening of the merge window

Re: [PATCH 6/8] kconfig: fix randomising choice entries in presence of KCONFIG_ALLCONFIG

2013-04-26 Thread Yann E. MORIN
On Fri, Apr 26, 2013 at 02:05:37PM +0200, Arnd Bergmann wrote: > On Thursday 25 April 2013 00:29:53 Yann E. MORIN wrote: > > From: "Yann E. MORIN" > > > > Currently, randconfig does randomise choice entries, unless > > KCONFIG_ALLCONFIG > > is speci

Re: linux-next: Tree for Apr 26

2013-04-26 Thread Yann E. MORIN
gt; #!/bin/sh > > > > cp config-bad .config > > make silentoldconfig > > > This resulted in > > > > 7ded2624f8988bd22819a60a6000ba6b7091db89 is the first bad commit > > commit 7ded2624f8988bd22819a60a6000ba6b7091db89 > > Author: Yann E. MORIN

Re: [PATCH 6/8] kconfig: fix randomising choice entries in presence of KCONFIG_ALLCONFIG

2013-04-26 Thread Yann E. MORIN
Arnd, All, On Fri, Apr 26, 2013 at 02:05:37PM +0200, Arnd Bergmann wrote: > On Thursday 25 April 2013 00:29:53 Yann E. MORIN wrote: > > From: "Yann E. MORIN" > > > > Currently, randconfig does randomise choice entries, unless > > KCONFIG_ALLCONFIG > >

Re: linux-next: Tree for Apr 26

2013-04-26 Thread Yann E. MORIN
le to reproduce it with Linus' master: $ git checkout master # This is Linus' master [--SNIP--] $ git rev-parse HEAD 697dfd884438058b15032b0169887c742704434a $ git clean -dX; git clean -d [--SNIP--] $ cp ../linux-next.config .config $ make silentoldconfig >>

Re: linux-next: Tree for Apr 26

2013-04-26 Thread Yann E. MORIN
detected Sorry, I have no grasp on how my ISP filters incoming emails... :-( Regards, Yann E. MORIN. -- .-..--.. | Yann E. MORIN | Real-Time Embedded | /\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software

Re: [PATCH 6/8] kconfig: fix randomising choice entries in presence of KCONFIG_ALLCONFIG

2013-04-26 Thread Yann E. MORIN
Arnd, All, On Fri, Apr 26, 2013 at 02:05:37PM +0200, Arnd Bergmann wrote: On Thursday 25 April 2013 00:29:53 Yann E. MORIN wrote: From: Yann E. MORIN yann.morin.1...@free.fr Currently, randconfig does randomise choice entries, unless KCONFIG_ALLCONFIG is specified. For example

Re: linux-next: Tree for Apr 26

2013-04-26 Thread Yann E. MORIN
7ded2624f8988bd22819a60a6000ba6b7091db89 Author: Yann E. MORIN yann.morin.1...@free.fr Date: Sun Mar 10 16:34:10 2013 +0100 kconfig: fix randomising choice entries in presence of KCONFIG_ALLCONFIG The commit id is different, because it is reverted and applied again. Yann? Commit 422c809 (kconfig: fix randomising

Re: [PATCH 6/8] kconfig: fix randomising choice entries in presence of KCONFIG_ALLCONFIG

2013-04-26 Thread Yann E. MORIN
On Fri, Apr 26, 2013 at 02:05:37PM +0200, Arnd Bergmann wrote: On Thursday 25 April 2013 00:29:53 Yann E. MORIN wrote: From: Yann E. MORIN yann.morin.1...@free.fr Currently, randconfig does randomise choice entries, unless KCONFIG_ALLCONFIG is specified. For example, given those

[pull request] Pull request for branch yem-kconfig-for-next

2013-04-26 Thread Yann E. MORIN
From: Yann E. MORIN yann.morin.1...@free.fr Michal, Please pull this to revert: 422c809: fix randomising choice entries in presence of KCONFIG_ALLCONFIG It causes more harm that it fixes issues, and I couldn't find a proper fix for now. To avoid breakage so close to the opening of the merge

[PATCH 1/1] Revert kconfig: fix randomising choice entries in presence of KCONFIG_ALLCONFIG

2013-04-26 Thread Yann E. MORIN
From: Yann E. MORIN yann.morin.1...@free.fr This reverts commit 422c809f03f043d0950d8362214818e956a9daee. It causes more harm than it solves issues. Reported-by: Sedat Dilek sedat.di...@gmail.com Reported-by: Arnd Bergmann a...@arndb.de Signed-off-by: Yann E. MORIN yann.morin.1...@free.fr Tested

[PATCH 4/8] kconfig: fix randconfig tristate detection

2013-04-24 Thread Yann E. MORIN
From: "Yann E. MORIN" Because the modules' symbole (CONFIG_MODULES) may not yet be set when we check a symbol's tristate capabilty, we'll always find that tristate symbols are booleans, even if we randomly decided that to enable modules: sym_get_type(sym) always return boolean for tris

[PATCH 5/8] kconfig: do not override symbols already set

2013-04-24 Thread Yann E. MORIN
From: "Yann E. MORIN" For randconfig, if a list of required symbols is specified with KCONFIG_ALLCONFIG, such symbols do not "have a value" as per sym_has_value(), but have the "valid" flag set. Signed-off-by: "Yann E. MORIN" --- scripts/kconfig

[PATCH 3/8] kconfig/lxdialog: rationalise the include paths where to find {.n}curses{,w}.h

2013-04-24 Thread Yann E. MORIN
From: "Yann E. MORIN" The current code does this: if [ -f /usr/include/ncursesw/curses.h ]; then echo '-I/usr/include/ncursesw -DCURSES_LOC=""' elif [ -f /usr/include/ncurses/ncurses.h ]; then echo '-I/usr/include/ncurses -DCURSES_LOC="&quo

[PATCH 2/8] menuconfig: Add "breadcrumbs" navigation aid

2013-04-24 Thread Yann E. MORIN
From: Benjamin Poirier Displays a trail of the menu entries used to get to the current menu. Signed-off-by: Benjamin Poirier Tested-by: "Yann E. MORIN" [yann.morin.1...@free.fr: small, trivial code re-ordering] Signed-off-by: "Yann E. MORIN" --- scripts/kconfig/list

[PATCH 7/8] kconfig: allow specifying the seed for randconfig

2013-04-24 Thread Yann E. MORIN
From: "Yann E. MORIN" For reproducibility, it can be useful to be able to specify the seed to use to seed the RNG. Add a new KCONFIG_SEED environment variable which can be set to the seed to use: $ make KCONFIG_SEED=42 randconfig $ sha1s

[PATCH 6/8] kconfig: fix randomising choice entries in presence of KCONFIG_ALLCONFIG

2013-04-24 Thread Yann E. MORIN
From: "Yann E. MORIN" Currently, randconfig does randomise choice entries, unless KCONFIG_ALLCONFIG is specified. For example, given those two files (Thomas' test-case): ---8<--- Config.test.in config OPTIONA bool "Option A" choice p

[PATCH 1/8] menuconfig: Fix memory leak introduced by jump keys feature

2013-04-24 Thread Yann E. MORIN
From: Benjamin Poirier Fixes the memory leak of struct jump_key allocated in get_prompt_str() Signed-off-by: Benjamin Poirier Tested-by: "Yann E. MORIN" Reviewed-by: "Yann E. MORIN" Signed-off-by: "Yann E. MORIN" Cc: sta...@vger.kernel.org ---

[PATCH 8/8] kconfig: implement KCONFIG_PROBABILITY for randconfig

2013-04-24 Thread Yann E. MORIN
From: "Yann E. MORIN" Currently the odds to set each symbol is (rounded): booleans: y: 50% n: 50% tristates: y: 33% m: 33% n: 33% Introduce a KCONFIG_PROBABILITY environment variable to tweak the probabilities (in percentage), as such: KCONFIG_PROBABILITY

[pull request v2] Pull request for branch yem-kconfig-for-next

2013-04-24 Thread Yann E. MORIN
From: "Yann E. MORIN" Michal, Here is the official pull-request for the kconfig-related changes I've gathered from the linux-kbuild list, and those I've locally accumulated, for inclusin in 3.10: - memory leak fixed in mconf - 3 randconfig fixes (randomising choices, setting

[pull request v2] Pull request for branch yem-kconfig-for-next

2013-04-24 Thread Yann E. MORIN
From: Yann E. MORIN yann.morin.1...@free.fr Michal, Here is the official pull-request for the kconfig-related changes I've gathered from the linux-kbuild list, and those I've locally accumulated, for inclusin in 3.10: - memory leak fixed in mconf - 3 randconfig fixes (randomising choices

[PATCH 8/8] kconfig: implement KCONFIG_PROBABILITY for randconfig

2013-04-24 Thread Yann E. MORIN
From: Yann E. MORIN yann.morin.1...@free.fr Currently the odds to set each symbol is (rounded): booleans: y: 50% n: 50% tristates: y: 33% m: 33% n: 33% Introduce a KCONFIG_PROBABILITY environment variable to tweak the probabilities (in percentage

[PATCH 1/8] menuconfig: Fix memory leak introduced by jump keys feature

2013-04-24 Thread Yann E. MORIN
From: Benjamin Poirier bpoir...@suse.de Fixes the memory leak of struct jump_key allocated in get_prompt_str() Signed-off-by: Benjamin Poirier bpoir...@suse.de Tested-by: Yann E. MORIN yann.morin.1...@free.fr Reviewed-by: Yann E. MORIN yann.morin.1...@free.fr Signed-off-by: Yann E. MORIN

[PATCH 6/8] kconfig: fix randomising choice entries in presence of KCONFIG_ALLCONFIG

2013-04-24 Thread Yann E. MORIN
From: Yann E. MORIN yann.morin.1...@free.fr Currently, randconfig does randomise choice entries, unless KCONFIG_ALLCONFIG is specified. For example, given those two files (Thomas' test-case): ---8--- Config.test.in config OPTIONA bool Option A choice prompt

[PATCH 7/8] kconfig: allow specifying the seed for randconfig

2013-04-24 Thread Yann E. MORIN
From: Yann E. MORIN yann.morin.1...@free.fr For reproducibility, it can be useful to be able to specify the seed to use to seed the RNG. Add a new KCONFIG_SEED environment variable which can be set to the seed to use: $ make KCONFIG_SEED=42 randconfig $ sha1sum .config

[PATCH 2/8] menuconfig: Add breadcrumbs navigation aid

2013-04-24 Thread Yann E. MORIN
From: Benjamin Poirier bpoir...@suse.de Displays a trail of the menu entries used to get to the current menu. Signed-off-by: Benjamin Poirier bpoir...@suse.de Tested-by: Yann E. MORIN yann.morin.1...@free.fr [yann.morin.1...@free.fr: small, trivial code re-ordering] Signed-off-by: Yann E. MORIN

[PATCH 3/8] kconfig/lxdialog: rationalise the include paths where to find {.n}curses{,w}.h

2013-04-24 Thread Yann E. MORIN
From: Yann E. MORIN yann.morin.1...@free.fr The current code does this: if [ -f /usr/include/ncursesw/curses.h ]; then echo '-I/usr/include/ncursesw -DCURSES_LOC=ncursesw/curses.h' elif [ -f /usr/include/ncurses/ncurses.h ]; then echo '-I/usr/include/ncurses -DCURSES_LOC

[PATCH 4/8] kconfig: fix randconfig tristate detection

2013-04-24 Thread Yann E. MORIN
From: Yann E. MORIN yann.morin.1...@free.fr Because the modules' symbole (CONFIG_MODULES) may not yet be set when we check a symbol's tristate capabilty, we'll always find that tristate symbols are booleans, even if we randomly decided that to enable modules: sym_get_type(sym) always return

[PATCH 5/8] kconfig: do not override symbols already set

2013-04-24 Thread Yann E. MORIN
From: Yann E. MORIN yann.morin.1...@free.fr For randconfig, if a list of required symbols is specified with KCONFIG_ALLCONFIG, such symbols do not have a value as per sym_has_value(), but have the valid flag set. Signed-off-by: Yann E. MORIN yann.morin.1...@free.fr --- scripts/kconfig

[PATCH 2/4] kconfig: allow specifying the seed for randconfig

2013-04-16 Thread Yann E. MORIN
$ make KCONFIG_SEED=42 randconfig $ sha1sum .config 70a128c8dcc61303069e1be352cce64114dfcbca .config It's very usefull for eg. debugging the kconfig parser. Signed-off-by: "Yann E. MORIN" --- Documentation/kbuild/kconfig.txt |9 + scripts/kconfig/conf.c

[PATCH 0/4] Some kconfig improvements and fixes

2013-04-16 Thread Yann E. MORIN
[PATCH 4/4] kconfig: do randomise choice entries in presence of KCONFIG_ALLCONFIG Regards, Yann E. MORIN. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

[PATCH 3/4] kconfig: implement KCONFIG_PROBABILITY for randconfig

2013-04-16 Thread Yann E. MORIN
.1...@free.fr: add to Documentation/] Signed-off-by: "Yann E. MORIN" --- Documentation/kbuild/kconfig.txt | 17 + scripts/kconfig/confdata.c | 22 +++--- 2 files changed, 36 insertions(+), 3 deletions(-) diff --git a/Documentation/kbuild/kco

[PATCH 4/4] kconfig: do randomise choice entries in presence of KCONFIG_ALLCONFIG

2013-04-16 Thread Yann E. MORIN
CONFIG_OPTION_C is not setCONFIG_OPTION_C=y ---8<------8<--- Ie., the first entry in a choice is always set, plus zero or one of the other options may be set. This patch ensures that only one option may be set for a choice. Reported-by: Thomas Petazzoni

[PATCH 1/4] kconfig/lxdialog: rationalise the include paths where to find {.n}curses{,w}.h

2013-04-16 Thread Yann E. MORIN
ly in #include is more in line with how pkg-config behaves, eg.: $ pkg-config --cflags ncursesw -I/usr/include/ncursesw This paves the way for using pkg-config for CFLAGS, too, now we use it to find the libraries. Signed-off-by: "Yann E. MORIN" --- scripts/kconfig/lxdialo

Re: [PATCH v3] menuconfig: Add "breadcrumbs" navigation aid

2013-04-16 Thread Yann E. MORIN
Benjamin, All, On Tue, Apr 16, 2013 at 10:07:23AM -0400, Benjamin Poirier wrote: > Displays a trail of the menu entries used to get to the current menu. > > Signed-off-by: Benjamin Poirier > Tested-by: "Yann E. MORIN" > [yann.morin.1...@free.fr: small, trivial code

Re: [PATCH 1/2] menuconfig: Fix memory leak introduced by jump keys feature

2013-04-16 Thread Yann E. MORIN
Michal, All, On Tue, Apr 16, 2013 at 11:12:41AM +0200, Michal Marek wrote: > > On 15.4.2013 23:54, Yann E. MORIN wrote: > >> So, unless Michal really wants to pull this one and push it to Linus > >> before he cuts v3.9 final, I'll merge this later in my -for-next branch.

Re: [PATCH 1/2] menuconfig: Fix memory leak introduced by jump keys feature

2013-04-16 Thread Yann E. MORIN
Michal, All, On Tue, Apr 16, 2013 at 11:12:41AM +0200, Michal Marek wrote: On 15.4.2013 23:54, Yann E. MORIN wrote: So, unless Michal really wants to pull this one and push it to Linus before he cuts v3.9 final, I'll merge this later in my -for-next branch. BTW, in you are going to rebase

Re: [PATCH v3] menuconfig: Add breadcrumbs navigation aid

2013-04-16 Thread Yann E. MORIN
Benjamin, All, On Tue, Apr 16, 2013 at 10:07:23AM -0400, Benjamin Poirier wrote: Displays a trail of the menu entries used to get to the current menu. Signed-off-by: Benjamin Poirier bpoir...@suse.de Tested-by: Yann E. MORIN yann.morin.1...@free.fr [yann.morin.1...@free.fr: small, trivial

[PATCH 1/4] kconfig/lxdialog: rationalise the include paths where to find {.n}curses{,w}.h

2013-04-16 Thread Yann E. MORIN
and the filename-only in #include is more in line with how pkg-config behaves, eg.: $ pkg-config --cflags ncursesw -I/usr/include/ncursesw This paves the way for using pkg-config for CFLAGS, too, now we use it to find the libraries. Signed-off-by: Yann E. MORIN yann.morin.1...@free.fr --- scripts

[PATCH 3/4] kconfig: implement KCONFIG_PROBABILITY for randconfig

2013-04-16 Thread Yann E. MORIN
...@uclibc.org [yann.morin.1...@free.fr: add to Documentation/] Signed-off-by: Yann E. MORIN yann.morin.1...@free.fr --- Documentation/kbuild/kconfig.txt | 17 + scripts/kconfig/confdata.c | 22 +++--- 2 files changed, 36 insertions(+), 3 deletions(-) diff --git

[PATCH 4/4] kconfig: do randomise choice entries in presence of KCONFIG_ALLCONFIG

2013-04-16 Thread Yann E. MORIN
is always set, plus zero or one of the other options may be set. This patch ensures that only one option may be set for a choice. Reported-by: Thomas Petazzoni thomas.petazz...@free-electrons.com Signed-off-by: Yann E. MORIN yann.morin.1...@free.fr Cc: Thomas Petazzoni thomas.petazz...@free

[PATCH 0/4] Some kconfig improvements and fixes

2013-04-16 Thread Yann E. MORIN
[PATCH 4/4] kconfig: do randomise choice entries in presence of KCONFIG_ALLCONFIG Regards, Yann E. MORIN. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

[PATCH 2/4] kconfig: allow specifying the seed for randconfig

2013-04-16 Thread Yann E. MORIN
$ make KCONFIG_SEED=42 randconfig $ sha1sum .config 70a128c8dcc61303069e1be352cce64114dfcbca .config It's very usefull for eg. debugging the kconfig parser. Signed-off-by: Yann E. MORIN yann.morin.1...@free.fr --- Documentation/kbuild/kconfig.txt |9 + scripts/kconfig/conf.c

Re: [PATCH 1/2] menuconfig: Fix memory leak introduced by jump keys feature

2013-04-15 Thread Yann E. MORIN
cle is a bit dangerous (heck, I would not like to be part of the cause of a new flaming, just for this! ;-) ) So, unless Michal really wants to pull this one and push it to Linus before he cuts v3.9 final, I'll merge this later in my -for-next branch. Thank you! Regards, Yann E. MO

Re: [PATCH 2/2] menuconfig: Add "breadcrumbs" navigation aid

2013-04-15 Thread Yann E. MORIN
for (i = len + 1; i < COLS - 1; i++) + waddch(stdscr, ACS_HLINE); [--SNIP--] Queued (with that change) into: https://git.gitorious.org/linux-kconfig/linux-kconfig.git yem-kconfig-for-next Regards, Yann E. MORIN. -- .-..-

Re: [PATCH 2/2] menuconfig: Add breadcrumbs navigation aid

2013-04-15 Thread Yann E. MORIN
(stdscr, 1, len+1); + for (i = len + 1; i COLS - 1; i++) + waddch(stdscr, ACS_HLINE); [--SNIP--] Queued (with that change) into: https://git.gitorious.org/linux-kconfig/linux-kconfig.git yem-kconfig-for-next Regards, Yann E. MORIN

Re: [PATCH 1/2] menuconfig: Fix memory leak introduced by jump keys feature

2013-04-15 Thread Yann E. MORIN
is a bit dangerous (heck, I would not like to be part of the cause of a new flaming, just for this! ;-) ) So, unless Michal really wants to pull this one and push it to Linus before he cuts v3.9 final, I'll merge this later in my -for-next branch. Thank you! Regards, Yann E. MORIN

Re: Final versions of ncurses libs detection patches

2013-03-06 Thread Yann E. MORIN
n using our previous legacy checks. I'm still doing a few more tests on my side before queuing. > Thanks for all suggestions, Thanks for staying around during the iterations. Regards, Yann E. MORIN. -- .-..--.--------. | Yan

Re: [PATCH 2/2] kconfig: optionally use pkg-config to detect ncurses libs

2013-03-06 Thread Yann E. MORIN
es > 2>/dev/null \ > + || echo "-lmenu -lpanel -ncurses" ) Typo: this should be: "-lncurses" and not: "-ncurses" I'll fix it here before queuing, no need to resend. Regards, Yann E. MORIN. -- .-.

Re: [PATCH 2/2] kconfig: optionally use pkg-config to detect ncurses libs

2013-03-06 Thread Yann E. MORIN
) Typo: this should be: -lncurses and not: -ncurses I'll fix it here before queuing, no need to resend. Regards, Yann E. MORIN. -- .-..--.. | Yann E. MORIN | Real-Time Embedded | /\ ASCII RIBBON | Erics' conspiracy

Re: Final versions of ncurses libs detection patches

2013-03-06 Thread Yann E. MORIN
checks. I'm still doing a few more tests on my side before queuing. Thanks for all suggestions, Thanks for staying around during the iterations. Regards, Yann E. MORIN. -- .-..--.. | Yann E. MORIN | Real-Time Embedded

Re: [PATCH 2/2] kconfig: use config scripts to detect ncurses libs

2013-03-03 Thread Yann E. MORIN
ig scripts, and: - try pkg-config; - fallback to -lncurses. HOSTLOADLIBES_nconf += $(shell \ pkg-config --libs ncurses 2>/dev/null \ || echo -lncurses ) Regards, Yann E. MORIN. -- .-.-

Re: [PATCH 1/2] menuconfig: use config scripts to detect ncurses libs

2013-03-03 Thread Yann E. MORIN
nfig script are unreliable: at least one major distribution (Debian) is broken and, for various reasons, is not gonna fix it, and all its derivatives (eg. Ubuntu) do suffer from the same deficiency. I think we should stick to: - try with pkg-config; - fallback to the legacy heuristic. Does usi

Re: [PATCH 2/2] kconfig: use config scripts to detect ncurses libs

2013-03-03 Thread Yann E. MORIN
problem that ncursesw5-config exists > even if the libncursesw5-dev package is not installed, so this patch > makes the build fail in such cases. The same goes for ncurses5-config, which is provided by ncurses-bin, and so is present even if the devel package is not installed, and the build will

Re: [PATCH] menuconfig: use config scripts to detect ncurses libs

2013-03-03 Thread Yann E. MORIN
Michal, All, On Friday 01 March 2013 Michal Marek wrote: > On 28.2.2013 19:16, Yann E. MORIN wrote: > > On Thursday 28 February 2013 j...@gentoo.org wrote: > >> This patch replaces the old heuristic for detection of ncurses libs for > >> linking the ncurses m

Re: [PATCH] menuconfig: use config scripts to detect ncurses libs

2013-03-03 Thread Yann E. MORIN
Michal, All, On Friday 01 March 2013 Michal Marek wrote: On 28.2.2013 19:16, Yann E. MORIN wrote: On Thursday 28 February 2013 j...@gentoo.org wrote: This patch replaces the old heuristic for detection of ncurses libs for linking the ncurses menuconfig dialog by the use of the config

Re: [PATCH 2/2] kconfig: use config scripts to detect ncurses libs

2013-03-03 Thread Yann E. MORIN
if the devel package is not installed, and the build will break, too. Regards, Yann E. MORIN. -- .-..--.. | Yann E. MORIN | Real-Time Embedded | /\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer

Re: [PATCH 1/2] menuconfig: use config scripts to detect ncurses libs

2013-03-03 Thread Yann E. MORIN
deficiency. I think we should stick to: - try with pkg-config; - fallback to the legacy heuristic. Does using pkg-config fix your use-case? Regards, Yann E. MORIN. -- .-..--.. | Yann E. MORIN | Real-Time Embedded

Re: [PATCH 2/2] kconfig: use config scripts to detect ncurses libs

2013-03-03 Thread Yann E. MORIN
\ pkg-config --libs ncurses 2/dev/null \ || echo -lncurses ) Regards, Yann E. MORIN. -- .-..--.. | Yann E. MORIN | Real-Time Embedded | /\ ASCII RIBBON | Erics' conspiracy

Re: [PATCH 1/2] Use config scripts to detect ncurses libs for menuconfig

2013-02-28 Thread Yann E. MORIN
Justin, All, On Thursday 28 February 2013 justin wrote: > On 2/28/13 7:08 PM, Yann E. MORIN wrote: > > Well, RHEL4 is still widely used, and it was released in 2005, so will > > not have ncurses-5.6 (updates may have it, but not everybody installs > > updates). > >

Re: [PATCH 2/2] kconfig: use config scripts to detect ncurses libs

2013-02-28 Thread Yann E. MORIN
ux-kconfig Thank you! :-) Regards, Yann E. MORIN. -- .-..--.--------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___

Re: [PATCH] menuconfig: use config scripts to detect ncurses libs

2013-02-28 Thread Yann E. MORIN
use of the *-config scripts. And, sorry, I should have been more explicit in my previous mail that the legacy drop should be in its own patch. I thought that was obvious, following the "one single change per patch" philosophy. Thanks you! :-) Regards, Yann E. MORIN. > Signed-off-by:

Re: [PATCH 1/2] Use config scripts to detect ncurses libs for menuconfig

2013-02-28 Thread Yann E. MORIN
sed in 2006. So I would guess we can > assume that every system will have it. Well, RHEL4 is still widely used, and it was released in 2005, so will not have ncurses-5.6 (updates may have it, but not everybody installs updates). Regards, Yann E. MORIN. -- .-.--------

Re: [PATCH 2/2] Use config scripts to detect ncurses libs for nconfig

2013-02-28 Thread Yann E. MORIN
Regards, Yann E. MORIN. -- .-..--.. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +

Re: [PATCH 2/2] Use config scripts to detect ncurses libs for nconfig

2013-02-28 Thread Yann E. MORIN
. MORIN. -- .-..--.. | Yann E. MORIN | Real-Time Embedded | /\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `.---: X

Re: [PATCH 1/2] Use config scripts to detect ncurses libs for menuconfig

2013-02-28 Thread Yann E. MORIN
, RHEL4 is still widely used, and it was released in 2005, so will not have ncurses-5.6 (updates may have it, but not everybody installs updates). Regards, Yann E. MORIN. -- .-..--.. | Yann E. MORIN | Real-Time Embedded

Re: [PATCH] menuconfig: use config scripts to detect ncurses libs

2013-02-28 Thread Yann E. MORIN
. And, sorry, I should have been more explicit in my previous mail that the legacy drop should be in its own patch. I thought that was obvious, following the one single change per patch philosophy. Thanks you! :-) Regards, Yann E. MORIN. Signed-off-by: Justin Lecher j...@gentoo.org --- scripts/kconfig

Re: [PATCH 2/2] kconfig: use config scripts to detect ncurses libs

2013-02-28 Thread Yann E. MORIN
, Yann E. MORIN. -- .-..--.. | Yann E. MORIN | Real-Time Embedded | /\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172

Re: [PATCH 1/2] Use config scripts to detect ncurses libs for menuconfig

2013-02-28 Thread Yann E. MORIN
Justin, All, On Thursday 28 February 2013 justin wrote: On 2/28/13 7:08 PM, Yann E. MORIN wrote: Well, RHEL4 is still widely used, and it was released in 2005, so will not have ncurses-5.6 (updates may have it, but not everybody installs updates). question, will such system be updated

Re: [PATCH 2/2] Use config scripts to detect ncurses libs for nconfig

2013-02-27 Thread Yann E. MORIN
llncursesw5-config --libs 2>/dev/null \ || ncurses5-config --libs 2>/dev/null ) Regards, Yann E. MORIN. -- .-..--.. | Yann E. MORIN | Real-Time Embedded

Re: [PATCH 1/2] Use config scripts to detect ncurses libs for menuconfig

2013-02-27 Thread Yann E. MORIN
$cc -print-file-name=lib${lib}.${ext} | grep -q > / > + if [ $? -eq 0 ]; then > + echo "-l${lib}" > + exit > + fi > +

Re: [PATCH 1/2] Use config scripts to detect ncurses libs for menuconfig

2013-02-27 Thread Yann E. MORIN
+ fi + done done - done + fi exit 1 } Regards, Yann E. MORIN. -- .-..--.. | Yann E. MORIN | Real-Time Embedded | /\ ASCII RIBBON | Erics

Re: [PATCH 2/2] Use config scripts to detect ncurses libs for nconfig

2013-02-27 Thread Yann E. MORIN
-config --libs 2/dev/null ) Regards, Yann E. MORIN. -- .-..--.. | Yann E. MORIN | Real-Time Embedded | /\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN

Re: [PATCH] Use config scripts to detect ncurses libs for, menuconfig/nconfig dialogs

2013-02-25 Thread Yann E. MORIN
Justin, All, On Monday 25 February 2013 Justin wrote: > On 25.02.2013 19:30, Yann E. MORIN wrote: > > On Sunday 24 February 2013 Justin wrote: > >> when ncurses is build with --with-termlib several symbols are moved to a > >> seperate terminfo library (libtinfo.so).

Re: [PATCH] Use config scripts to detect ncurses libs for, menuconfig/nconfig dialogs

2013-02-25 Thread Yann E. MORIN
^^ This is a bashism, and will not work on purely POSIX shells. Please use: >/dev/null 2>&1 > + ncurses5-config --libs I'd write: if ! ncurses5-config --libs 2>/dev/null; then old-code goes here fi > + exit 0 (nit-picking) I'd pr

Re: [PATCH] Use config scripts to detect ncurses libs for, menuconfig/nconfig dialogs

2013-02-25 Thread Yann E. MORIN
+ exit 0 (nit-picking) I'd prefer you be consistent with existing code which just calls 'exit' without a number. Regards, Yann E. MORIN. -- .-..--.. | Yann E. MORIN | Real-Time Embedded | /\ ASCII RIBBON | Erics

Re: [PATCH] Use config scripts to detect ncurses libs for, menuconfig/nconfig dialogs

2013-02-25 Thread Yann E. MORIN
Justin, All, On Monday 25 February 2013 Justin wrote: On 25.02.2013 19:30, Yann E. MORIN wrote: On Sunday 24 February 2013 Justin wrote: when ncurses is build with --with-termlib several symbols are moved to a seperate terminfo library (libtinfo.so). Current Kernel buildsystem results

Re: kconfig-frontends-3.8.0.0 release

2013-02-19 Thread Yann E. MORIN
Jan, All, On Wednesday 20 February 2013 Yann E. MORIN wrote: > $ ls -lrt /usr/bin/*{conf,gettext,diff} Obviously, that line above should have been (with the same result): $ ls -lrt /usr/bin/ lrwxrwxrwx 1 root root 26 Feb 19 23:11 fakeroot -> /etc/alternatives/fakeroot lrwxrwxrwx

Re: kconfig-frontends-3.8.0.0 release

2013-02-19 Thread Yann E. MORIN
Jan, All, On Tuesday 19 February 2013 Jan Engelhardt wrote: > On Tuesday 2013-02-19 23:14, Yann E. MORIN wrote: > >I'm pleased to announce the release of kconfig-frontends 3.8.0.0! > >Go download it there: > > > > http://ymorin.is-a-geek.org/download/kconfig-

kconfig-frontends-3.8.0.0 release

2013-02-19 Thread Yann E. MORIN
to following the evolution of kconfig, without the burden to manually synchronise from the Linux kernel source tree. Any comment, any feedback, any patch is welcome! ;-) [0] http://marc.info/?l=linux-kbuild=132753216310722 [1] https://lwn.net/Articles/487487/ Regards, Yann E. MORIN

kconfig-frontends-3.8.0.0 release

2013-02-19 Thread Yann E. MORIN
to following the evolution of kconfig, without the burden to manually synchronise from the Linux kernel source tree. Any comment, any feedback, any patch is welcome! ;-) [0] http://marc.info/?l=linux-kbuildm=132753216310722 [1] https://lwn.net/Articles/487487/ Regards, Yann E. MORIN

Re: kconfig-frontends-3.8.0.0 release

2013-02-19 Thread Yann E. MORIN
Jan, All, On Tuesday 19 February 2013 Jan Engelhardt wrote: On Tuesday 2013-02-19 23:14, Yann E. MORIN wrote: I'm pleased to announce the release of kconfig-frontends 3.8.0.0! Go download it there: http://ymorin.is-a-geek.org/download/kconfig-frontends/kconfig-frontends-3.8.0.0.tar.xz

Re: kconfig-frontends-3.8.0.0 release

2013-02-19 Thread Yann E. MORIN
Jan, All, On Wednesday 20 February 2013 Yann E. MORIN wrote: $ ls -lrt /usr/bin/*{conf,gettext,diff} Obviously, that line above should have been (with the same result): $ ls -lrt /usr/bin/ lrwxrwxrwx 1 root root 26 Feb 19 23:11 fakeroot - /etc/alternatives/fakeroot lrwxrwxrwx 1 root

Re: [PATCH resend v3 3/3] kconfig: nconf: add vi-style navigation keys

2013-02-09 Thread Yann E. MORIN
Rolland, All, On Saturday 09 February 2013 Roland Eggner wrote: > On 2013-02-09 Saturday at 02:03 +0100 Yann E. MORIN wrote: > > On Friday 01 February 2013 Roland Eggner wrote: > > > Add vi-style navigation keys, based on initial work by Dmitry Voytik. > > > > As

Re: [PATCH resend v3 1/3] kconfig: nconf: rewrite help texts

2013-02-09 Thread Yann E. MORIN
Rolland, All, On Saturday 09 February 2013 Roland Eggner wrote: > On 2013-02-09 Saturday at 01:30 +0100 Yann E. MORIN wrote: [--SNIP--] > > > +"Text Box (Help Window)\n" > > > +"--\n" > > > +"Use movement k

Re: [PATCH resend v3 1/3] kconfig: nconf: rewrite help texts

2013-02-09 Thread Yann E. MORIN
Rolland, All, On Saturday 09 February 2013 Roland Eggner wrote: On 2013-02-09 Saturday at 01:30 +0100 Yann E. MORIN wrote: [--SNIP--] +Text Box (Help Window)\n +--\n +Use movement keys Down Up PageDown PageUp End Home as listed in\n +table above.\n

Re: [PATCH resend v3 3/3] kconfig: nconf: add vi-style navigation keys

2013-02-09 Thread Yann E. MORIN
Rolland, All, On Saturday 09 February 2013 Roland Eggner wrote: On 2013-02-09 Saturday at 02:03 +0100 Yann E. MORIN wrote: On Friday 01 February 2013 Roland Eggner wrote: Add vi-style navigation keys, based on initial work by Dmitry Voytik. As much I am a unconditional vim user, I

Re: [PATCH resend v3 3/3] kconfig: nconf: add vi-style navigation keys

2013-02-08 Thread Yann E. MORIN
nce is remapped and people already rely on to provide help, not do any other weird thing (like exiting the current submenu). Regards, Yann E. MORIN. -- .-..--.. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON

Re: [PATCH resend v3 1/3] kconfig: nconf: rewrite help texts

2013-02-08 Thread Yann E. MORIN
ot; > "Symbol: FOO [ = m]\n" > @@ -229,26 +222,26 @@ search_help[] = N_( > "Selects: LIBCRC32\n" > "Selected by: BAR\n" > "-\n" > -"o T

Re: [PATCH resend v3 1/3] kconfig: nconf: rewrite help texts

2013-02-08 Thread Yann E. MORIN
will push soon to my branch. Thank you! :-) Regards, Yann E. MORIN. -- .-..--.. | Yann E. MORIN | Real-Time Embedded | /\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN

Re: [PATCH resend v3 3/3] kconfig: nconf: add vi-style navigation keys

2013-02-08 Thread Yann E. MORIN
is remapped and people already rely on h to provide help, not do any other weird thing (like exiting the current submenu). Regards, Yann E. MORIN. -- .-..--.. | Yann E. MORIN | Real-Time Embedded | /\ ASCII RIBBON | Erics

Re: [PATCH v2 1/2] nconf: add keybindings for vi-style menu navigation, rewrite help texts

2013-01-15 Thread Yann E. MORIN
submit them as four patches: - help rewrite - labels rewrite (update help accordingly) - vi-like keys - readline-like keys (Or the other way around for the last two patches.) With this patch ordering, each patch is easier to review, the fixes ones (help and labels rewrites) can b

Re: [PATCH v2stable 1/2] nconf: add keybindings for vi-style menu navigation, rewrite help texts

2013-01-15 Thread Yann E. MORIN
Roland, All, On Tuesday 15 January 2013 Roland Eggner wrote: > >From: Roland Eggner [--SNIP--] > --- > For stable users: to be applied on vanilla 3.2.37 I think feature-changes are not supposed to go into -stable. Regards, Y

<    1   2   3   4   5   >