Re: linux-next: Signed-off-bys missing for commits in the thermal tree

2017-09-04 Thread Zhang Rui
On Tue, 2017-09-05 at 10:57 +1000, Stephen Rothwell wrote: > Hi Zhang, > > Commits > >   1f0d851d9359 ("Debug patch") >   083d998842a2 ("debug") > > are missing a Signed-off-bys. > > These are not really appropriate for linux-next inclusion - > especially > during the merge window. > oops, sor

Re: [PATCH][next] Thermal: int3406_thermal: fix unused variable warning

2017-09-03 Thread Zhang Rui
On Fri, 2017-09-01 at 10:58 +0100, Colin King wrote: > From: Colin Ian King > > The variable index was introduced by an earlier commit and is not > used, and hence should be removed. > > Cleans up warning: "unused variable 'index'" > > Fixes: c658894562ba ("Thermal: int3406_thermal: fix thermal

Re: [PATCH v2 5/5] thermal: Add Tegra BPMP thermal sensor driver

2017-08-31 Thread Zhang Rui
On Thu, 2017-08-31 at 14:45 +0200, Thierry Reding wrote: > On Mon, Aug 21, 2017 at 10:40:44AM +0800, Wei Ni wrote: > > > > > > > > On Friday, August 11, 2017 10:57 AM, Zhang Rui wrote: > > > > > > On Mon, 2017-07-24 at 19:29 +0300, Mikko Perttunen

Re: [PATCH v2 0/5] thermal: imx: Add nvmem-cells binding on imx6sx

2017-08-31 Thread Zhang Rui
On Thu, 2017-08-31 at 16:48 +0800, Shawn Guo wrote: > On Fri, Jul 14, 2017 at 05:11:05PM +0300, Leonard Crestez wrote: > > > > Leonard Crestez (5): > >   thermal: imx: Add nvmem-cells alternate binding for OCOTP access > >   nvmem: core: Add nvmem_cell_read_u32 > >   thermal: imx: Add support for

Re: [PATCH] thermal: max77620: constify platform_device_id

2017-08-24 Thread Zhang Rui
On Sun, 2017-08-13 at 17:03 +0530, Arvind Yadav wrote: > platform_device_id are not supposed to change at runtime. All > functions > working with platform_device_id provided by > work with const platform_device_id. So mark the non-const structs as > const. > > Signed-off-by: Arvind Yadav applie

Re: [PATCH v2 3/5] thermal: imx: Add support for reading OCOTP through nvmem

2017-08-24 Thread Zhang Rui
On Wed, 2017-08-16 at 18:33 +0300, Leonard Crestez wrote: > On Tue, 2017-08-08 at 20:58 +0800, Zhang Rui wrote: > > > > On Tue, 2017-08-08 at 12:44 +0100, Srinivas Kandagatla wrote: > > > > > > On 08/08/17 12:38, Leonard Crestez wrote: > > > > > &

Re: [PATCH V1] thermal: qcom-spmi-temp-alarm: add support for GEN2 PMIC peripherals

2017-08-24 Thread Zhang Rui
On Thu, 2017-08-17 at 13:12 +0530, kgu...@codeaurora.org wrote: > On 2017-08-16 17:53, kgu...@codeaurora.org wrote: > > > > On 2017-08-08 13:42, Zhang Rui wrote: > > > > > > On Thu, 2017-07-13 at 17:39 +0530, Kiran Gunda wrote: > > > > > > &g

Re: [PATCH v4 2/4] thermal: add brcmstb AVS TMON driver

2017-08-14 Thread Zhang Rui
On Tue, 2017-08-15 at 08:42 +0200, Rafał Miłecki wrote: > On 2017-08-15 08:08, Zhang Rui wrote: > > > > > > > > diff --git a/drivers/thermal/broadcom/Kconfig > > > b/drivers/thermal/broadcom/Kconfig > > > index 42c098e..c106a15 100644 > > &

Re: [PATCH v4 2/4] thermal: add brcmstb AVS TMON driver

2017-08-14 Thread Zhang Rui
On Wed, 2017-08-09 at 15:02 -0700, Markus Mayer wrote: > From: Brian Norris > > The AVS TMON core provides temperature readings, a pair of > configurable > high- and low-temperature threshold interrupts, and an emergency > over-temperature chip reset. The driver utilizes the first two to > provid

Re: [PATCH 1/3 v2] thermal: core: Add some new helper functions to free resources

2017-08-11 Thread Zhang Rui
On Fri, 2017-08-11 at 09:30 +0200, walter harms wrote: > > Am 08.08.2017 16:39, schrieb Christophe JAILLET: > > > > In order to easily free resources allocated by > > 'thermal_zone_create_device_groups()' we need 2 new helper > > functions. > > > > The first one undoes 'thermal_zone_create_devic

Re: [PATCH v2 0/5] thermal: rockchip: add tsadc support in thermal driver and IPA thermal control for rk3328 in dts

2017-08-11 Thread Zhang Rui
On Fri, 2017-08-11 at 08:27 +0200, Heiko Stuebner wrote: > Hi, > > Am Freitag, 11. August 2017, 12:51:35 CEST schrieb Zhang Rui: > > > > On Fri, 2017-08-04 at 16:06 +0800, Rocky Hao wrote: > > > > > > This series patches add the tsadc support in thermal d

Re: [PATCH v4 0/4] thermal: add brcmstb AVS TMON driver

2017-08-10 Thread Zhang Rui
On Wed, 2017-08-09 at 15:02 -0700, Markus Mayer wrote: > From: Markus Mayer > > This series adds the brcmstb AVS TMON driver. > > The driver was originally written by Brian Norris. > > This series is also available at > https://github.com/mmayer/linux/tree/brcmstb-thermal-4.13-v4. > > v1 of th

Re: [PATCH v2 0/5] thermal: rockchip: add tsadc support in thermal driver and IPA thermal control for rk3328 in dts

2017-08-10 Thread Zhang Rui
On Fri, 2017-08-04 at 16:06 +0800, Rocky Hao wrote: > This series patches add the tsadc support in thermal driver and in > devicetree for rk3328. > Also add thermal control with Intelligent Power Allocation (IPA) > policy by default.  Please > refer to https://developer.arm.com/open-source/intellig

Re: [PATCH 0/9 v2] constify thermal_zone_of_device_ops structures

2017-08-10 Thread Zhang Rui
On Tue, 2017-08-08 at 17:08 +0200, Julia Lawall wrote: > The thermal_zone_of_device_ops structures are only passed as the > fourth > argument to thermal_zone_of_sensor_register or > devm_thermal_zone_of_sensor_register, both of which are declared as > const. > Thus the thermal_zone_of_device_ops st

Re: [PATCH 1/3 v2] thermal: core: Add some new helper functions to free resources

2017-08-10 Thread Zhang Rui
On Fri, 2017-08-11 at 11:23 +0800, Zhang Rui wrote: > On Tue, 2017-08-08 at 16:39 +0200, Christophe JAILLET wrote: > > > > In order to easily free resources allocated by > > 'thermal_zone_create_device_groups()' we need 2 new helper > > fun

Re: [PATCH 1/3 v2] thermal: core: Add some new helper functions to free resources

2017-08-10 Thread Zhang Rui
On Tue, 2017-08-08 at 16:39 +0200, Christophe JAILLET wrote: > In order to easily free resources allocated by > 'thermal_zone_create_device_groups()' we need 2 new helper functions. > > The first one undoes 'thermal_zone_create_device_groups()'. > The 2nd one undoes 'create_trip_attrs()', which is

Re: [PATCH] thermal/drivers/hisi: Remove confusing error message

2017-08-10 Thread Zhang Rui
On Tue, 2017-08-08 at 21:29 +0800, Leo Yan wrote: > On Tue, Aug 08, 2017 at 08:48:51PM +0800, Zhang Rui wrote: > > [...] > > > > > > > > > > > > > > > > > > > > @@ -352,10 +353,9 @@ static int hisi_thermal_prob

Re: [PATCH] thermal: rockchip: fix error return code in rockchip_thermal_probe()

2017-08-10 Thread Zhang Rui
On Mon, 2017-08-07 at 23:35 -0500, Gustavo A. R. Silva wrote: > platform_get_irq() returns an error code, but the rockchip_thermal > driver > ignores it and always returns -EINVAL. This is not correct and, > prevents > -EPROBE_DEFER from being propagated properly. > > Notice that platform_get_irq(

Re: [PATCH 2/5] thermal: rockchip: Support the RK3328 SOC in thermal driver

2017-08-10 Thread Zhang Rui
On Tue, 2017-07-25 at 17:09 +0800, Rocky Hao wrote: > RK3328 SOC has one Temperature Sensor for CPU. > > Change-Id: I176c76bae1801d815a513986cfefcb55272c69a8 > Signed-off-by: Rocky Hao Caesar, what do you think of this patch? thanks, rui > --- >  drivers/thermal/rockchip_thermal.c | 65 >

Re: [PATCH v2 5/5] thermal: Add Tegra BPMP thermal sensor driver

2017-08-10 Thread Zhang Rui
On Mon, 2017-07-24 at 19:29 +0300, Mikko Perttunen wrote: > On Tegra186, the BPMP (Boot and Power Management Processor) exposes > an > interface to thermal sensors on the system-on-chip. This driver > implements access to the interface. It supports reading the > temperature, setting trip points and

Re: [PATCH 0/4] constify thermal_zone_of_device_ops structures

2017-08-08 Thread Zhang Rui
On Sat, 2017-08-05 at 22:37 +0200, Julia Lawall wrote: > The thermal_zone_of_device_ops structures are only passed as the > fourth > argument to thermal_zone_of_sensor_register, which is declared as > const. > Thus the thermal_zone_of_device_ops structures themselves can be > const. > > Done with

Re: [PATCH v6 2/2] thermal: uniphier: add UniPhier thermal driver

2017-08-08 Thread Zhang Rui
On Tue, 2017-08-01 at 17:04 +0900, Kunihiko Hayashi wrote: > Add a thermal driver for on-chip PVT (Process, Voltage and > Temperature) > monitoring unit implemented on UniPhier SoCs. This driver supports > temperature monitoring and alert function. > > Signed-off-by: Kunihiko Hayashi > --- >  dri

Re: [PATCH 2/3] thermal: core: Reorder 'thermal_zone_device_register()' error handling code

2017-08-08 Thread Zhang Rui
On Tue, 2017-08-08 at 14:31 +0200, Christophe JAILLET wrote: > Le 08/08/2017 à 10:49, Zhang Rui a écrit : > > > > On Sun, 2017-07-16 at 08:59 +0200, Christophe JAILLET wrote: > > > > > > Reorder code in the error handling path in order to match the way > >

Re: [PATCH v2 3/5] thermal: imx: Add support for reading OCOTP through nvmem

2017-08-08 Thread Zhang Rui
On Tue, 2017-08-08 at 12:44 +0100, Srinivas Kandagatla wrote: > > > > On 08/08/17 12:38, Leonard Crestez wrote: > > > > On Tue, 2017-08-08 at 12:00 +0100, Srinivas Kandagatla wrote: > > > > > > On 08/08/17 08:21, Zhang Rui wrote: > > > >

Re: [PATCH] thermal/drivers/hisi: Remove confusing error message

2017-08-08 Thread Zhang Rui
On Tue, 2017-08-08 at 12:15 +0200, Daniel Lezcano wrote: > On 08/08/2017 09:55, Zhang Rui wrote: > > > > On Fri, 2017-07-07 at 17:03 +0200, Daniel Lezcano wrote: > > > > > > The sensor id is unknown at init time and we use all id in the > > > authorized

Re: [PATCH v3 1/4] Documentation: devicetree: add binding for Broadcom STB AVS TMON

2017-08-08 Thread Zhang Rui
On Mon, 2017-07-31 at 12:26 -0700, Markus Mayer wrote: > From: Brian Norris > > Add binding for Broadcom STB thermal. > > Signed-off-by: Brian Norris > Signed-off-by: Markus Mayer $ file v3-1-4-Documentation-devicetree-add-binding-for-Broadcom-STB- AVS-TMON.patch  unified diff output, UTF-8 U

Re: [PATCH v3 0/4] thermal: add brcmstb AVS TMON driver

2017-08-08 Thread Zhang Rui
On Mon, 2017-08-07 at 10:52 -0700, Florian Fainelli wrote: > On 07/31/2017 12:26 PM, Markus Mayer wrote: > > > > From: Markus Mayer > > > > This series adds the brcmstb AVS TMON driver. > > > > The driver was originally written by Brian Norris. > > > > v1 of this series can be found at https:/

Re: [PATCH] thermal: core: fix some format issues on critical shutdown string

2017-08-08 Thread Zhang Rui
On Sun, 2017-07-23 at 22:21 +0800, Icenowy Zheng wrote: > The critical shutdown notice string used to have some spaces missing, > which makes it not so pretty. > > Add the spaces to satisfy usual English space rules. > > Reported-by: Mingcong Bai > Signed-off-by: Icenowy Zheng applied. thanks

Re: [PATCH] thermal: fix INTEL_SOC_DTS_IOSF_CORE dependencies

2017-08-08 Thread Zhang Rui
On Sat, 2017-07-29 at 13:22 -0600, Pandruvada, Srinivas wrote: > On Fri, 2017-07-21 at 18:16 +0200, Arnd Bergmann wrote: > > > > We get a Kconfig warning when selecting this without also enabling > > CONFIG_PCI: > > > > warning: (X86_INTEL_LPSS && INTEL_SOC_DTS_IOSF_CORE && > > SND_SST_IPC_ACPI &

Re: [PATCH 2/3] thermal: core: Reorder 'thermal_zone_device_register()' error handling code

2017-08-08 Thread Zhang Rui
On Sun, 2017-07-16 at 08:59 +0200, Christophe JAILLET wrote: > Reorder code in the error handling path in order to match the way > resources > have been allocated. > > With this new order, we can avoid a call to 'device_unregister()' if > 'thermal_zone_create_device_groups'()' fails. At this point

Re: [PATCH 1/3] thermal: core: Fix a memory leak in 'thermal_zone_device_register()' error handling path

2017-08-08 Thread Zhang Rui
On Sun, 2017-07-16 at 08:59 +0200, Christophe JAILLET wrote: > 'tz' is freed in some error handling paths but not in the main one. > So free it also here to avoid a memory leak. > After device registered, tz is freed in thermal_release(). thanks, rui > Signed-off-by: Christophe JAILLET > --- >  

Re: [PATCH V1] thermal: qcom-spmi-temp-alarm: add support for GEN2 PMIC peripherals

2017-08-08 Thread Zhang Rui
On Thu, 2017-07-13 at 17:39 +0530, Kiran Gunda wrote: > From: David Collins > > Add support for the TEMP_ALARM GEN2 PMIC peripheral subtype.  The > GEN2 subtype defines an over temperature state with hysteresis > instead of stage in the status register.  There are two GEN2 > states corresponding

Re: [PATCH] thermal/drivers/hisi: Remove confusing error message

2017-08-08 Thread Zhang Rui
On Fri, 2017-07-07 at 17:03 +0200, Daniel Lezcano wrote: > The sensor id is unknown at init time and we use all id in the > authorized > MAX_SENSORS interval to register the sensor. On this SoC there is one > thermal-zone with one sensor on it. No need to spit on the console > everytime we > failed

Re: [PATCH v2 3/5] thermal: imx: Add support for reading OCOTP through nvmem

2017-08-08 Thread Zhang Rui
On Tue, 2017-07-25 at 16:08 +0800, Shawn Guo wrote: > On Fri, Jul 14, 2017 at 05:11:08PM +0300, Leonard Crestez wrote: > > > > On newer imx SOCs accessing OCOTP directly is wrong because the > > ocotp clock > > needs to be enabled first. Add support for reading those same > > values through > > th

[GIT PULL] Thermal management updates for v4.13-rc1

2017-07-14 Thread Zhang Rui
ng: don't store cpu_dev in cpufreq_cdev   thermal: cpu_cooling: 'freq' can't be zero in cpufreq_state2power()   thermal: cpu_cooling: Rearrange struct cpufreq_cooling_device   thermal: cpu_cooling: Replace kmalloc with kmalloc_array Willy WOLFF (1):   thermal:

Re: [PATCH v3 1/2] acpi: thermal: initialize tz_enabled to 1

2017-07-03 Thread Zhang Rui
t; > > Signed-off-by: Sameer Nanda > > Signed-off-by: Enric Balletbo i Serra > > > > --- > > Changes since v2: > >  - Zhang Rui: > >    - Make sure tz->tz_enabled is set properly before registering > > the zone. > > > > Changes since v1: > &

Re: [PATCH v2 2/2] thermal: core: Allow to disable polling when disabling thermal zone.

2017-06-30 Thread Zhang Rui
Hi, Enric, On Fri, 2017-06-30 at 10:15 +0200, Enric Balletbo Serra wrote: > Hi Rui, > > 2017-06-30 7:05 GMT+02:00 Zhang Rui : > > > > On Thu, 2017-06-29 at 18:50 +0200, Enric Balletbo i Serra wrote: > > > > > > Under each thermal zone there is a opt

Re: [PATCH v2 2/2] thermal: core: Allow to disable polling when disabling thermal zone.

2017-06-29 Thread Zhang Rui
IMO, we have a couple of things more to do, like the prototype patch attached, which I have not tested yet. >From 8bf51fe65bd386b7e8c3c2ca8b9f7d321c92b22f Mon Sep 17 00:00:00 2001 From: Zhang Rui Date: Fri, 30 Jun 2017 11:11:45 +0800 Subject: [RFC PATCH] Thermal: introduce thermal zone device mode c

Re: [PATCH v2 1/2] acpi: thermal: update thermal_zone after enable the driver.

2017-06-29 Thread Zhang Rui
On Thu, 2017-06-29 at 18:50 +0200, Enric Balletbo i Serra wrote: > Use thermal_set_mode instead of just set the tz_enable variable when > enabling the ACPI thermal driver. The purpose of this change is > trigger > a thermal_zone_device_update when driver switches from disabled to > enabled mode so

Re: [PATCH] thermal/intel_powerclamp: add const to thermal_cooling_device_ops structure

2017-06-29 Thread Zhang Rui
On Thu, 2017-06-29 at 11:26 +0530, Bhumika Goyal wrote: > On Thu, Jun 29, 2017 at 11:02 AM, Zhang Rui > wrote: > > > > On Thu, 2017-06-29 at 10:41 +0530, Bhumika Goyal wrote: > > > > > > On Thu, Jun 29, 2017 at 8:30 AM, Zhang Rui > > > wrote: >

Re: [PATCH] thermal/intel_powerclamp: add const to thermal_cooling_device_ops structure

2017-06-28 Thread Zhang Rui
On Thu, 2017-06-29 at 10:41 +0530, Bhumika Goyal wrote: > On Thu, Jun 29, 2017 at 8:30 AM, Zhang Rui > wrote: > > > > On Wed, 2017-06-21 at 12:39 +0530, Bhumika Goyal wrote: > > > > > > Declare thermal_cooling_device_ops structure as const as it is > >

Re: [PATCH] acpi: thermal: honor "mode" sysfs file setting

2017-06-28 Thread Zhang Rui
On Thu, 2017-06-29 at 00:14 +0200, Rafael J. Wysocki wrote: > On Thursday, June 22, 2017 02:45:42 PM Enric Balletbo i Serra wrote: > > > > From: Sameer Nanda > > > > Under each thermal zone there is a file called "mode". Writing > > enabled > > or disabled to this file allows a given thermal zon

Re: [PATCH] thermal/intel_powerclamp: add const to thermal_cooling_device_ops structure

2017-06-28 Thread Zhang Rui
On Wed, 2017-06-21 at 12:39 +0530, Bhumika Goyal wrote: > Declare thermal_cooling_device_ops structure as const as it is only > passed > as an argument to the function thermal_cooling_device_register and > this > argument is of type const. So, declare the structure as const. > I checked the source

Re: [GIT PULL][RESEND] Thermal SoC management fixes for v4.12-rc3

2017-05-29 Thread Zhang Rui
On Sun, 2017-05-28 at 09:14 -0700, Eduardo Valentin wrote: > Hello Linus, > > I know this is (very) late, but please consider these six fixes for > next rc3. > I tried sending these via Rui, but I think I missed the window to get > him still in office, so I am sending directly to you. yes, I miss

Re: [PATCH] Fixed hwmon_register_device() error regression

2017-05-29 Thread Zhang Rui
Hi, Josh On Sun, 2017-05-28 at 22:38 -0400, Josh Benson wrote: > Signed-off-by: Josh Benson First of all, you're missing a proper changelog here. Second, this patch has already been reverted by commit 3feb479cea37 because the name of some thermal devices contains special characters which is inco

Re: [PATCH V4 03/17] thermal: cpu_cooling: Name cpufreq cooling devices as cpufreq_cdev

2017-05-22 Thread Zhang Rui
On Tue, 2017-04-25 at 15:57 +0530, Viresh Kumar wrote: > Objects of "struct cpufreq_cooling_device" are named a bit > inconsistently. Lets use cpufreq_cdev everywhere. Also note that the > lists containing such devices is renamed similarly too. > > Signed-off-by: Viresh Kumar > Tested-by: Lukasz

Re: [PATCH v2 3/8] thermal: intel_bxt_pmic_thermal: use first level PMIC thermal irq

2017-05-22 Thread Zhang Rui
s patch fixes this issue by adding support to use > first level PMIC thermal irq. > > Signed-off-by: Kuppuswamy Sathyanarayanan > Acked-by: Zhang Rui -rui > --- >  drivers/thermal/intel_bxt_pmic_thermal.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > >

[GIT PULL] Thermal management updates for v4.12-rc1

2017-05-12 Thread Zhang Rui
d thermal zone to bcm2835-thermal example   thermal: bcm2835: add thermal driver for bcm2835 SoC Steve Twiss (2):   Documentation: devicetree: thermal: da9062/61 TJUNC temperature binding   thermal: da9062/61: Thermal junction temperature monitoring driver Zhang Rui (4):   Merge br

Re: [PATCH v1] ACPI: Switch to use generic UUID API

2017-05-09 Thread Zhang Rui
t; Cc: Amir Goldstein > Cc: Jarkko Sakkinen > Cc: Jani Nikula > Cc: Ben Skeggs > Cc: Benjamin Tissoires > Cc: Joerg Roedel > Cc: Adrian Hunter > Cc: Yisen Zhuang > Cc: Bjorn Helgaas > Cc: Zhang Rui > Cc: Felipe Balbi > Cc: Mathias Nyman > Cc: Heikki Kroger

Re: [PATCH] thermal: core: Add a back up thermal shutdown mechanism

2017-04-12 Thread Zhang Rui
On Wed, 2017-04-12 at 14:06 +0530, Keerthy wrote: > > On Wednesday 12 April 2017 01:56 PM, Zhang Rui wrote: > > > > On Wed, 2017-04-12 at 13:25 +0530, Keerthy wrote: > > > > > > > > > On Wednesday 12 April 2017 09:35 AM, Eduardo Vale

Re: [PATCH] thermal: core: Add a back up thermal shutdown mechanism

2017-04-12 Thread Zhang Rui
On Wed, 2017-04-12 at 13:25 +0530, Keerthy wrote: > > On Wednesday 12 April 2017 09:35 AM, Eduardo Valentin wrote: > > > > Keerthy, > > > > On Wed, Apr 12, 2017 at 09:09:36AM +0530, Keerthy wrote: > > > > > > > > > &

Re: [PATCH] thermal: core: Add a back up thermal shutdown mechanism

2017-04-11 Thread Zhang Rui
On Wed, 2017-04-12 at 08:19 +0530, Keerthy wrote: > > On Tuesday 11 April 2017 10:59 PM, Eduardo Valentin wrote: > > > > Hey, > > > > On Fri, Mar 31, 2017 at 12:00:20PM +0530, Keerthy wrote: > > > > > > orderly_poweroff is triggered when a graceful shutdown > > > of system is desired. This may

[GIT PULL] Thermal management updates for v4.11-rc5

2017-03-29 Thread Zhang Rui
Hi, Linus, Please pull from   git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux.git for-rc to receive the latest Thermal Management updates for v4.11-rc5 with top-most commit 3ea3217cf91804be6ed9b368ef4ac7911eb1dadc:   thermal: cpu_cooling: Check OPP for errors (2017-03-13 10:06:55 +080

Re: [PATCH 4.10 012/167] mmc: sdhci-acpi: support deferred probe

2017-03-28 Thread Zhang Rui
On Tue, 2017-03-28 at 13:51 +0800, Zhang Rui wrote: > On Mon, 2017-03-27 at 18:36 +0200, Greg Kroah-Hartman wrote: > > > > On Mon, Mar 27, 2017 at 10:40:23AM +0800, Zhang Rui wrote: > > > > > > > > > On Sun, 2017-03-26 at 12:26 +0100, Andrey Utkin wrote

Re: [PATCH 4.10 012/167] mmc: sdhci-acpi: support deferred probe

2017-03-27 Thread Zhang Rui
On Mon, 2017-03-27 at 18:36 +0200, Greg Kroah-Hartman wrote: > On Mon, Mar 27, 2017 at 10:40:23AM +0800, Zhang Rui wrote: > > > > On Sun, 2017-03-26 at 12:26 +0100, Andrey Utkin wrote: > > > > > > On Fri, Mar 10, 2017 at 10:07:35AM +010

Re: [PATCH 4.10 012/167] mmc: sdhci-acpi: support deferred probe

2017-03-26 Thread Zhang Rui
On Sun, 2017-03-26 at 12:26 +0100, Andrey Utkin wrote: > On Fri, Mar 10, 2017 at 10:07:35AM +0100, Greg Kroah-Hartman wrote: > > > > 4.10-stable review patch.  If anyone has any objections, please let > > me know. > > > > ------ > >

Re: [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess with compilation units

2017-03-26 Thread Zhang Rui
tion for Crystal Cove and > > > split > > > Whiskey Cove out of it. > > > > > > (*) It looks like the configuration was never tested with > > > INTEL_SOC_PMIC=n. The line in Makefile is actually wrong. > > > > > > Cc: "Rafael J. Wys

Re: [PATCH V3 0/5] thermal: minor cleanup/fixes

2017-03-13 Thread Zhang Rui
On Mon, 2017-03-13 at 15:37 +0530, Viresh Kumar wrote: > Hi, > > This series contains minor fixes/cleanups for thermal cooling > drivers. > > V2->V3: > - Added Acks from Rui > - Resending as it was getting ignored until now :( I just applied V2 this morning, and has not pushed to kernel.org yet.

[GIT PULL] Thermal management updates for v4.11-rc1

2017-03-01 Thread Zhang Rui
en3_thermal: Document the R-Car Gen3   thermal: rcar_gen3_thermal: Add R-Car Gen3 thermal driver Zhang Rui (2):   Merge branch 'linus' of git://git.kernel.org/.../evalenti/linux- soc-thermal into thermal-soc   Merge branches 'thermal-core', 'thermal-soc',

Re: [PATCH V2 0/5] thermal: minor cleanup/fixes

2017-02-20 Thread Zhang Rui
On Mon, 2017-02-20 at 15:59 +0530, Viresh Kumar wrote: > On 07-02-17, 09:39, Viresh Kumar wrote: > > > > Hi, > > > > This series contains minor fixes/cleanups for thermal cooling > > drivers. > > Acked-by: Zhang Rui for the whole patch series. As this p

Re: [PATCH] thermal: use cpumask_var_t for on-stack cpu masks

2017-02-10 Thread Zhang Rui
On Thu, 2017-02-02 at 15:46 +0100, Arnd Bergmann wrote: > Putting a bare cpumask structure on the stack produces a warning on > large SMP configurations: > > drivers/thermal/cpu_cooling.c: In function 'cpufreq_state2power': > drivers/thermal/cpu_cooling.c:644:1: warning: the frame size of 1056 > b

Re: [PATCH] Thermal - Fix possible NULL derefrence.

2017-02-06 Thread Zhang Rui
Just one comment, the subject should be  [PATCH] Thermal: imx_thermal : Fix possible NULL derefrence On Mon, 2017-01-30 at 10:34 +0530, Shailendra Verma wrote: > of_device_get_match_data could return NULL, and so can cause > a NULL pointer dereference later. > > Signed-off-by: Shailendra Verma

Re: v4.10-rc4 to v4.10-rc5: battery regression on Nokia N900

2017-01-27 Thread Zhang Rui
On Thu, 2017-01-26 at 22:27 -0800, Guenter Roeck wrote: > On 01/26/2017 07:39 PM, Zhang Rui wrote: > > > > On Thu, 2017-01-26 at 18:03 -0800, Guenter Roeck wrote: > > > > > > On 01/26/2017 05:37 PM, Zhang Rui wrote: > > > > > > > > &g

[GIT PULL] Thermal management updates for v4.10-rc6

2017-01-27 Thread Zhang Rui
Hi, Linus, Please pull from   git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux.git for-rc to receive the latest Thermal Management updates for v4.10-rc6 with top-most commit 3feb479cea37fc623cf4e705631b2e679cbfbd7a:   Revert "thermal: thermal_hwmon: Convert to hwmon_device_register_wit

GIT PULL] Thermal management updates for v4.10-rc6

2017-01-26 Thread Zhang Rui
Hi, Linus, Please pull from   git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux.git for-rc to receive the latest Thermal Management updates for v4.10-rc6 with top-most commit 3feb479cea37fc623cf4e705631b2e679cbfbd7a:   Revert "thermal: thermal_hwmon: Convert to hwmon_device_register_wit

Re: v4.10-rc4 to v4.10-rc5: battery regression on Nokia N900

2017-01-26 Thread Zhang Rui
On Thu, 2017-01-26 at 18:03 -0800, Guenter Roeck wrote: > On 01/26/2017 05:37 PM, Zhang Rui wrote: > > > > On Wed, 2017-01-25 at 13:09 +0100, Pali Rohár wrote: > > > > > > On Wednesday 25 January 2017 12:12:33 Pavel Machek wr

Re: v4.10-rc4 to v4.10-rc5: battery regression on Nokia N900

2017-01-26 Thread Zhang Rui
On Wed, 2017-01-25 at 13:09 +0100, Pali Rohár wrote: > On Wednesday 25 January 2017 12:12:33 Pavel Machek wrote: > > > > Hi! > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Right. > > > > > > > > > > > > > > Before reverting, can you please try if this patch works > > >

Re: v4.10-rc4 to v4.10-rc5: battery regression on Nokia N900

2017-01-24 Thread Zhang Rui
On Tue, 2017-01-24 at 21:07 -0200, Fabio Estevam wrote: > On Tue, Jan 24, 2017 at 8:46 PM, Pavel Machek wrote: > > > > > It is an ugly regression and it is -rc5 time. Actually not your > > problem, but Fabio Estevam or Zhang Rui has to deal with it soon. > I have alr

Re: v4.10-rc4 to v4.10-rc5: battery regression on Nokia N900

2017-01-23 Thread Zhang Rui
.829650] of_get_named_gpiod_flags: parsed 'gpio-reset' property > > of node '/ocp@6800/i2c@48072000/tlv320aic3x@19[0]' - status (0) > > [0.833831] tsl2563 2-0029: model 7, rev. 0 > > [0.837768] of_get_named_gpiod_flags: parsed 'enable-gpio' prop

[GIT PULL] Thermal management updates for v4.10-rc5

2017-01-21 Thread Zhang Rui
  thermal: rockchip: fixes the conversion table Fabio Estevam (1):   thermal: thermal_hwmon: Convert to hwmon_device_register_with_info() Jacob von Chorus (1):   thermal: core: move tz->device.groups cleanup to thermal_release Zhang Rui (2):   Merge branch 'fixes' of g

Re: [PATCH v9 3/3] iio: adc: add support for Allwinner SoCs ADC

2017-01-08 Thread Zhang Rui
Hi, On Sun, 2017-01-08 at 11:17 +, Jonathan Cameron wrote: > On 30/12/16 14:40, Jonathan Cameron wrote: > > > > On 13/12/16 14:33, Quentin Schulz wrote: > > > > > > The Allwinner SoCs all have an ADC that can also act as a > > > touchscreen > > > controller and a thermal sensor. This patch a

Re: [GIT PULL] More ACPI updates for v4.10-rc1

2017-01-04 Thread Zhang Rui
On Wed, 2017-01-04 at 09:46 -0800, Linus Torvalds wrote: > On Thu, Dec 22, 2016 at 6:18 AM, Rafael J. Wysocki > wrote: > > > > > > Please pull from the tag > > > >  git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git > > \ > >  acpi-extra-4.10-rc1 > I only just noticed that this a

Re: [PATCH] thermal: add thermal_zone_remove_device_groups()

2017-01-03 Thread Zhang Rui
On Wed, 2017-01-04 at 12:35 +0800, Zhang Rui wrote: > On Thu, 2016-12-15 at 16:47 -0500, Yasuaki Ishimatsu wrote: > > > > When offlining all cores on a CPU, the following system panic > > occurs: > > > > BUG: unable to handle kernel NULL pointer dereference

Re: [PATCH] thermal: add thermal_zone_remove_device_groups()

2017-01-03 Thread Zhang Rui
fflining all cores on CPU and executing > thermal_zone_device_unregister(), the panic occurs in strlen() > called from kernfs_name_hash() because name argument is NULL. > > The patch adds thermal_zone_remove_device_groups() to free > tz->device.groups and set NULL pointer. >

Re: [RESEND] thermal: hwmon: Properly report critical temperature in sysfs

2016-12-29 Thread Zhang Rui
On Wed, 2016-12-28 at 19:35 +0200, Krzysztof Kozlowski wrote: > In the critical sysfs entry the thermal hwmon was returning wrong > temperature to the user-space.  It was reporting the temperature of > the > first trip point instead of the temperature of critical trip point. > > For example: >

[GIT PULL] Thermal management updates for v4.10-rc1

2016-12-13 Thread Zhang Rui
hermal/x86_pkg_temp: Move work into package struct   thermal/x86_pkg_temp: Sanitize package management Zhang Rui (1):   Merge branches 'thermal-core', 'thermal-intel', 'thermal-soc- fixes' and 'thermal-reorg' into next  ..

[GIT PULL] Thermal management updates for v4.10-rc1

2016-12-12 Thread Zhang Rui
hermal/x86_pkg_temp: Move work into package struct   thermal/x86_pkg_temp: Sanitize package management Zhang Rui (1):   Merge branches 'thermal-core', 'thermal-intel', 'thermal-soc- fixes' and 'thermal-reorg' into next  ..

Re: [PATCH] MAINTAINERS: Samsung: Update maintainer for PWM FAN and SAMSUNG THERMAL

2016-12-12 Thread Zhang Rui
On Mon, 2016-12-12 at 08:33 -0800, Guenter Roeck wrote: > On Mon, Dec 12, 2016 at 04:09:45PM +0100, Lukasz Majewski wrote: > > > > Since I leave Samsung, I would like to step down from maintenance > > duties. > > Bartek Zolnierkiewicz will replace. > > > > Signed-off-by: Lukasz Majewski > For hw

Re: [PATCH] Fix multiple definition error under lto

2016-12-11 Thread Zhang Rui
On Sat, 2016-11-26 at 17:25 -0500, Peter Foley wrote: > drivers/thermal/built-in.o: In function `type_show.lto_priv.33': > (.text+0x3d80): multiple definition of `type_show.lto_priv.33' > drivers/base/built-in.o:(.text+0x2a40): first defined here > can you illustrate how to reproduce this problem?

Re: [patch V2 00/12] thermal/x86_pkg_temp: Sanitize hotplug and locking

2016-11-30 Thread Zhang Rui
On Tue, 2016-11-22 at 12:51 -0700, Pandruvada, Srinivas wrote: > On Tue, 2016-11-22 at 17:57 +, Thomas Gleixner wrote: > > > > Changes vs. V1: Fix the package removal wreckage reported by > > Srinivas > > > I haven't looked at individual patch but tested the series as a > whole.  > > So Rui,

Re: [PATCH 2/3] thermal: rockchip: improve conversion error messages

2016-11-21 Thread Zhang Rui
On Tue, 2016-11-22 at 09:51 +0800, Caesar Wang wrote: > 在 2016年11月19日 11:31, Caesar Wang 写道: > > > > Brian, > > > > 在 2016年11月19日 07:52, Brian Norris 写道: > > > > > > These error messages don't give much information about what went > > > wrong. > > > It would be nice, for one, to see what invalid

Re: [PATCH 1/3] thermal: handle get_temp() errors properly

2016-11-21 Thread Zhang Rui
Hi, Brian, On Fri, 2016-11-18 at 21:30 -0800, Brian Norris wrote: > Hi, > > On Fri, Nov 18, 2016 at 07:41:59PM -0800, Eduardo Valentin wrote: > > > > On Fri, Nov 18, 2016 at 03:52:55PM -0800, Brian Norris wrote: > > > > > > If using CONFIG_THERMAL_EMULATION, there's a corner case where we > > >

Re: [PATCH] thermal/powerclamp: add back module device table

2016-11-21 Thread Zhang Rui
On Mon, 2016-11-21 at 08:13 +0100, Greg Kroah-Hartman wrote: > On Mon, Nov 21, 2016 at 11:43:10AM +0800, Zhang Rui wrote: > > > > On Thu, 2016-11-17 at 11:42 -0800, Jacob Pan wrote: > > > > > > On Tue, 15 Nov 2016 08:03:32 +010

Re: [PATCH] thermal/powerclamp: add back module device table

2016-11-20 Thread Zhang Rui
On Thu, 2016-11-17 at 11:42 -0800, Jacob Pan wrote: > On Tue, 15 Nov 2016 08:03:32 +0100 > Greg Kroah-Hartman wrote: > > > > > On Mon, Nov 14, 2016 at 11:08:45AM -0800, Jacob Pan wrote: > > > > > > Commit 3105f234e0aba43e44e277c20f9b32ee8add43d4 replaced module > > > cpu id table with a cpu fea

Re: [PATCH 2/3] thermal: hisilicon: fix for dependency

2016-11-15 Thread Zhang Rui
On Sat, 2016-11-12 at 20:05 +0800, Leo Yan wrote: > Hi Rui, Eduardo, > > On Wed, Aug 31, 2016 at 04:50:16PM +0800, Leo Yan wrote: > > > > The thermal driver is standalone driver which is used to enable > > thermal sensors, so it can be used with any cooling device and > > should not bind with CPU

Re: [PATCH 3/3] thermal/intel_powerclamp: Convert to CPU hotplug state

2016-11-15 Thread Zhang Rui
On Mon, 2016-11-14 at 11:12 -0800, Jacob Pan wrote: > On Fri, 11 Nov 2016 18:34:10 +0100 > Petr Mladek wrote: > > > > > Please, let me known if I should do this as a separate patch > > and/or resend the patchset. > Rui/Eduardo, > There are four independent posted changes made to powerclamp drive

Re: v4.8-rc1: thinkpad x60: running at low frequency even during kernel build

2016-11-05 Thread Zhang Rui
On Fri, 2016-11-04 at 23:16 +0100, Pavel Machek wrote: > Hi! > > > > > I'd prefer mails over bugzilla for now... > > > > 4.9-rc2 has bios_limit: > > > > pavel@duo:~$ cat /sys/devices/system/cpu/cpu0/cpufreq/bios_limit > > 1833000 > > > > and it has thermal zones: > > > > /sys/devices/virtual/

Re: Regression in intel_powerclamp, due to cpu whitelist removal

2016-10-19 Thread Zhang Rui
On Wed, 2016-10-19 at 20:45 -0700, Jacob Pan wrote: > On Tue, 18 Oct 2016 14:20:49 + > Alok Kataria wrote: > > > > > Hi Jacob, Zhang,  > > > > One of your recent commit "thermal/powerclamp: remove cpu > > whitelist” [1], has caused a regression in the kernel.  > > > > That commit changed p

Re: [PATCH] of: thermal: Fixed governor at each thermal zone

2016-09-27 Thread Zhang Rui
Hi, Javi, Lukasz and Eduardo, thanks for your input. thanks, rui On 二, 2016-09-27 at 06:22 -0700, Eduardo Valentin wrote: > Hello, Lukasz, Inhyuk, Javi, > > On Tue, Sep 27, 2016 at 12:52:04PM +0100, Lukasz Luba wrote: > > > > > > On 27/09/16 02:46, Zhang Rui wrote:

Re: [PATCH] of: thermal: Fixed governor at each thermal zone

2016-09-26 Thread Zhang Rui
On 一, 2016-09-19 at 10:18 +0900, Inhyuk Kang wrote: > It is necessary to be added governor at each thermal_zone. > Because some governors should be operated in the during the kernel > booting > in order to avoid heating problem. > > Default governor cannot be covered all thermal zones policy becau

Re: [PATCH V2 1/7] dt-bindings: Update QorIQ TMU thermal bindings

2016-09-18 Thread Zhang Rui
atting chnages. > > > > > >  Documentation/devicetree/bindings/thermal/qoriq-thermal.txt | 7 > > > +++ > > >  1 file changed, 7 insertions(+) > > Acked-by: Rob Herring > Hi Zhang Rui, > > Since you have applied the driver patch, can you also a

[GIT PULL] Thermal management updates for v4.8-rc6

2016-09-07 Thread Zhang Rui
Hi, Linus, Please pull from   git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux.git for-rc to receive the latest Thermal Management updates for v4.8-rc6 with top-most commit 87260d3f7aecba9a5fadc6886c338b2a8fccfca9:   thermal: rcar_thermal: Fix priv->zone error handling (2016-09-06 20:4

Re: [Thermal] Need confirmation for the pending thermal soc patches

2016-09-06 Thread Zhang Rui
On 二, 2016-09-06 at 12:13 +0200, Geert Uytterhoeven wrote: > Hi Eduardo, > > On Mon, Sep 5, 2016 at 3:16 PM, Eduardo Valentin > wrote: > > > > On Sun, Aug 21, 2016 at 10:09:00PM +0800, Zhang Rui wrote: > > > > > > As Eduardo is quite busy recen

Re: [PATCH 2/5 v2] thermal: rcar_gen3_thermal: Add R-Car Gen3 thermal driver

2016-09-05 Thread Zhang Rui
On 六, 2016-09-03 at 05:25 +, Khiem Nguyen wrote: > Signed-off-by: Hien Dang > Signed-off-by: Thao Nguyen > Signed-off-by: Khiem Nguyen Well, I can only see patch 4/5, 5/5 in patchwork but I can not see this one thanks, rui > --- > > v2: >  * Set static function for _linear_temp_conver

Re: [PATCH] thermal: armada: add support for suspend/resume

2016-09-05 Thread Zhang Rui
On 五, 2016-08-19 at 21:06 +0800, Zhang Rui wrote: > On 四, 2016-07-21 at 12:43 +0200, Grzegorz Jaszczyk wrote: > > > > There is no need to implement subroutine for suspend since there is > > no > > data to store before suspending. > > > > Signed-off-by: Grze

Re: [PATCH v2 3/3] arm: dts: thermal: add thermal/auxadc node.

2016-09-05 Thread Zhang Rui
On 二, 2016-09-06 at 08:24 +0800, Zhang Rui wrote: > On 四, 2016-08-18 at 11:50 +0800, Dawei Chien wrote: > > > > This adds the thermal controller and auxadc nodes > > to the Mediatek MT2701 dtsi file. > > > > Signed-off-by: Dawei Chien > >

Re: [PATCH v2 3/3] arm: dts: thermal: add thermal/auxadc node.

2016-09-05 Thread Zhang Rui
On 四, 2016-08-18 at 11:50 +0800, Dawei Chien wrote: > This adds the thermal controller and auxadc nodes > to the Mediatek MT2701 dtsi file. > > Signed-off-by: Dawei Chien > --- > This patch depned on: > https://patchwork.kernel.org/patch/9249589/ > https://patchwork.kernel.org/patch/9249589/ Hmm

Re: [PATCH] ACPI / button: add support for tablet mode switch

2016-08-31 Thread Zhang Rui
On 三, 2016-08-31 at 15:33 +0800, Wei-Ning Huang wrote: > From: Wei-Ning Huang > > ACPI PNP device HID 'PNP0C60' is a device that indicates tablet mode > status. Add support for mapping this device to the SW_TABLET_MODE > input > event. > > Signed-off-by: Wei-Ning Huang > --- >  drivers/acpi/but

Re: [PATCH] thermal: hisilicon: fix COMPILE_TEST dependencies

2016-08-28 Thread Zhang Rui
On 五, 2016-08-26 at 17:44 +0200, Arnd Bergmann wrote: > As we now 'select STUB_CLK_HI6220', all dependencies for that driver > have > to be present in order to enable HISI_THERMAL, as pointed out by > Kconfig: > > warning: (HISI_THERMAL) selects STUB_CLK_HI6220 which has unmet > direct dependencie

[GIT PULL] Thermal management updates for v4.8-rc4

2016-08-25 Thread Zhang Rui
Hi, Linus, Please pull from   git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux.git for-rc to receive the latest Thermal Management updates for v4.8-rc4 with top-most commit 829bc78aa7628e81a9de717316b85cbee3c5eb86:   thermal: imx: fix a possible NULL dereference (2016-08-19 21:34:08 +0

<    1   2   3   4   5   6   7   8   9   >