Re: [PATCH 1/3 v2] thermal: core: Add some new helper functions to free resources

2017-08-10 Thread Zhang Rui
On Fri, 2017-08-11 at 11:23 +0800, Zhang Rui wrote: > On Tue, 2017-08-08 at 16:39 +0200, Christophe JAILLET wrote: > > > > In order to easily free resources allocated by > > 'thermal_zone_create_device_groups()' we need 2 new helper > > functions. &g

Re: [PATCH 1/3 v2] thermal: core: Add some new helper functions to free resources

2017-08-10 Thread Zhang Rui
On Tue, 2017-08-08 at 16:39 +0200, Christophe JAILLET wrote: > In order to easily free resources allocated by > 'thermal_zone_create_device_groups()' we need 2 new helper functions. > > The first one undoes 'thermal_zone_create_device_groups()'. > The 2nd one undoes 'create_trip_attrs()', which

Re: [PATCH 1/3 v2] thermal: core: Add some new helper functions to free resources

2017-08-10 Thread Zhang Rui
On Tue, 2017-08-08 at 16:39 +0200, Christophe JAILLET wrote: > In order to easily free resources allocated by > 'thermal_zone_create_device_groups()' we need 2 new helper functions. > > The first one undoes 'thermal_zone_create_device_groups()'. > The 2nd one undoes 'create_trip_attrs()', which

Re: [PATCH] thermal/drivers/hisi: Remove confusing error message

2017-08-10 Thread Zhang Rui
On Tue, 2017-08-08 at 21:29 +0800, Leo Yan wrote: > On Tue, Aug 08, 2017 at 08:48:51PM +0800, Zhang Rui wrote: > > [...] > > > > > > > > > > > > > > > > > > > > @@ -352,10 +353,9 @@ static int hisi_thermal_prob

Re: [PATCH] thermal/drivers/hisi: Remove confusing error message

2017-08-10 Thread Zhang Rui
On Tue, 2017-08-08 at 21:29 +0800, Leo Yan wrote: > On Tue, Aug 08, 2017 at 08:48:51PM +0800, Zhang Rui wrote: > > [...] > > > > > > > > > > > > > > > > > > > > @@ -352,10 +353,9 @@ static int hisi_thermal_prob

Re: [PATCH] thermal: rockchip: fix error return code in rockchip_thermal_probe()

2017-08-10 Thread Zhang Rui
On Mon, 2017-08-07 at 23:35 -0500, Gustavo A. R. Silva wrote: > platform_get_irq() returns an error code, but the rockchip_thermal > driver > ignores it and always returns -EINVAL. This is not correct and, > prevents > -EPROBE_DEFER from being propagated properly. > > Notice that

Re: [PATCH] thermal: rockchip: fix error return code in rockchip_thermal_probe()

2017-08-10 Thread Zhang Rui
On Mon, 2017-08-07 at 23:35 -0500, Gustavo A. R. Silva wrote: > platform_get_irq() returns an error code, but the rockchip_thermal > driver > ignores it and always returns -EINVAL. This is not correct and, > prevents > -EPROBE_DEFER from being propagated properly. > > Notice that

Re: [PATCH 2/5] thermal: rockchip: Support the RK3328 SOC in thermal driver

2017-08-10 Thread Zhang Rui
On Tue, 2017-07-25 at 17:09 +0800, Rocky Hao wrote: > RK3328 SOC has one Temperature Sensor for CPU. > > Change-Id: I176c76bae1801d815a513986cfefcb55272c69a8 > Signed-off-by: Rocky Hao Caesar, what do you think of this patch? thanks, rui > --- >  

Re: [PATCH 2/5] thermal: rockchip: Support the RK3328 SOC in thermal driver

2017-08-10 Thread Zhang Rui
On Tue, 2017-07-25 at 17:09 +0800, Rocky Hao wrote: > RK3328 SOC has one Temperature Sensor for CPU. > > Change-Id: I176c76bae1801d815a513986cfefcb55272c69a8 > Signed-off-by: Rocky Hao Caesar, what do you think of this patch? thanks, rui > --- >  drivers/thermal/rockchip_thermal.c | 65 >

Re: [PATCH v2 5/5] thermal: Add Tegra BPMP thermal sensor driver

2017-08-10 Thread Zhang Rui
On Mon, 2017-07-24 at 19:29 +0300, Mikko Perttunen wrote: > On Tegra186, the BPMP (Boot and Power Management Processor) exposes > an > interface to thermal sensors on the system-on-chip. This driver > implements access to the interface. It supports reading the > temperature, setting trip points

Re: [PATCH v2 5/5] thermal: Add Tegra BPMP thermal sensor driver

2017-08-10 Thread Zhang Rui
On Mon, 2017-07-24 at 19:29 +0300, Mikko Perttunen wrote: > On Tegra186, the BPMP (Boot and Power Management Processor) exposes > an > interface to thermal sensors on the system-on-chip. This driver > implements access to the interface. It supports reading the > temperature, setting trip points

Re: [PATCH 0/4] constify thermal_zone_of_device_ops structures

2017-08-08 Thread Zhang Rui
On Sat, 2017-08-05 at 22:37 +0200, Julia Lawall wrote: > The thermal_zone_of_device_ops structures are only passed as the > fourth > argument to thermal_zone_of_sensor_register, which is declared as > const. > Thus the thermal_zone_of_device_ops structures themselves can be > const. > > Done with

Re: [PATCH 0/4] constify thermal_zone_of_device_ops structures

2017-08-08 Thread Zhang Rui
On Sat, 2017-08-05 at 22:37 +0200, Julia Lawall wrote: > The thermal_zone_of_device_ops structures are only passed as the > fourth > argument to thermal_zone_of_sensor_register, which is declared as > const. > Thus the thermal_zone_of_device_ops structures themselves can be > const. > > Done with

Re: [PATCH v6 2/2] thermal: uniphier: add UniPhier thermal driver

2017-08-08 Thread Zhang Rui
On Tue, 2017-08-01 at 17:04 +0900, Kunihiko Hayashi wrote: > Add a thermal driver for on-chip PVT (Process, Voltage and > Temperature) > monitoring unit implemented on UniPhier SoCs. This driver supports > temperature monitoring and alert function. > > Signed-off-by: Kunihiko Hayashi

Re: [PATCH v6 2/2] thermal: uniphier: add UniPhier thermal driver

2017-08-08 Thread Zhang Rui
On Tue, 2017-08-01 at 17:04 +0900, Kunihiko Hayashi wrote: > Add a thermal driver for on-chip PVT (Process, Voltage and > Temperature) > monitoring unit implemented on UniPhier SoCs. This driver supports > temperature monitoring and alert function. > > Signed-off-by: Kunihiko Hayashi > --- >  

Re: [PATCH 2/3] thermal: core: Reorder 'thermal_zone_device_register()' error handling code

2017-08-08 Thread Zhang Rui
On Tue, 2017-08-08 at 14:31 +0200, Christophe JAILLET wrote: > Le 08/08/2017 à 10:49, Zhang Rui a écrit : > > > > On Sun, 2017-07-16 at 08:59 +0200, Christophe JAILLET wrote: > > > > > > Reorder code in the error handling path in order to match the way > >

Re: [PATCH 2/3] thermal: core: Reorder 'thermal_zone_device_register()' error handling code

2017-08-08 Thread Zhang Rui
On Tue, 2017-08-08 at 14:31 +0200, Christophe JAILLET wrote: > Le 08/08/2017 à 10:49, Zhang Rui a écrit : > > > > On Sun, 2017-07-16 at 08:59 +0200, Christophe JAILLET wrote: > > > > > > Reorder code in the error handling path in order to match the way > >

Re: [PATCH v2 3/5] thermal: imx: Add support for reading OCOTP through nvmem

2017-08-08 Thread Zhang Rui
On Tue, 2017-08-08 at 12:44 +0100, Srinivas Kandagatla wrote: > > > > On 08/08/17 12:38, Leonard Crestez wrote: > > > > On Tue, 2017-08-08 at 12:00 +0100, Srinivas Kandagatla wrote: > > > > > > On 08/08/17 08:21, Zhang Rui wrote: > > > >

Re: [PATCH v2 3/5] thermal: imx: Add support for reading OCOTP through nvmem

2017-08-08 Thread Zhang Rui
On Tue, 2017-08-08 at 12:44 +0100, Srinivas Kandagatla wrote: > > > > On 08/08/17 12:38, Leonard Crestez wrote: > > > > On Tue, 2017-08-08 at 12:00 +0100, Srinivas Kandagatla wrote: > > > > > > On 08/08/17 08:21, Zhang Rui wrote: > > > >

Re: [PATCH] thermal/drivers/hisi: Remove confusing error message

2017-08-08 Thread Zhang Rui
On Tue, 2017-08-08 at 12:15 +0200, Daniel Lezcano wrote: > On 08/08/2017 09:55, Zhang Rui wrote: > > > > On Fri, 2017-07-07 at 17:03 +0200, Daniel Lezcano wrote: > > > > > > The sensor id is unknown at init time and we use all id in the > > > authori

Re: [PATCH] thermal/drivers/hisi: Remove confusing error message

2017-08-08 Thread Zhang Rui
On Tue, 2017-08-08 at 12:15 +0200, Daniel Lezcano wrote: > On 08/08/2017 09:55, Zhang Rui wrote: > > > > On Fri, 2017-07-07 at 17:03 +0200, Daniel Lezcano wrote: > > > > > > The sensor id is unknown at init time and we use all id in the > > > authori

Re: [PATCH v3 1/4] Documentation: devicetree: add binding for Broadcom STB AVS TMON

2017-08-08 Thread Zhang Rui
On Mon, 2017-07-31 at 12:26 -0700, Markus Mayer wrote: > From: Brian Norris > > Add binding for Broadcom STB thermal. > > Signed-off-by: Brian Norris > Signed-off-by: Markus Mayer $ file

Re: [PATCH v3 1/4] Documentation: devicetree: add binding for Broadcom STB AVS TMON

2017-08-08 Thread Zhang Rui
On Mon, 2017-07-31 at 12:26 -0700, Markus Mayer wrote: > From: Brian Norris > > Add binding for Broadcom STB thermal. > > Signed-off-by: Brian Norris > Signed-off-by: Markus Mayer $ file v3-1-4-Documentation-devicetree-add-binding-for-Broadcom-STB- AVS-TMON.patch  unified diff output, UTF-8

Re: [PATCH v3 0/4] thermal: add brcmstb AVS TMON driver

2017-08-08 Thread Zhang Rui
On Mon, 2017-08-07 at 10:52 -0700, Florian Fainelli wrote: > On 07/31/2017 12:26 PM, Markus Mayer wrote: > > > > From: Markus Mayer > > > > This series adds the brcmstb AVS TMON driver. > > > > The driver was originally written by Brian Norris. > > > > v1 of this series

Re: [PATCH v3 0/4] thermal: add brcmstb AVS TMON driver

2017-08-08 Thread Zhang Rui
On Mon, 2017-08-07 at 10:52 -0700, Florian Fainelli wrote: > On 07/31/2017 12:26 PM, Markus Mayer wrote: > > > > From: Markus Mayer > > > > This series adds the brcmstb AVS TMON driver. > > > > The driver was originally written by Brian Norris. > > > > v1 of this series can be found at

Re: [PATCH] thermal: core: fix some format issues on critical shutdown string

2017-08-08 Thread Zhang Rui
On Sun, 2017-07-23 at 22:21 +0800, Icenowy Zheng wrote: > The critical shutdown notice string used to have some spaces missing, > which makes it not so pretty. > > Add the spaces to satisfy usual English space rules. > > Reported-by: Mingcong Bai > Signed-off-by: Icenowy Zheng

Re: [PATCH] thermal: core: fix some format issues on critical shutdown string

2017-08-08 Thread Zhang Rui
On Sun, 2017-07-23 at 22:21 +0800, Icenowy Zheng wrote: > The critical shutdown notice string used to have some spaces missing, > which makes it not so pretty. > > Add the spaces to satisfy usual English space rules. > > Reported-by: Mingcong Bai > Signed-off-by: Icenowy Zheng applied.

Re: [PATCH] thermal: fix INTEL_SOC_DTS_IOSF_CORE dependencies

2017-08-08 Thread Zhang Rui
On Sat, 2017-07-29 at 13:22 -0600, Pandruvada, Srinivas wrote: > On Fri, 2017-07-21 at 18:16 +0200, Arnd Bergmann wrote: > > > > We get a Kconfig warning when selecting this without also enabling > > CONFIG_PCI: > > > > warning: (X86_INTEL_LPSS && INTEL_SOC_DTS_IOSF_CORE && > > SND_SST_IPC_ACPI

Re: [PATCH] thermal: fix INTEL_SOC_DTS_IOSF_CORE dependencies

2017-08-08 Thread Zhang Rui
On Sat, 2017-07-29 at 13:22 -0600, Pandruvada, Srinivas wrote: > On Fri, 2017-07-21 at 18:16 +0200, Arnd Bergmann wrote: > > > > We get a Kconfig warning when selecting this without also enabling > > CONFIG_PCI: > > > > warning: (X86_INTEL_LPSS && INTEL_SOC_DTS_IOSF_CORE && > > SND_SST_IPC_ACPI

Re: [PATCH 2/3] thermal: core: Reorder 'thermal_zone_device_register()' error handling code

2017-08-08 Thread Zhang Rui
On Sun, 2017-07-16 at 08:59 +0200, Christophe JAILLET wrote: > Reorder code in the error handling path in order to match the way > resources > have been allocated. > > With this new order, we can avoid a call to 'device_unregister()' if > 'thermal_zone_create_device_groups'()' fails. At this

Re: [PATCH 2/3] thermal: core: Reorder 'thermal_zone_device_register()' error handling code

2017-08-08 Thread Zhang Rui
On Sun, 2017-07-16 at 08:59 +0200, Christophe JAILLET wrote: > Reorder code in the error handling path in order to match the way > resources > have been allocated. > > With this new order, we can avoid a call to 'device_unregister()' if > 'thermal_zone_create_device_groups'()' fails. At this

Re: [PATCH 1/3] thermal: core: Fix a memory leak in 'thermal_zone_device_register()' error handling path

2017-08-08 Thread Zhang Rui
On Sun, 2017-07-16 at 08:59 +0200, Christophe JAILLET wrote: > 'tz' is freed in some error handling paths but not in the main one. > So free it also here to avoid a memory leak. > After device registered, tz is freed in thermal_release(). thanks, rui > Signed-off-by: Christophe JAILLET

Re: [PATCH 1/3] thermal: core: Fix a memory leak in 'thermal_zone_device_register()' error handling path

2017-08-08 Thread Zhang Rui
On Sun, 2017-07-16 at 08:59 +0200, Christophe JAILLET wrote: > 'tz' is freed in some error handling paths but not in the main one. > So free it also here to avoid a memory leak. > After device registered, tz is freed in thermal_release(). thanks, rui > Signed-off-by: Christophe JAILLET > --- >  

Re: [PATCH V1] thermal: qcom-spmi-temp-alarm: add support for GEN2 PMIC peripherals

2017-08-08 Thread Zhang Rui
On Thu, 2017-07-13 at 17:39 +0530, Kiran Gunda wrote: > From: David Collins > > Add support for the TEMP_ALARM GEN2 PMIC peripheral subtype.  The > GEN2 subtype defines an over temperature state with hysteresis > instead of stage in the status register.  There are two

Re: [PATCH V1] thermal: qcom-spmi-temp-alarm: add support for GEN2 PMIC peripherals

2017-08-08 Thread Zhang Rui
On Thu, 2017-07-13 at 17:39 +0530, Kiran Gunda wrote: > From: David Collins > > Add support for the TEMP_ALARM GEN2 PMIC peripheral subtype.  The > GEN2 subtype defines an over temperature state with hysteresis > instead of stage in the status register.  There are two GEN2 > states corresponding

Re: [PATCH] thermal/drivers/hisi: Remove confusing error message

2017-08-08 Thread Zhang Rui
On Fri, 2017-07-07 at 17:03 +0200, Daniel Lezcano wrote: > The sensor id is unknown at init time and we use all id in the > authorized > MAX_SENSORS interval to register the sensor. On this SoC there is one > thermal-zone with one sensor on it. No need to spit on the console > everytime we >

Re: [PATCH] thermal/drivers/hisi: Remove confusing error message

2017-08-08 Thread Zhang Rui
On Fri, 2017-07-07 at 17:03 +0200, Daniel Lezcano wrote: > The sensor id is unknown at init time and we use all id in the > authorized > MAX_SENSORS interval to register the sensor. On this SoC there is one > thermal-zone with one sensor on it. No need to spit on the console > everytime we >

Re: [PATCH v2 3/5] thermal: imx: Add support for reading OCOTP through nvmem

2017-08-08 Thread Zhang Rui
On Tue, 2017-07-25 at 16:08 +0800, Shawn Guo wrote: > On Fri, Jul 14, 2017 at 05:11:08PM +0300, Leonard Crestez wrote: > > > > On newer imx SOCs accessing OCOTP directly is wrong because the > > ocotp clock > > needs to be enabled first. Add support for reading those same > > values through > >

Re: [PATCH v2 3/5] thermal: imx: Add support for reading OCOTP through nvmem

2017-08-08 Thread Zhang Rui
On Tue, 2017-07-25 at 16:08 +0800, Shawn Guo wrote: > On Fri, Jul 14, 2017 at 05:11:08PM +0300, Leonard Crestez wrote: > > > > On newer imx SOCs accessing OCOTP directly is wrong because the > > ocotp clock > > needs to be enabled first. Add support for reading those same > > values through > >

[GIT PULL] Thermal management updates for v4.13-rc1

2017-07-14 Thread Zhang Rui
mal: cpu_cooling: 'freq' can't be zero in cpufreq_state2power()   thermal: cpu_cooling: Rearrange struct cpufreq_cooling_device   thermal: cpu_cooling: Replace kmalloc with kmalloc_array Willy WOLFF (1):   thermal: fix source code documentation for parameters Zhang Rui (2):   Me

[GIT PULL] Thermal management updates for v4.13-rc1

2017-07-14 Thread Zhang Rui
mal: cpu_cooling: 'freq' can't be zero in cpufreq_state2power()   thermal: cpu_cooling: Rearrange struct cpufreq_cooling_device   thermal: cpu_cooling: Replace kmalloc with kmalloc_array Willy WOLFF (1):   thermal: fix source code documentation for parameters Zhang Rui (2):   Me

Re: [PATCH v3 1/2] acpi: thermal: initialize tz_enabled to 1

2017-07-03 Thread Zhang Rui
enabled to 1 into acpi_thermal_add itself. > > > > Signed-off-by: Sameer Nanda <sna...@chromium.org> > > Signed-off-by: Enric Balletbo i Serra <enric.balle...@collabora.com > > > > > --- > > Changes since v2: > >  - Zhang Rui: > &g

Re: [PATCH v3 1/2] acpi: thermal: initialize tz_enabled to 1

2017-07-03 Thread Zhang Rui
t; > > Signed-off-by: Sameer Nanda > > Signed-off-by: Enric Balletbo i Serra > > > > --- > > Changes since v2: > >  - Zhang Rui: > >    - Make sure tz->tz_enabled is set properly before registering > > the zone. > > > > Changes since v1: > &

Re: [PATCH v2 2/2] thermal: core: Allow to disable polling when disabling thermal zone.

2017-06-30 Thread Zhang Rui
Hi, Enric, On Fri, 2017-06-30 at 10:15 +0200, Enric Balletbo Serra wrote: > Hi Rui, > > 2017-06-30 7:05 GMT+02:00 Zhang Rui <rui.zh...@intel.com>: > > > > On Thu, 2017-06-29 at 18:50 +0200, Enric Balletbo i Serra wrote: > > > > > > Under each therm

Re: [PATCH v2 2/2] thermal: core: Allow to disable polling when disabling thermal zone.

2017-06-30 Thread Zhang Rui
Hi, Enric, On Fri, 2017-06-30 at 10:15 +0200, Enric Balletbo Serra wrote: > Hi Rui, > > 2017-06-30 7:05 GMT+02:00 Zhang Rui : > > > > On Thu, 2017-06-29 at 18:50 +0200, Enric Balletbo i Serra wrote: > > > > > > Under each thermal zone there is a opt

Re: [PATCH v2 2/2] thermal: core: Allow to disable polling when disabling thermal zone.

2017-06-29 Thread Zhang Rui
n thermal core as well. Thus, IMO, we have a couple of things more to do, like the prototype patch attached, which I have not tested yet. >From 8bf51fe65bd386b7e8c3c2ca8b9f7d321c92b22f Mon Sep 17 00:00:00 2001 From: Zhang Rui <rui.zh...@intel.com> Date: Fri, 30 Jun 2017 11:11:45 +0800 Subject

Re: [PATCH v2 2/2] thermal: core: Allow to disable polling when disabling thermal zone.

2017-06-29 Thread Zhang Rui
we have a couple of things more to do, like the prototype patch attached, which I have not tested yet. >From 8bf51fe65bd386b7e8c3c2ca8b9f7d321c92b22f Mon Sep 17 00:00:00 2001 From: Zhang Rui Date: Fri, 30 Jun 2017 11:11:45 +0800 Subject: [RFC PATCH] Thermal: introduce thermal zone device mode contro

Re: [PATCH v2 1/2] acpi: thermal: update thermal_zone after enable the driver.

2017-06-29 Thread Zhang Rui
On Thu, 2017-06-29 at 18:50 +0200, Enric Balletbo i Serra wrote: > Use thermal_set_mode instead of just set the tz_enable variable when > enabling the ACPI thermal driver. The purpose of this change is > trigger > a thermal_zone_device_update when driver switches from disabled to > enabled mode so

Re: [PATCH v2 1/2] acpi: thermal: update thermal_zone after enable the driver.

2017-06-29 Thread Zhang Rui
On Thu, 2017-06-29 at 18:50 +0200, Enric Balletbo i Serra wrote: > Use thermal_set_mode instead of just set the tz_enable variable when > enabling the ACPI thermal driver. The purpose of this change is > trigger > a thermal_zone_device_update when driver switches from disabled to > enabled mode so

Re: [PATCH] thermal/intel_powerclamp: add const to thermal_cooling_device_ops structure

2017-06-29 Thread Zhang Rui
On Thu, 2017-06-29 at 11:26 +0530, Bhumika Goyal wrote: > On Thu, Jun 29, 2017 at 11:02 AM, Zhang Rui <rui.zh...@intel.com> > wrote: > > > > On Thu, 2017-06-29 at 10:41 +0530, Bhumika Goyal wrote: > > > > > > On Thu, Jun 29, 2017 at 8:30 AM, Z

Re: [PATCH] thermal/intel_powerclamp: add const to thermal_cooling_device_ops structure

2017-06-29 Thread Zhang Rui
On Thu, 2017-06-29 at 11:26 +0530, Bhumika Goyal wrote: > On Thu, Jun 29, 2017 at 11:02 AM, Zhang Rui > wrote: > > > > On Thu, 2017-06-29 at 10:41 +0530, Bhumika Goyal wrote: > > > > > > On Thu, Jun 29, 2017 at 8:30 AM, Zhang Rui > > > wrote: >

Re: [PATCH] thermal/intel_powerclamp: add const to thermal_cooling_device_ops structure

2017-06-28 Thread Zhang Rui
On Thu, 2017-06-29 at 10:41 +0530, Bhumika Goyal wrote: > On Thu, Jun 29, 2017 at 8:30 AM, Zhang Rui <rui.zh...@intel.com> > wrote: > > > > On Wed, 2017-06-21 at 12:39 +0530, Bhumika Goyal wrote: > > > > > > Declare thermal_cooling_device_ops structure

Re: [PATCH] thermal/intel_powerclamp: add const to thermal_cooling_device_ops structure

2017-06-28 Thread Zhang Rui
On Thu, 2017-06-29 at 10:41 +0530, Bhumika Goyal wrote: > On Thu, Jun 29, 2017 at 8:30 AM, Zhang Rui > wrote: > > > > On Wed, 2017-06-21 at 12:39 +0530, Bhumika Goyal wrote: > > > > > > Declare thermal_cooling_device_ops structure as const as it is > >

Re: [PATCH] acpi: thermal: honor "mode" sysfs file setting

2017-06-28 Thread Zhang Rui
On Thu, 2017-06-29 at 00:14 +0200, Rafael J. Wysocki wrote: > On Thursday, June 22, 2017 02:45:42 PM Enric Balletbo i Serra wrote: > > > > From: Sameer Nanda > > > > Under each thermal zone there is a file called "mode". Writing > > enabled > > or disabled to this file

Re: [PATCH] acpi: thermal: honor "mode" sysfs file setting

2017-06-28 Thread Zhang Rui
On Thu, 2017-06-29 at 00:14 +0200, Rafael J. Wysocki wrote: > On Thursday, June 22, 2017 02:45:42 PM Enric Balletbo i Serra wrote: > > > > From: Sameer Nanda > > > > Under each thermal zone there is a file called "mode". Writing > > enabled > > or disabled to this file allows a given thermal

Re: [PATCH] thermal/intel_powerclamp: add const to thermal_cooling_device_ops structure

2017-06-28 Thread Zhang Rui
On Wed, 2017-06-21 at 12:39 +0530, Bhumika Goyal wrote: > Declare thermal_cooling_device_ops structure as const as it is only > passed > as an argument to the function thermal_cooling_device_register and > this > argument is of type const. So, declare the structure as const. > I checked the

Re: [PATCH] thermal/intel_powerclamp: add const to thermal_cooling_device_ops structure

2017-06-28 Thread Zhang Rui
On Wed, 2017-06-21 at 12:39 +0530, Bhumika Goyal wrote: > Declare thermal_cooling_device_ops structure as const as it is only > passed > as an argument to the function thermal_cooling_device_register and > this > argument is of type const. So, declare the structure as const. > I checked the

Re: [GIT PULL][RESEND] Thermal SoC management fixes for v4.12-rc3

2017-05-29 Thread Zhang Rui
On Sun, 2017-05-28 at 09:14 -0700, Eduardo Valentin wrote: > Hello Linus, > > I know this is (very) late, but please consider these six fixes for > next rc3. > I tried sending these via Rui, but I think I missed the window to get > him still in office, so I am sending directly to you. yes, I

Re: [GIT PULL][RESEND] Thermal SoC management fixes for v4.12-rc3

2017-05-29 Thread Zhang Rui
On Sun, 2017-05-28 at 09:14 -0700, Eduardo Valentin wrote: > Hello Linus, > > I know this is (very) late, but please consider these six fixes for > next rc3. > I tried sending these via Rui, but I think I missed the window to get > him still in office, so I am sending directly to you. yes, I

Re: [PATCH] Fixed hwmon_register_device() error regression

2017-05-29 Thread Zhang Rui
Hi, Josh On Sun, 2017-05-28 at 22:38 -0400, Josh Benson wrote: > Signed-off-by: Josh Benson First of all, you're missing a proper changelog here. Second, this patch has already been reverted by commit 3feb479cea37 because the name of some thermal devices contains special

Re: [PATCH] Fixed hwmon_register_device() error regression

2017-05-29 Thread Zhang Rui
Hi, Josh On Sun, 2017-05-28 at 22:38 -0400, Josh Benson wrote: > Signed-off-by: Josh Benson First of all, you're missing a proper changelog here. Second, this patch has already been reverted by commit 3feb479cea37 because the name of some thermal devices contains special characters which is

Re: [PATCH V4 03/17] thermal: cpu_cooling: Name cpufreq cooling devices as cpufreq_cdev

2017-05-23 Thread Zhang Rui
On Tue, 2017-04-25 at 15:57 +0530, Viresh Kumar wrote: > Objects of "struct cpufreq_cooling_device" are named a bit > inconsistently. Lets use cpufreq_cdev everywhere. Also note that the > lists containing such devices is renamed similarly too. > > Signed-off-by: Viresh Kumar

Re: [PATCH V4 03/17] thermal: cpu_cooling: Name cpufreq cooling devices as cpufreq_cdev

2017-05-23 Thread Zhang Rui
On Tue, 2017-04-25 at 15:57 +0530, Viresh Kumar wrote: > Objects of "struct cpufreq_cooling_device" are named a bit > inconsistently. Lets use cpufreq_cdev everywhere. Also note that the > lists containing such devices is renamed similarly too. > > Signed-off-by: Viresh Kumar > Tested-by: Lukasz

Re: [PATCH v2 3/8] thermal: intel_bxt_pmic_thermal: use first level PMIC thermal irq

2017-05-23 Thread Zhang Rui
irqs from the second level irq > chip, So this patch fixes this issue by adding support to use > first level PMIC thermal irq. > > Signed-off-by: Kuppuswamy Sathyanarayanan > <sathyanarayanan.kuppusw...@linux.intel.com> Acked-by: Zhang Rui <rui.zh...@intel.com> -rui >

Re: [PATCH v2 3/8] thermal: intel_bxt_pmic_thermal: use first level PMIC thermal irq

2017-05-23 Thread Zhang Rui
o this patch fixes this issue by adding support to use > first level PMIC thermal irq. > > Signed-off-by: Kuppuswamy Sathyanarayanan > Acked-by: Zhang Rui -rui > --- >  drivers/thermal/intel_bxt_pmic_thermal.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > >

[GIT PULL] Thermal management updates for v4.12-rc1

2017-05-12 Thread Zhang Rui
-thermal example   thermal: bcm2835: add thermal driver for bcm2835 SoC Steve Twiss (2):   Documentation: devicetree: thermal: da9062/61 TJUNC temperature binding   thermal: da9062/61: Thermal junction temperature monitoring driver Zhang Rui (4):   Merge branches 'thermal-core

[GIT PULL] Thermal management updates for v4.12-rc1

2017-05-12 Thread Zhang Rui
-thermal example   thermal: bcm2835: add thermal driver for bcm2835 SoC Steve Twiss (2):   Documentation: devicetree: thermal: da9062/61 TJUNC temperature binding   thermal: da9062/61: Thermal junction temperature monitoring driver Zhang Rui (4):   Merge branches 'thermal-core

Re: [PATCH v1] ACPI: Switch to use generic UUID API

2017-05-09 Thread Zhang Rui
gs <bske...@redhat.com> > Cc: Benjamin Tissoires <benjamin.tissoi...@redhat.com> > Cc: Joerg Roedel <j...@8bytes.org> > Cc: Adrian Hunter <adrian.hun...@intel.com> > Cc: Yisen Zhuang <yisen.zhu...@huawei.com> > Cc: Bjorn Helgaas <bhelg...@googl

Re: [PATCH v1] ACPI: Switch to use generic UUID API

2017-05-09 Thread Zhang Rui
: Amir Goldstein > Cc: Jarkko Sakkinen > Cc: Jani Nikula > Cc: Ben Skeggs > Cc: Benjamin Tissoires > Cc: Joerg Roedel > Cc: Adrian Hunter > Cc: Yisen Zhuang > Cc: Bjorn Helgaas > Cc: Zhang Rui > Cc: Felipe Balbi > Cc: Mathias Nyman > Cc: Heikki Krogerus &

Re: [PATCH] thermal: core: Add a back up thermal shutdown mechanism

2017-04-12 Thread Zhang Rui
On Wed, 2017-04-12 at 14:06 +0530, Keerthy wrote: > > On Wednesday 12 April 2017 01:56 PM, Zhang Rui wrote: > > > > On Wed, 2017-04-12 at 13:25 +0530, Keerthy wrote: > > > > > > > > > On Wednesday 12 April 2017 09:35 AM, Eduardo Vale

Re: [PATCH] thermal: core: Add a back up thermal shutdown mechanism

2017-04-12 Thread Zhang Rui
On Wed, 2017-04-12 at 14:06 +0530, Keerthy wrote: > > On Wednesday 12 April 2017 01:56 PM, Zhang Rui wrote: > > > > On Wed, 2017-04-12 at 13:25 +0530, Keerthy wrote: > > > > > > > > > On Wednesday 12 April 2017 09:35 AM, Eduardo Vale

Re: [PATCH] thermal: core: Add a back up thermal shutdown mechanism

2017-04-12 Thread Zhang Rui
On Wed, 2017-04-12 at 13:25 +0530, Keerthy wrote: > > On Wednesday 12 April 2017 09:35 AM, Eduardo Valentin wrote: > > > > Keerthy, > > > > On Wed, Apr 12, 2017 at 09:09:36AM +0530, Keerthy wrote: > > > > > > > > > &

Re: [PATCH] thermal: core: Add a back up thermal shutdown mechanism

2017-04-12 Thread Zhang Rui
On Wed, 2017-04-12 at 13:25 +0530, Keerthy wrote: > > On Wednesday 12 April 2017 09:35 AM, Eduardo Valentin wrote: > > > > Keerthy, > > > > On Wed, Apr 12, 2017 at 09:09:36AM +0530, Keerthy wrote: > > > > > > > > > &

Re: [PATCH] thermal: core: Add a back up thermal shutdown mechanism

2017-04-11 Thread Zhang Rui
On Wed, 2017-04-12 at 08:19 +0530, Keerthy wrote: > > On Tuesday 11 April 2017 10:59 PM, Eduardo Valentin wrote: > > > > Hey, > > > > On Fri, Mar 31, 2017 at 12:00:20PM +0530, Keerthy wrote: > > > > > > orderly_poweroff is triggered when a graceful shutdown > > > of system is desired. This may

Re: [PATCH] thermal: core: Add a back up thermal shutdown mechanism

2017-04-11 Thread Zhang Rui
On Wed, 2017-04-12 at 08:19 +0530, Keerthy wrote: > > On Tuesday 11 April 2017 10:59 PM, Eduardo Valentin wrote: > > > > Hey, > > > > On Fri, Mar 31, 2017 at 12:00:20PM +0530, Keerthy wrote: > > > > > > orderly_poweroff is triggered when a graceful shutdown > > > of system is desired. This may

[GIT PULL] Thermal management updates for v4.11-rc5

2017-03-29 Thread Zhang Rui
Hi, Linus, Please pull from   git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux.git for-rc to receive the latest Thermal Management updates for v4.11-rc5 with top-most commit 3ea3217cf91804be6ed9b368ef4ac7911eb1dadc:   thermal: cpu_cooling: Check OPP for errors (2017-03-13 10:06:55

[GIT PULL] Thermal management updates for v4.11-rc5

2017-03-29 Thread Zhang Rui
Hi, Linus, Please pull from   git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux.git for-rc to receive the latest Thermal Management updates for v4.11-rc5 with top-most commit 3ea3217cf91804be6ed9b368ef4ac7911eb1dadc:   thermal: cpu_cooling: Check OPP for errors (2017-03-13 10:06:55

Re: [PATCH 4.10 012/167] mmc: sdhci-acpi: support deferred probe

2017-03-28 Thread Zhang Rui
On Tue, 2017-03-28 at 13:51 +0800, Zhang Rui wrote: > On Mon, 2017-03-27 at 18:36 +0200, Greg Kroah-Hartman wrote: > > > > On Mon, Mar 27, 2017 at 10:40:23AM +0800, Zhang Rui wrote: > > > > > > > > > On Sun, 2017-03-26 at 12:26 +0100, Andrey Utkin wrote

Re: [PATCH 4.10 012/167] mmc: sdhci-acpi: support deferred probe

2017-03-28 Thread Zhang Rui
On Tue, 2017-03-28 at 13:51 +0800, Zhang Rui wrote: > On Mon, 2017-03-27 at 18:36 +0200, Greg Kroah-Hartman wrote: > > > > On Mon, Mar 27, 2017 at 10:40:23AM +0800, Zhang Rui wrote: > > > > > > > > > On Sun, 2017-03-26 at 12:26 +0100, Andrey Utkin wrote

Re: [PATCH 4.10 012/167] mmc: sdhci-acpi: support deferred probe

2017-03-27 Thread Zhang Rui
On Mon, 2017-03-27 at 18:36 +0200, Greg Kroah-Hartman wrote: > On Mon, Mar 27, 2017 at 10:40:23AM +0800, Zhang Rui wrote: > > > > On Sun, 2017-03-26 at 12:26 +0100, Andrey Utkin wrote: > > > > > > On Fri, Mar 10, 2017 at 10:07:35AM +010

Re: [PATCH 4.10 012/167] mmc: sdhci-acpi: support deferred probe

2017-03-27 Thread Zhang Rui
On Mon, 2017-03-27 at 18:36 +0200, Greg Kroah-Hartman wrote: > On Mon, Mar 27, 2017 at 10:40:23AM +0800, Zhang Rui wrote: > > > > On Sun, 2017-03-26 at 12:26 +0100, Andrey Utkin wrote: > > > > > > On Fri, Mar 10, 2017 at 10:07:35AM +010

Re: [PATCH 4.10 012/167] mmc: sdhci-acpi: support deferred probe

2017-03-26 Thread Zhang Rui
On Sun, 2017-03-26 at 12:26 +0100, Andrey Utkin wrote: > On Fri, Mar 10, 2017 at 10:07:35AM +0100, Greg Kroah-Hartman wrote: > > > > 4.10-stable review patch.  If anyone has any objections, please let > > me know. > > > > ------ > > &

Re: [PATCH 4.10 012/167] mmc: sdhci-acpi: support deferred probe

2017-03-26 Thread Zhang Rui
On Sun, 2017-03-26 at 12:26 +0100, Andrey Utkin wrote: > On Fri, Mar 10, 2017 at 10:07:35AM +0100, Greg Kroah-Hartman wrote: > > > > 4.10-stable review patch.  If anyone has any objections, please let > > me know. > > > > ------ > >

Re: [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess with compilation units

2017-03-26 Thread Zhang Rui
g option for Crystal Cove and > > > split > > > Whiskey Cove out of it. > > > > > > (*) It looks like the configuration was never tested with > > > INTEL_SOC_PMIC=n. The line in Makefile is actually wrong. > > > > > > Cc: "Rafael J. Wy

Re: [PATCH v3 1/3] mfd: intel_soc_pmic: Fix a mess with compilation units

2017-03-26 Thread Zhang Rui
g option for Crystal Cove and > > > split > > > Whiskey Cove out of it. > > > > > > (*) It looks like the configuration was never tested with > > > INTEL_SOC_PMIC=n. The line in Makefile is actually wrong. > > > > > > Cc: "Rafael J. Wys

Re: [PATCH V3 0/5] thermal: minor cleanup/fixes

2017-03-13 Thread Zhang Rui
On Mon, 2017-03-13 at 15:37 +0530, Viresh Kumar wrote: > Hi, > > This series contains minor fixes/cleanups for thermal cooling > drivers. > > V2->V3: > - Added Acks from Rui > - Resending as it was getting ignored until now :( I just applied V2 this morning, and has not pushed to kernel.org

Re: [PATCH V3 0/5] thermal: minor cleanup/fixes

2017-03-13 Thread Zhang Rui
On Mon, 2017-03-13 at 15:37 +0530, Viresh Kumar wrote: > Hi, > > This series contains minor fixes/cleanups for thermal cooling > drivers. > > V2->V3: > - Added Acks from Rui > - Resending as it was getting ignored until now :( I just applied V2 this morning, and has not pushed to kernel.org

[GIT PULL] Thermal management updates for v4.11-rc1

2017-03-01 Thread Zhang Rui
: rcar_gen3_thermal: Add R-Car Gen3 thermal driver Zhang Rui (2):   Merge branch 'linus' of git://git.kernel.org/.../evalenti/linux- soc-thermal into thermal-soc   Merge branches 'thermal-core', 'thermal-soc', 'thermal-intel' and 'ida-conversion' into next  .../devicetree/bindings/thermal

[GIT PULL] Thermal management updates for v4.11-rc1

2017-03-01 Thread Zhang Rui
: rcar_gen3_thermal: Add R-Car Gen3 thermal driver Zhang Rui (2):   Merge branch 'linus' of git://git.kernel.org/.../evalenti/linux- soc-thermal into thermal-soc   Merge branches 'thermal-core', 'thermal-soc', 'thermal-intel' and 'ida-conversion' into next  .../devicetree/bindings/thermal

Re: [PATCH V2 0/5] thermal: minor cleanup/fixes

2017-02-20 Thread Zhang Rui
On Mon, 2017-02-20 at 15:59 +0530, Viresh Kumar wrote: > On 07-02-17, 09:39, Viresh Kumar wrote: > > > > Hi, > > > > This series contains minor fixes/cleanups for thermal cooling > > drivers. > > Acked-by: Zhang Rui <rui.zh...@intel.com> for the w

Re: [PATCH V2 0/5] thermal: minor cleanup/fixes

2017-02-20 Thread Zhang Rui
On Mon, 2017-02-20 at 15:59 +0530, Viresh Kumar wrote: > On 07-02-17, 09:39, Viresh Kumar wrote: > > > > Hi, > > > > This series contains minor fixes/cleanups for thermal cooling > > drivers. > > Acked-by: Zhang Rui for the whole patch series. As this p

Re: [PATCH] thermal: use cpumask_var_t for on-stack cpu masks

2017-02-10 Thread Zhang Rui
On Thu, 2017-02-02 at 15:46 +0100, Arnd Bergmann wrote: > Putting a bare cpumask structure on the stack produces a warning on > large SMP configurations: > > drivers/thermal/cpu_cooling.c: In function 'cpufreq_state2power': > drivers/thermal/cpu_cooling.c:644:1: warning: the frame size of 1056 >

Re: [PATCH] thermal: use cpumask_var_t for on-stack cpu masks

2017-02-10 Thread Zhang Rui
On Thu, 2017-02-02 at 15:46 +0100, Arnd Bergmann wrote: > Putting a bare cpumask structure on the stack produces a warning on > large SMP configurations: > > drivers/thermal/cpu_cooling.c: In function 'cpufreq_state2power': > drivers/thermal/cpu_cooling.c:644:1: warning: the frame size of 1056 >

Re: [PATCH] Thermal - Fix possible NULL derefrence.

2017-02-06 Thread Zhang Rui
Just one comment, the subject should be  [PATCH] Thermal: imx_thermal : Fix possible NULL derefrence On Mon, 2017-01-30 at 10:34 +0530, Shailendra Verma wrote: > of_device_get_match_data could return NULL, and so can cause > a NULL pointer dereference later. > > Signed-off-by: Shailendra Verma

Re: [PATCH] Thermal - Fix possible NULL derefrence.

2017-02-06 Thread Zhang Rui
Just one comment, the subject should be  [PATCH] Thermal: imx_thermal : Fix possible NULL derefrence On Mon, 2017-01-30 at 10:34 +0530, Shailendra Verma wrote: > of_device_get_match_data could return NULL, and so can cause > a NULL pointer dereference later. > > Signed-off-by: Shailendra Verma

Re: v4.10-rc4 to v4.10-rc5: battery regression on Nokia N900

2017-01-27 Thread Zhang Rui
On Thu, 2017-01-26 at 22:27 -0800, Guenter Roeck wrote: > On 01/26/2017 07:39 PM, Zhang Rui wrote: > > > > On Thu, 2017-01-26 at 18:03 -0800, Guenter Roeck wrote: > > > > > > On 01/26/2017 05:37 PM, Zhang Rui wrote: > > > > > > > > &g

Re: v4.10-rc4 to v4.10-rc5: battery regression on Nokia N900

2017-01-27 Thread Zhang Rui
On Thu, 2017-01-26 at 22:27 -0800, Guenter Roeck wrote: > On 01/26/2017 07:39 PM, Zhang Rui wrote: > > > > On Thu, 2017-01-26 at 18:03 -0800, Guenter Roeck wrote: > > > > > > On 01/26/2017 05:37 PM, Zhang Rui wrote: > > > > > > > > &g

[GIT PULL] Thermal management updates for v4.10-rc6

2017-01-27 Thread Zhang Rui
Hi, Linus, Please pull from   git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux.git for-rc to receive the latest Thermal Management updates for v4.10-rc6 with top-most commit 3feb479cea37fc623cf4e705631b2e679cbfbd7a:   Revert "thermal: thermal_hwmon: Convert to

[GIT PULL] Thermal management updates for v4.10-rc6

2017-01-27 Thread Zhang Rui
Hi, Linus, Please pull from   git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux.git for-rc to receive the latest Thermal Management updates for v4.10-rc6 with top-most commit 3feb479cea37fc623cf4e705631b2e679cbfbd7a:   Revert "thermal: thermal_hwmon: Convert to

GIT PULL] Thermal management updates for v4.10-rc6

2017-01-26 Thread Zhang Rui
Hi, Linus, Please pull from   git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux.git for-rc to receive the latest Thermal Management updates for v4.10-rc6 with top-most commit 3feb479cea37fc623cf4e705631b2e679cbfbd7a:   Revert "thermal: thermal_hwmon: Convert to

<    1   2   3   4   5   6   7   8   9   10   >