Yes, I'm working on it. Do not worry about it.
Wei.
> -Original Message-
> From: Kumar Gala [mailto:[EMAIL PROTECTED]
> Sent: Tuesday, October 30, 2007 4:31 AM
> To: [EMAIL PROTECTED]
> Cc: Zhang Wei-r63237; [EMAIL PROTECTED];
> [EMAIL PROTECTED]; [EMAIL PROTECTED
Yes, I'm working on it. Do not worry about it.
Wei.
-Original Message-
From: Kumar Gala [mailto:[EMAIL PROTECTED]
Sent: Tuesday, October 30, 2007 4:31 AM
To: [EMAIL PROTECTED]
Cc: Zhang Wei-r63237; [EMAIL PROTECTED];
[EMAIL PROTECTED]; [EMAIL PROTECTED];
linux-kernel
Hi,
> > +static void fsl_dma_set_src(dma_addr_t addr,
> > + struct dma_async_tx_descriptor
> *tx, int index)
> > +{
>
> What is index supposed to mean? It's not used, or documented
> anywhere than
> I can see.
I've also got more document here. Hi, Dan, could you
Hi,
+static void fsl_dma_set_src(dma_addr_t addr,
+ struct dma_async_tx_descriptor
*tx, int index)
+{
What is index supposed to mean? It's not used, or documented
anywhere than
I can see.
I've also got more document here. Hi, Dan, could you give me some
Hi, Dan,
Does I have followed your new API? :-)
> > ---
> Greetings,
>
> Please copy me on any updates to this driver, drivers/dma, or
> crypto/async_tx.
Ok.
>
> Below are a few review comments...
>
> Regards,
> Dan
>
> > +/**
> > + * fsl_dma_alloc_descriptor - Allocate descriptor from
>
>
> If this is experimental, perhaps you should mark the depends line as
> such
> depends on on DMA_ENGINE && PPC && EXPERIMENTAL
I'll add EXPERIMENTAL for MPC83xx only.
>
> [...]
>
> >+
> >+fsl_dma_memcpy_issue_pending(chan);
> >+while (fsl_dma_is_complete(chan, cookie, NULL,
Hi,
> --- /dev/null
> > +++ b/drivers/dma/fsldma.c
> > @@ -0,0 +1,995 @@
>
> Thanks for using kernel-doc notation. However, ...
>
> > +/**
> > + * fsl_dma_alloc_descriptor - Allocate descriptor from
> channel's DMA pool.
>
> Function parameters need to be listed & described here.
> See
Hi,
--- /dev/null
+++ b/drivers/dma/fsldma.c
@@ -0,0 +1,995 @@
Thanks for using kernel-doc notation. However, ...
+/**
+ * fsl_dma_alloc_descriptor - Allocate descriptor from
channel's DMA pool.
Function parameters need to be listed described here.
See
If this is experimental, perhaps you should mark the depends line as
such
depends on on DMA_ENGINE PPC EXPERIMENTAL
I'll add EXPERIMENTAL for MPC83xx only.
[...]
+
+fsl_dma_memcpy_issue_pending(chan);
+while (fsl_dma_is_complete(chan, cookie, NULL, NULL)
+
Hi, Dan,
Does I have followed your new API? :-)
---
Greetings,
Please copy me on any updates to this driver, drivers/dma, or
crypto/async_tx.
Ok.
Below are a few review comments...
Regards,
Dan
+/**
+ * fsl_dma_alloc_descriptor - Allocate descriptor from
channel's DMA
Hi, Arnd,
I can change it as you metioned now.
Thanks!
-zw
> -Original Message-
> From: [EMAIL PROTECTED]
> [mailto:[EMAIL PROTECTED] On Behalf Of Arnd Bergmann
> Sent: Sunday, July 29, 2007 9:57 PM
> To: [EMAIL PROTECTED]
> Cc: Zhang Wei-r63237; [EMAIL PROTECTED];
Hi, Arnd,
I can change it as you metioned now.
Thanks!
-zw
-Original Message-
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of Arnd Bergmann
Sent: Sunday, July 29, 2007 9:57 PM
To: [EMAIL PROTECTED]
Cc: Zhang Wei-r63237; [EMAIL PROTECTED];
[EMAIL PROTECTED
Hi, Kumar,
> + RapidIO is a definition of a system interconnect. This node add
> > + the support for RapidIO processor in kernel. The node name is
> > + suggested to be 'rapidio'.
> > +
> > + Required properties:
> > +
> > +- compatible : Using "fsl,rapidio-delta" for Freescale
Hi, Kumar,
> -Original Message-
> From: Kumar Gala [mailto:[EMAIL PROTECTED]
> On Jul 26, 2007, at 3:42 AM, Zhang Wei wrote:
>
> > This patch adds the RapidIO support to the powerpc architecture.
> > Some files are moved from ppc. OF-tree and OF-device supports are
> > added.
> > New
Hi, Kumar,
-Original Message-
From: Kumar Gala [mailto:[EMAIL PROTECTED]
On Jul 26, 2007, at 3:42 AM, Zhang Wei wrote:
This patch adds the RapidIO support to the powerpc architecture.
Some files are moved from ppc. OF-tree and OF-device supports are
added.
New silicons
Hi, Kumar,
+ RapidIO is a definition of a system interconnect. This node add
+ the support for RapidIO processor in kernel. The node name is
+ suggested to be 'rapidio'.
+
+ Required properties:
+
+- compatible : Using fsl,rapidio-delta for Freescale PowerPC
+
Hi, Dan,
Thanks! I get it.
It's so lucky we have the same target.
When your patch could be accepted?
Cheers,
Wei.
> -Original Message-
> From: [EMAIL PROTECTED]
> [mailto:[EMAIL PROTECTED] On Behalf Of Dan Williams
> Sent: Thursday, July 12, 2007 12:57 AM
> To: Zhang
Hi, Dan,
Thanks! I get it.
It's so lucky we have the same target.
When your patch could be accepted?
Cheers,
Wei.
-Original Message-
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of Dan Williams
Sent: Thursday, July 12, 2007 12:57 AM
To: Zhang Wei-r63237
Cc: [EMAIL
Hi, Dan,
Do you mention here: http://marc.info/?l=linux-raid=118290909614463=2 ?
I see the async_tx is located at crypto/ of the above page, but my patch is for
DMA engine in drivers/dma and for DMA engine driver.
Thanks!
Wei.
> -Original Message-
> Subject: Re: [PATCH 3/4] Extend the
Hi, Dan,
Do you mention here: http://marc.info/?l=linux-raidm=118290909614463w=2 ?
I see the async_tx is located at crypto/ of the above page, but my patch is for
DMA engine in drivers/dma and for DMA engine driver.
Thanks!
Wei.
-Original Message-
Subject: Re: [PATCH 3/4] Extend the
Hi, Segher,
> DTS sector to the document of booting-without-of.txt file.
>
> >>> +- #address-cells : Address representation for
> >> "rapidio" devices.
> >>> + This field represents the number of cells needed
> to represent
> >>> + the RapidIO address of the registers. For
> >>
Hi, Segher,
DTS sector to the document of booting-without-of.txt file.
+- #address-cells : Address representation for
rapidio devices.
+ This field represents the number of cells needed
to represent
+ the RapidIO address of the registers. For
supporting more than
Hi, Segher,
> > +- #address-cells : Address representation for
> "rapidio" devices.
> > + This field represents the number of cells needed to represent
> > + the RapidIO address of the registers. For
> supporting more than
> > + 32-bits RapidIO address, this field should
Hi, Arnd,
>
> On Wednesday 27 June 2007, Zhang Wei wrote:
> > +static struct of_device_id mpc86xx_of_ids[] = {
> > + { .type = "soc", },
> > + { .compatible = "fsl,rapidio-delta", },
> > + {},
> > +};
> > +
> > +static __init int mpc86xx_of_device_init(void)
> > +{
> > +
Hi, Arnd,
On Wednesday 27 June 2007, Zhang Wei wrote:
+static struct of_device_id mpc86xx_of_ids[] = {
+ { .type = soc, },
+ { .compatible = fsl,rapidio-delta, },
+ {},
+};
+
+static __init int mpc86xx_of_device_init(void)
+{
+ return
Hi, Segher,
+- #address-cells : Address representation for
rapidio devices.
+ This field represents the number of cells needed to represent
+ the RapidIO address of the registers. For
supporting more than
+ 32-bits RapidIO address, this field should be 2.
+
Hi, Kumar and Segher,
>
> > "..8641.." "..8641d.." "..8548.." "..8548e.." "..8543.."
> "..8543e.."
> > "..8572.." "..8572e.." "..8567.." "..8567e.." "..8568.." "..8568e.."
>
> You don't need to mention _all_ compatible devices in
> the "compatible" property, only the few that matter;
>
Hi, Kumar and Segher,
..8641.. ..8641d.. ..8548.. ..8548e.. ..8543..
..8543e..
..8572.. ..8572e.. ..8567.. ..8567e.. ..8568.. ..8568e..
You don't need to mention _all_ compatible devices in
the compatible property, only the few that matter;
typically the oldest one, and sometimes
Hi, Segher,
>
> >>> +- device_type : Should be "rapidio"
> >>
> >> There is no OF binding, so no.
> >
> > So, we need to define it.
>
> If you want to. Until that has been done, don't use
> a "device_type". Linux won't use it, anyway.
Do you have another ideas about that? Only remove
Hi, Segher,
> -Original Message-
> Subject: Re: [PATCH 1/5] Add the explanation and sample of
> RapidIO DTS sector to the document of booting-without-of.txt file.
>
> > + k) RapidIO
> > +
> > + Required properties:
> > +
> > +- device_type : Should be "rapidio"
>
> There is no
Hi, Segher,
-Original Message-
Subject: Re: [PATCH 1/5] Add the explanation and sample of
RapidIO DTS sector to the document of booting-without-of.txt file.
+ k) RapidIO
+
+ Required properties:
+
+- device_type : Should be rapidio
There is no OF binding, so
Hi, Segher,
+- device_type : Should be rapidio
There is no OF binding, so no.
So, we need to define it.
If you want to. Until that has been done, don't use
a device_type. Linux won't use it, anyway.
Do you have another ideas about that? Only remove it?
+-
Hi, Phil,
> > +++ b/arch/powerpc/boot/dts/mpc8641_hpcn.dts
> > @@ -329,6 +329,19 @@
> > >;
> > };
> >
> > + [EMAIL PROTECTED] {
> > + device_type = "rapidio";
> > + compatible = "fsl,rapidio-v1.0";
> > +
Hi, Phil,
+++ b/arch/powerpc/boot/dts/mpc8641_hpcn.dts
@@ -329,6 +329,19 @@
;
};
+ [EMAIL PROTECTED] {
+ device_type = rapidio;
+ compatible = fsl,rapidio-v1.0;
+
34 matches
Mail list logo
