On Wed, 2014-04-16 at 23:08:26 +0200, Michal Marek wrote:
> On Mon, Apr 14, 2014 at 02:56:15PM +0800, Zhao, Gang wrote:
>> When using `make M=/path/to/driver modules` to build a module, file
>> Module.symvers will be created in that directory, so it's better to
>> ignore
On Wed, 2014-04-16 at 23:08:26 +0200, Michal Marek wrote:
On Mon, Apr 14, 2014 at 02:56:15PM +0800, Zhao, Gang wrote:
When using `make M=/path/to/driver modules` to build a module, file
Module.symvers will be created in that directory, so it's better to
ignore it in all directories
Signed-off-by: Zhao, Gang
---
.gitignore | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/.gitignore b/.gitignore
index 7e9932e..3aa8145 100644
--- a/.gitignore
+++ b/.gitignore
@@ -22,7 +22,6 @@
*.lst
*.symtypes
*.order
-modules.builtin
*.elf
*.bin
*.gz
@@ -33,6 +32,8
kyungsik@lge.com
Cc: Markus Trippelsdorf mar...@trippelsdorf.de
Signed-off-by: Zhao, Gang gamer...@gmail.com
---
.gitignore | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/.gitignore b/.gitignore
index 7e9932e..3aa8145 100644
--- a/.gitignore
+++ b/.gitignore
@@ -22,7 +22,6
s the (hopefully) last
> such missing statement
Thanks for the catch.
minor issue: commit log should be 'fails to be built'.
>
> Cc: "Zhao, Gang"
> Cc: "John W. Linville"
> Signed-off-by: Arnd Bergmann
> ---
> diff --git a/drivers/net/wireless/Kconfig
such missing statement
Thanks for the catch.
minor issue: commit log should be 'fails to be built'.
Cc: Zhao, Gang gamer...@gmail.com
Cc: John W. Linville linvi...@tuxdriver.com
Signed-off-by: Arnd Bergmann a...@arndb.de
---
diff --git a/drivers/net/wireless/Kconfig b/drivers/net/wireless/Kconfig
On Thu, 2014-02-20 at 17:03:39 +0800, Dan Carpenter wrote:
> On Thu, Feb 20, 2014 at 11:03:45AM +0800, Zhao, Gang wrote:
>> On Wed, 2014-02-19 at 19:43:15 +0800, One Thousand Gnomes wrote:
>> > On Wed, 19 Feb 2014 09:14:19 +0800
>> > "Zhao\, Gang" wrote:
On Thu, 2014-02-20 at 17:03:39 +0800, Dan Carpenter wrote:
On Thu, Feb 20, 2014 at 11:03:45AM +0800, Zhao, Gang wrote:
On Wed, 2014-02-19 at 19:43:15 +0800, One Thousand Gnomes wrote:
On Wed, 19 Feb 2014 09:14:19 +0800
Zhao\, Gang gamer...@gmail.com wrote:
Alan, thanks for resending
On Wed, 2014-02-19 at 19:43:15 +0800, One Thousand Gnomes wrote:
> On Wed, 19 Feb 2014 09:14:19 +0800
> "Zhao\, Gang" wrote:
>
>> Alan, thanks for resending this patch. But it seems you overlooked
>> something we discussed earlier.
>>
>> On Mon, 2014-0
On Wed, 2014-02-19 at 19:43:15 +0800, One Thousand Gnomes wrote:
On Wed, 19 Feb 2014 09:14:19 +0800
Zhao\, Gang gamer...@gmail.com wrote:
Alan, thanks for resending this patch. But it seems you overlooked
something we discussed earlier.
On Mon, 2014-02-17 at 22:13:08 +0800, Alan wrote
Alan, thanks for resending this patch. But it seems you overlooked
something we discussed earlier.
On Mon, 2014-02-17 at 22:13:08 +0800, Alan wrote:
> We should check the ring allocations don't fail.
> If we get a fail we need to clean up properly. The allocator assumes the
> deallocator will be
Alan, thanks for resending this patch. But it seems you overlooked
something we discussed earlier.
On Mon, 2014-02-17 at 22:13:08 +0800, Alan wrote:
We should check the ring allocations don't fail.
If we get a fail we need to clean up properly. The allocator assumes the
deallocator will be
On Thu, Dec 5, 2013 at 11:43 PM, Greg Kroah-Hartman
wrote:
> On Thu, Dec 05, 2013 at 05:06:33PM +0800, ZHAO Gang wrote:
>> On Tue, Dec 3, 2013 at 7:26 AM, Jingoo Han wrote:
>> > Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro
>> > is not preferred.
>>
On Tue, Dec 3, 2013 at 7:29 AM, Jingoo Han wrote:
> Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro
> is not preferred.
>
> Signed-off-by: Jingoo Han
> ---
Greg, this patch should be reverted. It do the opposite things.
> drivers/vme/boards/vme_vmivme7805.c |2 +-
>
On Tue, Dec 3, 2013 at 7:26 AM, Jingoo Han wrote:
> Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro
> is not preferred.
>
> Signed-off-by: Jingoo Han
>
I think you misunderstood the checkpatch.pl warning, it tells you what
to do, not what not to do.
WARNING: Use
On Tue, Dec 3, 2013 at 7:26 AM, Jingoo Han jg1@samsung.com wrote:
Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro
is not preferred.
Signed-off-by: Jingoo Han jg1@samsung.com
I think you misunderstood the checkpatch.pl warning, it tells you what
to do, not what not to do.
On Tue, Dec 3, 2013 at 7:29 AM, Jingoo Han jg1@samsung.com wrote:
Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro
is not preferred.
Signed-off-by: Jingoo Han jg1@samsung.com
---
Greg, this patch should be reverted. It do the opposite things.
On Thu, Dec 5, 2013 at 11:43 PM, Greg Kroah-Hartman
gre...@linuxfoundation.org wrote:
On Thu, Dec 05, 2013 at 05:06:33PM +0800, ZHAO Gang wrote:
On Tue, Dec 3, 2013 at 7:26 AM, Jingoo Han jg1@samsung.com wrote:
Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro
is not preferred
On Fri, Nov 22, 2013 at 7:56 PM, Denis Kirjanov wrote:
> If you have no free TX descriptors that means that something went
> wrong and it's a BUG. You have to tell the stack to stop sending
> packets using netif_stop_queue() and reenable transmissions once tx
> descriptors will be available.
On Fri, Nov 22, 2013 at 5:17 PM, Denis Kirjanov wrote:
> On 11/22/13, Mark Einon wrote:
>> On Wed, Nov 20, 2013 at 03:55:27PM +0800, ZHAO Gang wrote:
>>> As TODO file suggested, drop packet instead of return NETDEV_TX_BUSY
>>> when tx failed.
>>>
>>>
On Fri, Nov 22, 2013 at 5:17 PM, Denis Kirjanov kirja...@gmail.com wrote:
On 11/22/13, Mark Einon mark.ei...@gmail.com wrote:
On Wed, Nov 20, 2013 at 03:55:27PM +0800, ZHAO Gang wrote:
As TODO file suggested, drop packet instead of return NETDEV_TX_BUSY
when tx failed.
et131x_tx calls
On Fri, Nov 22, 2013 at 7:56 PM, Denis Kirjanov kirja...@gmail.com wrote:
If you have no free TX descriptors that means that something went
wrong and it's a BUG. You have to tell the stack to stop sending
packets using netif_stop_queue() and reenable transmissions once tx
descriptors will be
adapter->lock is only used in et131x_multicast(), which is eventually
called by network stack function __dev_set_rx_mode(). __dev_set_rx_mode()
is always called by (net_device *)dev->addr_list_lock hold, to protect from
concurrent access. So adapter->lock is redundant.
Signed-off-by:
stop read and return error when hit max delay time.
Signed-off-by: ZHAO Gang
---
drivers/staging/et131x/et131x.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index cda037a..6254a6b 100644
--- a/drivers/staging/et131x
remove items that have been done
Signed-off-by: ZHAO Gang
---
drivers/staging/et131x/README | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/et131x/README b/drivers/staging/et131x/README
index 8da96a6..00a34ea 100644
--- a/drivers/staging/et131x/README
+++ b/drivers
As TODO file suggested, drop packet instead of return NETDEV_TX_BUSY
when tx failed.
et131x_tx calls function et131x_send_packets, I put the work of
et131x_send_packets directly into et131x_tx, and made some changes to
let the code more readable.
Signed-off-by: ZHAO Gang
---
drivers/staging
This patch set should apply to current staging-next tree
ZHAO Gang (5):
staging: et131x: clean up code
staging: et131x: drop packet when error occurs in et131x_tx
staging: et131x: stop read when hit max delay in et131x_phy_mii_read
staging: et131x: remove spinlock adapter->lock
stag
fbr[id];
Then replace all the instances of "rx_local->fbr[id]" with fbr.
3. delete unnecessary variable in function et131x_init
variable u32 numrfd is not necessary in this function.
4. some code style change
Signed-off-by: ZHAO Gang
---
drivers/staging/et
On Wed, Nov 20, 2013 at 1:41 PM, Greg Kroah-Hartman
wrote:
> In the future, you need to tell me to drop the old ones from my queue.
> Normally you can do that by replying to them saying to remove them, or
> put a "v2" for "version 2" on this series.
>
> Anyway, as Mark told you to redo them a
> Hi, please revert the previous two patches if you can.
I mean drop/ignore previous two patches, just apply this 4 patches to
staging-next, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info
> I'm a bit confused - these patches apply to the current head of
> staging-next, but not on top of your previous two patches. I assume that
> you're aiming to have these changes on top of your last two, so can you
> please re-spin them to apply cleanly to the head of (staging-next + your
>
I'm a bit confused - these patches apply to the current head of
staging-next, but not on top of your previous two patches. I assume that
you're aiming to have these changes on top of your last two, so can you
please re-spin them to apply cleanly to the head of (staging-next + your
previous
Hi, please revert the previous two patches if you can.
I mean drop/ignore previous two patches, just apply this 4 patches to
staging-next, thanks.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at
On Wed, Nov 20, 2013 at 1:41 PM, Greg Kroah-Hartman
gre...@linuxfoundation.org wrote:
In the future, you need to tell me to drop the old ones from my queue.
Normally you can do that by replying to them saying to remove them, or
put a v2 for version 2 on this series.
Anyway, as Mark told you
This patch set should apply to current staging-next tree
ZHAO Gang (5):
staging: et131x: clean up code
staging: et131x: drop packet when error occurs in et131x_tx
staging: et131x: stop read when hit max delay in et131x_phy_mii_read
staging: et131x: remove spinlock adapter-lock
staging
all the instances of rx_local-fbr[id] with fbr.
3. delete unnecessary variable in function et131x_init
variable u32 numrfd is not necessary in this function.
4. some code style change
Signed-off-by: ZHAO Gang gamer...@gmail.com
---
drivers/staging/et131x/et131x.c | 209
As TODO file suggested, drop packet instead of return NETDEV_TX_BUSY
when tx failed.
et131x_tx calls function et131x_send_packets, I put the work of
et131x_send_packets directly into et131x_tx, and made some changes to
let the code more readable.
Signed-off-by: ZHAO Gang gamer...@gmail.com
remove items that have been done
Signed-off-by: ZHAO Gang gamer...@gmail.com
---
drivers/staging/et131x/README | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/et131x/README b/drivers/staging/et131x/README
index 8da96a6..00a34ea 100644
--- a/drivers/staging/et131x/README
stop read and return error when hit max delay time.
Signed-off-by: ZHAO Gang gamer...@gmail.com
---
drivers/staging/et131x/et131x.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index cda037a..6254a6b 100644
--- a/drivers
adapter-lock is only used in et131x_multicast(), which is eventually
called by network stack function __dev_set_rx_mode(). __dev_set_rx_mode()
is always called by (net_device *)dev-addr_list_lock hold, to protect from
concurrent access. So adapter-lock is redundant.
Signed-off-by: ZHAO Gang gamer
adapter->lock is only used in et131x_multicast(), which is eventually
called by network stack function __dev_set_rx_mode(). __dev_set_rx_mode()
is always called by (net_device *)dev->addr_list_lock hold, to protect from
concurrent access. So adapter->lock is redundant.
Signed-off-by:
stop read and return error when hit max delay time.
Signed-off-by: ZHAO Gang
---
drivers/staging/et131x/et131x.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index cda037a..6254a6b 100644
--- a/drivers/staging/et131x
As TODO file suggested, drop packet instead of return NETDEV_TX_BUSY
when tx failed.
et131x_tx calls function et131x_send_packets, I put the work of
et131x_send_packets directly into et131x_tx, and made some changes to
let the code more readable.
Signed-off-by: ZHAO Gang
---
drivers/staging
fbr[id];
Then replace all the instances of "rx_local->fbr[id]" with fbr.
3. delete unnecessary variable in function et131x_init
variable u32 numrfd is not necessary in this function.
4. some code style change
Signed-off-by: ZHAO Gang
---
drivers/staging/et
all the instances of rx_local-fbr[id] with fbr.
3. delete unnecessary variable in function et131x_init
variable u32 numrfd is not necessary in this function.
4. some code style change
Signed-off-by: ZHAO Gang gamer...@gmail.com
---
drivers/staging/et131x/et131x.c | 209
As TODO file suggested, drop packet instead of return NETDEV_TX_BUSY
when tx failed.
et131x_tx calls function et131x_send_packets, I put the work of
et131x_send_packets directly into et131x_tx, and made some changes to
let the code more readable.
Signed-off-by: ZHAO Gang gamer...@gmail.com
stop read and return error when hit max delay time.
Signed-off-by: ZHAO Gang gamer...@gmail.com
---
drivers/staging/et131x/et131x.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index cda037a..6254a6b 100644
--- a/drivers
adapter-lock is only used in et131x_multicast(), which is eventually
called by network stack function __dev_set_rx_mode(). __dev_set_rx_mode()
is always called by (net_device *)dev-addr_list_lock hold, to protect from
concurrent access. So adapter-lock is redundant.
Signed-off-by: ZHAO Gang gamer
Drop packet instead of return NETDEV_TX_BUSY when tx failed.
Signed-off-by: ZHAO Gang
---
move function send_packet's work directly to et131x_tx(), also make
some changes to improve readability.
drivers/staging/et131x/et131x.c | 84 +++--
1 file changed, 22
Signed-off-by: ZHAO Gang
---
drivers/staging/et131x/et131x.c | 26 --
1 file changed, 12 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index ca3332e..8c2a4a5 100644
--- a/drivers/staging/et131x/et131x.c
Signed-off-by: ZHAO Gang gamer...@gmail.com
---
drivers/staging/et131x/et131x.c | 26 --
1 file changed, 12 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index ca3332e..8c2a4a5 100644
--- a/drivers/staging
Drop packet instead of return NETDEV_TX_BUSY when tx failed.
Signed-off-by: ZHAO Gang gamer...@gmail.com
---
move function send_packet's work directly to et131x_tx(), also make
some changes to improve readability.
drivers/staging/et131x/et131x.c | 84
What sk_reset_txq() does is just calls function sk_tx_queue_reset(),
and sk_reset_txq() is used only in sock.h, by dst_negative_advice().
Let dst_negative_advice() calls sk_tx_queue_reset() directly so we
can remove unneeded sk_reset_txq().
Signed-off-by: ZHAO Gang
---
include/net/sock.h | 4
What sk_reset_txq() does is just calls function sk_tx_queue_reset(),
and sk_reset_txq() is used only in sock.h, by dst_negative_advice().
Let dst_negative_advice() calls sk_tx_queue_reset() directly so we
can remove unneeded sk_reset_txq().
Signed-off-by: ZHAO Gang gamer...@gmail.com
---
include
What sk_reset_txq() does is just calls function sk_tx_queue_reset(),
and sk_reset_txq() is used only in sock.h, by dst_negative_advice().
Let dst_negative_advice() calls sk_tx_queue_reset() directly so we
can remove unneeded sk_reset_txq().
Signed-off-by: ZHAO Gang
change a typo in patch
What sk_reset_txq() does is just calls function sk_tx_queue_reset(),
and sk_reset_txq() is used only in sock.c, by dst_negative_advice().
Let dst_negative_advice() calls sk_tx_queue_reset() directly so we
can remove unneeded sk_reset_txq().
Signed-off-by: ZHAO Gang
---
include/net/sock.h | 4
What sk_reset_txq() does is just calls function sk_tx_queue_reset(),
and sk_reset_txq() is used only in sock.c, by dst_negative_advice().
Let dst_negative_advice() calls sk_tx_queue_reset() directly so we
can remove unneeded sk_reset_txq().
Signed-off-by: ZHAO Gang gamer...@gmail.com
---
include
What sk_reset_txq() does is just calls function sk_tx_queue_reset(),
and sk_reset_txq() is used only in sock.h, by dst_negative_advice().
Let dst_negative_advice() calls sk_tx_queue_reset() directly so we
can remove unneeded sk_reset_txq().
Signed-off-by: ZHAO Gang gamer...@gmail.com
change
Signed-off-by: ZHAO Gang
---
include/linux/netdevice.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 3de49ac..a721a00 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -366,7 +366,7
Signed-off-by: ZHAO Gang
---
include/linux/netdevice.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 3de49ac..0dd6de7 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -366,7 +366,7
Signed-off-by: ZHAO Gang gamer...@gmail.com
---
include/linux/netdevice.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 3de49ac..0dd6de7 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
Signed-off-by: ZHAO Gang gamer...@gmail.com
---
include/linux/netdevice.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 3de49ac..a721a00 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
Signed-off-by: ZHAO Gang
---
net/core/rtnetlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 2a0e21d..bc04f15 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -2658,7 +2658,7 @@ static int rtnetlink_rcv_msg
Signed-off-by: ZHAO Gang gamer...@gmail.com
---
net/core/rtnetlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 2a0e21d..bc04f15 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -2658,7 +2658,7 @@ static int
file linux/fib_rules.h doesn't exist, so remove it.
Signed-off-by: ZHAO Gang
---
include/net/fib_rules.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/net/fib_rules.h b/include/net/fib_rules.h
index 4b2b557..c816f91 100644
--- a/include/net/fib_rules.h
+++ b/include/net
file linux/fib_rules.h doesn't exist, so remove it.
Signed-off-by: ZHAO Gang gamer...@gmail.com
---
include/net/fib_rules.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/net/fib_rules.h b/include/net/fib_rules.h
index 4b2b557..c816f91 100644
--- a/include/net/fib_rules.h
+++ b
uot;git add ..." to include in what will be committed)
#
# Documentation/DocBook/media_api/
nothing added to commit but untracked files present (use "git add" to track)
Add "*.svg" to DocBook/.gitignore so git will not track directory
DocBook/media_api, since there is no
will be committed)
#
# Documentation/DocBook/media_api/
nothing added to commit but untracked files present (use git add to track)
Add *.svg to DocBook/.gitignore so git will not track directory
DocBook/media_api, since there is no file in that directory it interest in.
Signed-off-by: ZHAO Gang gamer
68 matches
Mail list logo
