RE: [PATCH 2/5 V4] PCI: pciehp: check and wait port status out of DPC before handling DLLSC and PDC

2020-09-27 Thread Zhao, Haifeng
Sathyanarayanan, -Original Message- From: Kuppuswamy, Sathyanarayanan Sent: Monday, September 28, 2020 2:59 AM To: Zhao, Haifeng ; bhelg...@google.com; ooh...@gmail.com; rus...@russell.cc; lu...@wunner.de; andriy.shevche...@linux.intel.com; stuart.w.ha...@gmail.com; mr.nuke

RE: [PATCH 2/5 V4] PCI: pciehp: check and wait port status out of DPC before handling DLLSC and PDC

2020-09-27 Thread Zhao, Haifeng
Andy, May I ask which line of the Oops is " you randomly did something " ? and should be removed ? Thanks, Ethan -Original Message- From: Andy Shevchenko Sent: Sunday, September 27, 2020 5:10 PM To: Zhao, Haifeng ; Hansen, Dave Cc: Bjorn Helgaas ; Oliver ; rus...@

RE: [PATCH 2/5 V2] PCI: pciehp: check and wait port status out of DPC before handling DLLSC and PDC

2020-09-27 Thread Zhao, Haifeng
Sinan, I explained the reason why locks don't protect this case in the patch description part. Write side and read side hold different semaphore and mutex. Thanks, Ethan -Original Message- From: Sinan Kaya Sent: Sunday, September 27, 2020 11:28 PM To: Zhao, Haifeng ;

RE: [PATCH 4/5 V4] PCI: only return true when dev io state is really changed

2020-09-27 Thread Zhao, Haifeng
Sorry for that offence, I should ask for your permission. -Original Message- From: Joe Perches Sent: Sunday, September 27, 2020 5:14 PM To: Zhao, Haifeng ; bhelg...@google.com; ooh...@gmail.com; rus...@russell.cc; lu...@wunner.de; andriy.shevche...@linux.intel.com; stuart.w.ha

RE: [PATCH 1/5 V2] PCI: define a function to check and wait till port finish DPC handling

2020-09-26 Thread Zhao, Haifeng
Yep, I am think the same question, is there any other files better to put this function ? How about pci.c ? Thanks, Ethan -Original Message- From: Christoph Hellwig Sent: Sunday, September 27, 2020 2:24 PM To: Zhao, Haifeng Cc: bhelg...@google.com; ooh...@gmail.com; rus

RE: [PATCH 4/5 V2] PCI: only return true when dev io state is really changed

2020-09-26 Thread Zhao, Haifeng
😊 definitely simpler ! -Original Message- From: Joe Perches Sent: Sunday, September 27, 2020 12:17 PM To: Zhao, Haifeng ; bhelg...@google.com; ooh...@gmail.com; rus...@russell.cc; lu...@wunner.de; andriy.shevche...@linux.intel.com; stuart.w.ha...@gmail.com; mr.nuke...@gmail.com

RE: [PATCH 1/5] PCI: define a function to check and wait till port finish DPC handling

2020-09-26 Thread Zhao, Haifeng
Shevchenko Sent: Friday, September 25, 2020 8:25 PM To: Zhao, Haifeng Cc: bhelg...@google.com; ooh...@gmail.com; rus...@russell.cc; lu...@wunner.de; stuart.w.ha...@gmail.com; mr.nuke...@gmail.com; mika.westerb...@linux.intel.com; linux-...@vger.kernel.org; linux-kernel@vger.kernel.org;

RE: [PATCH 2/5] PCI: pciehp: check and wait port status out of DPC before handling DLLSC and PDC

2020-09-26 Thread Zhao, Haifeng
Andy, About the ICX code name, I will align it to public documentation in next version. ' non-relevant information' about the crash, I'm not sure what's not relevant. Thanks, Ethan -Original Message- From: Andy Shevchenko Sent: Friday, September 25, 2

RE: [PATCH 4/5] PCI: only return true when dev io state is really changed

2020-09-26 Thread Zhao, Haifeng
Yes, better ! -Original Message- From: Andy Shevchenko Sent: Friday, September 25, 2020 8:38 PM To: Zhao, Haifeng Cc: bhelg...@google.com; ooh...@gmail.com; rus...@russell.cc; lu...@wunner.de; stuart.w.ha...@gmail.com; mr.nuke...@gmail.com; mika.westerb...@linux.intel.com; linux

RE: [PATCH] Revert "block: revert back to synchronous request_queue removal"

2020-09-08 Thread Zhao, Haifeng
Ming, Got it, will try and give you feedback. Thanks, -Original Message- From: Ming Lei Sent: Wednesday, September 9, 2020 10:39 AM To: Zhao, Haifeng Cc: Christoph Hellwig ; ax...@kernel.dk; bhelg...@google.com; linux-bl...@vger.kernel.org; linux-kernel@vger.kernel.org; linux

RE: [PATCH] Revert "block: revert back to synchronous request_queue removal"

2020-09-08 Thread Zhao, Haifeng
ert's quick fix. Thanks, Ethan -Original Message- From: Christoph Hellwig Sent: Tuesday, September 8, 2020 10:21 PM To: Zhao, Haifeng Cc: ax...@kernel.dk; bhelg...@google.com; linux-bl...@vger.kernel.org; linux-kernel@vger.kernel.org; linux-...@vger.kernel.org; mcg...@kernel.o