[PATCH v4] ARM: imx: Added perf functionality to mmdc driver

2016-08-31 Thread Zhengyu Shen
/ 427.76 MB mmdc/write-bytes/ 5.334757334 seconds time elapsed Signed-off-by: Zhengyu Shen <zhengyu.s...@nxp.com> Signed-off-by: Frank Li <frank...@nxp.com> --- Changes from v3 to v4: Tested and fixed crash relating to removing events with perf fuzzer Adjuste

[PATCH v4] ARM: imx: Added perf functionality to mmdc driver

2016-08-31 Thread Zhengyu Shen
/ 427.76 MB mmdc/write-bytes/ 5.334757334 seconds time elapsed Signed-off-by: Zhengyu Shen Signed-off-by: Frank Li --- Changes from v3 to v4: Tested and fixed crash relating to removing events with perf fuzzer Adjusted formatting Moved all perf event code under

RE: [PATCH v3] Added perf functionality to mmdc driver

2016-08-31 Thread Zhengyu Shen
> > Mmdc was only responsible for one crash which I fixed (had to remove > > the event from the pmu properly). > > Ok. I take it that there will be a v4 appearing shortly with that fix? Hopefully I'll get that out by the end of today. > Crashes are very bad. Do you have any logs from those

RE: [PATCH v3] Added perf functionality to mmdc driver

2016-08-31 Thread Zhengyu Shen
> > Mmdc was only responsible for one crash which I fixed (had to remove > > the event from the pmu properly). > > Ok. I take it that there will be a v4 appearing shortly with that fix? Hopefully I'll get that out by the end of today. > Crashes are very bad. Do you have any logs from those

RE: [PATCH v3] Added perf functionality to mmdc driver

2016-08-30 Thread Zhengyu Shen
> Hi, > > On Tue, Aug 30, 2016 at 07:43:29PM +0800, Shawn Guo wrote: > > On Mon, Aug 29, 2016 at 11:06:44AM -0500, Zhi Li wrote: > > > On Wed, Aug 17, 2016 at 2:42 PM, Zhengyu Shen > <zhengyu.s...@nxp.com> wrote: > > > > MMDC is a multi-mode DDR contro

RE: [PATCH v3] Added perf functionality to mmdc driver

2016-08-30 Thread Zhengyu Shen
> Hi, > > On Tue, Aug 30, 2016 at 07:43:29PM +0800, Shawn Guo wrote: > > On Mon, Aug 29, 2016 at 11:06:44AM -0500, Zhi Li wrote: > > > On Wed, Aug 17, 2016 at 2:42 PM, Zhengyu Shen > wrote: > > > > MMDC is a multi-mode DDR controller that supports DDR3/D

[PATCH v3] Added perf functionality to mmdc driver

2016-08-18 Thread Zhengyu Shen
/ 427.76 MB mmdc/write-bytes/ 5.334757334 seconds time elapsed Signed-off-by: Zhengyu Shen <zhengyu.s...@nxp.com> Signed-off-by: Frank Li <frank...@nxp.com> --- Changes from v2 to v3: Use WARN_ONCE instead of returning generic error values Replace C

[PATCH v3] Added perf functionality to mmdc driver

2016-08-18 Thread Zhengyu Shen
/ 427.76 MB mmdc/write-bytes/ 5.334757334 seconds time elapsed Signed-off-by: Zhengyu Shen Signed-off-by: Frank Li --- Changes from v2 to v3: Use WARN_ONCE instead of returning generic error values Replace CPU Notifiers with newer state machine hotplug Added

RE: [PATCH v2] Added perf functionality to mmdc driver

2016-08-16 Thread Zhengyu Shen
> > > > + hrtimer_start(_mmdc->hrtimer, mmdc_timer_period(), > > > > + HRTIMER_MODE_REL_PINNED); > > > > > > Why is a hrtimer necessary? Is this just copy-pasted from CCN, or do > > > you have similar HW issues? > > > > > > Is there no overflow interrupt? > > > > When

RE: [PATCH v2] Added perf functionality to mmdc driver

2016-08-16 Thread Zhengyu Shen
> > > > + hrtimer_start(_mmdc->hrtimer, mmdc_timer_period(), > > > > + HRTIMER_MODE_REL_PINNED); > > > > > > Why is a hrtimer necessary? Is this just copy-pasted from CCN, or do > > > you have similar HW issues? > > > > > > Is there no overflow interrupt? > > > > When

RE: [PATCH v2] Added perf functionality to mmdc driver

2016-08-16 Thread Zhengyu Shen
> > Added cpumask and migration handling support to driver > > Validated event during event_init > > Added code to properly stop counters > > Used perf_invalid_context instead of perf_sw_context > > Added hrtimer to poll for overflow > > Added better description > >

RE: [PATCH v2] Added perf functionality to mmdc driver

2016-08-16 Thread Zhengyu Shen
> > Added cpumask and migration handling support to driver > > Validated event during event_init > > Added code to properly stop counters > > Used perf_invalid_context instead of perf_sw_context > > Added hrtimer to poll for overflow > > Added better description > >

[PATCH v2] Added perf functionality to mmdc driver

2016-08-15 Thread Zhengyu Shen
/ 427.76 MB mmdc/write-bytes/ 5.334757334 seconds time elapsed Signed-off-by: Zhengyu Shen <zhengyu.s...@nxp.com> --- change from v1 to v2: Added cpumask and migration handling support to driver Validated event during event_init Added code to properl

[PATCH v2] Added perf functionality to mmdc driver

2016-08-15 Thread Zhengyu Shen
/ 427.76 MB mmdc/write-bytes/ 5.334757334 seconds time elapsed Signed-off-by: Zhengyu Shen --- change from v1 to v2: Added cpumask and migration handling support to driver Validated event during event_init Added code to properly stop counters Used

[PATCH] Added perf functionality to mmdc driver

2016-08-06 Thread Zhengyu Shen
/ 14819600 mmdc/read-accesses/ 471.30 MB mmdc/read-bytes/ 2815419216 mmdc/total-cycles/ 13367354 mmdc/write-accesses/ 427.76 MB mmdc/write-bytes/ 5.334757334 seconds time elapsed Signed-off-by: Zhengyu Shen <zhengy

[PATCH] Added perf functionality to mmdc driver

2016-08-06 Thread Zhengyu Shen
/ 14819600 mmdc/read-accesses/ 471.30 MB mmdc/read-bytes/ 2815419216 mmdc/total-cycles/ 13367354 mmdc/write-accesses/ 427.76 MB mmdc/write-bytes/ 5.334757334 seconds time elapsed Signed-off-by: Zhengyu Shen --- arch/arm