On Wed, Apr 29, 2015 at 09:57:33PM +0200, Greg KH wrote:
> On Thu, Apr 30, 2015 at 12:21:32AM +0800, Zhuang Jin Can wrote:
> > On Wed, Apr 29, 2015 at 01:06:22PM +0200, Greg KH wrote:
> > > On Wed, Apr 29, 2015 at 06:57:30PM +0800, Zhuang Jin Can wrote:
> > > > On W
On Wed, Apr 29, 2015 at 09:57:33PM +0200, Greg KH wrote:
On Thu, Apr 30, 2015 at 12:21:32AM +0800, Zhuang Jin Can wrote:
On Wed, Apr 29, 2015 at 01:06:22PM +0200, Greg KH wrote:
On Wed, Apr 29, 2015 at 06:57:30PM +0800, Zhuang Jin Can wrote:
On Wed, Apr 29, 2015 at 11:01:48AM +0200, Greg
On Wed, Apr 29, 2015 at 01:06:22PM +0200, Greg KH wrote:
> On Wed, Apr 29, 2015 at 06:57:30PM +0800, Zhuang Jin Can wrote:
> > On Wed, Apr 29, 2015 at 11:01:48AM +0200, Greg KH wrote:
> > > On Wed, Apr 29, 2015 at 03:20:04PM +0800, Zhuang Jin Can wrote:
> > > > On T
On Wed, Apr 29, 2015 at 11:01:48AM +0200, Greg KH wrote:
> On Wed, Apr 29, 2015 at 03:20:04PM +0800, Zhuang Jin Can wrote:
> > On Tue, Apr 28, 2015 at 11:11:10PM +0200, Greg KH wrote:
> > > On Wed, Apr 29, 2015 at 12:51:27AM +0800, Zhuang Jin Can wrote:
> > > > Hi Gr
On Tue, Apr 28, 2015 at 11:11:10PM +0200, Greg KH wrote:
> On Wed, Apr 29, 2015 at 12:51:27AM +0800, Zhuang Jin Can wrote:
> > Hi Greg KH,
> >
> > On Tue, Apr 28, 2015 at 12:42:24PM +0200, Greg KH wrote:
> > > On Sun, Apr 19, 2015 at 11:46:12AM +0800, Zhuang Ji
On Wed, Apr 29, 2015 at 11:01:48AM +0200, Greg KH wrote:
On Wed, Apr 29, 2015 at 03:20:04PM +0800, Zhuang Jin Can wrote:
On Tue, Apr 28, 2015 at 11:11:10PM +0200, Greg KH wrote:
On Wed, Apr 29, 2015 at 12:51:27AM +0800, Zhuang Jin Can wrote:
Hi Greg KH,
On Tue, Apr 28, 2015
On Tue, Apr 28, 2015 at 11:11:10PM +0200, Greg KH wrote:
On Wed, Apr 29, 2015 at 12:51:27AM +0800, Zhuang Jin Can wrote:
Hi Greg KH,
On Tue, Apr 28, 2015 at 12:42:24PM +0200, Greg KH wrote:
On Sun, Apr 19, 2015 at 11:46:12AM +0800, Zhuang Jin Can wrote:
Some usb3 devices may
On Wed, Apr 29, 2015 at 01:06:22PM +0200, Greg KH wrote:
On Wed, Apr 29, 2015 at 06:57:30PM +0800, Zhuang Jin Can wrote:
On Wed, Apr 29, 2015 at 11:01:48AM +0200, Greg KH wrote:
On Wed, Apr 29, 2015 at 03:20:04PM +0800, Zhuang Jin Can wrote:
On Tue, Apr 28, 2015 at 11:11:10PM +0200, Greg
Hi Greg KH,
On Tue, Apr 28, 2015 at 12:42:24PM +0200, Greg KH wrote:
> On Sun, Apr 19, 2015 at 11:46:12AM +0800, Zhuang Jin Can wrote:
> > Some usb3 devices may not support usb3 lpm well.
> > The patch adds a sysfs to enable/disable u1 or u2 of the port.The
> > settings
Hi Greg KH,
On Tue, Apr 28, 2015 at 12:42:24PM +0200, Greg KH wrote:
On Sun, Apr 19, 2015 at 11:46:12AM +0800, Zhuang Jin Can wrote:
Some usb3 devices may not support usb3 lpm well.
The patch adds a sysfs to enable/disable u1 or u2 of the port.The
settings apply to both before and after
+ Mathias and David.
Hi Mathias,
Please help to review this patch.
Thanks
Jincan
On Sun, Apr 19, 2015 at 11:46:12AM +0800, Zhuang Jin Can wrote:
> Some usb3 devices may not support usb3 lpm well.
> The patch adds a sysfs to enable/disable u1 or u2 of the port.The
> settings appl
+ Mathias and David.
Hi Mathias,
Please help to review this patch.
Thanks
Jincan
On Sun, Apr 19, 2015 at 11:46:12AM +0800, Zhuang Jin Can wrote:
Some usb3 devices may not support usb3 lpm well.
The patch adds a sysfs to enable/disable u1 or u2 of the port.The
settings apply to both before
ly u2 is enabled, "u1_u2" - u1 and u2 are enabled.
The interface is useful for testing some USB3 devices during
development, and provides a way to disable usb3 lpm if the issues can
not be fixed in final products.
Signed-off-by: Zhuang Jin Can
---
Documentation/ABI/testing/sysfs-bus
are enabled.
The interface is useful for testing some USB3 devices during
development, and provides a way to disable usb3 lpm if the issues can
not be fixed in final products.
Signed-off-by: Zhuang Jin Can jin.can.zhu...@intel.com
---
Documentation/ABI/testing/sysfs-bus-usb | 10
drivers/usb
This revert a82b76f7fa6154e8ab2d8071842a3e38b9c0d0ff.
The commit causes an extra reset in remote wakeup as described in:
http://www.spinics.net/lists/linux-usb/msg119080.html
Signed-off-by: Zhuang Jin Can
---
drivers/usb/core/hub.c | 34 +-
1 file changed, 9
This revert a82b76f7fa6154e8ab2d8071842a3e38b9c0d0ff.
The commit causes an extra reset in remote wakeup as described in:
http://www.spinics.net/lists/linux-usb/msg119080.html
Signed-off-by: Zhuang Jin Can jin.can.zhu...@intel.com
---
drivers/usb/core/hub.c | 34
dep->endpoint.desc is checked at the beginning of
dwc3_gadget_ep_queue(), but after that it may be set to NULL
by another thread and then accessed again in dwc3_gadget_ep_queue().
This will lead to kernel oops.
Expand spinlock protection area to aviod race condition.
Signed-off-by: Zhuang
dep-endpoint.desc is checked at the beginning of
dwc3_gadget_ep_queue(), but after that it may be set to NULL
by another thread and then accessed again in dwc3_gadget_ep_queue().
This will lead to kernel oops.
Expand spinlock protection area to aviod race condition.
Signed-off-by: Zhuang Jin Can
Add usb_functionfs_descs_head_v2 structure for the new layout of
descriptors.
Signed-off-by: Zhuang Jin Can
---
include/uapi/linux/usb/functionfs.h |9 +
1 file changed, 9 insertions(+)
diff --git a/include/uapi/linux/usb/functionfs.h
b/include/uapi/linux/usb/functionfs.h
index
Add usb_functionfs_descs_head_v2 structure for the new layout of
descriptors.
Signed-off-by: Zhuang Jin Can jin.can.zhu...@intel.com
---
include/uapi/linux/usb/functionfs.h |9 +
1 file changed, 9 insertions(+)
diff --git a/include/uapi/linux/usb/functionfs.h
b/include/uapi/linux
Hi,
On Fri, May 16, 2014 at 07:41:06AM -0500, Felipe Balbi wrote:
> On Fri, May 16, 2014 at 11:50:13PM +0800, Zhuang Jin Can wrote:
> > > On Fri, May 16, 2014 at 05:57:57AM +0800, Zhuang Jin Can wrote:
> > > > In ISOC transfers, when free_slot points to the last TR
Hi,
On Fri, May 16, 2014 at 07:41:06AM -0500, Felipe Balbi wrote:
On Fri, May 16, 2014 at 11:50:13PM +0800, Zhuang Jin Can wrote:
On Fri, May 16, 2014 at 05:57:57AM +0800, Zhuang Jin Can wrote:
In ISOC transfers, when free_slot points to the last TRB (i.e. Link
TRB), and all queued
Hi
On Thu, May 15, 2014 at 10:37:57AM -0500, Felipe Balbi wrote:
> Hi
>
> On Fri, May 16, 2014 at 05:57:57AM +0800, Zhuang Jin Can wrote:
> > In ISOC transfers, when free_slot points to the last TRB (i.e. Link
> > TRB), and all queued requests meet Missed Interval
checks it before increasement.
free_slot should behave the same as busy_slot to make the trb_left
caculation correct.
Signed-off-by: Zhuang Jin Can
Signed-off-by: Jiebing Li
---
drivers/usb/dwc3/gadget.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/dwc3/gadg
increasement.
free_slot should behave the same as busy_slot to make the trb_left
caculation correct.
Signed-off-by: Zhuang Jin Can jin.can.zhu...@intel.com
Signed-off-by: Jiebing Li jiebing...@intel.com
---
drivers/usb/dwc3/gadget.c |8
1 file changed, 4 insertions(+), 4 deletions
Hi
On Thu, May 15, 2014 at 10:37:57AM -0500, Felipe Balbi wrote:
Hi
On Fri, May 16, 2014 at 05:57:57AM +0800, Zhuang Jin Can wrote:
In ISOC transfers, when free_slot points to the last TRB (i.e. Link
TRB), and all queued requests meet Missed Interval Isoc error, busy_slot
points to trb0
On Tue, May 13, 2014 at 10:05:34AM -0500, Felipe Balbi wrote:
> Hi,
>
> On Tue, May 13, 2014 at 09:45:51PM -0400, Zhuang Jin Can wrote:
> > Hi Balbi,
> >
> > Do you have any comment for this patch?
>
> do you have an easy test-case which I can use
Hi Balbi,
Do you have any comment for this patch?
Thanks
Jincan
On Wed, May 07, 2014 at 05:53:44PM -0400, Zhuang Jin Can wrote:
> A delayed status request may be queued before composite framework returns
> USB_GADGET_DELAYED_STATUS, because the thread queueing the request c
Hi Balbi,
Do you have any comment for this patch?
Thanks
Jincan
On Wed, May 07, 2014 at 05:53:44PM -0400, Zhuang Jin Can wrote:
A delayed status request may be queued before composite framework returns
USB_GADGET_DELAYED_STATUS, because the thread queueing the request can run
on a different
On Thu, May 08, 2014 at 11:22:36AM -0400, Alan Stern wrote:
> On Thu, 8 May 2014, Zhuang Jin Can wrote:
>
> > > dwc3 _cannot_ return NYET to a SETUP packet. The USB protocol does not
> > > allow it. A device must always respond to SETUP with ACK.
> > It true t
On Thu, May 08, 2014 at 10:25:46AM -0400, Alan Stern wrote:
> On Thu, 8 May 2014, Zhuang Jin Can wrote:
>
> > > When the host already timed out the control transfer and started a new
> > > one. Here's what I'm talking about:
> > >
> > >
On Thu, May 08, 2014 at 10:25:46AM -0400, Alan Stern wrote:
On Thu, 8 May 2014, Zhuang Jin Can wrote:
When the host already timed out the control transfer and started a new
one. Here's what I'm talking about:
Host sends a Set-Configuration request.
The UDC driver calls
On Thu, May 08, 2014 at 11:22:36AM -0400, Alan Stern wrote:
On Thu, 8 May 2014, Zhuang Jin Can wrote:
dwc3 _cannot_ return NYET to a SETUP packet. The USB protocol does not
allow it. A device must always respond to SETUP with ACK.
It true that device can not return NYET to a SETUP
On Wed, May 07, 2014 at 12:59:06PM -0400, Alan Stern wrote:
> On Thu, 8 May 2014, Zhuang Jin Can wrote:
>
> > > A similar problem can occur in the opposite sense: The thread queuing
> > > the delayed status request might be delayed for so long that another
> > > S
On Wed, May 07, 2014 at 11:03:42AM -0400, Alan Stern wrote:
> On Wed, 7 May 2014, Zhuang Jin Can wrote:
>
> > A delayed status request may be queued before composite framework returns
> > USB_GADGET_DELAYED_STATUS, because the thread queueing the request can run
>
STATUS XferNotReady IRQ
|
dwc3_ep0_xfernotready()
|
delayed_status is true, return;
The result is the status packet will never be transferred, and
delayed_status is not cleared.
Signed-off-by:
|
dwc3_ep0_xfernotready()
|
delayed_status is true, return;
The result is the status packet will never be transferred, and
delayed_status is not cleared.
Signed-off-by: Zhuang Jin Can
On Wed, May 07, 2014 at 11:03:42AM -0400, Alan Stern wrote:
On Wed, 7 May 2014, Zhuang Jin Can wrote:
A delayed status request may be queued before composite framework returns
USB_GADGET_DELAYED_STATUS, because the thread queueing the request can run
on a different core in parallel
On Wed, May 07, 2014 at 12:59:06PM -0400, Alan Stern wrote:
On Thu, 8 May 2014, Zhuang Jin Can wrote:
A similar problem can occur in the opposite sense: The thread queuing
the delayed status request might be delayed for so long that another
SETUP packet arrives from the host first
Hi,
On Thu, May 01, 2014 at 10:13:28AM -0500, Felipe Balbi wrote:
> On Thu, May 01, 2014 at 04:44:52PM -0400, Zhuang Jin Can wrote:
> > On Wed, Apr 30, 2014 at 02:58:29PM -0500, Felipe Balbi wrote:
> > > On Thu, May 01, 2014 at 02:36:08AM -0400, Zhuang Jin Can wrote:
> >
Hi,
On Thu, May 01, 2014 at 10:15:00AM -0500, Felipe Balbi wrote:
> On Thu, May 01, 2014 at 09:45:17AM -0400, Alan Stern wrote:
> > On Thu, 1 May 2014, Zhuang Jin Can wrote:
> > > > again, you found a bug on the gadget driver. Fix that. composite.c
> > > > gu
Hi,
On Thu, May 01, 2014 at 10:15:00AM -0500, Felipe Balbi wrote:
On Thu, May 01, 2014 at 09:45:17AM -0400, Alan Stern wrote:
On Thu, 1 May 2014, Zhuang Jin Can wrote:
again, you found a bug on the gadget driver. Fix that. composite.c
guarantees that for those functions which don't
Hi,
On Thu, May 01, 2014 at 10:13:28AM -0500, Felipe Balbi wrote:
On Thu, May 01, 2014 at 04:44:52PM -0400, Zhuang Jin Can wrote:
On Wed, Apr 30, 2014 at 02:58:29PM -0500, Felipe Balbi wrote:
On Thu, May 01, 2014 at 02:36:08AM -0400, Zhuang Jin Can wrote:
At least we should giveback
On Wed, Apr 30, 2014 at 03:03:53PM -0500, Felipe Balbi wrote:
> On Thu, May 01, 2014 at 03:16:04AM -0400, Zhuang Jin Can wrote:
> > endpoint.maxburst may be 0 if a gadget doesn't call config_ep_by_speed()
> > to update it from the companion descriptor.
> > And endpoint.maxbur
Hi Balbi,
On Wed, Apr 30, 2014 at 02:58:29PM -0500, Felipe Balbi wrote:
> On Thu, May 01, 2014 at 02:36:08AM -0400, Zhuang Jin Can wrote:
> > At least we should giveback the current request to the
> > gadget. Otherwise, the gadget will be stuck without knowi
Hi Balbi,
On Wed, Apr 30, 2014 at 02:58:29PM -0500, Felipe Balbi wrote:
On Thu, May 01, 2014 at 02:36:08AM -0400, Zhuang Jin Can wrote:
At least we should giveback the current request to the
gadget. Otherwise, the gadget will be stuck without knowing
anything.
It was oberved
On Wed, Apr 30, 2014 at 03:03:53PM -0500, Felipe Balbi wrote:
On Thu, May 01, 2014 at 03:16:04AM -0400, Zhuang Jin Can wrote:
endpoint.maxburst may be 0 if a gadget doesn't call config_ep_by_speed()
to update it from the companion descriptor.
And endpoint.maxburst - 1 returns 1b which
can't get the corret endpoint state and "Set Endpoint Config"
command can't restore the correct endpoint state during hibernation
resume flow.
Thus, when endpoint.maxburst is 0, we should set burst as 0 directly.
Signed-off-by: Zhuang Jin Can
---
drivers/usb/dwc3/gadget.c |3 ++
At least we should giveback the current request to the
gadget. Otherwise, the gadget will be stuck without knowing
anything.
It was oberved that the failure can happen if the request is
queued when the run/stop bit of controller is not set.
Signed-off-by: Zhuang Jin Can
---
drivers/usb/dwc3
On Wed, Apr 30, 2014 at 12:14:42PM -0500, Felipe Balbi wrote:
> sorry but your patch is not good for acceptance in mainline.
>
Thanks your time.
Jincan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More
Hi,
On Tue, Apr 29, 2014 at 11:10:42AM -0500, Felipe Balbi wrote:
> Hi,
>
> On Tue, Apr 29, 2014 at 05:21:42PM -0400, Zhuang Jin Can wrote:
> > On Mon, Apr 28, 2014 at 10:55:36AM -0500, Felipe Balbi wrote:
> > > On Mon, Apr 28, 2014 at 04:49:23PM -0400, Zhuang Jin
Hi,
On Tue, Apr 29, 2014 at 11:10:42AM -0500, Felipe Balbi wrote:
Hi,
On Tue, Apr 29, 2014 at 05:21:42PM -0400, Zhuang Jin Can wrote:
On Mon, Apr 28, 2014 at 10:55:36AM -0500, Felipe Balbi wrote:
On Mon, Apr 28, 2014 at 04:49:23PM -0400, Zhuang Jin Can wrote:
Adds a debugfs file
On Wed, Apr 30, 2014 at 12:14:42PM -0500, Felipe Balbi wrote:
sorry but your patch is not good for acceptance in mainline.
Thanks your time.
Jincan
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo
At least we should giveback the current request to the
gadget. Otherwise, the gadget will be stuck without knowing
anything.
It was oberved that the failure can happen if the request is
queued when the run/stop bit of controller is not set.
Signed-off-by: Zhuang Jin Can jin.can.zhu...@intel.com
the corret endpoint state and Set Endpoint Config
command can't restore the correct endpoint state during hibernation
resume flow.
Thus, when endpoint.maxburst is 0, we should set burst as 0 directly.
Signed-off-by: Zhuang Jin Can jin.can.zhu...@intel.com
---
drivers/usb/dwc3/gadget.c |3 ++-
1
On Mon, Apr 28, 2014 at 10:55:36AM -0500, Felipe Balbi wrote:
> On Mon, Apr 28, 2014 at 04:49:23PM -0400, Zhuang Jin Can wrote:
> > Adds a debugfs file "snapshot" to dump dwc3 requests, trbs and events.
>
> you need to explain what are you trying to provide to our users
On Mon, Apr 28, 2014 at 10:55:36AM -0500, Felipe Balbi wrote:
On Mon, Apr 28, 2014 at 04:49:23PM -0400, Zhuang Jin Can wrote:
Adds a debugfs file snapshot to dump dwc3 requests, trbs and events.
you need to explain what are you trying to provide to our users here.
What problem are you
57 matches
Mail list logo
